[Qemu-devel] [PULL 26/33] spapr: move lookup of the node into spapr_memory_plug()

2018-06-12 Thread David Gibson
From: David Hildenbrand Let's clean the hotplug handler up by moving lookup of the node into the function where it is actually being used. Signed-off-by: David Hildenbrand Reviewed-by: Greg Kurz Signed-off-by: David Gibson --- hw/ppc/spapr.c | 12 +--- 1 file changed, 5 insertions(+)

[Qemu-devel] [PULL 19/33] cuda: embed mos6522_cuda device directly rather than using QOM object link

2018-06-12 Thread David Gibson
From: Mark Cave-Ayland Examining the migration stream it can be seen that the mos6522 device state is being stored separately rather than as part of the CUDA device which is incorrect (and likely to cause issues if another mos6522 device is added to the machine). Resolve this by embedding the mo

[Qemu-devel] [PULL 15/33] ppc: remove obsolete pci_pmac_init() definitions from mac.h

2018-06-12 Thread David Gibson
From: Mark Cave-Ayland Commits 7b19318bee and 8ce3f743c7 removed the pci_pmac_init() and pci_pmac_u3_init() functions but missed the header prototypes in mac.h. Remove them since they are no longer needed. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David

[Qemu-devel] [PULL 17/33] ppc: add missing FW_CFG_PPC_NVRAM_FLAT definition

2018-06-12 Thread David Gibson
From: Mark Cave-Ayland This is used in OpenBIOS to define the memory layout of the NVRAM device. Whilst currently left at its default value, add the missing definition to ensure it is reserved. Signed-off-by: Mark Cave-Ayland Signed-off-by: David Gibson --- include/hw/ppc/ppc.h | 1 + 1 file

[Qemu-devel] [PULL 31/33] ppc/pnv: fix LPC HC firmware address space

2018-06-12 Thread David Gibson
From: Cédric Le Goater A specific MemoryRegion is required for the LPC HC Firmware address space. Signed-off-by: Cédric Le Goater Signed-off-by: David Gibson --- hw/ppc/pnv_lpc.c | 4 +++- include/hw/ppc/pnv_lpc.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/hw

[Qemu-devel] [PULL 27/33] spapr: move memory hotplug support check into spapr_memory_pre_plug()

2018-06-12 Thread David Gibson
From: David Hildenbrand Let's finish cleaning up the hotplug handler. This check can be performed in the pre_plug code as the very first thing. Signed-off-by: David Hildenbrand Reviewed-by: Greg Kurz Signed-off-by: David Gibson --- hw/ppc/spapr.c | 13 ++--- 1 file changed, 6 inserti

[Qemu-devel] [PULL 14/33] hw/misc/mos6522: Add trailing '\n' to qemu_log() calls

2018-06-12 Thread David Gibson
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: David Gibson --- hw/misc/mos6522.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/mos6522.c b/hw/misc/mos6522.c index 6163cea6ab..49166cb8ad 100644 --- a/hw/misc/mos6522.c +++ b/h

[Qemu-devel] [PULL 23/33] ppc4xx_i2c: Clean up and improve error logging

2018-06-12 Thread David Gibson
From: BALATON Zoltan Make it more readable by converting register indexes to decimal (avoids lot of superfluous 0x0) and distinguish errors caused by accessing non-existent vs. unimplemented registers. No functional change. Signed-off-by: BALATON Zoltan Signed-off-by: David Gibson --- hw/i2c/

[Qemu-devel] [PULL 28/33] spapr: introduce machine unplug handler

2018-06-12 Thread David Gibson
From: David Hildenbrand We'll be handling unplug of e.g. CPUs and PCDIMMs via the general hotplug handler soon, so let's add that handler function. Acked-by: David Gibson Reviewed-by: Greg Kurz Signed-off-by: David Hildenbrand Signed-off-by: David Gibson --- hw/ppc/spapr.c | 6 ++ 1 fi

[Qemu-devel] [PATCH] docs: Grammar and spelling fixes

2018-06-12 Thread Ville Skyttä
Signed-off-by: Ville Skyttä Reviewed-by: Peter Maydell Reviewed-by: Eric Blake --- docs/colo-proxy.txt | 2 +- docs/config/mach-virt-graphical.cfg | 2 +- docs/config/mach-virt-serial.cfg | 2 +- docs/config/q35-emulated.cfg | 2 +- docs/config/q35-virtio-graphical

[Qemu-devel] [PULL 22/33] target/ppc: extend eieio for POWER9

2018-06-12 Thread David Gibson
From: Cédric Le Goater POWER9 introduced a new variant of the eieio instruction using bit 6 as a hint to tell the CPU it is a store-forwarding barrier. The usage of this eieio extension was recently added in Linux 4.17 which activated the "support for a store forwarding barrier at kernel entry/e

[Qemu-devel] [PULL 25/33] spapr: no need to verify the node

2018-06-12 Thread David Gibson
From: David Hildenbrand The node property can always be queried and the value has already been verified in pc_dimm_realize(). Acked-by: David Gibson Reviewed-by: Greg Kurz Signed-off-by: David Hildenbrand Signed-off-by: David Gibson --- hw/ppc/spapr.c | 10 ++ 1 file changed, 2 inse

[Qemu-devel] [PULL 29/33] spapr: handle pc-dimm unplug via hotplug handler chain

2018-06-12 Thread David Gibson
From: David Hildenbrand Factor out memory unplug into separate function from spapr_lmb_release(). Then use generic hotplug_handler_unplug() to trigger memory unplug, which will call spapr_machine_device_unplug() -> spapr_memory_unplug() in the end. This way unplug operation is not buried in lmb

Re: [Qemu-devel] Is there a way to package QEMU binaries?

2018-06-12 Thread Peter Xu
On Tue, Jun 12, 2018 at 02:41:19PM +0800, Fam Zheng wrote: > On Tue, 06/12 14:24, Peter Xu wrote: > > Hi, > > > > For example, I wanted to compile QEMU once and install it on multiple > > systems. What would be the suggested way to do so? > > > > Is there something similar to "make bin-rpmpkg" f

Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name

2018-06-12 Thread Paolo Bonzini
On 11/06/2018 22:37, Eduardo Habkost wrote: > RFC NOTE: Paolo, Richard, as far as I can see, there's no point > in enabling OSPKE in user-mode QEMU. Do you confirm that? > > OSPKE is not a static feature flag: it changes dynamically at > runtime depending on CR4, and it was never configurable: KV

Re: [Qemu-devel] [PATCH v4] cutils: Provide strchrnul

2018-06-12 Thread Markus Armbruster
Keno Fischer writes: >> Suggest return strchrnul("Hello World", 'W') != 6, to avoid worries >> about a sufficiently smart compilers optimizing out a call that would >> otherwise fail to link, say because headers don't match libraries. > > I'm happy to do that, but then again, a sufficiently smart

[Qemu-devel] [PULL 21/33] mos6522: convert VMSTATE_TIMER_PTR_TEST to VMSTATE_TIMER_PTR

2018-06-12 Thread David Gibson
From: Mark Cave-Ayland The timers are configured in the mos6522 init function and therefore will always exist, so the function can never return false. Peter also pointed out that this is the only remaining user of VMSTATE_TIMER_PTR_TEST in the codebase, so we might as well just convert it over t

[Qemu-devel] [PULL 24/33] target/ppc: Allow PIR read in privileged mode

2018-06-12 Thread David Gibson
From: luporl According to PowerISA, the PIR register should be readable in privileged mode also, not only in hypervisor privileged mode. PowerISA 3.0 - 4.3.3 Processor Identification Register "Read access to the PIR is privileged; write access is not provided." Figure 18 in section 4.4.4 expli

[Qemu-devel] [PATCH 2/3] aspeed/smc: fix HW strapping

2018-06-12 Thread Cédric Le Goater
Only the flash type is strapped by HW. The 4BYTE mode is set by firmware when the flash device is detected. Signed-off-by: Cédric Le Goater --- hw/ssi/aspeed_smc.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index fce126e6e

Re: [Qemu-devel] [PATCH] docs: Grammar and spelling fixes

2018-06-12 Thread Ville Skyttä
On Tue, Jun 12, 2018 at 1:00 AM, Eric Blake wrote: > On 06/11/2018 03:25 PM, Ville Skyttä wrote: >> >> Signed-off-by: Ville Skyttä >> --- > [...] > >> +++ b/docs/interop/qcow2.txt >> @@ -326,7 +326,7 @@ in the image file. >> It contains pointers to the second level structures which are called >

Re: [Qemu-devel] Is there a way to package QEMU binaries?

2018-06-12 Thread Fam Zheng
On Tue, 06/12 14:52, Peter Xu wrote: > On Tue, Jun 12, 2018 at 02:41:19PM +0800, Fam Zheng wrote: > > On Tue, 06/12 14:24, Peter Xu wrote: > > > Hi, > > > > > > For example, I wanted to compile QEMU once and install it on multiple > > > systems. What would be the suggested way to do so? > > > >

[Qemu-devel] [PULL 33/33] spapr_pci: Remove unhelpful pagesize warning

2018-06-12 Thread David Gibson
By default, the IOMMU model built into the spapr virtual PCI host bridge supports 4kiB and 64kiB IOMMU page sizes. However this can be overridden which may be desirable to allow larger IOMMU page sizes when running a guest with hugepage backing and passthrough devices. For that reason a warning w

[Qemu-devel] [PULL 32/33] xics_kvm: use KVM helpers

2018-06-12 Thread David Gibson
From: Cédric Le Goater The KVM helpers hide the low level interface used to communicate to the XICS KVM device and provide a good cleanup to the XICS KVM models. Signed-off-by: Cédric Le Goater Signed-off-by: David Gibson --- hw/intc/xics_kvm.c | 52 +--

[Qemu-devel] [PATCH 1/3] aspeed/smc: fix dummy cycles count when in dual IO mode

2018-06-12 Thread Cédric Le Goater
When configured in dual I/O mode, address and data are sent in dual mode, including the dummy byte cycles in between. Adapt the count to the IO setting. Signed-off-by: Cédric Le Goater --- hw/ssi/aspeed_smc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/ssi/aspe

Re: [Qemu-devel] [PATCH v3 4/7] qmp: enable query-[chardev|version|name|uuid|iothreads|memdev] commands in preconfig state

2018-06-12 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert (git)" writes: >> >> > From: Igor Mammedov >> > >> > subj commands, are informational and do not depend on machine being >> > initialized. Make them available early in preconfig runstat

[Qemu-devel] [Bug 1769053] Re: Ability to control phys-bits through libvirt

2018-06-12 Thread  Christian Ehrhardt 
** Merge proposal unlinked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/347796 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1769053 Title: Ability to control phys-

[Qemu-devel] [PATCH 3/3] aspeed/smc: rename aspeed_smc_flash_send_addr() to aspeed_smc_flash_setup()

2018-06-12 Thread Cédric Le Goater
Also handle the fake transfers for dummy bytes in this setup routine. It will be useful when we activate MMIO execution. Signed-off-by: Cédric Le Goater --- hw/ssi/aspeed_smc.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/hw/ssi/aspeed_smc

[Qemu-devel] [PATCH 0/3] aspeed/smc: small fixes

2018-06-12 Thread Cédric Le Goater
Hello, Here is a short series of cleanups and fixes for issues in the Aspeed SMC controller model discovered when experimenting with the MMIO exec feature and also from tests under a QEMU PowerNV machine. Indeed, the OPAL/skiboot firmware accesses the Aspeed SoC address space using the iLPC->AHB

[Qemu-devel] [Bug 1769053] Re: Ability to control phys-bits through libvirt

2018-06-12 Thread  Christian Ehrhardt 
** Merge proposal unlinked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/347801 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1769053 Title: Ability to control phys-

Re: [Qemu-devel] [PATCH v3 2/7] hmp: Allow help on preconfig commands

2018-06-12 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * Markus Armbruster (arm...@redhat.com) wrote: >> >> "Dr. David Alan Gilbert (git)" writes: >> >> >> >> > From: "Dr. David Alan Gilbert" >> >> > >> >> > Allow the 'he

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-12 Thread Markus Armbruster
Igor Mammedov writes: > On Mon, 11 Jun 2018 15:40:16 -0300 > Eduardo Habkost wrote: > >> On Mon, Jun 11, 2018 at 02:01:52PM +0200, Markus Armbruster wrote: >> > * Eduardo, why does "info numa" have no QMP equivalent? >> >> Nobody ever asked for one, which seems to qualify as "only for >> human

Re: [Qemu-devel] [PATCH v2 1/1] s390x/ipl: Try to detect Linux vs non Linux for initial IPL PSW

2018-06-12 Thread Christian Borntraeger
On 06/11/2018 06:16 PM, Thomas Huth wrote: > On 11.06.2018 15:52, Christian Borntraeger wrote: >> Right now the IPL device always starts from address 0x1 (the usual >> Linux entry point). To run other guests (e.g. test programs) it is >> useful to use the IPL PSW from address 0. We can use t

[Qemu-devel] [Bug 1769053] Re: Ability to control phys-bits through libvirt

2018-06-12 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/347796 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1769053 Title: Ability to control phys-bi

[Qemu-devel] [Bug 1769053] Re: Ability to control phys-bits through libvirt

2018-06-12 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/347801 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1769053 Title: Ability to control phys-bi

Re: [Qemu-devel] [qemu-s390x] [PATCH v2] hw/s390x/ipl: Fix crashes that occurs when -kernel is used with small images

2018-06-12 Thread Christian Borntraeger
On 06/11/2018 07:26 PM, Thomas Huth wrote: > Add a sanity checks to fix the following two crashes: > > $ echo "Insane in the mainframe" > /tmp/test.txt > $ s390x-softmmu/qemu-system-s390x -kernel /tmp/test.txt -append xyz > Segmentation fault (core dumped) > $ s390x-softmmu/qemu-system-s390x -k

Re: [Qemu-devel] Is there a way to package QEMU binaries?

2018-06-12 Thread Peter Xu
On Tue, Jun 12, 2018 at 03:01:52PM +0800, Fam Zheng wrote: > On Tue, 06/12 14:52, Peter Xu wrote: > > On Tue, Jun 12, 2018 at 02:41:19PM +0800, Fam Zheng wrote: > > > On Tue, 06/12 14:24, Peter Xu wrote: > > > > Hi, > > > > > > > > For example, I wanted to compile QEMU once and install it on multi

[Qemu-devel] Questions about qemu enabling TCI

2018-06-12 Thread yt zhang
Dear technicians, Good day. I encountered some problems in the process of learning qemu, so I would like to ask technical staff. QEMU is running User Model mode and enables TCI function. What is the workflow of qemu at TCG and TCI stages? Is there a related program flow diagram? Thanks &

Re: [Qemu-devel] [PATCH v8 4/6] migration/ram.c: add ram save state notifiers

2018-06-12 Thread Peter Xu
On Fri, Jun 08, 2018 at 04:10:41PM +0800, Wei Wang wrote: > This patch adds a ram save state notifier list, and expose RAMState for > the notifer callbacks to use. > > Signed-off-by: Wei Wang > CC: Dr. David Alan Gilbert > CC: Juan Quintela > CC: Michael S. Tsirkin > CC: Peter Xu > --- > inc

Re: [Qemu-devel] Is there a way to package QEMU binaries?

2018-06-12 Thread Liviu Ionescu
On 12 June 2018 at 10:44:09, Peter Xu (pet...@redhat.com) wrote: > But it'll still be good if we can have a single package to play around > with. If there is no known way to do, we can try to figure a way out. you can take a look at: https://github.com/gnu-mcu-eclipse/qemu-build the scripts can

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-12 Thread Daniel P . Berrangé
On Mon, Jun 11, 2018 at 11:33:42PM +0200, Igor Mammedov wrote: > On Mon, 11 Jun 2018 15:40:16 -0300 > Eduardo Habkost wrote: > > > On Mon, Jun 11, 2018 at 02:01:52PM +0200, Markus Armbruster wrote: > > > * Eduardo, why does "info numa" have no QMP equivalent? > > > > Nobody ever asked for one, w

Re: [Qemu-devel] [PATCH] Remove COPYING.PYTHON

2018-06-12 Thread Daniel P . Berrangé
On Mon, Jun 11, 2018 at 03:01:52PM -0300, Eduardo Habkost wrote: > The COPYING.PYTHON file was added when we added the compatibility > argparse.py module, which was licensed under the Python Software > Foundation License Version 2. > > Now the compatibility argparse.py module was removed, and we a

[Qemu-devel] [Bug 1769053] Re: Ability to control phys-bits through libvirt

2018-06-12 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/347801 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1769053 Title: Ability to control phys-bi

Re: [Qemu-devel] [PATCH v2 04/10] qapi: Formalize qcow2 encryption probing

2018-06-12 Thread Daniel P . Berrangé
On Mon, Jun 11, 2018 at 10:51:57PM +0200, Max Reitz wrote: > Currently, you can give no encryption format for a qcow2 file while > still passing a key-secret. That does not conform to the schema, so > this patch changes the schema to allow it. > > Signed-off-by: Max Reitz > --- > qapi/block-cor

Re: [Qemu-devel] [PATCH v2 05/10] qapi: Formalize qcow encryption probing

2018-06-12 Thread Daniel P . Berrangé
On Mon, Jun 11, 2018 at 10:51:58PM +0200, Max Reitz wrote: > qcow only supports a single encryption (and there is no reason why that > would change in the future), so we can make it the default. > > Signed-off-by: Max Reitz > --- > qapi/block-core.json | 3 ++- > 1 file changed, 2 insertions(+),

[Qemu-devel] [PATCH v2 0/4] ARM SMMUv3: IOTLB Emulation and VHOST Support

2018-06-12 Thread Eric Auger
This series brings translation configuration caching and IOTLB emulation. The last patch implements VHOST integration and allows to run VSMMUv3 along with VHOST emulated end points. The first patch fixes the passthrough mode bug reported by Jia. It reworks the translate function and this series n

Re: [Qemu-devel] [PATCH v2 10/10] iotests: qcow2's encrypt.format is now optional

2018-06-12 Thread Daniel P . Berrangé
On Mon, Jun 11, 2018 at 10:52:03PM +0200, Max Reitz wrote: > Remove the encrypt.format option from the two blockdev-add test cases > for encrypted qcow2 images in 087 to explicitly test that this parameter > is now optional. > > Additionally, show that explicitly specifying encrypt.format=auto wor

[Qemu-devel] [PATCH v2 4/4] hw/arm/smmuv3: Add notifications on invalidation

2018-06-12 Thread Eric Auger
On TLB invalidation commands, let's call registered IOMMU notifiers. Those can only be UNMAP notifiers. SMMUv3 does not support notification on MAP (VFIO). This patch allows vhost use case where IOTLB API is notified on each guest IOTLB invalidation. Signed-off-by: Eric Auger --- hw/arm/smmu-co

[Qemu-devel] [PATCH v2 2/4] hw/arm/smmuv3: Cache/invalidate config data

2018-06-12 Thread Eric Auger
Let's cache config data to avoid fetching and parsing STE/CD structures on each translation. We invalidate them on data structure invalidation commands. We put in place a per-smmu mutex to protect the config cache. This will be useful too to protect the IOTLB cache. The caches can be accessed with

[Qemu-devel] [PATCH v2 1/4] hw/arm/smmuv3: Fix translate error handling

2018-06-12 Thread Eric Auger
From: Jia He In case the STE's config is "Bypass" we currently don't set the IOMMUTLBEntry perm flags and the access does not succeed. Also if the config is 0b0xx (Aborted/Reserved), decode_ste and smmuv3_decode_config currently returns -EINVAL and we don't enter the expected code path: we record

[Qemu-devel] [PATCH v2 3/4] hw/arm/smmuv3: IOTLB emulation

2018-06-12 Thread Eric Auger
We emulate a TLB cache of size SMMU_IOTLB_MAX_SIZE=256. It is implemented as a hash table whose key is a combination of the 16b asid and 48b IOVA (Jenkins hash). Entries are invalidated on TLB invalidation commands, either globally, or per asid, or per asid/iova. Signed-off-by: Eric Auger ---

Re: [Qemu-devel] [PATCH] hw/arm/smmuv3: Fix translate error handling

2018-06-12 Thread Auger Eric
Hi, On 06/08/2018 08:57 AM, Eric Auger wrote: > From: Jia He > > In case the STE's config is "Bypass" we currently don't set the > IOMMUTLBEntry perm flags and the access does not succeed. Also > if the config is 0b0xx (Aborted/Reserved), decode_ste and > smmuv3_decode_config currently returns -

[Qemu-devel] [PATCH] travis: display config.log when configure fails

2018-06-12 Thread Daniel P . Berrangé
When configure fails in CI systems we must be able to see the contents of the config.log file to diagnose the root cause. Signed-off-by: Daniel P. Berrangé --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 814be151f4..fc9a1fe8

[Qemu-devel] [Bug 1769053] Re: Ability to control phys-bits through libvirt

2018-06-12 Thread  Christian Ehrhardt 
** Merge proposal unlinked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/347801 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1769053 Title: Ability to control phys-

Re: [Qemu-devel] [PATCH] travis: display config.log when configure fails

2018-06-12 Thread Fam Zheng
On Tue, 06/12 09:28, Daniel P. Berrangé wrote: > When configure fails in CI systems we must be able to see the contents > of the config.log file to diagnose the root cause. > > Signed-off-by: Daniel P. Berrangé > --- > .travis.yml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [Qemu-devel] [Qemu-discuss] Questions about qemu enabling TCI

2018-06-12 Thread Peter Maydell
On 12 June 2018 at 06:45, yt zhang wrote: > Dear technicians, > Good day. > I encountered some problems in the process of learning qemu, so I > would like to ask technical staff. > QEMU is running User Model mode and enables TCI function. What is the > workflow of qemu at TCG and TCI sta

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-12 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert (git)" writes: > >> > >> > From: "Dr. David Alan Gilbert" > >> > > >> > Allow a bunch of the info commands to be used in preconfig

[Qemu-devel] [PATCH v4 0/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-06-12 Thread Balamuruhan S
V4: Read the remaining ram after updating dirty pages count and reuse existing `remaining` field in ram_counters to hold ram_bytes_remaining() Thank you Laurent for your time and help to investigate and correct my changes. V3: * commit message to be updated with the changes done by the patch si

[Qemu-devel] [PATCH v4 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-06-12 Thread Balamuruhan S
expected_downtime value is not accurate with dirty_pages_rate * page_size, using ram_bytes_remaining() would yeild it resonable. consider to read the remaining ram just after having updated the dirty pages count later migration_bitmap_sync_range() in migration_bitmap_sync() and reuse the `remainin

Re: [Qemu-devel] Is there a way to package QEMU binaries?

2018-06-12 Thread Peter Maydell
On 12 June 2018 at 07:24, Peter Xu wrote: > For example, I wanted to compile QEMU once and install it on multiple > systems. What would be the suggested way to do so? For this, I would recommend using whatever the packaging format for those systems is. Eg for Debian use the existing Debian QEMU

[Qemu-devel] [RFC v2 0/3] pci_expander_brdige: Put pxb-pcie host bridge into separate pci domain

2018-06-12 Thread Zihan Yang
Hi all, after some delay, here is the v2 version of putting pxb host bridge into separate pci domain. Currently only q35 host bridge is allocated an item in MCFG table, all pxb host bridges stay within pci domain 0. This series of patches put each pxb host bridge in separate pci domain, allocating

[Qemu-devel] [RFC v2 1/3] pci_expander_bridge: add type TYPE_PXB_PCIE_HOST

2018-06-12 Thread Zihan Yang
The inner host bridge created by pxb-pcie is TYPE_PXB_PCI_HOST by default, add a new type TYPE_PXB_PCIE_HOST to better utilize the ECAM of PCIe Signed-off-by: Zihan Yang --- hw/pci-bridge/pci_expander_bridge.c | 118 ++-- 1 file changed, 114 insertions(+), 4 delet

[Qemu-devel] [RFC v2 3/3] acpi-build: describe new pci domain in AML

2018-06-12 Thread Zihan Yang
Describe new pci segments of host bridges in AML. The host bridge list is replaced by QTAILQ to let q35 host be processed first in every traverse Signed-off-by: Zihan Yang --- hw/i386/acpi-build.c | 69 ++- hw/pci/pci.c | 9 ---

Re: [Qemu-devel] [PULL 32/33] xics_kvm: use KVM helpers

2018-06-12 Thread Greg Kurz
On Tue, 12 Jun 2018 16:45:02 +1000 David Gibson wrote: > From: Cédric Le Goater > > The KVM helpers hide the low level interface used to communicate to > the XICS KVM device and provide a good cleanup to the XICS KVM models. > > Signed-off-by: Cédric Le Goater > Signed-off-by: David Gibson >

Re: [Qemu-devel] [libvirt] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig

2018-06-12 Thread Michal Privoznik
On 06/12/2018 12:36 AM, Eduardo Habkost wrote: > CCing libvir-list. > > On Mon, Jun 11, 2018 at 11:29:24PM +0200, Igor Mammedov wrote: >> On Mon, 11 Jun 2018 16:06:07 -0300 >> Eduardo Habkost wrote: >> >>> On Mon, Jun 11, 2018 at 03:16:25PM +0200, Igor Mammedov wrote: On Fri, 8 Jun 2018 10:2

[Qemu-devel] [PATCH v4 6/7] hmp: add exit_preconfig

2018-06-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add the exit_preconfig command to return to normality. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Reviewed-by: Igor Mammedov --- hmp-commands.hx | 19 +++ hmp.c | 8 hmp.h | 1 + 3 files changed, 2

[Qemu-devel] [PATCH v4 0/7] Reenable hmp for preconfig mode

2018-06-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Reenable HMP in preconfig mode; it's pretty easy and anyway I want to do a similar thing for OOB eventually. We'll want to enable more commands in preconfig mode to make it useful at some point. Dave v4 Fixes from Markus' review. Including enabling some mor

[Qemu-devel] [PATCH v4 1/7] hmp: Add flag for preconfig commands

2018-06-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add a flag to command definitions to allow them to be used in preconfig and check it. If users try to use commands that aren't available, tell them to use the exit_preconfig comand we're adding in a few patches. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: M

[Qemu-devel] [PATCH v4 3/7] hmp: Restrict auto-complete in preconfig

2018-06-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Don't show the commands that aren't available. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Reviewed-by: Igor Mammedov --- monitor.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 8ff0e2fc

[Qemu-devel] [PATCH v4 2/7] hmp: Allow help on preconfig commands

2018-06-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Allow the 'help' command in preconfig state but make it only list the preconfig commands. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Reviewed-by: Igor Mammedov --- hmp-commands.hx | 1 + monitor.c | 8 +++- 2 files changed, 8 insertio

[Qemu-devel] [PATCH v4 4/7] qmp: Enable a few commands in preconfig state

2018-06-12 Thread Dr. David Alan Gilbert (git)
From: Igor Mammedov Commands query-chardev, query-version, query-name, query-uuid, query-iothreads, query-memdev are informational and do not depend on the machine being initialized. Make them available in preconfig runstate to make the latter a little bit more useful. The generic qom commands d

Re: [Qemu-devel] KVM Forum 2018: Call For Participation

2018-06-12 Thread Daniel P . Berrangé
A friendly reminder that the deadline for abstract submission is end of day this Thursday, June 14th. On Thu, May 17, 2018 at 12:52:35PM +0200, Paolo Bonzini wrote: > > KVM Forum 2018: Call For Participation > October 24-26, 2018 -

[Qemu-devel] [PATCH v4 5/7] hmp: Add commands for preconfig

2018-06-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Allow a bunch of the info commands to be used in preconfig. version, chardev, name, uuid,memdev, iothreads Were enabled in QMP in the previous patch from Igor status, hotpluggable_cpus Was enabled in the original allow-preconfig series history is HMP specif

Re: [Qemu-devel] [PATCH v2] hw/s390x/ipl: Fix crashes that occurs when -kernel is used with small images

2018-06-12 Thread Cornelia Huck
On Mon, 11 Jun 2018 19:26:47 +0200 Thomas Huth wrote: I've tweaked $SUBJECT to hw/s390x/ipl: Fix crashes when using -kernel/-initrd with small images > Add a sanity checks to fix the following two crashes: Also, s/Add a sanity checks/Add sanity checks/ > > $ echo "Insane in the mainframe" >

[Qemu-devel] [PATCH v4 7/7] hmp: Allow HMP in preconfig state again

2018-06-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Now we can cope with preconfig in HMP, reenable by reverting commit 71dc578e116599ea73c8a2a4e693134702ec0e83. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Reviewed-by: Igor Mammedov --- monitor.c | 6 -- 1 file changed, 6 deletions(-) diff -

Re: [Qemu-devel] [PULL 32/33] xics_kvm: use KVM helpers

2018-06-12 Thread Cédric Le Goater
On 06/12/2018 11:16 AM, Greg Kurz wrote: > On Tue, 12 Jun 2018 16:45:02 +1000 > David Gibson wrote: > >> From: Cédric Le Goater >> >> The KVM helpers hide the low level interface used to communicate to >> the XICS KVM device and provide a good cleanup to the XICS KVM models. >> >> Signed-off-by:

Re: [Qemu-devel] [PULL 0/3] x86 queue, 2018-06-11

2018-06-12 Thread Peter Maydell
On 11 June 2018 at 18:23, Eduardo Habkost wrote: > The following changes since commit 0d2fa03dae4fbe185a082f361342b1e30aed4582: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180608' into staging (2018-06-08 > 16:26:51 +0100) > > are available in the Git repository

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-12 Thread Cornelia Huck
On Fri, 8 Jun 2018 17:51:27 +0200 Pierre Morel wrote: > On 08/06/2018 16:45, Cornelia Huck wrote: > > On Fri, 8 Jun 2018 15:13:28 +0200 > > Halil Pasic wrote: > > > >> On 06/08/2018 02:20 PM, Cornelia Huck wrote: > > My proposal is to do the same > > copying to scsw(r) again, which w

Re: [Qemu-devel] [PATCH 1/8] util: add helper APIs for dealing with inotify

2018-06-12 Thread Gerd Hoffmann
On Fri, Jun 08, 2018 at 06:09:26PM +0100, Daniel P. Berrangé wrote: > The inotify userspace API for reading events is quite horrible, so it is > useful to wrap it in a more friendly API to avoid duplicating code > across many users in QEMU. Reviewed-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH 2/8] hw/usb: switch MTP to use new inotify APIs

2018-06-12 Thread Gerd Hoffmann
On Fri, Jun 08, 2018 at 06:09:27PM +0100, Daniel P. Berrangé wrote: > The internal inotify APIs allow alot of conditional statements to be > cleared out, and provide a simpler callback for handling events. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Gerd Hoffmann

[Qemu-devel] [PATCH v3 1/1] s390x/ipl: Try to detect Linux vs non Linux for initial IPL PSW

2018-06-12 Thread Christian Borntraeger
Right now the IPL device always starts from address 0x1 (the usual Linux entry point). To run other guests (e.g. test programs) it is useful to use the IPL PSW from address 0. We can use the Linux magic at 0x10008 to decide. Signed-off-by: Christian Borntraeger --- v2->v3: - check for

[Qemu-devel] [PATCH] xics_kvm: fix a build break

2018-06-12 Thread Cédric Le Goater
On CentOS 7.5, gcc-4.8.5-28.el7_5.1.ppc64le fails to build QEMU due to : hw/intc/xics_kvm.c: In function ‘ics_set_kvm_state’: hw/intc/xics_kvm.c:281:13: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized] return ret; Fix the breakage and also

Re: [Qemu-devel] [PATCH] xics_kvm: fix a build break

2018-06-12 Thread Cédric Le Goater
Forget that patch its bogus. sending a v2. On 06/12/2018 12:08 PM, Cédric Le Goater wrote: > On CentOS 7.5, gcc-4.8.5-28.el7_5.1.ppc64le fails to build QEMU due to : > > hw/intc/xics_kvm.c: In function ‘ics_set_kvm_state’: > hw/intc/xics_kvm.c:281:13: error: ‘ret’ may be used uninitialized in

[Qemu-devel] [PATCH v2] xics_kvm: fix a build break

2018-06-12 Thread Cédric Le Goater
On CentOS 7.5, gcc-4.8.5-28.el7_5.1.ppc64le fails to build QEMU due to : hw/intc/xics_kvm.c: In function ‘ics_set_kvm_state’: hw/intc/xics_kvm.c:281:13: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized] return ret; Fix the breakage and also

Re: [Qemu-devel] [PATCH v3 1/1] s390x/ipl: Try to detect Linux vs non Linux for initial IPL PSW

2018-06-12 Thread David Hildenbrand
On 12.06.2018 12:04, Christian Borntraeger wrote: > Right now the IPL device always starts from address 0x1 (the usual > Linux entry point). To run other guests (e.g. test programs) it is > useful to use the IPL PSW from address 0. We can use the Linux magic > at 0x10008 to decide. > > Signed-

Re: [Qemu-devel] [PATCH v3 1/1] s390x/ipl: Try to detect Linux vs non Linux for initial IPL PSW

2018-06-12 Thread Thomas Huth
On 12.06.2018 12:04, Christian Borntraeger wrote: > Right now the IPL device always starts from address 0x1 (the usual > Linux entry point). To run other guests (e.g. test programs) it is > useful to use the IPL PSW from address 0. We can use the Linux magic > at 0x10008 to decide. > > Signed-

[Qemu-devel] [PULL 8/8] usb-mtp: Return error on suspicious TYPE_DATA packet from initiator

2018-06-12 Thread Gerd Hoffmann
From: Bandan Das CID 1390604 If the initiator sends a packet with TYPE_DATA set without initiating a CMD_GET_OBJECT_INFO first, then usb_mtp_get_data can trip on a null s->data_out. Signed-off-by: Bandan Das Message-Id: Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 5 + 1 file chan

[Qemu-devel] [PULL 5/8] object: fix OBJ_PROP_LINK_UNREF_ON_RELEASE ambivalence

2018-06-12 Thread Gerd Hoffmann
From: Marc-André Lureau A link property can be set during creation, with object_property_add_link() and later with object_property_set_link(). add_link() doesn't add a reference to the target object, while set_link() does. Furthemore, OBJ_PROP_LINK_UNREF_ON_RELEASE flags, set during add_link, s

[Qemu-devel] [PULL 7/8] usb-hcd-xhci-test: add a test for ccid hotplug

2018-06-12 Thread Gerd Hoffmann
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-id: 20180531195119.22021-5-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann --- tests/usb-hcd-xhci-test.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/usb-hcd-xhci-test.c b/tests/usb-hcd-xhci-test

[Qemu-devel] [PULL 2/8] usb: correctly handle Zero Length Packets

2018-06-12 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé USB Specification Revision 2.0, §5.5.3: The Data stage of a control transfer from an endpoint to the host is complete when the endpoint does one of the following: • Has transferred exactly the amount of data specified during the Setup stage • Transfers a packet

[Qemu-devel] [PULL 4/8] bus: do not unref the added child bus on realize

2018-06-12 Thread Gerd Hoffmann
From: Marc-André Lureau When the parent bus removes the child property, it takes care of removing the added reference, in object_finalize_child_property(). Signed-off-by: Marc-André Lureau Message-id: 20180531195119.22021-2-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/core/

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add an entry for qemu-options* files in main directory

2018-06-12 Thread Thomas Huth
On 11.06.2018 17:53, Markus Armbruster wrote: > Thomas Huth writes: > >> The file "qemu-options.h", "qemu-options.hx" and "qemu-options-wrapper.h" >> in the main directory are currently without maintainer according to our >> get_maintainers.pl script. Considering that the command line options are

[Qemu-devel] [PULL 6/8] usb-ccid: fix bus leak

2018-06-12 Thread Gerd Hoffmann
From: Marc-André Lureau qbus_create_inplace() creates a new reference in realize(), it must be released in unrealize(). Signed-off-by: Marc-André Lureau Message-id: 20180531195119.22021-4-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/usb/dev-smartcard-reader.c | 1 + 1 file

[Qemu-devel] [PULL 3/8] usb/dev-mtp: Fix use of uninitialized values

2018-06-12 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé This fixes: hw/usb/dev-mtp.c:971:5: warning: 4th function call argument is an uninitialized value trace_usb_mtp_op_get_partial_object(s->dev.addr, o->handle, o->path, c->argv[1], c->argv[2]);

[Qemu-devel] [PULL 0/8] Usb 20180612 patches

2018-06-12 Thread Gerd Hoffmann
The following changes since commit 2afc4e3df80d947dd1bd42ce80278f591b35c74a: Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2018-06-11' into staging (2018-06-11 15:31:20 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/usb-20180612-pu

[Qemu-devel] [PULL 1/8] usb: update docs

2018-06-12 Thread Gerd Hoffmann
xhci is rock solid meanwhile. So move it up in the docs and feature it as prefered usb host adapter, instead of the old shy version saying "you might want try ...". While being at it rework the text on ehci and companion controllers too. Signed-off-by: Gerd Hoffmann Reviewed-by: Markus Armbrust

Re: [Qemu-devel] [PULL 0/1] Machine queue, 2018-06-11

2018-06-12 Thread Peter Maydell
On 11 June 2018 at 18:34, Eduardo Habkost wrote: > The following changes since commit 9f55925b8f50a962d1d08d815044db7767ae3838: > > Merge remote-tracking branch > 'remotes/vivier/tags/m68k-for-3.0-pull-request' into staging (2018-06-11 > 12:46:16 +0100) > > are available in the Git repository

[Qemu-devel] [PULL 5/8] linux-user/alpha: Fix epoll syscalls

2018-06-12 Thread Laurent Vivier
From: Richard Henderson These were named incorrectly, going so far as to invade strace.list. Signed-off-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id: <20180607184844.30126-2-richard.hender...@linaro.org> [lv: replace tabs by spaces] Signed-off-by: Laurent Vivier --- linux-use

[Qemu-devel] [PULL 2/8] linux-user: Use is_error() to avoid warnings and make the code clearer

2018-06-12 Thread Laurent Vivier
From: Philippe Mathieu-Daudé This fixes: linux-user/flatload.c:740:9: warning: Loss of sign in implicit conversion if (res > (unsigned long)-4096) ^~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-Id: <2018060415

[Qemu-devel] [PULL 3/8] linux-user: disable qemu-bridge-helper and socket_scm_helper build

2018-06-12 Thread Laurent Vivier
linux-user targets don't need them, and if we ask to build statically linked binaries, some static libraries they need are not available. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell Message-Id: <20180605160958.5434-1-laur...@vivier.eu> --- Makefile | 2 +- tests/Makef

[Qemu-devel] [PULL 4/8] qemu-binfmt-conf.sh: ignore the OS/ABI field

2018-06-12 Thread Laurent Vivier
Most of the binaries have a value of "UNIX - System V" for the OS/ABI. But cc1 has a value of "UNIX - GNU", and if we don't update the binfmt mask to ignore the OS/ABI field, gcc fails to execute it: gcc: error trying to exec '/usr/lib/gcc/m68k-linux-gnu/7/cc1': execv: Exec format error Signed-

  1   2   3   4   >