On 2018年06月11日 14:46, Zhang Chen wrote:
On Mon, Jun 11, 2018 at 9:56 AM, Jason Wang wrote:
On 2018年06月10日 22:09, Zhang Chen wrote:
I think when COLO is enabled, qemu should reject all other types of
backends.
Yes, you are right.
May be we should add a assert here? Because we can not g
If user forgets to provide any backend types for '-netdev' in qemu CLI,
It triggers seg fault.
e.g.
Expected:
$ qemu -netdev id=net0
qemu-system-x86_64: Parameter 'type' is missing
Actual:
$ qemu -netdev id=net0
Segmentation fault (core dumped)
Signed-off-by: Lin Ma
---
net/net.c | 9 ++--
Philippe Mathieu-Daudé writes:
> Hi Alex,
>
> On 06/08/2018 09:33 AM, Alex Bennée wrote:
>> One problem with satisfying your docker dependencies in a sub-make it
>> you might end up trying to satisfy the dependency multiple times. This
>> is especially a problem with debian-sid based cross comp
Philippe Mathieu-Daudé writes:
> On 06/08/2018 09:33 AM, Alex Bennée wrote:
>> One problem with satisfying your docker dependencies in a sub-make it
>> you might end up trying to satisfy the dependency multiple times. This
>> is especially a problem with debian-sid based cross compilers and CI
As qemu_new_net_client create new ncs but error happens later,
ncs will be left in global net_clients list, so we need to cleanup them.
Signed-off-by: linzhecheng
diff --git a/net/vhost-user.c b/net/vhost-user.c
index 608b837175..1c7ee48b60 100644
--- a/net/vhost-user.c
+++ b/net/vhost-user.c
@@
On Mon, Jun 04, 2018 at 05:55:09PM +0800, guangrong.x...@gmail.com wrote:
> From: Xiao Guangrong
>
> Instead of putting the main thread to sleep state to wait for
> free compression thread, we can directly post it out as normal
> page that reduces the latency and uses CPUs more efficiently
The f
On 11.06.2018 09:06, Lin Ma wrote:
> If user forgets to provide any backend types for '-netdev' in qemu CLI,
> It triggers seg fault.
>
> e.g.
>
> Expected:
> $ qemu -netdev id=net0
> qemu-system-x86_64: Parameter 'type' is missing
>
> Actual:
> $ qemu -netdev id=net0
> Segmentation fault (core
On 06/10/2018 03:12 PM, Thomas Huth wrote:
> Add a sanity check to fix the following crash:
>
> $ echo "Insane in the mainframe" > /tmp/test.txt
> $ s390x-softmmu/qemu-system-s390x -nographic -kernel /tmp/test.txt
> Segmentation fault (core dumped)
>
> Signed-off-by: Thomas Huth
Reviewed-by:
Keno Fischer writes:
> strchrnul is a GNU extension and thus unavailable on a number of targets.
> In the review for a commit removing strchrnul from 9p, I was asked to
> create a qemu_strchrnul helper to factor out this functionality.
> Do so, and use it in a number of other places in the code b
On 06/04/2018 02:03 PM, Daniel P. Berrangé wrote:
> The change to use RUN_STATE_PRECONFIG as the default initial state, even
> when not requested with --preconfig has caused a number of problems. This
> series introduces a new RUN_STATE_NONE to act as the initial state, so
> that we never use RUN_S
Peter Xu writes:
> On Fri, Jun 08, 2018 at 05:11:54PM +0800, Peter Xu wrote:
[...]
> So I think I agree with Markus's solution, we just flush the response
> queue when we get CLOSED (but we don't close the output fd; IMHO
> that's chardev backend's job). Would that work?
I figure you're right o
On Mon, Jun 04, 2018 at 05:55:08PM +0800, guangrong.x...@gmail.com wrote:
> From: Xiao Guangrong
>
> Background
> --
> Current implementation of compression and decompression are very
> hard to be enabled on productions. We noticed that too many wait-wakes
> go to kernel space and CPU usa
On Sun, 10 Jun 2018, Philippe Mathieu-Daudé wrote:
diff --git a/hw/ppc/sam460ex.c b/hw/ppc/sam460ex.c
index 2a98c10664..b35e3fff1c 100644
--- a/hw/ppc/sam460ex.c
+++ b/hw/ppc/sam460ex.c
@@ -12,8 +12,9 @@
*/
#include "qemu/osdep.h"
+#include "qemu/units.h"
#include "qemu-common.h"
-#include "qem
On Mon, 11 Jun 2018 05:06:53 +0300
"Michael S. Tsirkin" wrote:
> On Sat, Jun 09, 2018 at 11:34:03PM +0200, Max Reitz wrote:
> > Dave was saying that the worst thing about the whole q35 thing is
> > that users download an image and have no idea why it isn't
> > working. Figuring that out may
Philippe Mathieu-Daudé writes:
> On 06/08/2018 09:32 AM, Alex Bennée wrote:
>> Now we have restored debian-image-powerpc-cross using Debian SID
>> compilers we can build for 32 bit powerpc. Although PPC32 supports a
>> range of pages sizes currently only 4k works so the others are
>> commented
Philippe Mathieu-Daudé writes:
> On 06/08/2018 09:32 AM, Alex Bennée wrote:
>> Hi,
>>
>> Not a super amount has changed since the last version but review
>> comments and review tags have been added. The new patches at the end
>> enable a .travis.yml run and try and make the image building part
Philippe Mathieu-Daudé writes:
> Hi Alex,
>
> On 06/08/2018 09:33 AM, Alex Bennée wrote:
>> Signed-off-by: Alex Bennée
>> ---
>> .travis.yml | 6 ++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index 814be151f4..f1d2d9edec 100644
>> --- a/.travis.yml
On 2018/5/31 19:01, Auger Eric wrote:
> Hi,
>
> On 05/31/2018 05:15 AM, Shannon Zhao wrote:
>> While for_each_dist_irq_reg loop starts from GIC_INTERNAL, it forgot to
>> offset the date array and index. This will overlap the GICR registers
>> value and leave the last GIC_INTERNAL irq's register
On Wed, Jun 06, 2018 at 01:32:47PM +0200, Max Reitz wrote:
> ext2?
I wrote an nbdkit plugin for ext2/ext3/ext4 last week.
https://github.com/libguestfs/nbdkit/tree/master/plugins/ext2
It uses libext2fs from e2fsprogs and I think there are some lessons
for anyone who wants to use ext2 to store
> -Original Message-
> From: Farhan Ali [mailto:al...@linux.ibm.com]
> Sent: Saturday, June 09, 2018 3:09 AM
> To: linux-ker...@vger.kernel.org; k...@vger.kernel.org
> Cc: m...@redhat.com; qemu-devel@nongnu.org; Gonglei (Arei)
> ; longpeng ;
> pa...@linux.ibm.com; fran...@linux.ibm.com;
"Dr. David Alan Gilbert (git)" writes:
> From: "Dr. David Alan Gilbert"
>
> Add a flag to command definitions to allow them to be used in preconfig
> and check it.
> If users try to use commands that aren't available, tell them to use
> the exit_preconfig comand we're adding in a few patches.
>
On 11 June 2018 at 08:56, Markus Armbruster wrote:
> You're not printing $strchrnul like we print other configuration
> results. Hmm, we're not printing several of them. Question for
> maintainers (MAINTAINERS doesn't have any, so I'm cc'ing the top three
> coughed up by get_maintainer.pl): bug
On Fri, Jun 08, 2018 at 11:52:11AM -0300, Philippe Mathieu-Daudé wrote:
> On 06/01/2018 01:27 PM, Marc-André Lureau wrote:
> > A socket chardev may not have associated address (when adding client
> > fd manually for example). But on disconnect, updating socket filename
> > expects an address and ma
"Dr. David Alan Gilbert (git)" writes:
> From: "Dr. David Alan Gilbert"
>
> Allow the 'help' command in preconfig state but
> make it only list the preconfig commands.
>
> Signed-off-by: Dr. David Alan Gilbert
> Reviewed-by: Peter Xu
> Reviewed-by: Igor Mammedov
> ---
> hmp-commands.hx | 1 +
"Dr. David Alan Gilbert (git)" writes:
> From: "Dr. David Alan Gilbert"
>
> Don't show the commands that aren't available.
>
> Signed-off-by: Dr. David Alan Gilbert
> Reviewed-by: Peter Xu
> Reviewed-by: Igor Mammedov
> ---
> monitor.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 dele
On Fri, Jun 01, 2018 at 06:27:38PM +0200, Marc-André Lureau wrote:
> A socket chardev may not have associated address (when adding client
> fd manually for example). But on disconnect, updating socket filename
> expects an address and may lead to this crash:
>
> Thread 1 "qemu-system-x86" receiv
On 07.06.2018 14:22, Thomas Huth wrote:
> This patch series adds pxelinux.cfg-style network booting to the s390-ccw
> firmware. The core pxelinux.cfg loading and parsing logic has recently
> been merged to SLOF, so these patches now just have to make sure to call
> the right functions to get the co
On 06/07/2018 02:22 PM, Thomas Huth wrote:
> This patch series adds pxelinux.cfg-style network booting to the s390-ccw
> firmware. The core pxelinux.cfg loading and parsing logic has recently
> been merged to SLOF, so these patches now just have to make sure to call
> the right functions to get
if laio_init create linux_aio failed and return NULL, NULL pointer
dereference will occur when laio_attach_aio_context dereference
linux_aio in aio_get_linux_aio, so add assert to avoid it.
Signed-off-by: Jie Wang
---
util/async.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/async.c
On Mon, Jun 11, 2018 at 08:06:49AM +0200, Markus Armbruster wrote:
> Philippe Mathieu-Daudé writes:
>
> > On 06/08/2018 02:12 PM, Daniel P. Berrangé wrote:
> >> On Fri, Jun 08, 2018 at 07:02:31PM +0200, Markus Armbruster wrote:
> >>> We banned use of certain g_assert_FOO() functions outside tests
On Mon, 11 Jun 2018 09:49:39 +0200
Christian Borntraeger wrote:
> On 06/10/2018 03:12 PM, Thomas Huth wrote:
> > Add a sanity check to fix the following crash:
> >
> > $ echo "Insane in the mainframe" > /tmp/test.txt
> > $ s390x-softmmu/qemu-system-s390x -nographic -kernel /tmp/test.txt
> > Segm
If user forgets to provide any backend types for '-netdev' in qemu CLI,
It triggers seg fault.
e.g.
Expected:
$ qemu -netdev id=net0
qemu-system-x86_64: Parameter 'type' is missing
Actual:
$ qemu -netdev id=net0
Segmentation fault (core dumped)
Signed-off-by: Lin Ma
---
net/net.c | 4 +++-
1
On Fri, Jun 08, 2018 at 02:52:50PM -0300, Eduardo Habkost wrote:
> Changes v1 -> v2:
> * Remove references to ordereddict.py from Makefiles
> (oops)
>
> Now that we require Python >= 2.7, we don't need
> scripts/argparse.py and scripts/ordereddict.py anymore.
>
> Eduardo Habkost (2):
> python
On Fri, Jun 08, 2018 at 02:35:57PM -0300, Eduardo Habkost wrote:
> Python 2.7 (the minimum Python version we require) already
> provides the argparse module on the standard library.
>
> Signed-off-by: Eduardo Habkost
> ---
> scripts/argparse.py | 2406 ---
On Mon, 06/11 15:04, Jie Wang wrote:
> if laio_init create linux_aio failed and return NULL, NULL pointer
> dereference will occur when laio_attach_aio_context dereference
> linux_aio in aio_get_linux_aio, so add assert to avoid it.
>
> Signed-off-by: Jie Wang
> ---
> util/async.c | 1 +
> 1 fil
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On 11 June 2018 at 08:56, Markus Armbruster wrote:
> > You're not printing $strchrnul like we print other configuration
> > results. Hmm, we're not printing several of them. Question for
> > maintainers (MAINTAINERS doesn't have any, so I'm cc'
On Mon, Jun 11, 2018 at 09:52:55AM +0100, Peter Maydell wrote:
> On 11 June 2018 at 08:56, Markus Armbruster wrote:
> > You're not printing $strchrnul like we print other configuration
> > results. Hmm, we're not printing several of them. Question for
> > maintainers (MAINTAINERS doesn't have an
Since all but the libvirt task to expose these are set to invalid in
regard to the issue here I'm changing the title accordingly.
As a short term solution for Ubuntu users I forked bug 1776189 to
provide a machine type based solution until this here is implemented and
widely available and exploite
On 11.06.2018 11:23, Lin Ma wrote:
> If user forgets to provide any backend types for '-netdev' in qemu CLI,
> It triggers seg fault.
>
> e.g.
>
> Expected:
> $ qemu -netdev id=net0
> qemu-system-x86_64: Parameter 'type' is missing
>
> Actual:
> $ qemu -netdev id=net0
> Segmentation fault (core
On 11.06.2018 11:24, Cornelia Huck wrote:
> On Mon, 11 Jun 2018 09:49:39 +0200
> Christian Borntraeger wrote:
>
>> On 06/10/2018 03:12 PM, Thomas Huth wrote:
>>> Add a sanity check to fix the following crash:
>>>
>>> $ echo "Insane in the mainframe" > /tmp/test.txt
>>> $ s390x-softmmu/qemu-system
On 11 June 2018 at 10:38, Daniel P. Berrangé wrote:
> On Mon, Jun 11, 2018 at 09:52:55AM +0100, Peter Maydell wrote:
>> There's an argument that we should also log every config check
>> result somehow (I think autoconf configures do this), but I
>> don't think that our 'print stuff to stdout' is t
On 8 June 2018 at 13:44, Peter Maydell wrote:
> target-arm queue: aspeed patches from Cédric, and
> cleanup and sd card patches from Philippe.
>
> thanks
> -- PMM
>
> The following changes since commit bac5ba3dc5da706f52c149fa6c0bd1dc96899bec:
>
> Merge remote-tracking branch 'remotes/thibault/t
Reminder that 3.0 soft freeze is due in about 3 weeks, on the 3rd
July. Please try to get new features in in good time so we don't have
a last-minute deluge of huge pull requests :-)
thanks
-- PMM
I do like to add that I only saw this when the source we migrate from is
running on a relatively new CPU: Intel(R) Xeon(R) Gold 6126 CPU @
2.60GHz.
vendor_id : GenuineIntel
cpu family : 6
model : 85
model name : Intel(R) Xeon(R) Gold 6126 CPU @ 2.60GHz
stepping: 4
* Markus Armbruster (arm...@redhat.com) wrote:
> "Dr. David Alan Gilbert (git)" writes:
>
> > From: "Dr. David Alan Gilbert"
> >
> > Allow the 'help' command in preconfig state but
> > make it only list the preconfig commands.
> >
> > Signed-off-by: Dr. David Alan Gilbert
> > Reviewed-by: Peter
On 07.06.2018 18:03, 浙大邮箱 wrote:
> Hi，all
> I still have a question after reading your discussion: Will seabios detect
> the change of address space even if we add_region and del_region
> automatically? I guess that seabios may not take this change into
> consideration.
Hi,
We would just chang
On 06/11/2018 05:19 AM, Alex Bennée wrote:
> Philippe Mathieu-Daudé writes:
>> On 06/08/2018 09:32 AM, Alex Bennée wrote:
>>> Hi,
>>>
>>> Not a super amount has changed since the last version but review
>>> comments and review tags have been added. The new patches at the end
>>> enable a .travis.y
From: Richard Henderson
The raise_exception helper does not return. Do not generate
any code following that.
Signed-off-by: Richard Henderson
Message-Id: <20180512050250.12774-2-richard.hender...@linaro.org>
Signed-off-by: Laurent Vivier
---
target/m68k/translate.c | 16
1 f
The following changes since commit 0d2fa03dae4fbe185a082f361342b1e30aed4582:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20180608'
into staging (2018-06-08 16:26:51 +0100)
are available in the Git repository at:
git://github.com/vivier/qemu-m68k.git tags/m68k-for-3.0
From: Richard Henderson
These are all indirect or out-of-page direct jumps.
We can indirectly chain to the next TB without going
back to the main loop.
Signed-off-by: Richard Henderson
Message-Id: <20180512050250.12774-5-richard.hender...@linaro.org>
Signed-off-by: Laurent Vivier
---
target/m
From: Richard Henderson
We have exited the TB after using goto_tb; there is no
distinction from DISAS_NORETURN.
Signed-off-by: Richard Henderson
Message-Id: <20180512050250.12774-3-richard.hender...@linaro.org>
Signed-off-by: Laurent Vivier
---
target/m68k/translate.c | 4 +---
1 file changed
On 06/11/2018 12:08 PM, Thomas Huth wrote:
> On 11.06.2018 11:24, Cornelia Huck wrote:
>> On Mon, 11 Jun 2018 09:49:39 +0200
>> Christian Borntraeger wrote:
>>
>>> On 06/10/2018 03:12 PM, Thomas Huth wrote:
Add a sanity check to fix the following crash:
$ echo "Insane in the main
From: Richard Henderson
The name gen_lookup_tb is at odds with tcg_gen_lookup_and_goto_tb.
For these cases, we do indeed want to exit back to the main loop.
Similarly, DISAS_UPDATE performs no actual update, whereas DISAS_EXIT
does what it says.
Signed-off-by: Richard Henderson
Message-Id: <201
From: Richard Henderson
Removed ctx->insn_pc in favour of ctx->base.pc_next.
Yes, it is annoying, but didn't want to waste its 4 bytes.
Signed-off-by: Richard Henderson
Message-Id: <20180512050250.12774-7-richard.hender...@linaro.org>
Signed-off-by: Laurent Vivier
---
target/m68k/translate.c
From: Richard Henderson
Rather than limit total TB size to PAGE-32 bytes, end the TB when
near the end of a page. This should provide proper semantics of
SIGSEGV when executing near the end of a page.
Signed-off-by: Richard Henderson
Message-Id: <20180512050250.12774-9-richard.hender...@linaro
From: Richard Henderson
Signed-off-by: Richard Henderson
Message-Id: <20180512050250.12774-4-richard.hender...@linaro.org>
Signed-off-by: Laurent Vivier
---
target/m68k/translate.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index bfa30c
From: Richard Henderson
Signed-off-by: Richard Henderson
Message-Id: <20180512050250.12774-10-richard.hender...@linaro.org>
Signed-off-by: Laurent Vivier
---
target/m68k/translate.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/target/m68k/translate.c b
From: Richard Henderson
Signed-off-by: Richard Henderson
Message-Id: <20180512050250.12774-8-richard.hender...@linaro.org>
Signed-off-by: Laurent Vivier
---
target/m68k/translate.c | 180 +++-
1 file changed, 88 insertions(+), 92 deletions(-)
diff -
In a sub-directory source files may be conditionally built using a
Makefile.objs line such as
crypto-obj-$(CONFIG_CTHULHU) = foo.o
It is also possible to add custom linker flags for when this
foo.o is later linked into a binary
foo.o-libs = -lcthulhu
When the unqualfied 'foo.o' filename
* Juan Quintela (quint...@redhat.com) wrote:
> We still don't put anything there.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
>
> --
> fix magic (dave)
> check offset/ramblock (dave)
> ---
> migration/ram.c | 145 +++-
> 1
On Fri, 8 Jun 2018 22:40:39 +0200
Halil Pasic wrote:
> Your welcome. The discussion is kind of taking place all over the
> place. I'm actively trying to find the best place to answer, and avoid
> overtalking topics -- but it does not seem to work. Please bear with me.
To help with this discussio
On 11.06.2018 11:08, Viktor VM Mihajlovski wrote:
> On 07.06.2018 14:22, Thomas Huth wrote:
>> This patch series adds pxelinux.cfg-style network booting to the s390-ccw
>> firmware. The core pxelinux.cfg loading and parsing logic has recently
>> been merged to SLOF, so these patches now just have t
I'm late to the party, but anyway...
Am 07.06.2018 um 14:02 hat Markus Armbruster geschrieben:
> Peter Maydell writes:
>
> > On 5 June 2018 at 08:46, Cornelia Huck wrote:
> >> On Tue, 5 Jun 2018 06:33:22 +0200
> >> Thomas Huth wrote:
> >>> On 05.06.2018 03:17, Alex Williamson wrote:
> >>> > On
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 2018060327.21218-1-berra...@redhat.com
Subject: [Qemu-devel] [PATCH] DO NOT APPLY - de
"Dr. David Alan Gilbert (git)" writes:
> From: Igor Mammedov
>
> subj commands, are informational and do not depend on machine being
> initialized. Make them available early in preconfig runstate to make
> the later a little bit more useful.
>
> Signed-off-by: Igor Mammedov
Excessively long su
On 8 June 2018 at 18:47, John Snow wrote:
> The following changes since commit 0d2fa03dae4fbe185a082f361342b1e30aed4582:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20180608' into staging (2018-06-08
> 16:26:51 +0100)
>
> are available in the Git repository at:
>
* Juan Quintela (quint...@redhat.com) wrote:
> We synchronize all threads each RAM_SAVE_FLAG_EOS. Bitmap
> synchronizations don't happen inside a ram section, so we are safe
> about two channels trying to overwrite the same memory.
>
> Signed-off-by: Juan Quintela
> ---
> migration/ram.c
"Dr. David Alan Gilbert (git)" writes:
> From: "Dr. David Alan Gilbert"
>
> Allow a bunch of the info commands to be used in preconfig.
>
> version, chardev, name, uuid,memdev, iothreads
> Were enabled in QMP in the previous patch from Igor
Yes, these are okay together with PATCH 4.
> status
On 11.06.2018 13:12, Thomas Huth wrote:
> On 11.06.2018 11:08, Viktor VM Mihajlovski wrote:
>> On 07.06.2018 14:22, Thomas Huth wrote:
>>> This patch series adds pxelinux.cfg-style network booting to the s390-ccw
>>> firmware. The core pxelinux.cfg loading and parsing logic has recently
>>> been me
"Dr. David Alan Gilbert (git)" writes:
> From: "Dr. David Alan Gilbert"
>
> Add the exit_preconfig command to return to normality.
>
> Signed-off-by: Dr. David Alan Gilbert
> Reviewed-by: Peter Xu
> Reviewed-by: Igor Mammedov
> ---
> hmp-commands.hx | 15 +++
> hmp.c |
Let's also provide "quit", both in HMP and QMP.
* Markus Armbruster (arm...@redhat.com) wrote:
> Let's also provide "quit", both in HMP and QMP.
I tried enabling quit, but it fails with an incorrect
state transition.
Dave
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
Our parent class (PC_DIMM) provides exactly the same function.
Signed-off-by: David Hildenbrand
---
hw/mem/nvdimm.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
index 4087aca25e..f974accbdd 100644
--- a/hw/mem/nvdimm.c
+++ b/hw/mem/nvdimm.c
@@ -166,1
Not needed anymore, let's drop it.
Signed-off-by: David Hildenbrand
---
hw/mem/pc-dimm.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
index 12da89d562..62b34a992e 100644
--- a/hw/mem/pc-dimm.c
+++ b/hw/mem/pc-dimm.c
@@ -27,11 +27,6 @@
#include "sys
This is another set of cleanups as the result from
[PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers
And is based on the two series
[PATCH v1 0/2] memory: fix alignment checks/asserts
[PATCH v2 0/6] spapr: machine hotplug handler cleanups
These cleanup are the last step b
We already verify when realizing that the memdev property has been
set. We have no more accesses to get_memory_region() before the device
is realized.
So this function will never fail. Remove the stale check and the
error variable. Add a comment to the functions stating that they should
never be c
We can perform these checks before the device is actually realized.
Signed-off-by: David Hildenbrand
---
hw/i386/pc.c | 44 ++--
1 file changed, 26 insertions(+), 18 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index f3befe6721..85c040482e 100644
This might look like a step backwards, but it is not. get_memory_region()
should not be called on uninititalized devices. In general, only
properties should be access, but no "derived" satte like the memory
region.
1. We need duplicate error checks if memdev is actually already set.
realize() p
This is guaranteed by passing into host_memory_backend_get_memory() a
value that is not NULL - which is what we always do.
Signed-off-by: David Hildenbrand
---
hw/mem/pc-dimm.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.
"size" should not be queried before the device was realized. Let' make
that explicit.
Signed-off-by: David Hildenbrand
---
hw/mem/pc-dimm.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
index 86fbcf2d0c..5294734529 100644
--- a/hw/mem/pc-dimm.c
+++
We'll be factoring out some pc-dimm specific and some memory-device
checks next.
Signed-off-by: David Hildenbrand
---
hw/i386/pc.c | 2 ++
hw/mem/pc-dimm.c | 5 +
hw/ppc/spapr.c | 1 +
include/hw/mem/pc-dimm.h | 2 ++
4 files changed, 10 insertions(+)
diff --gi
Unused, so let's remove it.
Signed-off-by: David Hildenbrand
---
backends/hostmem.c | 3 +--
hw/mem/nvdimm.c | 4 ++--
hw/mem/pc-dimm.c | 4 ++--
hw/misc/ivshmem.c| 3 +--
include/sysemu/hostmem.h | 3 +--
numa.c | 3 +--
6 files changed, 8 insert
ping?
Am 29.05.2018 um 19:21 hat Kevin Wolf geschrieben:
> This is the third and hopefully for now last part of my work to fix
> drain. The main goal of this series is to make drain robust against
> graph changes that happen in any callbacks of in-flight requests while
> we drain a block node.
>
On Mon 11 Jun 2018 02:20:06 PM CEST, Kevin Wolf wrote:
> Am 01.06.2018 um 12:51 hat Alberto Garcia geschrieben:
>> On Thu 03 May 2018 02:22:41 PM CEST, Kevin Wolf wrote:
>> >> > Were the (more or less) exact requirements of QMP blockdev-reopen
>> >> > discussed? How is it different from qemu-io's "
We can reuse pc_dimm_get_memory_region() now, as both functions are
(besides the assert which is also correct), equal.
Signed-off-by: David Hildenbrand
---
hw/mem/pc-dimm.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
index 9a0da5d
We can assign and verify the slot before realizing and trying to plug.
reading/writing the slot property should never change, so let's reduce
error handling a bit by using &error_abort.
Signed-off-by: David Hildenbrand
---
hw/mem/pc-dimm.c | 31 ++-
1 file changed, 14
Am 01.06.2018 um 12:51 hat Alberto Garcia geschrieben:
> On Thu 03 May 2018 02:22:41 PM CEST, Kevin Wolf wrote:
> >> > Were the (more or less) exact requirements of QMP blockdev-reopen
> >> > discussed? How is it different from qemu-io's "reopen" command?
> >> > What are the options that you can an
Hi David and Paolo,
> -Original Message-
> From: David Hildenbrand [mailto:da...@redhat.com]
> Sent: Monday, June 11, 2018 6:44 PM
> To: 浙大邮箱
> Cc: Paolo Bonzini ; Gonglei (Arei)
> ; Igor Mammedov ;
> xuyandong ; Zhanghailiang
> ; wangxin (U)
> ; lidonglin ;
> k...@vger.kernel.org; qemu-
On 11.06.2018 14:25, Gonglei (Arei) wrote:
>
> Hi David and Paolo,
>
>> -Original Message-
>> From: David Hildenbrand [mailto:da...@redhat.com]
>> Sent: Monday, June 11, 2018 6:44 PM
>> To: 浙大邮箱
>> Cc: Paolo Bonzini ; Gonglei (Arei)
>> ; Igor Mammedov ;
>> xuyandong ; Zhanghailiang
>> ;
On 11 June 2018 at 11:49, Laurent Vivier wrote:
> The following changes since commit 0d2fa03dae4fbe185a082f361342b1e30aed4582:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20180608' into staging (2018-06-08
> 16:26:51 +0100)
>
> are available in the Git repository
Public bug reported:
I'm having troubles using the QEMU's SPICE server for remote views. When
trying to sync leds from my SPICE client to QEMU, I can see that the
caps lock keycodes are sent but the server state never gets updated
(which leads in funny behaviours like caps lock "blinking" in the g
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> Let's also provide "quit", both in HMP and QMP.
>
> I tried enabling quit, but it fails with an incorrect
> state transition.
Igor, this one's for you.
This patchset is two vaguely related patches that I wrote
while I was trying to understand the cputlb code enough to
add support for small-MPU-regions for v7M/v8M.
Patch 1 is just a docs comment patch, describing what the
CPUIOTLBEntry 'addr' field actually contains.
Patch 2 fixes a bug that does
The 'addr' field in the CPUIOTLBEntry struct has a rather non-obvious
use; add a comment documenting it (reverse-engineered from what
the code that sets it is doing).
Signed-off-by: Peter Maydell
---
include/exec/cpu-defs.h | 9 +
accel/tcg/cputlb.c | 12
2 files chang
The API for cpu_transaction_failed() says that it takes the physical
address for the failed transaction. However we were actually passing
it the offset within the target MemoryRegion. We don't currently
have any target CPU implementations of this hook that require the
physical address; fix this bug
On 11 June 2018 at 09:32, Shannon Zhao wrote:
> Hi Peter,
>
> Looks like we missed picking up this patch. I didn't include this in v6
> since you and Eric both reviewed it.
>
> Could you please pick it up?
Oops; added to target-arm.next. (I generally forget entirely about vN
of a patchset as soon
On Fri, 8 Jun 2018 10:21:05 -0300
Eduardo Habkost wrote:
> On Thu, Jun 07, 2018 at 02:00:09PM +0200, Igor Mammedov wrote:
> > When using --daemonize, the initial lead process will fork a child and
> > then wait to be notified that setup is complete via a pipe, before it
> > exits. When using --p
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> "Dr. David Alan Gilbert (git)" writes:
>>
>> > From: "Dr. David Alan Gilbert"
>> >
>> > Allow the 'help' command in preconfig state but
>> > make it only list the preconfig commands.
>> >
>> > Signed-off-by: D
> -Original Message-
> From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On
> Behalf Of David Hildenbrand
> Sent: Monday, June 11, 2018 8:36 PM
> To: Gonglei (Arei) ; 浙大邮箱
> Subject: Re: An emulation failure occurs,if I hotplug vcpus immediately after
> the
> VM start
>
Hi Michael
On Mon, May 14, 2018 at 2:38 PM, Marc-André Lureau
wrote:
> Iterate over the PCI bridges to lookup the PCI device associated with
> the block device.
>
> This allows to lookup the driver under the following syspath:
> /sys/devices/pci:00/:00:02.2/:03:00.0/virtio2/block/vda/
1 - 100 of 426 matches
Mail list logo
