Re: [Qemu-devel] [PATCH 23/27] hw/core/or-irq: Support more than 16 inputs to an OR gate

2018-05-30 Thread Paolo Bonzini
On 21/05/2018 17:02, Peter Maydell wrote: > On 21 May 2018 at 15:34, Paolo Bonzini wrote: >> Why do the levels have to be migrated at all? It should be enough if >> the IRQ level is either migrated manually, or restored (e.g. in >> post_save callbacks) through other data that is migrated. > This

Re: [Qemu-devel] [qemu-web PATCH v2] Add a blog post about the new -nic parameter

2018-05-30 Thread Thomas Huth
On 30.05.2018 17:57, Eric Blake wrote: > On 05/30/2018 10:25 AM, Thomas Huth wrote: >> QEMU v2.12 features a new, useful parameter called "-nic". Let's >> throw some light on this new parameter with a new blog post. >> >> Signed-off-by: Thomas Huth >> --- > >>  screenshots/2018-05-30-qemu-cli-net

Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: define loadparm length

2018-05-30 Thread Farhan Ali
On 05/29/2018 12:40 AM, Collin Walling wrote: Loadparm is defined by the s390 architecture to be 8 bytes in length. Let's define this size in the s390-ccw bios. Suggested-by: Laszlo Ersek Signed-off-by: Collin Walling --- pc-bios/s390-ccw/iplb.h | 4 +++- pc-bios/s390-ccw/main.c | 8 --

Re: [Qemu-devel] [PATCH v4 11/12] migration: poll the cm event while wait RDMA work request completion

2018-05-30 Thread Dr. David Alan Gilbert
* Lidong Chen (jemmy858...@gmail.com) wrote: > If the peer qemu is crashed, the qemu_rdma_wait_comp_channel function > maybe loop forever. so we should also poll the cm event fd, and when > receive any cm event, we consider some error happened. > > Signed-off-by: Lidong Chen I don't understand e

Re: [Qemu-devel] [PATCH 23/27] hw/core/or-irq: Support more than 16 inputs to an OR gate

2018-05-30 Thread Peter Maydell
On 30 May 2018 at 17:59, Paolo Bonzini wrote: > On 21/05/2018 17:02, Peter Maydell wrote: >> On 21 May 2018 at 15:34, Paolo Bonzini wrote: >>> Why do the levels have to be migrated at all? It should be enough if >>> the IRQ level is either migrated manually, or restored (e.g. in >>> post_save ca

Re: [Qemu-devel] [PATCH] qom: support orphan objects in object_get_canonical_path

2018-05-30 Thread Philippe Mathieu-Daudé
On 05/30/2018 01:23 PM, Paolo Bonzini wrote: > Mostly a rewrite, in order to keep the loop simple. Thus easier to review using "git difftool -y -x sdiff" (or whichever tool you prefer, such meld). "git format-patch" doesn't provide a way to generate side-by-side diffs applicable. > > Signed-off

Re: [Qemu-devel] [PATCH v4 12/12] migration: implement the shutdown for RDMA QIOChannel

2018-05-30 Thread Dr. David Alan Gilbert
* Lidong Chen (jemmy858...@gmail.com) wrote: > Because RDMA QIOChannel not implement shutdown function, > If the to_dst_file was set error, the return path thread > will wait forever. and the migration thread will wait > return path thread exit. > > the backtrace of return path thread is: > > (gd

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Cleber Rosa
On 05/30/2018 12:29 PM, Eduardo Habkost wrote: > On Wed, May 30, 2018 at 01:57:05PM +0100, Stefan Hajnoczi wrote: >> On Tue, May 29, 2018 at 03:37:28PM -0400, Cleber Rosa wrote: >>> This patch adds a few simple behavior tests for VNC. >>> >>> Signed-off-by: Cleber Rosa >>> --- >>> tests/accept

[Qemu-devel] [PATCH v3b 00/18] target/arm: SVE instructions, part 2

2018-05-30 Thread Richard Henderson
Here's the second installment of SVE instructions. There are about 25 patches waiting for a third installment; this makes a nice break before beginning with the memory ops. r~ Richard Henderson (18): target/arm: Extend vec_reg_offset to larger sizes target/arm: Implement SVE Permute - Unpre

[Qemu-devel] [PATCH v3b 02/18] target/arm: Implement SVE Permute - Unpredicated Group

2018-05-30 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 23 +++ target/arm/sve_helper.c| 114 +++ target/arm/translate-sve.c | 133 + target/arm/sve.decode | 27 4 files c

[Qemu-devel] [PATCH v3b 09/18] target/arm: Implement SVE vector splice (predicated)

2018-05-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 2 ++ target/arm/sve_helper.c| 37 + target/arm/translate-sve.c | 13 + target/arm/sve.decode | 3 +++ 4 files changed, 55 insertions(+) diff --git a/target/arm/helper-sve

[Qemu-devel] [PATCH v3b 01/18] target/arm: Extend vec_reg_offset to larger sizes

2018-05-30 Thread Richard Henderson
Rearrange the arithmetic so that we are agnostic about the total size of the vector and the size of the element. This will allow us to index up to the 32nd byte and with 16-byte elements. Signed-off-by: Richard Henderson --- target/arm/translate-a64.h | 26 +- 1 file cha

[Qemu-devel] [PATCH v3b 04/18] target/arm: Implement SVE Permute - Interleaving Group

2018-05-30 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 15 target/arm/sve_helper.c| 72 target/arm/translate-sve.c | 75 ++ target/arm/sve.decode | 10 + 4 files c

[Qemu-devel] [PATCH v3b 05/18] target/arm: Implement SVE compress active elements

2018-05-30 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 3 +++ target/arm/sve_helper.c| 34 ++ target/arm/translate-sve.c | 12 target/arm/sve.decode | 6 ++ 4 files changed, 55 insertions(+) diff -

[Qemu-devel] [PATCH v3b 17/18] target/arm: Implement SVE Integer Wide Immediate - Unpredicated Group

2018-05-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 25 +++ target/arm/sve_helper.c| 41 +++ target/arm/translate-sve.c | 144 + target/arm/sve.decode | 26 +++ 4 files changed, 236 insertions(+) diff --git a/target/ar

[Qemu-devel] [PATCH v3b 03/18] target/arm: Implement SVE Permute - Predicates Group

2018-05-30 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 6 + target/arm/sve_helper.c| 290 + target/arm/translate-sve.c | 120 +++ target/arm/sve.decode | 18 +++ 4 files changed, 434 insertions(+)

[Qemu-devel] [PATCH v3b 08/18] target/arm: Implement SVE reverse within elements

2018-05-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 14 + target/arm/sve_helper.c| 41 +++--- target/arm/translate-sve.c | 38 +++ target/arm/sve.decode | 7 +++ 4 files changed, 93 insertions(

[Qemu-devel] [PATCH v3b 06/18] target/arm: Implement SVE conditionally broadcast/extract element

2018-05-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 2 + target/arm/sve_helper.c| 11 ++ target/arm/translate-sve.c | 318 + target/arm/sve.decode | 20 +++ 4 files changed, 351 insertions(+) diff --git a/target/arm/helper-sve.h b/ta

[Qemu-devel] [PATCH v3b 18/18] target/arm: Implement SVE Floating Point Arithmetic - Unpredicated Group

2018-05-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 14 target/arm/helper.h| 19 +++ target/arm/translate-sve.c | 42 +++ target/arm/vec_helper.c| 69 ++ target/arm/sve.decode | 10 ++ 5 fi

[Qemu-devel] [PATCH v3b 11/18] target/arm: Implement SVE Integer Compare - Vectors Group

2018-05-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 115 +++ target/arm/sve_helper.c| 187 + target/arm/translate-sve.c | 91 ++ target/arm/sve.decode | 24 + 4 files changed, 417 insertions(+) d

[Qemu-devel] [PATCH v3b 07/18] target/arm: Implement SVE copy to vector (predicated)

2018-05-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-sve.c | 19 +++ target/arm/sve.decode | 6 ++ 2 files changed, 25 insertions(+) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index edcef277f8..a6f85de358 100644 --- a/target/arm/translate-

[Qemu-devel] [PATCH v3b 15/18] target/arm: Implement SVE Integer Compare - Scalars Group

2018-05-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 2 + target/arm/sve_helper.c| 31 +++ target/arm/translate-sve.c | 102 + target/arm/sve.decode | 8 +++ 4 files changed, 143 insertions(+) diff --git a/target/arm/helper-s

[Qemu-devel] [PATCH v3b 16/18] target/arm: Implement FDUP/DUP

2018-05-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-sve.c | 37 + target/arm/sve.decode | 8 2 files changed, 45 insertions(+) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 75eb36f110..e470f3b745 100644 --- a/t

[Qemu-devel] [PATCH v3b 10/18] target/arm: Implement SVE Select Vectors Group

2018-05-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 9 +++ target/arm/sve_helper.c| 55 ++ target/arm/translate-sve.c | 2 ++ target/arm/sve.decode | 6 + 4 files changed, 72 insertions(+) diff --git a/target/arm/helper-sve.h

[Qemu-devel] [PATCH v3b 13/18] target/arm: Implement SVE Partition Break Group

2018-05-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 18 +++ target/arm/sve_helper.c| 247 + target/arm/translate-sve.c | 106 target/arm/sve.decode | 19 +++ 4 files changed, 390 insertions(+) diff --git a/target/arm/h

[Qemu-devel] [PATCH v3b 14/18] target/arm: Implement SVE Predicate Count Group

2018-05-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 2 + target/arm/sve_helper.c| 14 target/arm/translate-sve.c | 132 + target/arm/sve.decode | 27 4 files changed, 175 insertions(+) diff --git a/target/arm/helper-sve

[Qemu-devel] [PATCH v3b 12/18] target/arm: Implement SVE Integer Compare - Immediate Group

2018-05-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 44 +++ target/arm/sve_helper.c| 88 ++ target/arm/translate-sve.c | 66 target/arm/sve.decode | 23 ++ 4 files changed, 221 insertio

Re: [Qemu-devel] [PATCH v3 1/5] Add functional/acceptance tests infrastructure

2018-05-30 Thread Cleber Rosa
On 05/30/2018 08:54 AM, Stefan Hajnoczi wrote: > On Tue, May 29, 2018 at 03:37:26PM -0400, Cleber Rosa wrote: >> diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst >> index 0ca1a2d4b5..5e090c87fb 100644 >> --- a/docs/devel/testing.rst >> +++ b/docs/devel/testing.rst >> @@ -484,3 +484,1

Re: [Qemu-devel] [qemu-web PATCH v2] Add a blog post about the new -nic parameter

2018-05-30 Thread Eric Blake
On 05/30/2018 12:27 PM, Thomas Huth wrote: On 30.05.2018 17:57, Eric Blake wrote: On 05/30/2018 10:25 AM, Thomas Huth wrote: QEMU v2.12 features a new, useful parameter called "-nic". Let's throw some light on this new parameter with a new blog post. Signed-off-by: Thomas Huth ---  screen

Re: [Qemu-devel] [PATCH] move public invalidate APIs out of translate-all.{c, h}, clean up

2018-05-30 Thread Philippe Mathieu-Daudé
On 05/30/2018 01:58 PM, Paolo Bonzini wrote: > Place them in exec.c, exec-all.h and ram_addr.h. This removes > knowledge of translate-all.h (which is an internal header) from > several files outside accel/tcg and removes knowledge of > AddressSpace from translate-all.c (as it only operates on ram_

Re: [Qemu-devel] [PATCH v3b 00/18] target/arm: SVE instructions, part 2

2018-05-30 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180530180120.13355-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v3b 00/18] target/arm: SVE instructions, part 2 === TEST SCRIPT BEGIN === #!/bin/bash BASE=b

Re: [Qemu-devel] [qemu-web PATCH v2] Add a blog post about the new -nic parameter

2018-05-30 Thread Thomas Huth
On 30.05.2018 20:15, Eric Blake wrote: > On 05/30/2018 12:27 PM, Thomas Huth wrote: >> On 30.05.2018 17:57, Eric Blake wrote: >>> On 05/30/2018 10:25 AM, Thomas Huth wrote: QEMU v2.12 features a new, useful parameter called "-nic". Let's throw some light on this new parameter with a new b

[Qemu-devel] [PATCH v4 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Cleber Rosa
This patch adds a few simple behavior tests for VNC. Signed-off-by: Cleber Rosa Reviewed-by: Stefan Hajnoczi --- tests/acceptance/vnc.py | 60 + 1 file changed, 60 insertions(+) create mode 100644 tests/acceptance/vnc.py diff --git a/tests/acceptance/vn

[Qemu-devel] [PATCH v4 5/5] Acceptance tests: add Linux kernel boot and console checking test

2018-05-30 Thread Cleber Rosa
This test boots a Linux kernel, and checks that the given command line was effective in two ways: * It makes the kernel use the set "console device" as a console * The kernel records the command line as expected in the console Given that way too many error conditions may occur, and detecting th

[Qemu-devel] [PATCH v4 2/5] scripts/qemu.py: allow adding to the list of extra arguments

2018-05-30 Thread Cleber Rosa
Tests will often need to add extra arguments to QEMU command line arguments. Signed-off-by: Cleber Rosa Reviewed-by: Stefan Hajnoczi --- scripts/qemu.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/scripts/qemu.py b/scripts/qemu.py index 08a3e9af5a..7cd8193df8 100644 --- a/scripts/

[Qemu-devel] [PATCH v4 4/5] scripts/qemu.py: introduce set_console() method

2018-05-30 Thread Cleber Rosa
The set_console() method is intended to ease higher level use cases that require a console device. The amount of intelligence is limited on purpose, requiring either the device type explicitly, or the existence of a machine (pattern) definition. Because of the console device type selection criter

[Qemu-devel] [PATCH v4 0/5] Acceptance/functional tests

2018-05-30 Thread Cleber Rosa
TL;DR = Another version, with a minimalist approach, of the acceptance tests infrastructure for QEMU, based on the Avocado Testing Framework. Background == The previous version, still considered an RFC, sent to the list by Eduardo[1] was based on the work held in Amador's branch[2].

[Qemu-devel] [PATCH v4 1/5] Add functional/acceptance tests infrastructure

2018-05-30 Thread Cleber Rosa
This patch adds the very minimum infrastructure necessary for writing and running functional/acceptance tests, including: * Documentation * The avocado_qemu.Test base test class * One example tests (version.py) Additional functionality is expected to be added along the tests that require them.

[Qemu-devel] [PATCH 4/4] test: Add swtpm migration test for the TPM TIS interface

2018-05-30 Thread Stefan Berger
Add a test case for testing swtpm migration with the TPM TIS interface. Signed-off-by: Stefan Berger --- tests/Makefile.include | 3 +++ tests/tpm-tis-swtpm-test.c | 66 ++ tests/tpm-util.c | 48 + tests/t

[Qemu-devel] [PATCH 1/4] test: Move reusable code from tpm-crb-swtpm-test.c to tpm-util.c

2018-05-30 Thread Stefan Berger
Move code we can reuse from tpm-crb-swtpm-test.c into tpm-util.c and prefix functions with 'tpm_util_'. Remove some unnecessary #include's. Signed-off-by: Stefan Berger --- tests/tpm-crb-swtpm-test.c | 100 +++-- tests/tpm-util.c | 89 +

[Qemu-devel] [PATCH 2/4] test: Move common TPM test functions to tpm-tests.c

2018-05-30 Thread Stefan Berger
Move common TPM test functions from tpm-crb-swtpm-test.c to tpm-tests.c so that for example test cases with the TPM TIS interface can use the same code. Prefix all funcions with 'tpm_test_'. Signed-off-by: Stefan Berger --- tests/Makefile.include | 2 +- tests/tpm-crb-swtpm-test.c | 99 ++

[Qemu-devel] [PATCH 0/4] Refactor code and implement another TPM TIS test

2018-05-30 Thread Stefan Berger
This series of patches refactors the tpm-crb-swtpm-test.c in the first two patches and moves functions into tpm-util.c and tpm-tests.c for reuse. Patch 3 passes "tpm-crb" to the functions that create the QEMU command line. Patch 4 is more or less a copy of tpm-crb-swtpm-test.c adapted for the TIS i

[Qemu-devel] [PATCH 3/4] test: Pass TPM interface model to functions creating command line

2018-05-30 Thread Stefan Berger
Pass the TPM interface model, such as 'tpm-crb', through to the functions that create the command line for QEMU. Signed-off-by: Stefan Berger --- tests/tpm-crb-swtpm-test.c | 4 ++-- tests/tpm-tests.c | 13 - tests/tpm-tests.h | 6 -- tests/tpm-util.c

Re: [Qemu-devel] [PATCH v3 5/5] Acceptance tests: add Linux kernel boot and console checking test

2018-05-30 Thread Stefan Hajnoczi
On Tue, May 29, 2018 at 03:37:30PM -0400, Cleber Rosa wrote: > This test boots a Linux kernel, and checks that the given command > line was effective in two ways: > > * It makes the kernel use the set "console device" as a console > * The kernel records the command line as expected in the consol

Re: [Qemu-devel] [PATCH v3 4/5] scripts/qemu.py: introduce set_console() method

2018-05-30 Thread Stefan Hajnoczi
On Tue, May 29, 2018 at 03:37:29PM -0400, Cleber Rosa wrote: > The set_console() method is intended to ease higher level use cases > that require a console device. > > The amount of intelligence is limited on purpose, requiring either the > device type explicitly, or the existence of a machine (pa

[Qemu-devel] [PATCH] main-loop: drop spin_counter

2018-05-30 Thread Stefan Hajnoczi
Commit d759c951f3287fad04210a52f2dc93f94cf58c7f ("replay: push replay_mutex_lock up the call tree") removed the !timeout lock optimization in the main loop. The idea of the optimization was to avoid ping-pongs between threads by keeping the Big QEMU Lock held across non-blocking (!timeout) main lo

[Qemu-devel] [RFC PATCH] configure: Enable out-of-tree acceptance tests

2018-05-30 Thread Philippe Mathieu-Daudé
In order to allow out-of-tree acceptance tests with Avocado, create a symlink in the build tree. Signed-off-by: Philippe Mathieu-Daudé --- Based-on: 20180530184156.15634-1-cr...@redhat.com http://lists.nongnu.org/archive/html/qemu-devel/2018-05/msg06877.html Before: build_dir$ avocado run /f

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Eduardo Habkost
On Wed, May 30, 2018 at 02:00:48PM -0400, Cleber Rosa wrote: > > > On 05/30/2018 12:29 PM, Eduardo Habkost wrote: > > On Wed, May 30, 2018 at 01:57:05PM +0100, Stefan Hajnoczi wrote: > >> On Tue, May 29, 2018 at 03:37:28PM -0400, Cleber Rosa wrote: > >>> This patch adds a few simple behavior test

Re: [Qemu-devel] [PATCH 03/16] ahci: make port read traces more descriptive

2018-05-30 Thread John Snow
On 05/26/2018 12:44 AM, Philippe Mathieu-Daudé wrote: > Hi John, > > On 05/25/2018 08:54 PM, John Snow wrote: >> A trace is added to let us watch unimplemented registers specifically, >> as these are more likely to cause us trouble. Otherwise, the port read >> traces now tell us what register i

Re: [Qemu-devel] [PATCH 1/4] hw/block/fdc: Replace error_setg(&error_abort) by error_report() + abort()

2018-05-30 Thread John Snow
On 05/29/2018 01:48 PM, Philippe Mathieu-Daudé wrote: > Use error_report() + abort() instead of error_setg(&error_abort), > as suggested by the "qapi/error.h" documentation: > > Please don't error_setg(&error_fatal, ...), use error_report() and > exit(), because that's more obvious. >

Re: [Qemu-devel] [PATCH] main-loop: drop spin_counter

2018-05-30 Thread Jeff Cody
On Wed, May 30, 2018 at 08:42:38PM +0100, Stefan Hajnoczi wrote: > Commit d759c951f3287fad04210a52f2dc93f94cf58c7f ("replay: push > replay_mutex_lock up the call tree") removed the !timeout lock > optimization in the main loop. > > The idea of the optimization was to avoid ping-pongs between threa

Re: [Qemu-devel] [PATCH] migration/block-dirty-bitmap: fix dirty_bitmap_load

2018-05-30 Thread John Snow
On 05/30/2018 07:24 AM, Vladimir Sementsov-Ogievskiy wrote: > dirty_bitmap_load_header return code is obtained but not handled. Fix > this. > > Bug was introduced in b35ebdf076d697bc > "migration: add postcopy migration of dirty bitmaps" with the whole > function. > > Signed-off-by: Vladimir S

Re: [Qemu-devel] [PATCH v4 20/21] hw/ide: Remove unused include

2018-05-30 Thread John Snow
On 05/28/2018 07:27 PM, Philippe Mathieu-Daudé wrote: > There is no need to include pci.h in this file. > (Continue f23c81073a cleanup). > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: John Snow

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2018-05-30 Thread Andreas Hasenack
Also marking the ubuntu task as incomplete. It looks like it's sorted, but let's give it some time for people to comment if they still have an issue. ** Changed in: qemu (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2018-05-30 Thread Andreas Hasenack
Doing the same for the debian task, which doesn't have an upstream bug anyway. ** Changed in: qemu (Debian) Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/685096 Titl

Re: [Qemu-devel] [Qemu-block] [PATCH v2 21/40] job: Convert block_job_cancel_async() to Job

2018-05-30 Thread John Snow
On 05/29/2018 08:30 AM, Max Reitz wrote: > On 2018-05-29 13:59, Kashyap Chamarthy wrote: >> On Fri, May 25, 2018 at 10:00:35AM +0200, Kevin Wolf wrote: >>> Am 24.05.2018 um 19:42 hat John Snow geschrieben: >> >> [...] >> >> (Randomly chiming in for a small clarification.) >> >> or some other

Re: [Qemu-devel] [PATCH] Fix hang with -L and symlink loop

2018-05-30 Thread Richard Henderson
On 05/29/2018 04:44 PM, Evan Green wrote: > When using -L with Linux app emulation, there is an issue in > init_paths where Qemu will get lost exploring a directory tree > with a symlink loop in it. This causes Qemu to hang, and > eventually consume all memory in the system. > > Qemu's code for pr

Re: [Qemu-devel] [PATCH v4 5/5] Acceptance tests: add Linux kernel boot and console checking test

2018-05-30 Thread Philippe Mathieu-Daudé
Hi Cleber, On 05/30/2018 03:41 PM, Cleber Rosa wrote: > This test boots a Linux kernel, and checks that the given command > line was effective in two ways: > > * It makes the kernel use the set "console device" as a console > * The kernel records the command line as expected in the console > >

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Cleber Rosa
On 05/30/2018 04:00 PM, Eduardo Habkost wrote: > On Wed, May 30, 2018 at 02:00:48PM -0400, Cleber Rosa wrote: >> >> >> On 05/30/2018 12:29 PM, Eduardo Habkost wrote: >>> On Wed, May 30, 2018 at 01:57:05PM +0100, Stefan Hajnoczi wrote: On Tue, May 29, 2018 at 03:37:28PM -0400, Cleber Rosa wr

Re: [Qemu-devel] [PATCH v4 1/5] Add functional/acceptance tests infrastructure

2018-05-30 Thread Philippe Mathieu-Daudé
Hi Cleber, On 05/30/2018 03:41 PM, Cleber Rosa wrote: > This patch adds the very minimum infrastructure necessary for writing > and running functional/acceptance tests, including: > > * Documentation > * The avocado_qemu.Test base test class > * One example tests (version.py) > > Additional f

Re: [Qemu-devel] [PATCH v4 2/5] scripts/qemu.py: allow adding to the list of extra arguments

2018-05-30 Thread Philippe Mathieu-Daudé
On 05/30/2018 03:41 PM, Cleber Rosa wrote: > Tests will often need to add extra arguments to QEMU command > line arguments. > > Signed-off-by: Cleber Rosa > Reviewed-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > scripts/qemu.py | 6 ++

Re: [Qemu-devel] [PATCH v4 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Philippe Mathieu-Daudé
On 05/30/2018 03:41 PM, Cleber Rosa wrote: > This patch adds a few simple behavior tests for VNC. > > Signed-off-by: Cleber Rosa > Reviewed-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > tests/acceptance/vnc.py | 60

Re: [Qemu-devel] [PATCH v4 4/5] scripts/qemu.py: introduce set_console() method

2018-05-30 Thread Philippe Mathieu-Daudé
On 05/30/2018 03:41 PM, Cleber Rosa wrote: > The set_console() method is intended to ease higher level use cases > that require a console device. > > The amount of intelligence is limited on purpose, requiring either the > device type explicitly, or the existence of a machine (pattern) > definitio

Re: [Qemu-devel] [PATCH 03/16] ahci: make port read traces more descriptive

2018-05-30 Thread Philippe Mathieu-Daudé
On 05/30/2018 05:17 PM, John Snow wrote: > On 05/26/2018 12:44 AM, Philippe Mathieu-Daudé wrote: >> Hi John, >> >> On 05/25/2018 08:54 PM, John Snow wrote: >>> A trace is added to let us watch unimplemented registers specifically, >>> as these are more likely to cause us trouble. Otherwise, the por

Re: [Qemu-devel] [PATCH 1/4] hw/block/fdc: Replace error_setg(&error_abort) by error_report() + abort()

2018-05-30 Thread Philippe Mathieu-Daudé
On 05/30/2018 05:23 PM, John Snow wrote: > On 05/29/2018 01:48 PM, Philippe Mathieu-Daudé wrote: >> Use error_report() + abort() instead of error_setg(&error_abort), >> as suggested by the "qapi/error.h" documentation: >> >> Please don't error_setg(&error_fatal, ...), use error_report() and >>

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Eduardo Habkost
On Wed, May 30, 2018 at 05:03:56PM -0400, Cleber Rosa wrote: > On 05/30/2018 04:00 PM, Eduardo Habkost wrote: [...] > [...] Now, in addition to this very personal, and thus > insignificant botheration, it restricts API design. By signaling to > users that this is valid: > > self.vm.add_

Re: [Qemu-devel] [PATCH 02/15] linux-user: move alpha fcntl definitions to alpha/target_fcntl.h

2018-05-30 Thread Richard Henderson
On 05/29/2018 12:41 PM, Laurent Vivier wrote: > No code change. > > Signed-off-by: Laurent Vivier > --- > linux-user/alpha/target_fcntl.h | 29 + > linux-user/syscall_defs.h | 32 ++-- > 2 files changed, 31 insertions(+), 30 deletions

Re: [Qemu-devel] [PATCH 03/15] linux-user: move hppa fcntl definitions to hppa/target_fcntl.h

2018-05-30 Thread Richard Henderson
On 05/29/2018 12:41 PM, Laurent Vivier wrote: > No code change. > > Signed-off-by: Laurent Vivier > --- > linux-user/hppa/target_fcntl.h | 31 +++ > linux-user/syscall_defs.h | 34 +- > 2 files changed, 32 insertions(+), 33 deletio

Re: [Qemu-devel] [PATCH 04/15] linux-user: move arm/aarch64/m68k fcntl definitions to [arm|aarch64|m68k]/target_fcntl.h

2018-05-30 Thread Richard Henderson
On 05/29/2018 12:41 PM, Laurent Vivier wrote: > No code change. > > Signed-off-by: Laurent Vivier > --- > linux-user/aarch64/target_fcntl.h | 5 + > linux-user/arm/target_fcntl.h | 6 ++ > linux-user/m68k/target_fcntl.h| 6 ++ > linux-user/syscall_defs.h | 7 +-- >

Re: [Qemu-devel] [PATCH 08/15] linux-user: move get_sp_from_cpustate() to target_cpu.h

2018-05-30 Thread Richard Henderson
On 05/29/2018 12:42 PM, Laurent Vivier wrote: > Remove useless includes > Fix HPPA include guard. > > Signed-off-by: Laurent Vivier > --- Acked-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 00/15] linux-user: move more definitions out of syscall_defs.h

2018-05-30 Thread Richard Henderson
On 05/29/2018 12:41 PM, Laurent Vivier wrote: > Move fcntl.h definitions to target directories. > Introduce a generic header for the targets without > specific definitions. > Move more signal.h definitions to target directories. > > Laurent Vivier (15): > linux-user: move generic fcntl definitio

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Cleber Rosa
On 05/30/2018 05:31 PM, Eduardo Habkost wrote: > On Wed, May 30, 2018 at 05:03:56PM -0400, Cleber Rosa wrote: >> On 05/30/2018 04:00 PM, Eduardo Habkost wrote: > [...] >> [...] Now, in addition to this very personal, and thus >> insignificant botheration, it restricts API design. By sig

Re: [Qemu-devel] [PATCH v3 00/17] tcg: tb_lock removal redux v3

2018-05-30 Thread Richard Henderson
On 05/21/2018 04:39 PM, Emilio G. Cota wrote: > v2: https://lists.nongnu.org/archive/html/qemu-devel/2018-04/msg00656.html > > Changes since v2: > > - rebase onto master, fixing conflicts > > - add R-b's > > - add a missing page_lock to page_collection_lock > > - add a couple of missing assert

Re: [Qemu-devel] [PATCH v3 00/17] tcg: tb_lock removal redux v3

2018-05-30 Thread Richard Henderson
On 05/30/2018 03:46 PM, Richard Henderson wrote: > Thanks. Queued to tcg-next. Hmph. Unqueued, at least for now. ERROR:/home/rth/work/qemu/qemu/accel/tcg/translate-all.c:615:page_unlock__debug: assertion failed: (page_is_locked(pd)) #3 0x74b6915e in g_assertion_message_expr () at /

[Qemu-devel] [PULL 00/12] NUMA queue, 2018-05-30

2018-05-30 Thread Eduardo Habkost
The following changes since commit e609fa71e89c81fbe2670411be62da95dfb093e0: Merge remote-tracking branch 'remotes/edgar/tags/edgar/xilinx-next-2018-05-29-v1.for-upstream' into staging (2018-05-29 13:01:11 +0100) are available in the Git repository at: git://github.com/ehabkost/qemu.git ta

[Qemu-devel] [PULL 03/12] numa: split out NumaOptions parsing into set_numa_options()

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov it will allow to reuse set_numa_options() for parsing configuration commands received via QMP interface Signed-off-by: Igor Mammedov Message-Id: <1525423069-61903-3-git-send-email-imamm...@redhat.com> Signed-off-by: Eduardo Habkost --- include/sysemu/numa.h | 1 + numa.c

[Qemu-devel] [PULL 01/12] numa: clarify error message when node index is out of range in -numa dist, ...

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov When using following CLI: -numa dist,src=128,dst=1,val=20 user gets a rather confusing error message: "Invalid node 128, max possible could be 128" Where 128 is number of nodes that QEMU supports (MAX_NODES), while src/dst is an index up to that limit, so it should be MA

[Qemu-devel] [PULL 05/12] hmp: disable monitor in preconfig state

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov Ban it for now, if someone would need it to work early, one would have to implement checks if HMP command is valid at preconfig state. Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake Message-Id: <1525423069-61903-5-git-send-email-imamm...@redhat.com> Signed-off-by: Edu

[Qemu-devel] [PULL 02/12] numa: postpone options post-processing till machine_run_board_init()

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov in preparation for numa options to being handled via QMP before machine_run_board_init(), move final numa configuration checks and processing to machine_run_board_init() so it could take into account both CLI (via parse_numa_opts()) and QMP input Signed-off-by: Igor Mammedov

[Qemu-devel] [PULL 04/12] qapi: introduce preconfig runstate

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov New preconfig runstate will be used in follow up patches related to introducing --preconfig CLI option and is intended to replace prelaunch runstate from QEMU start up to machine_init callback. Signed-off-by: Igor Mammedov Message-Id: <1525423069-61903-4-git-send-email-imamm

[Qemu-devel] [PULL 07/12] tests: qapi-schema tests for allow-preconfig

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov use new allow-preconfig parameter in tests and make sure that the QAPISchema can parse allow-preconfig correctly Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake Message-Id: <1526058959-41425-1-git-send-email-imamm...@redhat.com> Signed-off-by: Eduardo Habkost --- tes

[Qemu-devel] [PULL 06/12] qapi: introduce new cmd option "allow-preconfig"

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov New option will be used to allow commands, which are prepared/need to run, during preconfig state. Other commands that should be able to run in preconfig state, should be amended to not expect machine in initialized state or deal with it. For compatibility reasons, commands t

[Qemu-devel] [PULL 08/12] cli: add --preconfig option

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov This option allows pausing QEMU in the new RUN_STATE_PRECONFIG state, allowing the configuration of QEMU from QMP before the machine jumps into board initialization code of machine_run_board_init() The intent is to allow management to query machine state and additionally conf

[Qemu-devel] [PULL 10/12] qmp: permit query-hotpluggable-cpus in preconfig state

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov it will allow mgmt to query possible CPUs, which depends on used machine(version)/-smp options, without restarting QEMU and use results to configure numa mapping or adding CPUs with device_add* later. PS: *) device_add is not allowed to run at preconfig in this series but

[Qemu-devel] [PULL 09/12] tests: extend qmp test with preconfig checks

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov Add permission checks for commands at 'preconfig' stage. Signed-off-by: Igor Mammedov Message-Id: <1526556524-267991-1-git-send-email-imamm...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Eduardo Habkost --- tests/qmp-test.c | 47

Re: [Qemu-devel] [PATCH 03/20] target/openrisc: Fix singlestep_enabled

2018-05-30 Thread Stafford Horne
On Sun, May 27, 2018 at 09:13:07AM -0500, Richard Henderson wrote: > We failed to store to cpu_pc before raising the exception, > which caused us to re-execute the same insn that we stepped. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

[Qemu-devel] [PULL 11/12] qmp: add set-numa-node command

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov Command is allowed to run only in preconfig stage and will allow to configure numa mapping for CPUs depending on possible CPUs layout (query-hotpluggable-cpus) for given machine instance. Example of configuration session: $QEMU -smp 2 --preconfig ... QMP: -> {'execute': 'que

[Qemu-devel] [PULL 12/12] tests: functional tests for QMP command set-numa-node

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov * start QEMU with 2 unmapped cpus, * while in preconfig state * add 2 numa nodes * assign cpus to them * exit preconfig and in running state check that cpus are mapped correctly. Signed-off-by: Igor Mammedov Message-Id: <1526556607-268163-1-git-send-email-imamm

Re: [Qemu-devel] [PATCH 02/20] target/openrisc: Use exit_tb instead of CPU_INTERRUPT_EXITTB

2018-05-30 Thread Stafford Horne
On Sun, May 27, 2018 at 09:13:06AM -0500, Richard Henderson wrote: > No need to use the interrupt mechanisms when we can > simply exit the tb directly. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

Re: [Qemu-devel] [PATCH 00/20] target/openrisc improvements

2018-05-30 Thread Stafford Horne
On Sun, May 27, 2018 at 09:13:04AM -0500, Richard Henderson wrote: > This is almost a grab-bag of little improvements to the port. > > patches 1-3: > Fix singlestepping for gdbstub. This has apparently never > worked, as the first commit has the same bug of not advancing > the pc when stepp

Re: [Qemu-devel] [PATCH 08/20] target/openrisc: Merge tlb allocation into CPUOpenRISCState

2018-05-30 Thread Stafford Horne
On Sun, May 27, 2018 at 09:13:12AM -0500, Richard Henderson wrote: > There is no reason to allocate this separately. This was probably > copied from target/mips which makes the same mistake. > > While doing so, move tlb into the clear-on-reset range. While not > all of the TLB bits are guarantee

Re: [Qemu-devel] [PATCH 05/20] target/openrisc: Split out is_user

2018-05-30 Thread Stafford Horne
On Sun, May 27, 2018 at 09:13:09AM -0500, Richard Henderson wrote: > This allows us to limit the amount of ifdefs and isolate > the test for usermode. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

Re: [Qemu-devel] [PATCH 04/20] target/openrisc: Link more translation blocks

2018-05-30 Thread Stafford Horne
On Sun, May 27, 2018 at 09:13:08AM -0500, Richard Henderson wrote: > Track direct jumps via dc->jmp_pc_imm. Use that in > preference to jmp_pc when possible. Emit goto_tb in > that case, and lookup_and_goto_tb otherwise. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

Re: [Qemu-devel] [PATCH 06/20] target/openrisc: Exit the TB after l.mtspr

2018-05-30 Thread Stafford Horne
On Sun, May 27, 2018 at 09:13:10AM -0500, Richard Henderson wrote: > A store to SR changes interrupt state, which should return > to the main loop to recognize that state. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

Re: [Qemu-devel] [PATCH 01/20] target/openrisc: Remove DISAS_JUMP & DISAS_TB_JUMP

2018-05-30 Thread Stafford Horne
On Sun, May 27, 2018 at 09:13:05AM -0500, Richard Henderson wrote: > These values are unused. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

Re: [Qemu-devel] [RFC PATCH] configure: Enable out-of-tree acceptance tests

2018-05-30 Thread Eduardo Habkost
On Wed, May 30, 2018 at 05:03:34PM -0300, Philippe Mathieu-Daudé wrote: > In order to allow out-of-tree acceptance tests with Avocado, > create a symlink in the build tree. > "In other to allow" seems to imply that running acceptance tests on an out-of-tree build is impossible without this patch,

[Qemu-devel] [Bug 1769189] Re: Issue with qemu 2.12.0 + SATA

2018-05-30 Thread John Snow
There might be multiple issues present and I'm having difficulty reliably doing any kind of regression testing here, but I think this patch helps fix at least one of the issues I was seeing that occurs specifically during early boot. It may fix other hangs. ** Patch added: "sata.patch" https:

[Qemu-devel] [PATCH 3/3] ahci: don't schedule unnecessary BH

2018-05-30 Thread John Snow
The comment gives us a hint. *Maybe* we still have something to process. Well, why not check? Signed-off-by: John Snow --- hw/ide/ahci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index a9558e45e7..380366b038 100644 --- a/hw/ide/ahci.c +++

[Qemu-devel] [PATCH 0/3] ahci: fix completion race condition

2018-05-30 Thread John Snow
Commit d759c951f changed the main thread lock release/reacquisition, and in so doing apparently jostled loose a race condition in the AHCI code. Patch 2 should be sufficient to fix this, and patches 1 and 3 are just little trivial fixes. This might be sufficient to fix the bug as reported at http

[Qemu-devel] [PATCH 2/3] ahci: fix PxCI register race

2018-05-30 Thread John Snow
AHCI presently signals completion prior to the PxCI register being cleared to indicate completion. If a guest driver attempts to issue a new command in its IRQ handler, it might be surprised to learn there is still a command pending. In the case of Windows 10's boot driver, it will actually poll t

<    1   2   3   4   >