Re: [Qemu-devel] [PATCH v3 1/5] Add functional/acceptance tests infrastructure

2018-05-30 Thread Stefan Hajnoczi
On Tue, May 29, 2018 at 03:37:26PM -0400, Cleber Rosa wrote: > diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst > index 0ca1a2d4b5..5e090c87fb 100644 > --- a/docs/devel/testing.rst > +++ b/docs/devel/testing.rst > @@ -484,3 +484,156 @@ supported. To start the fuzzer, run > > Alternat

Re: [Qemu-devel] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary

2018-05-30 Thread Michael S. Tsirkin
On Wed, May 30, 2018 at 03:19:19AM -0300, Philippe Mathieu-Daudé wrote: > Le mer. 30 mai 2018 02:50, Philippe Mathieu-Daudé a écrit : > > On Wed, May 30, 2018 at 1:42 AM, Michael S. Tsirkin > wrote: > > On Wed, May 30, 2018 at 12:12:55AM -0300, Philippe Mathieu-Daudé wrote: > >> Hi

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post about the new -nic parameter

2018-05-30 Thread Paolo Bonzini
On 30/05/2018 14:18, Thomas Huth wrote: > QEMU v2.12 features a new, useful parameter called "-nic". Let's > throw some light on this new parameter with a new blog post. Nice! > Signed-off-by: Thomas Huth > --- > _posts/2018-05-30-nic-parameter.md | 126 > +

Re: [Qemu-devel] [PATCH v4 01/14] memory-device: drop assert related to align and start of address space

2018-05-30 Thread Igor Mammedov
On Tue, 29 May 2018 18:02:06 +0200 David Hildenbrand wrote: > On 29.05.2018 15:27, Igor Mammedov wrote: > > On Thu, 17 May 2018 10:15:14 +0200 > > David Hildenbrand wrote: > > > >> The start of the address space does not have to be aligned for the > >> search. Handle this case explicitly when

Re: [Qemu-devel] [PATCH v4 02/14] memory-device: introduce separate config option

2018-05-30 Thread Igor Mammedov
On Thu, 17 May 2018 10:15:15 +0200 David Hildenbrand wrote: > Some architectures might support memory devices, while they don't > support DIMM/NVDIMM. So let's > - Rename CONFIG_MEM_HOTPLUG to CONFIG_MEM_DEVICE > - Introduce CONFIG_DIMM and use it similarly to CONFIG NVDIMM > > CONFIG_DIMM and C

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Stefan Hajnoczi
On Tue, May 29, 2018 at 03:37:28PM -0400, Cleber Rosa wrote: > This patch adds a few simple behavior tests for VNC. > > Signed-off-by: Cleber Rosa > --- > tests/acceptance/vnc.py | 60 + > 1 file changed, 60 insertions(+) > create mode 100644 tests/accept

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Stefan Hajnoczi
On Tue, May 29, 2018 at 03:37:28PM -0400, Cleber Rosa wrote: > This patch adds a few simple behavior tests for VNC. > > Signed-off-by: Cleber Rosa > --- > tests/acceptance/vnc.py | 60 + > 1 file changed, 60 insertions(+) > create mode 100644 tests/accept

Re: [Qemu-devel] [PATCH v3 2/5] scripts/qemu.py: allow adding to the list of extra arguments

2018-05-30 Thread Stefan Hajnoczi
On Tue, May 29, 2018 at 03:37:27PM -0400, Cleber Rosa wrote: > Tests will often need to add extra arguments to QEMU command > line arguments. > > Signed-off-by: Cleber Rosa > --- > scripts/qemu.py | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Descri

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Fam Zheng
On Wed, 05/30 13:57, Stefan Hajnoczi wrote: > On Tue, May 29, 2018 at 03:37:28PM -0400, Cleber Rosa wrote: > > This patch adds a few simple behavior tests for VNC. > > > > Signed-off-by: Cleber Rosa > > --- > > tests/acceptance/vnc.py | 60 + > > 1 file ch

Re: [Qemu-devel] [PATCH] qga: add mountpoint usage to GuestFilesystemInfo

2018-05-30 Thread Eric Blake
On 05/30/2018 01:55 AM, Chen Hanxiao wrote: +usage = u100 / nonroot_total + (u100 % nonroot_total != 0); Why integral instead of floating point? I followed the style of df from coreutils. As the percentage already multiplied by 100, I think it has enough precision. You're making an arb

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-05-30 Thread Roman Kagan
On Wed, May 30, 2018 at 02:17:55PM +0200, Max Reitz wrote: > On 2018-04-26 18:19, Roman Kagan wrote: > > @@ -550,13 +561,26 @@ def verify_cache_mode(supported_cache_modes=[]): > > if supported_cache_modes and (cachemode not in supported_cache_modes): > > notrun('not suitable for this

Re: [Qemu-devel] [PATCH v2] qga: add mountpoint usage to GuestFilesystemInfo

2018-05-30 Thread Eric Blake
On 05/30/2018 04:01 AM, Chen Hanxiao wrote: From: Chen Hanxiao This patch adds support for getting the usage of mounted filesystem. It's very useful when we try to monitor guest's filesystem. Cc: Michael Roth Signed-off-by: Chen Hanxiao --- v2: add description in qapi-schema and version

Re: [Qemu-devel] [PATCH v4 04/14] pc: prepare for multi stage hotplug handlers

2018-05-30 Thread Igor Mammedov
On Thu, 17 May 2018 10:15:17 +0200 David Hildenbrand wrote: > For multi stage hotplug handlers, we'll have to do some error handling > in some hotplug functions, so let's use a local error variable (except > for unplug requests). I'd split out introducing local error into separate patch so patch

Re: [Qemu-devel] [PATCH v4 05/14] pc: route all memory devices through the machine hotplug handler

2018-05-30 Thread Igor Mammedov
On Thu, 17 May 2018 10:15:18 +0200 David Hildenbrand wrote: > Necessary to hotplug them cleanly later. We could drop the PC_DIMM > check, as PC_DIMM are just memory devices, but this approach is cleaner. > > Signed-off-by: David Hildenbrand > --- > hw/i386/pc.c | 2 ++ > 1 file changed, 2 inse

Re: [Qemu-devel] [[Qemu devel] RFC] hw/net: Add Smartfusion2 emac block

2018-05-30 Thread sundeep subbaraya
Hi Peter, On Tue, May 29, 2018 at 10:13 PM, Peter Maydell wrote: > On 26 May 2018 at 10:51, Subbaraya Sundeep wrote: >> Modelled Ethernet MAC of Smartfusion2 SoC. >> Micrel KSZ8051 PHY is present on Emcraft's SOM kit hence same >> PHY is emulated. >> >> Signed-off-by: Subbaraya Sundeep > > Hi;

[Qemu-devel] KVM internal error with kvm-pr on ppc64le

2018-05-30 Thread Loic Devulder
Hi guys! I tried to start a Linux CD (I tried openSUSE Leap 42.3) to install my ppc64le VM with kvm-pr (yes kvm-pr!) on a Power8 host and I have some issues... My host system is an openSUSE Tumbleweed 20180525 with qemu 2.11 and kernel 4.16.11. I tried different version of qemu without any suc

[Qemu-devel] [RFC PATCH v1 2/2] tcg: add instrumenting module

2018-05-30 Thread Pavel Dovgalyuk
This is a samples of the instrumenting interface and implementation of some instruction tracing tasks. Signed-off-by: Pavel Dovgalyuk --- accel/tcg/Makefile.objs|1 accel/tcg/instrument/Makefile.objs |1 accel/tcg/instrument/helper.h |1 accel/tcg/instrument/instr

[Qemu-devel] [RFC PATCH v1 1/2] tcg: add headers for non-target helpers

2018-05-30 Thread Pavel Dovgalyuk
This patch adds functions and headers for adding the helpers from the modules other than the target translators. Signed-off-by: Pavel Dovgalyuk --- include/exec/helper-register.h | 53 tcg/tcg.c | 12 + tcg/tcg.h

[Qemu-devel] [RFC PATCH v1 0/2] QEMU binary instrumentation prototype

2018-05-30 Thread Pavel Dovgalyuk
The following series implements dynamic binary instrumentation upon QEMU. It is based on the following prior sources: - KVM Forum 2017 talk "Instrumenting, Introspection, and Debugging with QEMU" https://www.linux-kvm.org/images/3/3d/Introspect.pdf - Discussion on Lluis Vilanova instrumentati

Re: [Qemu-devel] [PATCH v2 00/16] block: Make blockdev-create a job and stable API

2018-05-30 Thread Jeff Cody
On Tue, May 29, 2018 at 09:43:16PM -0400, Jeff Cody wrote: > On Tue, May 29, 2018 at 10:38:54PM +0200, Kevin Wolf wrote: > > This changes the x-blockdev-create QMP command so that it doesn't block > > the monitor and the main loop any more, but starts a background job that > > performs the image cr

Re: [Qemu-devel] [PATCH v4 1/2] qemu-error: introduce {error|warn}_report_once

2018-05-30 Thread Cornelia Huck
On Wed, 30 May 2018 11:30:45 +0800 Peter Xu wrote: > On Tue, May 29, 2018 at 11:30:00AM +0200, Cornelia Huck wrote: > > On Thu, 24 May 2018 12:44:53 +0800 > > Peter Xu wrote: > > > > > There are many error_report()s that can be used in frequently called > > > functions, especially on IO paths

Re: [Qemu-devel] [RFC PATCH v1 0/2] QEMU binary instrumentation prototype

2018-05-30 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 152768551387.13955.7085403440722380428.stgit@pasha-ThinkPad-T60 Subject: [Qemu-devel] [RFC

Re: [Qemu-devel] [RFC PATCH v1 0/2] QEMU binary instrumentation prototype

2018-05-30 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 152768551387.13955.7085403440722380428.stgit@pasha-ThinkPad-T60 Subject: [Qemu-devel] [RFC PATCH v1 0/2] QEMU binary instrumentation prototype === TEST SCRIPT BEGIN === #!/bin/bash # Testing

Re: [Qemu-devel] [PATCH 00/17] iotests: don't choke on disabled drivers

2018-05-30 Thread Roman Kagan
On Wed, May 30, 2018 at 02:35:34PM +0200, Max Reitz wrote: > On 2018-04-26 18:19, Roman Kagan wrote: > > Some iotests assume availability of certain block drivers, and fail if > > the driver is not supported by QEMU because it was disabled at configure > > time. > > > > This series tries to addres

Re: [Qemu-devel] [PATCH v4 1/2] qemu-error: introduce {error|warn}_report_once

2018-05-30 Thread Cornelia Huck
On Wed, 30 May 2018 14:39:55 +0800 Peter Xu wrote: > On Wed, May 30, 2018 at 07:47:32AM +0300, Michael S. Tsirkin wrote: > > On Thu, May 24, 2018 at 12:44:53PM +0800, Peter Xu wrote: > > > There are many error_report()s that can be used in frequently called > > > functions, especially on IO pat

Re: [Qemu-devel] [PATCH 00/17] iotests: don't choke on disabled drivers

2018-05-30 Thread Max Reitz
On 2018-05-30 15:47, Roman Kagan wrote: > On Wed, May 30, 2018 at 02:35:34PM +0200, Max Reitz wrote: >> On 2018-04-26 18:19, Roman Kagan wrote: >>> Some iotests assume availability of certain block drivers, and fail if >>> the driver is not supported by QEMU because it was disabled at configure >>>

[Qemu-devel] [Bug 1077116] Re: automoc4 segfaults when building in an armhf pbuilder on an amd64 host

2018-05-30 Thread  Christian Ehrhardt 
We have had a few more issues around armhf qemu-static that mostly resolved in Artful (qemu 2.10) and finally one that was good in Bionic (qemu 2.11). This also included some updates to other components but should be good now. If the issue here really still applies to a newer version please reope

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers

2018-05-30 Thread Paolo Bonzini
On 25/05/2018 14:43, David Hildenbrand wrote: > On 17.05.2018 10:15, David Hildenbrand wrote: >> We can have devices that need certain other resources that are e.g. >> system resources managed by the machine. We need a clean way to assign >> these resources (without violating layers as brought up b

Re: [Qemu-devel] [PATCH v4 01/14] memory-device: drop assert related to align and start of address space

2018-05-30 Thread David Hildenbrand
On 30.05.2018 14:57, Igor Mammedov wrote: > On Tue, 29 May 2018 18:02:06 +0200 > David Hildenbrand wrote: > >> On 29.05.2018 15:27, Igor Mammedov wrote: >>> On Thu, 17 May 2018 10:15:14 +0200 >>> David Hildenbrand wrote: >>> The start of the address space does not have to be aligned for

Re: [Qemu-devel] [PATCH v4 05/14] pc: route all memory devices through the machine hotplug handler

2018-05-30 Thread David Hildenbrand
On 30.05.2018 15:12, Igor Mammedov wrote: > On Thu, 17 May 2018 10:15:18 +0200 > David Hildenbrand wrote: > >> Necessary to hotplug them cleanly later. We could drop the PC_DIMM >> check, as PC_DIMM are just memory devices, but this approach is cleaner. >> >> Signed-off-by: David Hildenbrand >>

Re: [Qemu-devel] [PATCH v4 04/14] pc: prepare for multi stage hotplug handlers

2018-05-30 Thread David Hildenbrand
On 30.05.2018 15:08, Igor Mammedov wrote: > On Thu, 17 May 2018 10:15:17 +0200 > David Hildenbrand wrote: > >> For multi stage hotplug handlers, we'll have to do some error handling >> in some hotplug functions, so let's use a local error variable (except >> for unplug requests). > I'd split out

Re: [Qemu-devel] [PATCH 00/17] iotests: don't choke on disabled drivers

2018-05-30 Thread Roman Kagan
On Wed, May 30, 2018 at 03:53:52PM +0200, Max Reitz wrote: > On 2018-05-30 15:47, Roman Kagan wrote: > > On Wed, May 30, 2018 at 02:35:34PM +0200, Max Reitz wrote: > >> On 2018-04-26 18:19, Roman Kagan wrote: > >>> Some iotests assume availability of certain block drivers, and fail if > >>> the dri

[Qemu-devel] [PATCH 0/2] ARM virt: Support up to 256 PCIe buses

2018-05-30 Thread Eric Auger
Current Machvirt PCI host controller's ECAM region is 16MB large. This limits the number of PCIe buses to 16. PC/Q35 machines have a 256MB region allowing up to 256 buses. This series tries to bridge the gap. It declares a new ECAM region located beyond 256GB, of size 256MB The new ECAM region is

Re: [Qemu-devel] [PATCH v4 05/14] pc: route all memory devices through the machine hotplug handler

2018-05-30 Thread Paolo Bonzini
On 30/05/2018 16:08, David Hildenbrand wrote: >>> if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM) || >>> +object_dynamic_cast(OBJECT(dev), TYPE_MEMORY_DEVICE) || >> you probably could drop TYPE_PC_DIMM above, it's redundant since DIMM >> can be cast to TYPE_MEMORY_DEVICE >> >> ditto

[Qemu-devel] [PATCH 1/2] hw/arm/virt: Add a new 256MB ECAM region

2018-05-30 Thread Eric Auger
This patch defines a new ECAM region located after the 256GB limit. The virt machine state is augmented with a new highmem_ecam field which guards the usage of this new ECAM region instead of the legacy 16MB one. With the highmem ECAM region, up to 256 PCIe buses can be used. Signed-off-by: Eric

[Qemu-devel] [PATCH 2/2] hw/arm/virt: Add virt-3.0 machine type

2018-05-30 Thread Eric Auger
Add virt-3.0 machine type. This machine type supports highmem 256MB ECAM by default. This feature is disabled for earlier machine types and if highmem is off. The high 256MB ECAM region is chosen instead of the legacy 16MB one if the machine type allows it, if highmem is set (LPAE supported by th

Re: [Qemu-devel] [PATCH v4 05/14] pc: route all memory devices through the machine hotplug handler

2018-05-30 Thread David Hildenbrand
On 30.05.2018 16:27, Paolo Bonzini wrote: > On 30/05/2018 16:08, David Hildenbrand wrote: if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM) || +object_dynamic_cast(OBJECT(dev), TYPE_MEMORY_DEVICE) || >>> you probably could drop TYPE_PC_DIMM above, it's redundant since DIMM >

Re: [Qemu-devel] [PATCH v2 00/16] block: Make blockdev-create a job and stable API

2018-05-30 Thread Kevin Wolf
Am 29.05.2018 um 22:38 hat Kevin Wolf geschrieben: > This changes the x-blockdev-create QMP command so that it doesn't block > the monitor and the main loop any more, but starts a background job that > performs the image creation. > > The basic job as implemented here is all that is necessary to m

Re: [Qemu-devel] [RFC v2 0/6] hw/arm: Add support for non-contiguous iova regions

2018-05-30 Thread Shameerali Kolothum Thodi
Hi Eric, > -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: Monday, May 28, 2018 3:22 PM > To: Shameerali Kolothum Thodi ; > qemu-devel@nongnu.org; qemu-...@nongnu.org > Cc: drjo...@redhat.com; imamm...@redhat.com; peter.mayd...@linaro.org; > alex.william...@red

[Qemu-devel] [PATCH] tap: fix memory leak on success to create a tap device

2018-05-30 Thread wangyunjian
From: Yunjian Wang Signed-off-by: Yunjian Wang --- net/tap.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/net/tap.c b/net/tap.c index de05f20..6d7710f 100644 --- a/net/tap.c +++ b/net/tap.c @@ -803,7 +803,8 @@ int net_init_tap(const Netdev *netdev, const

[Qemu-devel] [PATCH] target/ppc: Allow privileged access to SPR_PCR

2018-05-30 Thread Joel Stanley
The powerpc Linux kernel[1] and skiboot firmware[2] recently gained changes that cause the Processor Compatibility Register (PCR) SPR to be cleared. These changes cause Linux to fail to boot on the Qemu powernv machine with an error: Trying to write privileged spr 338 (0x152) at 30017f0c

Re: [Qemu-devel] [RFC v2 1/6] hw/vfio: Retrieve valid iova ranges from kernel

2018-05-30 Thread Shameerali Kolothum Thodi
Hi Eric, > -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: Monday, May 28, 2018 3:21 PM > To: Shameerali Kolothum Thodi ; > qemu-devel@nongnu.org; qemu-...@nongnu.org > Cc: peter.mayd...@linaro.org; drjo...@redhat.com; Jonathan Cameron > ; Linuxarm ; > alex.wil

Re: [Qemu-devel] [Qemu-block] Some question about savem/qcow2 incremental snapshot

2018-05-30 Thread Stefan Hajnoczi
On Mon, May 14, 2018 at 02:48:47PM +0100, Stefan Hajnoczi wrote: > On Fri, May 11, 2018 at 07:25:31PM +0200, Kevin Wolf wrote: > > Am 10.05.2018 um 10:26 hat Stefan Hajnoczi geschrieben: > > > On Wed, May 09, 2018 at 07:54:31PM +0200, Max Reitz wrote: > > > > On 2018-05-09 12:16, Stefan Hajnoczi wr

Re: [Qemu-devel] [RFC v2 2/6] hw/arm/virt: Enable dynamic generation of guest RAM memory regions

2018-05-30 Thread Shameerali Kolothum Thodi
Hi Eric. > -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: Monday, May 28, 2018 3:22 PM > To: Shameerali Kolothum Thodi ; > qemu-devel@nongnu.org; qemu-...@nongnu.org > Cc: drjo...@redhat.com; imamm...@redhat.com; peter.mayd...@linaro.org; > alex.william...@red

Re: [Qemu-devel] [RFC v2 3/6] hw/arm/virt: Add pc-dimm mem hotplug framework

2018-05-30 Thread Shameerali Kolothum Thodi
Hi Eric, > -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: Monday, May 28, 2018 3:22 PM > To: Shameerali Kolothum Thodi ; > qemu-devel@nongnu.org; qemu-...@nongnu.org > Cc: drjo...@redhat.com; imamm...@redhat.com; peter.mayd...@linaro.org; > alex.william...@red

Re: [Qemu-devel] [RFC v2 4/6] hw/arm: Changes required to accommodate non-contiguous DT mem nodes

2018-05-30 Thread Shameerali Kolothum Thodi
Hi Eric, > -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: Monday, May 28, 2018 3:22 PM > To: Shameerali Kolothum Thodi ; > qemu-devel@nongnu.org; qemu-...@nongnu.org > Cc: peter.mayd...@linaro.org; drjo...@redhat.com; Jonathan Cameron > ; Linuxarm ; > alex.wil

Re: [Qemu-devel] [PATCH v4 04/12] migration: avoid concurrent invoke channel_close by different threads

2018-05-30 Thread Dr. David Alan Gilbert
* Lidong Chen (jemmy858...@gmail.com) wrote: > From: Lidong Chen > > The channel_close maybe invoked by different threads. For example, source > qemu invokes qemu_fclose in main thread, migration thread and return path > thread. Destination qemu invokes qemu_fclose in main thread, listen thread >

Re: [Qemu-devel] [RFC v2 6/6] hw/arm: Populate non-contiguous memory regions

2018-05-30 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: Monday, May 28, 2018 3:22 PM > To: Shameerali Kolothum Thodi ; > qemu-devel@nongnu.org; qemu-...@nongnu.org > Cc: drjo...@redhat.com; imamm...@redhat.com; peter.mayd...@linaro.org; > alex.william...@redhat.com

Re: [Qemu-devel] [RFC v2 2/6] hw/arm/virt: Enable dynamic generation of guest RAM memory regions

2018-05-30 Thread Shameerali Kolothum Thodi
Hi Drew, Thanks for going through this. > -Original Message- > From: Andrew Jones [mailto:drjo...@redhat.com] > Sent: Monday, May 28, 2018 5:47 PM > To: Shameerali Kolothum Thodi > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > peter.mayd...@linaro.org; Jonathan Cameron > ; Linuxarm ;

Re: [Qemu-devel] [RFC v2 5/6] hw/arm: ACPI SRAT changes to accommodate non-contiguous mem

2018-05-30 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Andrew Jones [mailto:drjo...@redhat.com] > Sent: Monday, May 28, 2018 6:02 PM > To: Shameerali Kolothum Thodi > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > peter.mayd...@linaro.org; Jonathan Cameron > ; Linuxarm ; > eric.au...@redhat.com; alex.william.

Re: [Qemu-devel] [PATCH] trace: Sort trace-events-subdirs

2018-05-30 Thread Stefan Hajnoczi
On Mon, May 28, 2018 at 02:40:55AM -0300, Philippe Mathieu-Daudé wrote: > Having these entries sorted helps to add new ones. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Makefile.objs | 82 +-- > 1 file changed, 41 insertions(+), 41 deletions(

Re: [Qemu-devel] [PATCH v4 1/2] qemu-error: introduce {error|warn}_report_once

2018-05-30 Thread Halil Pasic
On 05/30/2018 06:47 AM, Michael S. Tsirkin wrote: On Thu, May 24, 2018 at 12:44:53PM +0800, Peter Xu wrote: There are many error_report()s that can be used in frequently called functions, especially on IO paths. That can be unideal in that malicious guest can try to trigger the error tons of

Re: [Qemu-devel] [PATCH v4 1/2] qemu-error: introduce {error|warn}_report_once

2018-05-30 Thread Michael S. Tsirkin
On Wed, May 30, 2018 at 05:15:19PM +0200, Halil Pasic wrote: > > > On 05/30/2018 06:47 AM, Michael S. Tsirkin wrote: > > On Thu, May 24, 2018 at 12:44:53PM +0800, Peter Xu wrote: > > > There are many error_report()s that can be used in frequently called > > > functions, especially on IO paths. T

Re: [Qemu-devel] [PATCH] migration/block-dirty-bitmap: fix dirty_bitmap_load

2018-05-30 Thread Eric Blake
On 05/30/2018 06:24 AM, Vladimir Sementsov-Ogievskiy wrote: dirty_bitmap_load_header return code is obtained but not handled. Fix this. Bug was introduced in b35ebdf076d697bc "migration: add postcopy migration of dirty bitmaps" with the whole function. Signed-off-by: Vladimir Sementsov-Ogievski

Re: [Qemu-devel] [PATCH v2 2/3] slirp/ncsi: add a "Get Parameters" response

2018-05-30 Thread Philippe Mathieu-Daudé
On 05/30/2018 03:10 AM, Cédric Le Goater wrote: > Command 0x17 'Get Parameters' is used to get configuration parameter > values currently in effect on the controller and it is mandatory in > the NS-CI specification. > > Provide a minimum response to exercise the kernel. > > Signed-off-by: Cédric

Re: [Qemu-devel] [RFC v2 0/6] hw/arm: Add support for non-contiguous iova regions

2018-05-30 Thread Auger Eric
Hi Shameer; On 05/30/2018 04:39 PM, Shameerali Kolothum Thodi wrote: > Hi Eric, > >> -Original Message- >> From: Auger Eric [mailto:eric.au...@redhat.com] >> Sent: Monday, May 28, 2018 3:22 PM >> To: Shameerali Kolothum Thodi ; >> qemu-devel@nongnu.org; qemu-...@nongnu.org >> Cc: drjo...@

[Qemu-devel] [qemu-web PATCH v2] Add a blog post about the new -nic parameter

2018-05-30 Thread Thomas Huth
QEMU v2.12 features a new, useful parameter called "-nic". Let's throw some light on this new parameter with a new blog post. Signed-off-by: Thomas Huth --- Paolo, I tried to address your feedback from v1 here. But I guess there is still a lot of my bad English in here ... so please free to tak

Re: [Qemu-devel] [PATCH v4 1/2] qemu-error: introduce {error|warn}_report_once

2018-05-30 Thread Halil Pasic
On 05/30/2018 05:19 PM, Michael S. Tsirkin wrote: On Wed, May 30, 2018 at 05:15:19PM +0200, Halil Pasic wrote: On 05/30/2018 06:47 AM, Michael S. Tsirkin wrote: On Thu, May 24, 2018 at 12:44:53PM +0800, Peter Xu wrote: There are many error_report()s that can be used in frequently called f

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post about the new -nic parameter

2018-05-30 Thread Eric Blake
On 05/30/2018 07:54 AM, Paolo Bonzini wrote: On 30/05/2018 14:18, Thomas Huth wrote: QEMU v2.12 features a new, useful parameter called "-nic". Let's throw some light on this new parameter with a new blog post. Nice! +QEMU v2.12 has a new command line parameter, the `-nic` parameter, which

[Qemu-devel] [PULL 02/17] vdi: Fix vdi_co_do_create() return value

2018-05-30 Thread Kevin Wolf
.bdrv_co_create() is supposed to return 0 on success, but vdi could return a positive value instead. Fix this. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Jeff Cody --- block/vdi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/vdi.c b/block/vdi.c index 96a22b8e83.

[Qemu-devel] [PULL 01/17] qcow2: Fix Coverity warning when calculating the refcount cache size

2018-05-30 Thread Kevin Wolf
From: Alberto Garcia MIN_REFCOUNT_CACHE_SIZE is 4 and the cluster size is guaranteed to be at most 2MB, so the minimum refcount cache size (in bytes) is always going to fit in a 32-bit integer. Coverity doesn't know that, and since we're storing the result in a uint64_t (*refcount_cache_size) it

[Qemu-devel] [PULL 13/17] qemu-iotests: Rewrite 210 for blockdev-create job

2018-05-30 Thread Kevin Wolf
This rewrites the test case 210 to work with the new x-blockdev-create job rather than the old synchronous version of the command. All of the test cases stay the same as before, but in order to be able to implement proper job handling, the test case is rewritten in Python. Signed-off-by: Kevin Wo

[Qemu-devel] [PULL 06/17] qemu-iotests: Add VM.get_qmp_events_filtered()

2018-05-30 Thread Kevin Wolf
This adds a helper function that returns a list of QMP events that are already filtered through filter_qmp_event(). Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Jeff Cody --- tests/qemu-iotests/iotests.py | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/qemu-iote

[Qemu-devel] [PULL 03/17] vhdx: Fix vhdx_co_create() return value

2018-05-30 Thread Kevin Wolf
.bdrv_co_create() is supposed to return 0 on success, but vhdx could return a positive value instead. Fix this. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Jeff Cody --- block/vhdx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vhdx.c b/block/vhdx

[Qemu-devel] [PULL 16/17] qemu-iotests: Rewrite 213 for blockdev-create job

2018-05-30 Thread Kevin Wolf
This rewrites the test case 213 to work with the new x-blockdev-create job rather than the old synchronous version of the command. All of the test cases stay the same as before, but in order to be able to implement proper job handling, the test case is rewritten in Python. Signed-off-by: Kevin Wo

[Qemu-devel] [PULL 12/17] qemu-iotests: Rewrite 207 for blockdev-create job

2018-05-30 Thread Kevin Wolf
This rewrites the test case 207 to work with the new x-blockdev-create job rather than the old synchronous version of the command. Most of the test cases stay the same as before (the exception being some improved 'size' options that allow distinguishing which command created the image), but in ord

[Qemu-devel] [PULL 04/17] job: Add error message for failing jobs

2018-05-30 Thread Kevin Wolf
So far we relied on job->ret and strerror() to produce an error message for failed jobs. Not surprisingly, this tends to result in completely useless messages. This adds a Job.error field that can contain an error string for a failing job, and a parameter to job_completed() that sets the field. As

[Qemu-devel] [PULL 00/17] Block layer patches

2018-05-30 Thread Kevin Wolf
Merge remote-tracking branch 'remotes/edgar/tags/edgar/xilinx-next-2018-05-29-v1.for-upstream' into staging (2018-05-29 13:01:11 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch changes up to 3fb588a0f2c006122c34e1960a15c87ae

[Qemu-devel] [PULL 14/17] qemu-iotests: Rewrite 211 for blockdev-create job

2018-05-30 Thread Kevin Wolf
This rewrites the test case 211 to work with the new x-blockdev-create job rather than the old synchronous version of the command. All of the test cases stay the same as before, but in order to be able to implement proper job handling, the test case is rewritten in Python. Signed-off-by: Kevin Wo

[Qemu-devel] [PULL 05/17] block/create: Make x-blockdev-create a job

2018-05-30 Thread Kevin Wolf
This changes the x-blockdev-create QMP command so that it doesn't block the monitor and the main loop any more, but starts a background job that performs the image creation. The basic job as implemented here is all that is necessary to make image creation asynchronous and to provide a QMP interfac

[Qemu-devel] [PULL 07/17] qemu-iotests: Add VM.qmp_log()

2018-05-30 Thread Kevin Wolf
This adds a helper function that logs both the QMP request and the received response before returning it. Signed-off-by: Kevin Wolf Reviewed-by: Jeff Cody Reviewed-by: Max Reitz --- tests/qemu-iotests/iotests.py | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/qemu-iotest

[Qemu-devel] [PULL 10/17] qemu-iotests: iotests.py helper for non-file protocols

2018-05-30 Thread Kevin Wolf
This adds two helper functions that are useful for test cases that make use of a non-file protocol (specifically ssh). Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Jeff Cody --- tests/qemu-iotests/iotests.py | 17 + 1 file changed, 17 insertions(+) diff --git

[Qemu-devel] [PULL 08/17] qemu-iotests: Add iotests.img_info_log()

2018-05-30 Thread Kevin Wolf
This adds a filter function to postprocess 'qemu-img info' input (similar to what _img_info does), and an img_info_log() function that calls 'qemu-img info' and logs the filtered output. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Jeff Cody --- tests/qemu-iotests/iotests.py |

[Qemu-devel] [PULL 09/17] qemu-iotests: Add VM.run_job()

2018-05-30 Thread Kevin Wolf
Add an iotests.py function that runs a job and only returns when it is destroyed. An error is logged when the job failed and job-finalize and job-dismiss commands are issued if necessary. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Jeff Cody --- tests/qemu-iotests/iotests.py

[Qemu-devel] [PULL 17/17] block/create: Mark blockdev-create stable

2018-05-30 Thread Kevin Wolf
We're ready to declare the blockdev-create job stable. This renames the corresponding QMP command from x-blockdev-create to blockdev-create. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Jeff Cody --- qapi/block-core.json | 4 ++-- qapi/job.json | 2 +- blo

[Qemu-devel] [PULL 11/17] qemu-iotests: Rewrite 206 for blockdev-create job

2018-05-30 Thread Kevin Wolf
This rewrites the test case 206 to work with the new x-blockdev-create job rather than the old synchronous version of the command. All of the test cases stay the same as before, but in order to be able to implement proper job handling, the test case is rewritten in Python. Signed-off-by: Kevin Wo

Re: [Qemu-devel] [qemu-web PATCH v2] Add a blog post about the new -nic parameter

2018-05-30 Thread Eric Blake
On 05/30/2018 10:25 AM, Thomas Huth wrote: QEMU v2.12 features a new, useful parameter called "-nic". Let's throw some light on this new parameter with a new blog post. Signed-off-by: Thomas Huth --- screenshots/2018-05-30-qemu-cli-net.png| Bin 0 -> 24020 bytes screenshots/2018-05-30-q

[Qemu-devel] [PULL 15/17] qemu-iotests: Rewrite 212 for blockdev-create job

2018-05-30 Thread Kevin Wolf
This rewrites the test case 212 to work with the new x-blockdev-create job rather than the old synchronous version of the command. All of the test cases stay the same as before, but in order to be able to implement proper job handling, the test case is rewritten in Python. Signed-off-by: Kevin Wo

Re: [Qemu-devel] [qemu-web PATCH v2] Add a blog post about the new -nic parameter

2018-05-30 Thread Paolo Bonzini
On 30/05/2018 17:25, Thomas Huth wrote: > QEMU v2.12 features a new, useful parameter called "-nic". Let's > throw some light on this new parameter with a new blog post. > > Signed-off-by: Thomas Huth > --- > Paolo, I tried to address your feedback from v1 here. But I guess there > is still a l

Re: [Qemu-devel] [PATCH v7 00/10] qemu-img convert with copy offloading

2018-05-30 Thread Stefan Hajnoczi
On Tue, May 29, 2018 at 01:59:49PM +0800, Fam Zheng wrote: > v7: Fix qcow2. > > v6: Pick up rev-by from Stefan and Eric. > Tweak patch 2 commit message. > > v5: - Fix raw offset/bytes check for read. [Eric] > - Fix qcow2_handle_l2meta. [Stefan] > - Add coroutine_fn whereever appropria

Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: Add virt-3.0 machine type

2018-05-30 Thread Laszlo Ersek
On 05/30/18 16:26, Eric Auger wrote: > Add virt-3.0 machine type. > > This machine type supports highmem 256MB ECAM by default. > This feature is disabled for earlier machine types and > if highmem is off. > > The high 256MB ECAM region is chosen instead of the legacy > 16MB one if the machine ty

Re: [Qemu-devel] [Qemu-block] Some question about savem/qcow2 incremental snapshot

2018-05-30 Thread Kevin Wolf
Am 30.05.2018 um 16:44 hat Stefan Hajnoczi geschrieben: > On Mon, May 14, 2018 at 02:48:47PM +0100, Stefan Hajnoczi wrote: > > On Fri, May 11, 2018 at 07:25:31PM +0200, Kevin Wolf wrote: > > > Am 10.05.2018 um 10:26 hat Stefan Hajnoczi geschrieben: > > > > On Wed, May 09, 2018 at 07:54:31PM +0200,

Re: [Qemu-devel] [qemu-web PATCH v2] Add a blog post about the new -nic parameter

2018-05-30 Thread Paolo Bonzini
On 30/05/2018 17:57, Eric Blake wrote: > On 05/30/2018 10:25 AM, Thomas Huth wrote: >> QEMU v2.12 features a new, useful parameter called "-nic". Let's >> throw some light on this new parameter with a new blog post. >> >> Signed-off-by: Thomas Huth >> --- > >>  screenshots/2018-05-30-qemu-cli-net

Re: [Qemu-devel] [PATCH v7 00/11] enable numa configuration before machine_init() from QMP

2018-05-30 Thread Eduardo Habkost
On Wed, May 30, 2018 at 12:47:17PM +0200, Igor Mammedov wrote: > Eduardo, > > I've rebased series on top of current master > the only change in several patches was s/2.13/3.0/ > otherwise there weren't any other conflicts. > You can find rebased version at > > https://github.com/imammedo/qemu.git

Re: [Qemu-devel] [PATCH 1/2] hw/arm/virt: Add a new 256MB ECAM region

2018-05-30 Thread Laszlo Ersek
On 05/30/18 16:26, Eric Auger wrote: > This patch defines a new ECAM region located after the 256GB limit. > > The virt machine state is augmented with a new highmem_ecam field > which guards the usage of this new ECAM region instead of the legacy > 16MB one. With the highmem ECAM region, up to 25

Re: [Qemu-devel] [PATCH v9 3/7] monitor: more comments on lock-free elements

2018-05-30 Thread Stefan Hajnoczi
On Tue, May 29, 2018 at 01:57:51PM +0800, Peter Xu wrote: > Add some explicit comments for both Readline and cpu_set/cpu_get helpers > that they do not need the mon_lock protection. > > Signed-off-by: Peter Xu > --- > monitor.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH] qom: support orphan objects in object_get_canonical_path

2018-05-30 Thread Paolo Bonzini
Mostly a rewrite, in order to keep the loop simple. Signed-off-by: Paolo Bonzini --- qom/object.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/qom/object.c b/qom/object.c index 0fc972030e..4f30431ae3 100644 --- a/qom/object.c +++ b/qom/objec

Re: [Qemu-devel] [PATCH v9 4/7] monitor: fix comment for monitor_lock

2018-05-30 Thread Stefan Hajnoczi
On Tue, May 29, 2018 at 01:57:52PM +0800, Peter Xu wrote: > Fix typo in d622cb5879c. Meanwhile move these variables close to each > other. monitor_qapi_event_state can be declared static, add that. > > Reported-by: Markus Armbruster > Signed-off-by: Peter Xu > --- > monitor.c | 7 +++ > 1

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Eduardo Habkost
On Wed, May 30, 2018 at 01:57:05PM +0100, Stefan Hajnoczi wrote: > On Tue, May 29, 2018 at 03:37:28PM -0400, Cleber Rosa wrote: > > This patch adds a few simple behavior tests for VNC. > > > > Signed-off-by: Cleber Rosa > > --- > > tests/acceptance/vnc.py | 60 +++

Re: [Qemu-devel] [PULL 00/17] Block layer patches

2018-05-30 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180530155647.14090-1-kw...@redhat.com Subject: [Qemu-devel] [PULL 00/17] Block layer patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline

Re: [Qemu-devel] [PATCH v9 5/7] monitor: remove event_clock_type

2018-05-30 Thread Stefan Hajnoczi
On Tue, May 29, 2018 at 01:57:53PM +0800, Peter Xu wrote: > Instead, use a dynamic function to detect which clock we'll use. The > problem is that the old code will let monitor initialization depends on > qtest_enabled(). After this change, we don't have such a dependency any > more. There is a

Re: [Qemu-devel] [PATCH v9 6/7] monitor: move init global earlier

2018-05-30 Thread Stefan Hajnoczi
On Tue, May 29, 2018 at 01:57:54PM +0800, Peter Xu wrote: > Before this patch, monitor fd helpers might be called even earlier than > monitor_init_globals(). This can be problematic. > > After previous work, now monitor_init_globals() does not depend on > accelerator initialization any more. Cal

[Qemu-devel] [PATCH v3 1/2] qapi: allow empty branches in flat unions

2018-05-30 Thread Anton Nefedov
It often happens that just a few discriminator values imply extra data in a flat union. Existing checks did not make possible to leave other values uncovered. Such cases had to be worked around by either stating a dummy (empty) type or introducing another (subset) discriminator enumeration. Both o

[Qemu-devel] [PATCH v3 0/2] qapi: allow empty branches in flat unions

2018-05-30 Thread Anton Nefedov
since v2: remarks addressed: - qapi-code-gen.txt comment added - negative testcase (which became positive) is removed, verification added to qapi-schema-test Anton Nefedov (2): qapi: allow empty branches in flat unions qapi: remove empty flat union branches and types docs/devel/qapi-cod

[Qemu-devel] [PATCH v3 2/2] qapi: remove empty flat union branches and types

2018-05-30 Thread Anton Nefedov
Flat unions may now have uncovered branches, so it is possible to get rid of empty types defined for that purpose only. Signed-off-by: Anton Nefedov Reviewed-by: Eric Blake --- qapi/block-core.json | 55 qapi/crypto.json | 13 +---

Re: [Qemu-devel] [PATCH v9 7/7] monitor: add lock to protect mon_fdsets

2018-05-30 Thread Stefan Hajnoczi
On Tue, May 29, 2018 at 01:57:55PM +0800, Peter Xu wrote: > Introduce a new global big lock for mon_fdsets. Take it where needed. > > The monitor_fdset_get_fd() handling is a bit tricky: now we need to call > qemu_mutex_unlock() which might pollute errno, so we need to make sure > the correct err

Re: [Qemu-devel] [PATCH qemu v3 1/2] object: Handle objects with no parents

2018-05-30 Thread Paolo Bonzini
On 30/05/2018 09:17, Alexey Kardashevskiy wrote: > At the moment object_get_canonical_path() crashes if the object or one > of its parents does not have a parent, for example, a KVM accelerator > object. > > This adds a check for obj!=NULL in a loop to prevent the crash. > In order not to return a

Re: [Qemu-devel] [PATCH v4 10/12] migration: create a dedicated thread to release rdma resource

2018-05-30 Thread Dr. David Alan Gilbert
* Lidong Chen (jemmy858...@gmail.com) wrote: > ibv_dereg_mr wait for a long time for big memory size virtual server. > > The test result is: > 10GB 326ms > 20GB 699ms > 30GB 1021ms > 40GB 1387ms > 50GB 1712ms > 60GB 2034ms > 70GB 2457ms > 80GB 2807ms > 90GB 3107ms > 10

[Qemu-devel] [PATCH] move public invalidate APIs out of translate-all.{c, h}, clean up

2018-05-30 Thread Paolo Bonzini
Place them in exec.c, exec-all.h and ram_addr.h. This removes knowledge of translate-all.h (which is an internal header) from several files outside accel/tcg and removes knowledge of AddressSpace from translate-all.c (as it only operates on ram_addr_t). Locking becomes simpler, too, because the f

Re: [Qemu-devel] [PATCH 00/27] iommu: support txattrs, support TCG execution, implement TZ MPC

2018-05-30 Thread Paolo Bonzini
On 21/05/2018 16:03, Peter Maydell wrote: > This patchset is a rather large one, but the first half is all > fairly simple plumbing. It does four things: > * support IOMMUs that are aware of memory transaction attributes and >may generate different translations for different attributes > * su

<    1   2   3   4   >