On Tue, May 29, 2018 at 01:57:53PM +0800, Peter Xu wrote: > Instead, use a dynamic function to detect which clock we'll use. The > problem is that the old code will let monitor initialization depends on > qtest_enabled(). After this change, we don't have such a dependency any > more.
There is a hidden dependency: monitor_get_clock() returns the wrong value before main() has processed command-line arguments. Where is the guarantee that monitor_get_clock() is never called too early? At the least, monitor_get_clock() should call abort(3) if invoked too early. Even better would be an interface that cannot be used incorrectly.
signature.asc
Description: PGP signature
