[Qemu-devel] [Bug 1771570] Re: qemu-aarch64 $program > $file doesn't pipe output to file in 2.12.0

2018-05-19 Thread Juho Hiltunen
This issue is now marked as invalid, sorry for the trouble. qemu works just fine. The problem was with my linker configuration, it was using a different dynamic library for aarch64. Switching to a standard development stack solved my problem. ** Changed in: qemu Status: New => Invalid --

Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-19 Thread Yi Min Zhao
在 2018/5/18 下午9:07, Ján Tomko 写道: On Fri, May 18, 2018 at 11:19:16AM +0200, Eduardo Otubo wrote: On 18/05/2018 - 09:52:12, Ján Tomko wrote: On Thu, May 17, 2018 at 02:41:09PM +0200, Eduardo Otubo wrote: > On 15/05/2018 - 19:33:48, Yi Min Zhao wrote: > > If CONFIG_SECCOMP is undefined, the opt

[Qemu-devel] [PATCH v3 0/8] linux-user: move socket.h definitions to CPU directories

2018-05-19 Thread Laurent Vivier
Splitting out socket.h definitions helps to read the code and to fix the bugs... No code change, except for the last one that ports definitions from linux for sparc as the values are not the correct ones. v3: - rework ppc/sockbits.h to include generic/sockbits.h and to redefine needed value

[Qemu-devel] [PATCH v3 2/8] linux-user: move alpha socket.h definitions to alpha/sockbits.h

2018-05-19 Thread Laurent Vivier
No code change. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- linux-user/alpha/sockbits.h | 113 linux-user/socket.h | 106 + 2 files changed, 114 ins

[Qemu-devel] [PATCH v3 1/8] linux-user: move mips socket.h definitions to mips/sockbits.h

2018-05-19 Thread Laurent Vivier
No code change. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- linux-user/mips/sockbits.h | 110 +++ linux-user/mips64/sockbits.h | 1 + linux-user/socket.h | 106 +---

[Qemu-devel] [PATCH v3 3/8] linux-user: move sparc/sparc64 socket.h definitions to sparc/sockbits.h

2018-05-19 Thread Laurent Vivier
No code change. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- linux-user/socket.h | 44 +--- linux-user/sparc/sockbits.h | 94 +++ linux-user/sparc64/sockbits.h | 1 + 3 file

[Qemu-devel] [PATCH v3 7/8] linux-user: copy sparc/sockbits.h definitions from linux

2018-05-19 Thread Laurent Vivier
Values defined for sparc are not correct. Copy the content of "arch/sparc/include/uapi/asm/socket.h" to fix them. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell --- linux-user/sparc/sockbits.h | 131 +++- 1 file changed, 92 insertions(+), 39 del

[Qemu-devel] [PATCH v3 8/8] linux-user: define TARGET_SO_REUSEPORT

2018-05-19 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- linux-user/alpha/sockbits.h | 2 +- linux-user/generic/sockbits.h | 2 +- linux-user/mips/sockbits.h| 3 --- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/linux-user/alpha/sockbits.h b/linux-user/alpha/s

[Qemu-devel] [PATCH v3 6/8] linux-user: update ARCH_HAS_SOCKET_TYPES use

2018-05-19 Thread Laurent Vivier
to be like in the kernel and rename it TARGET_ARCH_HAS_SOCKET_TYPES Signed-off-by: Laurent Vivier --- linux-user/alpha/sockbits.h | 36 +++--- linux-user/hppa/sockbits.h | 33 +++- linux-user/mips/sockbits.h | 9 --- linux-user/socket.h | 62

[Qemu-devel] [PATCH v3 4/8] linux-user: move socket.h generic definitions to generic/sockbits.h

2018-05-19 Thread Laurent Vivier
and include the file from architectures without specific definitions Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell --- linux-user/aarch64/sockbits.h| 1 + linux-user/arm/sockbits.h| 1 + linux-user/cris/sockbits.h | 1 + linux-user/generic/sockbits.h| 67

[Qemu-devel] [PATCH v3 5/8] linux-user: move ppc socket.h definitions to ppc/sockbits.h

2018-05-19 Thread Laurent Vivier
Change conditional #ifdef part by #undef of the symbols redefined for PPC relative to generic/socket.h Signed-off-by: Laurent Vivier --- linux-user/generic/sockbits.h | 9 - linux-user/ppc/sockbits.h | 25 + 2 files changed, 25 insertions(+), 9 deletions(-)

[Qemu-devel] [PATCH] cirrus: format code

2018-05-19 Thread zhenwei pi
replace tab with spaces and fix some comments Signed-off-by: zhenwei pi --- hw/display/cirrus_vga.c | 1662 +++ 1 file changed, 831 insertions(+), 831 deletions(-) diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 138ae96..6319889 1

Re: [Qemu-devel] [PATCH] cirrus: format code

2018-05-19 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1526725312-32767-1-git-send-email-zhenwei...@youruncloud.com Subject: [Qemu-devel] [PATCH] cirrus: format code === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(gi

Re: [Qemu-devel] [RFC PATCH 2/2] tests/Makefile: comment out flakey tests

2018-05-19 Thread Peter Maydell
On 19 May 2018 at 07:10, Thomas Huth wrote: > On 18.05.2018 20:31, Peter Maydell wrote: >> Another flaky test for the collection: >> >> TEST: tests/boot-serial-test... (pid=25144) >> /sparc64/boot-serial/sun4u: ** >> ERROR:/home/petmay01/linaro/qemu-for-m

[Qemu-devel] [Bug 1772165] [NEW] qemu-system-arm: -device usb-host, bus=001, vendorid=0x04f2, productid=0x0111: Bus '001' not found

2018-05-19 Thread George
Public bug reported: Using Qemu 2.12.0 on ArchLinux. Trying to emulate arm device with `qemu-system-arm` and attach usb device for unput using ` -usb -device usb-host,bus=001,vendorid=0x1d6b,productid=0x0002 ` # lsusb returns Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub Bus 0

[Qemu-devel] [Bug 1772165] Re: qemu-system-arm: -device usb-host, bus=001, vendorid=0x04f2, productid=0x0111: Bus '001' not found

2018-05-19 Thread Peter Maydell
Can you give the full QEMU command line you're using? (I suspect the reason for this error is that the board model you're using does not have a USB controller.) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.ne

[Qemu-devel] [Bug 1772165] Re: qemu-system-arm: -device usb-host, bus=001, vendorid=0x04f2, productid=0x0111: Bus '001' not found

2018-05-19 Thread George
qemu-system-arm -M raspi2 -append "rw earlyprintk loglevel=8 dwc_otg.lpm_enable=0 root=/dev/mmcblk0p2" -cpu arm1176 -dtb bcm2709-rpi-2-b.dtb -hda DietPi_v6.8_RPi-ARMv6-Stretch.img -kernel kernel7.img -m 1G -smp 4 -serial stdio -usb -device usb- host,bus=001,vendorid=0x1d6b,productid=0x0002 ** Tags

[Qemu-devel] [Bug 1772166] [NEW] qemu 2.4.1: dereferencing pointer to incomplete type ‘struct ucontext’

2018-05-19 Thread George
Public bug reported: Trying to compile qemu release 2.4.1 Getting compile error user-exec.c: In function ‘cpu_resume_from_signal’: user-exec.c:72:37: error: dereferencing pointer to incomplete type ‘struct ucontext’ sigprocmask(SIG_SETMASK, &uc->uc_sigmask, NULL);

Re: [Qemu-devel] [Qemu-ppc] [PPC64] P5020DS: Booting from img possible (-drive)?

2018-05-19 Thread Christian Zigotzky
On 19 May 2018 at 08:15AM, Thomas Huth wrote: On 19.05.2018 06:58, Christian Zigotzky wrote: Thomas wrote: No clue, so just a blind guess: Is "CoreNet Generic" the right machine? What happens if you set "CONFIG_CORENET_GENERIC=n" in your kernel config? I think it‘s the right machine. It's li

Re: [Qemu-devel] [Qemu-ppc] [PPC64] P5020DS: Booting from img possible (-drive)?

2018-05-19 Thread Thomas Huth
Am Sat, 19 May 2018 16:03:02 +0200 schrieb Christian Zigotzky : > On 19 May 2018 at 08:15AM, Thomas Huth wrote: > > On 19.05.2018 06:58, Christian Zigotzky wrote: > >> Thomas wrote: > >> > >>> No clue, so just a blind guess: Is "CoreNet Generic" the right > >>> machine? What happens if you set

[Qemu-devel] [Bug 1772166] Re: qemu 2.4.1: dereferencing pointer to incomplete type ‘struct ucontext’

2018-05-19 Thread Peter Maydell
2.4.1 is a very old release of QEMU. I would recommend moving to a more recent release. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1772166 Title: qemu 2.4.1: dereferencing pointer to incomplete

[Qemu-devel] [Bug 1772165] Re: qemu-system-arm: -device usb-host, bus=001, vendorid=0x04f2, productid=0x0111: Bus '001' not found

2018-05-19 Thread Peter Maydell
Thanks. The USB controller for the raspi2/raspi3 boards is not currently modelled, so it's expected that USB devices won't work. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1772165 Title: qemu-sy

[Qemu-devel] [Bug 1772166] Re: qemu 2.4.1: dereferencing pointer to incomplete type ‘struct ucontext’

2018-05-19 Thread George
I need this for raspberry pi emulation and the most recent doesn't work as you can see from my other bug post. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1772166 Title: qemu 2.4.1: dereferencing

[Qemu-devel] [Bug 1772165] Re: qemu-system-arm: -device usb-host, bus=001, vendorid=0x04f2, productid=0x0111: Bus '001' not found

2018-05-19 Thread George
How then should I be able to actually use the vm when there is no input? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1772165 Title: qemu-system-arm: -device usb- host,bus=001,vendorid=0x04f2,pr

[Qemu-devel] [Bug 1772165] Re: qemu-system-arm: -device usb-host, bus=001, vendorid=0x04f2, productid=0x0111: Bus '001' not found

2018-05-19 Thread Peter Maydell
Serial terminal is how I've used the raspi3 board before. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1772165 Title: qemu-system-arm: -device usb- host,bus=001,vendorid=0x04f2,productid=0x0111:

[Qemu-devel] [Bug 1772166] Re: qemu 2.4.1: dereferencing pointer to incomplete type ‘struct ucontext’

2018-05-19 Thread Peter Maydell
QEMU 2.4 is from 2015, and we didn't add raspi2 support until 2016. We've never supported the USB controller for the raspi boards. Perhaps you're using some other fork of QEMU? If so, better to talk to whoever's responsible for it. -- You received this bug notification because you are a member of

[Qemu-devel] [Bug 1772075] Re: Segmentation fault on aarch64 vm at powerdown

2018-05-19 Thread M0Rf30
This bug is present also on AARCH32, ARMv7 architectures -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1772075 Title: Segmentation fault on aarch64 vm at powerdown Status in QEMU: New Bug descr

[Qemu-devel] [Bug 1772165] Re: qemu-system-arm: -device usb-host, bus=001, vendorid=0x04f2, productid=0x0111: Bus '001' not found

2018-05-19 Thread George
Serial terminal doesn't work with this options. Would you provide options with which i'll be able to access and login into the terminal. SSH is also a good solution. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchp

[Qemu-devel] [Bug 1772165] Re: qemu-system-arm: -device usb-host, bus=001, vendorid=0x04f2, productid=0x0111: Bus '001' not found

2018-05-19 Thread Peter Maydell
This is for raspi3 but may be a useful reference: https://translatedcode.wordpress.com/2018/04/25/debian-on-qemus-raspberry-pi-3-model/ Probably what you're hitting is that the kernel/dtb default to the second serial terminal, so you can try adding 'console=ttyAMA0' to the -append options, or alte

[Qemu-devel] megasas & scsi-disk - interesting I/O errors

2018-05-19 Thread Michael Tokarev
Hello. I've an interesting case here with megasas virtual device. TL;DR see summary at the end. Initially I were testing a backport of CVE-2017-9503 fix to qemu 2.8.1 (which is in debian stable), and while testing I found out that the last patch from the fix makes megasas- attached storage devic

[Qemu-devel] [Bug 1772165] Re: qemu-system-arm: -device usb-host, bus=001, vendorid=0x04f2, productid=0x0111: Bus '001' not found

2018-05-19 Thread George
Whenever I append `console=ttyAMA0` I get kernel panic `Division by zero in kernel` and -serial stdio doen't seem to work. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1772165 Title: qemu-system-a

Re: [Qemu-devel] [PATCH v3 0/2] Nios II generic board config and semihosting support

2018-05-19 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1526671191.git.jul...@codesourcery.com Subject: [Qemu-devel] [PATCH v3 0/2] Nios II generic board config and semihosting support === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH] Remove unwanted crlf conversion in serial

2018-05-19 Thread Patryk Olszewski
Signed-off-by: Patryk Olszewski --- chardev/char-serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chardev/char-serial.c b/chardev/char-serial.c index feb52e5..ae548d2 100644 --- a/chardev/char-serial.c +++ b/chardev/char-serial.c @@ -139,7 +139,7 @@ static void tty_ser

Re: [Qemu-devel] OpenRISC - SPR_PICMR always 'OR-ing' the values

2018-05-19 Thread Stafford Horne
On Sat, May 19, 2018 at 08:08:47PM -0300, Davidson Francis wrote: > Hello Stafford, > > I'm currently using or1k as a target CPU in an operating system that > I'm working. > It happens that I'm having some issues regarding the PICMR register: I realize > that in the latest Qemu version (2.12) when

[Qemu-devel] [PATCH] qemu-option-trace: -trace enable= is a pattern, not a file

2018-05-19 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- qemu-option-trace.texi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/qemu-option-trace.texi b/qemu-option-trace.texi index 4166d5cdc2..7d1b7f05c5 100644 --- a/qemu-option-trace.texi +++ b/qemu-option-trace.texi @@ -2,9 +2,8 @@ Specify

[Qemu-devel] [PULL 01/22] tcg: fix s/compliment/complement/ typos

2018-05-19 Thread Michael Tokarev
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Signed-off-by: Michael Tokarev --- target/i386/translate.c | 2 +- target/m68k/translate.c | 2 +- tcg/README | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate

[Qemu-devel] [PULL 02/22] misc, ide: remove use of HWADDR_PRIx in trace events

2018-05-19 Thread Michael Tokarev
From: Daniel P. Berrangé The trace events all use a uint64_t data type, so should be using the corresponding PRIx64 format, not HWADDR_PRIx which is intended for use with the 'hwaddr' type. Signed-off-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokarev --

[Qemu-devel] [PULL 04/22] qemu-option-trace: -trace enable= is a pattern, not a file

2018-05-19 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- qemu-option-trace.texi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/qemu-option-trace.texi b/qemu-option-trace.texi index 4166d5cdc2..7d1b7f05c5 100644 --- a/qemu-option-trace.texi +++ b/qemu-option-trace.texi @@ -2,9 +2,8 @@ Specify

[Qemu-devel] [PULL 13/22] trivial: Do not include pci.h if it is not necessary

2018-05-19 Thread Michael Tokarev
From: Thomas Huth There is no need to include pci.h in these files. Signed-off-by: Thomas Huth Reviewed-by: Michael S. Tsirkin Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokarev --- include/hw/ppc/ppc4xx.h| 2 -- include/hw/virtio/virtio-balloon.h | 1 - include/

[Qemu-devel] [PULL 00/22] Trivial patches for 2018-05-20

2018-05-19 Thread Michael Tokarev
Hello! This is a next trivial-patches pull request. It's been a while since the last pull, and quite some changes has been accumulated. Please consider pulling/applying. Thanks, /mjt The following changes since commit 5bcf917ee37a5efbef99f091a96db54a5276becb: Merge remote-tracking branch 'r

[Qemu-devel] [PULL 03/22] slirp/debug: Print IP addresses in human readable form

2018-05-19 Thread Michael Tokarev
From: Alexey Kardashevskiy Signed-off-by: Alexey Kardashevskiy Signed-off-by: Michael Tokarev --- slirp/arp_table.c | 4 ++-- slirp/socket.c| 8 slirp/udp.c | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/slirp/arp_table.c b/slirp/arp_table.c index 3

[Qemu-devel] [PULL 15/22] hw/timer/mt48t59: Fix bit-rotten NVRAM_PRINTF format strings

2018-05-19 Thread Michael Tokarev
From: Thomas Huth When compiling with NVRAM_PRINTF enabled, gcc currently bails out with: CC hw/timer/m48t59.o CC hw/timer/m48t59-isa.o hw/timer/m48t59.c: In function ‘NVRAM_writeb’: hw/timer/m48t59.c:460:5: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument

[Qemu-devel] [PULL 06/22] qemu-img-commands.hx: argument ordering fixups

2018-05-19 Thread Michael Tokarev
From: John Snow The TEXI and string versions are actually identical, except for markup. We can probably automate this... but make the ordering the same until then. Signed-off-by: John Snow Reviewed-by: Jeff Cody Signed-off-by: Michael Tokarev --- qemu-img-cmds.hx | 6 +++--- 1 file changed,

[Qemu-devel] [PULL 08/22] qemu-img: remove references to GEN_DOCS

2018-05-19 Thread Michael Tokarev
From: John Snow Nothing seemingly uses this. (jcody: commit 77bd1119ba even mentions that it appears unused) Signed-off-by: John Snow Reviewed-by: Jeff Cody Signed-off-by: Michael Tokarev --- qemu-img.c | 2 -- qemu-options-wrapper.h | 1 - 2 files changed, 3 deletions(-) diff -

[Qemu-devel] [PULL 17/22] typedefs: Remove PcGuestInfo from qemu/typedefs.h

2018-05-19 Thread Michael Tokarev
From: Philippe Mathieu-Daudé It is long gone since e4e8ba04c2007 ... Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Signed-off-by: Michael Tokarev --- include/qemu/typedefs.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h

[Qemu-devel] [PULL 20/22] gdbstub: Handle errors in gdb_accept()

2018-05-19 Thread Michael Tokarev
From: Peter Maydell In gdb_accept(), we both fail to check all errors (notably that from socket_set_nodelay(), as Coverity notes in CID 1005666), and fail to return an error status back to our caller. Correct both of these things, so that errors in accept() result in our stopping with a useful er

[Qemu-devel] [PULL 07/22] qemu-img.texi: fix command ordering

2018-05-19 Thread Michael Tokarev
From: John Snow This should match the summary ordering, which is alphabetical. Signed-off-by: John Snow Reviewed-by: Jeff Cody Signed-off-by: Michael Tokarev --- qemu-img.texi | 58 ++ 1 file changed, 30 insertions(+), 28 deletions(-)

[Qemu-devel] [PULL 05/22] HACKING: document preference for g_new instead of g_malloc

2018-05-19 Thread Michael Tokarev
From: Murilo Opsfelder Araujo This patch documents the preference for g_new instead of g_malloc. The reasons were adapted from commit b45c03f585ea9bb1af76c73e82195418c294919d. Discussion in QEMU's mailing list: http://lists.nongnu.org/archive/html/qemu-devel/2018-05/msg03238.html Cc: qemu-dev

[Qemu-devel] [PULL 09/22] qemu-img: Make documentation between .texi and .hx consistent

2018-05-19 Thread Michael Tokarev
From: John Snow These are also different and out of order for whatever reason. I'd like to automate this in the future, but for now let's put on the band-aid. In the case of resize, there were options missing from all three docstrings; the new string is based on the code. Signed-off-by: John Sn

[Qemu-devel] [PULL 10/22] qemu-img-cmds.hx: add passive-aggressive note

2018-05-19 Thread Michael Tokarev
From: John Snow I'm kidding. It's very easy to forget there are per-command sections in the texi, and insane that we don't autogenerate those, too. Until then, leave a little post-it note in this .hx file until I find a way to delete it. Signed-off-by: John Snow Reviewed-by: Jeff Cody Signed-

[Qemu-devel] [PULL 21/22] qapi/net.json: Fix the version number of the "vlan" removal

2018-05-19 Thread Michael Tokarev
From: Thomas Huth "vlan" will be dropped in 2.13, not in 2.12. And while we're at it, use the better wording "dropped in" instead of "removed with" (also for the "dump" removal). Reported-by: Stefan Hajnoczi Reported-by: Eric Blake Signed-off-by: Thomas Huth Reviewed-by: Eric Blake Signed-of

[Qemu-devel] [PULL 22/22] acpi: fix a comment about aml_call0()

2018-05-19 Thread Michael Tokarev
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokarev --- hw/acpi/aml-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 3fa557cea1..1e43cd736d 100644

[Qemu-devel] [PULL 16/22] qemu-options: Allow -no-user-config again

2018-05-19 Thread Michael Tokarev
From: Michal Privoznik After 1217d6ca2bf28c0febe1bd7d5b3fa912bbf6af2a we error out explicitly if an unknown -option was passed on the command line. However, we are doing two pass command line option parsing. In the first pass we just look for -no-user-config or -nodefconfig being present which de

[Qemu-devel] [PULL 12/22] tests: fix tpm-crb tpm-tis tests race

2018-05-19 Thread Michael Tokarev
From: Marc-André Lureau No need to close the TPM data socket on the emulator end, qemu will close it after a SHUTDOWN. This avoids a race between close() and read() in the TPM data thread. Reported-by: Peter Maydell Signed-off-by: Marc-André Lureau Signed-off-by: Stefan Berger Reviewed-by: Da

[Qemu-devel] [PULL 11/22] hw/ide/ahci: Keep ALLWINNER_AHCI() macro internal

2018-05-19 Thread Michael Tokarev
From: Philippe Mathieu-Daudé The ALLWINNER_AHCI() macro is only used in ahci-allwinner.c. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: John Snow Signed-off-by: Michael Tokarev --- hw/ide/ahci-allwinner.c | 3 +++ hw/ide/ahci_internal.h | 3 --- 2 files changed, 3 insertions(+), 3 dele

[Qemu-devel] [PULL 14/22] Remove unnecessary variables for function return value

2018-05-19 Thread Michael Tokarev
From: Laurent Vivier Re-run Coccinelle script scripts/coccinelle/return_directly.cocci Signed-off-by: Laurent Vivier ppc part Acked-by: David Gibson Signed-off-by: Michael Tokarev --- accel/tcg/translate-all.c | 5 +- block/quorum.c

[Qemu-devel] [PULL 19/22] gdbstub: Use qemu_set_cloexec()

2018-05-19 Thread Michael Tokarev
From: Peter Maydell Use the utility routine qemu_set_cloexec() rather than manually calling fcntl(). This lets us drop the #ifndef _WIN32 guards and also means Coverity doesn't complain that we're ignoring the fcntl error return (CID 1005665, CID 1005667). Signed-off-by: Peter Maydell Reviewed-

[Qemu-devel] [PULL 18/22] replace functions which are only available in glib-2.24

2018-05-19 Thread Michael Tokarev
From: Olaf Hering Currently the minimal supported version of glib is 2.22. Since testing is done with a glib that claims to be 2.22, but in fact has APIs from newer version of glib, this bug was not caught during submit of the patch referenced below. Replace g_realloc_n, which is available only