[Qemu-devel] [PATCH 5/8] spapr: Clean up LPCR updates from hypercalls

2018-05-02 Thread David Gibson
There are several places in spapr_hcall.c where we need to update the LPCR value on all CPUs. We do this with the set_spr() helper. That's not really correct because this directly sets the SPR value, without going through the ppc_store_lpcr() helper which may need to update state based on the LPC

[Qemu-devel] [PATCH 4/8] spapr: Make a helper to set up cpu entry point state

2018-05-02 Thread David Gibson
Under PAPR, only the boot CPU is active when the system starts. Other cpus must be explicitly activated using an RTAS call. The entry state for the boot and secondary cpus isn't identical, but it has some things in common. We're going to add a bit more common setup later, too, so to simplify make

Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific

2018-05-02 Thread Alexey Kardashevskiy
On 2/5/18 7:50 pm, Paolo Bonzini wrote: > On 02/05/2018 11:33, Alexey Kardashevskiy wrote: >>> +# Note: the handler creates an object, enumerates properties and >>> destroys >>> +# the object so it only lists properties created in >>> TypeInfo::instance_init(). >>> +# Since th

[Qemu-devel] [PATCH 1/8] target/ppc: Add ppc_store_lpcr() helper

2018-05-02 Thread David Gibson
There are some fields in the cpu state which need to be updated when the LPCR register is changed, which is done by ppc_hash64_update_rmls() and ppc_hash64_update_vrma(). Code which alters env->spr[SPR_LPCR] needs to call them afterwards to make sure the state is up to date. That's easy to get wr

Re: [Qemu-devel] [PATCH for-2.13 02/10] spapr: Remove support for PowerPC 970 with pseries machine type

2018-05-02 Thread David Gibson
On Fri, Apr 20, 2018 at 02:25:23PM +0200, Greg Kurz wrote: > On Tue, 17 Apr 2018 17:17:14 +1000 > David Gibson wrote: > > > Current POWER cpus allow for a VRMA, a special mapping which describes a > > guest's view of memory when in real mode (MMU off, from the guest's point > > of view). Older c

[Qemu-devel] [PATCH 2/8] spapr: Clean up rtas_start_cpu() & rtas_stop_self()

2018-05-02 Thread David Gibson
This makes several minor cleanups to these functions: * Follow usual convention of an early exit on error, rather than having most of the body in an if * Clearer naming of cpu and cpu_. Now callcpu is the cpu from which the RTAS call is invoked, newcpu is the cpu which we're starting

Re: [Qemu-devel] [PATCH v2 1/2] xlnx-zdma: Add a model of the Xilinx ZynqMP generic DMA

2018-05-02 Thread Edgar E. Iglesias
On Wed, May 02, 2018 at 10:06:39PM +0200, Francisco Iglesias wrote: > Add a model of the generic DMA found on Xilinx ZynqMP. Hi Francisco, A few more comments: > > Signed-off-by: Francisco Iglesias > Signed-off-by: Edgar E. Iglesias > --- > hw/dma/Makefile.objs | 1 + > hw/dma/xln

Re: [Qemu-devel] [PATCH v3 07/35] spapr/xive: introduce the XIVE Event Queues

2018-05-02 Thread David Gibson
On Thu, May 03, 2018 at 08:07:54AM +0200, Cédric Le Goater wrote: > On 05/03/2018 07:45 AM, David Gibson wrote: > > On Thu, Apr 26, 2018 at 11:48:06AM +0200, Cédric Le Goater wrote: > >> On 04/26/2018 09:25 AM, David Gibson wrote: > >>> On Thu, Apr 19, 2018 at 02:43:03PM +0200, Cédric Le Goater wro

[Qemu-devel] [PATCH 3/8] spapr: Remove unhelpful helpers from rtas_start_cpu()

2018-05-02 Thread David Gibson
rtas_start_cpu() calls spapr_cpu_update_tb_offset() and spapr_cpu_set_endianness() to initialize certain things in the new cpu's state. This is the only caller of those helpers, and they're each only a few lines long, so we might as well just fold them into the caller. In addition, those helpers

[Qemu-devel] [PATCH] usb-host: skip open on pending postload bh

2018-05-02 Thread Gerd Hoffmann
usb-host emulates a device unplug after live migration, because the device state is unknown and unplug/replug makes sure the guest re-initializes the device into a working state. This can't be done in post-load though, so post-load just schedules a bottom half which executes after vmload is comple

Re: [Qemu-devel] [PATCH 2/3] block/file-posix: File locking during creation

2018-05-02 Thread Fam Zheng
On Sat, 04/28 13:03, Max Reitz wrote: > On 2018-04-27 08:22, Fam Zheng wrote: > > On Sat, 04/21 00:09, Max Reitz wrote: > >> When creating a file, we should take the WRITE and RESIZE permissions. > >> We do not need either for the creation itself, but we do need them for > >> clearing and resizing

Re: [Qemu-devel] [PATCH v4 4/5] target/ppc: add hash MMU support for PowerNV POWER9 machines

2018-05-02 Thread David Gibson
On Thu, May 03, 2018 at 07:52:32AM +0200, Cédric Le Goater wrote: > On 05/03/2018 02:58 AM, David Gibson wrote: > > On Tue, Apr 24, 2018 at 02:41:47PM +0200, Cédric Le Goater wrote: > >> On 04/24/2018 02:03 PM, Cédric Le Goater wrote: > +hwaddr ppc_hash64_hpt_reg(PowerPCCPU *cpu) > +{ > >

Re: [Qemu-devel] [PATCH 1/4] qemu-options: Remove remainders of the -tdf option

2018-05-02 Thread Markus Armbruster
Thomas Huth writes: > The -tdf options has been removed with d07aa197c5a1556449361a0cbb5108e2, > but apparently I forgot to remove the corresponding two lines from > qemu-options.hx. > > Signed-off-by: Thomas Huth > --- > qemu-options.hx | 3 --- > 1 file changed, 3 deletions(-) > > diff --git

<    1   2   3   4