Re: [Qemu-devel] [PATCH v4 4/5] s390x/vfio: ap: Introduce VFIO AP device

2018-04-23 Thread Cornelia Huck
On Sun, 22 Apr 2018 12:05:44 -0400 Tony Krowiak wrote: > On 04/19/2018 08:03 AM, Cornelia Huck wrote: > > On Sun, 15 Apr 2018 15:07:23 -0400 > > Tony Krowiak wrote: > > > >> Introduces a VFIO based AP device. The device is defined via > >> the QEMU command line by specifying: > >> > >> -d

Re: [Qemu-devel] [PATCH v4 0/5] s390x: vfio-ap: guest dedicated crypto adapters

2018-04-23 Thread Cornelia Huck
On Sun, 22 Apr 2018 12:17:22 -0400 Tony Krowiak wrote: > On 04/19/2018 07:51 AM, Cornelia Huck wrote: > > On Sun, 15 Apr 2018 15:07:19 -0400 > > Tony Krowiak wrote: > > > >> default-configs/s390x-softmmu.mak |1 + > >> docs/vfio-ap.txt | 649 > >> +

Re: [Qemu-devel] [PATCH v3 01/35] ppc/xive: introduce a XIVE interrupt source model

2018-04-23 Thread Cédric Le Goater
On 04/23/2018 05:59 AM, David Gibson wrote: > On Fri, Apr 20, 2018 at 10:27:21AM +0200, Cédric Le Goater wrote: >> On 04/20/2018 09:10 AM, David Gibson wrote: >>> On Thu, Apr 19, 2018 at 02:42:57PM +0200, Cédric Le Goater wrote: Each XIVE interrupt source is associated with a two bit state mac

Re: [Qemu-devel] [PATCH v3 02/35] ppc/xive: add support for the LSI interrupt sources

2018-04-23 Thread Cédric Le Goater
On 04/23/2018 08:44 AM, David Gibson wrote: > On Thu, Apr 19, 2018 at 02:42:58PM +0200, Cédric Le Goater wrote: >> The 'sent' status of the LSI interrupt source is modeled with the 'P' >> bit of the ESB and the assertion status of the source is maintained in >> an array under the main sPAPRXive obj

[Qemu-devel] [ARM/FDPIC v2 0/4] FDPIC ABI for ARM

2018-04-23 Thread Christophe Lyon
Hello, This is v2 of: https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg00783.html Compared to v1, I have addressed Peter's comments: - patch #1 removes CONFIG_USE_FDPIC - patch #2 corresponds to the previous patch #1, and is now simpler without configure option - patch #3 corresponds to

[Qemu-devel] [ARM/FDPIC v2 4/4] linux-user: ARM-FDPIC: Add support for signals for FDPIC targets

2018-04-23 Thread Christophe Lyon
The FDPIC restorer needs to deal with a function descriptor, hence we have to extend 'retcode' such that it can hold the instructions needed to perform this. The restorer sequence uses the same thumbness as the exception handler (mainly to support Thumb-only architectures). Co-Authored-By: Mickaë

[Qemu-devel] [ARM/FDPIC v2 1/4] Remove CONFIG_USE_FDPIC.

2018-04-23 Thread Christophe Lyon
We want to avoid code disabled by default, because it ends up less tested. This patch removes all instances of #ifdef CONFIG_USE_FDPIC, most of which can be safely kept. For the ones that should be conditionally executed, we define elf_is_fdpic(). Without this patch, defining CONFIG_USE_FDPIC would

[Qemu-devel] [ARM/FDPIC v2 2/4] linux-user: ARM-FDPIC: Identify ARM FDPIC binaries

2018-04-23 Thread Christophe Lyon
Define an ARM-specific version of elf_is_fdpic: FDPIC ELF objects are identified with e_ident[EI_OSABI] == ELFOSABI_ARM_FDPIC. Co-Authored-By: Mickaël Guêné Signed-off-by: Christophe Lyon diff --git a/include/elf.h b/include/elf.h index c0dc9bb..934dbbd 100644 --- a/include/elf.h +++ b/include/

[Qemu-devel] [ARM/FDPIC v2 3/4] linux-user: ARM-FDPIC: Add support of FDPIC for ARM.

2018-04-23 Thread Christophe Lyon
Add FDPIC info into image_info structure since interpreter info is on stack and needs to be saved to be accessed later on. Co-Authored-By: Mickaël Guêné Signed-off-by: Christophe Lyon diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 76d7718..1ee1e38 100644 --- a/linux-user/elfloa

[Qemu-devel] [PATCH v2 3/4] pc-bios/s390-ccw/net: Add support for .INS config files

2018-04-23 Thread Thomas Huth
The .INS config files can normally be found on CD-ROM ISO images, so by supporting these files, it is now possible to boot directly when the TFTP server is set up with the contents of such an CD-ROM image. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/netmain.c | 51 +++

[Qemu-devel] [PATCH v2 2/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-04-23 Thread Thomas Huth
Since it is quite cumbersome to manually create a combined kernel with initrd image for network booting, we now support loading via pxelinux configuration files, too. In these files, the kernel, initrd and command line parameters can be specified seperately, and the firmware then takes care of glue

[Qemu-devel] [PATCH v2 1/4] pc-bios/s390-ccw/net: Split up net_load() into init, load and uninit parts

2018-04-23 Thread Thomas Huth
When we want to support pxelinux-style network booting later, we've got to do several TFTP transfers - and we do not want to apply for a new IP address via DHCP each time. So split up net_load into three parts: 1. net_init(), which initializes virtio-net, gets an IP address via DHCP and prints

[Qemu-devel] [PATCH v2 0/4] pc-bios/s390-ccw: Network boot improvements

2018-04-23 Thread Thomas Huth
Some patches to improve the network boot experience on s390x: First patch is just a minor code refactoring which should not have any visible impact, but makes the following patches easier. Patch 2 and 3 add support for loading kernels via configuration files, pxelinux-style and .INS-file style. T

[Qemu-devel] [PATCH v2 4/4] pc-bios/s390-ccw/net: Use diag308 to reset machine before jumping to the OS

2018-04-23 Thread Thomas Huth
The netboot firmware so far simply jumped directly into the OS kernel after the download has been completed. This, however, bears the risk that the virtio-net device still might be active in the background and incoming packets are still placed into the buffers - which could destroy memory of the no

Re: [Qemu-devel] [PATCH v3 03/35] ppc/xive: introduce the XiveFabric interface

2018-04-23 Thread Cédric Le Goater
On 04/23/2018 08:46 AM, David Gibson wrote: > On Thu, Apr 19, 2018 at 02:42:59PM +0200, Cédric Le Goater wrote: >> The XiveFabric offers a simple interface, between the XiveSourve >> object and the device model owning the interrupt sources, to forward >> an event notification to the XIVE interrupt

Re: [Qemu-devel] [PATCH] target/ppc/kvm: set vcpu as online/offline

2018-04-23 Thread Nikunj A Dadhania
David Gibson writes: > On Mon, Apr 23, 2018 at 11:43:02AM +0530, Nikunj A Dadhania wrote: >> Set the newly added register(KVM_REG_PPC_ONLINE) to indicate if the vcpu is >> online(1) or offline(0) >> >> KVM will use this information to set the RWMR register, which controls the >> PURR >> and SPU

[Qemu-devel] [QEMU + SPDK] The demo in the official document is not working

2018-04-23 Thread Bob Chen
Hi, I was trying to run qemu with spdk, referring to http://www.spdk.io/doc/ vhost.html#vhost_qemu_config . Steps were strictly followed. # Environment: latest CentOS 7 kernel, nvme ssd, spdk v18.01.x, > dpdk 17.11.1, qemu 2.11.1 cd spdk > sudo su > ulimit -l unlimited > HUGEMEM=2048 ./scripts

[Qemu-devel] [PATCH 0/2] Add vfio display reset handling

2018-04-23 Thread Tina Zhang
vfio display needs to release the invalid display resource and disable the scanout mode during guest OS reboot, otherwise bugs come out. Thanks hang.y...@intel.com for helping root cause the issue. Tina Zhang (2): console: introduce dpy_gfx_switch_surface ui: introduce vfio_display_reset hw

[Qemu-devel] [PATCH 2/2] ui: introduce vfio_display_reset

2018-04-23 Thread Tina Zhang
During guest OS reboot, guest framebuffer is invalid. It will cause bugs, if the invalid guest framebuffer is still used by host. This patch is to introduce vfio_display_reset which is invoked during vfio display reset. This vfio_display_reset function is used to release the invalid display resour

[Qemu-devel] [PATCH 1/2] console: introduce dpy_gfx_switch_surface

2018-04-23 Thread Tina Zhang
dpy_gfx_switch_surface is used to ask each valid DisplayChangeListener of a QemuConsole to switch to another DisplaySurface. Signed-off-by: Tina Zhang --- include/ui/console.h | 2 ++ ui/console.c | 16 2 files changed, 18 insertions(+) diff --git a/include/ui/console.

Re: [Qemu-devel] [RFC for-2.13 0/7] spapr: Clean up pagesize handling

2018-04-23 Thread Andrea Bolognani
On Fri, 2018-04-20 at 20:21 +1000, David Gibson wrote: > On Fri, Apr 20, 2018 at 11:31:10AM +0200, Andrea Bolognani wrote: > > I'll check out what other distros are doing: if all the major ones > > are defaulting to 64 KiB pages these days, it might be reasonable > > to do the same and pretend smal

[Qemu-devel] [PATCH] cpus: Fix event order on resume of stopped guest

2018-04-23 Thread Markus Armbruster
When resume of a stopped guest immediately runs into block device errors, the BLOCK_IO_ERROR event is sent before the RESUME event. Reproducer: 1. Create a scratch image $ dd if=/dev/zero of=scratch.img bs=1M count=100 Size doesn't actually matter. 2. Prepare blkdebug configuration: $

Re: [Qemu-devel] unknown keycodes

2018-04-23 Thread Peter Maydell
On 23 April 2018 at 04:31, Thomas Huth wrote: > On 21.04.2018 11:27, Mike R wrote: >> (qemu) unknown keycodes `empty+aliases(qwerty)’, please report to >> qemu-devel@nongnu.org >> >> reported. > > Well, please also report: It's kind of our own fault that we didn't ask for those sorts of details

Re: [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id

2018-04-23 Thread Peter Maydell
On 23 April 2018 at 07:40, Cédric Le Goater wrote: > commit 1d3e65aa7ac5 ("hw/timer: Add value matching support to > aspeed_timer") increased the vmstate version of the timers array but > doing so, it broke migration. To fix, we also need to change the > vmstate version of the aspeed timer control

Re: [Qemu-devel] [SPDK] qemu process hung at boot-up, no explicit errors or warnings

2018-04-23 Thread Bob Chen
2018-04-21 1:34 GMT+08:00 John Snow : > > > On 04/20/2018 07:13 AM, Bob Chen wrote: > > 2.11.1 could work, qemu is no longer occupying 100% CPU. That's > > interesting... > > > > Does 2.12 use 100% even at the firmware menu? Maybe we're not giving > this VM long enough to hit the spot that causes

Re: [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id

2018-04-23 Thread Cédric Le Goater
On 04/23/2018 11:12 AM, Peter Maydell wrote: >> diff --git a/hw/timer/aspeed_timer.c b/hw/timer/aspeed_timer.c >> index 50acbf530a3a..7df19bd9df91 100644 >> --- a/hw/timer/aspeed_timer.c >> +++ b/hw/timer/aspeed_timer.c >> @@ -498,8 +498,8 @@ static const VMStateDescription vmstate_aspeed_timer = {

Re: [Qemu-devel] [PATCH 4/4] audio/hda: detect output buffer overruns and underruns

2018-04-23 Thread KONRAD Frederic
On 04/19/2018 03:10 PM, Gerd Hoffmann wrote: If some event caused some larger playback hickup the fine-grained timer adjust isn't able to recover. Use a buffer overruns and underruns as indicator for that. Reset timer adjust logic in case we detected one. It seems that this patch causes big

Re: [Qemu-devel] [PATCH] scripts/qemugdb: support coroutine backtrace in coredumps

2018-04-23 Thread Stefan Hajnoczi
On Sun, Apr 22, 2018 at 09:37:52PM -0400, Simon Marchi wrote: > On 2018-04-09 10:08 PM, Stefan Hajnoczi wrote: > > I wonder what the point of select-frame is then... > > > > I have CCed the GDB mailing list. Maybe someone can help us. Context: > > > > QEMU implements coroutines using jmpbuf. W

Re: [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id

2018-04-23 Thread Peter Maydell
On 23 April 2018 at 10:28, Cédric Le Goater wrote: > On 04/23/2018 11:12 AM, Peter Maydell wrote: >>> diff --git a/hw/timer/aspeed_timer.c b/hw/timer/aspeed_timer.c >>> index 50acbf530a3a..7df19bd9df91 100644 >>> --- a/hw/timer/aspeed_timer.c >>> +++ b/hw/timer/aspeed_timer.c >>> @@ -498,8 +498,8

Re: [Qemu-devel] [PATCH v3 2/3] machine: make MemoryHotplugState accessible via the machine

2018-04-23 Thread David Hildenbrand
On 23.04.2018 05:28, David Gibson wrote: > On Fri, Apr 20, 2018 at 02:34:55PM +0200, David Hildenbrand wrote: >> Let's allow to query the MemoryHotplugState from the machine. >> >> This allows us to generically detect if a certain machine has support >> for memory devices, and to generically manage

Re: [Qemu-devel] [libvirt] [qemu RFC v2] qapi: add "firmware.json"

2018-04-23 Thread Daniel P . Berrangé
On Mon, Apr 23, 2018 at 10:10:10AM +1000, David Gibson wrote: > On Fri, Apr 20, 2018 at 10:34:57AM +0100, Daniel P. Berrangé wrote: > > On Fri, Apr 20, 2018 at 10:11:08AM +0200, Laszlo Ersek wrote: > > > On 04/19/18 11:12, Daniel P. Berrangé wrote: > > > > On Thu, Apr 19, 2018 at 10:39:32AM +0200,

Re: [Qemu-devel] unknown keycodes

2018-04-23 Thread Daniel P . Berrangé
On Mon, Apr 23, 2018 at 10:10:47AM +0100, Peter Maydell wrote: > On 23 April 2018 at 04:31, Thomas Huth wrote: > > On 21.04.2018 11:27, Mike R wrote: > >> (qemu) unknown keycodes `empty+aliases(qwerty)’, please report to > >> qemu-devel@nongnu.org > >> > >> reported. > > > > Well, please also rep

Re: [Qemu-devel] unknown keycodes

2018-04-23 Thread Daniel P . Berrangé
On Mon, Apr 23, 2018 at 05:31:28AM +0200, Thomas Huth wrote: > On 21.04.2018 11:27, Mike R wrote: > > (qemu) unknown keycodes `empty+aliases(qwerty)’, please report to > > qemu-devel@nongnu.org > > > > reported. > > Well, please also report: > > - Which version of QEMU are you using? > > - Whi

Re: [Qemu-devel] [PATCH] scripts/qemugdb: support coroutine backtrace in coredumps

2018-04-23 Thread Vladimir Sementsov-Ogievskiy
23.04.2018 12:33, Stefan Hajnoczi wrote: On Sun, Apr 22, 2018 at 09:37:52PM -0400, Simon Marchi wrote: On 2018-04-09 10:08 PM, Stefan Hajnoczi wrote: I wonder what the point of select-frame is then... I have CCed the GDB mailing list. Maybe someone can help us. Context: QEMU implements coro

Re: [Qemu-devel] [qemu RFC v3 2/3] qapi: change the type of TargetInfo.arch from string to enum SysEmuTarget

2018-04-23 Thread Markus Armbruster
Laszlo Ersek writes: > Now that we have @SysEmuTarget, it makes sense to restict > @TargetInfo.@arch to valid sysemu targets at the schema level. We could mention that supported targets become visible in QMP introspection. But I can't see what QMP clients could do with this information, so let'

Re: [Qemu-devel] [PATCH v4 0/9] enable numa configuration before machine_init() from QMP

2018-04-23 Thread Igor Mammedov
On Fri, 20 Apr 2018 08:31:18 +0200 Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Thu, Apr 19, 2018 at 10:00:04AM +0200, Igor Mammedov wrote: > >> On Wed, 18 Apr 2018 09:08:30 +0200 > >> Markus Armbruster wrote: > >> > >> > Eduardo Habkost writes: > >> > > >> > > On Tue,

Re: [Qemu-devel] [qemu RFC v3 1/3] qapi: add SysEmuTarget to "common.json"

2018-04-23 Thread Markus Armbruster
Laszlo Ersek writes: > We'll soon need an enumeration type that lists all the softmmu targets > that QEMU (the project) supports. Introduce @SysEmuTarget to > "common.json". > > Cc: "Daniel P. Berrange" > Cc: David Gibson > Cc: Eric Blake > Cc: Gerd Hoffmann > Cc: Kashyap Chamarthy > Cc: Mar

Re: [Qemu-devel] [PATCH v3 1/3] pc-dimm: factor out MemoryDevice interface

2018-04-23 Thread David Hildenbrand
On 22.04.2018 12:10, David Gibson wrote: > On Sun, Apr 22, 2018 at 10:21:34AM +0200, David Hildenbrand wrote: >> On 22.04.2018 06:26, David Gibson wrote: >>> On Fri, Apr 20, 2018 at 02:34:54PM +0200, David Hildenbrand wrote: On the qmp level, we already have the concept of memory devices:

Re: [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id

2018-04-23 Thread Cédric Le Goater
On 04/23/2018 11:34 AM, Peter Maydell wrote: > On 23 April 2018 at 10:28, Cédric Le Goater wrote: >> On 04/23/2018 11:12 AM, Peter Maydell wrote: diff --git a/hw/timer/aspeed_timer.c b/hw/timer/aspeed_timer.c index 50acbf530a3a..7df19bd9df91 100644 --- a/hw/timer/aspeed_timer.c

Re: [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id

2018-04-23 Thread Cédric Le Goater
On 04/23/2018 11:34 AM, Peter Maydell wrote: > On 23 April 2018 at 10:28, Cédric Le Goater wrote: >> On 04/23/2018 11:12 AM, Peter Maydell wrote: diff --git a/hw/timer/aspeed_timer.c b/hw/timer/aspeed_timer.c index 50acbf530a3a..7df19bd9df91 100644 --- a/hw/timer/aspeed_timer.c

Re: [Qemu-devel] [PATCH v2 for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-23 Thread Cornelia Huck
On Mon, 16 Apr 2018 09:45:20 +0200 Thomas Huth wrote: > "size_t" should be an unsigned type according to the C standard. > Thus we should also use this convention in the s390-ccw firmware to avoid > confusion. I checked the sources, and apart from one spot in libc.c, the > code should all be fine

[Qemu-devel] [PATCH v2] timer/aspeed: fix vmstate version id

2018-04-23 Thread Cédric Le Goater
commit 1d3e65aa7ac5 ("hw/timer: Add value matching support to aspeed_timer") increased the vmstate version of aspeed.timer because the state had changed, but it also bumped the version of the VMSTATE_STRUCT_ARRAY under the aspeed.timerctrl which did not need to. Change back this version to fix mig

Re: [Qemu-devel] [QEMU + SPDK] The demo in the official document is not working

2018-04-23 Thread Bob Chen
Problem solved. Got a reply from Intel just now. -- Forwarded message -- From: Liu, Changpeng Date: 2018-04-23 18:06 GMT+08:00 Subject: [Qemu-devel] [QEMU + SPDK] The demo in the official document is not working To: "a175818...@gmail.com" Hi Bob, The issues was introduced by

[Qemu-devel] [PATCH v3] dump: add Windows dump format to dump-guest-memory

2018-04-23 Thread Viktor Prutyanov
This patch adds Windows crashdumping feature. Now QEMU can produce ELF-dump containing Windows crashdump header, which can help to convert to a valid WinDbg-understandable crashdump file, or immediately create such file. The crashdump will be obtained by joining physical memory dump and 8K header e

Re: [Qemu-devel] [PATCH v2] timer/aspeed: fix vmstate version id

2018-04-23 Thread Peter Maydell
On 23 April 2018 at 11:14, Cédric Le Goater wrote: > commit 1d3e65aa7ac5 ("hw/timer: Add value matching support to > aspeed_timer") increased the vmstate version of aspeed.timer because > the state had changed, but it also bumped the version of the > VMSTATE_STRUCT_ARRAY under the aspeed.timerctrl

Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

2018-04-23 Thread Paolo Bonzini
On 20/04/2018 20:35, Emilio G. Cota wrote: > The executable is now larger: > > - before: >textdata bss dec hex filename > 9864951 2944592 4371560 1718110310629af > aarch64-softmmu/qemu-system-aarch64 > > - after: >textdata bss dec hex filename > 98

Re: [Qemu-devel] [PATCH v3] xilinx_spips: Correct SNOOP_NONE state when flushing the txfifo

2018-04-23 Thread Peter Maydell
On 20 April 2018 at 18:26, francisco iglesias wrote: > > > On 19 April 2018 at 08:27, Sai Pavan Boddu > wrote: >> >> SNOOP_NONE state handle is moved above in the if ladder, as it's same >> as SNOOP_STRIPPING during data cycles. >> >> Signed-off-by: Sai Pavan Boddu > > > Reviewed-by: Francisco I

Re: [Qemu-devel] [PATCH RFC] s390x: refactor reset/reipl handling

2018-04-23 Thread Cornelia Huck
On Thu, 12 Apr 2018 21:26:02 +0200 David Hildenbrand wrote: > Calling pause_all_vcpus()/resume_all_vcpus() from a VCPU thread might > not be the best idea. As pause_all_vcpus() temporarily drops the qemu > mutex, two parallel calls to pause_all_vcpus() can be active at a time, > resulting in a de

Re: [Qemu-devel] [PATCH RFC] s390x: refactor reset/reipl handling

2018-04-23 Thread Cornelia Huck
On Wed, 18 Apr 2018 16:33:13 +0200 David Hildenbrand wrote: > > static void s390_ipl_class_init(ObjectClass *klass, void *data) > > diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h > > index 0570d0ad75..102f1ea7af 100644 > > --- a/hw/s390x/ipl.h > > +++ b/hw/s390x/ipl.h > > @@ -87,7 +87,17 @@ int s3

Re: [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id

2018-04-23 Thread Dr. David Alan Gilbert
* Cédric Le Goater (c...@kaod.org) wrote: > On 04/23/2018 11:34 AM, Peter Maydell wrote: > > On 23 April 2018 at 10:28, Cédric Le Goater wrote: > >> On 04/23/2018 11:12 AM, Peter Maydell wrote: > diff --git a/hw/timer/aspeed_timer.c b/hw/timer/aspeed_timer.c > index 50acbf530a3a..7df19bd

Re: [Qemu-devel] [PATCH v3 2/3] machine: make MemoryHotplugState accessible via the machine

2018-04-23 Thread David Gibson
On Mon, Apr 23, 2018 at 11:36:48AM +0200, David Hildenbrand wrote: > On 23.04.2018 05:28, David Gibson wrote: > > On Fri, Apr 20, 2018 at 02:34:55PM +0200, David Hildenbrand wrote: > >> Let's allow to query the MemoryHotplugState from the machine. > >> > >> This allows us to generically detect if a

Re: [Qemu-devel] [PATCH v3 2/3] machine: make MemoryHotplugState accessible via the machine

2018-04-23 Thread David Hildenbrand
On 23.04.2018 12:44, David Gibson wrote: > On Mon, Apr 23, 2018 at 11:36:48AM +0200, David Hildenbrand wrote: >> On 23.04.2018 05:28, David Gibson wrote: >>> On Fri, Apr 20, 2018 at 02:34:55PM +0200, David Hildenbrand wrote: Let's allow to query the MemoryHotplugState from the machine. >>

Re: [Qemu-devel] [PATCH v2] timer/aspeed: fix vmstate version id

2018-04-23 Thread Cédric Le Goater
On 04/23/2018 12:29 PM, Peter Maydell wrote: > On 23 April 2018 at 11:14, Cédric Le Goater wrote: >> commit 1d3e65aa7ac5 ("hw/timer: Add value matching support to >> aspeed_timer") increased the vmstate version of aspeed.timer because >> the state had changed, but it also bumped the version of the

Re: [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id

2018-04-23 Thread Cédric Le Goater
>>> I think it's nice to at least do the "bump version" thing, so you >>> get a (hopefully comprehensible) error rather than just wrong >>> data if you do try a cross version migration, >> >> On that topic, the error message was : >> >> Missing section footer for aspeed.timerctrl >> >> which

Re: [Qemu-devel] [PATCH v2 for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-23 Thread Thomas Huth
On 23.04.2018 12:08, Cornelia Huck wrote: > On Mon, 16 Apr 2018 09:45:20 +0200 > Thomas Huth wrote: > >> "size_t" should be an unsigned type according to the C standard. >> Thus we should also use this convention in the s390-ccw firmware to avoid >> confusion. I checked the sources, and apart fro

Re: [Qemu-devel] [PATCH v11 03/17] hw/arm/smmu-common: VMSAv8-64 page table walk

2018-04-23 Thread Auger Eric
Hi Peter, On 04/16/2018 02:59 PM, Peter Maydell wrote: > On 12 April 2018 at 08:37, Eric Auger wrote: >> This patch implements the page table walk for VMSAv8-64. >> >> Signed-off-by: Eric Auger >> Signed-off-by: Prem Mallappa > >> diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c >> ind

Re: [Qemu-devel] [PATCH] cpus: Fix event order on resume of stopped guest

2018-04-23 Thread Paolo Bonzini
On 23/04/2018 10:45, Markus Armbruster wrote: > When resume of a stopped guest immediately runs into block device > errors, the BLOCK_IO_ERROR event is sent before the RESUME event. > > Reproducer: > > 1. Create a scratch image >$ dd if=/dev/zero of=scratch.img bs=1M count=100 > >Size do

Re: [Qemu-devel] [ARM/FDPIC v2 2/4] linux-user: ARM-FDPIC: Identify ARM FDPIC binaries

2018-04-23 Thread Peter Maydell
On 23 April 2018 at 08:51, Christophe Lyon wrote: > Define an ARM-specific version of elf_is_fdpic: > FDPIC ELF objects are identified with e_ident[EI_OSABI] == > ELFOSABI_ARM_FDPIC. > > Co-Authored-By: Mickaël Guêné > Signed-off-by: Christophe Lyon > > diff --git a/include/elf.h b/include/elf.h

Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code

2018-04-23 Thread Igor Mammedov
On Fri, 20 Apr 2018 14:34:56 +0200 David Hildenbrand wrote: > To be able to reuse MemoryDevice logic from other devices besides > pc-dimm, factor the relevant stuff out into the MemoryDevice code. > > As we don't care about slots for memory devices that are not pc-dimm, > don't factor that part

Re: [Qemu-devel] [ARM/FDPIC v2 1/4] Remove CONFIG_USE_FDPIC.

2018-04-23 Thread Peter Maydell
On 23 April 2018 at 08:51, Christophe Lyon wrote: > We want to avoid code disabled by default, because it ends up less > tested. This patch removes all instances of #ifdef CONFIG_USE_FDPIC, > most of which can be safely kept. For the ones that should be > conditionally executed, we define elf_is_f

Re: [Qemu-devel] [PATCH v3 0/3] pc-dimm: factor out MemoryDevice

2018-04-23 Thread Igor Mammedov
On Fri, 20 Apr 2018 14:34:53 +0200 David Hildenbrand wrote: > Right now we can only map PCDIMM/NVDIMM into guest address space. In the > future, we might want to do the same for virtio devices - e.g. > virtio-pmem or virtio-mem. Especially, they should be able to live side > by side to each other

[Qemu-devel] [PATCH v2 0/5] target-microblaze: Misc bug fixes

2018-04-23 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Hi, This is a series of fixes for bugs I ran into when adding support for extended addressing. It would be nice to get these into 2.12 if it's not too late. Cheers, Edgar ChangeLog: v1 -> v2: * Corrected fix making MSR.PVR read-only. Edgar E. Iglesias (5): target-

[Qemu-devel] [PATCH v2 3/5] target-microblaze: Don't clobber the IMM reg for ld/st reversed

2018-04-23 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Do not clobber the IMM register on reversed load/stores. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index ec12fed49d..100883e2cc

[Qemu-devel] [PATCH v2 2/5] target-microblaze: Fix trap checks for FPU insns

2018-04-23 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Fix trap checks for FPU insns when extended FPU insns are enabled. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/microblaze/translate.c b/tar

[Qemu-devel] [PATCH v2 1/5] target-microblaze: Respect MSR.PVR as read-only

2018-04-23 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Respect MSR.PVR as read-only. We were wrongly overwriting the PVR bit. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c

[Qemu-devel] [PATCH v2 5/5] target-microblaze: mmu: Make the TLBX MISS bit read-only

2018-04-23 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Make the TLBX MISS bit read-only. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/mmu.c | 4 1 file changed, 4 insertions(+) diff --git a/target/microblaze/mmu.c b/target/microblaze/mmu.c index 8391811900..9d5e6aa8a5 100644

[Qemu-devel] [PATCH v2 4/5] target-microblaze: mmu: Make TLBSX write-only

2018-04-23 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Make TLBSX write-only and guest-error log reads from it. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/mmu.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/microblaze/mmu.c b/target/microblaze/mmu

Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code

2018-04-23 Thread David Hildenbrand
On 23.04.2018 14:19, Igor Mammedov wrote: > On Fri, 20 Apr 2018 14:34:56 +0200 > David Hildenbrand wrote: > >> To be able to reuse MemoryDevice logic from other devices besides >> pc-dimm, factor the relevant stuff out into the MemoryDevice code. >> >> As we don't care about slots for memory devi

Re: [Qemu-devel] [PATCH v11 04/17] hw/arm/smmuv3: Skeleton

2018-04-23 Thread Auger Eric
Hi Peter, On 04/16/2018 03:08 PM, Peter Maydell wrote: > On 12 April 2018 at 08:37, Eric Auger wrote: >> From: Prem Mallappa >> >> This patch implements a skeleton for the smmuv3 device. >> Datatypes and register definitions are introduced. The MMIO >> region, the interrupts and the queue are ini

Re: [Qemu-devel] [PATCH v3 0/3] pc-dimm: factor out MemoryDevice

2018-04-23 Thread David Hildenbrand
On 23.04.2018 14:31, Igor Mammedov wrote: > On Fri, 20 Apr 2018 14:34:53 +0200 > David Hildenbrand wrote: > >> Right now we can only map PCDIMM/NVDIMM into guest address space. In the >> future, we might want to do the same for virtio devices - e.g. >> virtio-pmem or virtio-mem. Especially, they

Re: [Qemu-devel] [ARM/FDPIC v2 3/4] linux-user: ARM-FDPIC: Add support of FDPIC for ARM.

2018-04-23 Thread Peter Maydell
On 23 April 2018 at 08:51, Christophe Lyon wrote: > Add FDPIC info into image_info structure since interpreter info is on > stack and needs to be saved to be accessed later on. > > Co-Authored-By: Mickaël Guêné > Signed-off-by: Christophe Lyon > > diff --git a/linux-user/elfload.c b/linux-user/

Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code

2018-04-23 Thread David Hildenbrand
> >> +/* we will need a new memory slot for kvm and vhost */ >> +if (kvm_enabled() && !kvm_has_free_slot(machine)) { >> +error_setg(errp, "hypervisor has no free memory slots left"); >> +return; >> +} >> +if (!vhost_has_free_slot()) { >> +error_setg(errp, "

Re: [Qemu-devel] [PATCH v2 00/43] fix building of tests/tcg

2018-04-23 Thread Alex Bennée
Richard Henderson writes: > On 04/19/2018 03:58 AM, Alex Bennée wrote: >> What would be really >> helpful is if the respective maintainers could encode their EXACT >> STEPS for building their cross compilers into some docker recipes. > > I've just re-built my alphaev67 cross-environment and reco

Re: [Qemu-devel] [ARM/FDPIC v2 2/4] linux-user: ARM-FDPIC: Identify ARM FDPIC binaries

2018-04-23 Thread Christophe Lyon
On 23/04/2018 14:17, Peter Maydell wrote: On 23 April 2018 at 08:51, Christophe Lyon wrote: Define an ARM-specific version of elf_is_fdpic: FDPIC ELF objects are identified with e_ident[EI_OSABI] == ELFOSABI_ARM_FDPIC. Co-Authored-By: Mickaël Guêné Signed-off-by: Christophe Lyon diff --git

Re: [Qemu-devel] [PATCH] cpus: Fix event order on resume of stopped guest

2018-04-23 Thread Kevin Wolf
Am 23.04.2018 um 10:45 hat Markus Armbruster geschrieben: > When resume of a stopped guest immediately runs into block device > errors, the BLOCK_IO_ERROR event is sent before the RESUME event. > > Reproducer: > > 1. Create a scratch image >$ dd if=/dev/zero of=scratch.img bs=1M count=100 >

Re: [Qemu-devel] [PATCH 1/2] console: introduce dpy_gfx_switch_surface

2018-04-23 Thread Gerd Hoffmann
Hi, > void dpy_gfx_replace_surface(QemuConsole *con, > DisplaySurface *surface); > +void dpy_gfx_switch_surface(QemuConsole *con, > + DisplaySurface *surface); Why? Any problems with dpy_gfx_replace_surface? cheers, Gerd

Re: [Qemu-devel] [PATCH v5 1/2] Implement .hex file loader

2018-04-23 Thread Stefan Hajnoczi
On Fri, Apr 20, 2018 at 02:45:31PM +0800, Su Hang wrote: > diff --git a/hw/arm/boot.c b/hw/arm/boot.c > index 26184bcd7c26..898a7af114ea 100644 > --- a/hw/arm/boot.c > +++ b/hw/arm/boot.c > @@ -1070,12 +1070,20 @@ static void arm_load_kernel_notify(Notifier > *notifier, void *data) > kern

Re: [Qemu-devel] [ARM/FDPIC v2 4/4] linux-user: ARM-FDPIC: Add support for signals for FDPIC targets

2018-04-23 Thread Peter Maydell
On 23 April 2018 at 08:51, Christophe Lyon wrote: > The FDPIC restorer needs to deal with a function descriptor, hence we > have to extend 'retcode' such that it can hold the instructions needed > to perform this. > > The restorer sequence uses the same thumbness as the exception > handler (mainly

Re: [Qemu-devel] [PATCH v4 0/9] enable numa configuration before machine_init() from QMP

2018-04-23 Thread Eduardo Habkost
On Mon, Apr 23, 2018 at 11:50:16AM +0200, Igor Mammedov wrote: > On Fri, 20 Apr 2018 08:31:18 +0200 > Markus Armbruster wrote: > > > Eduardo Habkost writes: > > > > > On Thu, Apr 19, 2018 at 10:00:04AM +0200, Igor Mammedov wrote: > > >> On Wed, 18 Apr 2018 09:08:30 +0200 > > >> Markus Armbrus

Re: [Qemu-devel] [PATCH 2/2] ui: introduce vfio_display_reset

2018-04-23 Thread Gerd Hoffmann
> +surface = qemu_console_surface(vdev->dpy->con); > +dpy_gl_scanout_disable(vdev->dpy->con); > +dpy_gfx_switch_surface(vdev->dpy->con, surface); Hmm, so you ask which surface is active, then switch to it. Why? Maybe you just need a full display update after disabling the gl scanout?

Re: [Qemu-devel] [PATCH] hw/arm/virt: Add linux, pci-domain property

2018-04-23 Thread Peter Maydell
On 23 April 2018 at 06:18, Jan Kiszka wrote: > From: Jan Kiszka > > This allows to pin the host controller in the Linux PCI domain space. > Linux requires that property to be available consistently or not at all, > in which case the domain number becomes unstable on additions/removals. > Adding i

Re: [Qemu-devel] [PATCH] migration: update docs

2018-04-23 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 04/20/2018 12:57 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Update the migration docs: > > > > Among other changes: > > * Added a general list of advice for device authors > > * Reordered the section on cond

Re: [Qemu-devel] [Qemu-block] [PATCH 0/3] block/file-posix: File locking during creation

2018-04-23 Thread Alberto Garcia
On Sat 21 Apr 2018 12:09:10 AM CEST, Max Reitz wrote: > Currently we do not take permissions on a file while it is being > created. That is a bit sad. The simplest way to test this is the > following: > > $ qemu-img create -f qcow2 foo.qcow2 64M > Formatting 'foo.qcow2', fmt=qcow2 size=67

Re: [Qemu-devel] [ARM/FDPIC v2 2/4] linux-user: ARM-FDPIC: Identify ARM FDPIC binaries

2018-04-23 Thread Peter Maydell
On 23 April 2018 at 13:53, Christophe Lyon wrote: > On 23/04/2018 14:17, Peter Maydell wrote: >> I have a strong dislike for per-target ifdef ladders. Can we instead >> put the target's implementation of elf_is_fdpic() into >> linux-user/$ARCH/target_elf.h >> and also have that header do >> #defin

Re: [Qemu-devel] [PATCH] scripts/qemugdb: support coroutine backtrace in coredumps

2018-04-23 Thread Pedro Alves
On 04/23/2018 02:37 AM, Simon Marchi wrote: > On 2018-04-09 10:08 PM, Stefan Hajnoczi wrote: >> I wonder what the point of select-frame is then... >> >> I have CCed the GDB mailing list. Maybe someone can help us. Context: >> >> QEMU implements coroutines using jmpbuf. We'd like to print corouti

[Qemu-devel] [PATCH v3] dump: add Windows dump format to dump-guest-memory

2018-04-23 Thread Viktor Prutyanov
This patch adds Windows crashdumping feature. Now QEMU can produce ELF-dump containing Windows crashdump header, which can help to convert to a valid WinDbg-understandable crashdump file, or immediately create such file. The crashdump will be obtained by joining physical memory dump and 8K header e

Re: [Qemu-devel] [PATCH] loader: Fix misaligned member access

2018-04-23 Thread Philippe Mathieu-Daudé
On 04/23/2018 12:16 AM, David Gibson wrote: > On Sun, Apr 22, 2018 at 11:41:20AM +0100, Peter Maydell wrote: >> On 21 April 2018 at 22:16, Philippe Mathieu-Daudé wrote: >>> This fixes the following ASan warning: >>> >>> $ mips64el-softmmu/qemu-system-mips64el -M boston -kernel vmlinux.gz.itb >>

Re: [Qemu-devel] [PATCH v11 03/17] hw/arm/smmu-common: VMSAv8-64 page table walk

2018-04-23 Thread Peter Maydell
On 23 April 2018 at 13:10, Auger Eric wrote: > Hi Peter, > > On 04/16/2018 02:59 PM, Peter Maydell wrote: >> On 12 April 2018 at 08:37, Eric Auger wrote: >>> +/** >>> + * TODO: handle the case where the level resolves less than >>> + * granule_sz -3 IA bits. >>> + */ >>> +static inline >>> +uint

Re: [Qemu-devel] [PATCH] loader: Fix misaligned member access

2018-04-23 Thread Peter Maydell
On 23 April 2018 at 14:57, Philippe Mathieu-Daudé wrote: > On 04/23/2018 12:16 AM, David Gibson wrote: >> On Sun, Apr 22, 2018 at 11:41:20AM +0100, Peter Maydell wrote: >>> If we need to do an unaligned load, then ldl_p() is the >>> right way to do it. (We could also just do >>> *addr = ldl_be_p(

Re: [Qemu-devel] [ARM/FDPIC v2 3/4] linux-user: ARM-FDPIC: Add support of FDPIC for ARM.

2018-04-23 Thread Christophe Lyon
On 23/04/2018 14:49, Peter Maydell wrote: On 23 April 2018 at 08:51, Christophe Lyon wrote: Add FDPIC info into image_info structure since interpreter info is on stack and needs to be saved to be accessed later on. Co-Authored-By: Mickaël Guêné Signed-off-by: Christophe Lyon diff --git a/l

[Qemu-devel] [PATCH v2] loader: Fix misaligned member access

2018-04-23 Thread Philippe Mathieu-Daudé
This fixes the following ASan warning: $ mips64el-softmmu/qemu-system-mips64el -M boston -kernel vmlinux.gz.itb -nographic hw/core/loader-fit.c:108:17: runtime error: load of misaligned address 0x7f95cd7e4264 for type 'fdt64_t', which requires 8 byte alignment 0x7f95cd7e4264: note: pointer

Re: [Qemu-devel] [PATCH] loader: Fix misaligned member access

2018-04-23 Thread Philippe Mathieu-Daudé
On 04/23/2018 11:04 AM, Peter Maydell wrote: > On 23 April 2018 at 14:57, Philippe Mathieu-Daudé wrote: >> On 04/23/2018 12:16 AM, David Gibson wrote: >>> On Sun, Apr 22, 2018 at 11:41:20AM +0100, Peter Maydell wrote: If we need to do an unaligned load, then ldl_p() is the right way to d

Re: [Qemu-devel] [ARM/FDPIC v2 4/4] linux-user: ARM-FDPIC: Add support for signals for FDPIC targets

2018-04-23 Thread Christophe Lyon
On 23/04/2018 15:05, Peter Maydell wrote: On 23 April 2018 at 08:51, Christophe Lyon wrote: The FDPIC restorer needs to deal with a function descriptor, hence we have to extend 'retcode' such that it can hold the instructions needed to perform this. The restorer sequence uses the same thumbnes

Re: [Qemu-devel] [PATCH] loader: Fix misaligned member access

2018-04-23 Thread Philippe Mathieu-Daudé
> On 04/23/2018 11:04 AM, Peter Maydell wrote: >> On 23 April 2018 at 14:57, Philippe Mathieu-Daudé wrote: >>> On 04/23/2018 12:16 AM, David Gibson wrote: On Sun, Apr 22, 2018 at 11:41:20AM +0100, Peter Maydell wrote: > If we need to do an unaligned load, then ldl_p() is the > right w

Re: [Qemu-devel] [PATCH v2 00/43] fix building of tests/tcg

2018-04-23 Thread Alex Bennée
Alex Bennée writes: > Richard Henderson writes: > >> On 04/19/2018 03:58 AM, Alex Bennée wrote: >>> What would be really >>> helpful is if the respective maintainers could encode their EXACT >>> STEPS for building their cross compilers into some docker recipes. >> >> I've just re-built my alpha

Re: [Qemu-devel] [PATCH 05/16] xen: defer call to xen_restrict until just before os_setup_post

2018-04-23 Thread Anthony PERARD
On Thu, Apr 19, 2018 at 05:45:08PM +0100, Ian Jackson wrote: > We need to restrict *all* the control fds that qemu opens. Looking in > /proc/PID/fd shows there are many; their allocation seems scattered > throughout Xen support code in qemu. > > We must postpone the restrict call until roughly th

Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code

2018-04-23 Thread David Hildenbrand
On 23.04.2018 14:19, Igor Mammedov wrote: > On Fri, 20 Apr 2018 14:34:56 +0200 > David Hildenbrand wrote: > >> To be able to reuse MemoryDevice logic from other devices besides >> pc-dimm, factor the relevant stuff out into the MemoryDevice code. >> >> As we don't care about slots for memory devi

[Qemu-devel] [PATCH] docker: add debian/alpha image

2018-04-23 Thread Philippe Mathieu-Daudé
This image is not enough to cross-build QEMU, but it is useful enough to cross-compile TCG tests. Suggested-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/debian-alpha-cross.docker | 13 + 1 file changed, 13 insertions(+) create mode 100644 tests

[Qemu-devel] [PATCH v2 5/4] pc-bios/s390-ccw/net: Try to load pxelinux.cfg file accoring to the UUID

2018-04-23 Thread Thomas Huth
With the STSI instruction, we can get the UUID of the current VM instance, so we can support loading pxelinux config files via UUID in the file name, too. Signed-off-by: Thomas Huth --- Sorry, just found out how to get the VM UUID after sending out the v2 series, so this is now patch 5 of 4 ;-)

Re: [Qemu-devel] [PATCH 03/16] xen: link against xentoolcore

2018-04-23 Thread Anthony PERARD
On Thu, Apr 19, 2018 at 05:45:06PM +0100, Ian Jackson wrote: > From: Anthony PERARD > > Xen libraries in 4.10 include a new xentoolcore library. This > contains the xentoolcore_restrict_all function which we are about to > want to use. > > Signed-off-by: Ian Jackson > Acked-by: Stefano Stabell

  1   2   3   >