> >> + /* we will need a new memory slot for kvm and vhost */ >> + if (kvm_enabled() && !kvm_has_free_slot(machine)) { >> + error_setg(errp, "hypervisor has no free memory slots left"); >> + return; >> + } >> + if (!vhost_has_free_slot()) { >> + error_setg(errp, "a used vhost backend has no free memory slots >> left"); >> + return; >> + } > move these checks to pre_plug time > >> + >> + memory_region_add_subregion(&hpms->mr, addr - hpms->base, mr); > missing vmstate registration?
Missed this one: To be called by the caller. Important because e.g. for virtio-pmem we don't want this (I assume :) ). Thanks! -- Thanks, David / dhildenb