Re: [Qemu-devel] [PATCH v2] migration: discard non-migratable RAMBlocks

Hello David, On 04/19/2018 06:58 PM, Dr. David Alan Gilbert wrote: > * Cédric Le Goater (c...@kaod.org) wrote: >> On the POWER9 processor, the XIVE interrupt controller can control >> interrupt sources using MMIO to trigger events, to EOI or to turn off >> the sources. Priority management and inte

Re: [Qemu-devel] [Qemu-block] [PATCH 02/19] block: Use bdrv_do_drain_begin/end in bdrv_drain_all()

On Wed, Apr 11, 2018 at 06:39:23PM +0200, Kevin Wolf wrote: > bdrv_do_drain_begin/end() implement already everything that > bdrv_drain_all_begin/end() need and currently still do manually: Disable > external events, call parent drain callbacks, call block driver > callbacks. > > It also does two m

Re: [Qemu-devel] [Qemu-block] [PATCH 03/19] block: Remove 'recursive' parameter from bdrv_drain_invoke()

On Wed, Apr 11, 2018 at 06:39:24PM +0200, Kevin Wolf wrote: > All callers pass false for the 'recursive' parameter now. Remove it. > > Signed-off-by: Kevin Wolf > --- > block/io.c | 13 +++-- > 1 file changed, 3 insertions(+), 10 deletions(-) Reviewed-by: Stefan Hajnoczi signature.as

Re: [Qemu-devel] [Qemu-block] [PATCH 04/19] block: Don't manually poll in bdrv_drain_all()

On Wed, Apr 11, 2018 at 06:39:25PM +0200, Kevin Wolf wrote: > All involved nodes are already idle, we called bdrv_do_draine_begin() on > them. > > The comment in the code suggested that this were not correct because the > completion of a request on one node could spawn a new request on a > differe

Re: [Qemu-devel] [PATCH v3 01/35] ppc/xive: introduce a XIVE interrupt source model

On Thu, Apr 19, 2018 at 02:42:57PM +0200, Cédric Le Goater wrote: > Each XIVE interrupt source is associated with a two bit state machine > called an Event State Buffer (ESB) : the first bit "P" means that an > interrupt is "pending" and waiting for an EOI and the bit "Q" (queued) > means a new int

Re: [Qemu-devel] [Qemu-block] [PATCH 05/19] tests/test-bdrv-drain: bdrv_drain_all() works in coroutines now

On Wed, Apr 11, 2018 at 06:39:26PM +0200, Kevin Wolf wrote: > Since we use bdrv_do_drained_begin/end() for bdrv_drain_all_begin/end(), > coroutine context is automatically left with a BH, preventing the > deadlocks that made bdrv_drain_all*() unsafe in coroutine context. We > can consider it compat

Re: [Qemu-devel] [qemu-s390x] [PATCH for-2.13] Clear mem_path if we fall back to anonymous RAM allocation

On 04/19/2018 06:08 PM, Greg Kurz wrote: > On Thu, 19 Apr 2018 16:11:37 +0200 > David Hildenbrand wrote: > >> On 19.04.2018 15:34, Christian Borntraeger wrote: >>> >>> >>> On 04/19/2018 02:58 PM, Cornelia Huck wrote: On Thu, 19 Apr 2018 14:33:18 +0200 Igor Mammedov wrote: >>

Re: [Qemu-devel] [Qemu-block] [PATCH 06/19] block: Avoid unnecessary aio_poll() in AIO_WAIT_WHILE()

On Wed, Apr 11, 2018 at 06:39:27PM +0200, Kevin Wolf wrote: > Commit 91af091f923 added an additional aio_poll() to BDRV_POLL_WHILE() > in order to make sure that all pending BHs are executed on drain. This > was the wrong place to make the fix, as it is useless overhead for all > other users of the

Re: [Qemu-devel] [Qemu-block] [PATCH 08/19] block: Remove bdrv_drain_recurse()

On Wed, Apr 11, 2018 at 06:39:29PM +0200, Kevin Wolf wrote: > For bdrv_drain(), recursively waiting for child node requests is > pointless because we didn't quiesce their parents, so new requests could > come in anyway. Letting the function work only on a single node makes it > more consistent. >

Re: [Qemu-devel] [PATCH v3 3/4] qdev: Simplify the SysBusDeviceClass::init path

Philippe Mathieu-Daudé writes: > On 04/19/2018 06:27 PM, Philippe Mathieu-Daudé wrote: >> The SysBusDevice is the last DeviceClass::init user. >> >> Instead of using >> SysBusDeviceClass::realize >>-> DeviceClass::realize >>-> DeviceClass::init >>-> sysbus_device_init >

Re: [Qemu-devel] [PATCH v3 1/4] hw/i2c/smbus: Use DeviceClass::realize instead of SMBusDeviceClass::init

Philippe Mathieu-Daudé writes: > SMBusDeviceClass::init is no more used, remove it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v3 2/4] hw/i2c: Use DeviceClass::realize instead of I2CSlaveClass::init

Philippe Mathieu-Daudé writes: > I2CSlaveClass::init is no more used, remove it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v1 for-2.13 2/4] pc-bios/s390-ccw/net: Stop virtio-net device before jumping into the OS

On 04/20/2018 08:31 AM, Thomas Huth wrote: > On 19.04.2018 17:49, Christian Borntraeger wrote: >> On 04/18/2018 02:31 PM, Thomas Huth wrote: >>> The virtio-net receive buffers are filled asynchronously, so we should >>> make sure to properly shut down the virtio-net device before we jump into >>>

Re: [Qemu-devel] [PATCH v3 4/4] qdev: Remove DeviceClass::exit

Philippe Mathieu-Daudé writes: > Since no devices use it, we can safely remove it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster However, I'd reshuffle PATCH 3+4 a bit as explained in my review of PATCH 3.

Re: [Qemu-devel] [Qemu-block] [PATCH 09/19] test-bdrv-drain: Add test for node deletion

On Wed, Apr 11, 2018 at 06:39:30PM +0200, Kevin Wolf wrote: > +static void do_test_delete_by_drain(bool detach_instead_of_delete) > +{ > +BlockBackend *blk; > +BlockDriverState *bs, *child_bs, *null_bs; > +BDRVTestTopState *tts; > +TestCoDeleteByDrainData dbdd; > +Coroutine *co;

Re: [Qemu-devel] [PATCH 00/19] Drain fixes and cleanups, part 3

On Wed, Apr 11, 2018 at 06:39:21PM +0200, Kevin Wolf wrote: > This is the third and hopefully for now last part of my work to fix > drain. The main goal of this series is to make drain robust against > graph changes that happen in any callbacks of in-flight requests while > we drain a block node.

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.13 3/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

On 20.04.2018 08:53, Viktor VM Mihajlovski wrote: > On 19.04.2018 18:55, Thomas Huth wrote: >> On 19.04.2018 14:40, Viktor VM Mihajlovski wrote: [...] > That's interesting because treating the bootfile as pxe-ish config is > what DPM does. Which means that with this change the processor >>>

Re: [Qemu-devel] Let event loop use non-default GMainContext

On Mon, Apr 16, 2018 at 04:52:34PM +0800, Eva Chen wrote: > The reason for replacing default GMainContext is that I simultaneously run > two qemu, called A and B, in threads. However, these two QEMU using the > same default GMainContext causes A QEMU to handle the event from B QEMU, > and run B's h

Re: [Qemu-devel] [PATCH 0/9] block: Add COR filter driver

On Mon, Apr 16, 2018 at 06:58:40PM +0200, Max Reitz wrote: > In our quest to... (Oh, man, I always struggle with writing cover > letters. But rarely have I become stuck so early on.) Orthogonalize? You were off to a shaky start but it turned out to be a really good cover letter. Stefan signat

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.13 3/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

On 20.04.2018 09:36, Thomas Huth wrote: > On 20.04.2018 08:53, Viktor VM Mihajlovski wrote: >> On 19.04.2018 18:55, Thomas Huth wrote: [...] >> Well, if we don't add another identifier, and I feel reluctant about it >> as well for the reasons you wrote, we may stick with 0x1f and consider >> the ad

Re: [Qemu-devel] [PATCH v2 1/2] qapi: Rename QMP and QGA schema files

Eric Blake writes: > Having two files in the tree both named qapi-schema.json just adds > confusion. Rename these files to {qmp,qga}-schema to make it > obvious which schema is in effect, and relocate qga into the common > qapi/ subdirectory. Update all build rules that refer to the file > name

Re: [Qemu-devel] [libvirt] [qemu RFC v2] qapi: add "firmware.json"

On 04/19/18 11:12, Daniel P. Berrangé wrote: > On Thu, Apr 19, 2018 at 10:39:32AM +0200, Laszlo Ersek wrote: >> On 04/19/18 09:56, Daniel P. Berrangé wrote: >>> On Thu, Apr 19, 2018 at 09:48:36AM +0200, Markus Armbruster wrote: Laszlo Ersek writes: > On 04/18/18 10:47, Markus Armbrus

Re: [Qemu-devel] [PATCH v2] migration: discard non-migratable RAMBlocks

On 04/19/2018 07:45 PM, Edgar E. Iglesias wrote: On Thu, Apr 19, 2018 at 06:32:07PM +0100, Peter Maydell wrote: On 13 April 2018 at 08:52, Cédric Le Goater wrote: On the POWER9 processor, the XIVE interrupt controller can control interrupt sources using MMIO to trigger events, to EOI or to t

Re: [Qemu-devel] [PATCH v2 26/43] tests/tcg/arm: fix up test-arm-iwmmxt test

Richard Henderson writes: > On 04/19/2018 03:58 AM, Alex Bennée wrote: >> +test-arm-iwmmxt: CFLAGS+=-marm -march=iwmmxt -mabi=aapcs >> +test-arm-iwmmxt: test-arm-iwmmxt.S > > This appears to be insufficient. > If I begin with armv7l-linux-gnueabihf-gcc, then I get > > CROSS-BUILD arm guest-tes

Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

Richard Henderson writes: > On 04/17/2018 01:08 PM, Peter Maydell wrote: >> On 18 April 2018 at 00:01, Peter Maydell wrote: >>> I don't have the original IEEE754 spec to hand though; >>> that may have left this unspecified. >> >> Having located a copy of 754-1985 I think that also is >> clear e

Re: [Qemu-devel] [PATCH] docker: Rename the amd64 image as amd64-cross

On Fri, 04/20 00:41, Philippe Mathieu-Daudé wrote: > On 04/19/2018 11:57 PM, Fam Zheng wrote: > > On Thu, 04/19 23:40, Philippe Mathieu-Daudé wrote: > >> Like the other images, this one is also used to cross-compile. > >> Name it accordingly, matching directory pattern. > >> > >> Signed-off-by: Phi

Re: [Qemu-devel] [PATCH v3 01/35] ppc/xive: introduce a XIVE interrupt source model

On 04/20/2018 09:10 AM, David Gibson wrote: > On Thu, Apr 19, 2018 at 02:42:57PM +0200, Cédric Le Goater wrote: >> Each XIVE interrupt source is associated with a two bit state machine >> called an Event State Buffer (ESB) : the first bit "P" means that an >> interrupt is "pending" and waiting for

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.13 02/10] spapr: Remove support for PowerPC 970 with pseries machine type

On Fri, Apr 20, 2018 at 06:48:11AM +, luigi burdo wrote: > (because testing if we broke it means finding > a real 970 host). > > Hi, i have a real 970 host if you need an hand to test just ask Thanks, and I'll keep it in mind, but borrowing a system from some random person isn't really a mana

Re: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap set

On 2018年04月20日 13:11, Peter Xu wrote: On Fri, Apr 20, 2018 at 12:57:13PM +0800, Jason Wang wrote: On 2018年04月18日 12:51, Peter Xu wrote: During IOVA page table walk, there is a special case when: - notify_unmap is set, meanwhile - entry is invalid In the past, we skip the entry always. This

Re: [Qemu-devel] [PATCH v2 31/43] tests/tcg: enable building for MIPS

Philippe Mathieu-Daudé writes: > On 04/19/2018 02:58 PM, Peter Maydell wrote: >> On 19 April 2018 at 18:49, Alex Bennée wrote: >>> Philippe Mathieu-Daudé writes: On 04/19/2018 10:58 AM, Alex Bennée wrote: > This doesn't add any additional tests but enables building the > multiarch

Re: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap set

On 2018年04月18日 12:51, Peter Xu wrote: During IOVA page table walk, there is a special case when: - notify_unmap is set, meanwhile - entry is invalid In the past, we skip the entry always. This is not correct. We should send UNMAP notification to registered notifiers in this case. Otherwise

Re: [Qemu-devel] [Qemu-block] [PATCH 1/9] block: Add COR filter driver

On Mon, Apr 16, 2018 at 06:58:41PM +0200, Max Reitz wrote: > { 'enum': 'BlockdevDriver', > - 'data': [ 'blkdebug', 'blkverify', 'bochs', 'cloop', > + 'data': [ 'blkdebug', 'blkverify', 'bochs', 'cloop', 'cor', "copy-on-read" would be clearer than "cor" for the QMP API and the block/cor.c source

Re: [Qemu-devel] [Qemu-block] [PATCH 2/9] block: BLK_PERM_WRITE includes ..._UNCHANGED

On Mon, Apr 16, 2018 at 06:58:42PM +0200, Max Reitz wrote: > Currently we never actually check whether the WRITE_UNCHANGED > permission has been taken for unchanging writes. But the one check that > is commented out checks both WRITE and WRITE_UNCHANGED; and considering > that WRITE_UNCHANGED is a

Re: [Qemu-devel] [Qemu-block] [PATCH 4/9] block: Set BDRV_REQ_WRITE_UNCHANGED for COR writes

On Mon, Apr 16, 2018 at 06:58:44PM +0200, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > block/io.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH 3/9] block: Add BDRV_REQ_WRITE_UNCHANGED flag

On Mon, Apr 16, 2018 at 06:58:43PM +0200, Max Reitz wrote: > This flag signifies that a write request will not change the visible > disk content. With this flag set, it is sufficient to have the > BLK_PERM_WRITE_UNCHANGED permission instead of BLK_PERM_WRITE. > > Signed-off-by: Max Reitz > --- >

Re: [Qemu-devel] [Qemu-block] [PATCH 6/9] block: Support BDRV_REQ_WRITE_UNCHANGED in filters

On Mon, Apr 16, 2018 at 06:58:46PM +0200, Max Reitz wrote: > Update the rest of the filter drivers to support > BDRV_REQ_WRITE_UNCHANGED. They already forward write request flags to > their children, so we just have to announce support for it. > > This patch does not cover the replication driver

Re: [Qemu-devel] [PATCH v2 2/2] qapi: Rename .json to .qapi

Eric Blake writes: > Our QAPI input files aren't quite true JSON (comments being one obvious > difference); naming things .json doesn't make that obvious. Use a new > suffix .qapi that makes it easy to identify our files. I agree that .json is sub-optimal. Evidence: we add Emacs file variables

Re: [Qemu-devel] [Qemu-block] [PATCH v4 06/13] block: Generalize should_update_child() rule

On Wed 11 Apr 2018 08:54:18 PM CEST, Max Reitz wrote: > index c4dd1d4bb8..8d63a1b0c1 100644 > --- a/include/block/block_int.h > +++ b/include/block/block_int.h > @@ -616,6 +616,8 @@ struct BdrvChild { > QLIST_ENTRY(BdrvChild) next_parent; > }; > > +typedef QLIST_HEAD(BdrvChildList, BdrvChil

Re: [Qemu-devel] [Qemu-block] [PATCH 8/9] iotests: Copy 197 for COR filter driver

On Mon, Apr 16, 2018 at 06:58:48PM +0200, Max Reitz wrote: > iotest 197 tests copy-on-read using the (now old) copy-on-read flag. > Copy it to 215 and modify it to use the COR filter driver instead. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/215 | 120 >

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.13 3/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

On 20.04.2018 09:54, Viktor VM Mihajlovski wrote: > On 20.04.2018 09:36, Thomas Huth wrote: >> On 20.04.2018 08:53, Viktor VM Mihajlovski wrote: >>> On 19.04.2018 18:55, Thomas Huth wrote: > [...] >>> Well, if we don't add another identifier, and I feel reluctant about it >>> as well for the reason

Re: [Qemu-devel] [Qemu-block] [PATCH 7/9] iotests: Clean up wrap image in 197

On Mon, Apr 16, 2018 at 06:58:47PM +0200, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/197 | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH 1/2] hw/isa/superio: Fix inconsistent use of Chardev->be

On 19 April 2018 at 23:09, Philippe Mathieu-Daudé wrote: > 4c3119a6e3e and cd9526ab7c0 introduced an incorrect and inconsistent > use of Chardev->be. Also, this CharBackend member is private and is > not supposed to be accessible. > > Fix it by removing the inconsistent check. > > Reported-by: Mar

Re: [Qemu-devel] [PATCH 9/9] iotests: Add test for COR across nodes

On Mon, Apr 16, 2018 at 06:58:49PM +0200, Max Reitz wrote: > diff --git a/tests/qemu-iotests/216 b/tests/qemu-iotests/216 > new file mode 100755 > index 00..2f34f94faa > --- /dev/null > +++ b/tests/qemu-iotests/216 > @@ -0,0 +1,117 @@ > +#!/usr/bin/env python Welcome to the dark side! Rev

Re: [Qemu-devel] [PATCH 5/9] block/quorum: Support BDRV_REQ_WRITE_UNCHANGED

On Mon, Apr 16, 2018 at 06:58:45PM +0200, Max Reitz wrote: > We just need to forward it to quorum's children (except in case of a > rewrite because of corruption), but for that we first have to support > flags in child requests at all. > > Signed-off-by: Max Reitz > --- > block/quorum.c | 19 +++

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

On 20/04/2018 03:03, David Gibson wrote: >> This also implies I shouldn't add "openbios" separately, which was >> suggested earlier by Gerd -- according to >> , OpenBIOS is another >> implementation of OFW. > > Right. Although I think OpenBIOS and SLOF supp

Re: [Qemu-devel] [PATCH v2] migration: discard non-migratable RAMBlocks

On 20 April 2018 at 07:59, Cédric Le Goater wrote: > Hello David, > > On 04/19/2018 06:58 PM, Dr. David Alan Gilbert wrote: >> * Cédric Le Goater (c...@kaod.org) wrote: >>> @@ -1823,6 +1831,7 @@ void qemu_ram_set_idstr(RAMBlock *new_block, const >>> char *name, DeviceState *dev) >>> } >>

[Qemu-devel] [PATCH] vnc: fix use-after-free

When vnc_client_read() return value is -1 vs is not valid any more. Fixes: d49b87f0d1e0520443a990fc610d0f02bc63c556 Reported-by: Philippe Mathieu-Daudé Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index e1

Re: [Qemu-devel] [PATCH 1/1] Make qemu-bridge-helper work in macOS and FreeBSD

On Tue, Apr 17, 2018 at 09:57:46AM +0530, Nikhil Balachandra wrote: > Hi Stefan, > > Thanks for the review. I'll be sending v2 version of this patch in next 3-4 > days with the following changes. > > 1) New scripts/update-xnu-headers.sh script to import if_bridgevar.h[4] > into include/standard-h

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

On 04/20/18 10:47, Paolo Bonzini wrote: > On 20/04/2018 03:03, David Gibson wrote: >>> This also implies I shouldn't add "openbios" separately, which was >>> suggested earlier by Gerd -- according to >>> , OpenBIOS is another >>> implementation of OFW. >> >>

Re: [Qemu-devel] [PATCH] vnc: fix use-after-free

Hi On Fri, Apr 20, 2018 at 10:48 AM, Gerd Hoffmann wrote: > When vnc_client_read() return value is -1 > vs is not valid any more. > > Fixes: d49b87f0d1e0520443a990fc610d0f02bc63c556 > Reported-by: Philippe Mathieu-Daudé > Signed-off-by: Gerd Hoffmann Tested-by: Marc-André Lureau Reviewed-by:

Re: [Qemu-devel] [PATCH v2] migration: discard non-migratable RAMBlocks

On 04/20/2018 10:47 AM, Peter Maydell wrote: > On 20 April 2018 at 07:59, Cédric Le Goater wrote: >> Hello David, >> >> On 04/19/2018 06:58 PM, Dr. David Alan Gilbert wrote: >>> * Cédric Le Goater (c...@kaod.org) wrote: @@ -1823,6 +1831,7 @@ void qemu_ram_set_idstr(RAMBlock *new_block, const

Re: [Qemu-devel] [PATCH] test: Add test cases that use the external swtpm with CRB interface

On Thu, Apr 19, 2018 at 6:39 PM, Stefan Berger wrote: > Add a test program for testing the CRB with the external swtpm. > > The 1st test case extends a PCR and reads back the value and compares > it against an expected return packet. > > The 2nd test case repeats the 1st test case and then migrate

Re: [Qemu-devel] [PATCH for-2.13 01/10] spapr: Avoid redundant calls to spapr_cpu_reset()

On Fri, 20 Apr 2018 16:34:37 +1000 David Gibson wrote: > On Thu, Apr 19, 2018 at 03:48:23PM +0200, Greg Kurz wrote: > > On Tue, 17 Apr 2018 17:17:13 +1000 > > David Gibson wrote: > > > > > af81cf323c1 "spapr: CPU hotplug support" added a direct call to > > > spapr_cpu_reset() in spapr_cpu_ini

Re: [Qemu-devel] [PATCH for-2.13 04/10] spapr: Set compatibility mode before the rest of spapr_cpu_reset()

On Tue, 17 Apr 2018 17:17:16 +1000 David Gibson wrote: > Although the order doesn't really matter at the moment, it's possible > other initializastions could depend on the compatiblity mode, so make sure > we set it first in spapr_cpu_reset(). > > While we're at it drop the test against first_cp

Re: [Qemu-devel] [PATCH v2] migration: discard non-migratable RAMBlocks

On Fri, Apr 20, 2018 at 10:14:15AM +0200, KONRAD Frederic wrote: > > > On 04/19/2018 07:45 PM, Edgar E. Iglesias wrote: > > On Thu, Apr 19, 2018 at 06:32:07PM +0100, Peter Maydell wrote: > > > On 13 April 2018 at 08:52, Cédric Le Goater wrote: > > > > On the POWER9 processor, the XIVE interrupt

Re: [Qemu-devel] [PATCH v2 2/2] qapi: Rename .json to .qapi

* Markus Armbruster (arm...@redhat.com) wrote: > Eric Blake writes: > > > Our QAPI input files aren't quite true JSON (comments being one obvious > > difference); naming things .json doesn't make that obvious. Use a new > > suffix .qapi that makes it easy to identify our files. > > I agree that

Re: [Qemu-devel] [PATCH v2 31/43] tests/tcg: enable building for MIPS

Philippe Mathieu-Daudé writes: > On 04/19/2018 02:58 PM, Peter Maydell wrote: >> On 19 April 2018 at 18:49, Alex Bennée wrote: >>> Philippe Mathieu-Daudé writes: On 04/19/2018 10:58 AM, Alex Bennée wrote: > This doesn't add any additional tests but enables building the > multiarch

Re: [Qemu-devel] [RFC for-2.13 0/7] spapr: Clean up pagesize handling

On Fri, 2018-04-20 at 12:35 +1000, David Gibson wrote: > On Thu, Apr 19, 2018 at 05:30:04PM +0200, Andrea Bolognani wrote: > > On Thu, 2018-04-19 at 16:29 +1000, David Gibson wrote: > > > This means that in order to use hugepages in a PAPR guest it's > > > necessary to add a "cap-hpt-mps=24" machin

Re: [Qemu-devel] [libvirt] [qemu RFC v2] qapi: add "firmware.json"

On Fri, Apr 20, 2018 at 10:11:08AM +0200, Laszlo Ersek wrote: > On 04/19/18 11:12, Daniel P. Berrangé wrote: > > On Thu, Apr 19, 2018 at 10:39:32AM +0200, Laszlo Ersek wrote: > >> On 04/19/18 09:56, Daniel P. Berrangé wrote: > >>> On Thu, Apr 19, 2018 at 09:48:36AM +0200, Markus Armbruster wrote: >

Re: [Qemu-devel] [PATCH v3 0/3] Use SDL to create an OpenGL ES context for virglrenderer.

On Fri, Apr 13, 2018 at 02:58:39PM +0100, Elie Tournier wrote: > Hi, > Hello, Humble ping. This series is unreviewed. BR, Elie > v2: Rebase on top of master > v3: Fix the json format (Eric Blake) > Move DisplayOptions from ui/sdl2.c to include/ui/sdl2.h (Gerd Hoffmann) > Fix a compariso

Re: [Qemu-devel] [PATCH] vnc: fix use-after-free

On Fri, Apr 20, 2018 at 10:48:19AM +0200, Gerd Hoffmann wrote: > When vnc_client_read() return value is -1 > vs is not valid any more. > > Fixes: d49b87f0d1e0520443a990fc610d0f02bc63c556 > Reported-by: Philippe Mathieu-Daudé > Signed-off-by: Gerd Hoffmann > --- > ui/vnc.c | 5 +++-- > 1 file ch

Re: [Qemu-devel] [libvirt] [qemu RFC v2] qapi: add "firmware.json"

Hi, > Since your schema is likely to end up just being a file in docs/specs, > rather than directly part of our existnig qapi schema, I suggest we just > ignore whats there. Just define an arch enum in your spec which is right, > and let someone else worry about fixing the mess I think it would

Re: [Qemu-devel] [libvirt] [qemu RFC v2] qapi: add "firmware.json"

On Fri, Apr 20, 2018 at 11:46:24AM +0200, Gerd Hoffmann wrote: > Hi, > > > Since your schema is likely to end up just being a file in docs/specs, > > rather than directly part of our existnig qapi schema, I suggest we just > > ignore whats there. Just define an arch enum in your spec which is ri

Re: [Qemu-devel] [PATCH v4 03/21] target/arm: Reorganize PMCCNTR accesses

On 17 April 2018 at 21:37, Aaron Lindsay wrote: > pmccntr_read and pmccntr_write contained duplicate code that was already > being handled by pmccntr_sync. Consolidate the duplicated code into two > functions: pmccntr_op_start and pmccntr_op_finish. Add a companion to > c15_ccnt in CPUARMState so

Re: [Qemu-devel] [PATCH 14/16] os-posix: cleanup: Replace fprintf with error_report in remaining call sites

Philippe Mathieu-Daudé writes ("Re: [Qemu-devel] [PATCH 14/16] os-posix: cleanup: Replace fprintf with error_report in remaining call sites"): > On 04/19/2018 01:45 PM, Ian Jackson wrote: > > -fprintf(stderr, "Change of process name not supported by your OS\n"); > > +error_report("Change o

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Thu, Apr 19, 2018 at 12:24:04PM +0100, Dr. David Alan Gilbert wrote: > > * Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > > > On Wed, Apr 18, 2018 at 09:36:33AM +0100, Dr. David Alan Gilbert wrote: > > > > * Balamuruhan S (bal...@linux.vn

Re: [Qemu-devel] [PATCH v2 00/43] fix building of tests/tcg

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180419135901.30035-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v2 00/43] fix building of tests/tcg === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(gi

Re: [Qemu-devel] [PATCH v4 03/21] target/arm: Reorganize PMCCNTR accesses

On 17 April 2018 at 21:37, Aaron Lindsay wrote: > pmccntr_read and pmccntr_write contained duplicate code that was already > being handled by pmccntr_sync. Consolidate the duplicated code into two > functions: pmccntr_op_start and pmccntr_op_finish. Add a companion to > c15_ccnt in CPUARMState so

Re: [Qemu-devel] [libvirt] [qemu RFC v2] qapi: add "firmware.json"

> > > Since your schema is likely to end up just being a file in docs/specs, > > I think it would be useful to have this as part of the schema. Should > > be easy then to write up a small utility then which takes a json file as > > input and translates that into qemu command line options. > > Cu

Re: [Qemu-devel] [PATCH v3 0/3] Use SDL to create an OpenGL ES context for virglrenderer.

On Fri, Apr 20, 2018 at 10:32:53AM +0100, Elie Tournier wrote: > On Fri, Apr 13, 2018 at 02:58:39PM +0100, Elie Tournier wrote: > > Hi, > > > Hello, > > Humble ping. > This series is unreviewed. Looks sane. Plan to include it in the next pull request (unless something shows up in testing). Wai

[Qemu-devel] [PATCH] simple firmware.json test tool

applies on top of the firmware.json v2 series. --- configure | 2 +- Makefile| 2 ++ qemu-firmware.c | 81 + 3 files changed, 84 insertions(+), 1 deletion(-) create mode 100644 qemu-firmware.c diff --git a/configure b/config

Re: [Qemu-devel] [PATCH] simple firmware.json test tool

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180420104743.7396-1-kra...@redhat.com Subject: [Qemu-devel] [PATCH] simple firmware.json test tool === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --on

Re: [Qemu-devel] [PATCH v3 0/3] Use SDL to create an OpenGL ES context for virglrenderer.

On Fri, Apr 20, 2018 at 12:44:44PM +0200, Gerd Hoffmann wrote: > On Fri, Apr 20, 2018 at 10:32:53AM +0100, Elie Tournier wrote: > > On Fri, Apr 13, 2018 at 02:58:39PM +0100, Elie Tournier wrote: > > > Hi, > > > > > Hello, > > > > Humble ping. > > This series is unreviewed. > > Looks sane. Plan

Re: [Qemu-devel] [PATCH] simple firmware.json test tool

Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180420104743.7396-1-kra...@redhat.com Subject: [Qemu-devel] [PATCH] simple firmware.json test tool === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git check

Re: [Qemu-devel] [PATCH] simple firmware.json test tool

Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180420104743.7396-1-kra...@redhat.com Subject: [Qemu-devel] [PATCH] simple firmware.json

Re: [Qemu-devel] [PATCH v4 00/21] More fully implement ARM PMUv3

On 17 April 2018 at 21:37, Aaron Lindsay wrote: > The ARM PMU implementation currently contains a basic cycle counter, but it is > often useful to gather counts of other events and filter them based on > execution mode. These patches flesh out the implementations of various PMU > registers includi

Re: [Qemu-devel] [PATCH] simple firmware.json test tool

Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180420104743.7396-1-kra...@redhat.com Subject: [Qemu-devel] [PATCH] simple firmware.js

Re: [Qemu-devel] [PATCH v2 31/43] tests/tcg: enable building for MIPS

On 20 April 2018 at 03:57, Philippe Mathieu-Daudé wrote: > On 04/19/2018 02:58 PM, Peter Maydell wrote: >> I don't think we really want to get into the business of >> building our own cross compilers if we can avoid it...it's harder >> than it looks and we would be essentially reinventing the whee

Re: [Qemu-devel] [SPDK] qemu process hung at boot-up, no explicit errors or warnings

2.11.1 could work, qemu is no longer occupying 100% CPU. That's interesting... Now I can see the starting screen via vnc, says that not a bootable disk. Is that because the guest OS's virtio vhost driver is not up to date enough? ​ Thanks, Bob 2018-04-20 1:17 GMT+08:00 John Snow : > Forwardin

Re: [Qemu-devel] [PATCH for-2.13 03/10] target/ppc: Remove unnecessary initialization of LPCR_UPRT

On Tue, 17 Apr 2018 17:17:15 +1000 David Gibson wrote: > In cpu_ppc_set_papr() the UPRT and GTSE bits of the LPCR are initialized > based on on ppc64_radix_guest(). Which seems reasonable, except that > ppc64_radix_guest() is based on spapr->patb_entry which is only set up > in spapr_machine_res

Re: [Qemu-devel] [RFC for-2.13 0/7] spapr: Clean up pagesize handling

On Fri, Apr 20, 2018 at 11:31:10AM +0200, Andrea Bolognani wrote: > On Fri, 2018-04-20 at 12:35 +1000, David Gibson wrote: > > On Thu, Apr 19, 2018 at 05:30:04PM +0200, Andrea Bolognani wrote: > > > On Thu, 2018-04-19 at 16:29 +1000, David Gibson wrote: > > > > This means that in order to use hugep

Re: [Qemu-devel] [PATCH for-2.13 04/10] spapr: Set compatibility mode before the rest of spapr_cpu_reset()

On Fri, Apr 20, 2018 at 11:16:27AM +0200, Greg Kurz wrote: > On Tue, 17 Apr 2018 17:17:16 +1000 > David Gibson wrote: > > > Although the order doesn't really matter at the moment, it's possible > > other initializastions could depend on the compatiblity mode, so make sure > > we set it first in s

Re: [Qemu-devel] [PATCH v2 31/43] tests/tcg: enable building for MIPS

Peter Maydell writes: > On 20 April 2018 at 03:57, Philippe Mathieu-Daudé wrote: >> On 04/19/2018 02:58 PM, Peter Maydell wrote: >>> I don't think we really want to get into the business of >>> building our own cross compilers if we can avoid it...it's harder >>> than it looks and we would be e

Re: [Qemu-devel] [PATCH] vnc: fix use-after-free

Cc'ing qemu-stable On 04/20/2018 05:48 AM, Gerd Hoffmann wrote: > When vnc_client_read() return value is -1 > vs is not valid any more. > > Fixes: d49b87f0d1e0520443a990fc610d0f02bc63c556 > Reported-by: Philippe Mathieu-Daudé > Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [Qemu-block] [PATCH 2/9] block: BLK_PERM_WRITE includes ..._UNCHANGED

On Mon 16 Apr 2018 06:58:42 PM CEST, Max Reitz wrote: > Currently we never actually check whether the WRITE_UNCHANGED > permission has been taken for unchanging writes. But the one check that > is commented out checks both WRITE and WRITE_UNCHANGED; and considering > that WRITE_UNCHANGED is alread

Re: [Qemu-devel] [Qemu-block] [PATCH 4/9] block: Set BDRV_REQ_WRITE_UNCHANGED for COR writes

On Mon 16 Apr 2018 06:58:44 PM CEST, Max Reitz wrote: > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [Qemu-block] [PATCH 3/9] block: Add BDRV_REQ_WRITE_UNCHANGED flag

On Mon 16 Apr 2018 06:58:43 PM CEST, Max Reitz wrote: > This flag signifies that a write request will not change the visible > disk content. With this flag set, it is sufficient to have the > BLK_PERM_WRITE_UNCHANGED permission instead of BLK_PERM_WRITE. > > Signed-off-by: Max Reitz Reviewed-by:

Re: [Qemu-devel] [Qemu-block] [PATCH 5/9] block/quorum: Support BDRV_REQ_WRITE_UNCHANGED

On Mon 16 Apr 2018 06:58:45 PM CEST, Max Reitz wrote: > We just need to forward it to quorum's children (except in case of a > rewrite because of corruption), but for that we first have to support > flags in child requests at all. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v2] migration: discard non-migratable RAMBlocks

On 13 April 2018 at 08:52, Cédric Le Goater wrote: > On the POWER9 processor, the XIVE interrupt controller can control > interrupt sources using MMIO to trigger events, to EOI or to turn off > the sources. Priority management and interrupt acknowledgment is also > controlled by MMIO in the presen

Re: [Qemu-devel] [PATCH v2] qcow2: add overlap check for bitmap directory

19.04.2018 23:57, John Snow wrote: On 03/19/2018 04:07 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- If it appropriate for 2.12, let's push it. If not - then for 2.13. I wonder if I can make the case that this should be in 2.12.1; arguably it is imp

Re: [Qemu-devel] [Qemu-block] [PATCH 6/9] block: Support BDRV_REQ_WRITE_UNCHANGED in filters

On Mon 16 Apr 2018 06:58:46 PM CEST, Max Reitz wrote: > Update the rest of the filter drivers to support > BDRV_REQ_WRITE_UNCHANGED. They already forward write request flags to > their children, so we just have to announce support for it. > > This patch does not cover the replication driver becaus

Re: [Qemu-devel] [Qemu-block] [PATCH 7/9] iotests: Clean up wrap image in 197

On Mon 16 Apr 2018 06:58:47 PM CEST, Max Reitz wrote: > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v2 4/7] dirty-bitmap: separate unused meta-bitmap related functions

20.04.2018 00:54, John Snow wrote: On 04/16/2018 07:44 AM, Vladimir Sementsov-Ogievskiy wrote: Separate them in the header and clarify needed locking in comments. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h | 14 +- block/dirty-bitmap.c |

Re: [Qemu-devel] [PATCH for-2.13 02/10] spapr: Remove support for PowerPC 970 with pseries machine type

On Tue, 17 Apr 2018 17:17:14 +1000 David Gibson wrote: > Current POWER cpus allow for a VRMA, a special mapping which describes a > guest's view of memory when in real mode (MMU off, from the guest's point > of view). Older cpus didn't have that which meant that to support a guest > a special ho

Re: [Qemu-devel] [PATCH v2 5/7] blockdev: refactor block-dirty-bitmap-clear transaction

20.04.2018 01:47, John Snow wrote: On 04/16/2018 07:44 AM, Vladimir Sementsov-Ogievskiy wrote: bdrv_clear_dirty_bitmap do not fail, so we can call it in transaction commit, avoiding any rollback. After this, bdrv_undo_clear_dirty_bitmap() becomes unused, so, drop it. I'm trying to remember w

[Qemu-devel] [PATCH v3 0/3] pc-dimm: factor out MemoryDevice

Right now we can only map PCDIMM/NVDIMM into guest address space. In the future, we might want to do the same for virtio devices - e.g. virtio-pmem or virtio-mem. Especially, they should be able to live side by side to each other. E.g. the virto based memory devices regions will not be exposed via

[Qemu-devel] [PATCH v3 2/3] machine: make MemoryHotplugState accessible via the machine

Let's allow to query the MemoryHotplugState from the machine. This allows us to generically detect if a certain machine has support for memory devices, and to generically manage it (find free address range, plug/unplug a memory region). Signed-off-by: David Hildenbrand --- hw/i386/pc.c

[Qemu-devel] [PATCH v3 1/3] pc-dimm: factor out MemoryDevice interface

On the qmp level, we already have the concept of memory devices: "query-memory-devices" Right now, we only support NVDIMM and PCDIMM. We want to map other devices later into the address space of the guest. Such device could e.g. be virtio devices. These devices will have a guest memory range a

[Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code

To be able to reuse MemoryDevice logic from other devices besides pc-dimm, factor the relevant stuff out into the MemoryDevice code. As we don't care about slots for memory devices that are not pc-dimm, don't factor that part out. Most of this patch just moves checks and logic around. While at it

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.13 3/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

On 20.04.2018 10:40, Thomas Huth wrote: > On 20.04.2018 09:54, Viktor VM Mihajlovski wrote: >> On 20.04.2018 09:36, Thomas Huth wrote: >>> On 20.04.2018 08:53, Viktor VM Mihajlovski wrote: On 19.04.2018 18:55, Thomas Huth wrote: >> [...] Well, if we don't add another identifier, and I fee

  1   2   3   >