Re: [Qemu-devel] [PATCH v2 1/2] vhost-user-blk: set config ops before vhost-user init

2018-03-29 Thread Maxime Coquelin
On 03/29/2018 02:53 AM, Liu, Changpeng wrote: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Thursday, March 29, 2018 3:28 AM To: m...@redhat.com; Liu, Changpeng ; marcandre.lur...@redhat.com; qemu-devel@nongnu.org Cc: Maxime Coquelin Subject: [PA

[Qemu-devel] [PATCH v3 0/2] vhost-user: Back SET/GET_CONFIG with a protocol feature

2018-03-29 Thread Maxime Coquelin
V3 removes the assert of vhost_dev's vhost_ops, as it is not yet set at that time. While reviewing DPDK series adding support to VHOST_USER_SET_CONFIG and VHOST_USER_GET_CONFIG request, I found that it was not backed with a dedicated protocol feature. This series addresses this by adding a new p

[Qemu-devel] [PATCH v3 2/2] vhost-user: back SET/GET_CONFIG requests with a protocol feature

2018-03-29 Thread Maxime Coquelin
Without a dedicated protocol feature, QEMU cannot know whether the backend can handle VHOST_USER_SET_CONFIG and VHOST_USER_GET_CONFIG messages. This patch adds a protocol feature that is only advertised by QEMU if the device implements the config ops. Vhost user init fails if the device support th

[Qemu-devel] [PATCH v3 1/2] vhost-user-blk: set config ops before vhost-user init

2018-03-29 Thread Maxime Coquelin
As soon as vhost-user init is done, the backend may send VHOST_USER_SLAVE_CONFIG_CHANGE_MSG, so let's set the notification callback before it. Also, it will be used to know whether the device supports the config feature to advertize it or not. Signed-off-by: Maxime Coquelin --- hw/block/vhost-u

Re: [Qemu-devel] [PATCH v2 2/2] vhost-user: back SET/GET_CONFIG requests with a protocol feature

2018-03-29 Thread Maxime Coquelin
On 03/29/2018 02:57 AM, Liu, Changpeng wrote: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Thursday, March 29, 2018 3:28 AM To: m...@redhat.com; Liu, Changpeng ; marcandre.lur...@redhat.com; qemu-devel@nongnu.org Cc: Maxime Coquelin Subject: [PA

Re: [Qemu-devel] [PATCH v2 2/2] vhost-user: back SET/GET_CONFIG requests with a protocol feature

2018-03-29 Thread Liu, Changpeng
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Thursday, March 29, 2018 3:56 PM > To: Liu, Changpeng ; m...@redhat.com; > marcandre.lur...@redhat.com; qemu-devel@nongnu.org > Subject: Re: [PATCH v2 2/2] vhost-user: back SET/GET_CONFIG requests wit

Re: [Qemu-devel] [PATCH v2 2/2] vhost-user: back SET/GET_CONFIG requests with a protocol feature

2018-03-29 Thread Maxime Coquelin
On 03/29/2018 10:05 AM, Liu, Changpeng wrote: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Thursday, March 29, 2018 3:56 PM To: Liu, Changpeng ; m...@redhat.com; marcandre.lur...@redhat.com; qemu-devel@nongnu.org Subject: Re: [PATCH v2 2/2] vhost

Re: [Qemu-devel] [PATCH v4 for 2.12 0/3] fix bitmaps migration through shared storage

2018-03-29 Thread Vladimir Sementsov-Ogievskiy
28.03.2018 17:53, Max Reitz wrote: On 2018-03-27 12:11, Vladimir Sementsov-Ogievskiy wrote: 27.03.2018 12:53, Vladimir Sementsov-Ogievskiy wrote: 27.03.2018 12:28, Vladimir Sementsov-Ogievskiy wrote: 26.03.2018 21:06, Max Reitz wrote: On 2018-03-20 18:05, Vladimir Sementsov-Ogievskiy wrote:

Re: [Qemu-devel] [PATCH v2 5/6] e1000: Choose which set of props to migrate

2018-03-29 Thread Dr. David Alan Gilbert
* Jason Wang (jasow...@redhat.com) wrote: > > > On 2018年03月29日 00:36, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > When we're using the subsection we migrate both > > the 'props' and 'tso_props' data; when we're not using > > the subsection (to migrate to 2.11

Re: [Qemu-devel] [PATCH v2 5/6] e1000: Choose which set of props to migrate

2018-03-29 Thread Jason Wang
On 2018年03月29日 16:08, Dr. David Alan Gilbert wrote: * Jason Wang (jasow...@redhat.com) wrote: On 2018年03月29日 00:36, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" When we're using the subsection we migrate both the 'props' and 'tso_props' data; when we're not using the

Re: [Qemu-devel] [PATCH v2 5/6] e1000: Choose which set of props to migrate

2018-03-29 Thread Dr. David Alan Gilbert
* Jason Wang (jasow...@redhat.com) wrote: > > > On 2018年03月29日 16:08, Dr. David Alan Gilbert wrote: > > * Jason Wang (jasow...@redhat.com) wrote: > > > > > > On 2018年03月29日 00:36, Dr. David Alan Gilbert (git) wrote: > > > > From: "Dr. David Alan Gilbert" > > > > > > > > When we're using the su

Re: [Qemu-devel] [PATCH v5 for 2.13 3/4] docs: tpm: add VM save/restore example and troubleshooting guide

2018-03-29 Thread Dr. David Alan Gilbert
* Stefan Berger (stef...@linux.vnet.ibm.com) wrote: > On 03/28/2018 11:48 AM, Marc-André Lureau wrote: > > Hi > > > > On Fri, Mar 16, 2018 at 10:46 PM, Stefan Berger > > wrote: > > > Extend the docs related to TPM with specs related to VM save and > > > restore and a troubleshooting guide for TPM

[Qemu-devel] [Bug 1588591] Re: Qemu 2.6 Solaris 8 Sparc telnet terminate itself

2018-03-29 Thread Thomas Huth
Zhen Ning Lim, can you still reproduce the problem where QEMU terminates itself after printing that warning message? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.la

[Qemu-devel] [Bug 1588591] Re: Qemu 2.6 Solaris 8 Sparc telnet terminate itself

2018-03-29 Thread Zhen Ning Lim
Nope. Not anymore. I shall close this. Thanks! ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1588591 Title: Qemu 2.6 Solaris 8 Sparc t

[Qemu-devel] [PATCH 0/3] fix memory leaks when using object_property_get_str()

2018-03-29 Thread Greg Kurz
According to include/qom/object.h: /** * object_property_get_str: * @obj: the object * @name: the name of the property * @errp: returns an error if this function fails * * Returns: the value of the property, converted to a C string, or NULL if * an error occurs (including when the property

[Qemu-devel] [PATCH 1/3] exec: fix memory leak in find_max_supported_pagesize()

2018-03-29 Thread Greg Kurz
The string returned by object_property_get_str() is dynamically allocated. Signed-off-by: Greg Kurz --- exec.c |1 + 1 file changed, 1 insertion(+) diff --git a/exec.c b/exec.c index c09bd93df31e..02b1efebb7c3 100644 --- a/exec.c +++ b/exec.c @@ -1495,6 +1495,7 @@ static int find_max_suppor

[Qemu-devel] [PATCH 2/3] hw/s390x: fix memory leak in s390_init_ipl_dev()

2018-03-29 Thread Greg Kurz
The string returned by object_property_get_str() is dynamically allocated. Fixes: 3c4e9baacf4d9 Signed-off-by: Greg Kurz --- hw/s390x/s390-virtio-ccw.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 864145a

[Qemu-devel] [PATCH 3/3] sev/i386: fix memory leak in sev_guest_init()

2018-03-29 Thread Greg Kurz
The string returned by object_property_get_str() is dynamically allocated. Fixes: d8575c6c0242b Signed-off-by: Greg Kurz --- target/i386/sev.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/i386/sev.c b/target/i386/sev.c index 019d84cef2c7..c01167143f1c 100644 -

Re: [Qemu-devel] [PATCH 1/3] exec: fix memory leak in find_max_supported_pagesize()

2018-03-29 Thread Cornelia Huck
On Thu, 29 Mar 2018 11:09:46 +0200 Greg Kurz wrote: > The string returned by object_property_get_str() is dynamically allocated. > > Signed-off-by: Greg Kurz > --- > exec.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/exec.c b/exec.c > index c09bd93df31e..02b1efebb7c3 100644 >

Re: [Qemu-devel] [PATCH 2/3] hw/s390x: fix memory leak in s390_init_ipl_dev()

2018-03-29 Thread Cornelia Huck
On Thu, 29 Mar 2018 11:10:06 +0200 Greg Kurz wrote: > The string returned by object_property_get_str() is dynamically allocated. > > Fixes: 3c4e9baacf4d9 > Signed-off-by: Greg Kurz > --- > hw/s390x/s390-virtio-ccw.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH] migration: fix pfd leak

2018-03-29 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Fix leak spotted by ASAN: > > Direct leak of 16 byte(s) in 1 object(s) allocated from: > #0 0x7fe1abb80a38 in __interceptor_calloc (/lib64/libasan.so.4+0xdea38) > #1 0x7fe1aaf1bf75 in g_malloc0 ../glib/gmem.c:124 > #2 0x7fe1aaf

Re: [Qemu-devel] [PATCH 3/3] sev/i386: fix memory leak in sev_guest_init()

2018-03-29 Thread Cornelia Huck
On Thu, 29 Mar 2018 11:10:21 +0200 Greg Kurz wrote: > The string returned by object_property_get_str() is dynamically allocated. > > Fixes: d8575c6c0242b > Signed-off-by: Greg Kurz > --- > target/i386/sev.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/target/

Re: [Qemu-devel] [PATCH 2/3] hw/s390x: fix memory leak in s390_init_ipl_dev()

2018-03-29 Thread Igor Mammedov
On Thu, 29 Mar 2018 11:10:06 +0200 Greg Kurz wrote: > The string returned by object_property_get_str() is dynamically allocated. > > Fixes: 3c4e9baacf4d9 > Signed-off-by: Greg Kurz > --- > hw/s390x/s390-virtio-ccw.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH 2/3] hw/s390x: fix memory leak in s390_init_ipl_dev()

2018-03-29 Thread Cornelia Huck
On Thu, 29 Mar 2018 11:27:21 +0200 Igor Mammedov wrote: > On Thu, 29 Mar 2018 11:10:06 +0200 > Greg Kurz wrote: > > > The string returned by object_property_get_str() is dynamically allocated. > > > > Fixes: 3c4e9baacf4d9 > > Signed-off-by: Greg Kurz > > --- > > hw/s390x/s390-virtio-ccw.c |

[Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: Increase virtio timeout to 30 seconds

2018-03-29 Thread Thomas Huth
The current timeout is set to only three seconds - and considering that vring_wait_reply() or rather get_second() is not doing any rounding, the real timeout is likely rather 2 seconds in most cases. When the host is really badly loaded and we run the guest in TCG mode instead of KVM, it's possible

Re: [Qemu-devel] [PATCH 2/3] hw/s390x: fix memory leak in s390_init_ipl_dev()

2018-03-29 Thread Greg Kurz
On Thu, 29 Mar 2018 11:27:21 +0200 Igor Mammedov wrote: > On Thu, 29 Mar 2018 11:10:06 +0200 > Greg Kurz wrote: > > > The string returned by object_property_get_str() is dynamically allocated. > > > > Fixes: 3c4e9baacf4d9 > > Signed-off-by: Greg Kurz > > --- > > hw/s390x/s390-virtio-ccw.c |

Re: [Qemu-devel] [PATCH for-2.12 v4] iotests: Test abnormally large size in compressed cluster descriptor

2018-03-29 Thread Alberto Garcia
On Wed 28 Mar 2018 07:34:15 PM CEST, Max Reitz wrote: >> diff --git a/tests/qemu-iotests/122 b/tests/qemu-iotests/122 >> index 45b359c2ba..5b9593016c 100755 >> --- a/tests/qemu-iotests/122 >> +++ b/tests/qemu-iotests/122 > > Not sure if 122 is the right file for this... > > Or, let me rephrase, it

Re: [Qemu-devel] [PATCH 1/3] exec: fix memory leak in find_max_supported_pagesize()

2018-03-29 Thread Greg Kurz
On Thu, 29 Mar 2018 11:18:31 +0200 Cornelia Huck wrote: > On Thu, 29 Mar 2018 11:09:46 +0200 > Greg Kurz wrote: > > > The string returned by object_property_get_str() is dynamically allocated. > > > > Signed-off-by: Greg Kurz > > --- > > exec.c |1 + > > 1 file changed, 1 insertion(+) >

Re: [Qemu-devel] [PATCH] migration: Don't activate block devices if using -S

2018-03-29 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Activating the block devices causes the locks to be taken on > the backing file. If we're running with -S and the destination libvirt > hasn't started the destination with 'cont', it's expecting the

Re: [Qemu-devel] [PATCH for-2.12 v2 2/2] i386/hyperv: error out if features requested but unsupported

2018-03-29 Thread Roman Kagan
On Wed, Mar 28, 2018 at 03:53:31PM -0300, Eduardo Habkost wrote: > On Wed, Mar 28, 2018 at 06:30:24PM +0300, Roman Kagan wrote: > > In order to guarantee compatibility on migration, QEMU should have > > complete control over the features it announces to the guest via CPUID. > > > > However, for a

Re: [Qemu-devel] [PATCH v4 5/9] qapi: introduce new cmd option "allowed-in-preconfig"

2018-03-29 Thread Igor Mammedov
On Wed, 28 Mar 2018 16:30:16 -0300 Eduardo Habkost wrote: > On Wed, Mar 28, 2018 at 02:29:57PM +0200, Igor Mammedov wrote: > > On Fri, 23 Mar 2018 18:28:37 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Mar 12, 2018 at 02:11:11PM +0100, Igor Mammedov wrote: > > > > New option will be us

Re: [Qemu-devel] [PATCH 03/16] tcg: track TBs with per-region BST's

2018-03-29 Thread Alex Bennée
Emilio G. Cota writes: > This paves the way for enabling scalable parallel generation of TCG code. > > Instead of tracking TBs with a single binary search tree (BST), use a > BST for each TCG region, protecting it with a lock. This is as scalable > as it gets, since each TCG thread operates on a

Re: [Qemu-devel] [PATCH for 2.13 00/19] linux-user: move arch specific parts from main.c to arch directories

2018-03-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180326191603.10217-1-laur...@vivier.eu Subject: [Qemu-devel] [PATCH for 2.13 00/19] linux-user: move arch specific parts from main.c to arch directories === TEST SCRIPT BE

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.13] Add host_memory_backend_pagesize() helper

2018-03-29 Thread Greg Kurz
On Thu, 29 Mar 2018 08:37:48 +0200 Greg Kurz wrote: > On Thu, 29 Mar 2018 16:25:37 +1100 > David Gibson wrote: > > > There are a couple places (one generic, one target specific) where we need > > to get the host page size associated with a particular memory backend. I > > have some upcoming co

Re: [Qemu-devel] [PATCH v2 00/14] fp-test + hardfloat

2018-03-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1522128840-498-1-git-send-email-c...@braap.org Subject: [Qemu-devel] [PATCH v2 00/14] fp-test + hardfloat === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] [PATCH v2 09/14] hardfloat: support float32/64 multiplication

2018-03-29 Thread Alex Bennée
Emilio G. Cota writes: > On Wed, Mar 28, 2018 at 14:26:30 +0100, Alex Bennée wrote: >> Emilio G. Cota writes: >> OK I've had a bit more of a play and I think we can drop the macro abuse >> and have common wrappers for the host_fpu. We don't want to intermingle >> with the soft float slow path t

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: Increase virtio timeout to 30 seconds

2018-03-29 Thread Christian Borntraeger
On 03/29/2018 11:37 AM, Thomas Huth wrote: > The current timeout is set to only three seconds - and considering that > vring_wait_reply() or rather get_second() is not doing any rounding, > the real timeout is likely rather 2 seconds in most cases. When the > host is really badly loaded and we ru

Re: [Qemu-devel] [PATCH 04/16] tcg: move tb_ctx.tb_phys_invalidate_count to tcg_ctx

2018-03-29 Thread Alex Bennée
Emilio G. Cota writes: > Thereby making it per-TCGContext. Once we remove tb_lock, this will > avoid an atomic increment every time a TB is invalidated. > > Signed-off-by: Emilio G. Cota > --- > accel/tcg/translate-all.c | 5 +++-- > include/exec/tb-context.h | 1 - > tcg/tcg.c

Re: [Qemu-devel] [PATCH 09/16] translate-all: move tb_invalidate_phys_page_range up in the file

2018-03-29 Thread Alex Bennée
Emilio G. Cota writes: > This greatly simplifies next commit's diff. > > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > accel/tcg/translate-all.c | 77 > --- > 1 file changed, 39 insertions(+), 38 deletions(-) > > diff --git a/acc

Re: [Qemu-devel] [PATCH 08/16] translate-all: work page-by-page in tb_invalidate_phys_range_1

2018-03-29 Thread Alex Bennée
Emilio G. Cota writes: > So that we pass a same-page range to tb_invalidate_phys_page_range, > instead of always passing an end address that could be on a different > page. > > As discussed with Peter Maydell on the list [1], tb_invalidate_phys_page_range > doesn't actually do much with 'end', w

Re: [Qemu-devel] [PATCH] file-posix: Support fallocate for block device

2018-03-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1522204637-29589-1-git-send-email-zhenwei...@youruncloud.com Subject: [Qemu-devel] [PATCH] file-posix: Support fallocate for block device === TEST SCRIPT BEGIN === #!/bin/bas

Re: [Qemu-devel] [PATCH qemu] vfio: Print address space address when cannot map MMIO for DMA

2018-03-29 Thread Auger Eric
Hi Alexey, On 29/03/18 03:55, Alexey Kardashevskiy wrote: > On 29/3/18 8:03 am, Auger Eric wrote: >> Hi Alexey, Alex, >> On 22/03/18 09:18, Alexey Kardashevskiy wrote: >>> The 567b5b309abe ("vfio/pci: Relax DMA map errors for MMIO regions") added >>> an error message if a passed memory section addr

Re: [Qemu-devel] [PATCH 06/16] translate-all: make l1_map lockless

2018-03-29 Thread Alex Bennée
Emilio G. Cota writes: > Groundwork for supporting parallel TCG generation. > > We never remove entries from the radix tree, so we can use cmpxchg > to implement lockless insertions. > > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > accel/tcg/translate-all.c | 24

Re: [Qemu-devel] [PATCH 07/16] translate-all: remove hole in PageDesc

2018-03-29 Thread Alex Bennée
Emilio G. Cota writes: > Groundwork for supporting parallel TCG generation. > > Move the hole to the end of the struct, so that a u32 > field can be added there without bloating the struct. > > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > accel/tcg/translate-all.c | 2 +- >

Re: [Qemu-devel] [PATCH 08/16] translate-all: work page-by-page in tb_invalidate_phys_range_1

2018-03-29 Thread Alex Bennée
Emilio G. Cota writes: > So that we pass a same-page range to tb_invalidate_phys_page_range, > instead of always passing an end address that could be on a different > page. > > As discussed with Peter Maydell on the list [1], tb_invalidate_phys_page_range > doesn't actually do much with 'end', w

Re: [Qemu-devel] [PATCH 0/4] tpm: More improvements on CRB interface

2018-03-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1522270761-29646-1-git-send-email-stef...@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH 0/4] tpm: More improvements on CRB interface === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PULL 0/2] RISC-V: Important fixes for QEMU 2.12

2018-03-29 Thread Peter Maydell
On 28 March 2018 at 21:40, Michael Clark wrote: > The following changes since commit 043289bef4d9c0d277c45695c676a6cc9fca48a0: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180328' into > staging (2018-03-28 13:30:10 +0100) > > are available in the git repository at: > > https

Re: [Qemu-devel] [PATCH 3/3] sev/i386: fix memory leak in sev_guest_init()

2018-03-29 Thread Greg Kurz
On Thu, 29 Mar 2018 11:24:16 +0200 Cornelia Huck wrote: > On Thu, 29 Mar 2018 11:10:21 +0200 > Greg Kurz wrote: > > > The string returned by object_property_get_str() is dynamically allocated. > > > > Fixes: d8575c6c0242b > > Signed-off-by: Greg Kurz > > --- > > target/i386/sev.c |4 +++-

Re: [Qemu-devel] [PATCH 2/3] hw/s390x: fix memory leak in s390_init_ipl_dev()

2018-03-29 Thread Cornelia Huck
On Thu, 29 Mar 2018 11:39:41 +0200 Greg Kurz wrote: > On Thu, 29 Mar 2018 11:27:21 +0200 > Igor Mammedov wrote: > > > On Thu, 29 Mar 2018 11:10:06 +0200 > > Greg Kurz wrote: > > > > > The string returned by object_property_get_str() is dynamically allocated. > > > > > > Fixes: 3c4e9baacf4d

Re: [Qemu-devel] [PATCH 2/4] tpm: CRB: Reset Granted flag when relinquishing locality

2018-03-29 Thread Marc-André Lureau
On Wed, Mar 28, 2018 at 10:59 PM, Stefan Berger wrote: > Reset the Granted flag when relinquishing a locality. > > Signed-off-by: Stefan Berger Makes sense. I tried to avoid looking at locality management so far, but I guess a minimum is necessary. I suppose no locality will be granted in this c

Re: [Qemu-devel] [PATCH 1/4] tpm: CRB: set the Idle flag by default

2018-03-29 Thread Marc-André Lureau
On Wed, Mar 28, 2018 at 10:59 PM, Stefan Berger wrote: > Signed-off-by: Stefan Berger > --- This is also the default state according to the spec. Reviewed-by: Marc-André Lureau > hw/tpm/tpm_crb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c >

Re: [Qemu-devel] [PATCH 3/4] tpm: CRB: Enforce locality is requested before processing buffer

2018-03-29 Thread Marc-André Lureau
On Wed, Mar 28, 2018 at 10:59 PM, Stefan Berger wrote: > Section 5.5.3.2.2 of the CRB specs states that use of the TPM > through the localty control method must first be requested, > otherwise TPM commands will be dropped. This patch makes sure > that the current locality is the active locality an

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR

2018-03-29 Thread Peter Maydell
On 23 March 2018 at 12:08, Peter Maydell wrote: > On 21 March 2018 at 08:00, Shannon Zhao wrote: >> On 2018/3/20 19:54, Peter Maydell wrote: >>> Can you still successfully migrate a VM from a QEMU version >>> without this bugfix to one with the bugfix ? >>> >> I've tested this case. I can migrate

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: Increase virtio timeout to 30 seconds

2018-03-29 Thread Cornelia Huck
On Thu, 29 Mar 2018 12:03:42 +0200 Christian Borntraeger wrote: > On 03/29/2018 11:37 AM, Thomas Huth wrote: > > The current timeout is set to only three seconds - and considering that > > vring_wait_reply() or rather get_second() is not doing any rounding, > > the real timeout is likely rather 2

[Qemu-devel] [RFC PATCH 2/8] qcow2: Implement bdrv_co_map_range

2018-03-29 Thread Fam Zheng
Extract the common code from qcow2_co_block_status, then use it to implement qcow2_co_map_range. The major difference is the allocation logic, enabled by BDRV_REQ_ALLOCATE. Signed-off-by: Fam Zheng --- block/qcow2.c | 103 +- 1 file changed

[Qemu-devel] [RFC PATCH 1/8] block: Introduce bdrv_co_map_range API

2018-03-29 Thread Fam Zheng
A little similar to bdrv_co_block_status but with the capability to do allocation depending on the BDRV_REQ_ALLOCATE flag, this API is the building block needed by copy offloading to work for format drivers. The idea is the format drivers return "where" to copy from/to in its underlying "file", th

[Qemu-devel] [RFC PATCH 3/8] block: Introduce bdrv_co_copy_range

2018-03-29 Thread Fam Zheng
This tries to do offloaded data copying in the same procotol (but possibly a different BDS), or fall back to a bounce buffer if not supported. Signed-off-by: Fam Zheng --- block/io.c| 148 ++ include/block/block.h | 4 ++ include/

[Qemu-devel] [RFC PATCH 0/8] qemu-img convert with copy offloading

2018-03-29 Thread Fam Zheng
[Posting a preview RFC for the general idea discussion and internal API review. Libiscsi support is being worked on in the meantime.] This series introduces block layer API for copy offloading and makes use of it in qemu-img convert. For now we implemented the operation in local file protocol wit

[Qemu-devel] [RFC PATCH 5/8] file-posix: Implement bdrv_co_map_range

2018-03-29 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/file-posix.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/block/file-posix.c b/block/file-posix.c index b13bc89423..4e615d937e 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -1656,6 +1656,17 @@ static int coroutine_fn raw_co_

[Qemu-devel] [RFC PATCH 4/8] file-posix: Implement bdrv_co_copy_range

2018-03-29 Thread Fam Zheng
With copy_file_range(2), we can implement the bdrv_co_copy_range semantics. Signed-off-by: Fam Zheng --- block/file-posix.c | 77 +++-- include/block/raw-aio.h | 10 +-- 2 files changed, 82 insertions(+), 5 deletions(-) diff --git a/block/fil

[Qemu-devel] [RFC PATCH 8/8] qemu-img: Convert with copy offloading

2018-03-29 Thread Fam Zheng
The new blk_co_copy_range interface offers a more efficient way in the case of network based storage. Make use of it to allow faster convert operation. Since copy offloading cannot do zero detection ('-S') and compression (-c), only try it when these options are not used. Signed-off-by: Fam Zheng

[Qemu-devel] [RFC PATCH 6/8] raw: Implement raw_co_map_range

2018-03-29 Thread Fam Zheng
Because raw can be seen as a "passthrough" format, its implementation of bdrv_co_map_range is exactly the same as bdrv_co_block_status. The BDRV_REQ_ALLOCATE flag can be ignored because no metadata update is necessary. Signed-off-by: Fam Zheng --- block/raw-format.c | 9 + 1 file changed

[Qemu-devel] [RFC PATCH 7/8] block-backend: Add blk_co_copy_range

2018-03-29 Thread Fam Zheng
It's a BlockBackend wrapper of bdrv_co_copy_range. Signed-off-by: Fam Zheng --- block/block-backend.c | 8 include/sysemu/block-backend.h | 4 2 files changed, 12 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index 681b240b12..54b0789282 100644

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR

2018-03-29 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 23 March 2018 at 12:08, Peter Maydell wrote: > > On 21 March 2018 at 08:00, Shannon Zhao wrote: > >> On 2018/3/20 19:54, Peter Maydell wrote: > >>> Can you still successfully migrate a VM from a QEMU version > >>> without this bugfix to one w

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: Increase virtio timeout to 30 seconds

2018-03-29 Thread Thomas Huth
On 29.03.2018 12:03, Christian Borntraeger wrote: > > > On 03/29/2018 11:37 AM, Thomas Huth wrote: >> The current timeout is set to only three seconds - and considering that >> vring_wait_reply() or rather get_second() is not doing any rounding, >> the real timeout is likely rather 2 seconds in m

[Qemu-devel] [PATCH for-2.13] s390x: introduce 2.13 compat machine

2018-03-29 Thread Cornelia Huck
Signed-off-by: Cornelia Huck --- Yes, it's that time again :) --- hw/s390x/s390-virtio-ccw.c | 17 - include/hw/compat.h| 3 +++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 864145a7c6..122f31

Re: [Qemu-devel] [PATCH for-2.13] s390x: introduce 2.13 compat machine

2018-03-29 Thread Thomas Huth
On 29.03.2018 13:33, Cornelia Huck wrote: > Signed-off-by: Cornelia Huck > --- > Yes, it's that time again :) Can't we do v3.0 next ;-) ? Anyway: Reviewed-by: Thomas Huth

Re: [Qemu-devel] [PATCH v4 3/9] cli: add -preconfig option

2018-03-29 Thread Igor Mammedov
On Wed, 28 Mar 2018 16:21:48 -0300 Eduardo Habkost wrote: > On Wed, Mar 28, 2018 at 01:48:35PM +0200, Igor Mammedov wrote: > > On Tue, 27 Mar 2018 17:05:41 +0200 > > Igor Mammedov wrote: > > > > > On Fri, 23 Mar 2018 18:25:08 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Mon, Mar 12

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: Increase virtio timeout to 30 seconds

2018-03-29 Thread Christian Borntraeger
On 03/29/2018 11:37 AM, Thomas Huth wrote: > The current timeout is set to only three seconds - and considering that > vring_wait_reply() or rather get_second() is not doing any rounding, > the real timeout is likely rather 2 seconds in most cases. When the > host is really badly loaded and we ru

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/3] exec: fix memory leak in find_max_supported_pagesize()

2018-03-29 Thread Thomas Huth
On 29.03.2018 11:09, Greg Kurz wrote: > The string returned by object_property_get_str() is dynamically allocated. > > Signed-off-by: Greg Kurz > --- > exec.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/exec.c b/exec.c > index c09bd93df31e..02b1efebb7c3 100644 > --- a/exec.c > +

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/3] hw/s390x: fix memory leak in s390_init_ipl_dev()

2018-03-29 Thread Thomas Huth
On 29.03.2018 12:31, Cornelia Huck wrote: > On Thu, 29 Mar 2018 11:39:41 +0200 > Greg Kurz wrote: > >> On Thu, 29 Mar 2018 11:27:21 +0200 >> Igor Mammedov wrote: >> >>> On Thu, 29 Mar 2018 11:10:06 +0200 >>> Greg Kurz wrote: >>> The string returned by object_property_get_str() is dynami

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/3] hw/s390x: fix memory leak in s390_init_ipl_dev()

2018-03-29 Thread Thomas Huth
On 29.03.2018 11:10, Greg Kurz wrote: > The string returned by object_property_get_str() is dynamically allocated. > > Fixes: 3c4e9baacf4d9 > Signed-off-by: Greg Kurz > --- > hw/s390x/s390-virtio-ccw.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/hw/s390x/s390

Re: [Qemu-devel] [qemu-s390x] [PATCH 3/3] sev/i386: fix memory leak in sev_guest_init()

2018-03-29 Thread Thomas Huth
On 29.03.2018 11:24, Cornelia Huck wrote: > On Thu, 29 Mar 2018 11:10:21 +0200 > Greg Kurz wrote: > >> The string returned by object_property_get_str() is dynamically allocated. >> >> Fixes: d8575c6c0242b >> Signed-off-by: Greg Kurz >> --- >> target/i386/sev.c |4 +++- >> 1 file changed, 3

[Qemu-devel] [PATCH for-2.12 v5] iotests: Test abnormally large size in compressed cluster descriptor

2018-03-29 Thread Alberto Garcia
L2 entries for compressed clusters have a field that indicates the number of sectors used to store the data in the image. That's however not the size of the compressed data itself, just the number of sectors where that data is located. The actual data size is usually not a multiple of the sector s

Re: [Qemu-devel] [PATCH 2/3] hw/s390x: fix memory leak in s390_init_ipl_dev()

2018-03-29 Thread Cornelia Huck
On Thu, 29 Mar 2018 11:10:06 +0200 Greg Kurz wrote: > The string returned by object_property_get_str() is dynamically allocated. > > Fixes: 3c4e9baacf4d9 > Signed-off-by: Greg Kurz > --- > hw/s390x/s390-virtio-ccw.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Thanks, queued

Re: [Qemu-devel] [PATCH for-2.12 v2 2/2] i386/hyperv: error out if features requested but unsupported

2018-03-29 Thread Eduardo Habkost
On Thu, Mar 29, 2018 at 12:47:42PM +0300, Roman Kagan wrote: > On Wed, Mar 28, 2018 at 03:53:31PM -0300, Eduardo Habkost wrote: > > On Wed, Mar 28, 2018 at 06:30:24PM +0300, Roman Kagan wrote: > > > In order to guarantee compatibility on migration, QEMU should have > > > complete control over the f

Re: [Qemu-devel] [PATCH v4 5/9] qapi: introduce new cmd option "allowed-in-preconfig"

2018-03-29 Thread Eduardo Habkost
On Thu, Mar 29, 2018 at 11:53:55AM +0200, Igor Mammedov wrote: > On Wed, 28 Mar 2018 16:30:16 -0300 > Eduardo Habkost wrote: > > > On Wed, Mar 28, 2018 at 02:29:57PM +0200, Igor Mammedov wrote: > > > On Fri, 23 Mar 2018 18:28:37 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Mon, Mar 12,

Re: [Qemu-devel] [PATCH 4/4] tests: Tests more flags of the CRB interface

2018-03-29 Thread Marc-André Lureau
On Wed, Mar 28, 2018 at 10:59 PM, Stefan Berger wrote: > Test and modify more flags of the CRB interface. > > Signed-off-by: Stefan Berger > --- Reviewed-by: Marc-André Lureau > tests/tpm-crb-test.c | 74 > ++-- > 1 file changed, 72 insertions

[Qemu-devel] [PATCH] hw/i386: Fix IVHD entry length for AMD IOMMU

2018-03-29 Thread Jan Kiszka
From: Jan Kiszka Counting from the IVHD ID field to the all-devices entry, we have 28 bytes, not 36. Signed-off-by: Jan Kiszka --- hw/i386/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index deb440f286..a0cda71411 1

Re: [Qemu-devel] [PATCH v4 3/9] cli: add -preconfig option

2018-03-29 Thread Igor Mammedov
On Wed, 28 Mar 2018 16:17:32 -0300 Eduardo Habkost wrote: > On Tue, Mar 27, 2018 at 05:05:41PM +0200, Igor Mammedov wrote: > > On Fri, 23 Mar 2018 18:25:08 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Mar 12, 2018 at 02:11:09PM +0100, Igor Mammedov wrote: > > [...] > > > > diff --gi

Re: [Qemu-devel] [PATCH v4 2/9] numa: split out NumaOptions parsing into parse_NumaOptions()

2018-03-29 Thread Igor Mammedov
On Wed, 28 Mar 2018 15:54:28 -0300 Eduardo Habkost wrote: > On Tue, Mar 27, 2018 at 03:08:27PM +0200, Igor Mammedov wrote: > > On Fri, 23 Mar 2018 17:42:18 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Mar 12, 2018 at 02:11:08PM +0100, Igor Mammedov wrote: > > > > it will allow to reus

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: Increase virtio timeout to 30 seconds

2018-03-29 Thread Cornelia Huck
On Thu, 29 Mar 2018 11:37:31 +0200 Thomas Huth wrote: > The current timeout is set to only three seconds - and considering that > vring_wait_reply() or rather get_second() is not doing any rounding, > the real timeout is likely rather 2 seconds in most cases. When the > host is really badly loade

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: Increase virtio timeout to 30 seconds

2018-03-29 Thread Thomas Huth
On 29.03.2018 15:15, Cornelia Huck wrote: > On Thu, 29 Mar 2018 11:37:31 +0200 > Thomas Huth wrote: > >> The current timeout is set to only three seconds - and considering that >> vring_wait_reply() or rather get_second() is not doing any rounding, >> the real timeout is likely rather 2 seconds i

[Qemu-devel] [PULL 0/2] migration queue

2018-03-29 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit 47d3b60858d90ac8a0cc3a72af7f95c96781125a: Merge remote-tracking branch 'remotes/riscv/tags/riscv-qemu-2.12-important-fixes' into staging (2018-03-28 22:13:38 +0100) are available in the Git repository at: git://github.com/

[Qemu-devel] [PULL 2/2] migration: Don't activate block devices if using -S

2018-03-29 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Activating the block devices causes the locks to be taken on the backing file. If we're running with -S and the destination libvirt hasn't started the destination with 'cont', it's expecting the locks are still untaken. Don't activate the block devices if we're no

[Qemu-devel] [PULL 1/2] migration: fix pfd leak

2018-03-29 Thread Dr. David Alan Gilbert (git)
From: Marc-André Lureau Fix leak spotted by ASAN: Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x7fe1abb80a38 in __interceptor_calloc (/lib64/libasan.so.4+0xdea38) #1 0x7fe1aaf1bf75 in g_malloc0 ../glib/gmem.c:124 #2 0x7fe1aaf1c249 in g_malloc0_n ../glib/gmem.c:355

Re: [Qemu-devel] [PATCH v4 for 2.12 0/3] fix bitmaps migration through shared storage

2018-03-29 Thread Max Reitz
On 2018-03-29 10:08, Vladimir Sementsov-Ogievskiy wrote: > 28.03.2018 17:53, Max Reitz wrote: >> On 2018-03-27 12:11, Vladimir Sementsov-Ogievskiy wrote: [...] >>> isn't it because a lot of cat processes? will check, update loop to >>> i=0; while check -qcow2 169; do ((i++)); echo $i OK; killall

Re: [Qemu-devel] [PATCH for-2.12 v4] iotests: Test abnormally large size in compressed cluster descriptor

2018-03-29 Thread Max Reitz
On 2018-03-28 19:58, Eric Blake wrote: > On 03/28/2018 12:34 PM, Max Reitz wrote: [...] >> The OFLAG_COPIED repair looks a bit interesting, but, er, well. >> >> Max >> >> (Since a compressed cluster does not correspond 1:1 to a host cluster, >> you cannot say that a compressed cluster has a refco

[Qemu-devel] linux-user: missing synchronization in CPU object realization

2018-03-29 Thread Max Filippov
Hello, I'm running xtensa linux-user application that rapidly creates a lot of threads and I observe the following assertion failure: (process:26953): GLib-CRITICAL **: g_hash_table_iter_next: assertion 'ri->version == ri->hash_table->version' failed ** ERROR:qemu/qom/object.c:1663:object_get_can

[Qemu-devel] [PATCH v3 0/4] RFC: simplify qobject refcount

2018-03-29 Thread Marc-André Lureau
Hi, This series aims to get rid of the distinction between QObject, that must use qobject_incref/qobject_decref and its various derived types that have to use QINCREF/QDECREF. Instead, replace it with qobject_ref/qobject_unref for all types. v3: after v2 review with Eric and Paolo - fix clang ubs

Re: [Qemu-devel] [PATCH for-2.12 v4] iotests: Test abnormally large size in compressed cluster descriptor

2018-03-29 Thread Max Reitz
On 2018-03-29 11:39, Alberto Garcia wrote: > On Wed 28 Mar 2018 07:34:15 PM CEST, Max Reitz wrote: >>> diff --git a/tests/qemu-iotests/122 b/tests/qemu-iotests/122 >>> index 45b359c2ba..5b9593016c 100755 >>> --- a/tests/qemu-iotests/122 >>> +++ b/tests/qemu-iotests/122 >> >> Not sure if 122 is the

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: Increase virtio timeout to 30 seconds

2018-03-29 Thread Cornelia Huck
On Thu, 29 Mar 2018 11:37:31 +0200 Thomas Huth wrote: > The current timeout is set to only three seconds - and considering that > vring_wait_reply() or rather get_second() is not doing any rounding, > the real timeout is likely rather 2 seconds in most cases. When the > host is really badly loade

Re: [Qemu-devel] [PATCH for-2.12 v5] iotests: Test abnormally large size in compressed cluster descriptor

2018-03-29 Thread Eric Blake
On 03/29/2018 07:07 AM, Alberto Garcia wrote: L2 entries for compressed clusters have a field that indicates the number of sectors used to store the data in the image. That's however not the size of the compressed data itself, just the number of sectors where that data is located. The actual dat

Re: [Qemu-devel] [PATCH qemu] vfio: Print address space address when cannot map MMIO for DMA

2018-03-29 Thread Auger Eric
Hi Alex, On 29/03/18 00:13, Alex Williamson wrote: > On Wed, 28 Mar 2018 23:03:23 +0200 > Auger Eric wrote: > >> Hi Alexey, Alex, >> On 22/03/18 09:18, Alexey Kardashevskiy wrote: >>> The 567b5b309abe ("vfio/pci: Relax DMA map errors for MMIO regions") added >>> an error message if a passed memo

Re: [Qemu-devel] [PATCH 10/16] translate-all: use per-page locking in !user-mode

2018-03-29 Thread Alex Bennée
Emilio G. Cota writes: > Groundwork for supporting parallel TCG generation. > > Instead of using a global lock (tb_lock) to protect changes > to pages, use fine-grained, per-page locks in !user-mode. > User-mode stays with mmap_lock. > > Sometimes changes need to happen atomically on more than o

Re: [Qemu-devel] [PATCH 11/16] translate-all: add page_collection assertions

2018-03-29 Thread Alex Bennée
Emilio G. Cota writes: > The appended adds assertions to make sure we do not longjmp with page > locks held. Some notes: > > - user-mode has nothing to check, since page_locks are !user-mode only. > > - The checks only apply to page collections, since these have relatively > complex callers. >

Re: [Qemu-devel] [PATCH v4 for 2.12 0/3] fix bitmaps migration through shared storage

2018-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2018 17:03, Max Reitz wrote: On 2018-03-29 10:08, Vladimir Sementsov-Ogievskiy wrote: 28.03.2018 17:53, Max Reitz wrote: On 2018-03-27 12:11, Vladimir Sementsov-Ogievskiy wrote: [...] isn't it because a lot of cat processes? will check, update loop to i=0; while check -qcow2 169; do ((

[Qemu-devel] [PATCH] sys_membarrier: fix up include directives

2018-03-29 Thread Bruce Rogers
Our rule right now is to use <> for external headers only. util/sys_membarrier.c violates that. Fix it up. Signed-off-by: Bruce Rogers --- util/sys_membarrier.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/util/sys_membarrier.c b/util/sys_membarrier.c index 8dcb53e63

Re: [Qemu-devel] [PATCH 12/16] translate-all: discard TB when tb_link_page returns an existing matching TB

2018-03-29 Thread Alex Bennée
Emilio G. Cota writes: > Use the recently-gained QHT feature of returning the matching TB if it > already exists. This allows us to get rid of the lookup we perform > right after acquiring tb_lock. > > Suggested-by: Richard Henderson > Signed-off-by: Emilio G. Cota > --- > accel/tcg/cpu-exec.

Re: [Qemu-devel] [PATCH 14/16] cputlb: remove tb_lock from tlb_flush functions

2018-03-29 Thread Alex Bennée
Emilio G. Cota writes: > The acquisition of tb_lock was added when the async tlb_flush > was introduced in e3b9ca810 ("cputlb: introduce tlb_flush_* async work.") > > tb_lock was there to allow us to do memset() on the tb_jmp_cache's. > However, since f3ced3c5928 ("tcg: consistently access cpu->

  1   2   >