On Thu, 29 Mar 2018 11:18:31 +0200
Cornelia Huck <coh...@redhat.com> wrote:
> On Thu, 29 Mar 2018 11:09:46 +0200
> Greg Kurz <gr...@kaod.org> wrote:
>
> > The string returned by object_property_get_str() is dynamically allocated.
> >
> > Signed-off-by: Greg Kurz <gr...@kaod.org>
> > ---
> > exec.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/exec.c b/exec.c
> > index c09bd93df31e..02b1efebb7c3 100644
> > --- a/exec.c
> > +++ b/exec.c
> > @@ -1495,6 +1495,7 @@ static int find_max_supported_pagesize(Object *obj,
> > void *opaque)
> > mem_path = object_property_get_str(obj, "mem-path", NULL);
> > if (mem_path) {
> > long hpsize = qemu_mempath_getpagesize(mem_path);
> > + g_free(mem_path);
> > if (hpsize < *hpsize_min) {
> > *hpsize_min = hpsize;
> > }
> >
>
> Personally, I'd probably do the g_free() at the end of the if
> (mem_path) branch, but this works as well.
>
I usually prefer to free the string as soon as it isn't needed
anymore... matter of taste :)
> Reviewed-by: Cornelia Huck <coh...@redhat.com>
