[Qemu-devel] Should we check arguments for function `from_bcd` and `to_bcd`?

2018-03-22 Thread Su Hang
When I was reading 'qemu/hw/timer/m48t59.c'(Line:328) and run with `make check-qtest-ppc`, I found when write an invalid value 0xc to address 0x1FFF, `from_bcd` return 12 instead of raising an exception(or error). """(qemu/hw/timer/m48t59.c) case 0x1FFF: case 0x07FF: /* year */

[Qemu-devel] [PATCH] scsi-disk: Don't enlarge min_io_size to max_io_size

2018-03-22 Thread Fam Zheng
Some backends report big max_io_sectors. Making min_io_size the same value in this case will make it impossible for guest to align memory, therefore the disk may not be usable at all. Change the default behavior (when min_io_size and opt_io_size are not specified in the command line), do not assum

[Qemu-devel] [Bug 1754542] Re: colo: vm crash with segmentation fault

2018-03-22 Thread 李穗恒
I took a photo when SVM print reset. It seems like kernel panic. I hope this will help. ** Attachment added: "SVM_error.HEIC" https://bugs.launchpad.net/qemu/+bug/1754542/+attachment/5086650/+files/SVM_error.HEIC -- You received this bug notification because you are a member of qemu- devel-

Re: [Qemu-devel] [PATCH v2] vmdk: return ERROR when cluster sector is larger than vmdk limitation

2018-03-22 Thread Fam Zheng
On Thu, 03/22 14:24, yuchen...@synology.com wrote: > From: yuchenlin > > VMDK has a hard limitation of extent size, which is due to the size of grain > table entry is 32 bits. It means it can only point to a grain located at > offset = 2^32. To avoid writing the user data beyond limitation and re

Re: [Qemu-devel] [PATCH qemu v7 2/4] vfio/pci: Relax DMA map errors for MMIO regions

2018-03-22 Thread Alexey Kardashevskiy
On 22/3/18 2:29 am, Alex Williamson wrote: > On Mon, 19 Mar 2018 21:49:58 +0100 > Auger Eric wrote: > >> Hi Alexey, >> >> On 09/02/18 08:55, Alexey Kardashevskiy wrote: >>> At the moment if vfio_memory_listener is registered in the system memory >>> address space, it maps/unmaps every RAM memory

Re: [Qemu-devel] [PATCH 0/3] hw/rdma: Fix 32-bit compilation

2018-03-22 Thread Marcel Apfelbaum
Hi Yuval, - Original Message - > From: no-re...@patchew.org > To: "yuval shaia" > Cc: f...@redhat.com, "yuval shaia" , > mar...@redhat.com, ebl...@redhat.com, > qemu-devel@nongnu.org, qemu-triv...@nongnu.org > Sent: Thursday, March 22, 2018 7:07:35 AM > Subject: Re: [Qemu-devel] [PATCH

Re: [Qemu-devel] [PATCH qemu v7 2/4] vfio/pci: Relax DMA map errors for MMIO regions

2018-03-22 Thread Auger Eric
Hi Alexey, On 22/03/18 08:45, Alexey Kardashevskiy wrote: > On 22/3/18 2:29 am, Alex Williamson wrote: >> On Mon, 19 Mar 2018 21:49:58 +0100 >> Auger Eric wrote: >> >>> Hi Alexey, >>> >>> On 09/02/18 08:55, Alexey Kardashevskiy wrote: At the moment if vfio_memory_listener is registered in th

[Qemu-devel] [Bug 1754542] Re: colo: vm crash with segmentation fault

2018-03-22 Thread 李穗恒
SVM error photo ** Attachment removed: "SVM_error.HEIC" https://bugs.launchpad.net/qemu/+bug/1754542/+attachment/5086650/+files/SVM_error.HEIC ** Attachment added: "SVM.err.jpg" https://bugs.launchpad.net/qemu/+bug/1754542/+attachment/5086654/+files/SVM.err.jpg -- You received this bug

Re: [Qemu-devel] [PATCH 1/1] mach-virt: Set VM's SMBIOS system version to mc->desc

2018-03-22 Thread Andrew Jones
On Wed, Mar 21, 2018 at 10:12:16PM -0500, Wei Huang wrote: > Instead of using "1.0" as the system version of SMBIOS, we should use > mc->desc for mach-virt machine type. With this patch, "dmidecode -t 1" > (e.g., "-M virt-2.12,accel=kvm") will show: > > Handle 0x0100, DMI type 1, 27 bytes >

Re: [Qemu-devel] [Qemu-arm] [PATCH for-2.12 2/4] target/arm: Factor out code to calculate FSR for debug exceptions

2018-03-22 Thread Philippe Mathieu-Daudé
Hi Peter, This patch might be split in 2. On 03/20/2018 02:41 PM, Peter Maydell wrote: > When a debug exception is taken to AArch32, it appears as a Prefetch > Abort, and the Instruction Fault Status Register (IFSR) must be set. > The IFSR has two possible formats, depending on whether LPAE is in

Re: [Qemu-devel] [Qemu-arm] [PATCH for-2.12] hw/arm/bcm2836: Use the Cortex-A7 instead of Cortex-A15

2018-03-22 Thread Philippe Mathieu-Daudé
On 03/19/2018 12:02 PM, Peter Maydell wrote: > The BCM2836 uses a Cortex-A7, not a Cortex-A15. Update the device to > use the correct CPU. > https://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2836/QA7_rev3.4.pdf > > When the BCM2836 was introduced (bad5623690b) the Cortex-A7 was not

Re: [Qemu-devel] [PATCH for-2.12 4/4] target/arm: Always set FAR to a known unknown value for debug exceptions

2018-03-22 Thread Philippe Mathieu-Daudé
On 03/20/2018 02:41 PM, Peter Maydell wrote: > For debug exceptions due to breakpoints or the BKPT instruction which > are taken to AArch32, the Fault Address Register is architecturally > UNKNOWN. We were using that as license to simply not set > env->exception.vaddress, but this isn't correct, b

[Qemu-devel] [PATCH qemu] vfio: Print address space address when cannot map MMIO for DMA

2018-03-22 Thread Alexey Kardashevskiy
The 567b5b309abe ("vfio/pci: Relax DMA map errors for MMIO regions") added an error message if a passed memory section address or size is not aligned to the minimal IOMMU page size. However although it checks offset_within_address_space for the alignment, offset_within_region is printed instead whi

Re: [Qemu-devel] [Qemu-arm] [PATCH for-2.12 1/4] target/arm: Honour MDCR_EL2.TDE when routing exceptions due to BKPT/BRK

2018-03-22 Thread Philippe Mathieu-Daudé
Hi Peter, On 03/20/2018 02:41 PM, Peter Maydell wrote: > The MDCR_EL2.TDE bit allows the exception level targeted by debug > exceptions to be set to EL2 for code executing at EL0. We handle > this in the arm_debug_target_el() function, but this is only used for > hardware breakpoint and watchpoin

Re: [Qemu-devel] [Qemu-arm] [PATCH for-2.12 3/4] target/arm: Set FSR for BKPT, BRK when raising exception

2018-03-22 Thread Philippe Mathieu-Daudé
On 03/20/2018 10:41 AM, Peter Maydell wrote: > Now that we have a helper function specifically for the BRK and > BKPT instructions, we can set the exception.fsr there rather > than in arm_cpu_do_interrupt_aarch32(). This allows us to > use our new arm_debug_exception_fsr() helper. > > In particula

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/3] hw/rdma: Change host_virt to void *

2018-03-22 Thread Philippe Mathieu-Daudé
On 03/21/2018 06:10 PM, Yuval Shaia wrote: > To avoid compilation warnings on 32-bit machines: > rdma_backend.c: In function 'rdma_backend_create_mr': > rdma_backend.c:409:37: error: cast to pointer from integer of different > size [-Werror=int-to-pointer-cast] > mr->ibmr = ibv_reg_mr(pd->ibp

Re: [Qemu-devel] [PATCH 2/3] hw/rdma: Use correct print format in CHK_ATTR macro

2018-03-22 Thread Philippe Mathieu-Daudé
On 03/21/2018 06:10 PM, Yuval Shaia wrote: > Macro should not cast the given variable to u64 instead it should use > the supplied format argument (fmt). > > Reported-by: Eric Blake > Signed-off-by: Yuval Shaia Reviewed-by: Philippe Mathieu-Daudé > --- > hw/rdma/rdma_backend.c | 4 ++-- > 1 f

Re: [Qemu-devel] Bug AioContext polling is not implemented on Windows with qemu-system-ppc.exe

2018-03-22 Thread Howard Spoelstra
> Hi, Howard, > > Thanks for reporting the problem. Could you try applying below patch > to your rc0 tree and rebuild QEMU, to see whether it fixes your problem? > > - > diff --git a/iothread.c b/iothread.c > index 1b3463cb00..9f52270ae1 100644 > --- a/iothread.c > +++

Re: [Qemu-devel] [Qemu-trivial] [PATCH 3/3] hw/rdma: Fix 32-bit compilation

2018-03-22 Thread Philippe Mathieu-Daudé
Hi Yuval, On 03/21/2018 06:10 PM, Yuval Shaia wrote: > Use the correct printf formats, so that a 32-bit compile doesn't spit > out lots of warnings about %lx being incompatible with uint64_t. > > Suggested-by: Eric Blake > Signed-off-by: Yuval Shaia > --- > hw/rdma/rdma_backend.c| 21 +

Re: [Qemu-devel] [PATCH] tests: Fix ubuntu.i386 image initialization

2018-03-22 Thread Philippe Mathieu-Daudé
On 03/22/2018 12:47 AM, Fam Zheng wrote: > The apt-get commands we run through ssh expect certain features of the > tty, and refuses to work if /dev/null is used. It is ugly, but easy to > satisfy. > > Actually, there is no reason to hide the output. It just makes things > harder to diagnose. We c

Re: [Qemu-devel] [PATCH 18/19] mac_newworld: remove pics IRQ array and wire up macio to OpenPIC directly

2018-03-22 Thread Philippe Mathieu-Daudé
On 03/06/2018 05:31 PM, Mark Cave-Ayland wrote: > Introduce constants for the pre-defined New World IRQs to help keep things > readable. > > Signed-off-by: Mark Cave-Ayland > --- > hw/ppc/mac.h | 8 > hw/ppc/mac_newworld.c | 29 +++-- > 2 files changed,

Re: [Qemu-devel] Bug AioContext polling is not implemented on Windows with qemu-system-ppc.exe

2018-03-22 Thread Peter Xu
On Thu, Mar 22, 2018 at 09:28:34AM +0100, Howard Spoelstra wrote: > > Hi, Howard, > > > > Thanks for reporting the problem. Could you try applying below patch > > to your rc0 tree and rebuild QEMU, to see whether it fixes your problem? > > > > - > > diff --git a/iothrea

Re: [Qemu-devel] [PATCH v1 00/14] fp-test + hostfloat

2018-03-22 Thread Alex Bennée
Emilio G. Cota writes: > For performance numbers see the last patch. Just another random data point as we've been using himeno for our SVE wor: Master: 8:05:45 [alex@zen:~/l/q/qemu.git] master ± ./aarch64-linux-user/qemu-aarch64 sve.demo/himeno-v80 mimax = 129 mjmax = 65 mkmax = 65 imax =

[Qemu-devel] [PATCH for-2.12] iothread: fix breakage on windows

2018-03-22 Thread Peter Xu
OOB can enable iothread for parsing even on Windows. We need some tunes to enable that on Windows otherwise it'll break Windows users. This patch fixes the breakage on Windows with qemu-system-ppc.exe. Reported-by: Howard Spoelstra Tested-by: Howard Spoelstra Suggested-by: Paolo Bonzini Signe

Re: [Qemu-devel] [PATCH 4/4] membarrier: add --enable-membarrier

2018-03-22 Thread Paolo Bonzini
On 22/03/2018 02:29, Emilio G. Cota wrote: > It is indeed hard to see a large impact on performance given the > large size of our critical sections. But hey, rcu_read_unlock > goes down from 0.24% to 0.08% of execution time when booting > aarch64 linux! I expect something a little better than 0.15

Re: [Qemu-devel] [PATCH 17/19] uninorth: create new uninorth device

2018-03-22 Thread Philippe Mathieu-Daudé
Hi Mark, On 03/21/2018 12:29 AM, David Gibson wrote: > On Tue, Mar 06, 2018 at 08:31:01PM +, Mark Cave-Ayland wrote: >> Commit 4e46dcdbd3 "PPC: Newworld: Add uninorth token register" added a TODO >> which was to convert the uninorth registers hack to a proper device. Move >> these registers to

Re: [Qemu-devel] [PATCH v5.2 for 2.13 1/4] tpm: extend TPM emulator with state migration support

2018-03-22 Thread Dr. David Alan Gilbert
* Stefan Berger (stef...@linux.vnet.ibm.com) wrote: > On 03/21/2018 01:14 PM, Dr. David Alan Gilbert wrote: > > * Stefan Berger (stef...@linux.vnet.ibm.com) wrote: > > > + > > > +if (totlength > 0) { > > > +tsb->buffer = g_try_malloc(totlength); > > > +if (!tsb->buffer) { > > >

Re: [Qemu-devel] [PATCH] scsi-disk: Don't enlarge min_io_size to max_io_size

2018-03-22 Thread Paolo Bonzini
On 22/03/2018 08:38, Fam Zheng wrote: > Some backends report big max_io_sectors. Making min_io_size the same > value in this case will make it impossible for guest to align memory, > therefore the disk may not be usable at all. > > Change the default behavior (when min_io_size and opt_io_size are

Re: [Qemu-devel] Should we check arguments for function `from_bcd` and `to_bcd`?

2018-03-22 Thread Paolo Bonzini
On 22/03/2018 08:03, Su Hang wrote: > When I was reading 'qemu/hw/timer/m48t59.c'(Line:328) and run with > `make check-qtest-ppc`, > I found when write an invalid value 0xc to address 0x1FFF, > `from_bcd` return 12 instead of raising an exception(or error). Each device probably has a different beh

Re: [Qemu-devel] [PATCH for-2.12] iothread: fix breakage on windows

2018-03-22 Thread Paolo Bonzini
On 22/03/2018 09:56, Peter Xu wrote: > OOB can enable iothread for parsing even on Windows. We need some tunes > to enable that on Windows otherwise it'll break Windows users. This > patch fixes the breakage on Windows with qemu-system-ppc.exe. > > Reported-by: Howard Spoelstra > Tested-by: How

Re: [Qemu-devel] Bug AioContext polling is not implemented on Windows with qemu-system-ppc.exe

2018-03-22 Thread Paolo Bonzini
On 22/03/2018 06:19, Peter Xu wrote: > +#ifdef CONFIG_LINUX > /* Benchmark results from 2016 on NVMe SSD drives show max polling times > around > * 16-32 microseconds yield IOPS improvements for both iodepth=1 and > iodepth=32 > * workloads. > */ > #define IOTHREAD_POLL_MAX_NS_DEFAULT 327

Re: [Qemu-devel] [PATCH v3 43/49] qapi: make s390 commands depend on TARGET_S390X

2018-03-22 Thread Marc-André Lureau
Hi On Thu, Mar 22, 2018 at 6:42 AM, Thomas Huth wrote: > On 21.03.2018 12:52, Marc-André Lureau wrote: >> Signed-off-by: Marc-André Lureau >> Acked-by: Cornelia Huck >> --- >> qapi/misc.json | 101 -- >> qapi/target.json| 106

Re: [Qemu-devel] [Qemu-trivial] [PATCH 3/3] hw/rdma: Fix 32-bit compilation

2018-03-22 Thread Yuval Shaia
> > > > So many pr_err/pr_dbg() changes, you could have take the opportunity to > replace with updated error reporting API and tracepoint. Let's leave something for next time :) > > With %zu: > Reviewed-by: Philippe Mathieu-Daudé Thanks.

[Qemu-devel] [PATCH v2 for-2.12 0/3] hw/rdma: Fix 32-bit compilation

2018-03-22 Thread Yuval Shaia
Hi all, Following are three patches which fixes various compilation warnings and errors detected when compiling rdma device in 32bit host. All three patches are based on Eric Blake patch for rdma device. Thanks! Patch #1: Change host_virt to void * Low level IB verbs library accept void * argumen

[Qemu-devel] [PATCH v2 for-2.12 2/3] hw/rdma: Use correct print format in CHK_ATTR macro

2018-03-22 Thread Yuval Shaia
Macro should not cast the given variable to u64 instead it should use the supplied format argument (fmt). Reported-by: Eric Blake Signed-off-by: Yuval Shaia Reviewed-by: Eric Blake Tested-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé --- hw/rdma/rdma_backend.c | 4 ++-- 1 file changed,

[Qemu-devel] [PATCH v2 for-2.12 1/3] hw/rdma: Change host_virt to void *

2018-03-22 Thread Yuval Shaia
To avoid compilation warnings on 32-bit machines: rdma_backend.c: In function 'rdma_backend_create_mr': rdma_backend.c:409:37: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] mr->ibmr = ibv_reg_mr(pd->ibpd, (void *)addr, length, access); Reported-by: Eri

[Qemu-devel] [PATCH v2 for-2.12 3/3] hw/rdma: Fix 32-bit compilation

2018-03-22 Thread Yuval Shaia
Use the correct printf formats, so that a 32-bit compile doesn't spit out lots of warnings about %lx being incompatible with uint64_t. Suggested-by: Eric Blake Signed-off-by: Yuval Shaia Reviewed-by: Eric Blake Tested-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé --- hw/rdma/rdma_backen

Re: [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

2018-03-22 Thread Philippe Mathieu-Daudé
Hi Michael, On 03/20/2018 07:25 PM, Michael Clark wrote: > The following changes since commit f1a63fcfcd92c88be8942b5ae71aef9749a4f135: > > Update version for v2.12.0-rc0 release (2018-03-20 19:04:22 +) > > are available in the git repository at: > > https://github.com/riscv/riscv-qemu.

Re: [Qemu-devel] Bug AioContext polling is not implemented on Windows with qemu-system-ppc.exe

2018-03-22 Thread Peter Xu
On Thu, Mar 22, 2018 at 10:14:19AM +0100, Paolo Bonzini wrote: > On 22/03/2018 06:19, Peter Xu wrote: > > +#ifdef CONFIG_LINUX > > /* Benchmark results from 2016 on NVMe SSD drives show max polling times > > around > > * 16-32 microseconds yield IOPS improvements for both iodepth=1 and > > iod

Re: [Qemu-devel] [PATCH v8 18/23] qmp: support out-of-band (oob) execution

2018-03-22 Thread Marc-André Lureau
Hi On Fri, Mar 9, 2018 at 10:00 AM, Peter Xu wrote: > Having "allow-oob" to true for a command does not mean that this command > will always be run in out-of-band mode. The out-of-band quick path will > only be executed if we specify the extra "run-oob" flag when sending the > QMP request: > >

Re: [Qemu-devel] Should we check arguments for function `from_bcd` and `to_bcd`?

2018-03-22 Thread Su Hang
Thanks for your reply. :-) Su Hang "Paolo Bonzini" wrote: > On 22/03/2018 08:03, Su Hang wrote: > > When I was reading 'qemu/hw/timer/m48t59.c'(Line:328) and run with > > `make check-qtest-ppc`, > > I found when write an invalid value 0xc to address 0x1FFF, > > `from_bcd` return 12 instead of rai

Re: [Qemu-devel] [PULL 12/13] page_unprotect(): handle calls to pages that are PAGE_WRITE

2018-03-22 Thread Laurent Vivier
Le 22/03/2018 à 02:52, Laurent Vivier a écrit : > Le 23/01/2018 à 15:48, Laurent Vivier a écrit : >> From: Peter Maydell >> >> If multiple guest threads in user-mode emulation write to a >> page which QEMU has marked read-only because of cached TCG >> translations, the threads can race in page_unp

Re: [Qemu-devel] [PATCH 1/1] mach-virt: Set VM's SMBIOS system version to mc->desc

2018-03-22 Thread Peter Maydell
On 22 March 2018 at 08:01, Andrew Jones wrote: > I agree we should change the useless 1.0, but shouldn't we use > mc->name instead of mc->desc? mc->name would make it consistent > with pc-piix and q35 and also be a less verbose "version". We'd > get e.g. > > System Information > Manufactu

Re: [Qemu-devel] [Qemu-arm] [PATCH for-2.12 2/4] target/arm: Factor out code to calculate FSR for debug exceptions

2018-03-22 Thread Peter Maydell
On 21 March 2018 at 22:26, Philippe Mathieu-Daudé wrote: > Hi Peter, > > This patch might be split in 2. For a +27-10 patch, it doesn't really seem necessary. > On 03/20/2018 02:41 PM, Peter Maydell wrote: >> When a debug exception is taken to AArch32, it appears as a Prefetch >> Abort, and the

Re: [Qemu-devel] [PATCH for-2.12 4/4] target/arm: Always set FAR to a known unknown value for debug exceptions

2018-03-22 Thread Peter Maydell
On 21 March 2018 at 22:29, Philippe Mathieu-Daudé wrote: > On 03/20/2018 02:41 PM, Peter Maydell wrote: >> For debug exceptions due to breakpoints or the BKPT instruction which >> are taken to AArch32, the Fault Address Register is architecturally >> UNKNOWN. We were using that as license to simp

Re: [Qemu-devel] [PULL 12/13] page_unprotect(): handle calls to pages that are PAGE_WRITE

2018-03-22 Thread Peter Maydell
On 22 March 2018 at 10:36, Laurent Vivier wrote: > Le 22/03/2018 à 02:52, Laurent Vivier a écrit : >> It seems this patch breaks something in linux-user mode emulation for >> m68k (32bit BE) on ppc (32bit BE). >> >> What I have: >> >> ~/chroot$ sudo QEMU_CPU=m68040 chroot m68k/sid/ >> I have n

Re: [Qemu-devel] [PULL 12/13] page_unprotect(): handle calls to pages that are PAGE_WRITE

2018-03-22 Thread Laurent Vivier
Le 22/03/2018 à 12:05, Peter Maydell a écrit : > On 22 March 2018 at 10:36, Laurent Vivier wrote: >> Le 22/03/2018 à 02:52, Laurent Vivier a écrit : >>> It seems this patch breaks something in linux-user mode emulation for >>> m68k (32bit BE) on ppc (32bit BE). >>> >>> What I have: >>> >>> ~/chr

Re: [Qemu-devel] [PATCH 1/1] mach-virt: Set VM's SMBIOS system version to mc->desc

2018-03-22 Thread Daniel P . Berrangé
On Wed, Mar 21, 2018 at 10:12:16PM -0500, Wei Huang wrote: > Instead of using "1.0" as the system version of SMBIOS, we should use > mc->desc for mach-virt machine type. With this patch, "dmidecode -t 1" > (e.g., "-M virt-2.12,accel=kvm") will show: > > Handle 0x0100, DMI type 1, 27 bytes >

Re: [Qemu-devel] [PULL 12/13] page_unprotect(): handle calls to pages that are PAGE_WRITE

2018-03-22 Thread Peter Maydell
On 22 March 2018 at 11:05, Peter Maydell wrote: > On 22 March 2018 at 10:36, Laurent Vivier wrote: >> It goes wrong in this part: >> >> + */ >> +if (is_write && info->si_signo == SIGSEGV && info->si_code == >> SEGV_ACCERR && >> +h2g_valid(address)) { >> >> Because, on ppc, si_code

Re: [Qemu-devel] [PULL 12/13] page_unprotect(): handle calls to pages that are PAGE_WRITE

2018-03-22 Thread Peter Maydell
On 22 March 2018 at 11:07, Laurent Vivier wrote: > Le 22/03/2018 à 12:05, Peter Maydell a écrit : >> On 22 March 2018 at 10:36, Laurent Vivier wrote:re. >>> It goes wrong in this part: >>> >>> + */ >>> +if (is_write && info->si_signo == SIGSEGV && info->si_code == >>> SEGV_ACCERR && >>> +

Re: [Qemu-devel] [PULL 12/13] page_unprotect(): handle calls to pages that are PAGE_WRITE

2018-03-22 Thread Laurent Vivier
Le 22/03/2018 à 12:07, Peter Maydell a écrit : > On 22 March 2018 at 11:05, Peter Maydell wrote: >> On 22 March 2018 at 10:36, Laurent Vivier wrote: >>> It goes wrong in this part: >>> >>> + */ >>> +if (is_write && info->si_signo == SIGSEGV && info->si_code == >>> SEGV_ACCERR && >>> +

[Qemu-devel] [PATCH for-2.12 v3 2/2] iotests: Update 186 after commit ac64273c66ab136c44043259162

2018-03-22 Thread Alberto Garcia
Signed-off-by: Alberto Garcia Cc: Philippe Mathieu-Daudé --- tests/qemu-iotests/186.out | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/186.out b/tests/qemu-iotests/186.out index ec75c0fc60..5020162826 100644 --- a/tests/qemu-iotests/186.out +++ b/tests

[Qemu-devel] [PATCH for-2.12 v3 1/2] iotests: Update 051 and 186 after commit 1454509726719e0933c

2018-03-22 Thread Alberto Garcia
SCSI controllers are no longer created automatically for -drive if=scsi, so this patch updates the tests that relied on that. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake Cc: Thomas Huth --- tests/qemu-iotests/051.pc.out | 20 tests/qemu-iotests/186| 4 --

[Qemu-devel] [PATCH for-2.12 v3 0/2] Update output of some iotests

2018-03-22 Thread Alberto Garcia
Hi, I sent a patch a few days ago correction the output of iotests 051 and 186. I wanted to resend it again but I noticed that 186 needs now more changes due to commit ac64273c66ab136c44043259162, so I'm including those changes too. Regards, Berto Alberto Garcia (2): iotests: Update 051 and 1

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-22 Thread Xiao Guangrong
On 03/21/2018 04:19 PM, Peter Xu wrote: On Fri, Mar 16, 2018 at 04:05:14PM +0800, Xiao Guangrong wrote: Hi David, Thanks for your review. On 03/15/2018 06:25 PM, Dr. David Alan Gilbert wrote: migration/ram.c | 32 Hi, Do you have some performance n

Re: [Qemu-devel] [PATCH 2/8] migration: stop allocating and freeing memory frequently

2018-03-22 Thread Xiao Guangrong
On 03/21/2018 05:06 PM, Peter Xu wrote: On Tue, Mar 13, 2018 at 03:57:33PM +0800, guangrong.x...@gmail.com wrote: From: Xiao Guangrong Current code uses compress2()/uncompress() to compress/decompress memory, these two function manager memory allocation and release internally, that causes hu

Re: [Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration

2018-03-22 Thread 858585 jemmy
On Wed, Mar 21, 2018 at 2:19 AM, Juan Quintela wrote: > Lidong Chen wrote: >> RDMA migration implement save_page function for QEMUFile, but >> ram_control_save_page do not increase bytes_xfer. So when doing >> RDMA migration, it will use whole bandwidth. >> >> Signed-off-by: Lidong Chen > > Revi

Re: [Qemu-devel] [PATCH v8 19/23] qmp: isolate responses into io thread

2018-03-22 Thread Marc-André Lureau
Hi On Fri, Mar 9, 2018 at 10:00 AM, Peter Xu wrote: > For those monitors who have enabled IO thread, we'll offload the > responding procedure into IO thread. The main reason is that chardev is > not thread safe, and we need to do all the read/write IOs in the same > thread. For use_io_thr=true

Re: [Qemu-devel] [PATCH 3/8] migration: support to detect compression and decompression errors

2018-03-22 Thread Xiao Guangrong
On 03/21/2018 06:00 PM, Peter Xu wrote: On Tue, Mar 13, 2018 at 03:57:34PM +0800, guangrong.x...@gmail.com wrote: From: Xiao Guangrong Currently the page being compressed is allowed to be updated by the VM on the source QEMU, correspondingly the destination QEMU just ignores the decompressio

Re: [Qemu-devel] [PULL 0/1] Linux user for 2.12 patches

2018-03-22 Thread Peter Maydell
On 20 March 2018 at 20:43, Laurent Vivier wrote: > The following changes since commit 036793aebfc1dd0ce124fa278d7668d89b5da936: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-03-20 > 12:56:20 +) > > are available in the Git repositor

Re: [Qemu-devel] [PATCH] scsi-disk: Don't enlarge min_io_size to max_io_size

2018-03-22 Thread Daniel Henrique Barboza
Hi, On 03/22/2018 04:38 AM, Fam Zheng wrote: Some backends report big max_io_sectors. Making min_io_size the same value in this case will make it impossible for guest to align memory, therefore the disk may not be usable at all. Change the default behavior (when min_io_size and opt_io_size are

[Qemu-devel] [PATCH for-2.12 v4] iotests: Test abnormally large size in compressed cluster descriptor

2018-03-22 Thread Alberto Garcia
L2 entries for compressed clusters have a field that indicates the number of sectors used to store the data in the image. That's however not the size of the compressed data itself, just the number of sectors where that data is located. The actual data size is usually not a multiple of the sector s

Re: [Qemu-devel] [PATCH for-2.12] hw/intc/arm_gicv3: Fix secure-GIC NS ICC_PMR and ICC_RPR accesses

2018-03-22 Thread Peter Maydell
Ping for code review -- it would be nice to put this bugfix into rc1. thanks -- PMM On 15 March 2018 at 13:34, Peter Maydell wrote: > If the GIC has the security extension support enabled, then a > non-secure access to ICC_PMR must take account of the non-secure > view of interrupt priorities, w

Re: [Qemu-devel] [PATCH] vmdk: return ENOTSUP before offset overflow

2018-03-22 Thread Eric Blake
On 03/21/2018 09:40 PM, yuchenlin--- via Qemu-devel wrote: From: yuchenlin VMDK has a hard limitation of extent size, which is due to the size of grain table entry is 32 bits. It means it can only point to a grain located at offset = 2^32. To prevent offset overflow and record a useless offset

Re: [Qemu-devel] [PATCH v3 2/2] i386/kvm: lower requirements for Hyper-V frequency MSRs exposure

2018-03-22 Thread Roman Kagan
On Wed, Mar 21, 2018 at 05:19:24PM -0300, Eduardo Habkost wrote: > On Wed, Mar 21, 2018 at 07:57:29PM +0300, Roman Kagan wrote: > > On Wed, Mar 21, 2018 at 02:18:54PM +0100, Vitaly Kuznetsov wrote: > > > Roman Kagan writes: > > > > > > > On Tue, Mar 20, 2018 at 06:35:00PM +0100, Vitaly Kuznetsov

Re: [Qemu-devel] [PATCH] tests: Fix ubuntu.i386 image initialization

2018-03-22 Thread Eric Blake
On 03/21/2018 10:47 PM, Fam Zheng wrote: The apt-get commands we run through ssh expect certain features of the tty, and refuses to work if /dev/null is used. It is ugly, but easy to satisfy. Actually, there is no reason to hide the output. It just makes things harder to diagnose. We can always

Re: [Qemu-devel] [PATCH v2] vmdk: return ERROR when cluster sector is larger than vmdk limitation

2018-03-22 Thread Eric Blake
On 03/22/2018 02:41 AM, Fam Zheng wrote: On Thu, 03/22 14:24, yuchen...@synology.com wrote: From: yuchenlin VMDK has a hard limitation of extent size, which is due to the size of grain table entry is 32 bits. It means it can only point to a grain located at offset = 2^32. To avoid writing the

[Qemu-devel] [PATCH v4 0/2] i386/kvm: TSC page clocksource for Hyper-V-on-KVM fixes

2018-03-22 Thread Vitaly Kuznetsov
Changes since v3: - check cpu->hyperv_reenlightenment instead of has_msr_reenlightenment [Eduardo Habkost, Roman Kagan] - expose frequency MSRs only when either INVTSC or Reenlightenment is provided [Paolo Bonzini] (I'm not doing 'hv_frequency' property for now as the discussion around it see

[Qemu-devel] [PATCH v4 2/2] i386/kvm: expose Hyper-V frequency MSRs with reenlightenment

2018-03-22 Thread Vitaly Kuznetsov
We can also expose Hyper-V frequency MSRs when reenlightenment feature is enabled and TSC frequency is known, Hyper-V on KVM will provide stable TSC page clocksources to its guests. Signed-off-by: Vitaly Kuznetsov --- - Expose frequency MSRs only when either INVTSC or Reenlightenment is provide

Re: [Qemu-devel] [PULL v1 0/4] Merge tpm 2018/03/21

2018-03-22 Thread Peter Maydell
On 21 March 2018 at 12:07, Stefan Berger wrote: > This series of patches fixes the initialization and setting of a few > flags of the TPM CRB interface. > > The following changes since commit f1a63fcfcd92c88be8942b5ae71aef9749a4f135: > > Update version for v2.12.0-rc0 release (2018-03-20 19:04:2

[Qemu-devel] [PATCH v4 1/2] i386/kvm: add support for Hyper-V reenlightenment MSRs

2018-03-22 Thread Vitaly Kuznetsov
KVM recently gained support for Hyper-V Reenlightenment MSRs which are required to make KVM-on-Hyper-V enable TSC page clocksource to its guests when INVTSC is not passed to it (and it is not passed by default in Qemu as it effectively blocks migration). Signed-off-by: Vitaly Kuznetsov --- Change

Re: [Qemu-devel] [PATCH for-2.12 v3 2/2] iotests: Update 186 after commit ac64273c66ab136c44043259162

2018-03-22 Thread Eric Blake
On 03/22/2018 06:14 AM, Alberto Garcia wrote: Signed-off-by: Alberto Garcia Cc: Philippe Mathieu-Daudé --- tests/qemu-iotests/186.out | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/186.out b/tests/qemu-iotests/186.out index ec75c0fc60..5020162826 1

Re: [Qemu-devel] [PATCH v3 2/2] i386/kvm: lower requirements for Hyper-V frequency MSRs exposure

2018-03-22 Thread Eduardo Habkost
On Thu, Mar 22, 2018 at 04:00:14PM +0300, Roman Kagan wrote: > On Wed, Mar 21, 2018 at 05:19:24PM -0300, Eduardo Habkost wrote: > > On Wed, Mar 21, 2018 at 07:57:29PM +0300, Roman Kagan wrote: > > > On Wed, Mar 21, 2018 at 02:18:54PM +0100, Vitaly Kuznetsov wrote: > > > > Roman Kagan writes: > > >

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-03-22 Thread Eric Blake
On 03/22/2018 12:00 AM, Peter Xu wrote: Doesn't OOB insist on having an ID field with the command? OOB insists on an id field - but there is the situation that SOME errors occur even before the id field has been encountered (for example, if you send non-JSON, the parser gets all confused - it

[Qemu-devel] [PATCH v3] vmdk: return ERROR when cluster sector is larger than vmdk limitation

2018-03-22 Thread yuchenlin--- via Qemu-devel
From: yuchenlin VMDK has a hard limitation of extent size, which is due to the size of grain table entry is 32 bits. It means it can only point to a grain located at offset = 2^32. To avoid writing the user data beyond limitation and record a useless offset in grain table. We should return ERROR

Re: [Qemu-devel] [PATCH for-2.12 v3 2/2] iotests: Update 186 after commit ac64273c66ab136c44043259162

2018-03-22 Thread Alberto Garcia
On Thu 22 Mar 2018 02:17:23 PM CET, Eric Blake wrote: >> --- a/tests/qemu-iotests/186.out >> +++ b/tests/qemu-iotests/186.out >> @@ -404,7 +404,7 @@ Testing: -drive if=floppy >> QEMU X.Y.Z monitor - type 'help' for more information >> (qemu) info block >> floppy0: [not inserted] >> -Attac

Re: [Qemu-devel] [PATCH 1/1] mach-virt: Set VM's SMBIOS system version to mc->desc

2018-03-22 Thread Wei Huang
On 03/22/2018 05:53 AM, Peter Maydell wrote: > On 22 March 2018 at 08:01, Andrew Jones wrote: >> I agree we should change the useless 1.0, but shouldn't we use >> mc->name instead of mc->desc? mc->name would make it consistent >> with pc-piix and q35 and also be a less verbose "version". We'd >>

Re: [Qemu-devel] [PATCH 1/1] mach-virt: Set VM's SMBIOS system version to mc->desc

2018-03-22 Thread Andrew Jones
On Thu, Mar 22, 2018 at 11:07:12AM +, Daniel P. Berrangé wrote: > On Wed, Mar 21, 2018 at 10:12:16PM -0500, Wei Huang wrote: > > Instead of using "1.0" as the system version of SMBIOS, we should use > > mc->desc for mach-virt machine type. With this patch, "dmidecode -t 1" > > (e.g., "-M virt-2

Re: [Qemu-devel] raw iotest regressions in 2.12.0-rc0

2018-03-22 Thread Peter Xu
On Wed, Mar 21, 2018 at 05:58:48PM -0400, John Snow wrote: > ./check -v -raw > Failures: 109 132 136 148 152 183 > > 3fd2457d18edf5736f713dfe1ada9c87a9badab1 is the first bad commit > commit 3fd2457d18edf5736f713dfe1ada9c87a9badab1 > Author: Peter Xu > Date: Fri Mar 9 17:00:03 2018 +0800 > >

Re: [Qemu-devel] [PATCH for-2.12 v3 2/2] iotests: Update 186 after commit ac64273c66ab136c44043259162

2018-03-22 Thread Eric Blake
On 03/22/2018 08:42 AM, Alberto Garcia wrote: On Thu 22 Mar 2018 02:17:23 PM CET, Eric Blake wrote: --- a/tests/qemu-iotests/186.out +++ b/tests/qemu-iotests/186.out @@ -404,7 +404,7 @@ Testing: -drive if=floppy QEMU X.Y.Z monitor - type 'help' for more information (qemu) info block flo

Re: [Qemu-devel] [PATCH 1/1] mach-virt: Set VM's SMBIOS system version to mc->desc

2018-03-22 Thread Daniel P . Berrangé
On Thu, Mar 22, 2018 at 02:49:35PM +0100, Andrew Jones wrote: > On Thu, Mar 22, 2018 at 11:07:12AM +, Daniel P. Berrangé wrote: > > On Wed, Mar 21, 2018 at 10:12:16PM -0500, Wei Huang wrote: > > > Instead of using "1.0" as the system version of SMBIOS, we should use > > > mc->desc for mach-virt

Re: [Qemu-devel] [PATCH v3 2/2] i386/kvm: lower requirements for Hyper-V frequency MSRs exposure

2018-03-22 Thread Roman Kagan
On Thu, Mar 22, 2018 at 10:22:18AM -0300, Eduardo Habkost wrote: > On Thu, Mar 22, 2018 at 04:00:14PM +0300, Roman Kagan wrote: > > On Wed, Mar 21, 2018 at 05:19:24PM -0300, Eduardo Habkost wrote: > > > On Wed, Mar 21, 2018 at 07:57:29PM +0300, Roman Kagan wrote: > > > > On Wed, Mar 21, 2018 at 02:

Re: [Qemu-devel] [PULL 0/2] Dump patches

2018-03-22 Thread Peter Maydell
On 21 March 2018 at 14:37, Marc-André Lureau wrote: > The following changes since commit f1a63fcfcd92c88be8942b5ae71aef9749a4f135: > > Update version for v2.12.0-rc0 release (2018-03-20 19:04:22 +) > > are available in the Git repository at: > > https://github.com/elmarco/qemu.git tags/dum

Re: [Qemu-devel] [PATCH for-2.12] hw/intc/arm_gicv3: Fix secure-GIC NS ICC_PMR and ICC_RPR accesses

2018-03-22 Thread Andrew Jones
On Thu, Mar 15, 2018 at 01:34:41PM +, Peter Maydell wrote: > If the GIC has the security extension support enabled, then a > non-secure access to ICC_PMR must take account of the non-secure > view of interrupt priorities, where real priorities 0..0x7f > are secure-only and not visible to the no

Re: [Qemu-devel] [PATCH 1/4] nbd/server: refactor nbd_negotiate_meta_query for several namespaces

2018-03-22 Thread Vladimir Sementsov-Ogievskiy
21.03.2018 17:56, Eric Blake wrote: [adding NBD list] On 03/21/2018 07:19 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy ---   nbd/server.c | 60 +++-   1 file changed, 43 insertions(+), 17 deletions(

[Qemu-devel] [PATCH for-2.12 v4 0/2] Update output of some iotests

2018-03-22 Thread Alberto Garcia
Hi, I sent a patch a few days ago correction the output of iotests 051 and 186. I wanted to resend it again but I noticed that 186 needs now more changes due to commit ac64273c66ab136c44043259162, so I'm including those changes too. Regards, Berto v4: Filter 'Attached to:' lines [Eric] Alberto

[Qemu-devel] [PATCH for-2.12 v4 1/2] iotests: Update 051 and 186 after commit 1454509726719e0933c

2018-03-22 Thread Alberto Garcia
SCSI controllers are no longer created automatically for -drive if=scsi, so this patch updates the tests that relied on that. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake Cc: Thomas Huth --- tests/qemu-iotests/051.pc.out | 20 tests/qemu-iotests/186| 4 --

[Qemu-devel] [PATCH for-2.12 v4 2/2] iotests: Update 186 after commit ac64273c66ab136c44043259162

2018-03-22 Thread Alberto Garcia
Commit ac64273c66ab136c44 modified the output of iotest 186, changing the QOM path of floppy drives from /machine/unattached/device[17] to /machine/unattached/device[13]. Instead of updating the test output to reflect this change, this patch adds a new filter that hides all QOM paths from the 'Att

Re: [Qemu-devel] [PATCH v2 0/6] Extend vhost-user to support VFIO based accelerators

2018-03-22 Thread Michael S. Tsirkin
On Mon, Mar 19, 2018 at 03:15:31PM +0800, Tiwei Bie wrote: > This patch set does some small extensions to vhost-user protocol > to support VFIO based accelerators, and makes it possible to get > the similar performance of VFIO based PCI passthru while keeping > the virtio device emulation in QEMU.

Re: [Qemu-devel] [PATCH v2 3/6] virtio: support adding sub-regions for notify region

2018-03-22 Thread Michael S. Tsirkin
On Mon, Mar 19, 2018 at 03:15:34PM +0800, Tiwei Bie wrote: > Provide APIs to support querying whether the page-per-vq > is enabled and adding sub-regions for notify region. > > Signed-off-by: Tiwei Bie > --- > Makefile.target| 4 > hw/virtio/virtio-pci.c | 48 > +++

Re: [Qemu-devel] [PATCH v1 08/14] hostfloat: support float32/64 addition and subtraction

2018-03-22 Thread Emilio G. Cota
On Thu, Mar 22, 2018 at 14:41:05 +0800, Richard Henderson wrote: > On 03/22/2018 01:57 PM, Emilio G. Cota wrote: > >> Is there any especially good reason you want to not put this code into the > >> normal softfloat function? Does it really many any measurable difference > >> at > >> all to force

[Qemu-devel] ping Re: [PATCH v5 0/3] target/arm: Add a dynamic XML-description of the cp-registers to GDB

2018-03-22 Thread Abdallah Bouassida
ping http://patchwork.ozlabs.org/project/qemu-devel/list/?series=33714

Re: [Qemu-devel] [PATCH v1 08/14] hostfloat: support float32/64 addition and subtraction

2018-03-22 Thread Laurent Vivier
Le 22/03/2018 à 16:08, Emilio G. Cota a écrit : > On Thu, Mar 22, 2018 at 14:41:05 +0800, Richard Henderson wrote: >> On 03/22/2018 01:57 PM, Emilio G. Cota wrote: Is there any especially good reason you want to not put this code into the normal softfloat function? Does it really many an

Re: [Qemu-devel] ping Re: [PATCH v5 0/3] target/arm: Add a dynamic XML-description of the cp-registers to GDB

2018-03-22 Thread Peter Maydell
On 22 March 2018 at 15:08, Abdallah Bouassida wrote: > ping > http://patchwork.ozlabs.org/project/qemu-devel/list/?series=33714 Hi. This patchset is on my to-review queue, but it may take me a little while to get back to it because we're currently in freeze for the 2.12 release and so things that

Re: [Qemu-devel] [PATCH v2 2/6] vhost-user: introduce shared vhost-user state

2018-03-22 Thread Michael S. Tsirkin
On Mon, Mar 19, 2018 at 03:15:33PM +0800, Tiwei Bie wrote: > @@ -22,7 +23,7 @@ > > typedef struct VhostUserState { > NetClientState nc; > -CharBackend chr; /* only queue index 0 */ > +VhostUser vhost_user; /* only queue index 0 */ > VHostNetState *vhost_net; > guint watch;

Re: [Qemu-devel] [PATCH v2 5/6] vfio: remove DPRINTF() definition from vfio-common.h

2018-03-22 Thread Michael S. Tsirkin
On Mon, Mar 19, 2018 at 03:15:36PM +0800, Tiwei Bie wrote: > This macro isn't used by any VFIO code. And its name is > too generic. The vfio-common.h (in include/hw/vfio) can > be included by other modules in QEMU. It can introduce > conflicts. > > Signed-off-by: Tiwei Bie This one can go ahead

Re: [Qemu-devel] [PATCH 3/4] nbd/server: implement dirty bitmap export

2018-03-22 Thread Vladimir Sementsov-Ogievskiy
21.03.2018 19:57, Eric Blake wrote: On 03/21/2018 07:19 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy Rather sparse on the details in the commit message; I had to read the patch to even learn what the new namespace is. oh, yes, sorry :( @@ -92,6 +101

Re: [Qemu-devel] [PATCH v1 00/14] fp-test + hostfloat

2018-03-22 Thread Emilio G. Cota
On Thu, Mar 22, 2018 at 08:56:36 +, Alex Bennée wrote: > > Emilio G. Cota writes: > > > > For performance numbers see the last patch. > > Just another random data point as we've been using himeno for our SVE > wor: > > Master: > > 8:05:45 [alex@zen:~/l/q/qemu.git] master ± ./aarch64-lin

[Qemu-devel] [PATCH 2/3] coroutine: avoid co_queue_wakeup recursion

2018-03-22 Thread Stefan Hajnoczi
qemu_aio_coroutine_enter() is (indirectly) called recursively when processing co_queue_wakeup. This can lead to stack exhaustion. This patch rewrites co_queue_wakeup in an iterative fashion (instead of recursive) with bounded memory usage to prevent stack exhaustion. qemu_co_queue_run_restart()

[Qemu-devel] [PATCH 0/3] coroutine: avoid co_queue_wakeup recursion

2018-03-22 Thread Stefan Hajnoczi
co_queue_wakeup is currently implemented in a recursive fashion. Pathological patterns of aio_co_enter() between coroutines can cause stack exhaustion. This patch series implements co_queue_wakeup iteratively and avoids stack exhaustion. This issue was originally reported with qemu-img convert b

  1   2   >