Hi Yuval, ----- Original Message ----- > From: no-re...@patchew.org > To: "yuval shaia" <yuval.sh...@oracle.com> > Cc: f...@redhat.com, "yuval shaia" <yuval.sh...@oracle.com>, > mar...@redhat.com, ebl...@redhat.com, > qemu-devel@nongnu.org, qemu-triv...@nongnu.org > Sent: Thursday, March 22, 2018 7:07:35 AM > Subject: Re: [Qemu-devel] [PATCH 0/3] hw/rdma: Fix 32-bit compilation > > Hi, > > This series seems to have some coding style problems. See output below for > more information: >
[...] > === OUTPUT BEGIN === > Checking PATCH 1/3: hw/rdma: Change host_virt to void *... > Checking PATCH 2/3: hw/rdma: Use correct print format in CHK_ATTR macro... > Checking PATCH 3/3: hw/rdma: Fix 32-bit compilation... > WARNING: line over 80 characters > #40: FILE: hw/rdma/rdma_backend.c:180: > + pr_dbg("ibv_create_ah failed for gid <0x%" PRIx64 ", 0x%" PRIx64 > ">\n", > > ERROR: space prohibited before that close parenthesis ')' > #78: FILE: hw/rdma/rdma_backend.c:673: > + CHK_ATTR(dev_attr, backend_dev->dev_attr, max_mr_size, "%" PRId64 ); > > WARNING: line over 80 characters > #244: FILE: hw/rdma/vmw/pvrdma_main.c:345: > + pr_err("Error trying to set REG value, addr=0x%" PRIx64 ", val=0x%" > PRIx64 "\n", > > total: 1 errors, 2 warnings, 248 lines checked > Can you please fix and resend? Thanks, Marcel > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > === OUTPUT END === > > Test command exited with code: 1 > > > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-de...@freelists.org