Re: [Qemu-devel] Using new TCG Vector infrastructure in PowerPC

2018-03-16 Thread Richard Henderson
On 03/16/2018 12:08 PM, Nikunj A Dadhania wrote: > @@ -1078,8 +1079,8 @@ struct CPUPPCState { > /* Altivec registers */ > ppc_avr_t avr[32]; > uint32_t vscr; > -/* VSX registers */ > -uint64_t vsr[32]; > +/* 32 (128bit)- VSX registers */ > +ppc_avr_t vsr[32]; Another

Re: [Qemu-devel] [PATCH v2] scripts/checkpatch.pl: Bug fix

2018-03-16 Thread Fam Zheng
On Fri, 03/16 14:31, Su Hang wrote: > Because I generate my first patch on master, it should work. Nope. "git am" doesn't know to resolve the conflict automatically despite it being straightforward, unfortunately: http://patchew.org/QEMU/1521169105-32041-1-git-send-email-suhan...@mails.ucas.ac.cn

Re: [Qemu-devel] [PATCH v2] scripts/checkpatch.pl: Bug fix

2018-03-16 Thread Su Hang
Thanks for your reply! I'm glad to understand where problem lies. Su Hang > -Original Messages- > From: "Fam Zheng" > Sent Time: 2018-03-16 15:08:19 (Friday) > To: "Su Hang" > Cc: peter.mayd...@linaro.org, vsement...@virtuozzo.com, qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATC

[Qemu-devel] [PATCH v2] Add udmabuf misc device

2018-03-16 Thread Gerd Hoffmann
A driver to let userspace turn iovecs into dma-bufs. Use case: Allows qemu create dmabufs for the vga framebuffer or virtio-gpu ressources. Then they can be passed around to display those guest things on the host. To spice client for classic full framebuffer display, and hopefully some day to w

Re: [Qemu-devel] SSD virtio-scsi passthrough

2018-03-16 Thread Fam Zheng
On Mon, Mar 12, 2018 at 4:16 PM, Nitin Gupta wrote: > Hi Stefan > > Thanks for your response , i tried the the command provided by you and it > did not work as well > somehow i find that after changing the controller to LSI in qemu command > it started working , please find command below > > -d

Re: [Qemu-devel] [PATCH v2] Add udmabuf misc device

2018-03-16 Thread Greg KH
On Fri, Mar 16, 2018 at 08:46:49AM +0100, Gerd Hoffmann wrote: > --- /dev/null > +++ b/drivers/dma-buf/udmabuf.c > @@ -0,0 +1,261 @@ > +/* > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * publish

Re: [Qemu-devel] [PATCH v2] Add udmabuf misc device

2018-03-16 Thread Greg KH
On Fri, Mar 16, 2018 at 08:46:49AM +0100, Gerd Hoffmann wrote: > --- /dev/null > +++ b/tools/testing/selftests/drivers/dma-buf/udmabuf.c > @@ -0,0 +1,69 @@ > +#include > +#include > +#include > +#include > +#include > +#include > +#include No license text at all? Come on, I already made on

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e., -cpu ,ap=on), then the expectation is that the AP bus running in the guest will initialize; however, if the AP instructions are not being interpreted by the firmware, then the

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-16 Thread Xiao Guangrong
Hi David, Thanks for your review. On 03/15/2018 06:25 PM, Dr. David Alan Gilbert wrote: migration/ram.c | 32 Hi, Do you have some performance numbers to show this helps? Were those taken on a normal system or were they taken with one of the compression

Re: [Qemu-devel] [PATCH] virtio_net: flush uncompleted TX on reset

2018-03-16 Thread Jason Wang
On 2018年03月08日 02:57, Greg Kurz wrote: If the backend could not transmit a packet right away for some reason, the packet is queued for asynchronous sending. The corresponding vq element is tracked in the async_tx.elem field of the VirtIONetQueue, for later freeing when the transmission is compl

Re: [Qemu-devel] [PATCH 2/8] migration: stop allocating and freeing memory frequently

2018-03-16 Thread Xiao Guangrong
On 03/15/2018 07:03 PM, Dr. David Alan Gilbert wrote: +static int compress_threads_load_setup(void) +{ +int i, thread_count; + +if (!migrate_use_compression()) { +return 0; +} + +thread_count = migrate_decompress_threads(); +decompress_threads = g_new0(QemuThread, t

Re: [Qemu-devel] SSD virtio-scsi passthrough

2018-03-16 Thread Nitin Gupta
Vm just hang in Escape character , there is no error ..but from the qemu control window i am able to see sdc is passthrough Regards Nitin On Fri, Mar 16, 2018 at 1:16 PM, Fam Zheng wrote: > On Mon, Mar 12, 2018 at 4:16 PM, Nitin Gupta > wrote: > > Hi Stefan > > > > Thanks for your response

Re: [Qemu-devel] [PATCH 3/8] migration: support to detect compression and decompression errors

2018-03-16 Thread Xiao Guangrong
On 03/15/2018 07:29 PM, Dr. David Alan Gilbert wrote: @@ -1051,11 +1052,13 @@ static int do_compress_ram_page(QEMUFile *f, z_stream *stream, RAMBlock *block, { RAMState *rs = ram_state; int bytes_sent, blen; -uint8_t *p = block->host + (offset & TARGET_PAGE_MASK); +uint8

Re: [Qemu-devel] [PATCH v10 19/24] migration: Create multifd channels

2018-03-16 Thread Juan Quintela
Peter Xu wrote: > On Thu, Mar 15, 2018 at 01:57:54PM +0100, Juan Quintela wrote: >> Peter Xu wrote: >> > On Wed, Mar 07, 2018 at 12:00:05PM +0100, Juan Quintela wrote: >> >> In both sides. We still don't transmit anything through them. >> > >> > s/In/On/? >> >> +static void multifd_new_send_cha

Re: [Qemu-devel] [PATCH 4/8] migration: introduce control_save_page()

2018-03-16 Thread Xiao Guangrong
On 03/15/2018 07:37 PM, Dr. David Alan Gilbert wrote: * guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: From: Xiao Guangrong Abstract the common function control_save_page() to cleanup the code, no logic is changed Signed-off-by: Xiao Guangrong Reviewed-by: Dr. David Alan Gilb

Re: [Qemu-devel] [PATCH 5/8] migration: move calling control_save_page to the common place

2018-03-16 Thread Xiao Guangrong
On 03/15/2018 07:47 PM, Dr. David Alan Gilbert wrote: /* Check the pages is dirty and if it is send it */ if (migration_bitmap_clear_dirty(rs, pss->block, pss->page)) { +RAMBlock *block = pss->block; +ram_addr_t offset = pss->page << TARGET_PAGE_BITS; + +if

Re: [Qemu-devel] [PATCH] net/vde: print error on vde_open() failure

2018-03-16 Thread Jason Wang
On 2018年03月16日 04:06, Julia Suvorova via Qemu-devel wrote: Despite the fact that now when the initialization of vde fails, qemu does not end silently, no informative error is printed. The patch generates an error and pushes it through the calling function. Related bug: https://bugs.launchpad.n

Re: [Qemu-devel] [RFC 0/3] target/m68k: fix TCGv array overflow

2018-03-16 Thread Laurent Vivier
Le 15/03/2018 à 20:34, Richard Henderson a écrit : > On 03/16/2018 03:19 AM, Laurent Vivier wrote: >> I try to fix this by introducing a new TCG function >> to try to free a TCGv if it is a temporary one and >> do nothing otherwise (patches 1 and 2) > > I would prefer not to approach this in this

Re: [Qemu-devel] Using new TCG Vector infrastructure in PowerPC

2018-03-16 Thread Nikunj A Dadhania
Richard Henderson writes: > On 03/16/2018 12:08 PM, Nikunj A Dadhania wrote: >> @@ -1078,8 +1079,8 @@ struct CPUPPCState { >> /* Altivec registers */ >> ppc_avr_t avr[32]; >> uint32_t vscr; >> -/* VSX registers */ >> -uint64_t vsr[32]; >> +/* 32 (128bit)- VSX registers

Re: [Qemu-devel] [PATCH v3 3/7] s390x/cpumodel: Set up CPU model for AP device support

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:24, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The KVM_S390_VM_CPU_FEAT_AP CPU model feature indicates that AP facilities are installed. This feature will be enabl

Re: [Qemu-devel] [PATCH] i386: add KNM cpu model

2018-03-16 Thread Daniel P . Berrangé
On Fri, Mar 16, 2018 at 10:11:57AM +0800, Boqun Feng wrote: > On Wed, Mar 14, 2018 at 01:01:30PM +, Daniel P. Berrangé wrote: > > On Wed, Mar 14, 2018 at 03:29:59PM +0800, Boqun Feng wrote: > > > A new cpu model called "KNM" is added to model Knights Mill processors. > > > > Why the obscure ac

Re: [Qemu-devel] [PATCH] docker: fedora: test more components

2018-03-16 Thread Daniel P . Berrangé
On Fri, Mar 16, 2018 at 10:40:23AM +0800, Fam Zheng wrote: > On Thu, 03/15 14:47, Daniel P. Berrangé wrote: > > On Tue, Mar 13, 2018 at 01:05:52PM +0100, Paolo Bonzini wrote: > > > Install optional dependencies of QEMU to get better coverage. > > > > > > Signed-off-by: Paolo Bonzini > > > --- > >

Re: [Qemu-devel] [PATCH v3 7/7] s390: doc: detailed specifications for AP virtualization

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:25, Tony Krowiak wrote: This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak --- do

Re: [Qemu-devel] [PULL v2 0/9] Socket next patches

2018-03-16 Thread Peter Maydell
On 13 March 2018 at 18:12, Daniel P. Berrangé wrote: > The following changes since commit 59667bb167f773965ce6547352f312eff0d4d523: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' > into staging (2018-03-13 14:02:47 +) > > are available in the Git repository a

[Qemu-devel] [PATCH 3/4] hw/audio: Fix crashes when devices are used on ISA bus without DMA

2018-03-16 Thread Thomas Huth
The cs4231a, gus and sb16 sound cards crash QEMU when the user tries to instantiate them on a machine with DMA-less ISA bus (for example with "qemu-system-mips64el -M mips -device sb16"). Add proper checks to the realize functions to avoid the crashes. Signed-off-by: Thomas Huth --- hw/audio/cs4

[Qemu-devel] [PATCH 1/4] hw/net/can: Fix segfaults when using the devices without bus

2018-03-16 Thread Thomas Huth
The CAN devices can currently be used to crash QEMU, e.g.: $ x86_64-softmmu/qemu-system-x86_64 -device kvaser_pci Segmentation fault (core dumped) So we've got to add a proper check here that the corresponding bus is available. Signed-off-by: Thomas Huth --- hw/net/can/can_sja1000.c | 4

[Qemu-devel] [PATCH for-2.12 0/4] Fix crashes with CAN bus and ISA DMA devices

2018-03-16 Thread Thomas Huth
The new CAN bus devices and some older ISA devices that use DMA can be used to crash QEMU. These patches introduce some proper checks so that the users get a proper error message instead. Alexey Kardashevskiy (1): fdc: Exit if ISA controller does not support DMA Thomas Huth (3): hw/net/can: F

[Qemu-devel] [PATCH 2/4] fdc: Exit if ISA controller does not support DMA

2018-03-16 Thread Thomas Huth
From: Alexey Kardashevskiy A "powernv" machine type defines an ISA bus but it does not add any DMA controller to it so it is possible to hit assert(fdctrl->dma) by adding "-machine powernv -device isa-fdc". This replaces assert() with an error message. Signed-off-by: Alexey Kardashevskiy [thut

[Qemu-devel] [PATCH 4/4] scripts/device-crash-test: Remove fixed isapc-with-iommu entry

2018-03-16 Thread Thomas Huth
Fixed in a0c167a18470831e359f0538c3cf67907808f13e ("x86_iommu: check if machine has PCI bus"). Signed-off-by: Thomas Huth --- scripts/device-crash-test | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index 8ad3f44..b3ce720 100755 --- a/scr

Re: [Qemu-devel] [PATCH] virtio_net: flush uncompleted TX on reset

2018-03-16 Thread Greg Kurz
On Fri, 16 Mar 2018 16:05:17 +0800 Jason Wang wrote: > On 2018年03月08日 02:57, Greg Kurz wrote: > > If the backend could not transmit a packet right away for some reason, > > the packet is queued for asynchronous sending. The corresponding vq > > element is tracked in the async_tx.elem field of the

Re: [Qemu-devel] [PATCH v3 7/7] s390: doc: detailed specifications for AP virtualization

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:25, Tony Krowiak wrote: This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak --- do

Re: [Qemu-devel] [PATCH for-2.12 0/4] Fix crashes with CAN bus and ISA DMA devices

2018-03-16 Thread Paolo Bonzini
On 16/03/2018 10:51, Thomas Huth wrote: > The new CAN bus devices and some older ISA devices that use DMA can be > used to crash QEMU. These patches introduce some proper checks so that > the users get a proper error message instead. > > Alexey Kardashevskiy (1): > fdc: Exit if ISA controller do

Re: [Qemu-devel] [PATCH] docker: fedora: test more components

2018-03-16 Thread Paolo Bonzini
On 16/03/2018 10:43, Daniel P. Berrangé wrote: >> I wonder if we should simply do "dnf build-dep qemu" and only list additional >> (mingw, for example) packages explicitly, like the debian dockerfiles. > From an upstream POV it feels wrong to have our builds depend on the state > of stuff listed in

Re: [Qemu-devel] [PATCH v3 2/7] s390x/ap: base Adjunct Processor (AP) object

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:24, Tony Krowiak wrote: This patch introduces the base object for an AP device. Signed-off-by: Tony Krowiak --- hw/s390x/Makefile.objs |1 + hw/s390x/ap-device.c | 38 ++ include/hw/s390x/ap-device.h | 38 +++

[Qemu-devel] [PATCH] linux-user: Allocate extra space for brk in PIE executable

2018-03-16 Thread Richard Henderson
Limit this to 16M; there does not appear to be any special support for this in the kernel itself, at least for i686. Fixes: https://bugs.launchpad.net/bugs/1749393 Signed-off-by: Richard Henderson --- Commentary in the launchpad bug suggests 128M gap for x86_64, but that's somewhat irrelevant to

Re: [Qemu-devel] [PATCH v3 4/7] s390x/kvm: interface to interpret AP instructions

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:24, Tony Krowiak wrote: The VFIO AP device exploits interpretive execution of AP instructions (APIE). APIE is enabled by setting a device attribute via the KVM_SET_DEVICE_ATTR ioctl. Signed-off-by: Tony Krowiak --- target/s390x/kvm.c | 16 target/s39

Re: [Qemu-devel] [PATCH v3 4/7] s390x/kvm: interface to interpret AP instructions

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:24, Tony Krowiak wrote: The VFIO AP device exploits interpretive execution of AP instructions (APIE). APIE is enabled by setting a device attribute via the KVM_SET_DEVICE_ATTR ioctl. Signed-off-by: Tony Krowiak --- target/s390x/kvm.c | 16 target/s39

Re: [Qemu-devel] [PATCH v8 1/9] mirror: inherit supported write/zero flags

2018-03-16 Thread Alberto Garcia
On Mon 12 Mar 2018 11:16:50 AM CET, Anton Nefedov wrote: > Signed-off-by: Anton Nefedov > --- > block/mirror.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/block/mirror.c b/block/mirror.c > index f5bf620..2fb786f 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -

Re: [Qemu-devel] [PATCH v3 2/7] s390x/ap: base Adjunct Processor (AP) object

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:24, Tony Krowiak wrote: This patch introduces the base object for an AP device. Signed-off-by: Tony Krowiak --- hw/s390x/Makefile.objs |1 + hw/s390x/ap-device.c | 38 ++ include/hw/s390x/ap-device.h | 38 +++

Re: [Qemu-devel] [PATCH v8 3/9] quorum: set supported write/zero flags

2018-03-16 Thread Alberto Garcia
On Mon 12 Mar 2018 11:16:52 AM CET, Anton Nefedov wrote: > Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v3 5/7] s390x/vfio: ap: Introduce VFIO AP device

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:24, Tony Krowiak wrote: Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= The mediated matrix device is created by the VFIO AP device driver by writing a UUID to a sysfs attribute file (see docs/vfio

Re: [Qemu-devel] [PATCHv3] dma/i82374: avoid double creation of i82374 device

2018-03-16 Thread Thomas Huth
On 27.11.2017 09:40, Eduardo Otubo wrote: > On Fri, Nov 24, 2017 at 06:44:59PM +0100, Thomas Huth wrote: >> Hi Eduardo, >> >> On 24.11.2017 14:46, Eduardo Otubo wrote: >>> v3: >>> * Removed all unecessary local_err >>> * Change return of isa_bus_dma() and DMA_init() from void to int8_t, >>>r

Re: [Qemu-devel] [PATCH] gtk: drop pointless code from gd_window_close

2018-03-16 Thread Mark Cave-Ayland
On 15/03/18 11:35, Philippe Mathieu-Daudé wrote: On 03/14/2018 09:04 AM, Gerd Hoffmann wrote: Unregistering the display change listener looks like a pointless excercise given we'll exit in a moment. When exiting qemu via exercise menu/file/quit this will not happen either. Just drop the c

Re: [Qemu-devel] [PATCH v8 4/9] block: introduce BDRV_REQ_ALLOCATE flag

2018-03-16 Thread Alberto Garcia
On Mon 12 Mar 2018 11:16:53 AM CET, Anton Nefedov wrote: > The flag is supposed to indicate that the region of the disk image has > to be sufficiently allocated so it reads as zeroes. > > The call with the flag set must return -ENOTSUP if allocation cannot > be done efficiently. > This has to be ma

Re: [Qemu-devel] [PATCH v2 0/3] Add new CD-ROM related qtests

2018-03-16 Thread Mark Cave-Ayland
On 16/03/18 05:39, Thomas Huth wrote: With one of my clean-up patches (see commit 1454509726719e0933c800), I recently accidentially broke the "-cdrom" parameter (more precisely "-drive if=scsi") on a couple of boards, since there was no error detected during the "make check" regression testing.

Re: [Qemu-devel] [PATCH] linux-user: Allocate extra space for brk in PIE executable

2018-03-16 Thread Peter Maydell
On 16 March 2018 at 10:34, Richard Henderson wrote: > Limit this to 16M; there does not appear to be any special > support for this in the kernel itself, at least for i686. > > Fixes: https://bugs.launchpad.net/bugs/1749393 > Signed-off-by: Richard Henderson > --- > > Commentary in the launchpad

Re: [Qemu-devel] [PATCH v8 7/9] block: support BDRV_REQ_ALLOCATE in passthrough drivers

2018-03-16 Thread Alberto Garcia
On Mon 12 Mar 2018 11:16:56 AM CET, Anton Nefedov wrote: > Support the flag if the underlying BDS supports it > > Signed-off-by: Anton Nefedov > Reviewed-by: Alberto Garcia This is again not the patch that I reviewed (the quorum bits were not there), but I just check the changes and they look fi

Re: [Qemu-devel] [PULL 00/11] vfio updates for QEMU-2.12 soft freeze

2018-03-16 Thread Peter Maydell
On 13 March 2018 at 20:17, Alex Williamson wrote: > The following changes since commit 9f750794985d7386f088da941c76b73880b2b6c4: > > sev/i386: add sev_get_capabilities() (2018-03-13 17:36:06 +0100) > > are available in the Git repository at: > > git://github.com/awilliam/qemu-vfio.git tags/vfi

[Qemu-devel] [PATCH v5 1/5] bitmap: bitmap_count_one_with_offset

2018-03-16 Thread Wei Wang
Count the number of 1s in a bitmap starting from an offset. Signed-off-by: Wei Wang CC: Dr. David Alan Gilbert CC: Juan Quintela CC: Michael S. Tsirkin Reviewed-by: Dr. David Alan Gilbert --- include/qemu/bitmap.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/qem

[Qemu-devel] [PATCH v5 2/5] migration: use bitmap_mutex in migration_bitmap_clear_dirty

2018-03-16 Thread Wei Wang
The bitmap mutex is used to synchronize threads to update the dirty bitmap and the migration_dirty_pages count. This patch makes migration_bitmap_clear_dirty update the bitmap and count under the mutex. Signed-off-by: Wei Wang CC: Dr. David Alan Gilbert CC: Juan Quintela CC: Michael S. Tsirkin

[Qemu-devel] [PATCH v5 3/5] migration: API to clear bits of guest free pages from the dirty bitmap

2018-03-16 Thread Wei Wang
This patch adds an API to clear bits corresponding to guest free pages from the dirty bitmap. Spilt the free page block if it crosses the QEMU RAMBlock boundary. Signed-off-by: Wei Wang CC: Dr. David Alan Gilbert CC: Juan Quintela CC: Michael S. Tsirkin --- include/migration/misc.h | 2 ++ m

[Qemu-devel] [PATCH v5 5/5] migration: use the free page hint feature from balloon

2018-03-16 Thread Wei Wang
Start the free page optimization after the migration bitmap is synchronized. This can't be used in the stop© phase since the guest is paused. Make sure the guest reporting has stopped before synchronizing the migration dirty bitmap. Currently, the optimization is added to precopy only. Signed-off-

[Qemu-devel] [PATCH v5 4/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-03-16 Thread Wei Wang
The new feature enables the virtio-balloon device to receive hints of guest free pages from the free page vq. balloon_free_page_start - start guest free page hint reporting. balloon_free_page_stop - stop guest free page hint reporting. Note: balloon will report pages which were free at the time o

[Qemu-devel] [PATCH v5 0/5] virtio-balloon: free page hint reporting support

2018-03-16 Thread Wei Wang
This is the deivce part implementation to add a new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device receives the guest free page hints from the driver and clears the corresponding bits in the dirty bitmap, so that those free pages are not transferred by the migrati

Re: [Qemu-devel] [PATCH v4 4/4] migration: use the free page hint feature from balloon

2018-03-16 Thread Wei Wang
On 03/15/2018 03:49 AM, Dr. David Alan Gilbert wrote: * Wei Wang (wei.w.w...@intel.com) wrote: Start the free page optimization after the migration bitmap is synchronized. This can't be used in the stop© phase since the guest is paused. Make sure the guest reporting has stopped before synchroniz

Re: [Qemu-devel] [PATCH] ide: fix invalid TRIM range abortion for macio

2018-03-16 Thread Mark Cave-Ayland
On 05/03/18 21:54, Mark Cave-Ayland wrote: On 02/03/18 17:08, Anton Nefedov wrote: commit 947858b0 "ide: abort TRIM operation for invalid range" is incorrect for macio; just ide_dma_error() without doing a callback is not enough for that errorpath. Instead, pass -EINVAL to the callback and ha

Re: [Qemu-devel] [PATCH v4 2/4] migration: API to clear bits of guest free pages from the dirty bitmap

2018-03-16 Thread Wei Wang
On 03/15/2018 09:50 PM, Michael S. Tsirkin wrote: On Thu, Mar 15, 2018 at 06:52:41PM +0800, Wei Wang wrote: On 03/15/2018 02:11 AM, Dr. David Alan Gilbert wrote: * Wei Wang (wei.w.w...@intel.com) wrote: This patch adds an API to clear bits corresponding to guest free pages from the dirty bitma

Re: [Qemu-devel] [PATCH] virtio_net: flush uncompleted TX on reset

2018-03-16 Thread Jason Wang
On 2018年03月16日 17:58, Greg Kurz wrote: On Fri, 16 Mar 2018 16:05:17 +0800 Jason Wang wrote: On 2018年03月08日 02:57, Greg Kurz wrote: If the backend could not transmit a packet right away for some reason, the packet is queued for asynchronous sending. The corresponding vq element is tracked in

Re: [Qemu-devel] [PATCH v7 22/22] tcg: fix cpu_io_recompile

2018-03-16 Thread Richard Henderson
On 27 February 2018 at 17:53, Pavel Dovgalyuk wrote: > > cpu_io_recompile() function was broken by > the commit 9b990ee5a3cc6aa38f81266fb0c6ef37a36c45b9. Instead of regenerating > the block starting from PC of the original block, it just set the instruction > counter for TCG. In most cases this wa

Re: [Qemu-devel] [PATCH v7 22/22] tcg: fix cpu_io_recompile

2018-03-16 Thread Pavel Dovgalyuk
> From: Richard Henderson [mailto:richard.hender...@linaro.org] > On 27 February 2018 at 17:53, Pavel Dovgalyuk > wrote: > > > > cpu_io_recompile() function was broken by > > the commit 9b990ee5a3cc6aa38f81266fb0c6ef37a36c45b9. Instead of regenerating > > the block starting from PC of the origina

Re: [Qemu-devel] [PATCH] linux-user: Allocate extra space for brk in PIE executable

2018-03-16 Thread Richard Henderson
On 03/16/2018 07:01 PM, Peter Maydell wrote: > PS: do you know what the intention of the > if (reserved_va) { > mmap_next_start = reserved_va; > } > code in linux-user/main.c is? It seems a bit odd to say "ok, > we have reserved a big region. we will start trying to mmap

[Qemu-devel] [PATCH v11 04/15] migration: Introduce multifd_recv_new_channel()

2018-03-16 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/migration.c | 3 ++- migration/ram.c | 6 ++ migration/ram.h | 2 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 3b811c213a..21c651b4ee 100644 --- a/migration/migratio

[Qemu-devel] [PATCH v11 07/15] migration: Synchronize send threads

2018-03-16 Thread Juan Quintela
We synchronize all threads each RAM_SAVE_FLAG_EOS. Bitmap synchronizations don't happen inside a ram section, so we are safe about two channels trying to overwrite the same memory. Signed-off-by: Juan Quintela --- migration/ram.c| 52 +-

[Qemu-devel] [PATCH v11 05/15] migration: Be sure all recv channels are created

2018-03-16 Thread Juan Quintela
We need them before we start migration. Signed-off-by: Juan Quintela --- migration/migration.c | 6 +- migration/ram.c | 11 +++ migration/ram.h | 1 + 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 21c

[Qemu-devel] [PATCH v11 03/15] migration: terminate_* can be called for other threads

2018-03-16 Thread Juan Quintela
Once there, make count field to always be accessed with atomic operations. To make blocking operations, we need to know that the thread is running, so create a bool to indicate that. Signed-off-by: Juan Quintela -- Once here, s/terminate_multifd_*-threads/multifd_*_terminate_threads/ This is

[Qemu-devel] [RFC v11 00/15] mutifd

2018-03-16 Thread Juan Quintela
Multifd Hi [v11] Changes on top of previous sumbimission: - Now on top of migration-tests/v6 that I sent on Wednesday - Rebased to latest upstream - Everything that is sent through the network should be converted correctly (famous last words) - Still on RFC (sometimes it ends some packets at

[Qemu-devel] [PATCH v11 01/15] migration: Set error state in case of error

2018-03-16 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 20 1 file changed, 20 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 7266351fd0..1b8095a358 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -414,6 +414,16 @@ static void terminate_multifd_send_thre

[Qemu-devel] [PATCH v11 02/15] migration: In case of error just end the migration

2018-03-16 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrangé -- As requested, just continue connection in case of error. --- migration/socket.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/migration/socket.c b/migration/socket.c index 52db0c0c09..8dda1d9a98 100644 --

[Qemu-devel] [PATCH v11 08/15] migration: Synchronize recv threads

2018-03-16 Thread Juan Quintela
We synchronize all threads each RAM_SAVE_FLAG_EOS. Bitmap synchronizations don't happen inside a ram section, so we are safe about two channels trying to overwrite the same memory. Signed-off-by: Juan Quintela --- migration/ram.c| 49 - m

[Qemu-devel] [PATCH v11 12/15] migration: Transmit initial package through the multifd channels

2018-03-16 Thread Juan Quintela
Signed-off-by: Juan Quintela -- Be network agnostic. Add error checking for all values. --- migration/ram.c | 97 ++--- 1 file changed, 92 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 55af077abc..dd77c780

[Qemu-devel] [PATCH v11 14/15] migration: Create pages structure for reception

2018-03-16 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 9919777a21..0132de6e02 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -775,6 +775,7 @@ static void multifd_send_page(RAMBlock *block, ra

[Qemu-devel] [PATCH v11 06/15] migration: Export functions to create send channels

2018-03-16 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/socket.c | 28 +++- migration/socket.h | 7 +++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/migration/socket.c b/migration/socket.c index 8dda1d9a98..7889753fab 100644 --- a/migration/socket.c +++ b/migrati

[Qemu-devel] [PATCH v11 09/15] migration: Add multifd traces for start/end thread

2018-03-16 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrangé --- migration/ram.c| 6 ++ migration/trace-events | 4 2 files changed, 10 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 4ba03cf9c9..7d9e363bbe 100644 --- a/migration/ram.c +++ b/migration/ram.c @

[Qemu-devel] [PATCH v11 13/15] migration: Create ram_multifd_page

2018-03-16 Thread Juan Quintela
The function still don't use multifd, but we have simplified ram_save_page, xbzrle and RDMA stuff is gone. We have added a new counter. Signed-off-by: Juan Quintela -- Add last_page parameter Add commets for done and address Remove multifd field, it is the same than normal pages Merge next patc

[Qemu-devel] [PATCH v11 11/15] migration: Delay start of migration main routines

2018-03-16 Thread Juan Quintela
We need to make sure that we have started all the multifd threads. Signed-off-by: Juan Quintela --- migration/migration.c | 4 ++-- migration/migration.h | 1 + migration/ram.c | 3 +++ migration/socket.c| 3 +++ 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/migration/

Re: [Qemu-devel] [PATCH v2 2/3] tests/cdrom-test: Test booting from CD-ROM ISO image file

2018-03-16 Thread Philippe Mathieu-Daudé
On 03/16/2018 06:39 AM, Thomas Huth wrote: > We already have the code for a boot file in tests/boot-sector.c, > so if the genisoimage program is available, we can easily create > a bootable CD ISO image that we can use for testing whether our > CD-ROM emulation and the BIOS CD-ROM boot works correc

[Qemu-devel] [PATCH v11 10/15] migration: Create multifd channels

2018-03-16 Thread Juan Quintela
In both sides. We still don't transmit anything through them. Signed-off-by: Juan Quintela --- migration/ram.c | 50 -- 1 file changed, 40 insertions(+), 10 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 7d9e363bbe..5dade41243

Re: [Qemu-devel] [PATCH v2 1/3] tests/boot-sector: Add magic bytes to s390x boot code header

2018-03-16 Thread Philippe Mathieu-Daudé
On 03/16/2018 06:39 AM, Thomas Huth wrote: > We're going to use the s390x boot code for testing CD-ROM booting. > But the ISO loader of the s390-ccw bios is a little bit more picky > than the network loader and expects some magic bytes in the header > of the file (see linux_s390_magic in pc-bios/s3

[Qemu-devel] [PATCH v11 15/15] [RFC] migration: Send pages through the multifd channels

2018-03-16 Thread Juan Quintela
Migration ends correctly, but there is still a race between clean up and last synchronization. Signed-off-by: Juan Quintela --- migration/ram.c| 240 ++--- migration/trace-events | 3 +- 2 files changed, 211 insertions(+), 32 deletions(-) di

[Qemu-devel] [PATCH v2] virtio_net: flush uncompleted TX on reset

2018-03-16 Thread Greg Kurz
If the backend could not transmit a packet right away for some reason, the packet is queued for asynchronous sending. The corresponding vq element is tracked in the async_tx.elem field of the VirtIONetQueue, for later freeing when the transmission is complete. If a reset happens before completion,

[Qemu-devel] [PATCH 0/2] docker: update package list for fedora image

2018-03-16 Thread Paolo Bonzini
The first patch modernizes and completes the list of packages installed in the Fedora docker image. Both MinGW cross and native compilation are switched to SDL 2.0 and GTK+ 3.0. Paolo Paolo Bonzini (2): docker: test-mingw: use SDL2 and GTK+3 docker: fedora: include more build dependencies

[Qemu-devel] [PATCH 1/2] docker: test-mingw: use SDL2 and GTK+3

2018-03-16 Thread Paolo Bonzini
Do not test the deprecated API versions. debian-win32-cross and debian-win64-cross are already using SDL2 (they do not cover GTK+ at all). Signed-off-by: Paolo Bonzini --- tests/docker/dockerfiles/fedora.docker | 8 tests/docker/test-mingw| 4 ++-- 2 files changed, 6 i

[Qemu-devel] [PATCH 2/2] docker: fedora: include more build dependencies

2018-03-16 Thread Paolo Bonzini
Install optional dependencies of QEMU to get better coverage. Signed-off-by: Paolo Bonzini --- tests/docker/dockerfiles/fedora.docker | 67 -- 1 file changed, 55 insertions(+), 12 deletions(-) diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/do

Re: [Qemu-devel] [PATCH 3/4] hw/audio: Fix crashes when devices are used on ISA bus without DMA

2018-03-16 Thread Philippe Mathieu-Daudé
On 03/16/2018 10:51 AM, Thomas Huth wrote: > The cs4231a, gus and sb16 sound cards crash QEMU when the user tries > to instantiate them on a machine with DMA-less ISA bus (for example > with "qemu-system-mips64el -M mips -device sb16"). Add proper checks > to the realize functions to avoid the cras

Re: [Qemu-devel] [PATCH 1/2] docker: test-mingw: use SDL2 and GTK+3

2018-03-16 Thread Daniel P . Berrangé
On Fri, Mar 16, 2018 at 01:25:39PM +0100, Paolo Bonzini wrote: > Do not test the deprecated API versions. debian-win32-cross and > debian-win64-cross > are already using SDL2 (they do not cover GTK+ at all). > > Signed-off-by: Paolo Bonzini > --- > tests/docker/dockerfiles/fedora.docker | 8 ++

Re: [Qemu-devel] [PATCH v2] Add udmabuf misc device

2018-03-16 Thread Christian König
Am 16.03.2018 um 08:46 schrieb Gerd Hoffmann: A driver to let userspace turn iovecs into dma-bufs. Use case: Allows qemu create dmabufs for the vga framebuffer or virtio-gpu ressources. Then they can be passed around to display those guest things on the host. To spice client for classic full

Re: [Qemu-devel] [PULL 00/41] Block layer patches

2018-03-16 Thread Kevin Wolf
Am 15.03.2018 um 18:55 hat John Snow geschrieben: > > > On 03/15/2018 12:56 PM, Kevin Wolf wrote: > > Am 15.03.2018 um 17:42 hat Peter Maydell geschrieben: > >> On 13 March 2018 at 16:17, Kevin Wolf wrote: > >>> The following changes since commit > >>> 22ef7ba8e8ce7fef297549b3defcac333742b804:

Re: [Qemu-devel] [PATCH 2/2] docker: fedora: include more build dependencies

2018-03-16 Thread Daniel P . Berrangé
On Fri, Mar 16, 2018 at 01:25:40PM +0100, Paolo Bonzini wrote: > Install optional dependencies of QEMU to get better coverage. > > Signed-off-by: Paolo Bonzini > --- > tests/docker/dockerfiles/fedora.docker | 67 > -- > 1 file changed, 55 insertions(+), 12 deleti

Re: [Qemu-devel] [PATCH 2/2] docker: fedora: include more build dependencies

2018-03-16 Thread Paolo Bonzini
On 16/03/2018 13:45, Daniel P. Berrangé wrote: > On Fri, Mar 16, 2018 at 01:25:40PM +0100, Paolo Bonzini wrote: >> Install optional dependencies of QEMU to get better coverage. >> >> Signed-off-by: Paolo Bonzini >> --- >> tests/docker/dockerfiles/fedora.docker | 67 >> +++

[Qemu-devel] [Bug 1438572] Re: kvm does not support KVM_CAP_USER_MEMORY Please upgrade to at least kernel 2.6.29 or recent kvm-kmod (see http://sourceforge.net/projects/kvm)

2018-03-16 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

Re: [Qemu-devel] [PATCH v2 0/3] Add new CD-ROM related qtests

2018-03-16 Thread Michael S. Tsirkin
On Fri, Mar 16, 2018 at 06:39:52AM +0100, Thomas Huth wrote: > With one of my clean-up patches (see commit 1454509726719e0933c800), I > recently accidentially broke the "-cdrom" parameter (more precisely > "-drive if=scsi") on a couple of boards, since there was no error > detected during the "make

Re: [Qemu-devel] [PATCH 1/2] docker: test-mingw: use SDL2 and GTK+3

2018-03-16 Thread Philippe Mathieu-Daudé
On 03/16/2018 01:25 PM, Paolo Bonzini wrote: > Do not test the deprecated API versions. debian-win32-cross and > debian-win64-cross > are already using SDL2 (they do not cover GTK+ at all). Good idea to start a doc/test/docker-coverage.txt with a matrix of configs tested (for example debian-amd6

Re: [Qemu-devel] [PULL 00/69] Misc patches for QEMU soft freeze

2018-03-16 Thread Peter Maydell
On 13 March 2018 at 22:46, Paolo Bonzini wrote: > Not sure why this didn't make it to the list yesterday---most likely I > didn't remove --dry-run... Now I understand why everybody was waiting > for my pull request. > > The following changes since commit 819fd4699c7b36d574292bcbd8bc25e9d716c84b:

[Qemu-devel] [Bug 1435101] Re: Windows, QEMU 2.2.50 fails to boot XP CD

2018-03-16 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Bug 1435359] Re: Booting kernel 3.19.2 fails most of the time

2018-03-16 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] KVM call for agenda for 2018-03-20

2018-03-16 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: By

Re: [Qemu-devel] [PATCH 1/1] block: fix iotest 146 output expectations

2018-03-16 Thread Kevin Wolf
Am 12.03.2018 um 22:29 hat Jeff Cody geschrieben: > Commit bff5554843 added "force_size" into the common.filter for > _filter_img_create(), but test 146 still expects it in the output. > > Signed-off-by: Jeff Cody Thanks, applied to the block branch. Kevin

[Qemu-devel] tpm-tis-test and tpm-crb-test crash on OSX

2018-03-16 Thread Peter Maydell
On OSX host, I noticed that tpm-tis-test and tpm-crb-test both crash on OSX, hitting an error_abort case: (lldb) run Process 65115 launched: '/Users/pm215/src/qemu-for-merges/build/all/tests/tpm-tis-test' (x86_64) /i386/tpm-tis/test_check_localities: OK /i386/tpm-tis/test_check_access_reg: OK /i38

Re: [Qemu-devel] [PATCH v3 5/7] s390x/vfio: ap: Introduce VFIO AP device

2018-03-16 Thread Halil Pasic
On 03/16/2018 11:42 AM, Pierre Morel wrote: > On 16/03/2018 00:24, Tony Krowiak wrote: >> Introduces a VFIO based AP device. The device is defined via >> the QEMU command line by specifying: >> >> -device vfio-ap,sysfsdev= >> >> The mediated matrix device is created by the VFIO AP device >>

Re: [Qemu-devel] tpm-tis-test and tpm-crb-test crash on OSX

2018-03-16 Thread Peter Maydell
On 16 March 2018 at 13:12, Peter Maydell wrote: > On OSX host, I noticed that tpm-tis-test and tpm-crb-test > both crash on OSX, hitting an error_abort case: > > (lldb) run > Process 65115 launched: > '/Users/pm215/src/qemu-for-merges/build/all/tests/tpm-tis-test' > (x86_64) > /i386/tpm-tis/test_c

  1   2   3   >