Re: [Qemu-devel] [PATCH v2] dump-guest-memory: more descriptive lookup_type failure

2018-03-15 Thread Fam Zheng
On Wed, 03/14 16:38, Andrew Jones wrote: > We've seen a few reports of > > (gdb) source /usr/share/qemu-kvm/dump-guest-memory.py > Traceback (most recent call last): >File "/usr/share/qemu-kvm/dump-guest-memory.py", line 19, in > UINTPTR_T = gdb.lookup_type("uintptr_t") > gdb.error: N

Re: [Qemu-devel] [PATCH for 2.12] iotests: Avoid realpath

2018-03-15 Thread Fam Zheng
On Wed, 03/14 09:47, Eric Blake wrote: > > The remaining use was using realpath to convert a possibly > > relative filename into an absolute one before calling diff, > > but diff works just fine on the relative name. > > Hmm, this last change reverts commit 93e53fb6 that added realpath on purpose

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: fix tlbsync to check privilege level depending on GTSE

2018-03-15 Thread Cédric Le Goater
>> --- a/target/ppc/translate.c >> +++ b/target/ppc/translate.c >> @@ -4526,7 +4526,7 @@ static void gen_tlbie(DisasContext *ctx) >> TCGv_i32 t1; >> >> if (ctx->gtse) { >> -CHK_SV; /* If gtse is set then tblie is supervisor >> privileged */ >> +CHK_SV; /* If gtse is set

[Qemu-devel] [PATCH 0/3] Add new CD-ROM related qtests

2018-03-15 Thread Thomas Huth
With one of my clean-up patches (see commit 1454509726719e0933c800), I recently accidentially broke the "-cdrom" parameter (more precisely "-drive if=scsi") on a couple of boards, since there was no error detected during the "make check" regression testing. This is clearly an indication that we are

[Qemu-devel] [PATCH 1/3] tests/boot-sector: Add magic bytes to s390x boot code header

2018-03-15 Thread Thomas Huth
We're going to use the s390x boot code for testing CD-ROM booting. But the ISO loader of the s390-ccw bios is a little bit more picky than the network loader and expects some magic bytes in the header of the file (see linux_s390_magic in pc-bios/s390-ccw/bootmap.c), so we've got to add them in our

[Qemu-devel] [PATCH 3/3] tests/cdrom-test: Test that -cdrom parameter is working

2018-03-15 Thread Thomas Huth
Commit 1454509726719e0933c800 recently broke the "-cdrom" parameter on a couple of boards without that we noticed it immediately. Thus add a test which checks that "-cdrom" can at least be used to start QEMU with certain machine types. Signed-off-by: Thomas Huth --- tests/Makefile.include | 7 +

[Qemu-devel] [PATCH 2/3] tests/cdboot: Test booting from CD-ROM ISO image file

2018-03-15 Thread Thomas Huth
We already have the code for a boot file in tests/boot-sector.c, so if the genisoimage program is available, we can easily create a bootable CD ISO image that we can use for testing whether our CD-ROM emulation and the BIOS CD-ROM boot works correctly. Signed-off-by: Thomas Huth --- tests/Makefi

Re: [Qemu-devel] regression in timer code?

2018-03-15 Thread Max Filippov
On Wed, Mar 14, 2018 at 11:09 PM, Pavel Dovgalyuk wrote: >> From: Max Filippov [mailto:jcmvb...@gmail.com] >> On Wed, Mar 14, 2018 at 2:53 AM, Pavel Dovgalyuk wrote: >> > icount is adjusted by icount_warp_rt when CPU sleeps. >> > These adjustments may be different in different runs. >> > And the

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/3] tests/boot-sector: Add magic bytes to s390x boot code header

2018-03-15 Thread Christian Borntraeger
On 03/15/2018 08:49 AM, Thomas Huth wrote: > We're going to use the s390x boot code for testing CD-ROM booting. > But the ISO loader of the s390-ccw bios is a little bit more picky > than the network loader and expects some magic bytes in the header > of the file (see linux_s390_magic in pc-bios/

Re: [Qemu-devel] [PATCH v7 00/23] Migration: postcopy failure recovery

2018-03-15 Thread Fam Zheng
On Mon, 03/12 12:45, Peter Xu wrote: > On Fri, Mar 09, 2018 at 10:59:03AM -0600, Eric Blake wrote: > > On 03/09/2018 10:54 AM, Eric Blake wrote: > > > On 03/09/2018 03:15 AM, Peter Xu wrote: > > > > Based-on: <20180309090006.10018-1-pet...@redhat.com> > > > > > > > > This series is based on the se

Re: [Qemu-devel] [PATCH v7 00/23] Migration: postcopy failure recovery

2018-03-15 Thread Peter Xu
On Thu, Mar 15, 2018 at 04:19:37PM +0800, Fam Zheng wrote: > On Mon, 03/12 12:45, Peter Xu wrote: > > On Fri, Mar 09, 2018 at 10:59:03AM -0600, Eric Blake wrote: > > > On 03/09/2018 10:54 AM, Eric Blake wrote: > > > > On 03/09/2018 03:15 AM, Peter Xu wrote: > > > > > Based-on: <20180309090006.10018

Re: [Qemu-devel] [PATCH v7 00/23] Migration: postcopy failure recovery

2018-03-15 Thread Fam Zheng
On Thu, 03/15 16:41, Peter Xu wrote: > On Thu, Mar 15, 2018 at 04:19:37PM +0800, Fam Zheng wrote: > > On Mon, 03/12 12:45, Peter Xu wrote: > > > On Fri, Mar 09, 2018 at 10:59:03AM -0600, Eric Blake wrote: > > > > On 03/09/2018 10:54 AM, Eric Blake wrote: > > > > > On 03/09/2018 03:15 AM, Peter Xu w

Re: [Qemu-devel] [PATCH 2/3] tests/cdboot: Test booting from CD-ROM ISO image file

2018-03-15 Thread Daniel P . Berrangé
On Thu, Mar 15, 2018 at 08:49:04AM +0100, Thomas Huth wrote: > We already have the code for a boot file in tests/boot-sector.c, > so if the genisoimage program is available, we can easily create > a bootable CD ISO image that we can use for testing whether our > CD-ROM emulation and the BIOS CD-ROM

Re: [Qemu-devel] [PATCH v4 14/29] libvhost-user+postcopy: Register new regions with the ufd

2018-03-15 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Mon, Mar 12, 2018 at 01:23:21PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Thu, Mar 08, 2018 at 07:57:56PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David Alan Gilbert" > > > > > > >

Re: [Qemu-devel] [PATCH] virtio_net: flush uncompleted TX on reset

2018-03-15 Thread Greg Kurz
Ping ? On Thu, 8 Mar 2018 10:38:56 +0530 "Nageswara R Sastry" wrote: > Greg Kurz wrote on 08/03/2018 12:27:37 AM: > > > From: Greg Kurz > > To: qemu-devel@nongnu.org > > Cc: "Michael S. Tsirkin" , Jason Wang > > , R Nageswara Sastry > > Date: 08/03/2018 12:27 AM > > Subject: [PATCH] virtio_

Re: [Qemu-devel] [PATCH v9 11/14] target/arm/kvm: Translate the MSI doorbell in kvm_arch_fixup_msi_route

2018-03-15 Thread Auger Eric
Hi Paolo, On 13/03/18 14:37, Paolo Bonzini wrote: > On 12/03/2018 16:16, Auger Eric wrote: >>> It is still unclear to me if we need to register an IOMMUNotifier >>> to handle any change in the MSI doorbell which would occur behind >>> the scene and would not lead to any call to kvm_arch_fixup_msi_

Re: [Qemu-devel] ARM64 Interrupt handling on QEMU

2018-03-15 Thread Peter Maydell
On 15 March 2018 at 03:07, Brijen Raval wrote: > I am booting up a custom kernel on QEMU ARM64, upon completion of its > initial boot up it looks like it enters the arch_idle() state > > I enabled the -d int logging to understand what is going on, I see the > following repeated many times continuo

Re: [Qemu-devel] [PULL 0/1] Block patches

2018-03-15 Thread Peter Maydell
On 13 March 2018 at 12:29, Jeff Cody wrote: > The following changes since commit 834eddf22ec762839b724538c7be1d1d3b2d9d3b: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2018-03-13 10:49:02 +) > > are available in the git repository at: > > git

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v4 3/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-03-15 Thread Wei Wang
On 03/15/2018 10:47 AM, Michael S. Tsirkin wrote: On Thu, Mar 15, 2018 at 09:15:48AM +0800, Wei Wang wrote: On 03/14/2018 10:12 PM, Michael S. Tsirkin wrote: On Wed, Mar 14, 2018 at 02:03:19PM +0800, Wei Wang wrote: On 03/14/2018 10:53 AM, Michael S. Tsirkin wrote: On Wed, Mar 14, 2018 at 10:

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-15 Thread Dr. David Alan Gilbert
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > As compression is a heavy work, do not do it in migration thread, > instead, we post it out as a normal page > > Signed-off-by: Xiao Guangrong > --- > migration/ram.c | 32

Re: [Qemu-devel] [PATCH 2/3] tests/cdboot: Test booting from CD-ROM ISO image file

2018-03-15 Thread Thomas Huth
On 15.03.2018 10:21, Daniel P. Berrangé wrote: > On Thu, Mar 15, 2018 at 08:49:04AM +0100, Thomas Huth wrote: >> We already have the code for a boot file in tests/boot-sector.c, >> so if the genisoimage program is available, we can easily create >> a bootable CD ISO image that we can use for testin

Re: [Qemu-devel] [PATCH v4 2/4] migration: API to clear bits of guest free pages from the dirty bitmap

2018-03-15 Thread Wei Wang
On 03/15/2018 02:11 AM, Dr. David Alan Gilbert wrote: * Wei Wang (wei.w.w...@intel.com) wrote: This patch adds an API to clear bits corresponding to guest free pages from the dirty bitmap. Spilt the free page block if it crosses the QEMU RAMBlock boundary. Signed-off-by: Wei Wang CC: Dr. David

Re: [Qemu-devel] [PATCH] linux-user: implement HWCAP bits on MIPS

2018-03-15 Thread James Cowgill
Hi, On 14/03/18 16:13, Laurent Vivier wrote: > Le 14/03/2018 à 16:31, James Cowgill a écrit : >> Add support for the two currently defined HWCAP bits on MIPS - R6 and >> MSA. >> >> Buglink: https://bugs.launchpad.net/qemu/+bug/1754372 >> Signed-off-by: James Cowgill >> --- >> This was resent beca

Re: [Qemu-devel] [PATCH 2/8] migration: stop allocating and freeing memory frequently

2018-03-15 Thread Dr. David Alan Gilbert
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > Current code uses compress2()/uncompress() to compress/decompress > memory, these two function manager memory allocation and release > internally, that causes huge memory is allocated and freed very > frequent

Re: [Qemu-devel] [PATCH v4 2/4] migration: API to clear bits of guest free pages from the dirty bitmap

2018-03-15 Thread Wei Wang
On 03/15/2018 03:42 AM, Dr. David Alan Gilbert wrote: * Michael S. Tsirkin (m...@redhat.com) wrote: On Wed, Mar 14, 2018 at 06:11:37PM +, Dr. David Alan Gilbert wrote: +used_len = block->used_length - offset; +addr += used_len; +} + +start = offset >>

Re: [Qemu-devel] [PATCH 3/8] migration: support to detect compression and decompression errors

2018-03-15 Thread Dr. David Alan Gilbert
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > Currently the page being compressed is allowed to be updated by > the VM on the source QEMU, correspondingly the destination QEMU > just ignores the decompression error. However, we completely miss > the chanc

Re: [Qemu-devel] [PATCH] gtk: drop pointless code from gd_window_close

2018-03-15 Thread Philippe Mathieu-Daudé
On 03/14/2018 09:04 AM, Gerd Hoffmann wrote: > Unregistering the display change listener looks like a pointless > excercise given we'll exit in a moment. When exiting qemu via exercise > menu/file/quit this will not happen either. Just drop the code. > > Also return TRUE unconditionally. This

Re: [Qemu-devel] [PATCH 4/8] migration: introduce control_save_page()

2018-03-15 Thread Dr. David Alan Gilbert
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > Abstract the common function control_save_page() to cleanup the code, > no logic is changed > > Signed-off-by: Xiao Guangrong Reviewed-by: Dr. David Alan Gilbert It would be good to find a better name for

Re: [Qemu-devel] [PATCH 3/3] tests/cdrom-test: Test that -cdrom parameter is working

2018-03-15 Thread Philippe Mathieu-Daudé
Hi Thomas, On 03/15/2018 08:49 AM, Thomas Huth wrote: > Commit 1454509726719e0933c800 recently broke the "-cdrom" parameter > on a couple of boards without that we noticed it immediately. Thus > add a test which checks that "-cdrom" can at least be used to start > QEMU with certain machine types.

[Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix

2018-03-15 Thread Su Hang
Bug fix: checkpatch.pl stops complaining about following pattern: """ do { //do somethins; } while (conditions); """ Two things need to be mentioned: 1) Before I casue this bug, checkpatch.pl will raise a wrong complain: """ ERROR: braces {} are necessary even for single statement blocks +

Re: [Qemu-devel] [PATCH 5/8] migration: move calling control_save_page to the common place

2018-03-15 Thread Dr. David Alan Gilbert
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > The function is called by both ram_save_page and ram_save_target_page, > so move it to the common caller to cleanup the code > > Signed-off-by: Xiao Guangrong > --- > migration/ram.c | 16 >

Re: [Qemu-devel] [PATCH 1/3] tests/boot-sector: Add magic bytes to s390x boot code header

2018-03-15 Thread Philippe Mathieu-Daudé
On 03/15/2018 08:49 AM, Thomas Huth wrote: > We're going to use the s390x boot code for testing CD-ROM booting. > But the ISO loader of the s390-ccw bios is a little bit more picky > than the network loader and expects some magic bytes in the header > of the file (see linux_s390_magic in pc-bios/s3

Re: [Qemu-devel] [PATCH] checkpatch: warn about missing MAINTAINERS file changes

2018-03-15 Thread Stefan Hajnoczi
On Tue, Mar 13, 2018 at 11:49:57AM +0100, Thomas Huth wrote: > On 13.03.2018 11:37, Stefan Hajnoczi wrote: > > On Mon, Mar 12, 2018 at 02:46:20PM +0100, Thomas Huth wrote: > >> On 12.03.2018 14:18, Stefan Hajnoczi wrote: > >>> Warn if files are added/renamed/deleted without MAINTAINERS file > >>> c

[Qemu-devel] [Bug 1754038] Re: ARM M: Systick first wrap delayed (qemu-timers/icount prb?)

2018-03-15 Thread Peter Maydell
** Tags added: arm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1754038 Title: ARM M: Systick first wrap delayed (qemu-timers/icount prb?) Status in QEMU: New Bug description: When running t

[Qemu-devel] [Bug 1755479] Re: Cortex M:qemu abort with optimized code and icount

2018-03-15 Thread Peter Maydell
** Tags added: arm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1755479 Title: Cortex M:qemu abort with optimized code and icount Status in QEMU: New Bug description: A basic program runs fi

Re: [Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix

2018-03-15 Thread Peter Maydell
On 15 March 2018 at 11:45, Su Hang wrote: > Bug fix: checkpatch.pl stops complaining about following pattern: > """ > do { > //do somethins; > } while (conditions); > """ > > Two things need to be mentioned: > 1) Before I casue this bug, checkpatch.pl will raise a wrong > complain: > """ > ERR

[Qemu-devel] [Bug 1748434] Re: Possibly wrong GICv3 behavior when secure enabled

2018-03-15 Thread Peter Maydell
** Tags added: arm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1748434 Title: Possibly wrong GICv3 behavior when secure enabled Status in QEMU: New Bug description: I an tried arm-aarch64 i

[Qemu-devel] [Bug 1749393] Re: sbrk() not working under qemu-user with a PIE-compiled binary?

2018-03-15 Thread Peter Maydell
** Tags added: arm linux-user -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1749393 Title: sbrk() not working under qemu-user with a PIE-compiled binary? Status in QEMU: New Bug description:

[Qemu-devel] [PATCH v2 for-2.12] iotests: Avoid realpath, for CentOS 6

2018-03-15 Thread Eric Blake
CentOS 6 lacks a realpath binary on the base install, which makes all iotests runs fail since the 2.11 release: 001 - output mismatch (see 001.out.bad) ./check: line 815: realpath: command not found diff: missing operand after `/home/dummy/qemu/tests/qemu-iotests/001.out' diff: Try `diff -

[Qemu-devel] [Bug 1746943] Re: qemu-aarch64-static: qemu: uncaught target signal 11 for ps/top cmd

2018-03-15 Thread Peter Maydell
** Tags added: arm linux-user -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1746943 Title: qemu-aarch64-static: qemu: uncaught target signal 11 for ps/top cmd Status in QEMU: New Bug descriptio

Re: [Qemu-devel] [PATCH 2/3] tests/cdboot: Test booting from CD-ROM ISO image file

2018-03-15 Thread Eric Blake
On 03/15/2018 05:48 AM, Thomas Huth wrote: +pid = fork(); +if (pid == 0) { +va_start(args, fmt); +params = g_strdup_vprintf(fmt, args); +va_end(args); +command = g_strdup_printf("exec genisoimage %s", params); +g_free(params); +execlp("/bin

Re: [Qemu-devel] [PATCH 3/3] tests/cdrom-test: Test that -cdrom parameter is working

2018-03-15 Thread Eric Blake
On 03/15/2018 02:49 AM, Thomas Huth wrote: Commit 1454509726719e0933c800 recently broke the "-cdrom" parameter on a couple of boards without that we noticed it immediately. Thus s/without that we noticed/without us noticing/ add a test which checks that "-cdrom" can at least be used to start

Re: [Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix

2018-03-15 Thread Su Hang
Sorry about inappropriate example, what I want to express is, when checkpatch.pl find pattern like this: """ for (i = 0; i < 0; ++i) { ; } """ It should raise """ ERROR: that open brace { should be on the previous line #4: FILE: test.c:4: +for (i = 0; i < 0; ++i) +{ """ Instead of: """

Re: [Qemu-devel] [PATCH 7/9] hw/arm/bcm2836: Use correct affinity values for BCM2837

2018-03-15 Thread Philippe Mathieu-Daudé
On 03/13/2018 04:34 PM, Peter Maydell wrote: > The BCM2837 sets the Aff1 field of the MPIDR affinity values for the > CPUs to 0, whereas the BCM2836 uses 0xf. Set this correctly, as it > is required for Linux to boot. > > Signed-off-by: Peter Maydell I don't have the datasheet for this SoC, but

Re: [Qemu-devel] [PATCH] block: Fix leak of ignore_children in error path

2018-03-15 Thread Eric Blake
On 03/14/2018 10:51 PM, Fam Zheng wrote: Reported-by: Max Reitz Signed-off-by: Fam Zheng --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/block.c b/block.c index 75a9fd49de..c1fda9fd57 100644 --- a/block.c +++ b/block.c @@ -3671,12

Re: [Qemu-devel] [PATCH] vvfat: Fix inherit_options flags

2018-03-15 Thread Eric Blake
On 03/14/2018 10:45 PM, Fam Zheng wrote: Overriding flags violates the precedence rules of bdrv_reopen_queue_child. Just like the read-only option, no-flush should be put into the options. The same is done in bdrv_temp_snapshot_options. Reported-by: Stefan Hajnoczi --- block/vvfat.c | 2 +-

Re: [Qemu-devel] [PATCH 6/8] migration: move calling save_zero_page to the common place

2018-03-15 Thread Dr. David Alan Gilbert
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > save_zero_page() is always our first approach to try, move it to > the common place before calling ram_save_compressed_page > and ram_save_page > > Signed-off-by: Xiao Guangrong > --- > migration/ram.c | 10

Re: [Qemu-devel] [PATCH 7/8] migration: introduce save_normal_page()

2018-03-15 Thread Dr. David Alan Gilbert
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > It directly sends the page to the stream neither checking zero nor > using xbzrle or compression > > Signed-off-by: Xiao Guangrong Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 50 +++

Re: [Qemu-devel] [PATCH 9/9] hw/arm/raspi: Provide spin-loop code for AArch64 CPUs

2018-03-15 Thread Philippe Mathieu-Daudé
On 03/13/2018 04:34 PM, Peter Maydell wrote: > The raspi3 has AArch64 CPUs, which means that our smpboot > code for keeping the secondary CPUs in a pen needs to have > a version for A64 as well as A32. Without this, the > secondary CPUs go into an infinite loop of taking undefined > instruction exc

Re: [Qemu-devel] [PATCH 8/8] migration: remove ram_save_compressed_page()

2018-03-15 Thread Dr. David Alan Gilbert
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > Now, we can reuse the path in ram_save_page() to post the page out > as normal, then the only thing remained in ram_save_compressed_page() > is compression that we can move it out to the caller > > Signed-off

[Qemu-devel] [PATCH v2 for-2.12] qapi: Pass '-u' when doing non-silent diff

2018-03-15 Thread Eric Blake
Ed-script diffs are awful compared to context diffs. Fix another 'diff -q' while in the area (if the files are different, being noisy makes it easier to diagnose why). While at it, diff .err before .out, because if a test fails, .err is more likely to contain the most important information for fi

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Fix leak of ignore_children in error path

2018-03-15 Thread Alberto Garcia
On Thu 15 Mar 2018 04:51:57 AM CET, Fam Zheng wrote: > Reported-by: Max Reitz > Signed-off-by: Fam Zheng Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v10 19/24] migration: Create multifd channels

2018-03-15 Thread Juan Quintela
Peter Xu wrote: > On Wed, Mar 07, 2018 at 12:00:05PM +0100, Juan Quintela wrote: >> In both sides. We still don't transmit anything through them. > > s/In/On/? > >> >> Signed-off-by: Juan Quintela >> --- >> migration/ram.c | 52 ++-- >> 1 file ch

Re: [Qemu-devel] [PATCH] linux-user: implement HWCAP bits on MIPS

2018-03-15 Thread Laurent Vivier
Le 15/03/2018 à 11:52, James Cowgill a écrit : > Hi, > > On 14/03/18 16:13, Laurent Vivier wrote: >> Le 14/03/2018 à 16:31, James Cowgill a écrit : >>> Add support for the two currently defined HWCAP bits on MIPS - R6 and >>> MSA. >>> >>> Buglink: https://bugs.launchpad.net/qemu/+bug/1754372 >>> S

Re: [Qemu-devel] [PULL 00/11] M68k for 2.12 patches

2018-03-15 Thread Peter Maydell
On 13 March 2018 at 15:59, Laurent Vivier wrote: > The following changes since commit 59667bb167f773965ce6547352f312eff0d4d523: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' > into staging (2018-03-13 14:02:47 +) > > are available in the Git repository at: >

Re: [Qemu-devel] [PATCH 5/7] block: convert bdrv_invalidate_cache callback to coroutine_fn

2018-03-15 Thread Andreas Schwab
block/iscsi.c:2247:6: error: 'BlockDriver {aka struct BlockDriver}' has no member named 'bdrv_invalidate_cache'; did you mean 'bdrv_co_invalidate_cache'? .bdrv_invalidate_cache = iscsi_invalidate_cache, ^ bdrv_co_invalidate_cache block/iscsi.c:2247:31: error:

[Qemu-devel] [PATCH 01/10] RFC: Add save and support snapshot dependency function to block driver.

2018-03-15 Thread junyan . he
From: Junyan He We want to support incremental snapshot saving, this needs the file system support dependency saving. Later snapshots may ref the dependent snapshot's content, and most time should be cluster aligned. Add a query function to check whether the file system support this, and use the

[Qemu-devel] [PATCH 04/10] RFC: Set memory_region_set_log available for more client.

2018-03-15 Thread junyan . he
From: Junyan He We need to collect dirty log for nvdimm kind memory, need to enable memory_region_set_log for more clients rather than just VGA. Signed-off-by: Junyan He --- memory.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/memory.c b/memory.c index e70b6

[Qemu-devel] [PATCH 07/10] RFC: Add get_current_snapshot_info to get the snapshot state.

2018-03-15 Thread junyan . he
From: Junyan He We need to know the snapshot saving information when we do dependent snapshot saving, e.g the name of previous snapshot. Add this global function to query the snapshot status is usable. Signed-off-by: Junyan He --- include/migration/snapshot.h | 3 +++ migration/savevm.c

[Qemu-devel] [PATCH 00/10] RFC: Optimize nvdimm kind memory for snapshot.

2018-03-15 Thread junyan . he
From: Junyan He The nvdimm size is huge, sometimes it is more than 256G or even more. This is a huge burden for snapshot saving. One snapshot point with nvdimm may occupy more than 50G disk space even with compression enabled. We need to introduce dependent snapshot manner to solve this problem.

[Qemu-devel] [PATCH 10/10] RFC: Enable nvdimm snapshot functions.

2018-03-15 Thread junyan . he
From: Junyan He In snapshot saving, all nvdimm kind memory will be saved in different way and we exclude all nvdimm kind memory region in ram.c Signed-off-by: Junyan He --- migration/ram.c | 17 + vl.c| 1 + 2 files changed, 18 insertions(+) diff --git a/migration

[Qemu-devel] [PATCH v3 1/4] target/ppc: export external HPT via virtual hypervisor

2018-03-15 Thread Cédric Le Goater
commit e57ca75ce3b2 ("target/ppc: Manage external HPT via virtual hypervisor") exported a set of methods to manipulate the HPT from the core hash MMU but the base address of the HPT was not part of them and SPR_SDR1 is still used under some circumstances, which is incorrect for the sPAPR machines.

[Qemu-devel] [PATCH v3 0/4] target/ppc: add hash MMU support for the POWER9 PowerNV machine

2018-03-15 Thread Cédric Le Goater
Hello, This adds support for the Hash Page Table MMU mode on POWER9 PowerNV machines. The Radix Tree mode support for the host is still to be done but we are getting close. Thanks, C. Changes since v2: - extended PPCVirtualHypervisor interface to export the external HPT - added an assert o

[Qemu-devel] [PATCH for-2.12] hw/intc/arm_gicv3: Fix secure-GIC NS ICC_PMR and ICC_RPR accesses

2018-03-15 Thread Peter Maydell
If the GIC has the security extension support enabled, then a non-secure access to ICC_PMR must take account of the non-secure view of interrupt priorities, where real priorities 0..0x7f are secure-only and not visible to the non-secure guest, and priorities 0x80..0xff are shown to the guest as if

[Qemu-devel] [PATCH 03/10] RFC: Implement save and support snapshot dependency in block driver layer.

2018-03-15 Thread junyan . he
From: Junyan He Signed-off-by: Junyan He --- block/snapshot.c | 45 + include/block/snapshot.h | 7 +++ 2 files changed, 52 insertions(+) diff --git a/block/snapshot.c b/block/snapshot.c index eacc1f1..8cc40ac 100644 --- a/block/snapshot

[Qemu-devel] [PATCH v3 2/4] target/ppc: add basic support for PTCR on POWER9

2018-03-15 Thread Cédric Le Goater
The Partition Table Control Register (PTCR) is a hypervisor privileged SPR. It contains the host real address of the Partition Table and its size. Signed-off-by: Cédric Le Goater --- Changes since v2: - added an assert on MMU model in ppc_store_ptcr() - renamed s/ptas/patbsize/ Changes si

[Qemu-devel] [PATCH v3 3/4] target/ppc: add hash MMU support on POWER9 for PowerNV only

2018-03-15 Thread Cédric Le Goater
The HPTE bits definitions are slightly modified in ISA v3.0. Let's add some helpers to hide the differences in the hash MMU code. On a POWER9 processor, the Partition Table is composed of a pair of doublewords per partition. The first doubleword indicates whether the partition uses HPT or Radix Tr

[Qemu-devel] [PATCH 06/10] RFC: Add save dependency functions to qemu_file

2018-03-15 Thread junyan . he
From: Junyan He When we save snapshot, we need qemu_file to support save dependency operations. It should call brv_driver's save dependency functions to implement these operations. Signed-off-by: Junyan He --- migration/qemu-file.c | 61 +++ migr

[Qemu-devel] [PATCH v3 4/4] target/ppc: generalize check on radix when in HV mode

2018-03-15 Thread Cédric Le Goater
On a POWER9 processor, the first doubleword of the partition table entry (as pointed to by the PTCR) indicates whether the host uses HPT or Radix Tree translation for that partition. Use that bit to check for radix mode on pseries and powernv QEMU machines. Signed-off-by: Cédric Le Goater --- C

[Qemu-devel] [PATCH 05/10] RFC: Add memory region snapshot bitmap get function.

2018-03-15 Thread junyan . he
From: Junyan He We need to get the bitmap content of the snapshot when enable dirty log trace for nvdimm. Signed-off-by: Junyan He --- exec.c | 7 +++ include/exec/memory.h | 9 + include/exec/ram_addr.h | 2 ++ memory.c| 7 +++ 4 files change

[Qemu-devel] [PATCH 08/10] RFC: Add a section_id parameter to save_live_iterate call.

2018-03-15 Thread junyan . he
From: Junyan He We need to know the section_id when we do snapshot saving. Add a parameter to save_live_iterate function call. Signed-off-by: Junyan He --- hw/ppc/spapr.c | 2 +- hw/s390x/s390-stattrib.c | 2 +- include/migration/register.h | 2 +- migration/block.c

[Qemu-devel] [PATCH 09/10] RFC: Add nvdimm snapshot saving to migration.

2018-03-15 Thread junyan . he
From: Junyan He The nvdimm size is huge, sometimes is more than 256G or even more. This is a huge burden for snapshot saving. One snapshot point with nvdimm may occupy more than 50G disk space even with compression enabled. We need to introduce dependent snapshot manner to solve this problem. The

[Qemu-devel] [PATCH 02/10] RFC: Implement qcow2's snapshot dependent saving function.

2018-03-15 Thread junyan . he
From: Junyan He For qcow2 format, we can increase the cluster's reference count of dependent snapshot content and link the offset to the L2 table of the new snapshot point. This way can avoid obvious snapshot's dependent relationship, so when we delete some snapshot point, just decrease the clust

[Qemu-devel] [Bug 1748434] Re: Possibly wrong GICv3 behavior when secure enabled

2018-03-15 Thread Peter Maydell
Whoops, yes, we have the wrong condition for ICC_PMR non-secure reads and writes. We also have the same bug in ICC_RPR reads. I'll put together a patch and send it to the mailing list. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. h

Re: [Qemu-devel] [PATCH v4 2/4] migration: API to clear bits of guest free pages from the dirty bitmap

2018-03-15 Thread Michael S. Tsirkin
On Thu, Mar 15, 2018 at 06:52:41PM +0800, Wei Wang wrote: > On 03/15/2018 02:11 AM, Dr. David Alan Gilbert wrote: > > * Wei Wang (wei.w.w...@intel.com) wrote: > > > This patch adds an API to clear bits corresponding to guest free pages > > > from the dirty bitmap. Spilt the free page block if it cr

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v4 3/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-03-15 Thread Michael S. Tsirkin
On Thu, Mar 15, 2018 at 06:24:16PM +0800, Wei Wang wrote: > On 03/15/2018 10:47 AM, Michael S. Tsirkin wrote: > > On Thu, Mar 15, 2018 at 09:15:48AM +0800, Wei Wang wrote: > > > On 03/14/2018 10:12 PM, Michael S. Tsirkin wrote: > > > > On Wed, Mar 14, 2018 at 02:03:19PM +0800, Wei Wang wrote: > > >

Re: [Qemu-devel] [PATCH 00/10] RFC: Optimize nvdimm kind memory for snapshot.

2018-03-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1520930033-18885-1-git-send-email-junyan...@intel.com Subject: [Qemu-devel] [PATCH 00/10] RFC: Optimize nvdimm kind memory for snapshot. === TEST SCRIPT BEGIN === #!/bin/bas

Re: [Qemu-devel] [PATCH v2 for-2.12] iotests: Avoid realpath, for CentOS 6

2018-03-15 Thread Paolo Bonzini
On 15/03/2018 12:51, Eric Blake wrote: > CentOS 6 lacks a realpath binary on the base install, which makes > all iotests runs fail since the 2.11 release: > > 001 - output mismatch (see 001.out.bad) > ./check: line 815: realpath: command not found > diff: missing operand after `/home/dummy

[Qemu-devel] [Bug 1753314] Re: UART in sabrelite machine simulation doesn't work with VxWorks 7

2018-03-15 Thread Peter Maydell
Hi. Thanks for this patch. I've had a quick look at it against the imx datasheet, and here are my comments: * Firstly, we can't do anything with this patch without a Signed-off-by: line from you. In QEMU's process this is how people submitting code state that you're legally OK to contribute the co

Re: [Qemu-devel] [PATCH 00/10] RFC: Optimize nvdimm kind memory for snapshot.

2018-03-15 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1520930033-18885-1-git-send-email-junyan...@intel.com Subject: [Qemu-devel] [PATCH 00/10]

Re: [Qemu-devel] [PATCH] linux-user: implement HWCAP bits on MIPS

2018-03-15 Thread James Cowgill
Hi, On 15/03/18 13:00, Laurent Vivier wrote: > Le 15/03/2018 à 11:52, James Cowgill a écrit : >> Hi, >> >> On 14/03/18 16:13, Laurent Vivier wrote: >>> Le 14/03/2018 à 16:31, James Cowgill a écrit : +enum { +HWCAP_MIPS_R6 = (1 << 0), +HWCAP_MIPS_MSA = (1 <

[Qemu-devel] [PATCH v2] docker: dump 'config.log' if ./configure fails

2018-03-15 Thread Philippe Mathieu-Daudé
Suggested-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- v2: - avoid subshell using { ; } (Eric) - use test_fail() instead of prep_fail() (Fam) tests/docker/common.rc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/docker/c

[Qemu-devel] [PATCH] iscsi: fix iSER compilation

2018-03-15 Thread Paolo Bonzini
This fails in Fedora 28. Reported-by: Andreas Schwab Signed-off-by: Paolo Bonzini --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index a82170f16e..f5aecfc883 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -2244,7 +2244,7 @@

Re: [Qemu-devel] [PATCH] docker: fedora: test more components

2018-03-15 Thread Philippe Mathieu-Daudé
On 03/13/2018 01:33 PM, Fam Zheng wrote: > On Tue, 03/13 13:05, Paolo Bonzini wrote: >> Install optional dependencies of QEMU to get better coverage. >> >> Signed-off-by: Paolo Bonzini >> --- >> tests/docker/dockerfiles/fedora.docker | 13 ++--- >> 1 file changed, 10 insertions(+), 3 dele

Re: [Qemu-devel] [PATCH] linux-user: implement HWCAP bits on MIPS

2018-03-15 Thread Laurent Vivier
Le 15/03/2018 à 15:19, James Cowgill a écrit : > Hi, > > On 15/03/18 13:00, Laurent Vivier wrote: >> Le 15/03/2018 à 11:52, James Cowgill a écrit : >>> Hi, >>> >>> On 14/03/18 16:13, Laurent Vivier wrote: Le 14/03/2018 à 16:31, James Cowgill a écrit : > +enum { > +HWCAP_MIPS_R6

[Qemu-devel] [Bug 1755479] Re: Cortex M:qemu abort with optimized code and icount

2018-03-15 Thread philmd
Hey Antoine, do you mind replying to the list thread with a single line such: Tested-by: Antoine Calando This will help the code review and the patch will probably get merged faster. Thanks. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

Re: [Qemu-devel] [PATCH] docker: fedora: test more components

2018-03-15 Thread Daniel P . Berrangé
On Tue, Mar 13, 2018 at 01:05:52PM +0100, Paolo Bonzini wrote: > Install optional dependencies of QEMU to get better coverage. > > Signed-off-by: Paolo Bonzini > --- > tests/docker/dockerfiles/fedora.docker | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/

[Qemu-devel] [Bug 1751674] Re: qemu-system-arm segmentation fault trying to dump VM memory

2018-03-15 Thread Peter Maydell
What's happening here is that the memory range you're asking to dump (physaddrs 0 to 0x3fff) includes a lot of devices, including the interrupt controller, which is at 0x1e00. There's a longstanding bug in the GIC code where it will crash if you try to access its per-CPU register bank from

[Qemu-devel] [Bug 1755479] Re: Cortex M:qemu abort with optimized code and icount

2018-03-15 Thread Peter Maydell
That's not really necessary as the patch is already in Paolo's pull request. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1755479 Title: Cortex M:qemu abort with optimized code and icount Status

Re: [Qemu-devel] [Qemu-block] [PATCH v2 for-2.12] iotests: Avoid realpath, for CentOS 6

2018-03-15 Thread Jeff Cody
On Thu, Mar 15, 2018 at 06:51:44AM -0500, Eric Blake wrote: > CentOS 6 lacks a realpath binary on the base install, which makes > all iotests runs fail since the 2.11 release: > > 001 - output mismatch (see 001.out.bad) > ./check: line 815: realpath: command not found > diff: missing opera

[Qemu-devel] [Bug 1751674] Re: qemu-system-arm segmentation fault trying to dump VM memory

2018-03-15 Thread Peter Maydell
LP:1602247 is the bug for the similar issue when using the gdb stub. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1751674 Title: qemu-system-arm segmentation fault trying to dump VM memory Status

[Qemu-devel] [Bug 1746943] Re: qemu-aarch64-static: qemu: uncaught target signal 11 for ps/top cmd

2018-03-15 Thread Peter Maydell
Could you provide instructions to reproduce that don't require Fedora or docker, please? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1746943 Title: qemu-aarch64-static: qemu: uncaught target sign

[Qemu-devel] [Bug 1602247] Re: SIGSEGV when reading ARM GIC registers through GDB stub

2018-03-15 Thread Peter Maydell
See also LP:1751674 -- similar crash trying to access the GICv2 per-cpu regs from the QEMU monitor's pmemsave command. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1602247 Title: SIGSEGV when read

Re: [Qemu-devel] [PATCH v2 for-2.12] iotests: Avoid realpath, for CentOS 6

2018-03-15 Thread Philippe Mathieu-Daudé
On 03/15/2018 12:51 PM, Eric Blake wrote: > CentOS 6 lacks a realpath binary on the base install, which makes > all iotests runs fail since the 2.11 release: > > 001 - output mismatch (see 001.out.bad) > ./check: line 815: realpath: command not found > diff: missing operand after `/home/du

Re: [Qemu-devel] [PULL 0/3] Reduce Travis timeouts

2018-03-15 Thread Peter Maydell
On 13 March 2018 at 16:46, Alex Bennée wrote: > The following changes since commit 22ef7ba8e8ce7fef297549b3defcac333742b804: > > Merge remote-tracking branch 'remotes/famz/tags/staging-pull-request' into > staging (2018-03-13 11:42:45 +) > > are available in the Git repository at: > > htt

[Qemu-devel] [PATCH v2] linux-user: implement HWCAP bits on MIPS

2018-03-15 Thread James Cowgill
Add support for the two currently defined HWCAP bits on MIPS - R6 and MSA. Buglink: https://bugs.launchpad.net/qemu/+bug/1754372 Signed-off-by: James Cowgill --- v2 changes: - Fix kernel hwcap.h path. linux-user/elfload.c | 24 1 file changed, 24 insertions(+) diff --

[Qemu-devel] [Bug 1748434] Re: Possibly wrong GICv3 behavior when secure enabled

2018-03-15 Thread Peter Maydell
Patch which should fix this: https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg04537.html ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1

Re: [Qemu-devel] [PATCH v2] linux-user: implement HWCAP bits on MIPS

2018-03-15 Thread Laurent Vivier
Le 15/03/2018 à 16:13, James Cowgill a écrit : > Add support for the two currently defined HWCAP bits on MIPS - R6 and > MSA. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1754372 > Signed-off-by: James Cowgill > --- > v2 changes: > - Fix kernel hwcap.h path. > > linux-user/elfload.c | 24

[Qemu-devel] [Bug 1749393] Re: sbrk() not working under qemu-user with a PIE-compiled binary?

2018-03-15 Thread Matthias Klose
** Also affects: qemu (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1749393 Title: sbrk() not working under qemu-user with a PIE-compiled binary

[Qemu-devel] [Bug 1756080] [NEW] QEMU does not provide non-Linux kernels with ATAGS structure on ARM targets

2018-03-15 Thread barry.of.smith--- via Qemu-devel
Public bug reported: This would be a useful feature. Many kernels, particularly hobbyist kernels, have support for ATAGS. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEM

  1   2   >