Re: [Qemu-devel] [PATCH] vl: introduce vm_shutdown()

2018-02-23 Thread Fam Zheng
On Tue, 02/20 13:10, Stefan Hajnoczi wrote: > 1. virtio_scsi_handle_cmd_vq() racing with iothread_stop_all() hits the >virtio_scsi_ctx_check() assertion failure because the BDS AioContext >has been modified by iothread_stop_all(). Does this patch fix the issue completely? IIUC virtio_scsi_

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a OpenBSD maintainer

2018-02-23 Thread Fam Zheng
On Fri, 02/16 14:44, Philippe Mathieu-Daudé wrote: > On 02/16/2018 02:41 PM, Kamil Rytarowski wrote: > > On 16.02.2018 18:30, Philippe Mathieu-Daudé wrote: > >> But before announcing the host OS being supported again, I'd rather see > >> reproducible build/tests logs, in a (public - if possible) co

Re: [Qemu-devel] [PATCH v3 1/3] util/uri.c: replace TAB with whitespace

2018-02-23 Thread Thomas Huth
Hi, thanks for splitting your patch in more reviewable parts :-) Meta-comment: If you send a patch series, please include a cover letter next time ("PATCH 0/3") with a brief summary. Then the patch series shows up nicely as a thread in the e-mail programs of the reviewers (you also got to send o

Re: [Qemu-devel] [PATCH v3 2/3] util/uri.c: only remove `return`'s brackets

2018-02-23 Thread Thomas Huth
On 23.02.2018 08:51, Su Hang wrote: > only remove brackets that wrap `return` statements' content. > > use `perl -pi -e "s/return \((.*?)\);/return \1;/g" util/uri.c` > to remove pattern like this: "return (1);" > > Signed-off-by: Su Hang > --- > util/uri.c | 160 >

Re: [Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Christian Borntraeger
Hmmm, on my ubuntu 16.04 guest, I get the boot menu with no timeout even if I do not specify loadparm or boot menu: qemu-kvm -drive file=/var/lib/libvirt/qemu/image.zhyp140,if=none,id=d1 -device virtio-blk-ccw,drive=d1,bootindex=1 LOADPARM=[] Using virtio-blk. Using SCSI scheme. s390x

Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState

2018-02-23 Thread Gerd Hoffmann
Hi, > > What type of device is only sometimes hotpluggable ? > > The commit message says "display devices" and "consoles", > > but I would expect those to both be types of device which > > have a class which is never hotpluggable, so you can mark > > them non-hotpluggable with the existing class

Re: [Qemu-devel] [PATCH v4 0/7] vfio: add display support

2018-02-23 Thread Gerd Hoffmann
> Hi Gerd, > > It's a little bit concerning that the only way we can test the > region-based display support is with proprietary drivers that nobody > but NVIDIA has at this point. Have you considered adding region-based > display support to the mdev sample tty driver? I know it sounds > ridicul

[Qemu-devel] [Bug 1636217] Re: qemu-kvm 2.7 does not boot kvm VMs with virtio on top of VMware ESX

2018-02-23 Thread zzfancy
we still meet similar issue on centos.7 (qemu 2.9.0-16.el7_4.5.1 + libvirt 3.2.0-14.el7_4.3) my workaround including: a) without kvm accel or b) as comment #7 said "-machine type=pc-i440fx-x" where x <= 2.6 or c) with pci device "disable-modern=on" i found the function _farcall16 in seabios was

Re: [Qemu-devel] [PATCH v3 3/3] util/uri.c: add brackets to `if` statements

2018-02-23 Thread Thomas Huth
On 23.02.2018 08:51, Su Hang wrote: > Add brackets that wrap `if`, `else`, `while` that hold single > statements. > > In order to do this, I write a simple python regex script. > > Since then, all complaints rised by checkpatch.pl has been suppressed. > > Signed-off-by: Su Hang > --- > util/ur

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-23 Thread Cornelia Huck
On Thu, 22 Feb 2018 14:29:09 -0500 Matthew Rosato wrote: > On 02/22/2018 06:13 AM, Christian Borntraeger wrote: > > > > > > On 02/21/2018 06:39 PM, Cornelia Huck wrote: > >> On Tue, 20 Feb 2018 16:05:54 +0100 > >> David Hildenbrand wrote: > >> > >>> On 20.02.2018 15:57, Cornelia Huck wrote

Re: [Qemu-devel] [PATCH v2 32/32] arm/translate-a64: add all single op FP16 to handle_fp_1src_half

2018-02-23 Thread Alex Bennée
Richard Henderson writes: > On 02/08/2018 09:31 AM, Alex Bennée wrote: >> This includes FMOV, FABS, FNEG, FSQRT and FRINT[NPMZAXI]. We re-use >> existing helpers to achieve this. >> >> Signed-off-by: Alex Bennée >> --- >> target/arm/translate-a64.c | 72 >> +++

[Qemu-devel] [PATCH] s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define

2018-02-23 Thread Cornelia Huck
It's already defined in cpu.h (to the same value) and not used in the sclp code. Signed-off-by: Cornelia Huck --- include/hw/s390x/sclp.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h index 476cbf78f2..f9db243484 100644 --- a/include/hw/s390

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 07/67] target/arm: Implement SVE Predicate Logical Operations Group

2018-02-23 Thread Peter Maydell
On 22 February 2018 at 19:37, Richard Henderson wrote: > On 02/22/2018 10:55 AM, Peter Maydell wrote: >>> +# Three prediate operand, with governing predicate, flag setting >> >> Three what? > > Feh, typo for predicate. Oh, right -- I'd thought it might be some mashup/typo of something-immediate.

Re: [Qemu-devel] [PATCH v3 5/5] aarch64-linux-user: Add support for SVE signal frame records

2018-02-23 Thread Peter Maydell
On 22 February 2018 at 20:14, Richard Henderson wrote: > On 02/22/2018 08:41 AM, Peter Maydell wrote: >> On 16 February 2018 at 21:56, Richard Henderson >> wrote: >>> +if (sve_size <= std_size) { >>> +sve_ofs = size; >>> +size += sve_size; >>> +end1_of

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define

2018-02-23 Thread Christian Borntraeger
On 02/23/2018 10:54 AM, Cornelia Huck wrote: > It's already defined in cpu.h (to the same value) and not used in > the sclp code. > > Signed-off-by: Cornelia Huck > --- > include/hw/s390x/sclp.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x

Re: [Qemu-devel] [PULL 00/32] target-arm queue

2018-02-23 Thread Peter Maydell
On 22 February 2018 at 15:22, Peter Maydell wrote: > Latest run of arm patches -- most of these are Philippe's SD card > cleanups. I have more in my queue to review, but 32 is enough > patches to warrant sending out. > > thanks > -- PMM > > The following changes since commit ff8689611a1d954897d857

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Thomas Huth
On 22.02.2018 20:40, Collin L. Walling wrote: > On 02/22/2018 11:45 AM, Collin L. Walling wrote: >> On 02/22/2018 10:44 AM, Christian Borntraeger wrote: >>> >>> On 02/22/2018 04:40 PM, Collin L. Walling wrote: On 02/22/2018 07:23 AM, Viktor Mihajlovski wrote: > On 22.02.2018 12:51, Christi

Re: [Qemu-devel] [PATCH v6 00/23] RISC-V QEMU Port Submission

2018-02-23 Thread Daniel P . Berrangé
On Fri, Feb 23, 2018 at 01:11:46PM +1300, Michael Clark wrote: > QEMU RISC-V Emulation Support (RV64GC, RV32GC) > > This is hopefully the "fix remaining issues in-tree" release. This code seems to be a mixture of LGPLv2+ and MIT licensed code. The preferred license for QEMU contributions is GPLv2

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define

2018-02-23 Thread Cornelia Huck
On Fri, 23 Feb 2018 11:02:15 +0100 Christian Borntraeger wrote: > On 02/23/2018 10:54 AM, Cornelia Huck wrote: > > It's already defined in cpu.h (to the same value) and not used in > > the sclp code. > > > > Signed-off-by: Cornelia Huck > > --- > > include/hw/s390x/sclp.h | 1 - > > 1 file cha

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Christian Borntraeger
On 02/23/2018 11:07 AM, Thomas Huth wrote: > On 22.02.2018 20:40, Collin L. Walling wrote: >> On 02/22/2018 11:45 AM, Collin L. Walling wrote: >>> On 02/22/2018 10:44 AM, Christian Borntraeger wrote: On 02/22/2018 04:40 PM, Collin L. Walling wrote: > On 02/22/2018 07:23 AM, Viktor M

Re: [Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Thomas Huth
On 23.02.2018 09:53, Christian Borntraeger wrote: > Hmmm, on my ubuntu 16.04 guest, I get the boot menu with no timeout even if I > do not > specify loadparm or boot menu: > > qemu-kvm -drive file=/var/lib/libvirt/qemu/image.zhyp140,if=none,id=d1 > -device virtio-blk-ccw,drive=d1,bootindex=1

[Qemu-devel] [PATCH] s390x: remove s390_get_memslot_count

2018-02-23 Thread Cornelia Huck
Not needed anymore after removal of the memory hotplug code. Signed-off-by: Cornelia Huck --- include/hw/s390x/sclp.h | 1 - target/s390x/cpu.c | 9 - target/s390x/cpu.h | 4 target/s390x/kvm-stub.c | 5 - target/s390x/kvm.c | 5 - target/s390x/kvm_s390x.

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x: remove s390_get_memslot_count

2018-02-23 Thread Christian Borntraeger
On 02/23/2018 11:19 AM, Cornelia Huck wrote: > Not needed anymore after removal of the memory hotplug code. > > Signed-off-by: Cornelia Huck Acked-by: Christian Borntraeger > --- > include/hw/s390x/sclp.h | 1 - > target/s390x/cpu.c | 9 - > target/s390x/cpu.h | 4 >

Re: [Qemu-devel] [PATCH v2 20/32] arm/translate-a64: add FP16 FCMxx (zero) to simd_two_reg_misc_fp16

2018-02-23 Thread Alex Bennée
Richard Henderson writes: > On 02/22/2018 09:23 AM, Alex Bennée wrote: >> >> Richard Henderson writes: >> >>> On 02/08/2018 09:31 AM, Alex Bennée wrote: +maxpasses = hp ? (is_q ? 8 : 4) : (is_q ? 4 : 2); >>> >>> (8 << is_q) >> size >>> >>> ? >> >> Hmm I'm not so sure about th

Re: [Qemu-devel] [PATCH] iotests: Test abnormally large size in compressed cluster descriptor

2018-02-23 Thread Alberto Garcia
On Thu 22 Feb 2018 08:00:08 PM CET, Eric Blake wrote: >> One consequence of this is that even if the size field is larger than >> it needs to be QEMU can handle it just fine: it will read more data >> from disk but it will ignore the extra bytes. > > (is that true even for the corner case when the

Re: [Qemu-devel] [PATCH v2 1/3] s390x/sclp: proper support of larger send and receive masks

2018-02-23 Thread Cornelia Huck
On Thu, 22 Feb 2018 17:22:57 +0100 Claudio Imbrenda wrote: > Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length event masks") > we only supported sclp event masks of size exactly 4 bytes, even though s/of size/of a size of/ > the archiecture allows the guests to set up sclp event

Re: [Qemu-devel] [PATCH v2 0/3] s390x/sclp: 64 bit event masks

2018-02-23 Thread Cornelia Huck
On Thu, 22 Feb 2018 17:22:56 +0100 Claudio Imbrenda wrote: > Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length event masks") > we only supported 32bit sclp event masks, even though the archiecture > allows the guests to set up sclp event masks up to 1021 bytes in length. > With tha

Re: [Qemu-devel] [PATCH] s390x: remove s390_get_memslot_count

2018-02-23 Thread David Hildenbrand
On 23.02.2018 11:19, Cornelia Huck wrote: > Not needed anymore after removal of the memory hotplug code. > > Signed-off-by: Cornelia Huck > --- > include/hw/s390x/sclp.h | 1 - > target/s390x/cpu.c | 9 - > target/s390x/cpu.h | 4 > target/s390x/kvm-stub.c | 5 - >

Re: [Qemu-devel] [PATCH v2 1/3] s390x/sclp: proper support of larger send and receive masks

2018-02-23 Thread Claudio Imbrenda
On Fri, 23 Feb 2018 11:31:46 +0100 Cornelia Huck wrote: > On Thu, 22 Feb 2018 17:22:57 +0100 > Claudio Imbrenda wrote: > > > Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length > > event masks") we only supported sclp event masks of size exactly 4 > > bytes, even though > > s/of

Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage

2018-02-23 Thread Paolo Bonzini
On 22/02/2018 18:06, John Snow wrote: > > > On 02/22/2018 05:57 AM, Kevin Wolf wrote: >> Am 20.02.2018 um 22:54 hat Paolo Bonzini geschrieben: >>> On 20/02/2018 18:04, Peter Lieven wrote: Hi, I remember we discussed a long time ago to limit the stack usage of all functions tha

Re: [Qemu-devel] [PATCH v2 0/3] s390x/sclp: 64 bit event masks

2018-02-23 Thread Claudio Imbrenda
On Fri, 23 Feb 2018 11:37:55 +0100 Cornelia Huck wrote: > On Thu, 22 Feb 2018 17:22:56 +0100 > Claudio Imbrenda wrote: > > > Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length > > event masks") we only supported 32bit sclp event masks, even though > > the archiecture allows the gu

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 08/67] target/arm: Implement SVE Predicate Misc Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 3 + > target/arm/helper-sve.h| 3 + > target/arm/sve_helper.c| 86 +++- > target/arm/translate-sve.c | 163 > +

[Qemu-devel] [PATCH] loader: don't perform overlapping address check for memory region ROM images

2018-02-23 Thread Mark Cave-Ayland
All memory region ROM images have a base address of 0 which causes the overlapping address check to fail if more than one memory region ROM image is present, or an existing ROM image is loaded at address 0. Make sure that we ignore the overlapping address check in rom_check_and_register_reset() i

Re: [Qemu-devel] [PATCH qemu repost] qmp: Add qom-list-properties to list QOM object properties

2018-02-23 Thread Paolo Bonzini
On 22/02/2018 06:00, Alexey Kardashevskiy wrote: > There is already 'device-list-properties' which does most of the job, > however it does not handle everything returned by qom-list-types such > as machines as they inherit directly from TYPE_OBJECT and not TYPE_DEVICE. > > This adds a new qom-list

Re: [Qemu-devel] [PATCH v2 09/67] target/arm: Implement SVE Integer Binary Arithmetic - Predicated Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 145 + > target/arm/sve_helper.c| 196 > - > target/arm/translate-sve.c | 65 ++

Re: [Qemu-devel] [PATCH 0/6] vhost-user-test and leak fixes

2018-02-23 Thread Paolo Bonzini
On 15/02/2018 22:25, Marc-André Lureau wrote: > Hi, > > The following patches fix a regression introduced in commit > 218bb57dd79d that prevent ASAN from being detected & used. There is > also a works around for a GCC ASAN optimization bug. A few test leaks > are fixed, and a few patches reenable

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 03/67] target/arm: Add SVE decode skeleton

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Including only 4, as-yet unimplemented, instruction patterns > so that the whole thing compiles. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 11 +++- > target/arm/translate-sve.c | 63 > ++

Re: [Qemu-devel] [PULL 0/1] Add decodetree.py

2018-02-23 Thread Peter Maydell
On 22 February 2018 at 23:49, Richard Henderson wrote: > The following changes since commit ff8689611a1d954897d857b28f7ef404e11cfa2c: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-signed' > into staging (2018-02-22 11:37:05 +) > > are available in the Git repository

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 03/67] target/arm: Add SVE decode skeleton

2018-02-23 Thread Peter Maydell
On 23 February 2018 at 11:40, Peter Maydell wrote: > I realized while working through the rest of the series that this is > too early to do the sve_access_check() and fp_access_check(). Those > only apply to instructions which actually exist, so we mustn't > do the checks until after we've dealt w

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 10/67] target/arm: Implement SVE Integer Reduction Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Excepting MOVPRFX, which isn't a reduction. Presumably it is > placed within the group because of its encoding. > > Signed-off-by: Richard Henderson > @@ -306,8 +399,6 @@ DO_ZPZZ_D(sve_udiv_zpzz_d, uint64_t, DO_DIV) > #undef DO_ABD > #

Re: [Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Viktor Mihajlovski
On 23.02.2018 11:17, Thomas Huth wrote: > On 23.02.2018 09:53, Christian Borntraeger wrote: >> Hmmm, on my ubuntu 16.04 guest, I get the boot menu with no timeout even if >> I do not >> specify loadparm or boot menu: >> >> qemu-kvm -drive file=/var/lib/libvirt/qemu/image.zhyp140,if=none,id=d1 >>

Re: [Qemu-devel] [PATCH v2 11/32] arm/translate-a64: add FP16 F[A]C[EQ/GE/GT] to simd_three_reg_same_fp16

2018-02-23 Thread Alex Bennée
Richard Henderson writes: > On 02/08/2018 09:31 AM, Alex Bennée wrote: >> Signed-off-by: Alex Bennée >> --- >> target/arm/helper-a64.c| 49 >> ++ >> target/arm/helper-a64.h| 5 + >> target/arm/translate-a64.c | 15 ++ >> 3 f

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 11/67] target/arm: Implement SVE bitwise shift by immediate (predicated)

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 25 + > target/arm/sve_helper.c| 265 > + > target/arm/translate-sve.c | 128 ++ > target/arm/s

Re: [Qemu-devel] [PATCH 0/6] vhost-user-test and leak fixes

2018-02-23 Thread Marc-André Lureau
Hi On Fri, Feb 23, 2018 at 12:37 PM, Paolo Bonzini wrote: > On 15/02/2018 22:25, Marc-André Lureau wrote: >> Hi, >> >> The following patches fix a regression introduced in commit >> 218bb57dd79d that prevent ASAN from being detected & used. There is >> also a works around for a GCC ASAN optimiza

Re: [Qemu-devel] [PATCH] s390x: remove s390_get_memslot_count

2018-02-23 Thread Cornelia Huck
On Fri, 23 Feb 2018 11:19:19 +0100 Cornelia Huck wrote: > Not needed anymore after removal of the memory hotplug code. > > Signed-off-by: Cornelia Huck > --- > include/hw/s390x/sclp.h | 1 - > target/s390x/cpu.c | 9 - > target/s390x/cpu.h | 4 > target/s390x/kvm-stub

[Qemu-devel] [PATCH v3 0/3] s390x/sclp: 64 bit event masks

2018-02-23 Thread Claudio Imbrenda
Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length event masks") we only supported 32bit sclp event masks, even though the archiecture allows the guests to set up sclp event masks up to 1021 bytes in length. With that patch the behaviour was almost compliant, but some issues were stil

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 12/67] target/arm: Implement SVE bitwise shift by vector (predicated)

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

[Qemu-devel] [PATCH v2] iotests: Test abnormally large size in compressed cluster descriptor

2018-02-23 Thread Alberto Garcia
L2 entries for compressed clusters have a field that indicates the number of sectors used to store the data in the image. That's however not the size of the compressed data itself, just the number of sectors where that data is located. The actual data size is usually not a multiple of the sector s

[Qemu-devel] [PATCH v3 2/3] s390x/sclp: clean up sclp masks

2018-02-23 Thread Claudio Imbrenda
Introduce an sccb_mask_t to be used for SCLP event masks instead of just unsigned int or uint32_t. This will allow later to extend the mask with more ease. Signed-off-by: Claudio Imbrenda --- hw/char/sclpconsole-lm.c | 4 ++-- hw/char/sclpconsole.c | 4 ++-- hw/s390x/event

[Qemu-devel] [PATCH v3 1/3] s390x/sclp: proper support of larger send and receive masks

2018-02-23 Thread Claudio Imbrenda
Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length event masks") we only supported sclp event masks with a size of exactly 4 bytes, even though the architecture allows the guests to set up sclp event masks from 1 to 1021 bytes in length. After that patch, the behaviour was almost comp

[Qemu-devel] [PATCH v3 3/3] s390x/sclp: extend SCLP event masks to 64 bits

2018-02-23 Thread Claudio Imbrenda
Extend the SCLP event masks to 64 bits. Notice that using any of the new bits results in a state that cannot be migrated to an older version. Signed-off-by: Claudio Imbrenda --- hw/s390x/event-facility.c | 50 --- include/hw/s390x/event-facility.h |

Re: [Qemu-devel] [PATCH v2 13/67] target/arm: Implement SVE bitwise shift by wide elements (predicated)

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 21 + > target/arm/sve_helper.c| 35 +++ > target/arm/translate-sve.c | 25 + > target/ar

[Qemu-devel] [Bug 1751264] [NEW] qemu-img convert issue in a tmpfs partition

2018-02-23 Thread Teddy VALETTE
Public bug reported: qemu-img convert command is slow when the file to convert is located in a tmpfs formatted partition. v2.1.0 on debian/jessie x64, ext4: 10m14s v2.1.0 on debian/jessie x64, tmpfs: 10m15s v2.1.0 on debian/stretch x64, ext4: 11m9s v2.1.0 on debian/stretch x64, tmpfs: 10m21.362s

Re: [Qemu-devel] [PATCH v3 0/3] s390x/sclp: 64 bit event masks

2018-02-23 Thread Cornelia Huck
On Fri, 23 Feb 2018 13:51:02 +0100 Claudio Imbrenda wrote: > Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length event masks") > we only supported 32bit sclp event masks, even though the archiecture > allows the guests to set up sclp event masks up to 1021 bytes in length. > With tha

[Qemu-devel] Intermittent failure of iotest 203

2018-02-23 Thread Max Reitz
Hi, iotest 203 relatively often fails for me, at least when run in parallel. When I run the following concurrently on four shells: $ while TEST_DIR=/tmp/t1 ./check -T -qcow2 203; do; done $ while TEST_DIR=/tmp/t2 ./check -T -qcow2 203; do; done $ while TEST_DIR=/tmp/t3 ./check -T -qcow2 203; do;

Re: [Qemu-devel] [PATCH v2 14/67] target/arm: Implement SVE Integer Arithmetic - Unary Predicated Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 60 + > target/arm/sve_helper.c| 127 > + > target/arm/translate-sve.c | 111 ++

Re: [Qemu-devel] [PATCH v2 15/67] target/arm: Implement SVE Integer Multiply-Add Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 18 ++ > target/arm/sve_helper.c| 58 > +- > target/arm/translate-sve.c | 31 + > ta

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 16/67] target/arm: Implement SVE Integer Arithmetic - Unpredicated Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/translate-sve.c | 41 ++--- > target/arm/sve.decode | 13 + > 2 files changed, 51 insertions(+), 3 deletions(-) > @@ -254,7 +288,8 @@

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 17/67] target/arm: Implement SVE Index Generation Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 5 > target/arm/sve_helper.c| 40 +++ > target/arm/translate-sve.c | 67 > ++ > target/arm

[Qemu-devel] [PATCH 2/7] ovmf: link with Tcg2ConfigPei module

2018-02-23 Thread marcandre . lureau
From: Marc-André Lureau This module initializes TPM device type based on variable and detection. The module requires VariablePei, which is built with MEM_VARSTORE_EMU_ENABLE=FALSE. CC: Laszlo Ersek CC: Stefan Berger Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marc-A

[Qemu-devel] [PATCH 4/7] ovmf: link with Tcg2Pei module

2018-02-23 Thread marcandre . lureau
From: Marc-André Lureau This module will initialize TPM device, measure reported FVs and BIOS version. CC: Laszlo Ersek CC: Stefan Berger Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marc-André Lureau --- OvmfPkg/OvmfPkgX64.dsc | 7 +++ OvmfPkg/OvmfPkgX64.fdf |

[Qemu-devel] [PATCH 3/7] HACK: HobLib: workaround infinite loop

2018-02-23 Thread marcandre . lureau
From: Marc-André Lureau Without this hack, GetNextHob() loops infinitely with the next patch. I don't understand the reason. The loop is triggered by the GetFirstGuidHob (&gTpmErrorHobGuid) call. CC: Laszlo Ersek CC: Stefan Berger Contributed-under: TianoCore Contribution Agreement 1.0 Signed

[Qemu-devel] [PATCH 0/7] RFC: ovmf: preliminary TPM2 support

2018-02-23 Thread marcandre . lureau
From: Marc-André Lureau Hi, The following series adds basic TPM2 support for OVMF-on-QEMU (I haven't tested TPM1, for lack of interest). It links with the modules to initializes the device in PEI phase, and do measurements (both PEI and DXE). The Tcg2Dxe module provides the Tcg2 protocol which a

Re: [Qemu-devel] [PATCH v2 18/67] target/arm: Implement SVE Stack Allocation Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/translate-sve.c | 24 > target/arm/sve.decode | 12 > 2 files changed, 36 insertions(+) Reviewed-by: Peter Maydell thanks -- PMM

[Qemu-devel] [PATCH 1/7] SecurityPkg/Tcg2Pei: drop Tcg2PhysicalPresenceLib dependency

2018-02-23 Thread marcandre . lureau
From: Marc-André Lureau Apparently, unnecessary. Avoids extra build dependency and churn. CC: Laszlo Ersek CC: Stefan Berger Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marc-André Lureau --- SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 2 -- SecurityPkg/Tcg/Tcg2Pei/Tcg2Pe

[Qemu-devel] [PATCH 5/7] ovmf: link with Tcg2Dxe module

2018-02-23 Thread marcandre . lureau
From: Marc-André Lureau This module measures and log the boot environment. It also produces the Tcg2 protocol, which allows for example to read the log from OS: [0.00] efi: EFI v2.70 by EDK II [0.00] efi: SMBIOS=0x3fa1f000 ACPI=0x3fbb6000 ACPI 2.0=0x3fbb6014 MEMATTR=0x3e7d43

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 19/67] target/arm: Implement SVE Bitwise Shift - Unpredicated Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 12 +++ > target/arm/sve_helper.c| 30 + > target/arm/translate-sve.c | 81 > ++ > target/arm/sve.de

[Qemu-devel] [PATCH 6/7] ovmf: link with Tcg2ConfigDxe module

2018-02-23 Thread marcandre . lureau
From: Marc-André Lureau The module allows to tweak and interact with the TPM. Note that many actions are broken due to implementation of qemu TPM (providing it's own ACPI table), and the lack of PPI implementation. CC: Laszlo Ersek CC: Stefan Berger Contributed-under: TianoCore Contribution Ag

Re: [Qemu-devel] [PATCH v2] iotests: Test abnormally large size in compressed cluster descriptor

2018-02-23 Thread Eric Blake
On 02/23/2018 06:50 AM, Alberto Garcia wrote: L2 entries for compressed clusters have a field that indicates the number of sectors used to store the data in the image. That's however not the size of the compressed data itself, just the number of sectors where that data is located. The actual dat

[Qemu-devel] [PATCH 7/7] ovmf: add DxeTpm2MeasureBootLib

2018-02-23 Thread marcandre . lureau
From: Marc-André Lureau The library registers a security management handler, to measure images that are not measure in PEI phase. This seems to work for example with the qemu PXE rom: Loading driver at 0x0003E6C2000 EntryPoint=0x0003E6C9076 8086100e.efi And the following binary_bios_measuremen

Re: [Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Thomas Huth
On 23.02.2018 12:50, Viktor Mihajlovski wrote: > On 23.02.2018 11:17, Thomas Huth wrote: >> On 23.02.2018 09:53, Christian Borntraeger wrote: >>> Hmmm, on my ubuntu 16.04 guest, I get the boot menu with no timeout even if >>> I do not >>> specify loadparm or boot menu: >>> >>> qemu-kvm -drive fil

Re: [Qemu-devel] [PATCH v2 1/2] iotest 033: add misaligned write-zeroes test via truncate

2018-02-23 Thread Max Reitz
On 2018-02-12 14:14, Anton Nefedov wrote: > This new test case only makes sense for qcow2 while iotest 033 is generic; > however it matches the test purpose perfectly and also 033 contains those > do_test() tricks to pass the alignment, which won't look nice being > duplicated in other tests or mov

Re: [Qemu-devel] [PATCH v2 20/67] target/arm: Implement SVE Compute Vector Address Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 5 + > target/arm/sve_helper.c| 40 > target/arm/translate-sve.c | 33 + > target/arm/s

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 21/67] target/arm: Implement SVE floating-point exponential accelerator

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 4 +++ > target/arm/sve_helper.c| 81 > ++ > target/arm/translate-sve.c | 22 + > target/arm/sve.decode

Re: [Qemu-devel] [PATCH] qemu-img: Make resize error message more general

2018-02-23 Thread Max Reitz
On 2018-02-05 17:27, Max Reitz wrote: > The issue: > > $ qemu-img resize -f qcow2 foo.qcow2 > qemu-img: Expecting one image file name > Try 'qemu-img --help' for more information > > So we gave an image file name, but we omitted the length. qemu-img > thinks the last argument is always the

Re: [Qemu-devel] [PATCH 0/3] block/ssh: Add basic .bdrv_truncate()

2018-02-23 Thread Max Reitz
On 2018-02-14 21:49, Max Reitz wrote: > For (x-)blockdev-create, all protocol drivers that support image > creation also need to offer a .bdrv_truncate() implementation that > matches in features. A previous series of mine brought gluster's and > sheepdog's implementation up to par regarding preal

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 22/67] target/arm: Implement SVE floating-point trig select coefficient

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 4 > target/arm/sve_helper.c| 43 +++ > target/arm/translate-sve.c | 19 +++ > target/arm/sve.decode

Re: [Qemu-devel] [PATCH v3] qcow2: Replace align_offset() with ROUND_UP()

2018-02-23 Thread Max Reitz
On 2018-02-15 14:10, Alberto Garcia wrote: > The align_offset() function is equivalent to the ROUND_UP() macro so > there's no need to use the former. The ROUND_UP() name is also a bit > more explicit. > > This patch uses ROUND_UP() instead of the slower QEMU_ALIGN_UP() > because align_offset() al

Re: [Qemu-devel] [PATCH v2 23/67] target/arm: Implement SVE Element Count Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 11 ++ > target/arm/sve_helper.c| 136 ++ > target/arm/translate-sve.c | 274 > - > target/arm/sve.

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 24/67] target/arm: Implement SVE Bitwise Immediate Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/translate-sve.c | 50 > ++ > target/arm/sve.decode | 17 > 2 files changed, 67 insertions(+) Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH 4/6] vhost-user-test: do not hang if chardev creation failed

2018-02-23 Thread Maxime Coquelin
On 02/15/2018 10:25 PM, Marc-André Lureau wrote: Before the chardev name fix, the following error may happen: "attempt to add duplicate property 'chr-test' to object (type 'container')", due to races. Sadly, error_vprintf() uses g_test_message(), so you have to use read the cryptic --debug-log

Re: [Qemu-devel] [PATCH v2 25/67] target/arm: Implement SVE Integer Wide Immediate - Predicated Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > +/* Two operand predicated copy immediate with merge. All valid immediates > + * can fit within 17 signed bits in the simd_data field. > + */ > +void HELPER(sve_cpy_m_b)(void *vd, void *vn, void *vg, > +

Re: [Qemu-devel] [PATCH 0/9] nbd block status base:allocation

2018-02-23 Thread no-reply
Hi, This series failed build test on ppcle host. Please find the details below. Subject: [Qemu-devel] [PATCH 0/9] nbd block status base:allocation Type: series Message-id: 1518702707-7077-1-git-send-email-vsement...@virtuozzo.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be inv

Re: [Qemu-devel] [PATCH 3/6] vhost-user-test: add back memfd check

2018-02-23 Thread Maxime Coquelin
On 02/15/2018 10:25 PM, Marc-André Lureau wrote: This revert commit fb68096da3d35e64c88cd610c1fa42766c58e92a, and modify test_read_guest_mem() to use different chardev names, when using memfd (_test_server_free(), where the chardev is removed, runs in idle). Signed-off-by: Marc-André Lureau --

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 26/67] target/arm: Implement SVE Permute - Extract Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 2 ++ > target/arm/sve_helper.c| 81 > ++ > target/arm/translate-sve.c | 29 + > target/arm/sve.decode

Re: [Qemu-devel] [PATCH v3 1/3] s390x/sclp: proper support of larger send and receive masks

2018-02-23 Thread Christian Borntraeger
On 02/23/2018 01:51 PM, Claudio Imbrenda wrote: > Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length event masks") > we only supported sclp event masks with a size of exactly 4 bytes, even > though the architecture allows the guests to set up sclp event masks > from 1 to 1021 bytes

Re: [Qemu-devel] [PATCH v3 2/3] s390x/sclp: clean up sclp masks

2018-02-23 Thread Christian Borntraeger
On 02/23/2018 01:51 PM, Claudio Imbrenda wrote: > Introduce an sccb_mask_t to be used for SCLP event masks instead of just > unsigned int or uint32_t. This will allow later to extend the mask with > more ease. > > Signed-off-by: Claudio Imbrenda Reviewed-by: Christian Borntraeger

Re: [Qemu-devel] [PATCH v2 27/67] target/arm: Implement SVE Permute - Unpredicated Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 23 + > target/arm/translate-a64.h | 14 +++--- > target/arm/sve_helper.c| 114 > + > target/arm/translate-sve

Re: [Qemu-devel] intel-iommu and vhost: Do we need 'device-iotlb' and 'ats'?

2018-02-23 Thread Jintack Lim
On Fri, Feb 23, 2018 at 2:09 AM, Peter Xu wrote: > On Fri, Feb 23, 2018 at 06:34:04AM +, Jintack Lim wrote: >> On Fri, Feb 23, 2018 at 1:10 AM Peter Xu wrote: >> >> > On Fri, Feb 23, 2018 at 12:32:13AM -0500, Jintack Lim wrote: >> > > Hi Peter, >> > > >> > > Hope you had great holidays! >> >

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a OpenBSD maintainer

2018-02-23 Thread Peter Maydell
On 16 February 2018 at 16:46, Brad Smith wrote: > Add myself as an OpenBSD maintainer and add OpenBSD as maintained. > > Signed-off-by: Brad Smith > > > diff --git a/MAINTAINERS b/MAINTAINERS > index 57358a08e2..86329e274f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -386,6 +386,12 @@ M: K

Re: [Qemu-devel] [PATCH v3 3/3] s390x/sclp: extend SCLP event masks to 64 bits

2018-02-23 Thread Christian Borntraeger
On 02/23/2018 01:51 PM, Claudio Imbrenda wrote: > > +static bool vmstate_event_facility_mask64_needed(void *opaque) > +{ > +SCLPEventFacility *ef = opaque; > + > +return (ef->receive_mask & 0x) != 0; > +} > + > +static int vmstate_event_facility_mask64_pre_load(void *opaque) > +

Re: [Qemu-devel] [PATCH v2 16/36] file-win32: Support .bdrv_co_create

2018-02-23 Thread Eric Blake
On 02/21/2018 07:53 AM, Kevin Wolf wrote: This adds the .bdrv_co_create driver callback to file-win32, which enables image creation over QMP. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block/file-win32.c | 45 + 1 file changed, 37 insert

Re: [Qemu-devel] [PATCH v3 3/3] util/uri.c: add brackets to `if` statements

2018-02-23 Thread 苏航
Thanks for your reply. ^_^ I will apply all your suggestion in my next patch. > -Original Messages- > From: "Thomas Huth" > Sent Time: 2018-02-23 17:34:12 (Friday) > To: "Su Hang" , stefa...@redhat.com > Cc: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH v3 3/3] util/uri.c: add

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Collin L. Walling
On 02/23/2018 05:11 AM, Christian Borntraeger wrote: On 02/23/2018 11:07 AM, Thomas Huth wrote: On 22.02.2018 20:40, Collin L. Walling wrote: On 02/22/2018 11:45 AM, Collin L. Walling wrote: On 02/22/2018 10:44 AM, Christian Borntraeger wrote: On 02/22/2018 04:40 PM, Collin L. Walling wrote:

Re: [Qemu-devel] [PATCH v3 3/3] util/uri.c: add brackets to `if` statements

2018-02-23 Thread Eric Blake
On 02/23/2018 03:34 AM, Thomas Huth wrote: On 23.02.2018 08:51, Su Hang wrote: Add brackets that wrap `if`, `else`, `while` that hold single statements. In order to do this, I write a simple python regex script. Without documenting the script, no one else can reproduce this; but it's no diff

Re: [Qemu-devel] intel-iommu and vhost: Do we need 'device-iotlb' and 'ats'?

2018-02-23 Thread Jintack Lim
Hi Kevin, On Fri, Feb 23, 2018 at 2:34 AM, Tian, Kevin wrote: >> From: Peter Xu >> Sent: Friday, February 23, 2018 3:09 PM >> >> > >> > Right. I think my question was not clear. My question was that why don’t >> > IOMMU invalidate device-iotlb along with its mappings in one go. Then >> IOMMU >> >

[Qemu-devel] [PATCH v3 2/4] target/m68k: add fmod/frem

2018-02-23 Thread Laurent Vivier
Using a local m68k floatx80_mod() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] The quotient byte of the FPSR is updated with the result of the operation. Signed-off-by: Laurent Vivier --- target/m68k/Makefile.objs | 3 +- target/m68k/cpu.h |

[Qemu-devel] [PATCH v3 0/4] target/m68k: implement 680x0 FPU (part 3)

2018-02-23 Thread Laurent Vivier
Implement fmod, frem, fscale, fgetman and fgetexp. Instead of using functions of libm (v1 of this series) and converting between host long double and floatx80 type the new version (v2) adds new floatx80 functions in softfloat. All the floatx80 functions are copied from "Previous", the NeXT Comput

[Qemu-devel] [PATCH v3 1/4] softfloat: export some functions

2018-02-23 Thread Laurent Vivier
Move fpu/softfloat-macros.h to include/fpu/ Export floatx80 functions to be used by target floatx80 specific implementations. Exports: propagateFloatx80NaN(), extractFloatx80Frac(), extractFloatx80Exp(), extractFloatx80Sign(), normalizeFloatx80Subnormal(), packFloatx80(), roundAndPackFloa

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Collin L. Walling
On 02/23/2018 09:57 AM, Collin L. Walling wrote: On 02/23/2018 05:11 AM, Christian Borntraeger wrote: On 02/23/2018 11:07 AM, Thomas Huth wrote: On 22.02.2018 20:40, Collin L. Walling wrote: On 02/22/2018 11:45 AM, Collin L. Walling wrote: On 02/22/2018 10:44 AM, Christian Borntraeger wrote:

  1   2   3   4   >