[Qemu-devel] [PULL 1/6] colo: modified the payload compare function

2018-01-29 Thread Jason Wang
From: Mao Zhongyi Modified the function colo_packet_compare_common to prepare for the tcp packet comparison in the next patch. Cc: Zhang Chen Cc: Li Zhijian Cc: Jason Wang Signed-off-by: Mao Zhongyi Signed-off-by: Li Zhijian Signed-off-by: Zhang Chen Reviewed-by: Zhang Chen Signed-off-by

[Qemu-devel] [PULL 4/6] net: Allow netdevs to be used with 'hostfwd_add' and 'hostfwd_remove'

2018-01-29 Thread Jason Wang
From: Thomas Huth It does not make much sense to limit these commands to the legacy 'vlan' concept only, they should work with the modern netdevs, too. So now it is possible to use this command with one, two or three parameters. With one parameter, the command installs a hostfwd rule on the defa

[Qemu-devel] [PULL 0/6] Net patches

2018-01-29 Thread Jason Wang
The following changes since commit e607bbee553cfe73072870cef458cfa4e78133e2: Merge remote-tracking branch 'remotes/edgar/tags/edgar/xilinx-next-2018-01-26.for-upstream' into staging (2018-01-26 14:24:25 +) are available in the git repository at: https://github.com/jasowang/qemu.git tag

[Qemu-devel] [PULL 2/6] colo: compare the packet based on the tcp sequence number

2018-01-29 Thread Jason Wang
From: Mao Zhongyi Packet size some time different or when network is busy. Based on same payload size, but TCP protocol can not guarantee send the same one packet in the same way, like that: We send this payload: -- | header |1|2|3|4|5|6|7|8|9|0| -

[Qemu-devel] [PULL 5/6] qemu-doc: Get rid of "vlan=X" example in the documentation

2018-01-29 Thread Jason Wang
From: Thomas Huth The vlan concept is marked as deprecated, so we should not use this for examples in the documentation anymore. Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/q

[Qemu-devel] [PULL 3/6] net: Allow hubports to connect to other netdevs

2018-01-29 Thread Jason Wang
From: Thomas Huth QEMU can emulate hubs to connect NICs and netdevs. This is currently primarily used for the mis-named 'vlan' feature of the networking subsystem. Now the 'vlan' feature has been marked as deprecated, since its name is rather confusing and the users often rather mis-configure the

[Qemu-devel] [PULL 6/6] MAINTAINERS: update Dmitry Fleytman email

2018-01-29 Thread Jason Wang
From: Philippe Mathieu-Daudé gently asked by his automatic reply :) Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Jason Wang --- MAINTAINERS | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 753e799..fe39b30 100644 --- a/MAINTAI

Re: [Qemu-devel] [PULL 0/6] Net patches

2018-01-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1517213825-24085-1-git-send-email-jasow...@redhat.com Subject: [Qemu-devel] [PULL 0/6] Net patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --onel

Re: [Qemu-devel] SDL2 UI behavior of switching views

2018-01-29 Thread Gerd Hoffmann
On Sun, Jan 28, 2018 at 06:43:44PM +0300, Anatoly Trosinenko wrote: > When QEMU is run with GTK UI, it changes what is drawn on its single window > when I press Ctrl-Alt-{1,2,3,4}. But when I use SDL2 UI, it opens multiple > windows: a separate window per each view (display, monitor, serial, > para

Re: [Qemu-devel] [PATCH qemu v4] RFC: vfio-pci: Allow mmap of MSIX BAR

2018-01-29 Thread Auger Eric
Hi Alexey, On 29/01/18 04:55, Alexey Kardashevskiy wrote: > On 26/01/18 00:56, Auger Eric wrote: >> Hi Alexey, >> >> On 25/01/18 05:22, Alexey Kardashevskiy wrote: >>> This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability >>> which tells that a region with MSIX data can be mapped e

Re: [Qemu-devel] [PATCH] spapr_pci: fix MSI/MSIX selection

2018-01-29 Thread Greg Kurz
On Sat, 27 Jan 2018 20:15:52 +1100 David Gibson wrote: > On Fri, Jan 26, 2018 at 11:25:24PM +0100, Greg Kurz wrote: > > In various place we don't correctly check if the device supports MSI or > > MSI-X. This can cause devices to be advertised with MSI support, even > > if they only support MSI-X

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 12/18] s390x: fix size + content of STSI blocks

2018-01-29 Thread David Hildenbrand
On 25.01.2018 14:51, Cornelia Huck wrote: > On Thu, 25 Jan 2018 14:15:45 +0100 > David Hildenbrand wrote: > >> On 25.01.2018 11:26, Cornelia Huck wrote: >>> On Wed, 17 Jan 2018 18:40:41 +0100 >>> David Hildenbrand wrote: >>> All blocks are 4k in size, which is only true for two of them r

Re: [Qemu-devel] SDL2 UI behavior of switching views

2018-01-29 Thread Anatoly Trosinenko
Got it, thank you! 29 янв. 2018 г. 11:27 ДП пользователь "Gerd Hoffmann" написал: > On Sun, Jan 28, 2018 at 06:43:44PM +0300, Anatoly Trosinenko wrote: > > When QEMU is run with GTK UI, it changes what is drawn on its single > window > > when I press Ctrl-Alt-{1,2,3,4}. But when I use SDL2 UI, i

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 12/18] s390x: fix size + content of STSI blocks

2018-01-29 Thread Cornelia Huck
On Mon, 29 Jan 2018 10:42:33 +0100 David Hildenbrand wrote: > If there are no further comments, I can resend. Other than the wrong cr check, I did not have any complaints.

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-29 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 26 January 2018 at 19:46, Dr. David Alan Gilbert > wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > >> I think the correct fix here is that your test code should turn > >> its MMU on. Trying to treat guest RAM as uncacheable doe

Re: [Qemu-devel] [PULL 0/8] NBD patches through 26 Jan

2018-01-29 Thread Peter Maydell
On 26 January 2018 at 16:04, Eric Blake wrote: > The following changes since commit e607bbee553cfe73072870cef458cfa4e78133e2: > > Merge remote-tracking branch > 'remotes/edgar/tags/edgar/xilinx-next-2018-01-26.for-upstream' into staging > (2018-01-26 14:24:25 +) > > are available in the Gi

Re: [Qemu-devel] [PULL 0/6] Net patches

2018-01-29 Thread Jason Wang
On 2018年01月29日 16:25, no-re...@patchew.org wrote: Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1517213825-24085-1-git-send-email-jasow...@redhat.com Subject: [Qemu-devel] [PULL 0/6] Net patches === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-29 Thread Peter Maydell
On 29 January 2018 at 09:53, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On 26 January 2018 at 19:46, Dr. David Alan Gilbert >> wrote: >> > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> >> I think the correct fix here is that your test code should

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 09/10] s390-ccw: read user input for boot index via the SCLP console

2018-01-29 Thread David Hildenbrand
On 23.01.2018 19:26, Collin L. Walling wrote: > Implements an sclp_read function to capture input from the > console and a wrapper function that handles parsing certain > characters and adding input to a buffer. The input is checked > for any erroneous values and is handled appropriately. > > A pr

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 09/10] s390-ccw: read user input for boot index via the SCLP console

2018-01-29 Thread David Hildenbrand
On 29.01.2018 11:07, David Hildenbrand wrote: > On 23.01.2018 19:26, Collin L. Walling wrote: >> Implements an sclp_read function to capture input from the >> console and a wrapper function that handles parsing certain >> characters and adding input to a buffer. The input is checked >> for any erro

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 08/10] s390-ccw: print zipl boot menu

2018-01-29 Thread David Hildenbrand
On 23.01.2018 19:26, Collin L. Walling wrote: > When the boot menu options are present and the guest's > disk has been configured by the zipl tool, then the user > will be presented with an interactive boot menu with > labeled entries. An example of what the menu might look > like: > > zIPL v1.37.

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-29 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 29 January 2018 at 09:53, Dr. David Alan Gilbert > wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > >> On 26 January 2018 at 19:46, Dr. David Alan Gilbert > >> wrote: > >> > * Peter Maydell (peter.mayd...@linaro.org) wrote: >

[Qemu-devel] [PULL 5/7] hw: convert the escc device to keycodemapdb

2018-01-29 Thread Gerd Hoffmann
From: "Daniel P. Berrange" Replace the qcode_to_keycode table with automatically generated tables. Missing entries in qcode_to_keycode now fixed: - Q_KEY_CODE_KP_COMMA -> 0x2d Signed-off-by: Daniel P. Berrange Message-id: 20180117164118.8510-3-berra...@redhat.com Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PULL 6/7] ui: fix alphabetical ordering of keymaps

2018-01-29 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The qcode-to-linux keymaps was accidentally added in the wrong place by commit de80d78594b4c3767a12d8d42debcf12cbf85a5b Author: Owen Smith Date: Fri Nov 3 11:56:28 2017 + ui: generate qcode to linux mappings breaking the alphabetical ordering of keym

[Qemu-devel] [PULL 2/7] input: virtio: don't send mouse wheel event twice

2018-01-29 Thread Gerd Hoffmann
From: Miika S On Linux, a mouse event is generated for both down and up when mouse wheel is used. This caused virtio_input_send() to be called twice each time the wheel was used. This commit adds a check for the button down state and only calls virtio_input_send() when it is true. Signed-off-by

[Qemu-devel] [PULL 1/7] input: add mouse side buttons to virtio input

2018-01-29 Thread Gerd Hoffmann
From: Miika S Signed-off-by: Miika S Message-Id: <20171222152531.1849-3-miika9...@gmail.com> Signed-off-by: Gerd Hoffmann --- hw/input/virtio-input-hid.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/input/virtio-input-hid.c b/hw/input/virtio-input-hid.c index e78faec0b1..a5917c2754

[Qemu-devel] [PULL 0/7] Input 20180129 v2 patches

2018-01-29 Thread Gerd Hoffmann
tags/input-20180129-v2-pull-request for you to fetch changes up to ae6b06ab655b21c19b234ce3422f694d11a013e0: hw: convert virtio-input-hid device to keycodemapdb (2018-01-29 09:35:44 +0100) input: switch devices to keycodemapdb

[Qemu-devel] [PULL 3/7] ps2: check PS2Queue pointers in post_load routine

2018-01-29 Thread Gerd Hoffmann
From: Prasad J Pandit During Qemu guest migration, a destination process invokes ps2 post_load function. In that, if 'rptr' and 'count' values were invalid, it could lead to OOB access or infinite loop issue. Add check to avoid it. Reported-by: Cyrille Chatras Signed-off-by: Prasad J Pandit Me

[Qemu-devel] [PULL 4/7] hw: convert ps2 device to keycodemapdb

2018-01-29 Thread Gerd Hoffmann
From: "Daniel P. Berrange" Replace the qcode_to_keycode_set1, qcode_to_keycode_set2, and qcode_to_keycode_set3 tables with automatically generated tables. Missing entries in qcode_to_keycode_set1 now fixed: - Q_KEY_CODE_SYSRQ -> 0x54 - Q_KEY_CODE_PRINT -> 0x54 (NB ignored due to special case)

[Qemu-devel] [PULL 7/7] hw: convert virtio-input-hid device to keycodemapdb

2018-01-29 Thread Gerd Hoffmann
From: "Daniel P. Berrange" Replace the keymap_qcode table with automatically generated tables. Missing entries in keymap_qcode now fixed: Q_KEY_CODE_ASTERISK -> KEY_KPASTERISK Q_KEY_CODE_KP_MULTIPLY -> KEY_KPASTERISK Q_KEY_CODE_STOP -> KEY_STOP Q_KEY_CODE_AGAIN -> KEY_AGAIN Q_KEY_CODE

Re: [Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption

2018-01-29 Thread Andrew Jones
On Fri, Jan 26, 2018 at 06:01:33PM +, Peter Maydell wrote: > On 26 January 2018 at 17:33, Wei Xu wrote: > > On 2018/1/26 17:15, Peter Maydell wrote: > >> The pl011 code should call qemu_set_irq(..., 1) when the > >> guest enables interrupts on the device by writing to the int_enabled > >> (UAR

Re: [Qemu-devel] [PATCH 1/7] target/mips: compare virtual addresses in LL/SC sequence

2018-01-29 Thread Miodrag Dinic
Hi Alex, thank you for your comments, and sorry for such a late response, Aleksandar is currently on sick leave, but I will try to address your concern. Actually, answer to your question is already in the commit message of this patch, I'm copying it here for convenience: Given our LL/SC emu

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-29 Thread Marc Zyngier
On 29/01/18 10:04, Peter Maydell wrote: > On 29 January 2018 at 09:53, Dr. David Alan Gilbert > wrote: >> * Peter Maydell (peter.mayd...@linaro.org) wrote: >>> On 26 January 2018 at 19:46, Dr. David Alan Gilbert >>> wrote: * Peter Maydell (peter.mayd...@linaro.org) wrote: > I think the

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-29 Thread Alex Bennée
Fam Zheng writes: > To make our efforts on QEMU testing easier to consume by contributors, > let's add a document. For example, Patchew reports build errors on > patches that should be relativly easy to reproduce with a few steps, and > it is much nicer if there is such a documentation that it c

[Qemu-devel] [PATCH v3] linux-user: Implement ioctl cmd TIOCGPTPEER

2018-01-29 Thread Andreas Schwab
With glibc 2.27 the openpty function prefers the TIOCGPTPEER ioctl. Signed-off-by: Andreas Schwab Reviewed-by: Laurent Vivier --- v2: handle host with old kernel headers v3: fix sparc typos --- linux-user/aarch64/termbits.h| 2 ++ linux-user/alpha/termbits.h | 1 + linux-user/arm/termb

Re: [Qemu-devel] [PATCH] spapr_pci: fix MSI/MSIX selection

2018-01-29 Thread Laurent Vivier
On 27/01/2018 10:15, David Gibson wrote: > On Fri, Jan 26, 2018 at 11:25:24PM +0100, Greg Kurz wrote: >> In various place we don't correctly check if the device supports MSI or >> MSI-X. This can cause devices to be advertised with MSI support, even >> if they only support MSI-X (like virtio-pci-*

Re: [Qemu-devel] [PULL 0/6] Net patches

2018-01-29 Thread Thomas Huth
On 29.01.2018 11:02, Jason Wang wrote: > > > On 2018年01月29日 16:25, no-re...@patchew.org wrote: >> Hi, >> >> This series seems to have some coding style problems. See output below >> for >> more information: >> >> Type: series >> Message-id: 1517213825-24085-1-git-send-email-jasow...@redhat.com >>

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-29 Thread Stefan Hajnoczi
On Mon, Jan 29, 2018 at 11:31:33AM +0800, Fam Zheng wrote: Thanks for writing this! I have only reviewed some parts in detail. > +"Make check" testings > += > + > +The "make check" testing family includes most of the C based tests in QEMU. > For > +a quick help, run ``make c

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Simplify bdrv_can_write_zeroes_with_unmap()

2018-01-29 Thread Stefan Hajnoczi
On Fri, Jan 26, 2018 at 01:34:39PM -0600, Eric Blake wrote: > We don't need the can_write_zeroes_with_unmap field in > BlockDriverInfo, because it is redundant information with > supported_zero_flags & BDRV_REQ_MAY_UNMAP. Note that > BlockDriverInfo and supported_zero_flags are both per-device > s

Re: [Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption

2018-01-29 Thread Peter Maydell
On 29 January 2018 at 10:29, Andrew Jones wrote: > On Fri, Jan 26, 2018 at 06:01:33PM +, Peter Maydell wrote: >> On 26 January 2018 at 17:33, Wei Xu wrote: >> > On 2018/1/26 17:15, Peter Maydell wrote: >> >> The pl011 code should call qemu_set_irq(..., 1) when the >> >> guest enables interrup

Re: [Qemu-devel] [qemu-web PATCH] Add "Understanding QEMU devices" blog post

2018-01-29 Thread Paolo Bonzini
On 26/01/2018 15:46, Eric Blake wrote: > On 01/26/2018 06:40 AM, Paolo Bonzini wrote: >> On 26/01/2018 10:19, Thomas Huth wrote: >>> Last July, Eric Blake wrote a nice summary for newcomers about what >>> QEMU has to do to emulate devices for the guests. So far, we missed >>> to integrate this some

Re: [Qemu-devel] [qemu-web PATCH] Add "Understanding QEMU devices" blog post

2018-01-29 Thread Thomas Huth
On 26.01.2018 15:46, Eric Blake wrote: > On 01/26/2018 06:40 AM, Paolo Bonzini wrote: >> On 26/01/2018 10:19, Thomas Huth wrote: >>> Last July, Eric Blake wrote a nice summary for newcomers about what >>> QEMU has to do to emulate devices for the guests. So far, we missed >>> to integrate this some

Re: [Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption

2018-01-29 Thread Wei Xu
Hi Andrew, On 2018/1/29 10:29, Andrew Jones wrote: > On Fri, Jan 26, 2018 at 06:01:33PM +, Peter Maydell wrote: >> On 26 January 2018 at 17:33, Wei Xu wrote: >>> On 2018/1/26 17:15, Peter Maydell wrote: The pl011 code should call qemu_set_irq(..., 1) when the guest enables interrupt

Re: [Qemu-devel] [PULL 0/5] Merge tpm 2018/01/26

2018-01-29 Thread Peter Maydell
On 26 January 2018 at 18:49, Stefan Berger wrote: > The patches in this pull request fix a bug in the initialization of > a variable, adapt the cancel path used by the passthrough device to the > sysfs path of more recent versions of the Linux kernel, and do some other > cleanups preparing for sup

Re: [Qemu-devel] [PATCH 2/5] lockable: add QemuLockable

2018-01-29 Thread Stefan Hajnoczi
On Thu, Jan 25, 2018 at 06:59:46PM +0100, Paolo Bonzini wrote: > +struct QemuLockable { > +void *object; > +QemuLockUnlockFunc *lock; > +QemuLockUnlockFunc *unlock; > +}; ... > +/* In C, compound literals have the lifetime of an automatic variable. > + * In C++ it would be different, bu

Re: [Qemu-devel] [PATCH v3 19/22] fpu/softfloat: re-factor scalbn

2018-01-29 Thread Alex Bennée
Richard Henderson writes: > On 01/24/2018 05:13 AM, Alex Bennée wrote: >> +/* Multiply A by 2 raised to the power N. */ >> +static FloatParts scalbn_decomposed(FloatParts a, int n, >> + float_status *s) >> +{ >> +if (a.cls == float_class_normal) { >>

Re: [Qemu-devel] [PATCH v3 30/39] qcow2: Update expand_zero_clusters_in_l1() to support L2 slices

2018-01-29 Thread Alberto Garcia
On Fri 26 Jan 2018 08:46:19 PM CET, Eric Blake wrote: >> -ret = qcow2_cache_get(bs, s->l2_table_cache, l2_offset, >> - (void **)&l2_table); >> +ret = qcow2_cache_get(bs, s->l2_table_cache, slice_offset, >> +

[Qemu-devel] [PULL 00/13] Migration PULL request

2018-01-29 Thread Juan Quintela
ce commit 6233b4a8c2a32ef6955a921246fa08705bbb3676: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-01-26' into staging (2018-01-26 17:29:14 +) are available in the Git repository at: git://github.com/juanquintela/qemu.git tags/migration/20180129 for you to

[Qemu-devel] [PULL 02/13] migration: Route errors down through migration_channel_connect

2018-01-29 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Route async errors (especially from sockets) down through migration_channel_connect and on to migrate_fd_connect where they can be cleaned up. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/channel.c

[Qemu-devel] [PULL 04/13] migration: use s->threshold_size inside migration_update_counters

2018-01-29 Thread Juan Quintela
From: Wei Wang Fixes: b15df1ae50 ("migration: cleanup stats update into function") The threshold size is changed to be recorded in s->threshold_size. Signed-off-by: Wei Wang Reviewed-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.c | 5 ++--- 1

[Qemu-devel] [PULL 01/13] migration: Allow migrate_fd_connect to take an Error *

2018-01-29 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Allow whatever is performing the connection to pass migrate_fd_connect an error to indicate there was a problem during connection, an allow us to clean up. The caller must free the error. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Signed-of

[Qemu-devel] [PULL 05/13] migration: Drop current address parameter from save_zero_page()

2018-01-29 Thread Juan Quintela
It already has RAMBlock and offset, it can calculate it itself. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index cb1950f3eb..5a109efeda 100

[Qemu-devel] [PULL 07/13] tests: Consolidate accelerators declaration

2018-01-29 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- tests/migration-test.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index 0428d450df..3732682a29 100644 --- a/tests/mi

[Qemu-devel] [PULL 03/13] migration/savevm.c: set MAX_VM_CMD_PACKAGED_SIZE to 1ul << 32

2018-01-29 Thread Juan Quintela
From: Daniel Henrique Barboza MAX_VM_CMD_PACKAGED_SIZE is a constant used in qemu_savevm_send_packaged and loadvm_handle_cmd_packaged to determine whether a package is too big to be sent or received. qemu_savevm_send_packaged is called inside postcopy_start (migration/migration.c) to send the Mig

[Qemu-devel] [PULL 09/13] tests: Add deprecated commands migration test

2018-01-29 Thread Juan Quintela
We add deprecated commands on a new test, so we don't have to add it on normal tests. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- tests/migration-test.c | 46 ++ 1 file changed, 46 insertions(+) diff --git a/tests/migration-test.c b/tests/

[Qemu-devel] [PULL 06/13] tests: Remove deprecated migration tests commands

2018-01-29 Thread Juan Quintela
We move to use migration_set_parameter() for everything. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- tests/migration-test.c | 33 - 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-te

[Qemu-devel] [PULL 10/13] tests: Add migration precopy test

2018-01-29 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- tests/migration-test.c | 44 ++-- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index 2a0b651cd1..4

[Qemu-devel] [PULL 12/13] tests: Create migrate-start-postcopy command

2018-01-29 Thread Juan Quintela
This way, it is like the rest of commands Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- tests/migration-test.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index

[Qemu-devel] [PULL 08/13] tests: Use consistent names for migration

2018-01-29 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- tests/migration-test.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index 3732682a29..ac4a916169 100644 --- a/tests/migration

[Qemu-devel] [PULL 11/13] tests: Add migration xbzrle test

2018-01-29 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- tests/migration-test.c | 64 ++ 1 file changed, 64 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index 44c8860134..84f5bcf00a 100644 --- a/tests/migration-test.c +

[Qemu-devel] [PATCH v5 4/5] tests: Add basic migration precopy tcp test

2018-01-29 Thread Juan Quintela
Not sharing code from precopy/unix because we have to read back the tcp parameter. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- tests/migration-test.c | 58 +++--- 1 file changed, 55 insertions(+), 3 dele

[Qemu-devel] [PULL 13/13] tests: Adjust sleeps for migration test

2018-01-29 Thread Juan Quintela
Also reorder code to not sleep when event already happened. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- tests/migration-test.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/tests/migration-test

[Qemu-devel] [PATCH v5 0/5] Add make check tests for Migration

2018-01-29 Thread Juan Quintela
Hi In v5: - Several patches moved to pull request - merge info_migrate and migration_tests only missing bit is tcp_port, needed for tcp tests - Rename tcp-port to x-tcp-port We will get better naming from David at some point, and we will use that bit - ppc: use inline code as suggested by lvi

[Qemu-devel] [PATCH v5 1/5] migration: Create tcp_port parameter

2018-01-29 Thread Juan Quintela
It will be used to store the uri tcp_port parameter. This is the only parameter than can change and we can need to be able to connect to it. Signed-off-by: Juan Quintela -- This used to be uri parameter, but it has so many troubles to reproduce that it don't just make sense. --- hmp.c

Re: [Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption

2018-01-29 Thread Wei Xu
Hi Peter, On 2018/1/26 18:01, Peter Maydell wrote: > On 26 January 2018 at 17:33, Wei Xu wrote: >> On 2018/1/26 17:15, Peter Maydell wrote: >>> The pl011 code should call qemu_set_irq(..., 1) when the >>> guest enables interrupts on the device by writing to the int_enabled >>> (UARTIMSC) register

[Qemu-devel] [PATCH v5 2/5] migration: Set the migration tcp port

2018-01-29 Thread Juan Quintela
We can set the port parameter as zero. This patch lets us know what port the system was choosen for us. Now we can migrate to this place. Signed-off-by: Juan Quintela -- This was migrate_set_uri(), but as we only need the tcp_port, change to that one. --- migration/migration.c | 10 +

[Qemu-devel] [PATCH v5 3/5] tests: Migration ppc now inlines its program

2018-01-29 Thread Juan Quintela
No need to write it to a file. Just need a proper firmware O:-) Signed-off-by: Juan Quintela CC: Laurent Vivier --- tests/migration-test.c | 41 + 1 file changed, 5 insertions(+), 36 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-tes

[Qemu-devel] [PATCH v5 5/5] [RFH] tests: Add migration compress threads tests

2018-01-29 Thread Juan Quintela
Yeap, it is still not working. trying to learn how to debug threads for guests running from the testt hardness. For some reason, compression is not working at the moment, test is disabled until I found why. Signed-off-by: Juan Quintela --- tests/migration-test.c | 52 +++

Re: [Qemu-devel] [PULL 0/6] Net patches

2018-01-29 Thread Jason Wang
On 2018年01月29日 18:58, Thomas Huth wrote: On 29.01.2018 11:02, Jason Wang wrote: On 2018年01月29日 16:25, no-re...@patchew.org wrote: Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1517213825-24085-1-git-send-email-jaso

[Qemu-devel] [PATCH] tpm: fix alignment issues

2018-01-29 Thread Marc-André Lureau
The new tpm-crb-test fails on sparc host: TEST: tests/tpm-crb-test... (pid=230409) /i386/tpm-crb/test: Broken pipe FAIL GTester: last random seed: R02S29cea50247fe1efa59ee885a26d51a85 (pid=230423) FAIL: tests/tpm-crb-test and generates a new clang sanitizer runtime warning: /home/petmay01/lina

[Qemu-devel] [PATCH v3 00/18] s390x: flic rework, tcg flic support and STSI

2018-01-29 Thread David Hildenbrand
This patch series implements floating interrupt support for TCG and fixes STSI so we can remove warnings related to s390x SMP and MTTCG. KVM code has to be touched in order to factor out the injection routines into the flic ("s390x/flic: factor out injection of floating interrupts"). Basic testing

[Qemu-devel] [PATCH v3 03/18] s390x/tcg: simplify lookup of flic

2018-01-29 Thread David Hildenbrand
We can simply search for an object of our common type. Signed-off-by: David Hildenbrand --- hw/intc/s390_flic.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/intc/s390_flic.c b/hw/intc/s390_flic.c index fc244fe775..ba1aa40eba 100644 --- a/hw/intc/s390_flic.c +++

[Qemu-devel] [PATCH v3 02/18] s390x/flic: simplify flic initialization

2018-01-29 Thread David Hildenbrand
This makes it clearer, which device is used for which accelerator. Reviewed-by: Christian Borntraeger Signed-off-by: David Hildenbrand --- hw/intc/s390_flic.c | 7 +-- hw/intc/s390_flic_kvm.c | 12 include/hw/s390x/s390_flic.h | 9 - 3 files changed, 5 i

[Qemu-devel] [PATCH v3 05/18] s390x/flic: factor out injection of floating interrupts

2018-01-29 Thread David Hildenbrand
Let the flic device handle it internally. This will allow us to later on store floating interrupts in the flic for the TCG case. This now also simplifies kvm.c. All that's left is the fallback interface for floating interrupts, which is now triggered directly via the flic in case anything goes wro

[Qemu-devel] [PATCH v3 01/18] s390x/tcg: deliver multiple interrupts in a row

2018-01-29 Thread David Hildenbrand
We have to consider all deliverable interrupts. We now have to take care of the special scenario, where we first inject an interrupt with a WAIT PSW, followed by a !WAIT PSW. (very unlikely but possible) Signed-off-by: David Hildenbrand --- target/s390x/excp_helper.c | 20

[Qemu-devel] [PATCH v3 04/18] s390x/tcg: simplify machine check handling

2018-01-29 Thread David Hildenbrand
We currently only support CRW machine checks. This is a preparation for real floating interrupt support. Get rid of the queue and handle it via the bit INTERRUPT_MCHK. We don't rename it for now, as it will be soon gone (when moving crw machine checks into the flic). Please note that this is the

[Qemu-devel] [PATCH v3 13/18] s390x/tcg: STSI overhaul

2018-01-29 Thread David Hildenbrand
Current STSI implementation is a mess, so let's rewrite it. Problems fixed by this patch: 1) The order of exceptions/when recognized is wrong. 2) We have to store to virtual address space, not absolute. 3) Alignment check of the block is missing. 3) The SMP information is not indicated. While at

[Qemu-devel] [PATCH v3 08/18] s390x/flic: make floating interrupts on TCG actually floating

2018-01-29 Thread David Hildenbrand
Move floating interrupt handling into the flic. Floating interrupts will now be considered by all CPUs, not just CPU #0. While at it, convert I/O interrupts to use a list and make sure we properly consider I/O sub-classes in s390_cpu_has_io_int(). Signed-off-by: David Hildenbrand --- hw/intc/s39

[Qemu-devel] [PATCH v3 06/18] s390x/flic: no need to call s390_io_interrupt() from flic

2018-01-29 Thread David Hildenbrand
We can directly call the right function. Suggested-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/intc/s390_flic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/intc/s390_flic.c b/hw/intc/s390_flic.c index bdc8ec7607..d6ed1d7380 100644 --- a/hw/intc/s390_fl

[Qemu-devel] [PATCH v3 14/18] s390x/tcg: remove SMP warning

2018-01-29 Thread David Hildenbrand
We should be pretty good in shape now. Floating interrupts are working and atomic instructions should be atomic. Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 38

[Qemu-devel] [PATCH v3 11/18] s390x/flic: optimize CPU wakeup for TCG

2018-01-29 Thread David Hildenbrand
Kicking all CPUs on every floating interrupt is far from efficient. Let's optimize it at least a little bit. Signed-off-by: David Hildenbrand --- hw/intc/s390_flic.c | 31 +-- target/s390x/cpu.h | 4 target/s390x/internal.h | 5 - 3 files changed,

[Qemu-devel] [PATCH v3 07/18] s390x/tcg: tolerate wrong wakeups due to floating interrupts

2018-01-29 Thread David Hildenbrand
This is a preparation for floating interrupt support and only applies to MTTCG, single threaded TCG works just fine. If a floating interrupt wakes up a VCPU and the CPU thinks it can run (clearing cs->halted), at the point where the interrupt would be delivered, already another VCPU might have pick

[Qemu-devel] [PATCH v3 15/18] configure: s390x supports mttcg now

2018-01-29 Thread David Hildenbrand
s390x is ready. Most likely we are missing some pieces, but it should already be in pretty good shape now. Signed-off-by: David Hildenbrand --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 96dee6572c..2f2c5896c1 100755 --- a/configure +++ b/configure

[Qemu-devel] [PATCH v3 12/18] s390x: fix size + content of STSI blocks

2018-01-29 Thread David Hildenbrand
All blocks are 4k in size, which is only true for two of them right now. Also some reserved fields were wrong, fix it and convert all reserved fields to u8. This also fixes the LPAR part output in /proc/sysinfo under TCG. (for now, everything was indicated as 0) While at it, introduce typedefs fo

[Qemu-devel] [PATCH v3 09/18] s390x/tcg: implement TEST PENDING INTERRUPTION

2018-01-29 Thread David Hildenbrand
Use s390_cpu_virt_mem_write() so we can actually revert what we did (re-inject the dequeued IO interrupt). Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 1 + target/s390x/misc_helper.c | 54 ++ ta

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 09/10] s390-ccw: read user input for boot index via the SCLP console

2018-01-29 Thread David Hildenbrand
On 23.01.2018 19:26, Collin L. Walling wrote: > Implements an sclp_read function to capture input from the > console and a wrapper function that handles parsing certain > characters and adding input to a buffer. The input is checked > for any erroneous values and is handled appropriately. > > A pr

[Qemu-devel] [PATCH v3 17/18] s390x/kvm: cache the kvm flic in a central function

2018-01-29 Thread David Hildenbrand
This avoids tons of conversions when handling interrupts. Acked-by: Christian Borntraeger Signed-off-by: David Hildenbrand --- hw/intc/s390_flic_kvm.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/hw/intc/s390_flic_kvm.c b/hw/intc/s390_flic_kvm.c ind

[Qemu-devel] [PATCH v3 10/18] s390x/flic: implement qemu_s390_clear_io_flic()

2018-01-29 Thread David Hildenbrand
Now that we have access to the io interrupts, we can implement clear_io_irq() for TCG. Signed-off-by: David Hildenbrand --- hw/intc/s390_flic.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/hw/intc/s390_flic.c b/hw/intc/s390_flic.c index 928

[Qemu-devel] [PATCH v3 18/18] s390x/flic: cache the common flic class in a central function

2018-01-29 Thread David Hildenbrand
This avoids tons of conversions when handling interrupts. Signed-off-by: David Hildenbrand --- hw/intc/s390_flic.c | 13 - hw/s390x/css.c | 10 +- hw/s390x/virtio-ccw.c| 4 ++-- include/hw/s390x/s390_flic.h | 1 + target/s390x/interrupt.c

[Qemu-devel] [PATCH v3 16/18] s390x/tcg: cache the qemu flic in a central function

2018-01-29 Thread David Hildenbrand
This avoids tons of conversions when handling interrupts. Signed-off-by: David Hildenbrand --- hw/intc/s390_flic.c | 23 +-- include/hw/s390x/s390_flic.h | 1 + target/s390x/interrupt.c | 6 +++--- target/s390x/misc_helper.c | 2 +- 4 files changed, 22 inser

Re: [Qemu-devel] [PULL v4 00/43] hppa-softmmu

2018-01-29 Thread Peter Maydell
On 28 January 2018 at 23:14, Richard Henderson wrote: > Changes since patch v3: > * Drop MMU_DEBUG_LOAD, which obviates the sh4 changes. > > > r~ > > > The following changes since commit e607bbee553cfe73072870cef458cfa4e78133e2: > > Merge remote-tracking branch > 'remotes/edgar/tags/edgar/xil

Re: [Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption

2018-01-29 Thread Andrew Jones
On Mon, Jan 29, 2018 at 11:37:05AM +, Wei Xu wrote: > Hi Andrew, > > On 2018/1/29 10:29, Andrew Jones wrote: > > On Fri, Jan 26, 2018 at 06:01:33PM +, Peter Maydell wrote: > >> On 26 January 2018 at 17:33, Wei Xu wrote: > >>> On 2018/1/26 17:15, Peter Maydell wrote: > The pl011 code

Re: [Qemu-devel] [PATCH 4/5] coroutine-lock: make qemu_co_enter_next thread-safe

2018-01-29 Thread Stefan Hajnoczi
On Thu, Jan 25, 2018 at 06:59:48PM +0100, Paolo Bonzini wrote: > qemu_co_queue_next does not need to release and re-acquire the mutex, > because the queued coroutine does not run immediately. However, this > does not hold for qemu_co_enter_next. Now that qemu_co_queue_wait > can synchronize (via

Re: [Qemu-devel] [PATCH 1/5] test-coroutine: add simple CoMutex test

2018-01-29 Thread Stefan Hajnoczi
On Thu, Jan 25, 2018 at 06:59:45PM +0100, Paolo Bonzini wrote: > In preparation for adding a similar test using QemuLockable, add a very > simple testcase that has two interleaved calls to lock and unlock. > > Signed-off-by: Paolo Bonzini > --- > tests/test-coroutine.c | 50 > ++

Re: [Qemu-devel] [PATCH 3/5] coroutine-lock: convert CoQueue to use QemuLockable

2018-01-29 Thread Stefan Hajnoczi
On Thu, Jan 25, 2018 at 06:59:47PM +0100, Paolo Bonzini wrote: > There are cases in which a queued coroutine must be restarted from > non-coroutine context (with qemu_co_enter_next). In this cases, > qemu_co_enter_next also needs to be thread-safe, but it cannot use > a CoMutex and so cannot qemu_

Re: [Qemu-devel] [PATCH 5/5] curl: convert to CoQueue

2018-01-29 Thread Stefan Hajnoczi
On Thu, Jan 25, 2018 at 06:59:49PM +0100, Paolo Bonzini wrote: > Now that CoQueues can use a QemuMutex for thread-safety, there is no > need for curl to roll its own coroutine queue. Coroutines can be > placed directly on the queue instead of using a list of CURLAIOCBs. > > Signed-off-by: Paolo B

Re: [Qemu-devel] Can not hotplug device to pci-to-pci bridge using machine type older than 1.7

2018-01-29 Thread Igor Mammedov
On Thu, 25 Jan 2018 16:01:39 +0800 Fei Li wrote: > Hi, > > After I hotplug a pci device to a pci2pci bridge (I use "pci.1") with > machine type 1.7 or older, > I can not see the pci device via `lspci` in the guest, but can see it > via `info qtree` in the hmp. > What's more, after I reboot the

Re: [Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption

2018-01-29 Thread Peter Maydell
On 29 January 2018 at 12:18, Wei Xu wrote: > On 2018/1/26 18:01, Peter Maydell wrote: >> No, that's not right either. int_level should already have the >> RX bit set, because pl011_put_fifo() sets that bit when it gets a >> character from QEMU and puts it into the FIFO. >> >> Does something else c

Re: [Qemu-devel] [Bug 1745312] [NEW] Regression report: Disk subsystem I/O failures/issues surfacing in DOS/early Windows [two separate issues: one bisected, one root-caused]

2018-01-29 Thread Stefan Hajnoczi
On Thu, Jan 25, 2018 at 07:18:52AM -, i336_ wrote: > Public bug reported: > > [Headsup: This report is long-ish due to the amount of detail I've > stumbled on along the way that I think is relevant to include. I can't > speak as to the complexity of the actual bugs, but the size of this > repo

Re: [Qemu-devel] Prevent overriding the input file with the output file when using qemu-img

2018-01-29 Thread Stefan Hajnoczi
On Thu, Jan 25, 2018 at 11:02:08AM +, Daniel P. Berrangé wrote: > On Thu, Jan 25, 2018 at 10:52:57AM +, Stefan Hajnoczi wrote: > > On Tue, Jan 23, 2018 at 08:48:15AM -0600, Eric Blake wrote: > > > On 01/22/2018 10:40 PM, River Chiang wrote: > > > > Signed-off-by: River Chiang > > > >

  1   2   3   4   >