Re: [Qemu-devel] [qemu-web PATCH] Link to git web view on contribute page

2018-01-26 Thread Thomas Huth
On 25.01.2018 20:03, Eric Blake wrote: > I was looking for a web view of qemu.git for reference, but > my first try was at https://www.qemu.org/contribute/ which > mentions how to clone but with no link for browsing. Meanwhile, > the download page pointed people to the list of all repos (and > eve

[Qemu-devel] [PULL 5/5] usb-ccid: convert CCIDCardClass::exitfn() -> unrealize()

2018-01-26 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-id: 20180125171432.13554-4-f4...@amsat.org Signed-off-by: Gerd Hoffmann --- hw/usb/ccid.h | 4 +++- hw/usb/ccid-card-emulated.c | 4 ++-- hw/usb/ccid-card-passthru.c | 1 + hw/usb/dev-smartcard-re

[Qemu-devel] [PULL 1/5] usb: Remove legacy -usbdevice options (host, serial, disk and net)

2018-01-26 Thread Gerd Hoffmann
From: Thomas Huth The option have been marked as deprecated since QEMU 2.10, and so far nobody complained that the host, serial, disk and net options are urgently required anymore. So let's now get rid at least of this legacy pile, to simplify the usb code quite a bit. This patch removes the usb

[Qemu-devel] [PULL 4/5] usb-ccid: inline ccid_card_initfn() in ccid_card_realize()

2018-01-26 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-id: 20180125171432.13554-3-f4...@amsat.org Signed-off-by: Gerd Hoffmann --- hw/usb/dev-smartcard-reader.c | 25 +++-- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/hw/usb/dev-smartca

[Qemu-devel] [PATCH v11 13/20] target/arm: Use vector infrastructure for aa64 mov/not/neg

2018-01-26 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 42 -- 1 file changed, 36 insertions(+), 6 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 5a4e62ae0f..11310f1a7a 100644 -

Re: [Qemu-devel] [PATCH v2 09/11] target/arm: Decode aa64 armv8.3 fcmla

2018-01-26 Thread Richard Henderson
On 01/15/2018 10:18 AM, Peter Maydell wrote: >> +void HELPER(gvec_fcmlah)(void *vd, void *vn, void *vm, >> + void *vfpst, uint32_t desc) >> +{ >> +uintptr_t opr_sz = simd_oprsz(desc); >> +float16 *d = vd; >> +float16 *n = vn; >> +float16 *m = vm; >> +floa

[Qemu-devel] [PULL] Update OpenBIOS images

2018-01-26 Thread Mark Cave-Ayland
Hi Peter, Here are the latest OpenBIOS updates (mainly the power support for SPARC). Please pull. ATB, Mark. The following changes since commit 2077fef91d5eb8e3745a84fabd87a5ee7d2b535d: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20180125' into staging (2018-01-25

[Qemu-devel] [PULL 3/7] ps2: check PS2Queue pointers in post_load routine

2018-01-26 Thread Gerd Hoffmann
From: Prasad J Pandit During Qemu guest migration, a destination process invokes ps2 post_load function. In that, if 'rptr' and 'count' values were invalid, it could lead to OOB access or infinite loop issue. Add check to avoid it. Reported-by: Cyrille Chatras Signed-off-by: Prasad J Pandit Me

Re: [Qemu-devel] [PATCH v2 0/4] memory/vfio: notify region_del() when unregister listeners

2018-01-26 Thread Paolo Bonzini
On 22/01/2018 07:02, Peter Xu wrote: > v2 > - add begin() hooks [Paolo] > - move vfio patch to front [Paolo] > - one more patch for arm devlistener unregister [Paolo] > - one more patch for vhost traces > - removing RFC tag > > This series fixes bug reported here: > > https://bugzilla.redhat.co

[Qemu-devel] [PATCH 3/3] input: add missing newline from trace-events

2018-01-26 Thread Mark Cave-Ayland
This was accidentally omitted from 77cb0f5aaf "Split adb.c into adb.c, adb-mouse.c and adb-kbd.c". Signed-off-by: Mark Cave-Ayland --- hw/input/trace-events | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/input/trace-events b/hw/input/trace-events index a8d46cb766..5affabc81d 100644 ---

[Qemu-devel] [PULL 0/5] Usb 20180126 v3 patches

2018-01-26 Thread Gerd Hoffmann
The following changes since commit 2077fef91d5eb8e3745a84fabd87a5ee7d2b535d: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20180125' into staging (2018-01-25 17:04:47 +) are available in the git repository at: git://git.kraxel.org/qemu tags/usb-201801

[Qemu-devel] [PULL 1/7] input: add mouse side buttons to virtio input

2018-01-26 Thread Gerd Hoffmann
From: Miika S Signed-off-by: Miika S Message-Id: <20171222152531.1849-3-miika9...@gmail.com> Signed-off-by: Gerd Hoffmann --- hw/input/virtio-input-hid.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/input/virtio-input-hid.c b/hw/input/virtio-input-hid.c index e78faec0b1..a5917c2754

[Qemu-devel] [PULL 4/7] hw: convert ps2 device to keycodemapdb

2018-01-26 Thread Gerd Hoffmann
From: "Daniel P. Berrange" Replace the qcode_to_keycode_set1, qcode_to_keycode_set2, and qcode_to_keycode_set3 tables with automatically generated tables. Missing entries in qcode_to_keycode_set1 now fixed: - Q_KEY_CODE_SYSRQ -> 0x54 - Q_KEY_CODE_PRINT -> 0x54 (NB ignored due to special case)

[Qemu-devel] [PULL 0/7] Input 20180126 patches

2018-01-26 Thread Gerd Hoffmann
The following changes since commit 2077fef91d5eb8e3745a84fabd87a5ee7d2b535d: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20180125' into staging (2018-01-25 17:04:47 +) are available in the git repository at: git://git.kraxel.org/qemu tags/input-201

[Qemu-devel] [qemu-web PATCH] Add "Understanding QEMU devices" blog post

2018-01-26 Thread Thomas Huth
Last July, Eric Blake wrote a nice summary for newcomers about what QEMU has to do to emulate devices for the guests. So far, we missed to integrate this somewhere into the QEM web site or wiki, so let's publish this now as a nice blog post for the users. Signed-off-by: Thomas Huth --- _posts/20

Re: [Qemu-devel] [PATCH] i2c: Add a CONFIG_I2C master switch to the configuration files

2018-01-26 Thread Paolo Bonzini
On 22/01/2018 16:27, Thomas Huth wrote: > The i2c core and the at24c EEPROM should only be compiled and linked > on the machines that support i2c. Otherwise it's quite strange to see > the at24c-eeprom to be "available" on qemu-system-s390x for example. > > Signed-off-by: Thomas Huth > --- > def

[Qemu-devel] [PULL 6/7] ui: fix alphabetical ordering of keymaps

2018-01-26 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The qcode-to-linux keymaps was accidentally added in the wrong place by commit de80d78594b4c3767a12d8d42debcf12cbf85a5b Author: Owen Smith Date: Fri Nov 3 11:56:28 2017 + ui: generate qcode to linux mappings breaking the alphabetical ordering of keym

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 07/10] s390-ccw: read stage2 boot loader data to find menu

2018-01-26 Thread Thomas Huth
On 25.01.2018 16:49, Collin L. Walling wrote: > On 01/25/2018 10:25 AM, Thomas Huth wrote: >> On 23.01.2018 19:26, Collin L. Walling wrote: >>> Read the stage2 boot loader data block-by-block. We scan the >>> current block for the string "zIPL" to detect the start of the >>> boot menu banner. We th

[Qemu-devel] QEMU related blogs, all in once place

2018-01-26 Thread Stefan Hajnoczi
If you want to follow blogs from QEMU contributors check out: https://planet.virt-tools.org/ Daniel Berrange has provided the following steps for adding your own blog to planet.virt-tools.org: $ git clone git://libvirt.org/virttools-planet.git and add your blog info to updater/virt-tools/conf

Re: [Qemu-devel] [PATCH] monitor: Remove legacy "-mon default=on" parameter

2018-01-26 Thread Paolo Bonzini
On 22/01/2018 20:35, Dr. David Alan Gilbert wrote: > * Thomas Huth (th...@redhat.com) wrote: >> The "default" parameter of the "-mon" option is useless since >> QEMU v2.4.0, and marked as deprecated since QEMU v2.8.0. That >> should have been long enough to let people update their scripts, >> so ti

Re: [Qemu-devel] [PATCH 2/2] ept_emulation_fault() need NetApp BSD attribution:

2018-01-26 Thread Izik Eidus
On Fri, Jan 26, 2018 at 11:39 AM, Paolo Bonzini wrote: > On 23/01/2018 13:36, Izik Eidus wrote: >> Moving it to a new file and add the BSD license there. >> >> Signed-off-by: Izik Eidus > > Since it's compatible, I'm just adding the NetApp BSD license to the file. Sure. > > What is the original

Re: [Qemu-devel] [qemu-web PATCH] Add "Understanding QEMU devices" blog post

2018-01-26 Thread Kashyap Chamarthy
On Fri, Jan 26, 2018 at 10:19:30AM +0100, Thomas Huth wrote: > Last July, Eric Blake wrote a nice summary for newcomers about what > QEMU has to do to emulate devices for the guests. So far, we missed > to integrate this somewhere into the QEM web site or wiki, so let's > publish this now as a nice

Re: [Qemu-devel] [PATCH v4 09/10] s390-ccw: read user input for boot index via the SCLP console

2018-01-26 Thread Thomas Huth
On 23.01.2018 19:26, Collin L. Walling wrote: > Implements an sclp_read function to capture input from the > console and a wrapper function that handles parsing certain > characters and adding input to a buffer. The input is checked > for any erroneous values and is handled appropriately. > > A pr

Re: [Qemu-devel] [PATCH] migration/savevm.c: do not fail when len > MAX_VM_CMD_PACKAGED_SIZE

2018-01-26 Thread Dr. David Alan Gilbert
* Daniel Henrique Barboza (danie...@linux.vnet.ibm.com) wrote: > MAX_VM_CMD_PACKAGED_SIZE is a constant used in qemu_savevm_send_packaged > and loadvm_handle_cmd_packaged to determine whether a package is too > big to be sent or received. qemu_savevm_send_packaged is called inside > postcopy_start

[Qemu-devel] [PATCH v3] tpm: add CRB device

2018-01-26 Thread Marc-André Lureau
tpm_crb is a device for TPM 2.0 Command Response Buffer (CRB) Interface as defined in TCG PC Client Platform TPM Profile (PTP) Specification Family “2.0” Level 00 Revision 01.03 v22. The PTP allows device implementation to switch between TIS and CRB model at run time, but given that CRB is a simpl

Re: [Qemu-devel] [PATCH 1/1] nbd: implement bdrv_get_info callback

2018-01-26 Thread Edgar Kaziakhmedov
PIng So, let me know if I need to make any changes in patch On 1/18/18 1:09 PM, Paolo Bonzini wrote: On 18/01/2018 12:51, Edgar Kaziakhmedov wrote: +static int nbd_get_info(BlockDriverState *bs, BlockDriverInfo *bdi) +{ +if (bs->supported_zero_flags & BDRV_REQ_MAY_UNMAP) { +bdi->ca

Re: [Qemu-devel] [PATCH v2] docs: update information for TLS certificate management

2018-01-26 Thread Kashyap Chamarthy
On Thu, Jan 25, 2018 at 05:09:30PM +, Daniel P. Berrangé wrote: > From: "Daniel P. Berrange" [...] > +@node vnc_setup_sasl > + > +@subsection Configuring SASL mechanisms > + > +The following documentation assumes use of the Cyrus SASL implementation on a > +Linux host, but the principals sho

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/6] arm: support -cpu max (and gic-version=max)

2018-01-26 Thread Eduardo Habkost
On Thu, Jan 25, 2018 at 03:10:31PM +, Peter Maydell wrote: > On 25 January 2018 at 14:41, Peter Maydell wrote: > > On 22 January 2018 at 18:33, Eduardo Habkost wrote: > >> About QOM type names: > >> > >> On x86, all CPU models are resolved to "-", and > >> i386 and x86_64 have different suffi

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/6] arm: support -cpu max (and gic-version=max)

2018-01-26 Thread Eduardo Habkost
On Thu, Jan 25, 2018 at 02:41:50PM +, Peter Maydell wrote: > On 22 January 2018 at 18:33, Eduardo Habkost wrote: > > About QOM type names: > > > > On x86, all CPU models are resolved to "-", and > > i386 and x86_64 have different suffixes. So the QOM type name is > > "max-x86_64-cpu" on qemu-

Re: [Qemu-devel] [PATCH 2/2] ept_emulation_fault() need NetApp BSD attribution:

2018-01-26 Thread Paolo Bonzini
On 23/01/2018 13:36, Izik Eidus wrote: > Moving it to a new file and add the BSD license there. > > Signed-off-by: Izik Eidus Since it's compatible, I'm just adding the NetApp BSD license to the file. What is the original source? xhyve or something like that? Paolo > --- > target/i386/hvf/e

Re: [Qemu-devel] [PATCH v3] tpm: add CRB device

2018-01-26 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180126120306.19225-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH v3] tpm: a

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-26 Thread Paolo Bonzini
On 25/01/2018 22:33, Pavel Pisa wrote: > Hello Paolo, > > thanks for suggestions. I understand and fully agree with your > request to switch to QOM. I have succeed with that for CAN devices > some time ago. It worth to be done for the rest of the objects > but I fear that I do not find time to com

Re: [Qemu-devel] [PATCH v3] tpm: add CRB device

2018-01-26 Thread no-reply
Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180126120306.19225-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH v3] tpm:

Re: [Qemu-devel] [PATCH] Drop remaining bits of ia64 host support

2018-01-26 Thread Paolo Bonzini
On 25/01/2018 17:19, Peter Maydell wrote: > We dropped support for ia64 host CPUs in the 2.11 release (removing > the TCG backend for it, and advertising the support as being > completely removed in the changelog). However there are a few bits > and pieces of code still floating about. Remove tho

Re: [Qemu-devel] [PATCH v2] sockets: fix parsing of ipv4/ipv6 opts in parse_socket_addr

2018-01-26 Thread Paolo Bonzini
On 25/01/2018 18:14, Daniel P. Berrangé wrote: > From: "Daniel P. Berrange" > > The inet_parse() function looks for 'ipv4' and 'ipv6' flags, but only > treats them as bare bool flags. The normal QemuOpts parsing would allow > on/off values to be set too. > > This updates inet_parse() so that its

Re: [Qemu-devel] QEMU related blogs, all in once place

2018-01-26 Thread Daniel P . Berrangé
On Fri, Jan 26, 2018 at 09:52:21AM +, Stefan Hajnoczi wrote: > If you want to follow blogs from QEMU contributors check out: > > https://planet.virt-tools.org/ > > Daniel Berrange has provided the following steps for adding your own > blog to planet.virt-tools.org: > > $ git clone git://li

[Qemu-devel] [PATCH v2 2/2] i386: Add support to get/set/migrate Intel Processor Trace feature

2018-01-26 Thread Luwei Kang
From: Chao Peng Add Intel Processor Trace related definition. It also add corresponding part to kvm_get/set_msr and vmstate. Signed-off-by: Luwei Kang Signed-off-by: Chao Peng --- target/i386/cpu.h | 22 ++ target/i386/kvm.c | 51 +++

[Qemu-devel] [PATCH v2 1/2] i386: Add Intel Processor Trace feature support

2018-01-26 Thread Luwei Kang
From: Chao Peng Expose Intel Processor Trace feature to guest. In order to make this feature migration-safe, new feature word information "FEAT_INTEL_PT_EBX" and "FEAT_INTEL_PT_ECX" be added. Some constant value initialized in CPUID[0x14].0x01 to guarantee get same result in diffrent hardware wh

Re: [Qemu-devel] [PATCH 3/6] target/arm: Move definition of 'host' cpu type into cpu.c

2018-01-26 Thread Philippe Mathieu-Daudé
On 12/07/2017 03:14 PM, Peter Maydell wrote: > Move the definition of the 'host' cpu type into cpu.c, where all the > other CPU types are defined. We can do this now we've decoupled it > from the KVM-specific host feature probing. This means we now create > the type unconditionally (assuming we w

Re: [Qemu-devel] [PATCH v2 06/11] target/arm: Decode aa32 armv8.1 two reg and a scalar

2018-01-26 Thread Peter Maydell
On 26 January 2018 at 07:18, Richard Henderson wrote: > On 01/15/2018 09:47 AM, Peter Maydell wrote: >> On 18 December 2017 at 17:24, Richard Henderson >> wrote: >>> Signed-off-by: Richard Henderson >>> --- >>> target/arm/translate.c | 38 +++--- >>> 1 file chang

[Qemu-devel] [PULL v2 3/9] xlnx-zynqmp-pmu: Add the CPU and memory

2018-01-26 Thread Edgar E. Iglesias
From: Alistair Francis Connect the MicroBlaze CPU and the ROM and RAM memory regions. Signed-off-by: Alistair Francis Reviewed-by: Edgar E. Iglesias Signed-off-by: Edgar E. Iglesias --- hw/microblaze/xlnx-zynqmp-pmu.c | 70 +++-- 1 file changed, 68 inserti

[Qemu-devel] [PULL v2 4/9] aarch64-softmmu.mak: Use an ARM specific config

2018-01-26 Thread Edgar E. Iglesias
From: Alistair Francis In preperation for having an ARM and MicroBlaze ZynqMP machine let's split out the current ARM specific config options. Signed-off-by: Alistair Francis Acked-by: Peter Maydell Reviewed-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Edgar E. Ig

[Qemu-devel] [PULL 2/5] usb-storage: Fix share-rw option parsing

2018-01-26 Thread Gerd Hoffmann
From: Fam Zheng Because usb-storage creates an internal scsi device, we should propagate options. We already do so for bootindex etc, but failed to take care of share-rw. Fix it in an apparent way: add a new parameter to scsi_bus_legacy_add_drive and pass in s->conf.share_rw. Cc: qemu-sta...@non

[Qemu-devel] [PULL v2 7/9] xlnx-zynqmp-ipi: Initial version of the Xilinx IPI device

2018-01-26 Thread Edgar E. Iglesias
From: Alistair Francis This is the initial version of the Inter Processor Interrupt device. Signed-off-by: Alistair Francis Reviewed-by: Edgar E. Iglesias Signed-off-by: Edgar E. Iglesias --- hw/intc/Makefile.objs | 1 + hw/intc/xlnx-zynqmp-ipi.c | 377 +

Re: [Qemu-devel] [PATCH v3] tpm: add CRB device

2018-01-26 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180126120306.19225-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH v3] tpm: add CRB device === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git ch

[Qemu-devel] [PATCH 0/3] ppc: trivial Mac-related trace-events patches

2018-01-26 Thread Mark Cave-Ayland
Here is a set of trivial PPC patches which convert grackle and uninorth over to use trace-events, and also add a missing newline to hw/input/trace-events which was accidentally omitted when previously converting the ADB devices. Signed-off-by: Mark Cave-Ayland Mark Cave-Ayland (3): grackle: co

[Qemu-devel] [PULL 3/5] hw/usb/ccid: Make ccid_card_init() take an error parameter

2018-01-26 Thread Gerd Hoffmann
From: Mao Zhongyi Replace init() of CCIDCardClass with realize, then convert ccid_card_init(), ccid_card_initfn() and it's callbacks to take an Error** in ordor to report the error more clearly. Signed-off-by: Mao Zhongyi Signed-off-by: Cao jin Signed-off-by: Philippe Mathieu-Daudé Message-id

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/6] hw/arm/virt: Check that the CPU realize method succeeded

2018-01-26 Thread Philippe Mathieu-Daudé
On 12/07/2017 03:14 PM, Peter Maydell wrote: > We were passing a NULL error pointer to the object_property_set_bool() > call that realizes the CPU object. This meant that we wouldn't detect > failure, and would plough blindly on to crash later trying to use a > NULL CPU object pointer. Detect error

Re: [Qemu-devel] [PATCH v3] tpm: add CRB device

2018-01-26 Thread Marc-Andre Lureau
Hi, Stash this to fix test leaks: diff --git a/tests/tpm-crb-test.c b/tests/tpm-crb-test.c index de78a28844..8bf1507e00 100644 --- a/tests/tpm-crb-test.c +++ b/tests/tpm-crb-test.c @@ -81,6 +81,7 @@ static void *emu_tpm_thread(void *data) g_free(s->tpm_msg); s->tpm_msg = NULL; +obj

Re: [Qemu-devel] [PULL 0/8] Ui 20180125 patches

2018-01-26 Thread Peter Maydell
On 25 January 2018 at 14:32, Gerd Hoffmann wrote: > The following changes since commit 834a336eb911db8a8ca00e760ee6a85faca19414: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2018-01-24 19:24:26 +) > > are available in the git repository at: > > git://gi

Re: [Qemu-devel] [PULL] Update OpenBIOS images

2018-01-26 Thread Peter Maydell
On 26 January 2018 at 08:16, Mark Cave-Ayland wrote: > Hi Peter, > > Here are the latest OpenBIOS updates (mainly the power support for SPARC). > Please pull. > > > ATB, > > Mark. > > > The following changes since commit 2077fef91d5eb8e3745a84fabd87a5ee7d2b535d: > > Merge remote-tracking branch

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/6] hw/arm/virt: Check that the CPU realize method succeeded

2018-01-26 Thread Peter Maydell
On 26 January 2018 at 14:32, Philippe Mathieu-Daudé wrote: > On 12/07/2017 03:14 PM, Peter Maydell wrote: >> We were passing a NULL error pointer to the object_property_set_bool() >> call that realizes the CPU object. This meant that we wouldn't detect >> failure, and would plough blindly on to cr

[Qemu-devel] [PATCH v3 02/39] qcow2: Add table size field to Qcow2Cache

2018-01-26 Thread Alberto Garcia
The table size in the qcow2 cache is currently equal to the cluster size. This doesn't allow us to use the cache memory efficiently, particularly with large cluster sizes, so we need to be able to have smaller cache tables that are independent from the cluster size. This patch adds a new field to Q

[Qemu-devel] [PATCH v3 15/39] qcow2: Update l2_load() to support L2 slices

2018-01-26 Thread Alberto Garcia
Each entry in the qcow2 L2 cache stores a full L2 table (which uses a complete cluster in the qcow2 image). A cluster is usually too large to be used efficiently as the size for a cache entry, so we want to decouple both values by allowing smaller cache entries. Therefore the qcow2 L2 cache will no

[Qemu-devel] [PULL v2 1/9] microblaze: boot.c: Don't try to find NULL file

2018-01-26 Thread Edgar E. Iglesias
From: Alistair Francis Previously if no device tree was passed to microblaze_load_kernel() then qemu_find_file() would try to find a NULL pointer. To avoid this put a check around qemu_find_file(). Signed-off-by: Alistair Francis Reported-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] [Bug 1737194] Re: Windows NT 4.0 fails to boot from qcow2 installation

2018-01-26 Thread David Lindsay
Hi John & others: (3 separate things.) 1: Image formats Regarding qcow, unfortunately there is no change if I use this format. - Windows 3.1 initially hung at "Starting MS-DOS..."; upon restart it crashed when it decided it couldn't find COMMAND.COM (a frequent failure mode I forgot to mention)

[Qemu-devel] [PATCH v3 16/39] qcow2: Prepare l2_allocate() for adding L2 slice support

2018-01-26 Thread Alberto Garcia
Adding support for L2 slices to l2_allocate() needs (among other things) an extra loop that iterates over all slices of a new L2 table. Putting all changes in one patch would make it hard to read because all semantic changes would be mixed with pure indentation changes. To make things easier this

[Qemu-devel] [PATCH v3 18/39] qcow2: Refactor get_cluster_table()

2018-01-26 Thread Alberto Garcia
After the previous patch we're now always using l2_load() in get_cluster_table() regardless of whether a new L2 table has to be allocated or not. This patch refactors that part of the code to use one single l2_load() call. Signed-off-by: Alberto Garcia --- block/qcow2-cluster.c | 21 +++

[Qemu-devel] [PATCH v3 12/39] qcow2: Add offset_to_l1_index()

2018-01-26 Thread Alberto Garcia
Similar to offset_to_l2_index(), this function returns the index in the L1 table for a given guest offset. This is only used in a couple of places and it's not a particularly complex calculation, but it makes the code a bit more readable. Although in the qcow2_get_cluster_offset() case the old cod

[Qemu-devel] [PATCH v3 03/39] qcow2: Remove BDS parameter from qcow2_cache_get_table_addr()

2018-01-26 Thread Alberto Garcia
This function was only using the BlockDriverState parameter to get the cache table size (since it was equal to the cluster size). This is no longer necessary so this parameter can be removed. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake --- block/qcow2-cache.c | 13 ++--- 1 fil

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 06/11] target/arm: Decode aa32 armv8.1 two reg and a scalar

2018-01-26 Thread Philippe Mathieu-Daudé
On 12/18/2017 02:24 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/translate.c | 38 +++--- > 1 file changed, 35 insertions(+), 3 deletions(-) > > diff --git a/target/arm/translate.c b/targ

[Qemu-devel] [PULL 2/7] input: virtio: don't send mouse wheel event twice

2018-01-26 Thread Gerd Hoffmann
From: Miika S On Linux, a mouse event is generated for both down and up when mouse wheel is used. This caused virtio_input_send() to be called twice each time the wheel was used. This commit adds a check for the button down state and only calls virtio_input_send() when it is true. Signed-off-by

Re: [Qemu-devel] [PULL 0/7] Input 20180126 patches

2018-01-26 Thread Peter Maydell
; > are available in the git repository at: > > git://git.kraxel.org/qemu tags/input-20180126-pull-request > > for you to fetch changes up to d0b610a55b81bdc485c877ef0466895fd40e8d6f: > > hw: convert virtio-input-hid dev

Re: [Qemu-devel] [PULL 0/5] Usb 20180126 v3 patches

2018-01-26 Thread Peter Maydell
; > are available in the git repository at: > > git://git.kraxel.org/qemu tags/usb-20180126-v3-pull-request > > for you to fetch changes up to 80ae865468bde918363a123aa26c6fc4385023ac: > > usb-ccid: convert CCIDCardClass::exit

[Qemu-devel] [PULL v2 5/9] xlnx-pmu-iomod-intc: Add the PMU Interrupt controller

2018-01-26 Thread Edgar E. Iglesias
From: Alistair Francis Add the PMU IO Module Interrupt controller device. Signed-off-by: Alistair Francis Reviewed-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Edgar E. Iglesias --- default-configs/microblaze-softmmu.mak | 1 + hw/intc/Makefile.objs

[Qemu-devel] [PATCH v3 37/39] iotests: Test valid values of l2-cache-entry-size

2018-01-26 Thread Alberto Garcia
The l2-cache-entry-size setting can only contain values that are powers of two between 512 and the cluster size. Signed-off-by: Alberto Garcia --- tests/qemu-iotests/103 | 17 + tests/qemu-iotests/103.out | 3 +++ 2 files changed, 20 insertions(+) diff --git a/tests/qemu-io

[Qemu-devel] [PATCH v3 27/39] qcow2: Update qcow2_update_snapshot_refcount() to support L2 slices

2018-01-26 Thread Alberto Garcia
qcow2_update_snapshot_refcount() increases the refcount of all clusters of a given snapshot. In order to do that it needs to load all its L2 tables and iterate over their entries. Since we'll be loading L2 slices instead of full tables we need to add an extra loop that iterates over all slices of e

[Qemu-devel] [PATCH v3 39/39] iotests: Add l2-cache-entry-size to iotest 137

2018-01-26 Thread Alberto Garcia
This test tries reopening a qcow2 image with valid and invalid options. This patch adds l2-cache-entry-size to the set. Signed-off-by: Alberto Garcia --- tests/qemu-iotests/137 | 5 + tests/qemu-iotests/137.out | 2 ++ 2 files changed, 7 insertions(+) diff --git a/tests/qemu-iotests/137

[Qemu-devel] [PATCH v3 19/39] qcow2: Update get_cluster_table() to support L2 slices

2018-01-26 Thread Alberto Garcia
This patch updates get_cluster_table() to return L2 slices instead of full L2 tables. The code itself needs almost no changes, it only needs to call offset_to_l2_slice_index() instead of offset_to_l2_index(). This patch also renames all the relevant variables and the documentation. Signed-off-by:

[Qemu-devel] [PATCH v3 35/39] qcow2: Rename l2_table in count_cow_clusters()

2018-01-26 Thread Alberto Garcia
This function doesn't need any changes to support L2 slices, but since it's now dealing with slices intead of full tables, the l2_table variable is renamed for clarity. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake --- block/qcow2-cluster.c | 4 ++-- 1 file changed, 2 insertions(+), 2 d

[Qemu-devel] [PATCH v3 04/39] qcow2: Remove BDS parameter from qcow2_cache_get_table_idx()

2018-01-26 Thread Alberto Garcia
This function was only using the BlockDriverState parameter to get the cache table size (since it was equal to the cluster size). This is no longer necessary so this parameter can be removed. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake --- block/qcow2-cache.c | 9 - 1 file cha

[Qemu-devel] [PATCH v3 01/39] qcow2: Fix documentation of get_cluster_table()

2018-01-26 Thread Alberto Garcia
This function has not been returning the offset of the L2 table since commit 3948d1d4876065160583e79533bf604481063833 Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake --- block/qcow2-cluster.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/qcow2-cluster.c b/blo

[Qemu-devel] [PATCH v3 34/39] qcow2: Rename l2_table in count_contiguous_clusters_unallocated()

2018-01-26 Thread Alberto Garcia
This function doesn't need any changes to support L2 slices, but since it's now dealing with slices intead of full tables, the l2_table variable is renamed for clarity. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake --- block/qcow2-cluster.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[Qemu-devel] [PATCH v3 10/39] qcow2: Remove BDS parameter from qcow2_cache_discard()

2018-01-26 Thread Alberto Garcia
This function was only using the BlockDriverState parameter to pass it to qcow2_cache_get_table_idx() and qcow2_cache_table_release(). This is no longer necessary so this parameter can be removed. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake --- block/qcow2-cache.c| 2 +- block/qco

[Qemu-devel] [PATCH v3 20/39] qcow2: Update qcow2_get_cluster_offset() to support L2 slices

2018-01-26 Thread Alberto Garcia
qcow2_get_cluster_offset() checks how many contiguous bytes are available at a given offset. The returned number of bytes is limited by the amount that can be addressed without having to load more than one L2 table. Since we'll be loading L2 slices instead of full tables this patch changes the lim

[Qemu-devel] [PATCH v3 17/39] qcow2: Update l2_allocate() to support L2 slices

2018-01-26 Thread Alberto Garcia
This patch updates l2_allocate() to support the qcow2 cache returning L2 slices instead of full L2 tables. The old code simply gets an L2 table from the cache and initializes it with zeroes or with the contents of an existing table. With a cache that returns slices instead of tables the idea remai

[Qemu-devel] [PATCH v3 06/39] qcow2: Remove BDS parameter from qcow2_cache_entry_mark_dirty()

2018-01-26 Thread Alberto Garcia
This function was only using the BlockDriverState parameter to pass it to qcow2_cache_get_table_idx(). This is no longer necessary so this parameter can be removed. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake --- block/qcow2-cache.c| 3 +-- block/qcow2-cluster.c | 12 ++-

[Qemu-devel] [PATCH v3 32/39] qcow2: Rename l2_table in qcow2_alloc_compressed_cluster_offset()

2018-01-26 Thread Alberto Garcia
This function doesn't need any changes to support L2 slices, but since it's now dealing with slices instead of full tables, the l2_table variable is renamed for clarity. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake --- block/qcow2-cluster.c | 16 1 file changed, 8 inse

[Qemu-devel] [PATCH v3 28/39] qcow2: Read refcount before L2 table in expand_zero_clusters_in_l1()

2018-01-26 Thread Alberto Garcia
At the moment it doesn't really make a difference whether we call qcow2_get_refcount() before of after reading the L2 table, but if we want to support L2 slices we'll need to read the refcount first. This patch simply changes the order of those two operations to prepare for that. The patch with th

[Qemu-devel] [PATCH v3 08/39] qcow2: Remove BDS parameter from qcow2_cache_destroy()

2018-01-26 Thread Alberto Garcia
This function was never using the BlockDriverState parameter so it can be safely removed. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake --- block/qcow2-cache.c | 2 +- block/qcow2.c | 16 block/qcow2.h | 2 +- 3 files changed, 10 insertions(+), 10 deletion

[Qemu-devel] [PATCH v3 38/39] iotests: Test downgrading an image using a small L2 slice size

2018-01-26 Thread Alberto Garcia
expand_zero_clusters_in_l1() is used when downgrading qcow2 images from v3 to v2 (compat=0.10). This is one of the functions that needed more changes to support L2 slices, so this patch extends iotest 061 to test downgrading a qcow2 image using a smaller slice size. Signed-off-by: Alberto Garcia

[Qemu-devel] [PATCH v3 09/39] qcow2: Remove BDS parameter from qcow2_cache_clean_unused()

2018-01-26 Thread Alberto Garcia
This function was only using the BlockDriverState parameter to pass it to qcow2_cache_table_release(). This is no longer necessary so this parameter can be removed. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake --- block/qcow2-cache.c | 2 +- block/qcow2.c | 4 ++-- block/qcow2.h

[Qemu-devel] [PATCH v3 31/39] qcow2: Update qcow2_truncate() to support L2 slices

2018-01-26 Thread Alberto Garcia
The qcow2_truncate() code is mostly independent from whether we're using L2 slices or full L2 tables, but in full and falloc preallocation modes new L2 tables are allocated using qcow2_alloc_cluster_link_l2(). Therefore the code needs to be modified to ensure that all nb_clusters that are processe

[Qemu-devel] [PATCH v3 00/39] Allow configuring the qcow2 L2 cache entry size

2018-01-26 Thread Alberto Garcia
this is the new revision of the patch series to allow configuring the entry size of the qcow2 L2 cache. Follow this link for the full description from the first version: https://lists.gnu.org/archive/html/qemu-block/2017-10/msg00458.html And here are some numbers showing the performance improv

[Qemu-devel] [PATCH v3 13/39] qcow2: Add l2_slice_size field to BDRVQcow2State

2018-01-26 Thread Alberto Garcia
The BDRVQcow2State structure contains an l2_size field, which stores the number of 64-bit entries in an L2 table. For efficiency reasons we want to be able to load slices instead of full L2 tables, so we need to know how many entries an L2 slice can hold. An L2 slice is the portion of an L2 table

[Qemu-devel] [PATCH v3 11/39] qcow2: Remove BDS parameter from qcow2_cache_is_table_offset()

2018-01-26 Thread Alberto Garcia
This function was only using the BlockDriverState parameter to pass it to qcow2_cache_get_table_addr(). This is no longer necessary so this parameter can be removed. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake --- block/qcow2-cache.c| 3 +-- block/qcow2-refcount.c | 6 +++--- bloc

Re: [Qemu-devel] [PULL 0/8] M68k for 2.12 patches

2018-01-26 Thread Peter Maydell
On 25 January 2018 at 15:15, Laurent Vivier wrote: > The following changes since commit 0f79bfe38a2cf0f43c7ea4959da7f8ebd7858f3d: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-2.12-pull-request' into staging > (2018-01-25 09:53:53 +) > > are available in the Git r

Re: [Qemu-devel] [PATCH 4/6] target/arm: Add "-cpu max" support

2018-01-26 Thread Philippe Mathieu-Daudé
On 01/26/2018 11:33 AM, Peter Maydell wrote: > On 26 January 2018 at 14:29, Philippe Mathieu-Daudé wrote: >> Hi Peter, >> >> On 12/07/2017 03:14 PM, Peter Maydell wrote: >>> Add support for "-cpu max" for ARM guests. This CPU type behaves >>> like "-cpu host" when KVM is enabled, and like a system

Re: [Qemu-devel] [PATCH v10.5 04/20] tcg: Add generic vector expanders

2018-01-26 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson I'm slightly confused by the fact some previously added functions in this series are seeing changes. Is this just of an artefact of building up the TCG API in stages or should the changes be rolled into the original patches? Also th

[Qemu-devel] [PATCH v3] hw/char: remove legacy interface escc_init()

2018-01-26 Thread Laurent Vivier
Move necessary stuff in escc.h and update type names. Remove slavio_serial_ms_kbd_init(). Fix code style problems reported by checkpatch.pl Update mac_newworld, mac_oldworld and sun4m to use directly the QDEV interface. Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- Notes

Re: [Qemu-devel] [PATCH] hmp: Add nbd_server_remove to mirror QMP command

2018-01-26 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > Since everything else about the nbd-server-* QMP commands is > accessible from HMP, we might as well make removing an export > available as well. For now, I went with a bool flag rather > than a mode string for choosing between safe (default) and > hard mo

Re: [Qemu-devel] [PATCH 4/6] target/arm: Add "-cpu max" support

2018-01-26 Thread Philippe Mathieu-Daudé
Hi Peter, On 12/07/2017 03:14 PM, Peter Maydell wrote: > Add support for "-cpu max" for ARM guests. This CPU type behaves > like "-cpu host" when KVM is enabled, and like a system CPU with > the maximum possible feature set otherwise. (Note that this means > it won't be migratable across versions,

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-26 Thread Wei Huang
On 01/25/2018 02:05 PM, Dr. David Alan Gilbert wrote: > * Wei Huang (w...@redhat.com) wrote: >> This patch adds the migration test support for aarch64. The test code, >> which implements the same functionality as x86, is compiled into a binary >> and booted as a kernel in qemu. Here are the desig

[Qemu-devel] [PATCH v3 07/39] qcow2: Remove BDS parameter from qcow2_cache_put()

2018-01-26 Thread Alberto Garcia
This function was only using the BlockDriverState parameter to pass it to qcow2_cache_get_table_idx(). This is no longer necessary so this parameter can be removed. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake --- block/qcow2-cache.c| 2 +- block/qcow2-cluster.c | 28

[Qemu-devel] [PATCH v3 30/39] qcow2: Update expand_zero_clusters_in_l1() to support L2 slices

2018-01-26 Thread Alberto Garcia
expand_zero_clusters_in_l1() expands zero clusters as a necessary step to downgrade qcow2 images to a version that doesn't support metadata zero clusters. This function takes an L1 table (which may or may not be active) and iterates over all its L2 tables looking for zero clusters. Since we'll be

[Qemu-devel] [PATCH v3 25/39] qcow2: Update zero_single_l2() to support L2 slices

2018-01-26 Thread Alberto Garcia
zero_single_l2() limits the number of clusters to be zeroed to the amount that fits inside an L2 table. Since we'll be loading L2 slices instead of full tables we need to update that limit. Apart from that, this function doesn't need any additional changes, so this patch simply updates the variabl

[Qemu-devel] [PATCH v3 36/39] qcow2: Allow configuring the L2 slice size

2018-01-26 Thread Alberto Garcia
Now that the code is ready to handle L2 slices we can finally add an option to allow configuring their size. An L2 slice is the portion of an L2 table that is read by the qcow2 cache. Until now the cache was always reading full L2 tables, and since the L2 table size is equal to the cluster size th

[Qemu-devel] [PULL 3/8] qapi: add nbd-server-remove

2018-01-26 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Add command for removing an export. It is needed for cases when we don't want to keep the export after the operation on it was completed. The other example is a temporary node, created with blockdev-add. If we want to delete it we should firstly remove any corre

[Qemu-devel] [PULL 1/8] qapi: add name parameter to nbd-server-add

2018-01-26 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Allow user to specify name for new export, to not reuse internal node name and to not show it to clients. This also allows creating several exports per device. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-Id: <20180119135719.24

[Qemu-devel] [PATCH v2] migration: change blocktime type to uint32_t

2018-01-26 Thread Alexey Perevalov
Initially int64_t was used, but on PowerPC architecture, clang doesn't have atomic_*_8 function, so it produces link time error. QEMU is working with time as with 64bit value, but by fact 32 bit is enough with CLOCK_REALTIME. In this case blocktime will keep only 1200 hours time interval. Signed-

  1   2   3   >