On 12/07/2017 03:14 PM, Peter Maydell wrote: > We were passing a NULL error pointer to the object_property_set_bool() > call that realizes the CPU object. This meant that we wouldn't detect > failure, and would plough blindly on to crash later trying to use a > NULL CPU object pointer. Detect errors and fail instead. > > In particular, this will be necessary to detect the user error > of using "-cpu host" without "-enable-kvm" once we make the host > CPU type be registered unconditionally rather than only in > kvm_arch_init(). > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > hw/arm/virt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 151592b..62af013 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -1402,7 +1402,7 @@ static void machvirt_init(MachineState *machine) > "secure-memory", &error_abort); > } > > - object_property_set_bool(cpuobj, true, "realized", NULL); > + object_property_set_bool(cpuobj, true, "realized", &error_fatal); > object_unref(cpuobj); > } > fdt_add_timer_nodes(vms); >
