[Qemu-devel] [PATCH v2 04/16] block/mirror: Pull out mirror_perform()

When converting mirror's I/O to coroutines, we are going to need a point where these coroutines are created. mirror_perform() is going to be that point. Signed-off-by: Max Reitz Reviewed-by: Fam Zheng Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/mirror.c | 51 ++

[Qemu-devel] [PATCH v2 11/16] block/dirty-bitmap: Add bdrv_dirty_iter_next_area

This new function allows to look for a consecutively dirty area in a dirty bitmap. Signed-off-by: Max Reitz --- include/block/dirty-bitmap.h | 2 ++ block/dirty-bitmap.c | 51 2 files changed, 53 insertions(+) diff --git a/include/block/dirt

[Qemu-devel] [PATCH v2 16/16] iotests: Add test for active mirroring

Signed-off-by: Max Reitz --- tests/qemu-iotests/151 | 114 + tests/qemu-iotests/151.out | 5 ++ tests/qemu-iotests/group | 1 + 3 files changed, 120 insertions(+) create mode 100755 tests/qemu-iotests/151 create mode 100644 tests/qemu-iotest

[Qemu-devel] [PATCH v2 13/16] block/mirror: Add MirrorBDSOpaque

This will allow us to access the block job data when the mirror block driver becomes more complex. Signed-off-by: Max Reitz --- block/mirror.c | 12 1 file changed, 12 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index bb46f3c4e9..c1987b0230 100644 --- a/block/mirror.

[Qemu-devel] [PATCH v2 05/16] block/mirror: Convert to coroutines

In order to talk to the source BDS (and maybe in the future to the target BDS as well) directly, we need to convert our existing AIO requests into coroutine I/O requests. Signed-off-by: Max Reitz --- block/mirror.c | 154 ++--- 1 file changed,

[Qemu-devel] [PATCH v2 15/16] block/mirror: Add copy mode QAPI interface

This patch allows the user to specify whether to use active or only passive mode for mirror block jobs. Currently, this setting will remain constant for the duration of the entire block job. Signed-off-by: Max Reitz --- qapi/block-core.json | 11 +-- include/block/block_int.h | 4

[Qemu-devel] [PATCH v2 14/16] block/mirror: Add active mirroring

This patch implements active synchronous mirroring. In active mode, the passive mechanism will still be in place and is used to copy all initially dirty clusters off the source disk; but every write request will write data both to the source and the target disk, so the source cannot be dirtied fas

[Qemu-devel] [PATCH v2 08/16] block/mirror: Use source as a BdrvChild

With this, the mirror_top_bs is no longer just a technically required node in the BDS graph but actually represents the block job operation. Also, drop MirrorBlockJob.source, as we can reach it through mirror_top_bs->backing. Signed-off-by: Max Reitz --- block/mirror.c | 14 ++ 1 fi

[Qemu-devel] [PATCH v2 09/16] block: Generalize should_update_child() rule

Currently, bdrv_replace_node() refuses to create loops from one BDS to itself if the BDS to be replaced is the backing node of the BDS to replace it: Say there is a node A and a node B. Replacing B by A means making all references to B point to A. If B is a child of A (i.e. A has a reference to B

[Qemu-devel] [PATCH v2 10/16] hbitmap: Add @advance param to hbitmap_iter_next()

This new parameter allows the caller to just query the next dirty position without moving the iterator. Signed-off-by: Max Reitz --- include/qemu/hbitmap.h | 5 - block/backup.c | 2 +- block/dirty-bitmap.c | 2 +- tests/test-hbitmap.c | 26 +- util/hbi

[Qemu-devel] [PATCH v2 12/16] block/mirror: Distinguish active from passive ops

Currently, the mirror block job only knows passive operations. But once we introduce active writes, we need to distinguish between the two; for example, mirror_wait_for_free_in_flight_slot() should wait for a passive operation because active writes will not use the same in-flight slots. Signed-of

Re: [Qemu-devel] [PATCH v3 2/5] qapi: add nbd-server-remove

On 01/19/2018 07:57 AM, Vladimir Sementsov-Ogievskiy wrote: > Add command for removing an export. It is needed for cases when we > don't want to keep export after the operation on it was completed. > The other example is temporary node, created with blockdev-add. > If we want to delete it we should

Re: [Qemu-devel] [PATCH] tpm: Set the flags of the CMD_INIT command to 0

On Mon, Jan 22, 2018 at 10:33 PM, Stefan Berger wrote: > The flags of the CMD_INIT control channel command were not > initialized properly. Fix this and set to 0. > > Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau > --- > hw/tpm/tpm_emulator.c | 4 +++- > 1 file changed, 3 inser

Re: [Qemu-devel] [PATCH v3] ppc: Deprecate qemu-system-ppcemb

On Sun, Jan 21, 2018 at 10:57:58PM +0100, Thomas Huth wrote: > qemu-system-ppcemb has been once split of qemu-system-ppc to support > CPU page sizes < 4096 for some of the embedded 4xx PowerPC CPUs. > However, there was hardly any OS available in the wild that really > used such small page sizes (L

Re: [Qemu-devel] [PATCH] linux-user: implement renameat2

Le 22/01/2018 à 18:44, Andreas Schwab a écrit : > This is needed for new architectures like RISC-V which do not provide any > other rename-like syscall. > > Signed-off-by: Andreas Schwab > --- > linux-user/syscall.c | 33 + > 1 file changed, 33 insertions(+) > >

Re: [Qemu-devel] [PATCH] linux-user: implement renameat2

Le 22/01/2018 à 18:44, Andreas Schwab a écrit : > This is needed for new architectures like RISC-V which do not provide any > other rename-like syscall. > > Signed-off-by: Andreas Schwab > --- > linux-user/syscall.c | 33 + > 1 file changed, 33 insertions(+) > >

[Qemu-devel] [PATCH qemu v3] RFC: vfio-pci: Allow mmap of MSIX BAR

This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability which tells that a region with MSIX data can be mapped entirely, i.e. the VFIO PCI driver won't prevent MSIX vectors area from being mapped. With this change, all BARs are mapped in a single chunk and MSIX vectors are emulated o

[Qemu-devel] [PATCH v9 05/16] sdhci: add a check_capab_sdma() qtest

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index 5f036c8a75..f4c43b8120 100644 --- a/tests/sdhci-test.c +++ b/tests/sdhci-test.c @@ -15,6 +15,7

[Qemu-devel] [PATCH v9 01/16] sdhci: use error_propagate(local_err) in realize()

avoid the "errp && *errp" pattern (not recommended in "qapi/error.h" comments). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sdhci.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index f9264d3be5..8c9c0

[Qemu-devel] [PATCH v9 10/16] sdhci: check the Spec v1 capabilities correctness

Incorrect value will throw an error. Note than Spec v2 is supported by default. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci-internal.h | 21 ++- hw/sd/sdhci.c | 97 +- hw/sd/trace-events | 1 + 3 files changed, 117

[Qemu-devel] [PATCH v9 00/16] SDHCI: clean v1/v2 Specs (part 2)

Since v8: - we keep the 'capareg' property, this simplify a lot the series - the Zynq 7000 uses the datasheet CAPAREG - reset R-b/A-b Since v7: - use error_propagate() Since v6: - rebased on upstream to use DEFINE_SDHCI_COMMON_PROPERTIES - included qtests back - add PCI qtests - series was gettin

[Qemu-devel] [PATCH v9 06/16] sdhci: add qtest to check the SD Spec version

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index f4c43b8120..094e0570e1 100644 --- a/tests/sdhci-test.c +++ b/tests/sdhci-test.c

[Qemu-devel] [PATCH v9 16/16] hw/arm/xilinx_zynq: fix the capabilities register to match the datasheet

checking Xilinx datasheet "UG585" (v1.12.1) Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/xilinx_zynq.c | 53 tests/sdhci-test.c | 5 + 2 files changed, 34 insertions(+), 24 deletions(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xi

[Qemu-devel] [PATCH v9 04/16] sdhci: add a check_capab_baseclock() qtest

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index 4833dd4204..5f036c8a75 100644 --- a/tests/sdhci-test.c +++ b/tests/sdhci-test.c @@ -14,6 +14

[Qemu-devel] [PATCH v9 02/16] sdhci: add qtest to check the SD capabilities register

The PCI model is tested with the pc/x86_64 machine, the SysBus model with the smdkc210/arm machine. Signed-off-by: Philippe Mathieu-Daudé --- tests/sdhci-test.c | 134 + tests/Makefile.include | 3 ++ 2 files changed, 137 insertions(+) creat

[Qemu-devel] [PATCH v9 13/16] sdhci: check Spec v2 capabilities (DMA and 64-bit bus)

Incorrect value will throw an error. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci-internal.h | 14 +++--- hw/sd/sdhci.c | 19 +++ 2 files changed, 22 insertions(+), 11 deletions(-) diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h index c5e26

[Qemu-devel] [PATCH v9 03/16] sdhci: add check_capab_readonly() qtest

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index 517e2ed5a2..4833dd4204 100644 --- a/tests/sdhci-test.c +++ b/tests/sdhci-test.c

[Qemu-devel] [PATCH v9 08/16] sdhci: use a numeric value for the default CAPAB register

using many #defines is not portable when scaling to different HCI. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci.c | 74 +-- 1 file changed, 16 insertions(+), 58 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 1331062

[Qemu-devel] [PATCH v9 14/16] hw/arm/exynos4210: access the 64-bit capareg with qdev_prop_set_uint64()

We only set a 32-bit value, but this is a good practice in case this code is used as reference. (missed in 5efc9016e52) Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/exynos4210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c ind

[Qemu-devel] [PATCH v9 09/16] sdhci: simplify sdhci_get_fifolen()

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci-internal.h | 4 +++- hw/sd/sdhci.c | 20 +--- 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h index b7751c815f..577ca9da54 100644 --- a/hw/sd/sdhci-inter

[Qemu-devel] [PATCH v9 07/16] sdhci: add a 'spec_version property' (default to v2)

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sdhci-internal.h | 4 ++-- include/hw/sd/sdhci.h | 2 ++ hw/sd/sdhci.c | 27 +++ 3 files changed, 27 insertions(+), 6 deletions(-) diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-

[Qemu-devel] [PATCH v9 15/16] hw/arm/exynos4210: add a comment about a very similar SDHCI (Spec. v2)

Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/exynos4210.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c index d89322c7ea..06f9d1ffa4 100644 --- a/hw/arm/exynos4210.c +++ b/hw/arm/exynos4210.c @@ -377,6 +377,18 @@ Exynos4210State *e

[Qemu-devel] [PATCH v9 12/16] sdhci: Fix 64-bit ADMA2

From: Sai Pavan Boddu The 64-bit ADMA address is not converted to the cpu endianes correctly. This patch fixes the issue and uses a valid mask for the attribute data. Signed-off-by: Sai Pavan Boddu [AF: Re-write commit message] Reviewed-by: Alistair Francis --- hw/sd/sdhci.c | 4 ++-- 1 file

[Qemu-devel] virtio block device is not working

Hello people! I'm not able to boot any guest that sets a virtio block device like: (branch master) [PPC64] qemu-system-ppc64 -cpu POWER8 -nographic -vga none -m 4G -M pseries,accel=kvm,kvm-type=PR -drive file=disk.qcow2,if=virtio QEMU Starting Build Date = Dec 18 2017 13:08:00 FW Version = git

Re: [Qemu-devel] [PATCH] raw: Disable probing if image format is given by driver-specific options

On 01/23/2018 12:45 AM, Max Reitz wrote: On 2018-01-22 08:21, Lin Ma wrote: If the user specifies image format through driver-specific options, The format probing should be prohibited and the warning message should not be printed. e.g.: $ qemu-system-x86_64 ... -drive file.file.filename=disk0.

[Qemu-devel] [PATCH v8 01/14] sdhci: add support for v3 capabilities

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci-internal.h | 13 hw/sd/sdhci.c | 54 -- 2 files changed, 65 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h index 4ed9727ec3..911

[Qemu-devel] [PATCH v8 00/14] SDHCI: add tuning sequence for UHS-I cards (part 3)

This series add minimum features required by Spec v3 to support UHS-I cards. Since v7: - we keep the 'capareg' property, this simplify a lot the series - the ZynqMP uses the datasheet CAPAREG - reset R-b/A-b Note: https://www.google.com.ar/search?q=sdhci_imx0+caps show various console outpu

[Qemu-devel] [PATCH v8 03/14] sdhci: implement the Host Control 2 register (tuning sequence)

[based on a patch from Alistair Francis from qemu/xilinx tag xilinx-v2015.2] Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci-internal.h | 10 ++ include/hw/sd/sdhci.h | 1 + hw/sd/sdhci.c | 22 +++--- 3 files changed, 30 insertions(+), 3 deletions(-) di

[Qemu-devel] [PATCH v8 10/14] hw/arm/xilinx_zynqmp: fix the capabilities/spec version to match the datasheet

checking Xilinx datasheet "UG1085" (v1.7) Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/xlnx-zynqmp.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index 325642058b..33d5fe53d8 100644 --- a/hw/ar

[Qemu-devel] [PATCH v8 04/14] sdbus: add trace events

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/core.c | 14 -- hw/sd/trace-events | 5 + 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/sd/core.c b/hw/sd/core.c index 295dc44ab7..498284f109 100644 --- a/hw/sd/core.c +++ b/hw/sd/core.c @@ -23,6 +23,12 @@

[Qemu-devel] [PATCH v8 05/14] sdhci: implement UHS-I voltage switch

[based on a patch from Alistair Francis from qemu/xilinx tag xilinx-v2015.2] Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sd.h| 16 include/hw/sd/sdhci.h | 1 + hw/sd/core.c | 13 + hw/sd/sd.c| 13 + hw/sd/sdhci.c

[Qemu-devel] [PATCH v8 02/14] sdhci: rename the hostctl1 register

As per the Spec v3.00 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- include/hw/sd/sdhci.h | 2 +- hw/sd/sdhci.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/hw/sd/sdhci.h b/include/hw/sd/sdhci.h index 96e07de2a2..5a

[Qemu-devel] [PATCH v8 11/14] hw/arm/xilinx_zynqmp: enable the UHS-I mode

see the Xilinx datasheet "UG1085" (v1.7) Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/xlnx-zynqmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index 33d5fe53d8..bb4265a4ce 100644 --- a/hw/arm/xlnx-zynqmp.c +++ b/hw/arm/xlnx-zynqmp.c @@ -39

[Qemu-devel] [PATCH v8 06/14] sdhci: implement CMD/DAT[] fields in the Present State register

[based on a patch from Alistair Francis from qemu/xilinx tag xilinx-v2015.2] Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci-internal.h | 2 ++ include/hw/sd/sd.h | 4 hw/sd/core.c | 34 ++ hw/sd/sd.c | 16

[Qemu-devel] [PATCH v8 07/14] hw/arm/bcm2835_peripherals: implement SDHCI Spec. v3

Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/bcm2835_peripherals.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c index 12e0dd11af..0570cc4ad3 100644 --- a/hw/arm/bcm2835_peripherals.c +++

[Qemu-devel] [PATCH v8 12/14] sdhci: check Spec v3 capabilities qtest

Signed-off-by: Philippe Mathieu-Daudé --- tests/sdhci-test.c | 12 tests/Makefile.include | 1 + 2 files changed, 13 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index aae2cfc1b5..56eefdafd8 100644 --- a/tests/sdhci-test.c +++ b/tests/sdhci-test.c @@ -42,1

[Qemu-devel] [PATCH v8 08/14] hw/arm/bcm2835_peripherals: change maximum block size to 1kB

following the datasheet. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/bcm2835_peripherals.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c index 0570cc4ad3..6b86a99b14 100644 --- a/hw/arm/bcm2835_peripherals.c +

[Qemu-devel] [PATCH v8 09/14] hw/arm/fsl-imx6: implement SDHCI Spec. v3

Signed-off-by: Philippe Mathieu-Daudé --- various FreeBSD console output from google search show this register having a value of 0x0377c800. hw/arm/fsl-imx6.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/arm/fsl-imx6.c b/hw/arm/fsl-imx6.c index b0d4088290..1f4607f206 100644 ---

[Qemu-devel] [PATCH v8 13/14] sdhci: add a check_capab_v3() qtest

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 17 + 1 file changed, 17 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index 56eefdafd8..a8970da71a 100644 --- a/tests/sdhci-test.c +++ b/tests/sdhci-test.c @@ -16,6

[Qemu-devel] [PATCH v3 02/12] sdcard: replace DPRINTF() by trace events

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 33 ++--- hw/sd/trace-events | 6 ++ 2 files changed, 32 insertions(+), 7 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 55d2ba2dd7..f876973a2b 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -40

[Qemu-devel] [PATCH v3 06/12] sdcard: do not trace CMD55 when expecting ACMD

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index dc4b2329e4..27c08aa894 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -816,13 +816,15 @@ static void sd_lock_command(SDState *sd) sd

[Qemu-devel] [PATCH v3 01/12] sdcard: reorder SDState struct members

place card registers first, this will ease further code movements. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sd.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index ab9be561d2..55d2ba2dd7 100644

[Qemu-devel] [PATCH v3 00/12] SDCard: housekeeping, add tracing (part 4)

Since v2: - split again in 2... this part is cleanup/tracing - add more tracepoints - move some code reusable by sdbus in sdmmc-internal.h Since v1: - rewrote mostly all patches to keep it simpler. $ git backport-diff 001/12:[0007] [FC] 'sdcard: reorder SDState struct members' 002/12:[0002] [FC]

[Qemu-devel] [PATCH v3 03/12] sdcard: add a trace event for command responses

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 26 +++--- hw/sd/trace-events | 1 + 2 files changed, 24 insertions(+), 3 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index f876973a2b..3590099ce8 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -152,6 +152,26

[Qemu-devel] [PATCH v3 10/12] sdcard: rename sd_set_$REG() functions called once as sd_reset_$REG()

All are only called once at reset. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index c46e9c2818..8b5022a7db 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -269,7 +2

[Qemu-devel] [PATCH v3 04/12] sdcard: replace fprintf() by qemu_hexdump()

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 3590099ce8..03263e08ae 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -44,13 +44,6 @@ //#define DEBUG_SD 1 -#ifdef DEBUG_SD -#de

[Qemu-devel] [PATCH v3 07/12] sdcard: define SDMMC_CMD_MAX instead of using the magic '64'

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sd.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 27c08aa894..7b1cbc0a2e 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -126,6 +126,8 @@ struct

[Qemu-devel] [PATCH v3 09/12] sdcard: display protocol used when tracing

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 14 ++ hw/sd/trace-events | 8 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index e2c4d96d76..c46e9c2818 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -122,6 +122,7 @@ str

[Qemu-devel] [PATCH v3 12/12] sdcard: use the registerfields API to access the OCR register

Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sd.h | 1 - hw/sd/sd.c | 21 + 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/include/hw/sd/sd.h b/include/hw/sd/sd.h index bf1eb0713c..9bdb3c9285 100644 --- a/include/hw/sd/sd.h +++ b/include/hw

[Qemu-devel] [PATCH v3 05/12] sdcard: add more trace events

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 32 ++-- hw/sd/trace-events | 13 + 2 files changed, 39 insertions(+), 6 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 03263e08ae..dc4b2329e4 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c

[Qemu-devel] [PATCH v3 11/12] sdcard: use G_BYTE from cutils

code is now easier to read. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 8b5022a7db..f87e543f8f 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -36,6 +36,7 @@ #

[Qemu-devel] [PATCH v3 08/12] sdcard: display command name when tracing CMD/ACMD

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdmmc-internal.h | 20 ++ hw/sd/sd.c | 16 ++- hw/sd/sdmmc-common.c | 72 ++ hw/sd/Makefile.objs| 2 +- hw/sd/trace-events | 8 +++--- 5 files changed, 106 i

[Qemu-devel] [PATCH v3 00/18] SDCard: bugfixes, support UHS-I (part 5)

Some refactors, few bugfixes, better SD/SPI support. With this series apply, machines can use cards in UHS-I mode. (mostly imported from Alistair Francis work) MMC mode split out for another series. Since v2: - split again in 2... other part is cleanup/tracing Since v1: - rewrote mostly all pat

[Qemu-devel] [PATCH v3 03/18] sdcard: fix the 'maximum data transfer rate' to 25MHz

To comply with Spec v1.10 (and 2.00, 3.01): . TRAN_SPEED for current SD Memory Cards that field must be always 0_0110_010b (032h) which is equal to 25MHz - the mandatory maximum operating frequency of SD Memory Card. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 2 +- 1 file changed,

[Qemu-devel] [PATCH v3 07/18] sdcard: use the correct masked OCR in the R3 reply

use the registerfields API to access the OCR register Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 23f5d47782..ee381540aa 100644 --- a/hw/sd/sd.c +++ b/hw/sd/s

[Qemu-devel] [PATCH v3 06/18] sdcard: simplify using the ldst API

the code is easier to review/refactor. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 38 +- 1 file changed, 9 insertions(+), 29 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 3c66521862..23f5d47782 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@

[Qemu-devel] [PATCH v3 04/18] sdcard: clean the SCR register and add few comments

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 56df5b660a..5d50d48097 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -297,10 +297,13 @@ static void sd_ocr_powerup(void *opaque) static

[Qemu-devel] [PATCH v3 01/18] sdcard: Don't always set the high capacity bit

Don't set the high capacity bit by default as it will be set if required in the sd_set_csd() function. [based on a patch from Alistair Francis and Peter Ogden from qemu/xilinx tag xilinx-v2015.4] Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 5 - 1 file changed, 4 insertions(+),

[Qemu-devel] [PATCH v3 09/18] sdcard: handles more commands in SPI mode

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 57 ++--- 1 file changed, 54 insertions(+), 3 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 2eca999bc3..07424aa56e 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1390,9 +1390,11 @@

[Qemu-devel] [PATCH v3 08/18] sdcard: use the registerfields API for the CARD_STATUS register masks

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 48 +--- 1 file changed, 45 insertions(+), 3 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index ee381540aa..2eca999bc3 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -423,14 +423,56 @@ static voi

[Qemu-devel] [PATCH v3 11/18] sdcard: check the card is in correct state for APP CMD (CMD55)

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index bbf9496e8a..434d1fbc47 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1389,6 +1389,14 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)

[Qemu-devel] [PATCH v3 05/18] sdcard: remove commands from unsupported old MMC specification

This device does not model MMCA Specification previous to v4.2 Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 33 - 1 file changed, 33 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 5d50d48097..3c66521862 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c

[Qemu-devel] [PATCH v3 02/18] sdcard: update the CSD CRC register regardless the CSD structure version

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 20764451f2..f6318c6fdb 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -377,7 +377,6 @@ static void sd_reset_csd(SDState *sd, uint64_t size)

[Qemu-devel] [PATCH v3 10/18] sdcard: handle CMD54 (SDIO)

Linux uses it to poll the bus before polling for a card. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 07424aa56e..bbf9496e8a 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1378,9 +1378,8

[Qemu-devel] [PATCH v3 14/18] sdcard: simplify SD_SEND_OP_COND (ACMD41)

replace switch(single case) -> if() Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 56 ++-- 1 file changed, 26 insertions(+), 30 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 707c294169..6efcacb942 100644 --- a/hw/sd/sd.c +++

[Qemu-devel] [PATCH v3 18/18] sdcard: add an enum for the SD PHY Spec version

So far this device intends to model the Spec v1.10 Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 1f6c4ce2a4..9880a5d090 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -47,6 +47,11 @@ //#define DEBUG_S

[Qemu-devel] [PATCH v3 16/18] sdcard: add a 'uhs' property, update the OCR register ACCEPT_SWITCH_1V8 bit

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 27176ba33e..b3b6859bc4 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -93,6 +93,7 @@ struct SDState { /* Configurable properties */ BlockBackend *blk;

[Qemu-devel] [PATCH v3 12/18] sdcard: warn if host uses an incorrect address for APP CMD (CMD55)

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 434d1fbc47..b5c947df62 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1394,6 +1394,11 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)

[Qemu-devel] [PATCH v3 15/18] sdcard: add SD SEND_TUNING_BLOCK (CMD19)

[based on a patch from Alistair Francis from qemu/xilinx tag xilinx-v2015.2] Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 24 1 file changed, 24 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 6efcacb942..27176ba33e 100644 --- a/hw/sd/sd.c +++ b/hw/s

[Qemu-devel] [PATCH v3 13/18] sdcard: simplify SEND_IF_COND (CMD8)

replace switch(single case) -> if() Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index b5c947df62..707c294169 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1015,23 +101

[Qemu-devel] [PATCH v3 17/18] sdcard: implement the UHS-I SWITCH_FUNCTION entries (Spec v3)

[based on a patch from Alistair Francis from qemu/xilinx tag xilinx-v2015.2] Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 148 + hw/sd/trace-events | 1 + 2 files changed, 127 insertions(+), 22 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH v3 4/5] target/arm: Add ZCR_ELx

Define ZCR_EL[1-3]. Signed-off-by: Richard Henderson --- target/arm/cpu.h| 5 ++ target/arm/helper.c | 131 2 files changed, 136 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 3f4f6b6144..17955ad3ef 100644 --- a/ta

[Qemu-devel] [PATCH v3 1/5] target/arm: Expand vector registers for SVE

Change vfp.regs as a uint64_t to vfp.zregs as an ARMVectorReg. The previous patches have made the change in representation relatively painless. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/cpu.h | 59 +++--- target/ar

[Qemu-devel] [PATCH v3 2/5] target/arm: Add predicate registers for SVE

Signed-off-by: Richard Henderson --- target/arm/cpu.h | 12 1 file changed, 12 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 1854fe51a8..3f4f6b6144 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -188,6 +188,13 @@ typedef struct ARMVectorReg { uin

[Qemu-devel] [PATCH v3 0/5] target/arm: Preparatory work for SVE

Based on PMM's target-arm.next branch, which now has most of v2. While looking again at ZCR_ELx, I think that there's an existing bug in the FPCR/FPSR system registers, wherein we do not have an access function for when the FPU is disabled. r~ Richard Henderson (5): target/arm: Expand vector

[Qemu-devel] [PATCH v3 5/5] target/arm: Add SVE state to TB->FLAGS

Add both SVE exception state and vector length. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 8 target/arm/translate.h | 2 ++ target/arm/helper.c| 25 - target/arm/translate-a64.c | 2 ++ 4 files changed, 36 insertions(+), 1 d

[Qemu-devel] [PATCH v3 3/5] target/arm: Add SVE to migration state

Save the high parts of the Zregs and all of the Pregs. The ZCR_ELx registers are migrated via the CP mechanism. Signed-off-by: Richard Henderson --- target/arm/machine.c | 53 1 file changed, 53 insertions(+) diff --git a/target/arm/machine.c

[Qemu-devel] [PATCH v2 2/6] hw/sd/milkymist-memcard: split realize() out of SysBusDevice init()

Create the SDCard in the realize() function. Suggested-by: Michael Walle Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/milkymist-memcard.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c i

[Qemu-devel] [PATCH v2 1/6] hw/sd/milkymist-memcard: use qemu_log_mask()

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/milkymist-memcard.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c index 341da88552..1292c0c099 100644 --- a/hw/sd/milkymist-memcard.c +++ b/hw/sd/milkymis

[Qemu-devel] [PATCH v2 0/6] SDHCI: convert legacy devices to the SDBus API (part 6)

Hi, Since v1: - rebased on /master (Peter sdcard reset() patches) - fix milkymist-mmc from previous seris using instance_init (Michael Walle) This series convert 3 devices using the legacy SDCard API to the SDBus API: - milkymist-mmc - pl181 - ssi-sd Then move the legacy API to a separate header

[Qemu-devel] [PATCH v2 3/6] hw/sd/milkymist-memcard: expose a SDBus and connect the SDCard to it

using the sdbus_*() API. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/milkymist-memcard.c | 38 +- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c index a8e65892c7..5570c1e9a0 100644 ---

[Qemu-devel] [PATCH v2 5/6] hw/sd/ssi-sd: use the SDBus API, connect the SDCard to the bus

On reset the bus will reset the card, we can now drop the device_reset() call. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/ssi-sd.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c index f88f509e0a..ae04b66

[Qemu-devel] [PATCH v2 4/6] hw/sd/pl181: expose a SDBus and connect the SDCard to it

using the sdbus_*() API. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/pl181.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/hw/sd/pl181.c b/hw/sd/pl181.c index 3ba1f7dd23..ce696c5d7d 100644 --- a/hw/sd/pl181.c +++ b/hw/sd/pl181.c @@ -33,

[Qemu-devel] [PATCH v2 6/6] hw/sd: move sdcard legacy API to "hw/sd/sdcard_legacy.h"

roughly 2 users left. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sd.h| 17 --- include/hw/sd/sdcard_legacy.h | 51 +++ hw/sd/omap_mmc.c | 2 +- hw/sd/pl181.c | 1 + hw/sd/sd.c

Re: [Qemu-devel] [RFC PATCH 0/3] vfio: ccw: basic channel path event handling

* Halil Pasic [2018-01-16 16:57:13 +0100]: > > > On 01/15/2018 09:59 AM, Dong Jia Shi wrote: > > * Halil Pasic [2018-01-12 19:10:20 +0100]: > > > >> > >> > >> On 01/11/2018 04:04 AM, Dong Jia Shi wrote: > >>> What are still missing, thus need to be offered in the next version are: > >>> - I/O

Re: [Qemu-devel] [PATCH v3] chardev/char-socket: add POLLHUP handler

On Fri, Jan 19, 2018 at 01:47:15PM +0300, Klim Kireev wrote: > The following behavior was observed for QEMU configured by libvirt > to use guest agent as usual for the guests without virtio-serial > driver (Windows or the guest remaining in BIOS stage). > > In QEMU on first connect to listen chara

[Qemu-devel] [Bug 1176366] Re: TCPIP not working on qemu 1.4.50 (master)

Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Bug 1185311] Re: could not hot-remove disabled NIC from Win2012 guest by 'devel_del id1'

Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] Prevent overriding the input file with the output file when using qemu-img

Signed-off-by: River Chiang -- qemu-img.c -- index 68b375f998..5ce594ea00 100644 @@ -2098,6 +2098,9 @@ static int img_convert(int argc, char **argv) if (s.src_num < 1) { error_report("Must specify image file name");

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3] ppc: Deprecate qemu-system-ppcemb

On Sun, 21 Jan 2018 22:57:58 +0100 Thomas Huth wrote: > qemu-system-ppcemb has been once split of qemu-system-ppc to support > CPU page sizes < 4096 for some of the embedded 4xx PowerPC CPUs. > However, there was hardly any OS available in the wild that really > used such small page sizes (Linux

  1   2   3   4   >