Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-01-09 Thread Laurent Vivier
Le 09/01/2018 à 15:14, Peter Maydell a écrit : > On 9 January 2018 at 14:12, Aurelien Jarno wrote: >> On 2018-01-09 13:27, Laurent Vivier wrote: >>> Le 09/01/2018 à 13:22, Alex Bennée a écrit : It's not actively built and when enabled things fail to compile. I'm not sure the type-checkin

Re: [Qemu-devel] [PATCH] target/arm: Make disas_thumb2_insn() generate its own UNDEF exceptions

2018-01-09 Thread Peter Maydell
On 12 December 2017 at 17:39, Richard Henderson wrote: > On 12/12/2017 04:08 AM, Peter Maydell wrote: >> Refactor disas_thumb2_insn() so that it generates the code for raising >> an UNDEF exception for invalid insns, rather than returning a flag >> which the caller must check to see if it needs to

Re: [Qemu-devel] [PATCH] get_phys_addr_pmsav7: Support AP=0b111 for v7M

2018-01-09 Thread Peter Maydell
Ping for code review? thanks -- PMM On 8 December 2017 at 14:13, Peter Maydell wrote: > For PMSAv7, the v7A/R Arm ARM defines that setting AP to 0b111 > is an UNPREDICTABLE reserved combination. However, for v7M > this value is documented as having the same behaviour as 0b110: > read-only for bo

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/2] GICv2 & GICv3: RAZ/WI reserved addresses rather than aborting

2018-01-09 Thread Peter Maydell
Ping for code review? thanks -- PMM On 13 December 2017 at 16:52, Peter Maydell wrote: > The GICv2 and GICv3 specifications say that reserved register > addresses should RAZ/WI. This means we need to return MEMTX_OK, not > MEMTX_ERROR, because now that we support generating external aborts > th

Re: [Qemu-devel] [RFC v6 22/27] qmp: isolate responses into io thread

2018-01-09 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 04:45:52PM +0800, Peter Xu wrote: > +static void monitor_qmp_bh_responder(void *opaque) > +{ > +QMPResponse response; > + > +while (true) { > +response = monitor_qmp_response_pop_one(); > +if (!response.data) { > +break; > +} > +

[Qemu-devel] [PATCH 1/4] hw/sd/pl181: Reset SD card on controller reset

2018-01-09 Thread Peter Maydell
Since pl181 is still using the legacy SD card API, the SD card created by sd_init() is not plugged into any bus. This means that the controller has to reset it manually. Failing to do this mostly didn't affect the guest since the guest typically does a programmed SD card reset as part of its SD co

Re: [Qemu-devel] [RFC v6 23/27] monitor: enable IO thread for (qmp & !mux) typed

2018-01-09 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 04:45:53PM +0800, Peter Xu wrote: > Start to use dedicate IO thread for QMP monitors that are not using > MUXed chardev. > > Signed-off-by: Peter Xu > --- > monitor.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.as

Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-01-09 Thread Peter Maydell
On 9 January 2018 at 14:20, Laurent Vivier wrote: > Le 09/01/2018 à 15:14, Peter Maydell a écrit : >> Is gcc's codegen still bad enough that we have to default to not >> using the type-checking versions? If so, maybe we could at least >> enable the type-checking on an --enable-debug build, so it d

Re: [Qemu-devel] [PATCH v21 2/5 RESEND] virtio-balloon: VIRTIO_BALLOON_F_SG

2018-01-09 Thread Tetsuo Handa
Wei Wang wrote: > - enable OOM to free inflated pages maintained in the local temporary > list. I do want to see it before applying this patch. Please carefully check how the xbitmap implementation works, and you will find that you are adding a lot of redundant operations with a bug.

[Qemu-devel] [Bug 1739378] Re: migration state save/load of sdcard device is broken

2018-01-09 Thread Peter Maydell
I think the sd card migration issue should be fixed by http://patchwork.ozlabs.org/patch/857554/ NB that you'll also need to use "-machine secure=off" on the command line, as there's a second bug where we don't successfully migrate with trustzone emulation enabled (which is the default now). --

Re: [Qemu-devel] [RFC v6 25/27] docs: update QMP documents for OOB commands

2018-01-09 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 04:45:55PM +0800, Peter Xu wrote: > +To add OOB execution support for a command, we need to make sure the > +command handler satisfies at least the following: It would help to rephrase this in the imperative mood (telling the reader what to do rather than describing what wo

Re: [Qemu-devel] [RFC v6 00/27] QMP: out-of-band (OOB) execution support

2018-01-09 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 04:45:30PM +0800, Peter Xu wrote: > This v6 kept most of the high level design untouched, however there > are quite a few of changes that try to make the series more robust and > safe. My sincere thank to the reviewers (especially Stefan!) on all > review comments to previo

[Qemu-devel] [PATCH v2] isa/piix: move to mips malta

2018-01-09 Thread Michael S. Tsirkin
This device is only used on mips malta, move it to the maintainer that's actually testing it. Cc: Aurelien Jarno Cc: Yongbok Kim Cc: Hervé Poussineau Signed-off-by: Michael S. Tsirkin --- Aurelien, pls feel free to merge this or v1. MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [Qemu-devel] [PATCH 1/2] vhost-user: factor out msg head and payload

2018-01-09 Thread Stefan Hajnoczi
On Mon, Jan 08, 2018 at 07:50:38PM +0200, Michael S. Tsirkin wrote: > static VhostUserMsg m __attribute__ ((unused)); Can m be dropped now? signature.asc Description: PGP signature

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 2/5] s390-ccw: ipl structs for eckd cdl/ldl

2018-01-09 Thread Cornelia Huck
On Mon, 18 Dec 2017 17:11:52 -0500 "Collin L. Walling" wrote: > On 12/14/2017 12:41 PM, Cornelia Huck wrote: > > On Mon, 11 Dec 2017 17:19:17 -0500 > > "Collin L. Walling" wrote: > > > >> ECKD DASDs have different IPL structures for CDL and LDL > >> formats. The current Ipl1 and Ipl2 structs f

Re: [Qemu-devel] [PATCH 2/2] vhost-user: fix misaligned access to payload

2018-01-09 Thread Stefan Hajnoczi
On Mon, Jan 08, 2018 at 07:50:44PM +0200, Michael S. Tsirkin wrote: > We currently take a pointer to a misaligned field of a packed structure. > clang reports this as a build warning. > A fix is to keep payload in a separate structure, and access is it > from there using a vectored write. > > Sign

Re: [Qemu-devel] [PATCH v2 06/20] include/fpu/softfloat: add some float16 constants

2018-01-09 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Hi Alex, > > On 01/09/2018 09:22 AM, Alex Bennée wrote: >> This defines the same set of common constants for float 16 as defined >> for 32 and 64 bit floats. These are often used by target helper >> functions. I've also removed constants that are not used by anyb

Re: [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180108

2018-01-09 Thread Peter Maydell
On 9 January 2018 at 12:16, David Gibson wrote: > Thanks. Even if you can identify which patch it is and we can > postpone that one would be a bug help. Bisection blames this one: pbonz...@redhat.com (1): target-ppc: optimize cmp translation A plain boot doesn't work either: ./build/ppc/

Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-01-09 Thread Alex Bennée
Laurent Vivier writes: > Le 09/01/2018 à 15:14, Peter Maydell a écrit: >> On 9 January 2018 at 14:12, Aurelien Jarno wrote: >>> On 2018-01-09 13:27, Laurent Vivier wrote: Le 09/01/2018 à 13:22, Alex Bennée a écrit : > It's not actively built and when enabled things fail to compile. I'm

Re: [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

2018-01-09 Thread Thomas Huth
On 09.01.2018 01:32, Alistair Francis wrote: > On Tue, Jan 2, 2018 at 4:59 AM, Markus Armbruster wrote: >> Alistair Francis writes: >> >>> On Fri, Dec 22, 2017 at 12:30 PM, Markus Armbruster >>> wrote: Alistair Francis writes: > On Fri, Dec 22, 2017 at 9:17 AM, Thomas Huth wrote

Re: [Qemu-devel] Some question about savem/qcow2 incremental snapshot

2018-01-09 Thread Stefan Hajnoczi
On Mon, Dec 25, 2017 at 07:54:00AM +, He, Junyan wrote: > I am now focusing on snapshot optimization for Intel NVDimm kind memory. > Different from the normal memory, the NVDimm may be 128G, 256G or even more > for just one guest, and its speed is slower than the normal memory. So > sometime

Re: [Qemu-devel] [PATCH] linux-user: MIPS set cpu to r6 CPU if binary is R6

2018-01-09 Thread Richard Henderson
On 01/08/2018 03:34 PM, Laurent Vivier wrote: > Peter, Riku, > > what do you think of the idea of using the ELF header to select the CPU > to emulate? I think it's a good way to cut down on mistakes and reduce -- or at least not increase -- the number of binaries we build. r~

Re: [Qemu-devel] [PATCH v14 8/9] hw/arm/virt: Add RAS platform version for migration

2018-01-09 Thread Peter Maydell
On 28 December 2017 at 14:58, Igor Mammedov wrote: > On Thu, 28 Dec 2017 13:54:17 +0800 > Dongjiu Geng wrote: > >> Support this feature since version 2.10, disable it by >> default in the old version. > patch should go before acpi tables are actually added, > otherwise it might break bisectabilit

[Qemu-devel] [PATCH 0/7] CPU model updates for CVE-2017-5715 (Spectre variant #2)

2018-01-09 Thread Eduardo Habkost
This series adds support for the new IA32_SPEC_CTRL MSR on Intel CPU models. The new MSR and the spec-ctrl CPUID bit (CPUID[EAX=7,ECX=0].EDX[bit 26]) were introduced by a recent Intel microcode updated and can be used by OSes to mitigate CVE-2017-5715. It also adds a new EPYC-IBPB CPU model that

[Qemu-devel] [PATCH 1/7] i386: Change X86CPUDefinition::model_id to const char*

2018-01-09 Thread Eduardo Habkost
It is valid to have a 48-character model ID on CPUID, however the definition of X86CPUDefinition::model_id is char[48], which can make the compiler drop the null terminator from the string. If a CPU model happens to have 48 bytes on model_id, "-cpu help" will print garbage and the object_property_

[Qemu-devel] [PATCH 4/7] i386: Add FEAT_8000_0008_EBX CPUID feature word

2018-01-09 Thread Eduardo Habkost
Add the new feature word and the "ibpb" feature flag. Based on a patch by Paolo Bonzini. Signed-off-by: Eduardo Habkost --- target/i386/cpu.h | 3 +++ target/i386/cpu.c | 19 ++- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.

[Qemu-devel] [PATCH 6/7] [RFC] i386: Add EPYC-IBPB CPU model

2018-01-09 Thread Eduardo Habkost
RFC NOTE: More info is required to confirm if this is necessary to mitigate mitigate CVE-2017-5715 on AMD CPUs. EPYC-IBPB is a copy of the EPYC CPU model with just CPUID_8000_0008_EBX_IBPB added. Cc: Jiri Denemark Cc: Tom Lendacky Cc: Brijesh Singh Signed-off-by: Eduardo Habkost --- target/i

[Qemu-devel] [PATCH 2/7] i386: Add support for SPEC_CTRL MSR

2018-01-09 Thread Eduardo Habkost
From: Paolo Bonzini Signed-off-by: Eduardo Habkost --- target/i386/cpu.h | 3 +++ target/i386/kvm.c | 14 ++ target/i386/machine.c | 20 3 files changed, 37 insertions(+) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 62c4742703..07f47997d6 1

[Qemu-devel] [PATCH 5/7] i386: Add new -IBRS versions of Intel CPU models

2018-01-09 Thread Eduardo Habkost
The new MSR IA32_SPEC_CTRL MSR was introduced by a recent Intel microcode updated and can be used by OSes to mitigate CVE-2017-5715. Unfortunately we can't change the existing CPU models without breaking existing setups, so users need to explicitly update their VM configuration to use the new *-IB

[Qemu-devel] [PATCH 3/7] i386: Add spec-ctrl CPUID bit

2018-01-09 Thread Eduardo Habkost
Add the feature name and a CPUID_7_0_EDX_SPEC_CTRL macro. Signed-off-by: Eduardo Habkost --- target/i386/cpu.h | 1 + target/i386/cpu.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 07f47997d6..de387c1311 100644 --- a/target/i38

[Qemu-devel] [PATCH 7/7] [RFC] i386: Add PCID to {Westmere, SandyBridge, IvyBridge}-IBRS

2018-01-09 Thread Eduardo Habkost
RFC NOTE: we need to confirm if all Westmere/SandyBridge/IvyBridge CPUs out there support PCID, before applying this patch. RFC NOTE 2: in parallel, we are evaluating the possibility of enabling PCID on the existing Westmere/SandyBridge/IvyBridge CPU models, see https://patchew.org/QEMU/2018010820

Re: [Qemu-devel] [PATCH v5 6/7] vhost: Clean out old vhost_set_memory and friends

2018-01-09 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Mon, 18 Dec 2017 20:13:39 + > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > Remove the old update mechanism, vhost_set_memory, and the functions > > and flags it used. > > > > Signed-off-by: Dr. David Al

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/2] GICv2 & GICv3: RAZ/WI reserved addresses rather than aborting

2018-01-09 Thread Laszlo Ersek
On 01/09/18 15:24, Peter Maydell wrote: > Ping for code review? > > thanks > -- PMM > > On 13 December 2017 at 16:52, Peter Maydell wrote: >> The GICv2 and GICv3 specifications here's where I had started running from your patch... >> say that reserved register >> addresses should RAZ/WI. ...a

Re: [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180108

2018-01-09 Thread Michael Roth
Quoting Peter Maydell (2018-01-09 09:15:25) > On 9 January 2018 at 12:16, David Gibson wrote: > > Thanks. Even if you can identify which patch it is and we can > > postpone that one would be a bug help. > > Bisection blames this one: > > pbonz...@redhat.com (1): > target-ppc: optimize cmp

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/4] hw/sd/milkymist-memcard: Reset SD card on controller reset

2018-01-09 Thread Philippe Mathieu-Daudé
Hi Peter, On 01/09/2018 11:01 AM, Peter Maydell wrote: > Since pl181 is still using the legacy SD card API, the SD pl181 -> milkymist-memcard ;) > card created by sd_init() is not plugged into any bus. This > means that the controller has to reset it manually. > > Failing to do this mostly didn

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/2] GICv2 & GICv3: RAZ/WI reserved addresses rather than aborting

2018-01-09 Thread Peter Maydell
On 9 January 2018 at 15:58, Laszlo Ersek wrote: > Sorry, no clue about any of this -- where should I read up? I cc'd you mostly as a heads-up since the QEMU bug is UEFI affecting, not because I wanted to make you read the GIC specs :-) > Ard did ask a question though: > > https://www.mail-archiv

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/4] Reset SD cards attached to legacy-API controllers

2018-01-09 Thread Philippe Mathieu-Daudé
Hi Peter, On 01/09/2018 11:01 AM, Peter Maydell wrote: > It turns out that we don't reset the SD card model if it's > attached to a legacy-API controller. For new-style controllers > where the SD card object is attached to an SD_BUS, the generic > qbus infrastructure takes care of ensuring that th

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/4] Reset SD cards attached to legacy-API controllers

2018-01-09 Thread Peter Maydell
On 9 January 2018 at 16:13, Philippe Mathieu-Daudé wrote: > I didn't test migrating a card (but have a "sdcard migration qtest" > entry in my TODO). I usually test not by actually migrating but using 'savevm foo' in the monitor to save a snapshot and then -loadvm foo on the command line to resume

Re: [Qemu-devel] [Qemu-arm] [PATCH 3/4] hw/sd/ssi-sd: Reset SD card on controller reset

2018-01-09 Thread Philippe Mathieu-Daudé
Hi Peter, On 01/09/2018 11:01 AM, Peter Maydell wrote: > Since ssi-sd is still using the legacy SD card API, the SD > card created by sd_init() is not plugged into any bus. This > means that the controller has to reset it manually. > > Failing to do this mostly didn't affect the guest since the >

Re: [Qemu-devel] [PATCH 1/7] net: struct MACAddr can use the QEMU_PACKED macro

2018-01-09 Thread Richard Henderson
On 01/08/2018 10:02 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > include/net/net.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/net/net.h b/include/net/net.h > index 4afac1a9dd..70f5bb3419 100644 > --- a/include/net/net.h >

Re: [Qemu-devel] [PATCH 4/7] net/rocker: move struct rocker_desc to C file

2018-01-09 Thread Richard Henderson
On 01/08/2018 10:02 AM, Philippe Mathieu-Daudé wrote: > this is the only user. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/net/rocker/rocker_hw.h | 13 - > hw/net/rocker/rocker_desc.c | 13 + > 2 files changed, 13 insertions(+), 13 deletions(-) Reviewed-by: Ri

Re: [Qemu-devel] [PATCH 3/7] net/rocker: use QEMU_PACKED and QEMU_ALIGNED() macros

2018-01-09 Thread Richard Henderson
On 01/08/2018 10:02 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/net/rocker/rocker_hw.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PULL 0/3] NBD patches through 2018-01-08

2018-01-09 Thread Peter Maydell
On 8 January 2018 at 15:31, Eric Blake wrote: > The following changes since commit 799044b6a3a0fc63e1e020e4d9266786a2dc7a0b: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2018-01-08 13:44:01 +) > > are available in the Git repository at: > > git://repo

Re: [Qemu-devel] [Qemu-arm] [PATCH 3/4] hw/sd/ssi-sd: Reset SD card on controller reset

2018-01-09 Thread Peter Maydell
On 9 January 2018 at 16:25, Philippe Mathieu-Daudé wrote: > Hi Peter, > > On 01/09/2018 11:01 AM, Peter Maydell wrote: >> Since ssi-sd is still using the legacy SD card API, the SD >> card created by sd_init() is not plugged into any bus. This >> means that the controller has to reset it manually.

Re: [Qemu-devel] [PATCH 7/7] i386/pc: use the QEMU_ALIGNED() macro

2018-01-09 Thread Richard Henderson
On 01/08/2018 10:02 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/pc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 5/7] net/eepro100: use QEMU_ALIGNED() macro

2018-01-09 Thread Richard Henderson
On 01/08/2018 10:02 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/net/eepro100.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 04/12] slirp: add in6_multicast() and use it instead of IN6_IS_ADDR_MULTICAST()

2018-01-09 Thread Richard Henderson
On 01/08/2018 09:28 AM, Philippe Mathieu-Daudé wrote: > Host: Mac OS 10.12.5 > Compiler: Apple LLVM version 8.1.0 (clang-802.0.42) > > slirp/ip6_icmp.c:79:32: warning: taking address of packed member 'ip_src' > of class or > structure 'ip6' may result in an unaligned pointer value >

Re: [Qemu-devel] [PATCH v1 for-2-12 05/15] s390x/tcg: simplify machine check handling

2018-01-09 Thread Cornelia Huck
On Mon, 11 Dec 2017 14:47:30 +0100 David Hildenbrand wrote: > We currently only support CRW machine checks. This is a preparation for > real floating interrupt support. > > Get rid of the queue and handle it via the bit INTERRUPT_MCHK. We don't > rename it for now, as it will be soon gone (when

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/2] GICv2 & GICv3: RAZ/WI reserved addresses rather than aborting

2018-01-09 Thread Laszlo Ersek
On 01/09/18 17:12, Peter Maydell wrote: > On 9 January 2018 at 15:58, Laszlo Ersek wrote: >> Sorry, no clue about any of this -- where should I read up? > > I cc'd you mostly as a heads-up since the QEMU bug is UEFI affecting, > not because I wanted to make you read the GIC specs :-) Thanks (and

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/2] GICv2 & GICv3: RAZ/WI reserved addresses rather than aborting

2018-01-09 Thread Peter Maydell
On 9 January 2018 at 16:29, Laszlo Ersek wrote: > On 01/09/18 17:12, Peter Maydell wrote: >> On 9 January 2018 at 15:58, Laszlo Ersek wrote: >>> Sorry, no clue about any of this -- where should I read up? >> >> I cc'd you mostly as a heads-up since the QEMU bug is UEFI affecting, >> not because I

Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2018-01-09 Thread Cornelia Huck
On Wed, 13 Dec 2017 10:31:58 +0100 David Hildenbrand wrote: > On 13.12.2017 10:16, Christian Borntraeger wrote: > > > > > > On 12/12/2017 04:28 PM, Cornelia Huck wrote: > >> On Tue, 12 Dec 2017 16:17:17 +0100 > >> David Hildenbrand wrote: > >> > >>> On 12.12.2017 15:29, Cornelia Huck wrote

Re: [Qemu-devel] [Qemu-arm] [PATCH 3/4] hw/sd/ssi-sd: Reset SD card on controller reset

2018-01-09 Thread Philippe Mathieu-Daudé
On 01/09/2018 01:28 PM, Peter Maydell wrote: > On 9 January 2018 at 16:25, Philippe Mathieu-Daudé wrote: >> Hi Peter, >> >> On 01/09/2018 11:01 AM, Peter Maydell wrote: >>> Since ssi-sd is still using the legacy SD card API, the SD >>> card created by sd_init() is not plugged into any bus. This >

Re: [Qemu-devel] [PATCH net-next v4 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor

2018-01-09 Thread David Miller
From: Jason Baron Date: Fri, 5 Jan 2018 17:44:54 -0500 > The ability to set speed and duplex for virtio_net is useful in various > scenarios as described here: > > 16032be virtio_net: add ethtool support for set and get of settings > > However, it would be nice to be able to set this from the

[Qemu-devel] [PATCH v5 0/4] vhost: two fixes and used_memslots refactoring

2018-01-09 Thread Jay Zhou
v4 -> v5: Making the followed up device_add to fall back to userspace virtio when netdev_add fails if vhost force flag does not set. Jay Zhou (4): vhost: remove assertion to prevent crash tap: do not close fd if only vhost failed to initialize vhost: fix memslot limit check vhost: used

[Qemu-devel] [PATCH v5 1/4] vhost: remove assertion to prevent crash

2018-01-09 Thread Jay Zhou
Start QEMU with more DIMM devices than limit but without any vhost backends and then hotplug a vhost user backend, the VM will be crashed. Instead of asserting in vhost_user_set_mem_table(), error number is used to gracefully prevent device to start. This fixes the crash issue. Cc: qemu-sta...@non

[Qemu-devel] [PATCH v5 4/4] vhost: used_memslots refactoring

2018-01-09 Thread Jay Zhou
Used_memslots is shared by vhost kernel and user, it is equal to dev->mem->nregions, which is correct for vhost kernel, but not for vhost user, the latter one uses memory regions that have file descriptor. E.g. a VM has a vhost-user NIC and 8(vhost user memslot upper limit) memory slots, it will be

Re: [Qemu-devel] [PATCH v5 5/7] vhost: Regenerate region list from changed sections list

2018-01-09 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Wed, 27 Dec 2017 14:19:03 +0100 > Igor Mammedov wrote: > > > On Mon, 18 Dec 2017 20:13:38 + > > "Dr. David Alan Gilbert (git)" wrote: > > > > > From: "Dr. David Alan Gilbert" > > > > > > Compare the sections list that's just been generated

[Qemu-devel] [PATCH v5 2/4][RFC] tap: do not close fd if only vhost failed to initialize

2018-01-09 Thread Jay Zhou
Making the followed up device_add to fall back to userspace virtio when netdev_add fails if vhost force flag does not set. Suggested-by: Michael S. Tsirkin Suggested-by: Igor Mammedov Signed-off-by: Jay Zhou --- net/tap.c | 25 ++--- 1 file changed, 18 insertions(+), 7 dele

[Qemu-devel] [PATCH v5 3/4] vhost: fix memslot limit check

2018-01-09 Thread Jay Zhou
Since used_memslots will be updated to the actual value after registering memory listener for the first time, move the memslots limit checking to the right place. Signed-off-by: Jay Zhou --- hw/virtio/vhost.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-01-09 Thread Richard Henderson
On 01/09/2018 06:43 AM, Peter Maydell wrote: > On 9 January 2018 at 14:20, Laurent Vivier wrote: >> Le 09/01/2018 à 15:14, Peter Maydell a écrit : >>> Is gcc's codegen still bad enough that we have to default to not >>> using the type-checking versions? If so, maybe we could at least >>> enable th

Re: [Qemu-devel] [PATCH v1 for-2-12 08/15] s390x/flic: make floating interrupts on TCG actually floating

2018-01-09 Thread Cornelia Huck
On Mon, 11 Dec 2017 14:47:33 +0100 David Hildenbrand wrote: > Move floating interrupt handling into the flic. Floating interrupts > will now be considered by all CPUs, not just CPU #0. While at it, convert > I/O interrupts to use a list and make sure we properly consider I/O > sub-classes in s390

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/2] GICv2 & GICv3: RAZ/WI reserved addresses rather than aborting

2018-01-09 Thread Laszlo Ersek
On 01/09/18 17:35, Peter Maydell wrote: > On 9 January 2018 at 16:29, Laszlo Ersek wrote: >> On 01/09/18 17:12, Peter Maydell wrote: >>> On 9 January 2018 at 15:58, Laszlo Ersek wrote: Sorry, no clue about any of this -- where should I read up? >>> >>> I cc'd you mostly as a heads-up since t

Re: [Qemu-devel] [PATCH v14 2/9] ACPI: Add APEI GHES table generation and CPER record support

2018-01-09 Thread Peter Maydell
On 3 January 2018 at 02:21, gengdongjiu wrote: > On 2017/12/28 22:18, Igor Mammedov wrote: >> On Thu, 28 Dec 2017 13:54:11 +0800 >> Dongjiu Geng wrote: >>> In order to simulation, we hard code the error >>> type to Multi-bit ECC. >> Not sure what this is about, care to elaborate? > > please see M

Re: [Qemu-devel] [PATCH 2/6] hw/sd/milkymist-memcard: split realize() out of SysBusDevice init()

2018-01-09 Thread Michael Walle
Hey Philippe, Am 2018-01-03 17:23, schrieb Philippe Mathieu-Daudé: Create the SDCard in the realize() function. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/milkymist-memcard.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/hw/sd/milkymist-mem

Re: [Qemu-devel] New documentation for the LatticeMicro32 target

2018-01-09 Thread Michael Walle
Am 2018-01-09 12:58, schrieb Peter Maydell: I just fell over this, it looks like this fix never made it into master. Michael, could you submit this as a full patch with a commit message and signed-off-by, please? cc: qemu-sta...@nongnu.org as well, since it fixes a "breaks the board completely"

Re: [Qemu-devel] [PATCH v2 10/20] fpu/softfloat: define decompose structures

2018-01-09 Thread Richard Henderson
On 01/09/2018 04:22 AM, Alex Bennée wrote: > +float_class_qnan, > +float_class_snan, > +float_class_dnan, /* default nan */ here wouldn't go amiss. > +float_class_msnan, /* maybe silenced */ r~

[Qemu-devel] [PATCH] lm32: take BQL before writing IP/IM register

2018-01-09 Thread Michael Walle
Writing to these registers may raise an interrupt request. Actually, this prevents the milkymist board from starting. Cc: qemu-sta...@nongnu.org Signed-off-by: Michael Walle --- target/lm32/op_helper.c | 4 1 file changed, 4 insertions(+) diff --git a/target/lm32/op_helper.c b/target/lm32/

Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-01-09 Thread Halil Pasic
On 12/30/2017 10:35 AM, Longpeng(Mike) wrote: > From: Gonglei > > The virtio crypto device is a virtual crypto device (ie. hardware > crypto accelerator card). Currently, the virtio crypto device provides > the following crypto services: CIPHER, MAC, HASH, and AEAD. > > In this patch, CIPHER,

Re: [Qemu-devel] [PATCH 04/12] slirp: add in6_multicast() and use it instead of IN6_IS_ADDR_MULTICAST()

2018-01-09 Thread Thomas Huth
On 09.01.2018 17:33, Richard Henderson wrote: > On 01/08/2018 09:28 AM, Philippe Mathieu-Daudé wrote: >> Host: Mac OS 10.12.5 >> Compiler: Apple LLVM version 8.1.0 (clang-802.0.42) >> >> slirp/ip6_icmp.c:79:32: warning: taking address of packed member 'ip_src' >> of class or >> structure

Re: [Qemu-devel] [PATCH v2 16/20] fpu/softfloat: re-factor float to int/uint

2018-01-09 Thread Richard Henderson
On 01/09/2018 04:22 AM, Alex Bennée wrote: > We share the common int64/uint64_pack_decomposed function across all > the helpers and simply limit the final result depending on the final > size. > > Signed-off-by: Alex Bennée > > -- > v2 > - apply float_flg_invalid fixes next patch > --- > fpu/

Re: [Qemu-devel] [PATCH v14 9/9] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2018-01-09 Thread Peter Maydell
On 28 December 2017 at 05:54, Dongjiu Geng wrote: > Add SIGBUS signal handler. In this handler, it checks the SIGBUS type, > translates the host VA which is delivered by host to guest PA, then fill > this PA to CPER and fill the CPER to guest APEI GHES memory, finally > notify guest according to t

Re: [Qemu-devel] [PATCH v2 19/20] fpu/softfloat: re-factor minmax

2018-01-09 Thread Richard Henderson
On 01/09/2018 04:22 AM, Alex Bennée wrote: > Let's do the same re-factor treatment for minmax functions. I still > use the MACRO trick to expand but now all the checking code is common. > > Signed-off-by: Alex Bennée > > --- > v2 > - minor indentation fix > --- > fpu/softfloat.c | 239

Re: [Qemu-devel] [PATCH v14 4/9] ACPI: enable APEI GHES in the configure file

2018-01-09 Thread Peter Maydell
On 28 December 2017 at 05:54, Dongjiu Geng wrote: > Add CONFIG_ACPI_APEI configuration in the arm-softmmu.mak > and add build choice in the Makefile.objs. > > Signed-off-by: Dongjiu Geng > --- > default-configs/arm-softmmu.mak | 1 + > hw/acpi/Makefile.objs | 1 + > 2 files changed, 2

Re: [Qemu-devel] [PATCH v2 20/20] fpu/softfloat: re-factor compare

2018-01-09 Thread Richard Henderson
On 01/09/2018 04:22 AM, Alex Bennée wrote: > The compare function was already expanded from a macro. I keep the > macro expansion but move most of the logic into a compare_decomposed. > > Signed-off-by: Alex Bennée > > --- > v2 > - minor re-factor for better inf handling > --- > fpu/softfloat

Re: [Qemu-devel] [PATCH v14 5/9] target-arm: kvm64: inject synchronous External Abort

2018-01-09 Thread Peter Maydell
On 28 December 2017 at 05:54, Dongjiu Geng wrote: > Add synchronous external abort injection logic, setup > exception type and syndrome value. When switch to guest, > guest will jump to the synchronous external abort vector > table entry. > > The ESR_ELx.DFSC is set to synchronous external abort(0

Re: [Qemu-devel] [PATCH v1 for-2-12 13/15] s390x/tcg: STSI overhaul

2018-01-09 Thread Cornelia Huck
On Mon, 11 Dec 2017 14:47:38 +0100 David Hildenbrand wrote: > Current STSI implementation is a mess, so let's rewrite it. > > Problems fixed by this patch: > 1) The order of exceptions/when recognized is wrong. > 2) We have to store to virtual address space, not absolute. > 3) Alignment check of

[Qemu-devel] [PATCH v3] usb: Remove legacy -usbdevice options (host, serial, disk and net)

2018-01-09 Thread Thomas Huth
The option have been marked as deprecated since QEMU 2.10, and so far nobody complained that the host, serial, disk and net options are urgently required anymore. So let's now get rid at least of this legacy pile, to simplify the usb code quite a bit. This patch removes the usbdevices host, serial

Re: [Qemu-devel] [PATCH v1 for-2-12 00/15] s390x: flic rework, tcg flic support and tcg

2018-01-09 Thread Cornelia Huck
On Mon, 11 Dec 2017 14:47:25 +0100 David Hildenbrand wrote: > This patch series implements floating interrupt support for TCG and fixes > STSI so we can remove warnings related to s390x SMP and MTTCG. > > KVM code has to be touched in order to factor out the injection routines > into the flic ("

Re: [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180108

2018-01-09 Thread Paolo Bonzini
On 09/01/2018 17:02, Michael Roth wrote: >> so you can see it's already diverged because it prints out >> a different value for the name of the pci node and the >> SCSI line has 8200 vs . > FYI I actually see this with a raspberry pi 3 too Is this an arm32 or aarch64 install?

Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-01-09 Thread Michael S. Tsirkin
On Tue, Jan 09, 2018 at 06:05:41PM +0100, Halil Pasic wrote: > > +\drivernormative{\subsubsection}{Device configuration layout}{Device Types > > / Crypto Device / Device configuration layout} > > + > > +\begin{itemize*} > > +\item The driver MUST read the \field{status} from the bottom bit of > >

Re: [Qemu-devel] [PULL v2 00/16] target/xtensa updates

2018-01-09 Thread Peter Maydell
On 8 January 2018 at 17:49, Max Filippov wrote: > Hi Peter, > > please pull the following batch of updates for the target/xtensa. > Changes v1->v2: > - Drop no longer used function option_bits_enabled. > > The following changes since commit 0a0dc59d27527b78a195c2d838d28b7b49e5a639: > > Update ve

Re: [Qemu-devel] [PATCH v6 21/29] hw/s390x: Replace fprintf(stderr, "*\n" with error_report()

2018-01-09 Thread Cornelia Huck
On Wed, 20 Dec 2017 09:24:41 -0800 Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N

[Qemu-devel] [PATCH] fixup! i386: Change X86CPUDefinition::model_id to const char*

2018-01-09 Thread Eduardo Habkost
On Tue, Jan 09, 2018 at 01:45:13PM -0200, Eduardo Habkost wrote: > It is valid to have a 48-character model ID on CPUID, however the > definition of X86CPUDefinition::model_id is char[48], which can > make the compiler drop the null terminator from the string. > > If a CPU model happens to have 48

Re: [Qemu-devel] [PATCH] irq: fix memory leak

2018-01-09 Thread Paolo Bonzini
On 25/12/2017 03:47, linzhecheng wrote: > entry is moved from list but is not freed. > > Signed-off-by: linzhecheng > > diff --git a/target/i386/kvm.c b/target/i386/kvm.c > index 351b64f77c..3c920db79a 100644 > --- a/target/i386/kvm.c > +++ b/target/i386/kvm.c > @@ -3494,6 +3494,7 @@ int kvm_arc

[Qemu-devel] [Bug 1727250] Re: qemu-io-test 147 segfaults when configured with gcov

2018-01-09 Thread Murilo Opsfelder Araújo
The fix was committed: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=c4365735a7d38f4355c6f77e6670d3972315f7c2 commit c4365735a7d38f4355c6f77e6670d3972315f7c2 Author: Murilo Opsfelder Araujo Date: Fri Jan 5 11:32:41 2018 -0200 block/nbd: fix segmentation fault when .desc is not null-term

[Qemu-devel] [Bug 1727259] Re: qemu-io-test 58 segfaults when configured with gcov

2018-01-09 Thread Murilo Opsfelder Araújo
The fix was committed: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=c4365735a7d38f4355c6f77e6670d3972315f7c2 commit c4365735a7d38f4355c6f77e6670d3972315f7c2 Author: Murilo Opsfelder Araujo Date: Fri Jan 5 11:32:41 2018 -0200 block/nbd: fix segmentation fault when .desc is not null-term

Re: [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180108

2018-01-09 Thread Michael Roth
Quoting Paolo Bonzini (2018-01-09 11:34:48) > On 09/01/2018 17:02, Michael Roth wrote: > >> so you can see it's already diverged because it prints out > >> a different value for the name of the pci node and the > >> SCSI line has 8200 vs . > > FYI I actually see this with a rasp

[Qemu-devel] [PATCH v4] target/xtensa: use libisa for instruction decoding

2018-01-09 Thread Max Filippov
Replace manual opcode analysis with libisa-based code. This makes it possible to support variable-encoding instructions of the core ISA, like const16, and will allow to support advanced Xtensa features, like FLIX and TIE. Signed-off-by: Max Filippov --- Changes v3->v4: - Don't use g_malloc_n, use

Re: [Qemu-devel] [PATCH] scsi: Don't check uninitialized local variable

2018-01-09 Thread Paolo Bonzini
On 08/01/2018 04:09, Fam Zheng wrote: > After the out label there is a check on iTask.task but it is not > initialized yet. > > Fixes: e38bc23454ef763deb4405ebdee6a1081aa00bc8 > Signed-off-by: Fam Zheng > --- > block/iscsi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --g

Re: [Qemu-devel] [PATCH v6 21/29] hw/s390x: Replace fprintf(stderr, "*\n" with error_report()

2018-01-09 Thread Alistair Francis
On Tue, Jan 9, 2018 at 9:45 AM, Cornelia Huck wrote: > On Wed, 20 Dec 2017 09:24:41 -0800 > Alistair Francis wrote: > >> Replace a large number of the fprintf(stderr, "*\n" calls with >> error_report(). The functions were renamed with these commands and then >> compiler issues where manually fixe

Re: [Qemu-devel] [PULL v2 00/16] target/xtensa updates

2018-01-09 Thread Max Filippov
On Tue, Jan 9, 2018 at 9:44 AM, Peter Maydell wrote: > /Users/pm215/src/qemu-for-merges/target/xtensa/helper.c:63:26: error: > implicit declaration of function 'g_malloc_n' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > config->opcode_ops = g_malloc_n(opcodes, sizeof(XtensaOpc

Re: [Qemu-devel] [PATCH] scsi: Don't check uninitialized local variable

2018-01-09 Thread Eric Blake
On 01/09/2018 12:05 PM, Paolo Bonzini wrote: > On 08/01/2018 04:09, Fam Zheng wrote: >> After the out label there is a check on iTask.task but it is not >> initialized yet. >> >> Fixes: e38bc23454ef763deb4405ebdee6a1081aa00bc8 >> Signed-off-by: Fam Zheng >> --- >> block/iscsi.c | 3 +-- >> 1 file

Re: [Qemu-devel] [PATCH 2/6] hw/sd/milkymist-memcard: split realize() out of SysBusDevice init()

2018-01-09 Thread Philippe Mathieu-Daudé
Hi Michael, > Am 2018-01-03 17:23, schrieb Philippe Mathieu-Daudé: >> >> Create the SDCard in the realize() function. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/sd/milkymist-memcard.c | 24 +++- >> 1 file changed, 15 insertions(+), 9 deletions(-) >> >> diff --gi

[Qemu-devel] [PULL v3] target/xtensa updates

2018-01-09 Thread Max Filippov
: Update version for v2.11.0 release (2017-12-13 14:31:09 +) are available in the git repository at: git://github.com/OSLL/qemu-xtensa.git tags/20180109-xtensa for you to fetch changes up to 5a6539e627faf9251e1db78238b9f9b870610518: target/xtensa: implement disassembler (2018-01-09 09:

Re: [Qemu-devel] [PULL] qemu-sparc updates

2018-01-09 Thread Peter Maydell
On 8 January 2018 at 19:31, Mark Cave-Ayland wrote: > Hi Peter, > > Here is the first set of SPARC updates for 2.12. Please pull. > > > ATB, > > Mark. > > > The following changes since commit 4124ea4f5bd367ca6412fb2dfe7ac4d80e1504d9: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20

Re: [Qemu-devel] [PULL 00/14] Migration pull request

2018-01-09 Thread Peter Maydell
On 5 January 2018 at 09:59, Juan Quintela wrote: > Eric Blake wrote: >> On 01/03/2018 03:38 AM, Juan Quintela wrote: >>> Hi >>> >>> This are the changes for migration that are already reviewed. >>> >>> Please, apply. >>> >> >>> Alexey Perevalov (6): >>> migration: introduce postcopy-blockti

Re: [Qemu-devel] [PATCH 2/6] hw/sd/milkymist-memcard: split realize() out of SysBusDevice init()

2018-01-09 Thread Philippe Mathieu-Daudé
>> Creating the device (milkymist_memcard_create()) fails with an assertion: >> sysbus_mmio_map_common: Assertion `n >= 0 && n < dev->num_mmio' failed. > > Thanks for trying this. > > Odd 'make check-qtest-lm32' didn't catch this... Oh it actually does... My bad! GTESTER check-qtest-lm32 qemu

Re: [Qemu-devel] [PULL 00/14] Migration pull request

2018-01-09 Thread Juan Quintela
Peter Maydell wrote: > On 5 January 2018 at 09:59, Juan Quintela wrote: >> Eric Blake wrote: >>> On 01/03/2018 03:38 AM, Juan Quintela wrote: Hi This are the changes for migration that are already reviewed. Please, apply. >>> Alexey Perevalov (6): mi

Re: [Qemu-devel] [PATCH v4 1/6] vhost: Move log_dirty check

2018-01-09 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Thu, 14 Dec 2017 15:20:10 + > "Dr. David Alan Gilbert" wrote: > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > On Wed, 13 Dec 2017 18:08:02 + > > > "Dr. David Alan Gilbert (git)" wrote: > > > > > > > From: "Dr. David Alan Gilbert

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2-12 12/15] s390x/tcg: fix size + content of STSI blocks

2018-01-09 Thread Thomas Huth
On 11.12.2017 14:47, David Hildenbrand wrote: > All blocks are 4k in size, which is only true for two of them right now. > Also some reserved fields were wrong, fix it and convert all reserved > fields to u8. > > This also fixes the LPAR part output in /proc/sysinfo under TCG. (for > now, everythi

<    1   2   3   >