On 9 January 2018 at 14:20, Laurent Vivier <laur...@vivier.eu> wrote: > Le 09/01/2018 à 15:14, Peter Maydell a écrit : >> Is gcc's codegen still bad enough that we have to default to not >> using the type-checking versions? If so, maybe we could at least >> enable the type-checking on an --enable-debug build, so it doesn't >> bitrot all the time. > > What means "bad enough"? for some targets it works fine.
I mean whatever the problem was that made us write the comment A sufficiently clever compiler and sane ABI should be able to see though these structs. However x86/gcc 3.x seems to struggle a bit, so leave them disabled by default. In theory the code generated should be no worse than without structs... > The problem with that is if it is not enabled all the time it becomes > broken really quick... Yes, that's why I'd like it at least default-enabled for --enable-debug, if we can't enable it always. thanks -- PMM