[Qemu-devel] [PULL v2 02/23] hw/block/nvme: Convert to realize

2017-12-19 Thread Stefan Hajnoczi
From: Mao Zhongyi Convert nvme_init() to realize and rename it to nvme_realize(). Cc: John Snow Cc: Keith Busch Cc: Kevin Wolf Cc: Max Reitz Cc: Markus Armbruster Signed-off-by: Mao Zhongyi Message-id: 2882e72d795e04cbe2120f569d551aef2467ac60.1511317952.git.maozy.f...@cn.fujitsu.com Sign

[Qemu-devel] [PULL v2 00/23] Block patches

2017-12-19 Thread Stefan Hajnoczi
The following changes since commit eaefea537b476cb853e2edbdc68e969ec777e4bb: Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into staging (2017-12-18 14:17:42 +) are available in the Git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for

[Qemu-devel] [PULL v2 03/23] hw/block: Fix the return type

2017-12-19 Thread Stefan Hajnoczi
From: Mao Zhongyi When the function no success value to transmit, it usually make the function return void. It has turned out not to be a success, because it means that the extra local_err variable and error_propagate() will be needed. It leads to cumbersome code, therefore, transmit success/ fai

[Qemu-devel] [PULL v2 01/23] coroutine: simplify co_aio_sleep_ns() prototype

2017-12-19 Thread Stefan Hajnoczi
The AioContext pointer argument to co_aio_sleep_ns() is only used for the sleep timer. It does not affect where the caller coroutine is resumed. Due to changes to coroutine and AIO APIs it is now possible to drop the AioContext pointer argument. This is safe to do since no caller has specific re

[Qemu-devel] [PULL v2 10/23] block: don't keep AioContext acquired after blockdev_backup_prepare()

2017-12-19 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake Message-id: 20171206144550.22295-5-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi --- blockdev.c | 44 ++-- 1 file changed, 34 insertions(+), 10 deletions(-) diff --git a

[Qemu-devel] [PULL v2 12/23] block: drop unused BlockDirtyBitmapState->aio_context field

2017-12-19 Thread Stefan Hajnoczi
The dirty bitmap actions in qmp_transaction have not used AioContext since the dirty bitmap locking discipline was introduced in commit 2119882c7eb7e2c612b24fc0c8d86f5887d6f1c3 ("block: introduce dirty_bitmap_mutex"). Remove the unused field. Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wol

[Qemu-devel] [PULL v2 04/23] hw/block: Use errp directly rather than local_err

2017-12-19 Thread Stefan Hajnoczi
From: Mao Zhongyi [Drop virtio_blk_data_plane_create() change that misinterprets return value when the virtio transport does not support dataplane. --Stefan] Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz Cc: Keith Busch Cc: Stefan Hajnoczi Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Gerd

[Qemu-devel] [PULL v2 05/23] dev-storage: Fix the unusual function name

2017-12-19 Thread Stefan Hajnoczi
From: Mao Zhongyi The function name of usb_msd_{realize,unrealize}_*, usb_msd_class_initfn_* are unusual. Rename it to usb_msd_*_{realize,unrealize}, usb_msd_class_*_initfn. Cc: Gerd Hoffmann Signed-off-by: Mao Zhongyi Reviewed-by: Philippe Mathieu-Daudé Message-id: 11e6003433abce35f3f4970e

[Qemu-devel] [PULL v2 11/23] block: don't keep AioContext acquired after internal_snapshot_prepare()

2017-12-19 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake Message-id: 20171206144550.22295-6-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi --- blockdev.c | 47 +++ 1 file changed, 31 insertions(+), 16 deletions(-) diff --gi

[Qemu-devel] [PULL v2 17/23] virtio-blk: reject configs with logical block size > physical block size

2017-12-19 Thread Stefan Hajnoczi
From: Mark Kanda virtio-blk logical block size should never be larger than physical block size because it doesn't make sense to have such configurations. QEMU doesn't have a way to effectively express this condition; the best it can do is report the physical block exponent as 0 - indicating the l

[Qemu-devel] [PULL v2 15/23] qemu-iotests: add 202 external snapshots IOThread test

2017-12-19 Thread Stefan Hajnoczi
QMP 'transaction' blockdev-snapshot-sync with multiple disks in an IOThread is an untested code path. Several bugs have been found in connection with this command. This patch adds a test case to prevent future regressions. Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf Reviewed-by: Eri

[Qemu-devel] [PULL v2 06/23] qdev: drop unused #include "sysemu/iothread.h"

2017-12-19 Thread Stefan Hajnoczi
Commit 1351d1ec89eabebc9fdff20451a62c413d7accc1 ("qdev: drop iothread property type") forgot to remove this include. Signed-off-by: Stefan Hajnoczi Message-id: 20171205133954.31006-1-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi --- hw/core/qdev-properties-system.c | 1 - 1 file changed, 1

[Qemu-devel] [PULL v2 09/23] block: don't keep AioContext acquired after drive_backup_prepare()

2017-12-19 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake Message-id: 20171206144550.22295-4-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi --- blockdev.c | 42 ++ 1 file changed, 34 insertions(+), 8 deletions(-) diff --git a/bl

[Qemu-devel] [PULL v2 21/23] iotests: add VM.add_object()

2017-12-19 Thread Stefan Hajnoczi
The VM.add_object() method can be used to add IOThreads or memory backend objects. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake Message-id: 20171207201320.19284-5-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/iotests.py | 5 + 1 file changed, 5 inserti

[Qemu-devel] [PULL v2 16/23] virtio-blk: make queue size configurable

2017-12-19 Thread Stefan Hajnoczi
From: Mark Kanda Depending on the configuration, it can be beneficial to adjust the virtio-blk queue size to something other than the current default of 128. Add a new property to make the queue size configurable. Signed-off-by: Mark Kanda Reviewed-by: Karl Heubaum Reviewed-by: Martin K. Peter

[Qemu-devel] [PULL v2 07/23] blockdev: hold AioContext for bdrv_unref() in external_snapshot_clean()

2017-12-19 Thread Stefan Hajnoczi
bdrv_unref() requires the AioContext lock because bdrv_flush() uses BDRV_POLL_WHILE(), which assumes the AioContext is currently held. If BDRV_POLL_WHILE() runs without AioContext held the pthread_mutex_unlock() call in aio_context_release() fails. This patch moves bdrv_unref() into the AioContex

[Qemu-devel] [PULL v2 23/23] qemu-iotests: add 203 savevm with IOThreads test

2017-12-19 Thread Stefan Hajnoczi
This test case will prevent future regressions with savevm and IOThreads. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake Message-id: 20171207201320.19284-7-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/203 | 59 +++

[Qemu-devel] [PULL v2 14/23] blockdev: add x-blockdev-set-iothread testing command

2017-12-19 Thread Stefan Hajnoczi
Currently there is no easy way for iotests to ensure that a BDS is bound to a particular IOThread. Normally the virtio-blk device calls blk_set_aio_context() when dataplane is enabled during guest driver initialization. This never happens in iotests since -machine accel=qtest means there is no gu

[Qemu-devel] [PULL v2 19/23] docs: mark nested AioContext locking as a legacy API

2017-12-19 Thread Stefan Hajnoczi
See the patch for why nested AioContext locking is no longer allowed. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake Message-id: 20171207201320.19284-3-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi --- docs/devel/multiple-iothreads.txt | 7 --- 1 file changed, 4 insertions(+),

[Qemu-devel] [PULL v2 08/23] block: don't keep AioContext acquired after external_snapshot_prepare()

2017-12-19 Thread Stefan Hajnoczi
It is not necessary to hold AioContext across transactions anymore since bdrv_drained_begin/end() is used to keep the nodes quiesced. In fact, using the AioContext lock for this purpose was always buggy. This patch reduces the scope of AioContext locked regions. This is not just a cleanup but al

[Qemu-devel] [PULL v2 18/23] block: avoid recursive AioContext acquire in bdrv_inactivate_all()

2017-12-19 Thread Stefan Hajnoczi
From: Paolo Bonzini BDRV_POLL_WHILE() does not support recursive AioContext locking. It only releases the AioContext lock once regardless of how many times the caller has acquired it. This results in a hang since the IOThread does not make progress while the AioContext is still locked. The fol

[Qemu-devel] [PULL v2 22/23] iothread: fix iothread_stop() race condition

2017-12-19 Thread Stefan Hajnoczi
There is a small chance that iothread_stop() hangs as follows: Thread 3 (Thread 0x7f63eba5f700 (LWP 16105)): #0 0x7f64012c09b6 in ppoll () at /lib64/libc.so.6 #1 0x55959992eac9 in ppoll (__ss=0x0, __timeout=0x0, __nfds=, __fds=) at /usr/include/bits/poll2.h:77 #2 0x55959992e

[Qemu-devel] [Bug 1738840] Re: qemu-img convert qcow2 to raw fails on OS X

2017-12-19 Thread Robert Marklund
I tried to make a quick grep of the start of the disk in the "bad" raw image and it does not exist anywhere so there is more ot it then just a offset issue. rg -M 20 -a --encoding=ascii '\xeb\x63\x90\x00\x00\x00\x00\x00\x00\x00\x00\x00' coreos_production_openstack_image.bin.apfs or rg -M 20 -a -

[Qemu-devel] [PULL v2 13/23] iothread: add iothread_by_id() API

2017-12-19 Thread Stefan Hajnoczi
Encapsulate IOThread QOM object lookup so that callers don't need to know how and where IOThread objects live. Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake Message-id: 20171206144550.22295-8-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi --- include/sysem

Re: [Qemu-devel] [Qemu-block] [PATCH v3] ssh: switch from libssh2 to libssh

2017-12-19 Thread Jeff Cody
On Mon, Dec 18, 2017 at 09:31:40PM +, Richard W.M. Jones wrote: > On Mon, Dec 18, 2017 at 01:43:39PM -0500, John Snow wrote: > > Hi, friendly ping: > > > > It's been over a month with no replies, so it's safe to say this has > > gotten lost in the 2.11 release shuffle. > > > > Recommend you r

[Qemu-devel] [PULL v2 20/23] blockdev: add x-blockdev-set-iothread force boolean

2017-12-19 Thread Stefan Hajnoczi
When a node is already associated with a BlockBackend the x-blockdev-set-iothread command refuses to set the IOThread. This is to prevent accidentally changing the IOThread when the nodes are in use. When the nodes are created with -drive they automatically get a BlockBackend. In that case we kn

Re: [Qemu-devel] [PATCH v1 00/13] Fix VNC server unbounded memory usage

2017-12-19 Thread Daniel P. Berrange
On Tue, Dec 19, 2017 at 09:57:59AM -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > In the 2.11 release we fixed CVE-2017-15268, which allowed the VNC > > websockets > > server to consume arbitrary memory when a slow client was connected. I have > > since discovered that

[Qemu-devel] [Bug 1738840] Re: qemu-img convert qcow2 to raw fails on OS X

2017-12-19 Thread Robert Marklund
Adding "-S 0" on the APFS convert only makes the file 8.5Gb but its still "bad". -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1738840 Title: qemu-img convert qcow2 to raw fails on OS X Status in

Re: [Qemu-devel] [PATCH] Split adb.c into adb.c, adb-mouse.c and adb-kbd.c

2017-12-19 Thread Philippe Mathieu-Daudé
Hi Laurent, On Tue, Dec 19, 2017 at 8:54 AM, Laurent Vivier wrote: > It makes the code clearer to separate the bus implementation > from the devices one. > > Remove ADB_DPRINTF() from adb.c instead of adding it to new files. > Some minor changes to make checkpatch.pl happy. > > Signed-off-by: Lau

[Qemu-devel] [PATCH 1/3] net: Remove the legacy "-net channel" parameter

2017-12-19 Thread Thomas Huth
It has never been documented, so hardly anybody knows about this parameter, and it is marked as deprecated since QEMU v2.6. Time to let it go now. Reviewed-by: Samuel Thibault Signed-off-by: Thomas Huth --- include/net/slirp.h | 2 -- net/net.c | 7 --- net/slirp.c | 34

[Qemu-devel] [PATCH 3/3] qemu-doc: Update the deprecation information of -tftp, -bootp, -redir and -smb

2017-12-19 Thread Thomas Huth
The information how to update the deprecated parameters was too scarce, so that some people did not update to the new syntax yet. Provide some more information to make sure that it is clear how to update from the old syntax to the new one. Signed-off-by: Thomas Huth --- qemu-doc.texi | 33 ++

[Qemu-devel] [PATCH 0/3] net: Remove "-net channel" and update "-net nic" docs

2017-12-19 Thread Thomas Huth
Remove the deprecated (and even undocumented) "-net channel" parameter, and update our docs with regards to the possibility to use "netdev=..." together with the "-net nic" option for embedded NICs. Thomas Huth (3): net: Remove the legacy "-net channel" parameter qemu-doc: The "-net nic" optio

[Qemu-devel] [PATCH 2/3] qemu-doc: The "-net nic" option can be used with "netdev=...", too

2017-12-19 Thread Thomas Huth
Looks like we missed to document that it is also possible to specify a netdev with "-net nic" - which is very useful if you want to configure your on-board NIC to use a backend that has been specified with "-netdev". Signed-off-by: Thomas Huth --- qemu-options.hx | 14 -- 1 file chan

[Qemu-devel] [Bug 1738840] Re: qemu-img convert qcow2 to raw fails on OS X

2017-12-19 Thread Robert Marklund
The image apfs2 here is created with "-S 0"and the .bin is a working one generated on a ubuntu machine. Strange thing is that this say they are identical: $ time qemu-img compare -f qcow2 -F raw coreos_production_openstack_image.img.org coreos_production_openstack_image.bin.apfs Images are iden

[Qemu-devel] [PATCH 0/4] Add aarch64_be-linux-user target

2017-12-19 Thread Michael Weiser
Hello, below patches add support for big-endian aarch64 to linux-user. Almost everything is already in place. The patches just set up the CPU flags as required for big-endianess, add a distinction in uname and make sure the instructions for the signal trampoline end up in memory little-endian. Fin

[Qemu-devel] [PATCH] linux-user: Fix support MIPS o32 FP64 mode

2017-12-19 Thread YunQiang Su
MIPS o32 has a mode called FP64, who has 32 64Bit FPU registers. To use it: add PR_GET_FP_MODE and PR_SET_FP_MODE options for prctl set CP0St_FR when binary as EF_MIPS_FP64 https://dmz-portal.mips.com/wiki/MIPS_O32_ABI_-_FR0_and_FR1_Interlinking Signed-off-by: YunQiang Su --- linux-user/main

[Qemu-devel] [PATCH] linux-user: MIPS set cpu to r6 CPU if binary is R6

2017-12-19 Thread YunQiang Su
MIPS r6 is not just simple super set for pre-R6, it also drops some instruction and even changes encoding for some. But r6 binary has the same header for binfmt_misc. So here we need to detect the version of binaries and set cpu_model for it. --- include/elf.h| 4 linux-user/elfload

[Qemu-devel] [PATCH] linux-user: set P5600 as default for MIPS o32

2017-12-19 Thread YunQiang Su
P5600 supports MIPS32r5, and is supported by qemu. The current 24Kf supports mips32r2 only, to execute r3/r5 binaries we need P5600. .CP1_fcr31_rw_bitmask for P5600 is also modified: to make FCR31_NAN2008 and FCR31_ABS2008 editable, otherwise only NAN2008 binaries are supported. Signed-off-by: Y

[Qemu-devel] [PATCH 1/4] linux-user: Add support for big-endian aarch64

2017-12-19 Thread Michael Weiser
Enable big-endian mode for data accesses on aarch64 for big-endian linux user mode. Activate it for all execution levels as documented by ARM: Set the SCTLR EE bit for ELs 1 through 3. Additionally set bit E0E in EL1 to enable it in EL0 as well. Signed-off-by: Michael Weiser --- linux-user/main.

Re: [Qemu-devel] [PATCH v2 01/13] build-sys: fix qemu-ga -pthread linking

2017-12-19 Thread Marc-André Lureau
Hi On Fri, Dec 15, 2017 at 7:21 PM, Philippe Mathieu-Daudé wrote: > Hi Marc-André, > > On 12/15/2017 12:06 PM, Marc-André Lureau wrote: >> When linking qemu-ga under some configuration (when gthread-2.0.pc >> doesn't have -pthread, as happening atm with meson build), you may >> have this linking

[Qemu-devel] [PATCH 4/4] configure: Add aarch64_be-linux-user target

2017-12-19 Thread Michael Weiser
Add target aarch64_be-linux-user. This allows a qemu-aarch64_be binary to be built that will run big-endian aarch64 binaries. Signed-off-by: Michael Weiser --- configure | 9 + default-configs/aarch64_be-linux-user.mak | 1 + 2 files changed, 6 insertions(

Re: [Qemu-devel] [PATCH v2 03/13] build-sys: add a rule to print a variable

2017-12-19 Thread Marc-André Lureau
Hi On Fri, Dec 15, 2017 at 7:28 PM, Eric Blake wrote: > On 12/15/2017 09:06 AM, Marc-André Lureau wrote: >> $ make print-CFLAGS >> CFLAGS=-fsanitize=address -Og -g >> >> Trick from various sources: >> https://stackoverflow.com/questions/16467718/how-to-print-out-a-variable-in-makefile >> https://

[Qemu-devel] [PATCH 3/4] linux-user: Fix endianess of aarch64 signal trampoline

2017-12-19 Thread Michael Weiser
Since for aarch64 the signal trampoline is synthesized directly into the signal frame we need to make sure the instructions end up little-endian. Otherwise the wrong endianness will cause a SIGILL upon return from the signal handler on big-endian targets. Signed-off-by: Michael Weiser --- linux-

Re: [Qemu-devel] [PATCH v2 04/13] build-sys: add AddressSanitizer when --enable-debug if possible

2017-12-19 Thread Marc-André Lureau
Hi On Fri, Dec 15, 2017 at 4:06 PM, Marc-André Lureau wrote: > Enable ASAN by default if the compiler supports it. > > If necessary, we could consider a seperate configure option, although > I like the idea to have it enabled by default with --enable-debug. Peter, Paolo, Fam, any thoughts about

[Qemu-devel] [PATCH 2/4] linux-user: Add separate aarch64_be uname

2017-12-19 Thread Michael Weiser
Make big-endian aarch64 systems identify as aarch64_be as expected by big-endian userland and toolchains. Signed-off-by: Michael Weiser --- linux-user/aarch64/target_syscall.h | 4 1 file changed, 4 insertions(+) diff --git a/linux-user/aarch64/target_syscall.h b/linux-user/aarch64/target

Re: [Qemu-devel] [PATCH v20 1/7] xbitmap: Introduce xbitmap

2017-12-19 Thread Philippe Ombredanne
Matthew, On Tue, Dec 19, 2017 at 1:17 PM, Wei Wang wrote: > From: Matthew Wilcox > > The eXtensible Bitmap is a sparse bitmap representation which is > efficient for set bits which tend to cluster. It supports up to > 'unsigned long' worth of bits, and this commit adds the bare bones -- > xb_se

Re: [Qemu-devel] [PATCH] s390x/sclp: fixup highest CPU address

2017-12-19 Thread Cornelia Huck
On Tue, 19 Dec 2017 09:28:07 +0100 Christian Borntraeger wrote: > the highest cpu address is not the same as max_cpus. max_cpus s/the/The/ > counts from 1 while the cpu address starts at 0. > > Signed-off-by: Christian Borntraeger > Reviewed-by: Jason J. Herne > --- > hw/s390x/sclp.c | 2 +-

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-19 Thread Vladimir Sementsov-Ogievskiy
13.12.2017 07:12, Fam Zheng wrote: On Mon, 11/13 19:20, Vladimir Sementsov-Ogievskiy wrote: Hi all. There are three qmp commands, needed to implement external backup API. Using these three commands, client may do all needed bitmap management by hand: on backup start we need to do a transactio

Re: [Qemu-devel] [PULL v1] Merge tpm 2017/12/19

2017-12-19 Thread Peter Maydell
On 19 December 2017 at 11:55, Stefan Berger wrote: > The patch in this pull request fixes a linker error when --disable-tpm is > used. > >Stefan > > The following changes since commit eaefea537b476cb853e2edbdc68e969ec777e4bb: > > Merge remote-tracking branch 'remotes/mjt/tags/trivial-patche

Re: [Qemu-devel] [PATCH V2 4/5] pvrdma: initial implementation

2017-12-19 Thread Michael S. Tsirkin
On Sun, Dec 17, 2017 at 02:54:56PM +0200, Marcel Apfelbaum wrote: > @@ -2847,15 +2847,16 @@ if test "$rdma" != "no" ; then > #include > int main(void) { return 0; } > EOF > - rdma_libs="-lrdmacm -libverbs" > + rdma_libs="-lrdmacm -libverbs -libumad" >if compile_prog "" "$rdma_libs" ; then

Re: [Qemu-devel] [Qemu-block] [PATCH v3] ssh: switch from libssh2 to libssh

2017-12-19 Thread Richard W.M. Jones
On Tue, Dec 19, 2017 at 10:24:18AM -0500, Jeff Cody wrote: > On Mon, Dec 18, 2017 at 09:31:40PM +, Richard W.M. Jones wrote: > > On Mon, Dec 18, 2017 at 01:43:39PM -0500, John Snow wrote: > > > Hi, friendly ping: > > > > > > It's been over a month with no replies, so it's safe to say this has

[Qemu-devel] [PATCH] monitor: Remove legacy "-mon default=on" parameter

2017-12-19 Thread Thomas Huth
The "default" parameter of the "-mon" option is useless since QEMU v2.4.0, and marked as deprecated since QEMU v2.8.0. That should have been long enough to let people update their scripts, so time to remove it now. Signed-off-by: Thomas Huth --- monitor.c | 3 --- qemu-doc.texi | 9 -

Re: [Qemu-devel] [PATCH 0/4] Add aarch64_be-linux-user target

2017-12-19 Thread Laurent Vivier
Le 19/12/2017 à 16:16, Michael Weiser a écrit : > Hello, > > below patches add support for big-endian aarch64 to linux-user. Almost > everything is already in place. The patches just set up the CPU flags as > required for big-endianess, add a distinction in uname and make sure the > instructions f

Re: [Qemu-devel] [PATCH] monitor: Remove legacy "-mon default=on" parameter

2017-12-19 Thread Daniel P. Berrange
On Tue, Dec 19, 2017 at 05:17:33PM +0100, Thomas Huth wrote: > The "default" parameter of the "-mon" option is useless since > QEMU v2.4.0, and marked as deprecated since QEMU v2.8.0. That > should have been long enough to let people update their scripts, > so time to remove it now. > > Signed-off

[Qemu-devel] vhost-user graceful connect/disconnect

2017-12-19 Thread Stefan Hajnoczi
Hi, Vhost-user implementations assume the slave is already running before the master starts. The slave is required during virtio device initialization (e.g. feature bit negotiation) and so it is simplest to assume that the master is already available and will respond immediately to the VHOST_USER_

Re: [Qemu-devel] [PATCH] Split adb.c into adb.c, adb-mouse.c and adb-kbd.c

2017-12-19 Thread Laurent Vivier
Le 19/12/2017 à 16:26, Philippe Mathieu-Daudé a écrit : > Hi Laurent, > > On Tue, Dec 19, 2017 at 8:54 AM, Laurent Vivier wrote: >> It makes the code clearer to separate the bus implementation >> from the devices one. >> >> Remove ADB_DPRINTF() from adb.c instead of adding it to new files. >> Som

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 1/5] s390-ccw: update libc

2017-12-19 Thread Collin L. Walling
On 12/19/2017 02:31 AM, Thomas Huth wrote: On 18.12.2017 17:16, Collin L. Walling wrote: On 12/18/2017 08:06 AM, Thomas Huth wrote: On 11.12.2017 23:19, Collin L. Walling wrote: Moved:    memcmp from bootmap.h to libc.h (renamed from _memcmp)    strlen from sclp.c to libc.h (renamed from _st

Re: [Qemu-devel] [PATCH v2 03/13] build-sys: add a rule to print a variable

2017-12-19 Thread Eric Blake
On 12/19/2017 09:45 AM, Marc-André Lureau wrote: +Useful make targets +=== + +- help + + Print a help message for the most common build targets. Except that this patch forgot to tweak 'make help' to mention 'make print-VAR' ;) Well, I don't think print-VAR is a common build

Re: [Qemu-devel] [PATCH] monitor: Remove legacy "-mon default=on" parameter

2017-12-19 Thread Thomas Huth
On 19.12.2017 17:21, Daniel P. Berrange wrote: > On Tue, Dec 19, 2017 at 05:17:33PM +0100, Thomas Huth wrote: >> The "default" parameter of the "-mon" option is useless since >> QEMU v2.4.0, and marked as deprecated since QEMU v2.8.0. That >> should have been long enough to let people update their

[Qemu-devel] [PATCH 0/2] qemu-iotests: add missing make rule for socket_scm_helper

2017-12-19 Thread Philippe Mathieu-Daudé
Hi, Apparently block-tests are only run on patchew CI, not Travis, so this went unnoticed. Now ./check does check for this helper, and errors are easier to figure out. Regards, Phil. Philippe Mathieu-Daudé (2): qemu-iotests: add missing rule to build socket_scm_helper qemu-iotests: check s

Re: [Qemu-devel] [PATCH v2 02/13] build-sys: silence make by default or V=0

2017-12-19 Thread Eric Blake
On 12/15/2017 09:06 AM, Marc-André Lureau wrote: Move generic make flags in MAKEFLAGS (SUBDIR_MAKEFLAGS is more qemu specific). Use --quiet to silence make 'is up to date' message. Signed-off-by: Marc-André Lureau --- Makefile | 2 +- rules.mak | 2 ++ 2 files changed, 3 insertions(+), 1

[Qemu-devel] [PATCH 1/2] qemu-iotests: add missing rule to build socket_scm_helper

2017-12-19 Thread Philippe Mathieu-Daudé
'make check-block' uses it on Linux. Signed-off-by: Philippe Mathieu-Daudé --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index b4bcc872f2..fa5e9597f1 100644 --- a/tests/Makefile.include +++ b/tests/M

Re: [Qemu-devel] [PATCH v3 2/2] target/i386: add clflushopt to "Skylake-Server" cpu model

2017-12-19 Thread Eduardo Habkost
On Tue, Dec 19, 2017 at 11:37:30AM +0800, Haozhong Zhang wrote: > CPUID_7_0_EBX_CLFLUSHOPT is missed in current "Skylake-Server" cpu > model. Add it to "Skylake-Server" cpu model on pc-i440fx-2.12 and > pc-q35-2.12. Keep it disabled in "Skylake-Server" cpu model on older > machine types. > > Signe

[Qemu-devel] [PATCH 2/2] qemu-iotests: check socket_scm_helper is available

2017-12-19 Thread Philippe Mathieu-Daudé
This now throws a more helpful error message when not found: tests/qemu-iotests$ ./check 045 QEMU -- "/qemu/build/x86_64-softmmu/qemu-system-x86_64" -nodefaults -machine accel=qtest QEMU_IMG -- "/qemu/build/qemu-img" QEMU_IO -- "/qemu/build/qemu-io" --cache writeback

Re: [Qemu-devel] [PATCH V5] pci: removed the is_express field since a uniform interface was inserted

2017-12-19 Thread Eduardo Habkost
On Mon, Dec 18, 2017 at 05:21:40PM +0200, Yoni Bettan wrote: > according to Eduardo Habkost's commit fd3b02c889 all PCIEs now implement > INTERFACE_PCIE_DEVICE so we don't need is_express field anymore. > > Devices that implements only INTERFACE_PCIE_DEVICE (is_express == 1) > or > devices that im

Re: [Qemu-devel] [PATCH 2/2] qemu: add linkspeed and duplex setting to virtio-net

2017-12-19 Thread Jason Baron via Qemu-devel
On 12/19/2017 04:19 AM, Yan Vugenfirer wrote: > >> On 18 Dec 2017, at 18:04, Jason Baron via Qemu-devel >> mailto:qemu-devel@nongnu.org>> wrote: >> >> >> >> On 12/18/2017 06:34 AM, Yan Vugenfirer wrote: >>> On 14 Dec 2017, at 21:33, Jason Baron via Qemu-devel mailto:qemu-devel@nongnu.o

[Qemu-devel] [Bug 1180777] Re: RDP traffic freeze on quiet network

2017-12-19 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

Re: [Qemu-devel] [PATCH V5] pci: removed the is_express field since a uniform interface was inserted

2017-12-19 Thread Marcel Apfelbaum
On 18/12/2017 17:21, Yoni Bettan wrote: according to Eduardo Habkost's commit fd3b02c889 all PCIEs now implement INTERFACE_PCIE_DEVICE so we don't need is_express field anymore. Devices that implements only INTERFACE_PCIE_DEVICE (is_express == 1) or devices that implements only INTERFACE_CONVENT

[Qemu-devel] [Bug 1299858] Re: qemu all apps crash on OS X 10.6.8

2017-12-19 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Bug 1202289] Re: Windows 2008/7 Guest to Guest Very slow 10-20Mbit/s

2017-12-19 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Bug 1211910] Re: Logical to linear address translation is wrong for 32-bit guests on a 64-bit hypervisor

2017-12-19 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Bug 1299566] Re: virtio serial doesn't work with virtio nic

2017-12-19 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-19 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 2:56 PM, Michael S. Tsirkin wrote: >> * Please handle short reads/writes and EAGAIN with the UNIX domain socket. >> Do >>not use read/write_all() functions because they hang QEMU until I/O >>completes. > > I'm not sure I agree with this one. vhost-user uses this

Re: [Qemu-devel] [PATCH qemu v2] RFC: vfio-pci: Allow mmap of MSIX BAR

2017-12-19 Thread Alex Williamson
On Tue, 19 Dec 2017 15:52:02 +1100 David Gibson wrote: > On Fri, Dec 15, 2017 at 05:29:14PM +1100, Alexey Kardashevskiy wrote: > > This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability > > which tells that a region with MSIX data can be mapped entirely, i.e. > > the VFIO PCI drive

Re: [Qemu-devel] [PATCH V2 4/5] pvrdma: initial implementation

2017-12-19 Thread Marcel Apfelbaum
On 19/12/2017 18:12, Michael S. Tsirkin wrote: On Sun, Dec 17, 2017 at 02:54:56PM +0200, Marcel Apfelbaum wrote: @@ -2847,15 +2847,16 @@ if test "$rdma" != "no" ; then #include int main(void) { return 0; } EOF - rdma_libs="-lrdmacm -libverbs" + rdma_libs="-lrdmacm -libverbs -libumad"

[Qemu-devel] [PATCH 0/9] iotests: python3 compatibility

2017-12-19 Thread Philippe Mathieu-Daudé
Hi, This is a very boring series. I a later series I refactor the iotests.py class, however when the first version of series [1] was posted I received comments that this class should no support Python 3. I didn't tested with very old CentOS release, but this should work with Python versions >= 2

[Qemu-devel] [PATCH 3/9] iotests: replace print statement by print() function for python3 compatibility

2017-12-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/qemu-iotests/149| 3 ++- tests/qemu-iotests/165| 3 ++- tests/qemu-iotests/iotests.py | 5 +++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/149 b/tests/qemu-iotests/149 index 223cd68ad5..d3ffa25

[Qemu-devel] [PATCH 2/9] qmp.py: encode JSON unicode as byte strings for python3 compatibility

2017-12-19 Thread Philippe Mathieu-Daudé
the socket API expects byte strings. Signed-off-by: Philippe Mathieu-Daudé --- scripts/qmp/qmp.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qmp/qmp.py b/scripts/qmp/qmp.py index 07c9632e9e..1080195e04 100644 --- a/scripts/qmp/qmp.py +++ b/scripts/qmp/qmp.py @@ -

[Qemu-devel] [PATCH 1/9] qemu.py: replace iteritems() by items() for python3 compatibility

2017-12-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- scripts/qemu.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qemu.py b/scripts/qemu.py index 9bfdf6d37d..5e12ac7c8c 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -247,7 +247,7 @@ class QEMUMachine(object): def q

[Qemu-devel] [PATCH 4/9] iotests: use octal numbers for python3 compatibility

2017-12-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/qemu-iotests/118 | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/tests/qemu-iotests/118 b/tests/qemu-iotests/118 index 8a9e838c90..3cf21218f0 100755 --- a/tests/qemu-iotests/118 +++ b/tests/qemu-iotests

[Qemu-devel] [PATCH 7/9] iotests: replace lambda function by lambda expression for python3 compatibility

2017-12-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/qemu-iotests/065 | 4 ++-- tests/qemu-iotests/139 | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/065 b/tests/qemu-iotests/065 index 72aa9707c7..e95f7f817b 100755 --- a/tests/qemu-iotests/065 +++ b/tests/qem

[Qemu-devel] [PATCH 6/9] iotests: replace dict.has_key() by 'in' operator for python3 compatibility

2017-12-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/qemu-iotests/093 | 2 +- tests/qemu-iotests/096 | 4 ++-- tests/qemu-iotests/136 | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/093 b/tests/qemu-iotests/093 index 5c36a5fb4d..28b1d021ca 100755 --- a/tests/q

[Qemu-devel] [PATCH 5/9] iotests: replace xrange() by range() for python3 compatibility

2017-12-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/qemu-iotests/044 | 14 +++--- tests/qemu-iotests/163 | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/qemu-iotests/044 b/tests/qemu-iotests/044 index 11ea0f4d35..1e96800176 100755 --- a/tests/qemu-iotests/044 +++

[Qemu-devel] [PATCH 8/9] iotests: replace assertEquals() by assertEqual() for python3 compatibility

2017-12-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/qemu-iotests/041| 6 +++--- tests/qemu-iotests/118| 4 ++-- tests/qemu-iotests/iotests.py | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 index a860a31e9a..fa0f20

[Qemu-devel] [PATCH 9/9] iotests.py: use io.StringIO with python3

2017-12-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/qemu-iotests/iotests.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 4c515d2e6c..0e1b8ab6e6 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu

Re: [Qemu-devel] [PULL 00/10] Command line patches for 2017-12-18

2017-12-19 Thread Peter Maydell
On 18 December 2017 at 17:30, Markus Armbruster wrote: > The following changes since commit 411ad78115ebeb3411cf4b7622784b93dfabe259: > > Merge remote-tracking branch > 'remotes/stefanberger/tags/pull-tpm-2017-12-15-1' into staging (2017-12-17 > 15:27:41 +) > > are available in the git rep

Re: [Qemu-devel] [PATCH V2 3/5] docs: add pvrdma device documentation

2017-12-19 Thread Michael S. Tsirkin
On Sun, Dec 17, 2017 at 02:54:55PM +0200, Marcel Apfelbaum wrote: > Signed-off-by: Marcel Apfelbaum > Signed-off-by: Yuval Shaia > --- > docs/pvrdma.txt | 145 > > 1 file changed, 145 insertions(+) > create mode 100644 docs/pvrdma.txt >

Re: [Qemu-devel] [PATCH V2 4/5] pvrdma: initial implementation

2017-12-19 Thread Michael S. Tsirkin
I won't have time to review before the next year. Results of a quick peek. On Sun, Dec 17, 2017 at 02:54:56PM +0200, Marcel Apfelbaum wrote: > +static void *mad_handler_thread(void *arg) > +{ > +PVRDMADev *dev = (PVRDMADev *)arg; > +int rc; > +QObject *o_ctx_id; > +unsigned long cq

Re: [Qemu-devel] [PATCH V2 5/5] MAINTAINERS: add entry for hw/net/pvrdma

2017-12-19 Thread Michael S. Tsirkin
On Sun, Dec 17, 2017 at 02:54:57PM +0200, Marcel Apfelbaum wrote: > Signed-off-by: Marcel Apfelbaum > Signed-off-by: Yuval Shaia > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ffd77b461c..d24401a4d0 100644 > --- a/MAINTAINER

Re: [Qemu-devel] [PATCH v1 10/13] ui: fix VNC client throttling when forced update is requested

2017-12-19 Thread Marc-André Lureau
Hi On Mon, Dec 18, 2017 at 8:12 PM, Daniel P. Berrange wrote: > The VNC server must throttle data sent to the client to prevent the 'output' > buffer size growing without bound, if the client stops reading data off the > socket (either maliciously or due to stalled/slow network connection). > > T

Re: [Qemu-devel] [PATCH V2 0/5] hw/pvrdma: PVRDMA device implementation

2017-12-19 Thread Michael S. Tsirkin
On Sun, Dec 17, 2017 at 02:54:52PM +0200, Marcel Apfelbaum wrote: > RFC -> V2: > - Full implementation of the pvrdma device > - Backend is an ibdevice interface, no need for the KDBR module > > General description > === > PVRDMA is the QEMU implementation of VMware's paravirtuali

[Qemu-devel] [Bug 1299566] Re: virtio serial doesn't work with virtio nic

2017-12-19 Thread Michał Zieliński
I can't reproduce it now, I don't even remember this issue. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1299566 Title: virtio serial doesn't work with virtio nic Status in QEMU: Incomplete Bu

Re: [Qemu-devel] [PATCH v1 10/13] ui: fix VNC client throttling when forced update is requested

2017-12-19 Thread Daniel P. Berrange
On Tue, Dec 19, 2017 at 06:57:23PM +0100, Marc-André Lureau wrote: > Hi > > On Mon, Dec 18, 2017 at 8:12 PM, Daniel P. Berrange > wrote: > > The VNC server must throttle data sent to the client to prevent the 'output' > > buffer size growing without bound, if the client stops reading data off th

Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement

2017-12-19 Thread Michael S. Tsirkin
On Tue, Dec 19, 2017 at 11:05:11PM +0900, Tetsuo Handa wrote: > Wei Wang wrote: > > ChangeLog: > > v19->v20: > > 1) patch 1: xbitmap > > - add __rcu to "void **slot"; > > - remove the exceptional path. > > 2) patch 3: xbitmap > > - DeveloperNotes: add an item to comment that the current

[Qemu-devel] [PATCH 1/3] vhost-user: rename VhostUserMemory userspace_addr field to user_addr

2017-12-19 Thread Maxime Coquelin
The Vhost-user specification does not specify the user address should be a valid address within master process address space. Let's name it user_addr to comply with the specification. Cc: Stefan Hajnoczi Cc: Michael S. Tsirkin Signed-off-by: Maxime Coquelin --- hw/virtio/vhost-user.c | 4 ++--

[Qemu-devel] [PATCH 0/3] Vhost: no more leak QEMU virtual addresses to user backend

2017-12-19 Thread Maxime Coquelin
Before this series, QEMU process virtual addresses are sent to the user backend as user addresses. Passing these virtual addresses aren't useful, as the backend doesn't direct access to QEMU address space. It does make sense however for kernel backend, which can access QEMU address space. This s

[Qemu-devel] [PATCH 3/3] vhost-user: no more leak QEMU virtual addresses to user backend

2017-12-19 Thread Maxime Coquelin
The user backends use user address from VHOST_USER_SET_MEM_TABLE to be able to handle VHOST_USER_SET_VRING_ADDR and VHOST_USER_IOTLB_MSG payloads. Now that Vhost code supports the use of Guest physical addresses instead of QEMU process virtual addresses, let's do the switch to avoid leaking QEMU p

[Qemu-devel] [PATCH 2/3] vhost: introduce backend's user address type

2017-12-19 Thread Maxime Coquelin
User backends don't need to know about QEMU virtual addresses. It is possible to use guest physical addresses as user addresses without user backends changes. This patch introduces a new enum in VhostOps to specify whether the backend expects the user addresses to be host virtual or guest physical

Re: [Qemu-devel] [PATCH] monitor: Remove legacy "-mon default=on" parameter

2017-12-19 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > On 19.12.2017 17:21, Daniel P. Berrange wrote: > > On Tue, Dec 19, 2017 at 05:17:33PM +0100, Thomas Huth wrote: > >> The "default" parameter of the "-mon" option is useless since > >> QEMU v2.4.0, and marked as deprecated since QEMU v2.8.0. That > >> should

[Qemu-devel] [Bug 1722884] Re: keyboard input while mouse moving triggers mouse failure

2017-12-19 Thread Geoffrey McRae
This bug needs some attention, we just released Looking Glass which relies heavily on the relative input mode of SPICE which in turn relies heavily on the virtual i8042 controller. This project has the ability to completely eliminate the need to dual boot a Linux machine with windows and is gaining

<    1   2   3   >