On 12/19/2017 09:45 AM, Marc-André Lureau wrote:

+Useful make targets
+===================
+
+- help
+
+  Print a help message for the most common build targets.

Except that this patch forgot to tweak 'make help' to mention 'make
print-VAR' ;)

Well, I don't think print-VAR is a common build target, it's a
build-sys hack/debug imho, so having it described in build-system.txt
only make sense.

Do you agree?

With the bash-completion library installed, performing tab-completion on 'make ' produces a large list of targets, which includes 'help', but even with your patch does NOT include 'print-CFLAGS' or any variant of print-. If I use just tab-completion and 'make help', then having 'print-FOO' listed under the "Generic targets:" section of the help output would let me discover it without me having to read build-system.txt.

Does anyone else have a strong opinion for or against the additional output in 'make help'?

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Reply via email to