Re: [Qemu-devel] [RFC v5 06/26] monitor: move the cur_mon hack deeper for QMP

2017-12-15 Thread Peter Xu
On Wed, Dec 13, 2017 at 03:41:49PM +, Stefan Hajnoczi wrote: > On Tue, Dec 05, 2017 at 01:51:40PM +0800, Peter Xu wrote: > > In monitor_qmp_read(), we have the hack to temporarily replace the > > cur_mon pointer. Now we move this hack deeper inside the QMP dispatcher > > routine since the Moni

[Qemu-devel] [PATCH 1/2] block: Open backing image in force share mode for size probe

2017-12-15 Thread Fam Zheng
Management tools create overlays of running guests with qemu-img: $ qemu-img create -b /image/in/use.qcow2 -f qcow2 /overlay/image.qcow2 but this doesn't work anymore due to image locking: qemu-img: /overlay/image.qcow2: Failed to get shared "write" lock Is another process using the im

[Qemu-devel] [PATCH 0/2] block: Fix qemu-img creating overlay when guest running

2017-12-15 Thread Fam Zheng
Shared write lock is not strictly necessary for creating the overlay image, if all what we want is to probe the size. Fam Zheng (2): block: Open backing image in force share mode for size probe iotests: Test creating overlay when guest running block.c| 3 ++- tests/qemu-i

[Qemu-devel] [PATCH 2/2] iotests: Test creating overlay when guest running

2017-12-15 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/153 | 4 tests/qemu-iotests/153.out | 3 +++ 2 files changed, 7 insertions(+) diff --git a/tests/qemu-iotests/153 b/tests/qemu-iotests/153 index fa25eb24bd..22cb9c69a7 100755 --- a/tests/qemu-iotests/153 +++ b/tests/qemu-iotests/153 @@ -32

Re: [Qemu-devel] [PATCH 06/14] sdhci: refactor same sysbus/pci properties into a common one

2017-12-15 Thread Paolo Bonzini
On 14/12/2017 19:40, Philippe Mathieu-Daudé wrote: >>> +DEFINE_PROP_BOOL("pending-insert-quirk", SDHCIState, >>> pending_insert_quirk, >>> + false), >> I like the reduction of code in this patch, but aren't we now going to >> have device properties that aren't actually conn

Re: [Qemu-devel] [RFC v5 07/26] monitor: unify global init

2017-12-15 Thread Peter Xu
On Wed, Dec 13, 2017 at 03:48:06PM +, Stefan Hajnoczi wrote: > On Tue, Dec 05, 2017 at 01:51:41PM +0800, Peter Xu wrote: > > diff --git a/vl.c b/vl.c > > index 1ad1c04637..1ec995a6ae 100644 > > --- a/vl.c > > +++ b/vl.c > > @@ -3144,7 +3144,6 @@ int main(int argc, char **argv, char **envp) > >

Re: [Qemu-devel] [PATCH 01/26] sdbus: add a QMP command to access a SDBus

2017-12-15 Thread Paolo Bonzini
On 14/12/2017 14:25, Philippe Mathieu-Daudé wrote: > Yes, a SDHCI qtest is added in a later series (in C) using MMIO access: > http://lists.nongnu.org/archive/html/qemu-devel/2017-12/msg02391.html > > But to be sure the SDHCI is correct I needed a SD slave to behave > correctly ;) Hence this "bus

Re: [Qemu-devel] [PATCH v2] dump-guest-memory.py: fix "You can't do that without a process to debug"

2017-12-15 Thread Fam Zheng
On Tue, 12/12 18:30, Laszlo Ersek wrote: > On 12/12/17 18:26, no-re...@patchew.org wrote: > > Hi, > > > > This series seems to have some coding style problems. See output below for > > more information: > > > > Message-id: 20171212172208.13588-1-marcandre.lur...@redhat.com > > Subject: [Qemu-deve

Re: [Qemu-devel] [PATCH v5 0/2] remove i386/pc dependency from non-PC world (part 1) fix

2017-12-15 Thread Paolo Bonzini
On 15/12/2017 04:43, Philippe Mathieu-Daudé wrote: > Fix patch 42 from previous series (v4) so patchew can build, and if a > maintainer > is willing to take the previous series with the last 2 patches, I don't need > to > respam a v6. > > Regards, > > Phil. I tweaked a bit patch 1 to use LOG_U

Re: [Qemu-devel] [PATCH v2 0/5] target/m68k: implement 680x0 FPU (part 3)

2017-12-15 Thread william lin
Hi, Does anyone know what is the status on this patch? In particular I need the code from the later patches in Laurent's tree (sin, cos, etc..) to fix the x87 fpu bug. >From what I understand, there shouldn't be any licensing issue with the code as implementation's algorithm was taken from the ve

Re: [Qemu-devel] [RFC v5 09/26] monitor: create monitor dedicate iothread

2017-12-15 Thread Peter Xu
On Wed, Dec 13, 2017 at 04:20:22PM +, Stefan Hajnoczi wrote: > On Tue, Dec 05, 2017 at 01:51:43PM +0800, Peter Xu wrote: > > @@ -208,6 +209,12 @@ struct Monitor { > > QTAILQ_ENTRY(Monitor) entry; > > }; > > > > +struct MonitorGlobal { > > +IOThread *mon_iothread; > > +}; > > + > > +

Re: [Qemu-devel] [qemu-s390x] [PULL 00/46] First batch of s390x patches for 2.12

2017-12-15 Thread Christian Borntraeger
On 12/14/2017 08:05 PM, Peter Maydell wrote: > On 14 December 2017 at 17:09, Cornelia Huck wrote: >> The following changes since commit 0ef0583d5adceb9138bdb47494dabd1549ac5b6d: >> >> Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20171214' >> into staging (2017-12-14 15:32:32 +

[Qemu-devel] [PATCH v2 0/2] vhost: two fixes

2017-12-15 Thread Jay Zhou
v1 -> v2: * delete the "used_memslots" global variable, and add it for vhost-user and vhost-kernel separately Jay Zhou (2): vhost: add used memslot number for vhost-user and vhost-kernel separately vhost: double check used memslots number hw/virtio/vhost-backend.c | 14

[Qemu-devel] [PATCH v2 2/2] vhost: double check used memslots number

2017-12-15 Thread Jay Zhou
If the VM already has N(N>8) available memory slots for vhost user, the VM will be crashed in vhost_user_set_mem_table if we try to hotplug the first vhost user NIC. This patch checks if memslots number exceeded or not after updating vhost_user_used_memslots. Signed-off-by: Jay Zhou --- hw/virti

[Qemu-devel] [PATCH v2 1/2] vhost: add used memslot number for vhost-user and vhost-kernel separately

2017-12-15 Thread Jay Zhou
Used_memslots is equal to dev->mem->nregions now, it is true for vhost kernel, but not for vhost user, which uses the memory regions that have file descriptor. In fact, not all of the memory regions have file descriptor. It is usefully in some scenarios, e.g. used_memslots is 8, and only 5 memory s

Re: [Qemu-devel] [RFC v5 10/26] monitor: allow to use IO thread for parsing

2017-12-15 Thread Peter Xu
On Wed, Dec 13, 2017 at 04:35:00PM +, Stefan Hajnoczi wrote: > On Tue, Dec 05, 2017 at 01:51:44PM +0800, Peter Xu wrote: > > @@ -583,6 +585,7 @@ static void monitor_data_init(Monitor *mon, bool > > skip_flush) > > /* Use *mon_cmds by default. */ > > mon->cmd_table = mon_cmds; > >

Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-15 Thread Wei Wang
On 12/15/2017 01:32 AM, Stefan Hajnoczi wrote: On Thu, Dec 14, 2017 at 01:53:16PM +0800, Wei Wang wrote: On 12/13/2017 08:35 PM, Stefan Hajnoczi wrote: On Wed, Dec 13, 2017 at 04:11:45PM +0800, Wei Wang wrote: I think the current approach is fine for a prototype but is not suitable for wider u

Re: [Qemu-devel] [qemu-s390x] [PULL 00/46] First batch of s390x patches for 2.12

2017-12-15 Thread Cornelia Huck
On Fri, 15 Dec 2017 09:35:10 +0100 Christian Borntraeger wrote: > On 12/14/2017 08:05 PM, Peter Maydell wrote: > > On 14 December 2017 at 17:09, Cornelia Huck wrote: > >> The following changes since commit > >> 0ef0583d5adceb9138bdb47494dabd1549ac5b6d: > >> > >> Merge remote-tracking branch

Re: [Qemu-devel] [RFC v5 11/26] qmp: introduce QMPCapability

2017-12-15 Thread Peter Xu
On Wed, Dec 13, 2017 at 04:56:51PM +, Stefan Hajnoczi wrote: > On Tue, Dec 05, 2017 at 01:51:45PM +0800, Peter Xu wrote: > > There was no QMP capabilities defined. Define the first "oob" as > > capability to allow out-of-band messages. > > > > Also, touch up qmp-test.c to test the new bits. >

Re: [Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id

2017-12-15 Thread Max Reitz
On 2017-12-13 05:50, seeteena wrote: > Hi David, > > While creating snapshots when tag name '0' used in the very first and > followed by tag name '1' then snapshot created with tag name '0' is getting > erased. > A snapshot is identified by a name computed either from an id, which is > basical

Re: [Qemu-devel] [PATCH 0/2] vhost: two fixes

2017-12-15 Thread Dr. David Alan Gilbert
* Zhoujian (jay) (jianjay.z...@huawei.com) wrote: > Hi Dave, > > > -Original Message- > > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > > Sent: Friday, December 15, 2017 3:49 AM > > To: Michael S. Tsirkin > > Cc: Zhoujian (jay) ; qemu-devel@nongnu.org; > > Huangweidong (C) ;

Re: [Qemu-devel] [PATCH v6 4/4] hw: convert XenInput keyboard to keycodemapdb

2017-12-15 Thread Daniel P. Berrange
On Wed, Dec 13, 2017 at 03:01:51PM +, Anthony PERARD wrote: > On Tue, Dec 12, 2017 at 02:10:44PM +, Daniel P. Berrange wrote: > > Replace the scancode2linux table with an automatically > > generated table. In doing so, the XenFB keyboard > > handler is also converted to the modern InputEven

[Qemu-devel] [Bug 1738283] Re: 'Less than' (<), 'more than' (>), and 'pipe' (|) can't be typed via VNC

2017-12-15 Thread Daniel Berrange
By default virt-manager will *not* enable the '-k en-us' argument, because that forces use of a specific keyboard layout in QEMU's VNC server. For that to work, the VNC client keymap must exactly match the QEMU VNC server keymap, and must also exactly match the guest OS keymap. Instead virt-manage

Re: [Qemu-devel] [RFC v5 11/26] qmp: introduce QMPCapability

2017-12-15 Thread Fam Zheng
On Fri, 12/15 17:14, Peter Xu wrote: > On Wed, Dec 13, 2017 at 04:56:51PM +, Stefan Hajnoczi wrote: > > On Tue, Dec 05, 2017 at 01:51:45PM +0800, Peter Xu wrote: > > > There was no QMP capabilities defined. Define the first "oob" as > > > capability to allow out-of-band messages. > > > > > >

Re: [Qemu-devel] [RFC v5 12/26] qmp: negociate QMP capabilities

2017-12-15 Thread Fam Zheng
On Wed, 12/13 17:19, Stefan Hajnoczi wrote: > On Tue, Dec 05, 2017 at 01:51:46PM +0800, Peter Xu wrote: > > @@ -1037,8 +1038,42 @@ static void monitor_init_qmp_commands(void) > > qmp_marshal_qmp_capabilities, QCO_NO_OPTIONS); > > } > > > > -void qmp_qmp_capabilities(Err

Re: [Qemu-devel] [RFC v5 13/26] qmp: introduce some capability helpers

2017-12-15 Thread Fam Zheng
On Tue, 12/05 13:51, Peter Xu wrote: > Introduce qmp_cap_enabled() and qmp_oob_enabled() helpers. > > Signed-off-by: Peter Xu > --- > monitor.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/monitor.c b/monitor.c > index 097312e65f..9666115259 100644 > --- a/monitor.c > ++

Re: [Qemu-devel] [PATCH qemu v2] kvm: Add kvm_set_user_memory tracepoint

2017-12-15 Thread Darren Kenny
On Fri, Dec 15, 2017 at 04:23:26PM +1100, Alexey Kardashevskiy wrote: This adds a tracepoint to trace the KVM_SET_USER_MEMORY_REGION ioctl parameters which is quite useful for debugging VFIO memory regions being actually registered with KVM. Signed-off-by: Alexey Kardashevskiy --- Changes: v2:

Re: [Qemu-devel] [RFC v5 19/26] qapi: introduce new cmd option "allow-oob"

2017-12-15 Thread Fam Zheng
On Tue, 12/05 13:51, Peter Xu wrote: > --- a/qapi/introspect.json > +++ b/qapi/introspect.json > @@ -259,12 +259,16 @@ > # > # @ret-type: the name of the command's result type. > # > +# @allow-oob: whether the command allows out-of-band execution. > +# (Since: 2.11) (Since: 2.12) F

Re: [Qemu-devel] [qemu-s390x] [PULL 00/46] First batch of s390x patches for 2.12

2017-12-15 Thread Peter Maydell
On 15 December 2017 at 09:11, Cornelia Huck wrote: > On Fri, 15 Dec 2017 09:35:10 +0100 > Christian Borntraeger wrote: > >> On 12/14/2017 08:05 PM, Peter Maydell wrote: >> > (ram_addr_t can be a 32-bit type). > > This a 32 bit host, isn't it? I don't have regular access to one... Yes. Win32 cros

Re: [Qemu-devel] [qemu-s390x] [PULL 00/46] First batch of s390x patches for 2.12

2017-12-15 Thread David Hildenbrand
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > index 80e753a5ef..9abb8de9f9 100644 > --- a/hw/s390x/s390-virtio-ccw.c > +++ b/hw/s390x/s390-virtio-ccw.c > @@ -172,9 +172,10 @@ static void s390_memory_init(ram_addr_t mem_size) > name = g_strdup_printf("s390.ram"); >

Re: [Qemu-devel] [qemu-s390x] [PULL 00/46] First batch of s390x patches for 2.12

2017-12-15 Thread Christian Borntraeger
On 12/15/2017 10:53 AM, David Hildenbrand wrote: > >> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c >> index 80e753a5ef..9abb8de9f9 100644 >> --- a/hw/s390x/s390-virtio-ccw.c >> +++ b/hw/s390x/s390-virtio-ccw.c >> @@ -172,9 +172,10 @@ static void s390_memory_init(ram_addr_

Re: [Qemu-devel] [PATCH v4 1/6] vhost: Move log_dirty check

2017-12-15 Thread Igor Mammedov
On Thu, 14 Dec 2017 15:20:10 + "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Wed, 13 Dec 2017 18:08:02 + > > "Dr. David Alan Gilbert (git)" wrote: > > > > > From: "Dr. David Alan Gilbert" > > > > > > Move the log_dirty check into vhost_section

Re: [Qemu-devel] [PATCH v2 02/15] imx_fec: Refactor imx_eth_enable_rx()

2017-12-15 Thread Philippe Mathieu-Daudé
On 12/14/2017 11:52 AM, Andrey Smirnov wrote: > Refactor imx_eth_enable_rx() to have more meaningfull variable name > than 'tmp' and to reduce number of logical negations done. > > Cc: Peter Maydell > Cc: Jason Wang > Cc: Philippe Mathieu-Daudé > Cc: qemu-devel@nongnu.org > Cc: qemu-...@nongnu.

Re: [Qemu-devel] [qemu-s390x] [PULL 00/46] First batch of s390x patches for 2.12

2017-12-15 Thread David Hildenbrand
On 15.12.2017 10:53, Christian Borntraeger wrote: > > > On 12/15/2017 10:53 AM, David Hildenbrand wrote: >> >>> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c >>> index 80e753a5ef..9abb8de9f9 100644 >>> --- a/hw/s390x/s390-virtio-ccw.c >>> +++ b/hw/s390x/s390-virtio-ccw.c >>

Re: [Qemu-devel] [PATCH v2 05/15] imx_fec: Use ENET_FTRL to determine truncation length

2017-12-15 Thread Philippe Mathieu-Daudé
Hi Andrey, On 12/14/2017 11:52 AM, Andrey Smirnov wrote: > Frame truncation length, TRUNC_FL, is determined by the contents of > ENET_FTRL register, so convert the code to use it instead of a > hardcoded constant. > > To avoid the case where TRUNC_FL is greater that ENET_MAX_FRAME_SIZE, > increas

[Qemu-devel] [PATCH 1/4] tests/pxe-test: Remove unnecessary special case test functions

2017-12-15 Thread David Gibson
All of the x86 and some of the other test cases here use a common test function, test_pxe_ipv4(), but one ppc and one s390 test use different functions. In the s390 case, this is completely pointless, the right parameter to test_pxe_ipv4() will already do exactly the right thing. For the spapr-vl

[Qemu-devel] [PATCH 0/4] Improvements to pxe-test

2017-12-15 Thread David Gibson
This series makes several cleanups and enhancements to tests/pxe-test. In particular it improves its handling of different machine types. David Gibson (4): tests/pxe-test: Remove unnecessary special case test functions tests/pxe-test: Use table of testcases rather than open-coding tests/pxe-

[Qemu-devel] [PATCH 4/4] tests/pxe-test: Add some extra tests

2017-12-15 Thread David Gibson
Previously virtio-net was only tested for ppc64 in "slow" mode. That doesn't make much sense since virtio-net is used much more often in practice than the spapr-vlan device which was tested always. So, move virtio-net to always be tested on ppc64. We had no tests at all for the q35 machine, whic

[Qemu-devel] [PATCH 2/4] tests/pxe-test: Use table of testcases rather than open-coding

2017-12-15 Thread David Gibson
Currently pxe-tests open codes the list of tests for each architecture. This changes it to use tables of test parameters, somewhat similar to boot-serial-test. This adds the machine type into the table as well, giving us the ability to perform tests on multiple machine types for architectures wher

Re: [Qemu-devel] [PATCH v4 04/43] MAINTAINERS: add an entry for the i82378 (superio)

2017-12-15 Thread Thomas Huth
On 15.12.2017 04:29, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Hervé Poussineau > Reviewed-by: Hervé Poussineau Remove the doubled Reviewed-by, or replace the second line with: Reviewed-by: Thomas Huth > --- > MAINTAINERS | 1 + > 1 file changed, 1

Re: [Qemu-devel] [qemu-s390x] [PULL 00/46] First batch of s390x patches for 2.12

2017-12-15 Thread Cornelia Huck
On Fri, 15 Dec 2017 09:51:32 + Peter Maydell wrote: > On 15 December 2017 at 09:11, Cornelia Huck wrote: > > On Fri, 15 Dec 2017 09:35:10 +0100 > > Christian Borntraeger wrote: > > > >> On 12/14/2017 08:05 PM, Peter Maydell wrote: > >> > (ram_addr_t can be a 32-bit type). > > > > This

[Qemu-devel] [PATCH 3/4] tests/pxe-test: Test net booting over IPv6 in some cases

2017-12-15 Thread David Gibson
This adds IPv6 net boot testing (in addition to IPv4) when in slow test mode on ppc64 or s390. IPv6 PXE doesn't seem to work on x86, I'm guessing out BIOS image doesn't support it. Signed-off-by: David Gibson --- tests/pxe-test.c | 26 -- 1 file changed, 20 insertions(+)

Re: [Qemu-devel] [PATCH v4 04/43] MAINTAINERS: add an entry for the i82378 (superio)

2017-12-15 Thread Philippe Mathieu-Daudé
On 12/15/2017 07:17 AM, Thomas Huth wrote: > On 15.12.2017 04:29, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> Reviewed-by: Hervé Poussineau >> Reviewed-by: Hervé Poussineau > > Remove the doubled Reviewed-by, or replace the second line with: > > Reviewed-by: Thoma

Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-15 Thread Wei Wang
On 12/14/2017 11:06 PM, Stefan Hajnoczi wrote: On Wed, Dec 13, 2017 at 10:59:10PM +0200, Michael S. Tsirkin wrote: * VHOST_USER_SET_VRING_KICK Set up vring kick doorbell (unless bit 8 is set) before sending VHOST_USER_SET_VRING_KICK to the guest. But guest can't use it, now can it?

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-15 Thread Wei Wang
On 12/15/2017 02:04 AM, Stefan Hajnoczi wrote: On Thu, Dec 14, 2017 at 01:53:16PM +0800, Wei Wang wrote: 3rd one: I'm not able to solve this one, as discussed, there are too many differences and it's too complex. I prefer the direction of simply gating the vhost-user protocol and deliver to the

Re: [Qemu-devel] [qemu-s390x] [PULL 00/46] First batch of s390x patches for 2.12

2017-12-15 Thread Peter Maydell
On 15 December 2017 at 10:21, Cornelia Huck wrote: > On Fri, 15 Dec 2017 09:51:32 + > Peter Maydell wrote: > >> On 15 December 2017 at 09:11, Cornelia Huck wrote: >> > On Fri, 15 Dec 2017 09:35:10 +0100 >> > Christian Borntraeger wrote: >> > >> >> On 12/14/2017 08:05 PM, Peter Maydell wrote

Re: [Qemu-devel] [RFC v5 00/26] QMP: out-of-band (OOB) execution support

2017-12-15 Thread Fam Zheng
On Tue, 12/05 13:51, Peter Xu wrote: > This version is mostly document update, and dropped the single patch > that is migration related (will be put into postcopy recovery > series). Sorry if I'm asking an already answered question, if so please remind me with some pointers.. Can we completely hi

Re: [Qemu-devel] [qemu-s390x] [PULL 00/46] First batch of s390x patches for 2.12

2017-12-15 Thread Cornelia Huck
On Fri, 15 Dec 2017 10:33:28 + Peter Maydell wrote: > On 15 December 2017 at 10:21, Cornelia Huck wrote: > > On Fri, 15 Dec 2017 09:51:32 + > > Peter Maydell wrote: > > > >> On 15 December 2017 at 09:11, Cornelia Huck wrote: > >> > On Fri, 15 Dec 2017 09:35:10 +0100 > >> > Christia

Re: [Qemu-devel] [PATCH 4/4] tests/pxe-test: Add some extra tests

2017-12-15 Thread Thomas Huth
On 15.12.2017 11:16, David Gibson wrote: > Previously virtio-net was only tested for ppc64 in "slow" mode. That > doesn't make much sense since virtio-net is used much more often in > practice than the spapr-vlan device which was tested always. So, move > virtio-net to always be tested on ppc64.

Re: [Qemu-devel] [PATCH 1/4] tests/pxe-test: Remove unnecessary special case test functions

2017-12-15 Thread Thomas Huth
On 15.12.2017 11:16, David Gibson wrote: > All of the x86 and some of the other test cases here use a common test > function, test_pxe_ipv4(), but one ppc and one s390 test use different > functions. > > In the s390 case, this is completely pointless, the right parameter to > test_pxe_ipv4() will

[Qemu-devel] [PATCH] block: Document that x-blockdev-change breaks quorum children list

2017-12-15 Thread Kevin Wolf
Removing a quorum child node with x-blockdev-change results in a quorum driver state that cannot be recreated with create options because it would require a list with gaps. This causes trouble in at least .bdrv_refresh_filename(). Document this problem so that we won't accidentally mark the comman

[Qemu-devel] [PULL v2 46/46] s390-ccw-virtio: allow for systems larger that 7.999TB

2017-12-15 Thread Cornelia Huck
From: Christian Borntraeger KVM does not allow memory regions > KVM_MEM_MAX_NR_PAGES, basically limiting the memory per slot to 8TB-4k. As memory slots on s390/kvm must be a multiple of 1MB we need start a new memory region if we cross 8TB-1M. With that (and optimistic overcommitment in the kern

[Qemu-devel] [PULL v2 00/46] First batch of s390x patches for 2.12

2017-12-15 Thread Cornelia Huck
The following changes since commit 0ef0583d5adceb9138bdb47494dabd1549ac5b6d: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20171214' into staging (2017-12-14 15:32:32 +) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-20171215-v

Re: [Qemu-devel] [PATCH v19 1/7] xbitmap: Introduce xbitmap

2017-12-15 Thread kbuild test robot
-Wang/Virtio-balloon-Enhancement/20171215-100525 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) vim +29 lib/xbitmap.c 5 6 /** 7 * xb_set_bit - set a

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Document that x-blockdev-change breaks quorum children list

2017-12-15 Thread Alberto Garcia
On Fri 15 Dec 2017 11:59:05 AM CET, Kevin Wolf wrote: > Removing a quorum child node with x-blockdev-change results in a quorum > driver state that cannot be recreated with create options because it > would require a list with gaps. This causes trouble in at least > .bdrv_refresh_filename(). > > Do

Re: [Qemu-devel] [PATCH 2/4] tests/pxe-test: Use table of testcases rather than open-coding

2017-12-15 Thread Thomas Huth
On 15.12.2017 11:16, David Gibson wrote: > Currently pxe-tests open codes the list of tests for each architecture. > This changes it to use tables of test parameters, somewhat similar to > boot-serial-test. > > This adds the machine type into the table as well, giving us the ability > to perform t

Re: [Qemu-devel] [PATCH 3/4] tests/pxe-test: Test net booting over IPv6 in some cases

2017-12-15 Thread Thomas Huth
On 15.12.2017 11:16, David Gibson wrote: > This adds IPv6 net boot testing (in addition to IPv4) when in slow test > mode on ppc64 or s390. IPv6 PXE doesn't seem to work on x86, I'm guessing > out BIOS image doesn't support it. > > Signed-off-by: David Gibson > --- > tests/pxe-test.c | 26 +

Re: [Qemu-devel] [PULL 0/6] xen-20171214-tag

2017-12-15 Thread Peter Maydell
On 15 December 2017 at 00:27, Stefano Stabellini wrote: > The following changes since commit 0a0dc59d27527b78a195c2d838d28b7b49e5a639: > > Update version for v2.11.0 release (2017-12-13 14:31:09 +) > > are available in the git repository at: > > git://xenbits.xen.org/people/sstabellini/qem

Re: [Qemu-devel] [PATCH v5] nvme: Add tracing

2017-12-15 Thread Kevin Wolf
Am 03.11.2017 um 14:37 hat Doug Gale geschrieben: > Add trace output for commands, errors, and undefined behavior. > Add guest error log output for undefined behavior. > Report invalid undefined accesses to MMIO. > Annotate unlikely error checks with unlikely. > > Signed-off-by: Doug Gale > Revie

Re: [Qemu-devel] [PATCH] smbus: do not immediately complete commands

2017-12-15 Thread Philippe Mathieu-Daudé
On 12/10/2017 02:27 PM, Hervé Poussineau wrote: > PIIX4 errata says that "immediate polling of the Host Status Register BUSY > bit may indicate that the SMBus is NOT busy." > Due to this, some code does the following steps: > (a) set parameters > (b) start command > (c) check for smbus busy bit set

Re: [Qemu-devel] [PATCH 1/5] i8259: convert DPRINTFs into trace

2017-12-15 Thread Philippe Mathieu-Daudé
On 12/10/2017 03:38 AM, Peter Xu wrote: > One thing to mention is that in pic_set_irq() I need to uncomment a few > lines in the macros to make sure IRQ value calculation is correct. Yep, this is correct. > Signed-off-by: Peter Xu Reviewed-by: Philippe Mathieu-Daudé > --- > hw/intc/i8259.c

Re: [Qemu-devel] [PATCH 2/5] i8259: use DEBUG_IRQ_COUNT always

2017-12-15 Thread Philippe Mathieu-Daudé
On 12/10/2017 03:38 AM, Peter Xu wrote: > It's not really scary to even enable it forever. After all it's i8259, > and it's even not the kernel one. > > Then we can remove quite a few of lines to make it cleaner. And "info > irq" will always work for it. > > Signed-off-by: Peter Xu > --- > hw

Re: [Qemu-devel] [PATCH 3/5] i8259: generalize statistics into common code

2017-12-15 Thread Philippe Mathieu-Daudé
On 12/10/2017 03:38 AM, Peter Xu wrote: > It was only for userspace i8259. Move it to general code so that > kvm-i8259 can also use it in the future. > > Signed-off-by: Peter Xu > --- > hw/intc/i8259.c | 37 + > hw/intc/i8259_common.c

Re: [Qemu-devel] [PATCH 4/5] kvm-i8259: support "info pic" and "info irq"

2017-12-15 Thread Philippe Mathieu-Daudé
On 12/10/2017 03:38 AM, Peter Xu wrote: > Let's leverage the i8259 common code for kvm-i8259 too. > > I think it's still possible that stats can lost when i8259 is in kernel > and meanwhile when irqfd is used, e.g., by vfio or vhost devices. > However that should be rare IMHO since they should be

Re: [Qemu-devel] [PATCH 5/5] i8259: move TYPE_INTERRUPT_STATS_PROVIDER upper

2017-12-15 Thread Philippe Mathieu-Daudé
On 12/10/2017 03:38 AM, Peter Xu wrote: > Now both classes (i8259, i8259-kvm) support this. Move this upper to > the common class code. > > Signed-off-by: Peter Xu Reviewed-by: Philippe Mathieu-Daudé > --- > hw/i386/kvm/i8259.c| 7 --- > hw/intc/i8259.c| 7 --- > hw/intc/

Re: [Qemu-devel] [PATCH v1 02/19] include/fpu/softfloat: implement float16_abs helper

2017-12-15 Thread Philippe Mathieu-Daudé
On 12/11/2017 09:56 AM, Alex Bennée wrote: > This will be required when expanding the MINMAX() macro for 16 > bit/half-precision operations. > > Signed-off-by: Alex Bennée > Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > include/fpu/softfloat.h | 7 +++ > 1 fi

Re: [Qemu-devel] [RFC v5 00/26] QMP: out-of-band (OOB) execution support

2017-12-15 Thread Dr. David Alan Gilbert
* Fam Zheng (f...@redhat.com) wrote: > On Tue, 12/05 13:51, Peter Xu wrote: > > This version is mostly document update, and dropped the single patch > > that is migration related (will be put into postcopy recovery > > series). > > Sorry if I'm asking an already answered question, if so please rem

[Qemu-devel] [PATCH] migration: Guard ram_bytes_remaining against early call

2017-12-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Calling ram_bytes_remaining during the early part of setup is unsafe because the ram_state isn't yet initialised. This can happen in the sequence: migrate migrate_cancel info migrate if the migrate sticks trying to connect (e.g. to an unresponsive destina

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-15 Thread Stefan Hajnoczi
On Fri, Dec 15, 2017 at 06:33:45PM +0800, Wei Wang wrote: > On 12/15/2017 02:04 AM, Stefan Hajnoczi wrote: > > On Thu, Dec 14, 2017 at 01:53:16PM +0800, Wei Wang wrote: > > > 3rd one: I'm not able to solve this one, as discussed, there are too many > > > differences and it's too complex. I prefer t

Re: [Qemu-devel] [PATCH] docs/devel/migration.txt: keep functions consistent with the code

2017-12-15 Thread Daniel P. Berrange
On Tue, Dec 05, 2017 at 07:58:16PM +, Dr. David Alan Gilbert wrote: > * Jay Zhou (jianjay.z...@huawei.com) wrote: > > Since the commit 11808bb0c422134bf09119f4aa22c59b0ce84bf3 removed > > the put_buffer callback and using an iovec based write handler instead, > > the docs should be sync with th

Re: [Qemu-devel] [PATCH v1 05/19] include/fpu/softfloat: add some float16 contants

2017-12-15 Thread Alex Bennée
Alex Bennée writes: > This defines the same set of common constants for float 16 as defined > for 32 and 64 bit floats. These are often used by target helper > functions. > > Signed-off-by: Alex Bennée > --- > include/fpu/softfloat.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --gi

Re: [Qemu-devel] [PATCH v4 2/6] vhost: Simplify ring verification checks

2017-12-15 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Wed, 13 Dec 2017 18:08:03 + > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > vhost_verify_ring_mappings() were used to verify that > > rings are still accessible and related memory hasn't > > been moved af

Re: [Qemu-devel] No uhd (3840x2160) guest res?

2017-12-15 Thread Gerd Hoffmann
On Tue, Dec 12, 2017 at 08:20:41PM +, Dr. David Alan Gilbert wrote: > My guests don't seem to offer the standard uhd resolution of 3840x2160 > - what should be providing that? > > I'm running an f27 gnome (X or wayland) guest with: > > ./x86_64-softmmu/qemu-system-x86_64 -device virtio-vga --

Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-15 Thread Stefan Hajnoczi
On Fri, Dec 15, 2017 at 05:10:37PM +0800, Wei Wang wrote: > On 12/15/2017 01:32 AM, Stefan Hajnoczi wrote: > > On Thu, Dec 14, 2017 at 01:53:16PM +0800, Wei Wang wrote: > > > On 12/13/2017 08:35 PM, Stefan Hajnoczi wrote: > > > > On Wed, Dec 13, 2017 at 04:11:45PM +0800, Wei Wang wrote: > > > > >

Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-15 Thread Stefan Hajnoczi
On Fri, Dec 15, 2017 at 06:33:14PM +0800, Wei Wang wrote: > On 12/14/2017 11:06 PM, Stefan Hajnoczi wrote: > > On Wed, Dec 13, 2017 at 10:59:10PM +0200, Michael S. Tsirkin wrote: > > > > * VHOST_USER_SET_VRING_KICK > > > > > > > > Set up vring kick doorbell (unless bit 8 is set) before sendi

Re: [Qemu-devel] [PULL 00/24] ppc-for-2.12 queue 20171215

2017-12-15 Thread Peter Maydell
ble in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.12-20171215 > > for you to fetch changes up to 1481fe5fcfeb7fcf3c1ebb9d8c0432e3e0188ccf: > > spapr: don't initialize PATB entry if ma

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 5/7] vhost-user: VHOST_USER_SET_VHOST_PCI msg

2017-12-15 Thread Stefan Hajnoczi
On Wed, Dec 06, 2017 at 06:32:50PM +0800, Wei Wang wrote: > On 12/06/2017 12:00 AM, Stefan Hajnoczi wrote: > > On Tue, Dec 05, 2017 at 11:33:14AM +0800, Wei Wang wrote: > > > Add a new vhost-uer protocol msg, VHOST_USER_SET_VHOST_PCI. This msg is > > > used to signal the vhost-pci device to start/s

Re: [Qemu-devel] [RFC v5 05/26] qjson: add "opaque" field to JSONMessageParser

2017-12-15 Thread Stefan Hajnoczi
On Fri, Dec 15, 2017 at 03:55:06PM +0800, Peter Xu wrote: > On Wed, Dec 13, 2017 at 03:37:02PM +, Stefan Hajnoczi wrote: > > On Tue, Dec 05, 2017 at 01:51:39PM +0800, Peter Xu wrote: > > > diff --git a/qga/main.c b/qga/main.c > > > index 62a62755bd..3b5ebbc1ee 100644 > > > --- a/qga/main.c > >

Re: [Qemu-devel] [PATCH 1/1] target-ppc: Fix booke206 tlbwe TLB instruction

2017-12-15 Thread David Gibson
On Tue, Nov 14, 2017 at 05:28:48PM +0100, Luc Michel wrote: > On 11/06/2017 07:16 AM, David Gibson wrote: > > On Thu, Nov 02, 2017 at 11:35:59AM +0100, Luc MICHEL wrote: > >> When overwritting a valid TLB entry with a new one, the previous page > >> were not flushed in QEMU TLB, leading to incohere

Re: [Qemu-devel] [RFC v5 07/26] monitor: unify global init

2017-12-15 Thread Stefan Hajnoczi
On Fri, Dec 15, 2017 at 04:11:41PM +0800, Peter Xu wrote: > On Wed, Dec 13, 2017 at 03:48:06PM +, Stefan Hajnoczi wrote: > > On Tue, Dec 05, 2017 at 01:51:41PM +0800, Peter Xu wrote: > > > diff --git a/vl.c b/vl.c > > > index 1ad1c04637..1ec995a6ae 100644 > > > --- a/vl.c > > > +++ b/vl.c > > >

[Qemu-devel] [PATCH v2 13/32] qcow2: Add l2_slice_size field to BDRVQcow2State

2017-12-15 Thread Alberto Garcia
The BDRVQcow2State structure contains an l2_size field, which stores the number of 64-bit entries in an L2 table. For efficiency reasons we want to be able to load slices instead of full L2 tables, so we need to know how many entries an L2 slice can hold. An L2 slice is the portion of an L2 table

[Qemu-devel] [PATCH v2 03/32] qcow2: Remove BDS parameter from qcow2_cache_get_table_addr()

2017-12-15 Thread Alberto Garcia
This function was only using the BlockDriverState parameter to get the cache table size (since it was equal to the cluster size). This is no longer necessary so this parameter can be removed. Signed-off-by: Alberto Garcia --- block/qcow2-cache.c | 13 ++--- 1 file changed, 6 insertions(+

[Qemu-devel] [PATCH v2 27/32] qcow2: Rename l2_table in qcow2_alloc_compressed_cluster_offset()

2017-12-15 Thread Alberto Garcia
This function doesn't need any changes to support L2 slices, but since it's now dealing with slices intead of full tables, the l2_table variable is renamed for clarity. Signed-off-by: Alberto Garcia --- block/qcow2-cluster.c | 16 1 file changed, 8 insertions(+), 8 deletions(-)

[Qemu-devel] [PATCH v2 26/32] qcow2: Update qcow2_truncate() to support L2 slices

2017-12-15 Thread Alberto Garcia
The qcow2_truncate() code is mostly independent from whether we're using L2 slices or full L2 tables, but in full and falloc preallocation modes new L2 tables are allocated using qcow2_alloc_cluster_link_l2(). Therefore the code needs to be modified to ensure that all nb_clusters that are processe

[Qemu-devel] [PATCH v2 14/32] qcow2: Add offset_to_l2_slice_index()

2017-12-15 Thread Alberto Garcia
Similar to offset_to_l2_index(), this function takes a guest offset and returns the index in the L2 slice that contains its L2 entry. An L2 slice has currently the same size as an L2 table (one cluster), so both functions return the same value for now. Signed-off-by: Alberto Garcia --- block/qc

[Qemu-devel] [PATCH v2 22/32] qcow2: Update discard_single_l2() to support L2 slices

2017-12-15 Thread Alberto Garcia
discard_single_l2() limits the number of clusters to be discarded to the amount that fits inside an L2 table. Since we'll be loading L2 slices instead of full tables we need to update that limit. Apart from that, this function doesn't need any additional changes, so this patch simply updates the v

[Qemu-devel] [PATCH v2 01/32] qcow2: Fix documentation of get_cluster_table()

2017-12-15 Thread Alberto Garcia
This function has not been returning the offset of the L2 table since commit 3948d1d4876065160583e79533bf604481063833 Signed-off-by: Alberto Garcia --- block/qcow2-cluster.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index

[Qemu-devel] [PATCH v2 20/32] qcow2: Update handle_copied() to support L2 slices

2017-12-15 Thread Alberto Garcia
handle_copied() loads an L2 table and limits the number of checked clusters to the amount that fits inside that table. Since we'll be loading L2 slices instead of full tables we need to update that limit. Apart from that, this function doesn't need any additional changes, so this patch simply upda

[Qemu-devel] [PATCH v2 23/32] qcow2: Update zero_single_l2() to support L2 slices

2017-12-15 Thread Alberto Garcia
zero_single_l2() limits the number of clusters to be zeroed to the amount that fits inside an L2 table. Since we'll be loading L2 slices instead of full tables we need to update that limit. Apart from that, this function doesn't need any additional changes, so this patch simply updates the variabl

[Qemu-devel] [PATCH v2 04/32] qcow2: Remove BDS parameter from qcow2_cache_get_table_idx()

2017-12-15 Thread Alberto Garcia
This function was only using the BlockDriverState parameter to get the cache table size (since it was equal to the cluster size). This is no longer necessary so this parameter can be removed. Signed-off-by: Alberto Garcia --- block/qcow2-cache.c | 9 - 1 file changed, 4 insertions(+), 5

[Qemu-devel] [PATCH v2 30/32] qcow2: Rename l2_table in count_cow_clusters()

2017-12-15 Thread Alberto Garcia
This function doesn't need any changes to support L2 slices, but since it's now dealing with slices intead of full tables, the l2_table variable is renamed for clarity. Signed-off-by: Alberto Garcia --- block/qcow2-cluster.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[Qemu-devel] [PATCH v2 00/32] Allow configuring the qcow2 L2 cache entry size

2017-12-15 Thread Alberto Garcia
Hello all, this is the new revision of the patch series to allow configuring the entry size of the qcow2 L2 cache. Follow this link for the full description from the first version: https://lists.gnu.org/archive/html/qemu-block/2017-10/msg00458.html Here are some performance numbers with a ful

[Qemu-devel] [PATCH v2 29/32] qcow2: Rename l2_table in count_contiguous_clusters_unallocated()

2017-12-15 Thread Alberto Garcia
This function doesn't need any changes to support L2 slices, but since it's now dealing with slices intead of full tables, the l2_table variable is renamed for clarity. Signed-off-by: Alberto Garcia --- block/qcow2-cluster.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v2 15/32] qcow2: Update l2_load() to support L2 slices

2017-12-15 Thread Alberto Garcia
Each entry in the qcow2 L2 cache stores a full L2 table (which uses a complete cluster in the qcow2 image). A cluster is usually too large to be used efficiently as the size for a cache entry, so we want to decouple both values by allowing smaller cache entries. Therefore the qcow2 L2 cache will no

[Qemu-devel] [PATCH v2 08/32] qcow2: Remove BDS parameter from qcow2_cache_destroy()

2017-12-15 Thread Alberto Garcia
This function was never using the BlockDriverState parameter so it can be safely removed. Signed-off-by: Alberto Garcia --- block/qcow2-cache.c | 2 +- block/qcow2.c | 16 block/qcow2.h | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/block/

[Qemu-devel] [PATCH v2 07/32] qcow2: Remove BDS parameter from qcow2_cache_put()

2017-12-15 Thread Alberto Garcia
This function was only using the BlockDriverState parameter to pass it to qcow2_cache_get_table_idx(). This is no longer necessary so this parameter can be removed. Signed-off-by: Alberto Garcia --- block/qcow2-cache.c| 2 +- block/qcow2-cluster.c | 28 ++-- block/q

[Qemu-devel] [PATCH v2 28/32] qcow2: Rename l2_table in count_contiguous_clusters()

2017-12-15 Thread Alberto Garcia
This function doesn't need any changes to support L2 slices, but since it's now dealing with slices intead of full tables, the l2_table variable is renamed for clarity. Signed-off-by: Alberto Garcia --- block/qcow2-cluster.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --g

[Qemu-devel] [PATCH v2 17/32] qcow2: Update get_cluster_table() to support L2 slices

2017-12-15 Thread Alberto Garcia
This patch updates get_cluster_table() to return L2 slices instead of full L2 tables. The code itself needs almost no changes, it only needs to call offset_to_l2_slice_index() instead of offset_to_l2_index(). This patch also renames all the relevant variables and the documentation. Signed-off-by:

[Qemu-devel] [PATCH v2 11/32] qcow2: Remove BDS parameter from qcow2_cache_is_table_offset()

2017-12-15 Thread Alberto Garcia
This function was only using the BlockDriverState parameter to pass it to qcow2_cache_get_table_addr(). This is no longer necessary so this parameter can be removed. Signed-off-by: Alberto Garcia --- block/qcow2-cache.c| 3 +-- block/qcow2-refcount.c | 6 +++--- block/qcow2.h | 3 +-

[Qemu-devel] [PATCH v2 09/32] qcow2: Remove BDS parameter from qcow2_cache_clean_unused()

2017-12-15 Thread Alberto Garcia
This function was only using the BlockDriverState parameter to pass it to qcow2_cache_table_release(). This is no longer necessary so this parameter can be removed. Signed-off-by: Alberto Garcia --- block/qcow2-cache.c | 2 +- block/qcow2.c | 4 ++-- block/qcow2.h | 2 +- 3 files cha

  1   2   3   4   >