Re: [Qemu-devel] [PATCH v1 for-2.12 0/5] s390x/tcg: CCW hotplug support

2017-12-04 Thread Cornelia Huck
On Mon, 4 Dec 2017 13:55:00 +0100 David Hildenbrand wrote: > Hotplugging a ccw device currently fails due to different reasons. > > 1. The stored machine check information is partially wrong. > 2. The TOD programmable field cannot be restored. > 3. STCRW cannot get executed. > > With these pat

Re: [Qemu-devel] [PATCH] mmap(2) returns MAP_FAILED, not NULL, on failure

2017-12-04 Thread John Snow
On 12/01/2017 01:31 PM, Michael McConville wrote: > Signed-off-by: Michael McConville > --- > hw/i386/xen/xen-mapcache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c > index baab93b614..efa35dc6e0 100644 > ---

[Qemu-devel] [PULL 1/1] blockjob: Make block_job_pause_all() keep a reference to the jobs

2017-12-04 Thread Kevin Wolf
From: Alberto Garcia Starting from commit 40840e419be31e6a32e6ea24511c74b389d5e0e4 we are pausing all block jobs during bdrv_reopen_multiple() to prevent any of them from finishing and removing nodes from the graph while they are being reopened. It turns out that pausing a block job doesn't nece

[Qemu-devel] [PULL 0/1] Block layer patch for 2.11.0-rc4

2017-12-04 Thread Kevin Wolf
The following changes since commit 495566ec38817e6625294e6909cffb4de040c8e7: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.11-20171204' into staging (2017-12-04 11:27:53 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstrea

Re: [Qemu-devel] [PATCH v1 for-2.12 1/5] s390x/kvm: factor out build_channel_report_mcic() into cpu.h

2017-12-04 Thread Cornelia Huck
On Mon, 4 Dec 2017 13:55:01 +0100 David Hildenbrand wrote: > We'll need it later on in two places. Refactor it to just indicate the > valid bit. While at it, introduce a define for the used CR14 bit (we'll s/valid bit/validity bits/ > also need later on). > > Signed-off-by: David Hildenbrand

Re: [Qemu-devel] [PATCH v1 for-2.12 0/5] s390x/tcg: CCW hotplug support

2017-12-04 Thread David Hildenbrand
On 04.12.2017 17:56, Cornelia Huck wrote: > On Mon, 4 Dec 2017 13:55:00 +0100 > David Hildenbrand wrote: > >> Hotplugging a ccw device currently fails due to different reasons. >> >> 1. The stored machine check information is partially wrong. >> 2. The TOD programmable field cannot be restored.

Re: [Qemu-devel] [PATCH v4 31/32] migration, qmp: new command "migrate-pause"

2017-12-04 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Dec 01, 2017 at 04:53:28PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > It is used to manually trigger the postcopy pause state. It works just > > > like when we found the migration stream failed during postcop

[Qemu-devel] deadlock in rcu_init_lock() in usermode emulation

2017-12-04 Thread Peter Maydell
Hi; in https://bugs.linaro.org/show_bug.cgi?id=3259 comment 27 Stuart provides backtraces of a deadlock in user-mode in the RCU code. Specifically, thread 3 (the thread which is running the guest code which makes the clone syscall to do the fork) is blocked waiting for the rcu_sync_lock in rcu_ini

Re: [Qemu-devel] [PATCH v1 for-2.12 1/5] s390x/kvm: factor out build_channel_report_mcic() into cpu.h

2017-12-04 Thread David Hildenbrand
On 04.12.2017 18:03, Cornelia Huck wrote: > On Mon, 4 Dec 2017 13:55:01 +0100 > David Hildenbrand wrote: > >> We'll need it later on in two places. Refactor it to just indicate the >> valid bit. While at it, introduce a define for the used CR14 bit (we'll > > s/valid bit/validity bits/ In the

Re: [Qemu-devel] [PULL 0/7] pc, pci, virtio: fixes for rc3

2017-12-04 Thread Peter Maydell
On 4 December 2017 at 10:16, Peter Maydell wrote: > On 3 December 2017 at 04:56, Michael S. Tsirkin wrote: >> On Fri, Dec 01, 2017 at 06:05:25PM +, Peter Maydell wrote: >>> Are any of these so important that we would absolutely refuse >>> to release without the fixes (ie they justify rolling

Re: [Qemu-devel] [PATCH v1 for-2.12 2/5] s390x/tcg: fix and cleanup mcck injection

2017-12-04 Thread Cornelia Huck
On Mon, 4 Dec 2017 13:55:02 +0100 David Hildenbrand wrote: > The architecture mode indication wasn't stored. The split of certain > 64bit fields was unnecessary. Also, the complete clock comparator, not > just bit 0-55 (starting at byte 1) was stored. > > We now generate a proper MCIC via the s

Re: [Qemu-devel] [PATCH v1 for-2.12 5/5] s390x/tcg: wire up STORE CHANNEL REPORT WORD

2017-12-04 Thread Cornelia Huck
On Mon, 4 Dec 2017 13:55:05 +0100 David Hildenbrand wrote: > We somehow missed that, new kernels require it. Why _new_ kernels? I think we have unconditionally issued stcrw since back in 2.2? > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.h | 1 + > target/s390x/insn-

Re: [Qemu-devel] [PATCH v1 for-2.12 4/9] s390x/tcg: wire up SET CHANNEL MONITOR

2017-12-04 Thread Cornelia Huck
On Mon, 4 Dec 2017 15:01:45 +0100 David Hildenbrand wrote: > Let's just wire it up like KVM. > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.h | 1 + > target/s390x/insn-data.def | 1 + > target/s390x/misc_helper.c | 9 + > target/s390x/translate.c | 7 +++

Re: [Qemu-devel] [PATCH v1 for-2.12 2/5] s390x/tcg: fix and cleanup mcck injection

2017-12-04 Thread David Hildenbrand
On 04.12.2017 18:20, Cornelia Huck wrote: > On Mon, 4 Dec 2017 13:55:02 +0100 > David Hildenbrand wrote: > >> The architecture mode indication wasn't stored. The split of certain >> 64bit fields was unnecessary. Also, the complete clock comparator, not >> just bit 0-55 (starting at byte 1) was s

Re: [Qemu-devel] [PATCH v1 for-2.12 4/9] s390x/tcg: wire up SET CHANNEL MONITOR

2017-12-04 Thread David Hildenbrand
On 04.12.2017 18:24, Cornelia Huck wrote: > On Mon, 4 Dec 2017 15:01:45 +0100 > David Hildenbrand wrote: > >> Let's just wire it up like KVM. >> >> Signed-off-by: David Hildenbrand >> --- >> target/s390x/helper.h | 1 + >> target/s390x/insn-data.def | 1 + >> target/s390x/misc_helper.c |

Re: [Qemu-devel] [PATCH v1 for-2.12 6/9] s390x/tcg: Implement SIGA instruction

2017-12-04 Thread Cornelia Huck
On Mon, 4 Dec 2017 15:01:47 +0100 David Hildenbrand wrote: > I have no idea what that instruction does, but KVM seems to suppress it, > setting cc=3 (and as it seems to be an io instruction, it should be > protected). Let's do the same for TCG, so we're at least equal. > > (it is used in the ke

Re: [Qemu-devel] [PATCH v1 for-2.12 4/9] s390x/tcg: wire up SET CHANNEL MONITOR

2017-12-04 Thread Cornelia Huck
On Mon, 4 Dec 2017 18:27:55 +0100 David Hildenbrand wrote: > On 04.12.2017 18:24, Cornelia Huck wrote: > > On Mon, 4 Dec 2017 15:01:45 +0100 > > David Hildenbrand wrote: > > > >> Let's just wire it up like KVM. > >> > >> Signed-off-by: David Hildenbrand > >> --- > >> target/s390x/helper.h

Re: [Qemu-devel] [qemu-s390x] [PATCH RFC 2/2] s390x: attach autogenerated nics

2017-12-04 Thread Halil Pasic
On 12/04/2017 05:40 PM, Cornelia Huck wrote: > On Mon, 4 Dec 2017 12:17:06 +0100 > Christian Borntraeger wrote: > >> On 11/28/2017 02:46 PM, Cornelia Huck wrote: >>> The autogenerated nics should be treated as any other device; use >>> qdev_set_id() to have them show up under peripheral-anon. >

Re: [Qemu-devel] [PATCH v1 for-2.12 5/5] s390x/tcg: wire up STORE CHANNEL REPORT WORD

2017-12-04 Thread David Hildenbrand
On 04.12.2017 18:22, Cornelia Huck wrote: > On Mon, 4 Dec 2017 13:55:05 +0100 > David Hildenbrand wrote: > >> We somehow missed that, new kernels require it. > > Why _new_ kernels? I think we have unconditionally issued stcrw since > back in 2.2? Okay, the problem is then rather related to my

Re: [Qemu-devel] [PATCH v1 for-2.12 4/9] s390x/tcg: wire up SET CHANNEL MONITOR

2017-12-04 Thread David Hildenbrand
On 04.12.2017 18:32, Cornelia Huck wrote: > On Mon, 4 Dec 2017 18:27:55 +0100 > David Hildenbrand wrote: > >> On 04.12.2017 18:24, Cornelia Huck wrote: >>> On Mon, 4 Dec 2017 15:01:45 +0100 >>> David Hildenbrand wrote: >>> Let's just wire it up like KVM. Signed-off-by: David H

Re: [Qemu-devel] [PATCH] 9pfs: Correctly handle cancelled requests

2017-12-04 Thread Greg Kurz
On Sat, 2 Dec 2017 16:14:25 -0500 Keno Fischer wrote: > Hi Keno, > # Background > > I was investigating spurious, non-deterministic EINTR returns from > various 9p file system operations in a Linux guest served from the > qemu 9p server. > > ## EINTR, ERESTARTSYS and the linux kernel > > W

Re: [Qemu-devel] [qemu-s390x] [PATCH RFC 2/2] s390x: attach autogenerated nics

2017-12-04 Thread Cornelia Huck
On Mon, 4 Dec 2017 18:33:24 +0100 Halil Pasic wrote: > On 12/04/2017 05:40 PM, Cornelia Huck wrote: > > On Mon, 4 Dec 2017 12:17:06 +0100 > > Christian Borntraeger wrote: > > > >> On 11/28/2017 02:46 PM, Cornelia Huck wrote: > >>> The autogenerated nics should be treated as any other device

Re: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter

2017-12-04 Thread Eric Farman
On 12/01/2017 10:16 AM, Paolo Bonzini wrote: On 01/12/2017 16:15, Eric Farman wrote: Commit 5c0919d02066 ("virtio-scsi: Add virtqueue_size parameter allowing virtqueue size to be set.") introduced a new parameter to virtio-scsi. Later, commit 920036106044 ("vhost-user-scsi: add missing virtque

Re: [Qemu-devel] [PATCH v1 for-2.12 5/5] s390x/tcg: wire up STORE CHANNEL REPORT WORD

2017-12-04 Thread Cornelia Huck
On Mon, 4 Dec 2017 18:34:36 +0100 David Hildenbrand wrote: > On 04.12.2017 18:22, Cornelia Huck wrote: > > On Mon, 4 Dec 2017 13:55:05 +0100 > > David Hildenbrand wrote: > > > >> We somehow missed that, new kernels require it. > > > > Why _new_ kernels? I think we have unconditionally iss

Re: [Qemu-devel] [PATCH v1 for-2.12 5/5] s390x/tcg: wire up STORE CHANNEL REPORT WORD

2017-12-04 Thread David Hildenbrand
On 04.12.2017 18:53, Cornelia Huck wrote: > On Mon, 4 Dec 2017 18:34:36 +0100 > David Hildenbrand wrote: > >> On 04.12.2017 18:22, Cornelia Huck wrote: >>> On Mon, 4 Dec 2017 13:55:05 +0100 >>> David Hildenbrand wrote: >>> We somehow missed that, new kernels require it. >>> >>> Why _n

Re: [Qemu-devel] [PATCH v1 for-2.12 5/5] s390x/tcg: wire up STORE CHANNEL REPORT WORD

2017-12-04 Thread Cornelia Huck
On Mon, 4 Dec 2017 18:56:00 +0100 David Hildenbrand wrote: > On 04.12.2017 18:53, Cornelia Huck wrote: > > On Mon, 4 Dec 2017 18:34:36 +0100 > > David Hildenbrand wrote: > > > >> On 04.12.2017 18:22, Cornelia Huck wrote: > >>> On Mon, 4 Dec 2017 13:55:05 +0100 > >>> David Hildenbrand wrot

Re: [Qemu-devel] [PULL 0/1] Block layer patch for 2.11.0-rc4

2017-12-04 Thread Peter Maydell
On 4 December 2017 at 17:01, Kevin Wolf wrote: > The following changes since commit 495566ec38817e6625294e6909cffb4de040c8e7: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.11-20171204' > into staging (2017-12-04 11:27:53 +) > > are availa

Re: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter

2017-12-04 Thread Peter Maydell
On 4 December 2017 at 17:52, Eric Farman wrote: > On 12/01/2017 10:16 AM, Paolo Bonzini wrote: >> >> On 01/12/2017 16:15, Eric Farman wrote: >>> diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c >>> index cd4ab05233..9c1bea8ff3 100644 >>> --- a/hw/scsi/vhost-scsi.c >>> +++ b/hw/scsi/vhost-s

Re: [Qemu-devel] [PATCH v4 1/1] tests/qemu-iotests: adding savevm/loadvm with postcopy flag test

2017-12-04 Thread Max Reitz
On 2017-12-04 16:17, Daniel Henrique Barboza wrote: > This patch implements a test case for the scenario that was failing > prior to the patch "migration/ram.c: do not set 'postcopy_running' in > POSTCOPY_INCOMING_END", commit acab30b85d. > > This new test file 201 was derived from the test file 1

Re: [Qemu-devel] [PATCH v7 for-2.12 21/25] block: Purify .bdrv_refresh_filename()

2017-12-04 Thread Max Reitz
On 2017-12-04 17:37, Alberto Garcia wrote: > On Mon 20 Nov 2017 09:10:00 PM CET, Max Reitz wrote: >> -static void blkdebug_refresh_filename(BlockDriverState *bs, QDict *options) >> +static void blkdebug_refresh_filename(BlockDriverState *bs) >> { >> BDRVBlkdebugState *s = bs->opaque; >> -

Re: [Qemu-devel] [PATCH v7 for-2.12 24/25] block/curl: Implement bdrv_refresh_filename()

2017-12-04 Thread Max Reitz
On 2017-12-04 17:51, Alberto Garcia wrote: > On Mon 20 Nov 2017 09:10:03 PM CET, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >> block/curl.c | 18 ++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/block/curl.c b/block/curl.c >> index 11318a9a29..fe57223fda 100644 >

Re: [Qemu-devel] [PATCH v1 for-2.12 5/5] s390x/tcg: wire up STORE CHANNEL REPORT WORD

2017-12-04 Thread David Hildenbrand
On 04.12.2017 18:58, Cornelia Huck wrote: > On Mon, 4 Dec 2017 18:56:00 +0100 > David Hildenbrand wrote: > >> On 04.12.2017 18:53, Cornelia Huck wrote: >>> On Mon, 4 Dec 2017 18:34:36 +0100 >>> David Hildenbrand wrote: >>> On 04.12.2017 18:22, Cornelia Huck wrote: > On Mon, 4 Dec

[Qemu-devel] Debugging io deadlock

2017-12-04 Thread BALATON Zoltan
Hello, I'm seeing a possible deadlock that I don't know how to debug. Any hint on how to find the cause or what should be checked further to identify the reason why this is happening and how to fix it is greatly appreciated. Here are the state of threads: (gdb) info thr Id Target Id

Re: [Qemu-devel] [PATCH v2] pci: removed the is_express field since a uniform interface was inserted

2017-12-04 Thread Philippe Mathieu-Daudé
Hi Yoni, Eduardo, Markus, On 12/04/2017 07:18 AM, Yoni Bettan wrote: > * according to Eduardo Habkost's commit > fd3b02c8896d597dd8b9e053dec579cf0386aee1 > > * since all PCIEs now implement INTERFACE_PCIE_DEVICE we > don't need this field anymore > > *

Re: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter

2017-12-04 Thread Eric Farman
On 12/04/2017 01:05 PM, Peter Maydell wrote: On 4 December 2017 at 17:52, Eric Farman wrote: On 12/01/2017 10:16 AM, Paolo Bonzini wrote: On 01/12/2017 16:15, Eric Farman wrote: diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c index cd4ab05233..9c1bea8ff3 100644 --- a/hw/scsi/vhost

[Qemu-devel] qemu-devel archive search was missing some messages but it's fixed now

2017-12-04 Thread Ian Kelling
Hi. I work at FSF and help maintain the mailing lists software. I don't know exactly how many were missing because there was an error we were ignoring. At least some from November. I fixed it by reindexing from scratch. I didn't figure out the the root cause, likely something to do with incrementa

Re: [Qemu-devel] qemu-devel archive search was missing some messages but it's fixed now

2017-12-04 Thread Laszlo Ersek
Hello Ian, On 12/04/17 21:02, Ian Kelling wrote: > General thoughts about the archive: I'm looking forward to us upgrading > to mailman 3 at some point which will bring an improved archive > interface. Do you mean HyperKitty? Will you seek out community feedback on it first? > Of course, you c

[Qemu-devel] [PATCH v2] 9pfs: Correctly handle cancelled requests

2017-12-04 Thread Keno Fischer
# Background I was investigating spurious non-deterministic EINTR returns from various 9p file system operations in a Linux guest served from the qemu 9p server. ## EINTR, ERESTARTSYS and the linux kernel When a signal arrives that the Linux kernel needs to deliver to user-space while a given

Re: [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check

2017-12-04 Thread Shravan Rajinikanth
> To me both versions seem fine, could you explain the grammatical error in the > old message? My opinion aligns with Peter's, in that "This means" followed by "waste of" is a break in the sentence to a reader. Adding an "a" to change it to "This means a waste of" also seemed like a possible fix,

Re: [Qemu-devel] qemu-devel archive search was missing some messages but it's fixed now

2017-12-04 Thread Ian Kelling
Laszlo Ersek writes: > Hello Ian, > > On 12/04/17 21:02, Ian Kelling wrote: > >> General thoughts about the archive: I'm looking forward to us upgrading >> to mailman 3 at some point which will bring an improved archive >> interface. > > Do you mean HyperKitty? Yes. > > Will you seek out commun

Re: [Qemu-devel] [PATCH] Remove MemoryRegionSection check code from sparc_cpu_get_phys_page_debug()

2017-12-04 Thread Mark Cave-Ayland
On 27/11/17 20:19, Jean-Christophe DUBOIS wrote: Hello Mark, Did you get any second opinion on this? Also do you need me to resend the patch with the SPARC keyword in the patch subject line? Hi Jean-Christophe, Apologies for the delay as I've been fairly busy with my day job. I believe Ar

Re: [Qemu-devel] qemu-devel archive search was missing some messages but it's fixed now

2017-12-04 Thread Ian Kelling
Related, I've updated https://lists.nongnu.org/archive/cgi-bin/namazu.cgi?idxname=qemu-devel with new text to explain what is configured to not be in the search index: Long messages and words are ignored Messages longer than 100,000 letters or 500,000 bytes are ignored. Words longer than 40 chara

[Qemu-devel] [Bug 1497204] Re: qemu-system-s390x: no SMP support without KVM

2017-12-04 Thread Thomas Huth
QEMU v2.11 has now experimental SMP support (see https://wiki.qemu.org/ChangeLog/2.11#s390 ... commit has been made here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=11b0079cec6b1f46ba76c ). ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because

Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev-backup: enable non-root nodes for backup

2017-12-04 Thread John Snow
On 12/01/2017 02:41 PM, Max Reitz wrote: > ((By the way, I don't suppose that's how it should work... But I don't > suppose that we want propagation of dirtying towards the BDS roots, do > we? :-/)) I have never really satisfactorily explained to myself what bitmaps on intermediate notes truly

Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev-backup: enable non-root nodes for backup

2017-12-04 Thread Max Reitz
On 2017-12-04 23:15, John Snow wrote: > > > On 12/01/2017 02:41 PM, Max Reitz wrote: >> ((By the way, I don't suppose that's how it should work... But I don't >> suppose that we want propagation of dirtying towards the BDS roots, do >> we? :-/)) > > I have never really satisfactorily explained

Re: [Qemu-devel] [PATCH v4 1/1] tests/qemu-iotests: adding savevm/loadvm with postcopy flag test

2017-12-04 Thread Max Reitz
On 2017-12-04 16:17, Daniel Henrique Barboza wrote: > This patch implements a test case for the scenario that was failing > prior to the patch "migration/ram.c: do not set 'postcopy_running' in > POSTCOPY_INCOMING_END", commit acab30b85d. > > This new test file 201 was derived from the test file 1

[Qemu-devel] [PATCH v3] target/ppc: Fix system lockups caused by interrupt_request state corruption

2017-12-04 Thread Richard Purdie
Occasionally in Linux guests on x86_64 we're seeing logs like: ppc_set_irq: 0x55b4e0d562f0 n_IRQ 8 level 1 => pending 0100req 0004 when they should read: ppc_set_irq: 0x55b4e0d562f0 n_IRQ 8 level 1 => pending 0100req 0002 The "0004" is CPU_INTERRUPT_EXITTB yet the code calls

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] target/ppc: Fix system lockups caused by interrupt_request state corruption

2017-12-04 Thread Richard Purdie
On Mon, 2017-12-04 at 12:44 +1100, David Gibson wrote: > On Mon, Dec 04, 2017 at 12:00:40PM +1100, David Gibson wrote: > > > > On Fri, Dec 01, 2017 at 03:49:07PM +, Richard Purdie wrote: > > > > > > Occasionally in Linux guests on x86_64 we're seeing logs like: > > > > > > ppc_set_irq: 0x55b

Re: [Qemu-devel] [Qemu-block] [PATCH v5 00/15] qcow2: space preallocation and COW improvements

2017-12-04 Thread John Snow
Friendly ping; this has gone over 30 days without a reply on the list. I recommend rebasing and trying again after 2.11 hits. Thanks, --John On 11/01/2017 11:43 AM, Anton Nefedov wrote: > v5: rebased, patches slightly reordered; > cluster allocation (to avoid writing zero-buffers) > now g

Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev-backup: enable non-root nodes for backup

2017-12-04 Thread John Snow
On 12/04/2017 05:21 PM, Max Reitz wrote: > On 2017-12-04 23:15, John Snow wrote: >> >> >> On 12/01/2017 02:41 PM, Max Reitz wrote: >>> ((By the way, I don't suppose that's how it should work... But I don't >>> suppose that we want propagation of dirtying towards the BDS roots, do >>> we? :-/)) >

Re: [Qemu-devel] [PULL 0/7] pc, pci, virtio: fixes for rc3

2017-12-04 Thread Michael S. Tsirkin
On Mon, Dec 04, 2017 at 10:16:08AM +, Peter Maydell wrote: > On 3 December 2017 at 04:56, Michael S. Tsirkin wrote: > > On Fri, Dec 01, 2017 at 06:05:25PM +, Peter Maydell wrote: > >> On 1 December 2017 at 17:08, Michael S. Tsirkin wrote: > >> > Chao Gao (1): > >> > i386/msi: Correc

Re: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter

2017-12-04 Thread Michael S. Tsirkin
On Mon, Dec 04, 2017 at 03:00:45PM -0500, Eric Farman wrote: > > > On 12/04/2017 01:05 PM, Peter Maydell wrote: > > On 4 December 2017 at 17:52, Eric Farman wrote: > > > On 12/01/2017 10:16 AM, Paolo Bonzini wrote: > > > > > > > > On 01/12/2017 16:15, Eric Farman wrote: > > > > > diff --git a/h

Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: fix 197 for vpc

2017-12-04 Thread John Snow
On 12/01/2017 04:45 AM, Stefan Hajnoczi wrote: > On Wed, Nov 29, 2017 at 05:44:21PM -0500, John Snow wrote: >> VPC has some difficulty creating geometries of particular size. >> However, we can indeed force it to use a literal one, so let's >> do that for the sake of test 197, which is testing so

[Qemu-devel] [PATCH v2] iotests: fix 197 for vpc

2017-12-04 Thread John Snow
VPC has some difficulty creating geometries of particular size. However, we can indeed force it to use a literal one, so let's do that for the sake of test 197, which is testing some specific offsets. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- tests/qemu-

Re: [Qemu-devel] [PATCH for-2.12] hw/ide: Remove duplicated definitions from ahci_internal.h

2017-12-04 Thread John Snow
On 11/30/2017 02:12 PM, Thomas Huth wrote: > The same definitions can also be found in include/hw/ide/ahci.h > so let's remove these #defines from ahci_internal.h. > > Signed-off-by: Thomas Huth > --- > hw/ide/ahci_internal.h | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/hw/i

Re: [Qemu-devel] [PULL 0/3] ppc-for-2.11 queue 20171204

2017-12-04 Thread David Gibson
2: > >> > >> Update version for v2.11.0-rc3 release (2017-11-29 17:59:34 +) > >> > >> are available in the Git repository at: > >> > >> git://github.com/dgibson/qemu.git tags/ppc-for-2.11-20171204 > >> > >> for you to fetch

Re: [Qemu-devel] [PATCH 21/25] spapr: introduce a helper to map the XIVE memory regions

2017-12-04 Thread David Gibson
On Mon, Dec 04, 2017 at 04:30:36PM +0100, Cédric Le Goater wrote: > On 12/04/2017 08:52 AM, David Gibson wrote: > > On Thu, Nov 23, 2017 at 02:29:51PM +0100, Cédric Le Goater wrote: > >> When the XIVE interrupt mode is activated, the machine needs to expose > >> to the guest the MMIO regions use by

Re: [Qemu-devel] [PATCH v4 31/32] migration, qmp: new command "migrate-pause"

2017-12-04 Thread Peter Xu
On Mon, Dec 04, 2017 at 05:10:29PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Fri, Dec 01, 2017 at 04:53:28PM +, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > It is used to manually trigger the postcopy pause state. I

Re: [Qemu-devel] [PATCH] docs/devel/migration.txt: keep functions consistent with the code

2017-12-04 Thread Jay Zhou
Hi, Does this document update make sense? Regards, Jay On 2017/11/23 16:47, Jay Zhou wrote: Since the commit 11808bb0c422134bf09119f4aa22c59b0ce84bf3 removed the put_buffer callback and using an iovec based write handler instead, the docs should be sync with the code too. Signed-off-by: Jay

[Qemu-devel] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-04 Thread Wei Wang
Vhost-pci is a point-to-point based inter-VM communication solution. This patch series implements the vhost-pci-net device setup and emulation. The device is implemented as a virtio device, and it is set up via the vhost-user protocol to get the neessary info (e.g the memory info of the remote VM,

[Qemu-devel] [PATCH v3 1/7] vhost-user: share the vhost-user protocol related structures

2017-12-04 Thread Wei Wang
Put the vhost-user protocol related data structures to vhost-user.h, so that they can be used in other implementations (e.g. a slave implementation). Signed-off-by: Wei Wang --- hw/virtio/vhost-user.c | 100 +- include/hw/virtio/vhost-user.h | 106

[Qemu-devel] [PATCH v3 4/7] vhost-pci-slave: add vhost-pci slave implementation

2017-12-04 Thread Wei Wang
The vhost-pci slave implementation is added to support the creation of the vhost-pci-net device. It follows the vhost-user protocol to get the master VM's info (e.g. memory regions, vring address). Signed-off-by: Wei Wang --- hw/net/vhost_pci_net.c | 20 ++- hw/virtio/Makefile.objs

[Qemu-devel] [PATCH v3 3/7] virtio/virtio-pci.c: add vhost-pci-net-pci

2017-12-04 Thread Wei Wang
Add the virtio-pci emulation part of the vhost-pci device. BAR2 is used to expose the remote VM's memory to the guest, and its default size is set to 64GB. Signed-off-by: Wei Wang --- hw/virtio/virtio-pci.c | 55 ++ hw/virtio/virtio-pci.h

[Qemu-devel] [PATCH v3 5/7] vhost-user: VHOST_USER_SET_VHOST_PCI msg

2017-12-04 Thread Wei Wang
Add a new vhost-uer protocol msg, VHOST_USER_SET_VHOST_PCI. This msg is used to signal the vhost-pci device to start/stop working. Signed-off-by: Wei Wang --- hw/net/vhost_net.c| 37 + hw/virtio/vhost-pci-slave.c | 2 +- hw/virtio/vhost-

[Qemu-devel] [PATCH v3 6/7] vhost-pci-slave: handle VHOST_USER_SET_VHOST_PCI

2017-12-04 Thread Wei Wang
This patch implements the slave part handling of the VHOST_USER_SET_VHOST_PCI msg. Receiving a "true" from the master will set the LINK_UP status of the vhost-pci device config status, and a config interrupt will be injected to the guest to notify that the device is ready to use. The driver is exp

[Qemu-devel] [PATCH v3 2/7] vhost-pci-net: add vhost-pci-net

2017-12-04 Thread Wei Wang
Add the vhost-pci-net device emulation. The device uses bar 2 to expose the remote VM's memory to the guest. The first 4KB of the the bar area stores the metadata which describes the remote memory and vring info. Signed-off-by: Wei Wang --- hw/net/Makefile.objs | 2 +-

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/2] nvic: Make nvic_sysreg_ns_ops work with any MemoryRegion

2017-12-04 Thread Philippe Mathieu-Daudé
On 12/01/2017 03:51 PM, Peter Maydell wrote: > Generalize nvic_sysreg_ns_ops so that we can pass it an > arbitrary MemoryRegion which it will use as the underlying > register implementation to apply the NS-alias behaviour > to. We'll want this so we can do the same with systick. > > Signed-off-by:

[Qemu-devel] [PATCH v3 7/7] virtio/vhost.c: vhost-pci needs remote gpa

2017-12-04 Thread Wei Wang
The vhost-pci driver uses the remote guest physical address to send/receive packets from the remote guest, so when sending the ving info to the vhost-pci device, send the guest physical adress directly. Signed-off-by: Wei Wang --- hw/virtio/vhost.c | 56 +++---

Re: [Qemu-devel] [PATCH 20/25] spapr: add device tree support for the XIVE interrupt mode

2017-12-04 Thread David Gibson
On Mon, Dec 04, 2017 at 05:19:03PM +0100, Cédric Le Goater wrote: > On 12/04/2017 08:49 AM, David Gibson wrote: > > On Thu, Nov 23, 2017 at 02:29:50PM +0100, Cédric Le Goater wrote: > >> The XIVE interface for the guest is described in the device tree under > >> the "interrupt-controller" node. A c

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/2] nvic: Make systick banked

2017-12-04 Thread Philippe Mathieu-Daudé
Hi Peter, On 12/01/2017 03:51 PM, Peter Maydell wrote: > For the v8M security extension, there should be two systick > devices, which use separate banked systick exceptions. The > register interface is banked in the same way as for other > banked registers, including the existence of an NS alias >

Re: [Qemu-devel] [Qemu-arm] [PATCH] arm/translate-a64: mark path as unreachable to eliminate warning

2017-12-04 Thread Philippe Mathieu-Daudé
Hi Peter, On 11/13/2017 08:26 AM, Peter Maydell wrote: > On 8 November 2017 at 12:37, Philippe Mathieu-Daudé wrote: >> On 11/07/2017 05:46 PM, Emilio G. Cota wrote: >>> Fixes the following warning when compiling with gcc 5.4.0 with -O1 >>> optimizations and --enable-debug: >>> >>> target/arm/tran

[Qemu-devel] [PATCH v2] linux-user: Use *at functions instead of caching interp_prefix contents

2017-12-04 Thread Richard Henderson
From: Richard Henderson If the interp_prefix is a complete chroot, it may have a *lot* of files. Setting up the cache for this is quite expensive. Instead, use the *at versions of various syscalls to attempt the operation in the prefix. Signed-off-by: Richard Henderson --- Changes since v1 (N

Re: [Qemu-devel] [for-2.12 0/7] PCI cleanups

2017-12-04 Thread Michael S. Tsirkin
On Wed, Nov 29, 2017 at 05:18:47PM +0800, Fam Zheng wrote: > On Wed, 11/29 01:02, no-re...@patchew.org wrote: > > /tmp/cc3Czn0R.s: Fatal error: can't write 3947 bytes to section .debug_str > > of hw/arm/virt-acpi-build.o because: 'No space left on device' > > Hmm, the host is shared and what I ha

Re: [Qemu-devel] [PATCH v2] linux-user: Use *at functions instead of caching interp_prefix contents

2017-12-04 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2] linux-user: Use *at functions instead of caching interp_prefix contents Type: series Message-id: 20171205044844.3597-1-richard.hender...@linaro.org === TEST SCRIPT B

Re: [Qemu-devel] [for-2.12 0/7] PCI cleanups

2017-12-04 Thread Fam Zheng
On Tue, 12/05 06:49, Michael S. Tsirkin wrote: > On Wed, Nov 29, 2017 at 05:18:47PM +0800, Fam Zheng wrote: > > On Wed, 11/29 01:02, no-re...@patchew.org wrote: > > > /tmp/cc3Czn0R.s: Fatal error: can't write 3947 bytes to section > > > .debug_str of hw/arm/virt-acpi-build.o because: 'No space lef

Re: [Qemu-devel] [for-2.12 0/7] PCI cleanups

2017-12-04 Thread David Gibson
On Tue, Dec 05, 2017 at 01:05:58PM +0800, Fam Zheng wrote: > On Tue, 12/05 06:49, Michael S. Tsirkin wrote: > > On Wed, Nov 29, 2017 at 05:18:47PM +0800, Fam Zheng wrote: > > > On Wed, 11/29 01:02, no-re...@patchew.org wrote: > > > > /tmp/cc3Czn0R.s: Fatal error: can't write 3947 bytes to section

[Qemu-devel] [PULL 1/1] target/ppc: Fix system lockups caused by interrupt_request state corruption

2017-12-04 Thread David Gibson
From: Richard Purdie Occasionally in Linux guests on x86_64 we're seeing logs like: ppc_set_irq: 0x55b4e0d562f0 n_IRQ 8 level 1 => pending 0100req 0004 when they should read: ppc_set_irq: 0x55b4e0d562f0 n_IRQ 8 level 1 => pending 0100req 0002 The "0004" is CPU_INTERRUPT_EX

[Qemu-devel] [PULL 0/1] ppc-for-2.11 queue 20171205

2017-12-04 Thread David Gibson
The following changes since commit 2a4c7e839101a52f7bf9ba4dd64e466518565352: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2017-12-04 17:19:04 +) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.11-20171205 for you

Re: [Qemu-devel] [PATCH 1/3] s390x/css: unrestrict cssids

2017-12-04 Thread Dong Jia Shi
* Halil Pasic [2017-12-01 15:31:34 +0100]: [...] No comment for the message part. The code looks good to me. So after squashing with patch #2: Reviewed-by: Dong Jia Shi > --- > hw/s390x/3270-ccw.c| 2 +- > hw/s390x/css.c | 28 > hw/s390x/s390

Re: [Qemu-devel] [PATCH 2/3] s390x/css: advertise unrestricted cssids

2017-12-04 Thread Dong Jia Shi
* Halil Pasic [2017-12-04 16:07:27 +0100]: > > > On 12/04/2017 12:15 PM, Cornelia Huck wrote: > > On Fri, 1 Dec 2017 15:31:35 +0100 > > Halil Pasic wrote: > > > >> Let us advertise the changes introduced by "s390x/css: unrestrict cssids" > >> to the management software (so it can tell are cs

[Qemu-devel] [RFC v5 01/26] qobject: introduce qstring_get_try_str()

2017-12-04 Thread Peter Xu
The only difference from qstring_get_str() is that it allows the qstring to be NULL. If so, NULL is returned. CC: Eric Blake CC: Markus Armbruster Reviewed-by: Fam Zheng Signed-off-by: Peter Xu --- include/qapi/qmp/qstring.h | 1 + qobject/qstring.c | 10 ++ 2 files changed

[Qemu-devel] [RFC v5 02/26] qobject: introduce qobject_get_try_str()

2017-12-04 Thread Peter Xu
A quick way to fetch string from qobject when it's a QString. Reviewed-by: Fam Zheng Signed-off-by: Peter Xu --- include/qapi/qmp/qstring.h | 1 + qobject/qstring.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/include/qapi/qmp/qstring.h b/include/qapi/qmp/qstring.

[Qemu-devel] [RFC v5 03/26] qobject: let object_property_get_str() use new API

2017-12-04 Thread Peter Xu
We can simplify object_property_get_str() using the new qobject_get_try_str(). Reviewed-by: Fam Zheng Signed-off-by: Peter Xu --- qom/object.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/qom/object.c b/qom/object.c index c58c52d518..9cbeb51f0b 100644 --- a/qom/o

[Qemu-devel] [RFC v5 00/26] QMP: out-of-band (OOB) execution support

2017-12-04 Thread Peter Xu
This version is mostly document update, and dropped the single patch that is migration related (will be put into postcopy recovery series). v5 - rename "monitor_iothread" to "mon_iothread" [Dave] - add comment in monitor_cleanup(), note that when the hacks can be removed. [Dan] - add a note sect

[Qemu-devel] [RFC v5 05/26] qjson: add "opaque" field to JSONMessageParser

2017-12-04 Thread Peter Xu
It'll be passed to emit() as well when it happens. Since at it, add a typedef for the emitter function. Reviewed-by: Fam Zheng Signed-off-by: Peter Xu --- include/qapi/qmp/json-streamer.h | 10 -- monitor.c| 7 --- qga/main.c | 5 +++-

[Qemu-devel] [RFC v5 06/26] monitor: move the cur_mon hack deeper for QMP

2017-12-04 Thread Peter Xu
In monitor_qmp_read(), we have the hack to temporarily replace the cur_mon pointer. Now we move this hack deeper inside the QMP dispatcher routine since the Monitor pointer can be passed in to that using the new JSON Parser opaque field now. This does not make much sense as a single patch. Howev

[Qemu-devel] [RFC v5 08/26] monitor: let mon_list be tail queue

2017-12-04 Thread Peter Xu
It was QLIST. I want to use this list to do monitor priority job later, which need tail insertion ability. So switching to a tail queue. Reviewed-by: Fam Zheng Signed-off-by: Peter Xu --- monitor.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/monitor.c b/moni

[Qemu-devel] [RFC v5 04/26] monitor: move skip_flush into monitor_data_init

2017-12-04 Thread Peter Xu
It's part of the data init. Collect it. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Fam Zheng Signed-off-by: Peter Xu --- monitor.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index e36fb5308d..3940737c1c 100644 --- a/monitor.c +++ b/

[Qemu-devel] [RFC v5 07/26] monitor: unify global init

2017-12-04 Thread Peter Xu
There are many places for monitor init its globals, at least: - monitor_init_qmp_commands() at the very beginning - single function to init monitor_lock - in the first entry of monitor_init() using "is_first_init" Unify them a bit. Reviewed-by: Fam Zheng Signed-off-by: Peter Xu --- include/mo

[Qemu-devel] [RFC v5 11/26] qmp: introduce QMPCapability

2017-12-04 Thread Peter Xu
There was no QMP capabilities defined. Define the first "oob" as capability to allow out-of-band messages. Also, touch up qmp-test.c to test the new bits. Signed-off-by: Peter Xu --- monitor.c| 15 +-- qapi-schema.json | 13 + tests/qmp-test.c | 10 +- 3

[Qemu-devel] [RFC v5 15/26] monitor: let suspend_cnt be thread safe

2017-12-04 Thread Peter Xu
Monitor code now can be run in more than one thread. Let it be thread safe when accessing suspend_cnt counter. Signed-off-by: Peter Xu --- monitor.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index 35d8925636..6ac1b2065d 100644 --- a/

[Qemu-devel] [RFC v5 09/26] monitor: create monitor dedicate iothread

2017-12-04 Thread Peter Xu
Create one IOThread for the monitors, prepared to handle all the input/output IOs using existing iothread framework. Signed-off-by: Peter Xu --- monitor.c | 32 1 file changed, 32 insertions(+) diff --git a/monitor.c b/monitor.c index a70ab5606b..6b60f6d91b 1006

[Qemu-devel] [RFC v5 12/26] qmp: negociate QMP capabilities

2017-12-04 Thread Peter Xu
After this patch, we will allow QMP clients to enable QMP capabilities when sending the first "qmp_capabilities" command. Originally we are starting QMP session with no arguments like: { "execute": "qmp_capabilities" } Now we can enable some QMP capabilities using (take OOB as example, which i

[Qemu-devel] [RFC v5 16/26] monitor: separate QMP parser and dispatcher

2017-12-04 Thread Peter Xu
Originally QMP goes throw these steps: JSON Parser --> QMP Dispatcher --> Respond /|\(2)(3) | (1) | \|/ (4) +- main thread + This patch does this: JSON Parser QMP Dispatcher --> Respond /|\ |

[Qemu-devel] [RFC v5 10/26] monitor: allow to use IO thread for parsing

2017-12-04 Thread Peter Xu
For each Monitor, add one field "use_io_thr" to show whether it will be using the dedicated monitor IO thread to handle input/output. When set, monitor IO parsing work will be offloaded to dedicated monitor IO thread, rather than the original main loop thread. This only works for QMP. HMP will a

[Qemu-devel] [RFC v5 13/26] qmp: introduce some capability helpers

2017-12-04 Thread Peter Xu
Introduce qmp_cap_enabled() and qmp_oob_enabled() helpers. Signed-off-by: Peter Xu --- monitor.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/monitor.c b/monitor.c index 097312e65f..9666115259 100644 --- a/monitor.c +++ b/monitor.c @@ -1038,6 +1038,16 @@ static void monitor_in

[Qemu-devel] [RFC v5 18/26] monitor: send event when request queue full

2017-12-04 Thread Peter Xu
Set maximum QMP request queue length to 8. If queue full, instead of queue the command, we directly return a "request-dropped" event, telling client that specific command is dropped. Note that this flow control mechanism is only valid if OOB is enabled. If it's not, the effective queue length wil

[Qemu-devel] [RFC v5 22/26] monitor: enable IO thread for (qmp & !mux) typed

2017-12-04 Thread Peter Xu
Start to use dedicate IO thread for QMP monitors that are not using MUXed chardev. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index 298703d90f..e864b17ed9 100644 --- a/moni

[Qemu-devel] [RFC v5 14/26] monitor: introduce monitor_qmp_respond()

2017-12-04 Thread Peter Xu
A tiny refactoring, preparing to split the QMP dispatcher away. Reviewed-by: Fam Zheng Signed-off-by: Peter Xu --- monitor.c | 48 +++- 1 file changed, 31 insertions(+), 17 deletions(-) diff --git a/monitor.c b/monitor.c index 9666115259..35d8925636

[Qemu-devel] [RFC v5 17/26] qmp: add new event "request-dropped"

2017-12-04 Thread Peter Xu
This event will be emitted if one QMP request is dropped. Along, declare an enum for the reasons. Signed-off-by: Peter Xu --- qapi-schema.json | 34 ++ 1 file changed, 34 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index 531fd4c0db..9d2625b6b3

<    1   2   3   >