Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v2] linux-user: Use *at functions instead of
caching interp_prefix contents
Type: series
Message-id: 20171205044844.3597-1-richard.hender...@linaro.org
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update]
patchew/1510087611-1851-1-git-send-email-c...@braap.org ->
patchew/1510087611-1851-1-git-send-email-c...@braap.org
t [tag update]
patchew/1512154296-5652-1-git-send-email-peter.mayd...@linaro.org ->
patchew/1512154296-5652-1-git-send-email-peter.mayd...@linaro.org
* [new tag]
patchew/20171205044844.3597-1-richard.hender...@linaro.org ->
patchew/20171205044844.3597-1-richard.hender...@linaro.org
Switched to a new branch 'test'
88b8681d57 linux-user: Use *at functions instead of caching interp_prefix
contents
=== OUTPUT BEGIN ===
Checking PATCH 1/1: linux-user: Use *at functions instead of caching
interp_prefix contents...
ERROR: do not use assignment in if condition
#135: FILE: linux-user/syscall.c:8287:
+ if (!(fn = lock_user_string(arg2)))
ERROR: braces {} are necessary for all arms of this statement
#135: FILE: linux-user/syscall.c:8287:
+ if (!(fn = lock_user_string(arg2)))
[...]
ERROR: do not use assignment in if condition
#160: FILE: linux-user/syscall.c:8315:
+ if (!(fn = lock_user_string(arg1))) {
ERROR: do not use assignment in if condition
#183: FILE: linux-user/syscall.c:8335:
+ if (!(fn = lock_user_string(arg2))) {
ERROR: do not use assignment in if condition
#315: FILE: linux-user/syscall.c:9738:
+ if (!(fn = lock_user_string(arg1))) {
ERROR: do not use assignment in if condition
#338: FILE: linux-user/syscall.c:9758:
+ if (!(fn = lock_user_string(arg1))) {
ERROR: do not use assignment in if condition
#364: FILE: linux-user/syscall.c:10853:
+ if (!(fn = lock_user_string(arg1))) {
ERROR: do not use assignment in if condition
#389: FILE: linux-user/syscall.c:10875:
+ if (!(fn = lock_user_string(arg1))) {
ERROR: do not use assignment in if condition
#415: FILE: linux-user/syscall.c:10909:
+ if (!(fn = lock_user_string(arg2)))
ERROR: braces {} are necessary for all arms of this statement
#415: FILE: linux-user/syscall.c:10909:
+ if (!(fn = lock_user_string(arg2)))
[...]
ERROR: do not use assignment in if condition
#439: FILE: linux-user/syscall.c:11920:
+ if (!(fn = lock_user_string(arg2))) {
total: 11 errors, 0 warnings, 419 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
