ARRAY_SIZE() has been defined in include/linux/kernel.h, and "make"
complains a warning of redefinition of ARRAY_SIZE() in
testing/radix/linux/kernel.h. So, remove ARRAY_SIZE() from there.
Signed-off-by: Wei Wang
Cc: Matthew Wilcox
Cc: Andrew Morton
---
tools/testing/radix-tree/linux/kernel.h
This patch adds support to walk through the free page blocks in the
system and report them via a callback function. Some page blocks may
leave the free list after zone->lock is released, so it is the caller's
responsibility to either detect or prevent the use of such pages.
One use example of this
The was removed from radix-tree.h by the following commit:
f5bba9d11a256ad2a1c2f8e7fc6aabe6416b7890.
Since that commit, tools/testing/radix-tree/ couldn't pass compilation
due to: tools/testing/radix-tree/idr.c:17: undefined reference to
WARN_ON_ONCE. This patch adds the bug.h header to idr.h to
Current virtqueue_add API implementation is based on the scatterlist
struct, which uses kaddr. This is inadequate to all the use case of
vring. For example:
- Some usages don't use IOMMU, in this case the user can directly pass
in a physical address in hand, instead of going through the sg
impl
From: Matthew Wilcox
The eXtensible Bitmap is a sparse bitmap representation which is
efficient for set bits which tend to cluster. It supports up to
'unsigned long' worth of bits, and this commit adds the bare bones --
xb_set_bit(), xb_clear_bit() and xb_test_bit().
Signed-off-by: Wei Wang
--
Add a new feature, VIRTIO_BALLOON_F_SG, which enables the transfer of
balloon (i.e. inflated/deflated) pages using scatter-gather lists to the
host. A scatter-gather list is described by a vring desc.
The implementation of the previous virtio-balloon is not very efficient,
because the balloon page
This patch made some changes to the original xbitmap implementation from
the linux-dax tree:
- remove xb_fill() and xb_zero() from xbitmap.h since they are not
implemented;
- xb_test_bit: changed "ebit > BITS_PER_LONG" to "ebit >= BITS_PER_LONG",
because bit 64 beyonds the "unsigned long" exc
Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_VQ feature indicates the
support of reporting hints of guest free pages to host via virtio-balloon.
Host requests the guest to report free pages by sending a new cmd
id to the guest via the free_page_report_cmd_id configuration register.
When the gues
The guest free pages should not be discarded by the live migration thread
when page poisoning is enabled with PAGE_POISONING_NO_SANITY=n, because
skipping the transfer of such poisoned free pages will trigger false
positive when new pages are allocated and checked on the destination.
This patch ski
On 11/07/2017 01:00 AM, Matthew Wilcox wrote:
On Fri, Nov 03, 2017 at 04:13:02PM +0800, Wei Wang wrote:
From: Matthew Wilcox
Add the following tests for xbitmap:
1) single bit test: single bit set/clear/find;
2) bit range test: set/clear a range of bits and find a 0 or 1 bit in
the range.
Sig
Le 29/11/2017 à 15:08, Thomas Huth a écrit :
> On 29.11.2017 14:59, Peter Maydell wrote:
>> On 29 November 2017 at 13:42, Laurent Vivier wrote:
>>> these functions come from:
>>>
>>> http://previous.alternative-system.com/
>>>
>>> http://svn.code.sf.net/p/previous/code/trunk/src/softfloat/softfloa
Am 29.11.2017 um 14:56 hat Jeff Cody geschrieben:
> On Wed, Nov 29, 2017 at 11:25:13AM +0100, Paolo Bonzini wrote:
> > This reverts the effects of commit 4afeffc857 ("blockjob: do not allow
> > coroutine double entry or entry-after-completion", 2017-11-21)
> >
> > This fixed the symptom of a bug r
On Wed, Nov 29, 2017 at 03:21:37PM +0100, Kevin Wolf wrote:
> Am 29.11.2017 um 14:56 hat Jeff Cody geschrieben:
> > On Wed, Nov 29, 2017 at 11:25:13AM +0100, Paolo Bonzini wrote:
> > > This reverts the effects of commit 4afeffc857 ("blockjob: do not allow
> > > coroutine double entry or entry-after
On 28 November 2017 at 15:41, Eric Auger wrote:
> At the moment the ITS is not properly reset. On System reset or
> reboot, previous ITS register values and caches are left
> unchanged. Some of the registers might point to some guest RAM
> tables which are not valid anymore. This leads to state
>
On 29/11/2017 15:12, David Gibson wrote:
On Wed, Nov 29, 2017 at 12:45:28PM +0200, Marcel Apfelbaum wrote:
On 29/11/2017 10:46, David Gibson wrote:
pci_bus_is_root() currently relies on a method in the PCIBusClass.
But it's always known if a PCI bus is a root bus when we create it, so
using a d
On 29/11/2017 13:41, Eduardo Habkost wrote:
On Wed, Nov 29, 2017 at 12:54:04PM +0200, Marcel Apfelbaum wrote:
On 29/11/2017 10:46, David Gibson wrote:
The bus pointer in PCIDevice is basically redundant with QOM information.
It's always initialized to the qdev_get_parent_bus(), the only differe
On Wed, 29 Nov 2017 15:06:33 +0100
David Hildenbrand wrote:
> On 29.11.2017 14:51, Thomas Huth wrote:
> > On 28.11.2017 21:33, David Hildenbrand wrote:
> >> I have quite some patches on my queue for 2.12. (booting Fedora 26/27
> >> guests, floating interrupts, machine checks, missing instructio
While we look at the fixes for 2.11, I briefly prototyped this series to see if
it makes sense as a simplification of the drain API for 2.12.
The idea is to let AioContext manage quiesce callbacks, then the block layer
only needs to do the in-flight request waiting. This lets us get rid of the
cal
Signed-off-by: Fam Zheng
---
include/block/aio.h | 27 +---
util/async.c| 73 +
2 files changed, 97 insertions(+), 3 deletions(-)
diff --git a/include/block/aio.h b/include/block/aio.h
index e9aeeaec94..40c2f64544 100644
Signed-off-by: Fam Zheng
---
block/io.c| 18 --
include/block/block_int.h | 1 -
2 files changed, 19 deletions(-)
diff --git a/block/io.c b/block/io.c
index 4fdf93a014..7f07972489 100644
--- a/block/io.c
+++ b/block/io.c
@@ -134,24 +134,6 @@ void bdrv_disable_cop
Signed-off-by: Fam Zheng
---
block/throttle.c | 34 +++---
1 file changed, 27 insertions(+), 7 deletions(-)
diff --git a/block/throttle.c b/block/throttle.c
index 833175ac77..35b740e3de 100644
--- a/block/throttle.c
+++ b/block/throttle.c
@@ -70,6 +70,25 @@ fin:
Signed-off-by: Fam Zheng
---
blockjob.c | 47 ++-
1 file changed, 30 insertions(+), 17 deletions(-)
diff --git a/blockjob.c b/blockjob.c
index ff9a614531..86d060c89c 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -148,6 +148,23 @@ static void block_job_at
Signed-off-by: Fam Zheng
---
blockjob.c | 24
include/block/blockjob_int.h | 14 --
2 files changed, 38 deletions(-)
diff --git a/blockjob.c b/blockjob.c
index 809111bf24..bfeb7c4ace 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -699,18 +699,6
Signed-off-by: Fam Zheng
---
block.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/block.c b/block.c
index 9a1a0d1e73..949f0dec11 100644
--- a/block.c
+++ b/block.c
@@ -4745,8 +4745,7 @@ void bdrv_set_aio_context(BlockDriverState *bs,
AioContext *new_context)
{
Instead of the recursion of the "disable/enable external requests"
operations on the graph, we switch to AioContext's API to disable/enable
on the whole AioContext altogether. Strictly it is be a bit more than
necessary, but as all drained sections are short, it is not a big
problem.
Drained end c
Signed-off-by: Fam Zheng
---
block/qed.c | 34 +-
1 file changed, 25 insertions(+), 9 deletions(-)
diff --git a/block/qed.c b/block/qed.c
index 821dcaa055..8ddaa31e7c 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -337,12 +337,33 @@ static void qed_cancel_need_chec
On Tue, 28 Nov 2017 21:33:11 +0100
David Hildenbrand wrote:
> Allows to easily convert more callers of program_interrupt() and to
> easily introduce new exceptions without forgetting about the cpu state
> reset.
>
> Use program_interrupt_ra() in places where we already had the same
> pattern.
>
Signed-off-by: Fam Zheng
---
block.c| 24
block/block-backend.c | 22 --
blockjob.c | 6 --
include/block/block.h | 16
include/block/block_int.h | 11 ---
Right now, only the server can choose whether an export is read-only. A
client can always treat an export as read-only by not sending any
writes, but a server has no guarantee that a client will behave that
way, and must assume that an export where the server did not advertise
NBD_FLAG_READ_ON
Acked-by: Gabriel Somlo
On Tue, Nov 28, 2017 at 10:40:27PM +0100, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/
On 29.11.2017 15:55, Cornelia Huck wrote:
> On Tue, 28 Nov 2017 21:33:11 +0100
> David Hildenbrand wrote:
>
>> Allows to easily convert more callers of program_interrupt() and to
>> easily introduce new exceptions without forgetting about the cpu state
>> reset.
>>
>> Use program_interrupt_ra() i
On Tue, 28 Nov 2017 21:33:14 +0100
David Hildenbrand wrote:
> TCG needs the retaddr when injecting an interrupt. Let's just pass it
> along and use 0 for KVM. The value will be completely ignored for KVM.
Can we get a #define for that? Just to make it clear at a glance that
we're passing an igno
On 29.11.2017 16:13, Cornelia Huck wrote:
> On Tue, 28 Nov 2017 21:33:14 +0100
> David Hildenbrand wrote:
>
>> TCG needs the retaddr when injecting an interrupt. Let's just pass it
>> along and use 0 for KVM. The value will be completely ignored for KVM.
>
> Can we get a #define for that? Just t
On 11/29/2017 03:16 AM, Paolo Bonzini wrote:
On 29/11/2017 05:00, Fam Zheng wrote:
Chances are qemu-devel@nongnu.org patches only adding new files can be
picked up by patchew and treated like a qemu.git patch. Patchew already
ignores [qemu-web] patches, so suggest it in this article as well. (Ar
On 29.11.2017 15:17, Laurent Vivier wrote:
> Le 29/11/2017 à 15:08, Thomas Huth a écrit :
>> On 29.11.2017 14:59, Peter Maydell wrote:
>>> On 29 November 2017 at 13:42, Laurent Vivier wrote:
these functions come from:
http://previous.alternative-system.com/
http://svn.code
On 11/29/2017 01:51 PM, Peter Maydell wrote:
On 29 November 2017 at 12:47, KONRAD Frederic
wrote:
Maybe a little hack might work for x86 on x86 though.
Something like hardcoding the helper with an inline assembly
code?
The set of people who want to emulate x86 on x86 is surely
even smaller
On 29.11.2017 13:33, Mohammed Gamal wrote:
> Instead of having the same error checks in vtd_realize()
> and amdvi_realize(), move that over to the generic
> x86_iommu_realize().
>
> Reviewed-by: Peter Xu
> Reviewed-by: Eduardo Habkost
> Signed-off-by: Mohammed Gamal
> ---
> hw/i386/amd_iommu.c
Now that we have a website that accepts patches on the list, the
main project should make it easier to find information about that
process.
Signed-off-by: Eric Blake
---
Doc only, so it could go in -rc3 if we have a reason to slip it
in this late; but I'm also fine if it waits for 2.12.
README
From: John Snow
Both of these tests are for formats which now stipulate that they are
read-only. Adjust the tests to match.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Lukáš Doktor
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/075 | 18 +-
tests/qemu-iot
On Wed, 22 Nov 2017 16:15:52 +1100
Alexey Kardashevskiy wrote:
> The vfio_iommu_spapr_tce driver always advertises v1 and v2 IOMMU support,
> however PR KVM (a special version of KVM designed to work in
> a paravirtualized system; these days used for nested virtualizaion) only
> supports the "pse
From: Fam Zheng
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
qemu-options.hx | 4
1 file changed, 4 insertions(+)
diff --git a/qemu-options.hx b/qemu-options.hx
index 3728e9b4dd..f11c4ac960 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -693,6 +693,10 @@ This is the prot
From: Fam Zheng
This documents the image locking feature and explains when and how
related options can be used.
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
docs/qemu-block-drivers.texi | 36
qemu-doc.texi| 1 +
2 files changed,
The following changes since commit e7b47c22e2df14d55e3e4426688c929bf8e3f7fb:
osdep.h: Make TIME_MAX handle different time_t types (2017-11-24 13:23:36
+)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to fetch changes up to 5591c001a10
From: Kashyap Chamarthy
When you cancel an in-progress 'mirror' job (or "active `block-commit`")
with QMP `block-job-cancel`, it emits the event: BLOCK_JOB_CANCELLED.
However, when `block-job-cancel` is issued *after* `drive-mirror` has
indicated (via the event BLOCK_JOB_READY) that the source an
From: Peter Lieven
DIV_ROUND_UP(st.st_size, BDRV_SECTOR_SIZE) was overflowing ret (int) if
st.st_size is greater than 1TB.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Peter Lieven
Message-id: 1511798407-31129-1-git-send-email...@kamp.de
Signed-off-by: Max Reitz
---
block/nfs.c | 7 +++
1 fi
Web (and other doc) updates are also valid contributions.
Suggested-by: Paolo Bonzini
Signed-off-by: Eric Blake
---
contribute.md | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/contribute.md b/contribute.md
index bf4a55d..88baee6 100644
--- a/contribute.md
+++ b/contribu
From: Paolo Bonzini
Hide the clearing of job->busy in a single function, and set it
in block_job_enter. This lets block_job_do_yield verify that
qemu_coroutine_enter is not used while job->busy = false.
Signed-off-by: Paolo Bonzini
Tested-By: Jeff Cody
Reviewed-by: Fam Zheng
Reviewed-by: Jef
On 29.11.2017 13:33, Mohammed Gamal wrote:
> Starting qemu with
> qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu
> leads to a segfault. The code assume PCI bus is present and
> tries to access the bus structure without checking.
>
> Since Intel VT-d and AMDVI should only work with PCI, a
From: Alberto Garcia
When destroying a block job in block_job_unref() we should remove it
from the job list before calling block_job_remove_all_bdrv().
This is because removing the BDSs can trigger an aio_poll() and wake
up other jobs that might attempt to use the block job list. If that
happens
On Wed, 22 Nov 2017 16:16:49 +1100
Alexey Kardashevskiy wrote:
> On some platforms INTx may not be enabled on a KVM host (one such
> example is IBM pHyp hypervisor and this is intentional). However
> the PCI_INTERRUPT_PIN is not 0 so QEMU tries initializing INTx, fails as
> (!vdev->pdev->irq) in
From: Paolo Bonzini
This reverts the effects of commit 4afeffc857 ("blockjob: do not allow
coroutine double entry or entry-after-completion", 2017-11-21)
This fixed the symptom of a bug rather than the root cause. Canceling the
wait on a sleeping blockjob coroutine is generally fine, we just nee
The .drained_begin/end callbacks can (directly or indirectly via
aio_poll()) cause block nodes to be removed or the current BdrvChild to
point to a different child node.
Use QLIST_FOREACH_SAFE() to make sure we don't access invalid
BlockDriverStates or accidentally continue iterating the parents o
On 29.11.2017 16:20, KONRAD Frederic wrote:
>
>
> On 11/29/2017 01:51 PM, Peter Maydell wrote:
>> On 29 November 2017 at 12:47, KONRAD Frederic
>> wrote:
>>> Maybe a little hack might work for x86 on x86 though.
>>> Something like hardcoding the helper with an inline assembly
>>> code?
>>
>> The
From: Paolo Bonzini
All callers are using QEMU_CLOCK_REALTIME, and it will not be possible to
support more than one clock when block_job_sleep_ns switches to a single
timer stored in the BlockJob struct.
Signed-off-by: Paolo Bonzini
Reviewed-by: Alberto Garcia
Tested-By: Jeff Cody
Reviewed-by
On Wed, Nov 29, 2017 at 08:42:17PM +0800, Peter Xu wrote:
> On Wed, Nov 29, 2017 at 01:33:11PM +0100, Mohammed Gamal wrote:
> > [Resending for the second time]
> >
> > Starting qemu with
> > qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu
> > leads to a segfault. The code assume PCI bus i
On Wed, 29 Nov 2017 16:38:03 +0100
David Hildenbrand wrote:
> On 29.11.2017 16:35, Cornelia Huck wrote:
> > On Wed, 29 Nov 2017 16:14:40 +0100
> > David Hildenbrand wrote:
> >
> >> On 29.11.2017 16:13, Cornelia Huck wrote:
> >>> On Tue, 28 Nov 2017 21:33:14 +0100
> >>> David Hildenbrand wr
On Wed, 29 Nov 2017 16:14:40 +0100
David Hildenbrand wrote:
> On 29.11.2017 16:13, Cornelia Huck wrote:
> > On Tue, 28 Nov 2017 21:33:14 +0100
> > David Hildenbrand wrote:
> >
> >> TCG needs the retaddr when injecting an interrupt. Let's just pass it
> >> along and use 0 for KVM. The value wi
On 29.11.2017 16:35, Cornelia Huck wrote:
> On Wed, 29 Nov 2017 16:14:40 +0100
> David Hildenbrand wrote:
>
>> On 29.11.2017 16:13, Cornelia Huck wrote:
>>> On Tue, 28 Nov 2017 21:33:14 +0100
>>> David Hildenbrand wrote:
>>>
TCG needs the retaddr when injecting an interrupt. Let's just p
On Wed, 22 Nov 2017 18:39:47 +1100
Alexey Kardashevskiy wrote:
Missing reference to commit that made these fields unused. A Fixes tag
to that commit also seems appropriate. An empty commit log is pretty
much never justified. This also looks like 2.12 material. Thanks,
Alex
> Signed-off-by:
On Wed, 22 Nov 2017 15:58:02 +0800
"Liu, Yi L" wrote:
> The init of giommu_list and hostwin_list is missed during container
> initialization.
>
> Signed-off-by: Liu, Yi L
> ---
> hw/vfio/common.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
>
On 29.11.2017 16:39, Cornelia Huck wrote:
> On Wed, 29 Nov 2017 16:38:03 +0100
> David Hildenbrand wrote:
>
>> On 29.11.2017 16:35, Cornelia Huck wrote:
>>> On Wed, 29 Nov 2017 16:14:40 +0100
>>> David Hildenbrand wrote:
>>>
On 29.11.2017 16:13, Cornelia Huck wrote:
> On Tue, 28 No
On Tue, 28 Nov 2017 21:33:17 +0100
David Hildenbrand wrote:
> s390_cpu_virt_mem_rw() must always return, so callers can react on
> an exception (e.g. see ioinst_handle_stcrw()). For TCG, there was one
> case where a cpu loop exit was triggered. Fix that up.
>
> However, for TCG we always have to
On Wed, 29 Nov 2017 14:46:56 +0100
Cédric Le Goater wrote:
> On 11/29/2017 12:49 PM, Greg Kurz wrote:
>
> > Cédric Le Goater wrote:
> >
> >> The XIVE interrupt controller uses a set of tables to redirect exception
> >> from event sources to CPU threads. The Interrupt Virtualization Entry (IV
On Tue, 28 Nov 2017 21:33:23 +0100
David Hildenbrand wrote:
> STSI needs some more love, but let's do one step at a time.
Out of curiousity: What else do you want to do?
> We can now drop potential_page_fault().
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/misc_helper.c | 2 +-
>
On Tue, 28 Nov 2017 21:33:24 +0100
David Hildenbrand wrote:
> All users are gone, we can finally drop it and make sure that all new
> new program interrupt injections are reminded of the retaddr - as they
s/new new/new/
> have to use program_interrupt_ra() now.
>
> Signed-off-by: David Hildenb
> This looks a bit odd if you don't realize that kvm already handled the
> exception. But I don't really have a better idea.
>
>> }
>> return;
>> }
>
>> @@ -645,9 +657,12 @@ void ioinst_handle_chsc(S390CPU *cpu, uint32_t ipb,
>> uintptr_t ra)
>> if (!s390_cpu_virt_mem
On 29.11.2017 16:53, Cornelia Huck wrote:
> On Tue, 28 Nov 2017 21:33:23 +0100
> David Hildenbrand wrote:
>
>> STSI needs some more love, but let's do one step at a time.
>
> Out of curiousity: What else do you want to do?
>
Will post the patch as soon as this series has been picked up.
Here
On Wed, 29 Nov 2017 16:45:21 +0100
David Hildenbrand wrote:
> On 29.11.2017 16:39, Cornelia Huck wrote:
> > On Wed, 29 Nov 2017 16:38:03 +0100
> > David Hildenbrand wrote:
> >
> >> On 29.11.2017 16:35, Cornelia Huck wrote:
> >>> On Wed, 29 Nov 2017 16:14:40 +0100
> >>> David Hildenbrand wr
On Wed, 29 Nov 2017 16:54:30 +0100
David Hildenbrand wrote:
> >> diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
> >> index 31e3f3f415..39da9aeef4 100644
> >> --- a/target/s390x/mmu_helper.c
> >> +++ b/target/s390x/mmu_helper.c
> >> @@ -22,6 +22,7 @@
> >> #include "internal.h
200 currently fails on tmpfs because it sets cache=none. However,
without that (and aio=native), the test still works now and it fails
before Jeff's series (on fc7dbc119e0852a70dc9fa68bb41a318e49e4cd6). So
we can probably remove it safely.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/200 |
On Wed, Nov 29, 2017 at 04:59:42PM +0100, Max Reitz wrote:
> 200 currently fails on tmpfs because it sets cache=none. However,
> without that (and aio=native), the test still works now and it fails
> before Jeff's series (on fc7dbc119e0852a70dc9fa68bb41a318e49e4cd6). So
> we can probably remove i
On 29.11.2017 16:57, Cornelia Huck wrote:
> On Wed, 29 Nov 2017 16:45:21 +0100
> David Hildenbrand wrote:
>
>> On 29.11.2017 16:39, Cornelia Huck wrote:
>>> On Wed, 29 Nov 2017 16:38:03 +0100
>>> David Hildenbrand wrote:
>>>
On 29.11.2017 16:35, Cornelia Huck wrote:
> On Wed, 29 No
On 29/11/2017 16:31, Eric Blake wrote:
> Web (and other doc) updates are also valid contributions.
>
> Suggested-by: Paolo Bonzini
> Signed-off-by: Eric Blake
> ---
> contribute.md | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/contribute.md b/contribute.md
> index
On 11/27/2017 10:46 PM, linzhecheng wrote:
If we create a thread with QEMU_THREAD_DETACHED mode, QEMU may get a segfault
in a low probability.
The root cause of this problem is a bug of glibc(version 2.17,the latest
version has the same bug),
let's see what happened in glibc's code.
Have
On 11/22/2017 08:08 PM, Max Reitz wrote:
Signed-off-by: Max Reitz
---
block/vmdk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
No semantic difference as far as I can tell, but avoiding needless use
of the comma operator is always a win in my book.
Reviewed-by: Eric Blake
di
On 29 November 2017 at 15:31, Eric Blake wrote:
> Web (and other doc) updates are also valid contributions.
>
> Suggested-by: Paolo Bonzini
> Signed-off-by: Eric Blake
> ---
> contribute.md | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/contribute.md b/contribute.md
On 11/29/2017 02:56 PM, Cédric Le Goater wrote:
> +switch (offset) {
> +case 0:
> +spapr_xive_source_eoi(xive, lisn);
Hrm. I don't love that you're dealing with clearing that LSI bit
here, but setting it at a different level.
The state machines
On 11/22/2017 08:08 PM, Max Reitz wrote:
Persistent dirty bitmaps require a properly functioning
autoclear_features field, or we cannot track when an unsupporting
program might overwrite them. Therefore, we cannot support them for
compat=0.10 images.
Signed-off-by: Max Reitz
---
block/qcow2-
On processors which don't support MSR_EP bit, loadvm command set exception
prefix to an incorrect value and so guest OS freezes.
In cpu_post_load() there is:
/* Invalidate all msr bits except MSR_TGPR/MSR_HVB before restoring */
msr = env->msr;
env->msr ^= ~((1ULL << MSR_T
The msr invalidation code (commits 993eb and 2360b) inverts all
bits except MSR_TGPR and MSR_HVB. On non PowerPC 601 processors
this leads to incorrect change of excp_prefix in hreg_store_msr()
function. The problem is that new msr value get multiplied by msr_mask
and inverted msr does not, thus va
On 29.11.2017 16:59, Cornelia Huck wrote:
> On Wed, 29 Nov 2017 16:54:30 +0100
> David Hildenbrand wrote:
>
>
diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
index 31e3f3f415..39da9aeef4 100644
--- a/target/s390x/mmu_helper.c
+++ b/target/s390x/mmu_helper.c
On 11/29/2017 01:37 PM, Cornelia Huck wrote:
> On Tue, 28 Nov 2017 14:07:58 +0100
> Halil Pasic wrote:
>
>> The default css 0xfe is currently restricted to virtual subchannel
>> devices. The hope when the decision was made was, that non-virtual
>> subchannel devices will come around when guest
> -Original Message-
> From: Eric Blake [mailto:ebl...@redhat.com]
> Sent: Thursday, November 30, 2017 12:19 AM
> To: linzhecheng; qemu-devel@nongnu.org
> Cc: aligu...@us.ibm.com; f...@redhat.com; wangxin (U); Gonglei (Arei);
> pbonz...@redhat.com
> Subject: Re: [Qemu-devel] [PATCH v4] th
On 11/29/2017 12:47 PM, Cornelia Huck wrote:
> On Wed, 29 Nov 2017 16:17:35 +0800
> Dong Jia Shi wrote:
>
>> * Halil Pasic [2017-11-28 14:07:58 +0100]:
>>
>> [...]
>>> The auto-generated bus ids are affected by both changes. We hope to not
>>> encounter any auto-generated bus ids in production
On 29/11/2017 17:22, Peter Maydell wrote:
> On 29 November 2017 at 15:31, Eric Blake wrote:
>> Web (and other doc) updates are also valid contributions.
>>
>> Suggested-by: Paolo Bonzini
>> Signed-off-by: Eric Blake
>> ---
>> contribute.md | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletio
On 29/11/2017 17:28, Gonglei (Arei) wrote:
>>> The root cause of this problem is a bug of glibc(version 2.17,the latest
>>> version
>> has the same bug),
>>> let's see what happened in glibc's code.
>> Have you reported this bug to the glibc folks, and if so, can we include
>> a URL to the glibc b
> -Original Message-
> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> Sent: Thursday, November 30, 2017 12:39 AM
> To: Gonglei (Arei); Eric Blake; linzhecheng; qemu-devel@nongnu.org
> Cc: f...@redhat.com; wangxin (U)
> Subject: Re: [Qemu-devel] [PATCH v4] thread: move detach_thread fro
+static const VMStateDescription vmstate_spapr_xive = {
+.name = TYPE_SPAPR_XIVE,
+.version_id = 1,
+.minimum_version_id = 1,
+.needed = vmstate_spapr_xive_needed,
+.fields = (VMStateField[]) {
+VMSTATE_UINT32_EQUAL(nr_irqs, sPAPRXive,
"Daniel P. Berrange" wrote:
> On Wed, Nov 22, 2017 at 12:54:58PM +, Daniel P. Berrange wrote:
>> On Wed, Nov 22, 2017 at 01:29:57PM +0100, Juan Quintela wrote:
>> > "Daniel P. Berrange" wrote:
>> > > On Mon, Oct 30, 2017 at 12:21:11PM +0100, Juan Quintela wrote:
> > > This is bad as it is th
That explains it. For most operations that approach works well as
basically nobody uses the 80 bit formats directly anyways. Unfortunately
asinh() is very badly conditioned in the region tested and it is not
enough.
A possible approach to fix this would be to use long double (128 bit)
were availab
On Wed, Nov 29, 2017 at 05:43:35PM +0100, Juan Quintela wrote:
> "Daniel P. Berrange" wrote:
> > On Wed, Nov 22, 2017 at 12:54:58PM +, Daniel P. Berrange wrote:
> >> On Wed, Nov 22, 2017 at 01:29:57PM +0100, Juan Quintela wrote:
> >> > "Daniel P. Berrange" wrote:
> >> > > On Mon, Oct 30, 2017
On Wed, Nov 29, 2017 at 04:35:25PM +0300, Roman Kagan wrote:
> > On 2017/11/29 18:41, Eduardo Habkost wrote:
[...]
> > > IMO, the long term solution is to make Linux guests not misbehave
> > > when we stop lying about the L3 cache. Maybe we could provide a
> > > "IPIs are expensive, please avoid t
On 29/11/2017 14:35, Roman Kagan wrote:
>>
>>> IMO, the long term solution is to make Linux guests not misbehave
>>> when we stop lying about the L3 cache. Maybe we could provide a
>>> "IPIs are expensive, please avoid them" hint in the KVM CPUID
>>> leaf?
> We already have it, it's the hypervisor
On 11/28/2017 08:33 PM, David Hildenbrand wrote:
> +S390CPU *cpu = s390_env_get_cpu(env);
> +
> +#ifdef CONFIG_TCG
> +if (tcg_enabled() && ra) {
> +cpu_restore_state(CPU(cpu), ra);
> +}
> +#endif
FWIW, I have a patch queued for 2.12 that removes the RA != 0 check protecting
cal
On 11/28/2017 08:33 PM, David Hildenbrand wrote:
> Let's use program_interrupt_ra() instead.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/fpu_helper.c | 2 +-
> target/s390x/int_helper.c | 14 +++---
> target/s390x/internal.h| 2 --
> target/s390x/misc_helper.c | 16
Am 29.11.2017 um 15:49 hat Fam Zheng geschrieben:
> While we look at the fixes for 2.11, I briefly prototyped this series
> to see if it makes sense as a simplification of the drain API for
> 2.12.
>
> The idea is to let AioContext manage quiesce callbacks, then the block
> layer only needs to do
On 11/28/2017 08:33 PM, David Hildenbrand wrote:
> It is broken and not even wired up. We'll add a new handler soon, but
> that will live somewhere else.
>
> Signed-off-by: David Hildenbrand
> ---
> hw/s390x/css.c | 6 --
> include/hw/s390x/css.h | 1 -
> target/s390x/internal.h
On Wed, 29 Nov 2017 17:25:59 +0100
Halil Pasic wrote:
> On 11/29/2017 01:37 PM, Cornelia Huck wrote:
> > On Tue, 28 Nov 2017 14:07:58 +0100
> > Halil Pasic wrote:
> >
> >> The default css 0xfe is currently restricted to virtual subchannel
> >> devices. The hope when the decision was made was,
On 11/28/2017 08:33 PM, David Hildenbrand wrote:
> TCG needs the retaddr when injecting an interrupt. Let's just pass it
> along and use 0 for KVM. The value will be completely ignored for KVM.
>
> Convert program_interrupt() to program_interrupt_ra() directly, making
> use of the passed address.
On 11/28/2017 08:33 PM, David Hildenbrand wrote:
> Once we wire up TCG, we will need the retaddr to correctly inject
> program interrupts. As we want to get rid of the function
> program_interrupt(), convert PCI code too.
>
> For KVM, we can simply pass a 0.
>
> Convert program_interrupt() to pro
1 - 100 of 320 matches
Mail list logo
