On Wed, 29 Nov 2017 16:45:21 +0100 David Hildenbrand <da...@redhat.com> wrote:
> On 29.11.2017 16:39, Cornelia Huck wrote: > > On Wed, 29 Nov 2017 16:38:03 +0100 > > David Hildenbrand <da...@redhat.com> wrote: > > > >> On 29.11.2017 16:35, Cornelia Huck wrote: > >>> On Wed, 29 Nov 2017 16:14:40 +0100 > >>> David Hildenbrand <da...@redhat.com> wrote: > >>> > >>>> On 29.11.2017 16:13, Cornelia Huck wrote: > >>>>> On Tue, 28 Nov 2017 21:33:14 +0100 > >>>>> David Hildenbrand <da...@redhat.com> wrote: > >>>>> > >>>>>> TCG needs the retaddr when injecting an interrupt. Let's just pass it > >>>>>> along and use 0 for KVM. The value will be completely ignored for KVM. > >>>>>> > >>>>> > >>>>> Can we get a #define for that? Just to make it clear at a glance that > >>>>> we're passing an ignored value and not some magic thing. > >>>> > >>>> If you can come up with a good name, I can't :) > >>> > >>> KVM_FAKE_RA > >>> KVM_RA_UNUSED > >>> KVM_RA_IGNORED > >>> > >>> ? > >>> > >> > >> KVM_RA ? (to keep lines short?) > >> > > > > That sounds too much like a magic value IMO (and not something that is > > ignored). > > > > Passing 0 will actually also ignore it for TCG. So it is actually a > magic value :) (just that more gets ignore din case of KVM ...) > > RA_NONE ? > > RA_IGNORED?
