Re: [Qemu-devel] [PATCH v4 01/20] block: Add .bdrv_co_block_status() callback

2017-11-28 Thread Vladimir Sementsov-Ogievskiy
12.10.2017 21:58, Eric Blake wrote: We are gradually moving away from sector-based interfaces, towards byte-based. Now that the block layer exposes byte-based allocation, it's time to tackle the drivers. Add a new callback that operates on as small as byte boundaries. Subsequent patches will the

Re: [Qemu-devel] [PATCH v2 2/2] vmgenid: use UUID property type

2017-11-28 Thread Roman Kagan
On Mon, Nov 27, 2017 at 08:38:41AM -0800, Ben Warren wrote: > It looks like you dropped Marc-André and my Reviewed-by lines. Please put > them back. Oops. I thought that the amount of changes in the first patch was too big to keep the R-b; however, the second patch was basically the same so I s

Re: [Qemu-devel] [PATCH v3 05/45] windbg: added helper features

2017-11-28 Thread Ladi Prosek
On Tue, Nov 21, 2017 at 3:07 PM, Mihail Abakumov wrote: > Added some helper features for windbgstub. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > include/exec/windbgstub-utils.h | 27 +++ > include/exec/

Re: [Qemu-devel] [PATCH v4 02/20] block: Switch passthrough drivers to .bdrv_co_block_status()

2017-11-28 Thread Vladimir Sementsov-Ogievskiy
12.10.2017 21:58, Eric Blake wrote: We are gradually moving away from sector-based interfaces, towards byte-based. Update the generic helpers, and all passthrough clients (blkdebug, commit, mirror, throttle) accordingly. Signed-off-by: Eric Blake --- v4: rebase to interface tweak v3: rebase t

Re: [Qemu-devel] QEMU Summit 2017: minutes

2017-11-28 Thread Thomas Huth
On 27.11.2017 23:03, John Snow wrote: > > On 11/23/2017 11:31 AM, Peter Maydell wrote: [...] >> Continuous Integration: >> * Christian Borntraeger: qemu-iotests have broken a lot, they should be >>run before patches are merged > > This, rather unfortunately, is a huge testing burden. I try t

Re: [Qemu-devel] [PATCH v3 05/45] windbg: added helper features

2017-11-28 Thread Peter Maydell
On 28 November 2017 at 08:18, Ladi Prosek wrote: > On Tue, Nov 21, 2017 at 3:07 PM, Mihail Abakumov > wrote: >> Added some helper features for windbgstub. > --- a/include/exec/windbgstub-utils.h > +++ b/include/exec/windbgstub-utils.h > @@ -32,7 +32,7 @@ > #define FMT_ERR "Error:%d" > > #defi

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Boris Fiuczynski
On 11/27/2017 05:56 PM, Cornelia Huck wrote: Proposal 2: Export the default cssid as a machine property. If this property exists, it also implies that devices can be put into any css image (although it makes the most sense to put them into the default css image as indicated by the property). Can

[Qemu-devel] [Bug 1591611] Re: chroot using qemu-x86_64-static fails on ppc64el

2017-11-28 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1591611 Title: chroot using qemu-x86_64-static fails on ppc64el Status in QEMU: Fix

Re: [Qemu-devel] [PATCH v3 05/45] windbg: added helper features

2017-11-28 Thread Paolo Bonzini
On 28/11/2017 09:34, Peter Maydell wrote: >> #define FMT_ERR "Error:%d" >> >> #define UINT8_P(ptr) ((uint8_t *) (ptr)) >> -#define UINT32_P(ptr) ((uint32_t *) (ptr)) >> +#define UINT32_P(ptr) ((uint32_t *) (size_t) (ptr)) >> #define PTR(var) UINT8_P(&var) > Hiding casts behind macros like this

[Qemu-devel] [PATCH 0/4] cryptodev: add vhost support

2017-11-28 Thread Gonglei
I posted the RFC verion five months ago for DPDK vhost-crypto implmention, and now it's time to send the formal version. Because we need an user space scheme for better performance. The vhost user crypto server side patches had been sent to DPDK community, pls see [RFC PATCH 0/6] lib/librte_vhost

[Qemu-devel] [PATCH 4/4] cryptodev-vhost-user: set the key length

2017-11-28 Thread Gonglei
Signed-off-by: Gonglei --- backends/cryptodev-vhost-user.c | 4 include/sysemu/cryptodev-vhost-user.h | 3 +++ 2 files changed, 7 insertions(+) diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-user.c index 061c0e5..c7a9848 100644 --- a/backends/cryptodev-vhost-u

[Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Gonglei
Introduce two vhost-user meassges: VHOST_USER_CREATE_CRYPTO_SESSION and VHOST_USER_CLOSE_CRYPTO_SESSION. At this point, the QEMU side support crypto operation in cryptodev host-user backend. Signed-off-by: Gonglei Signed-off-by: Longpeng(Mike) Signed-off-by: Zhoujian --- backends/cryptodev-vho

Re: [Qemu-devel] [PATCH v3 1/2] virtio: check VirtQueue Vring object is set

2017-11-28 Thread Cornelia Huck
On Mon, 27 Nov 2017 23:25:28 +0530 (IST) P J P wrote: > +-- On Mon, 27 Nov 2017, Cornelia Huck wrote --+ > |The check for align is not really needed, as virtio-1 disallows setting > align > |anyway. > > disallows...? See the check in virtio_queue_set_align(). Moreover, the calculation that b

Re: [Qemu-devel] QEMU Summit 2017: minutes

2017-11-28 Thread Cornelia Huck
On Tue, 28 Nov 2017 09:33:52 +0100 Thomas Huth wrote: > On 27.11.2017 23:03, John Snow wrote: > > > > On 11/23/2017 11:31 AM, Peter Maydell wrote: > [...] > >> Continuous Integration: > >> * Christian Borntraeger: qemu-iotests have broken a lot, they should be > >>run before patches are m

[Qemu-devel] [PATCH 2/4] cryptodev: add vhost support

2017-11-28 Thread Gonglei
Impliment the vhost-crypto's funtions, such as startup, stop and notification etc. Introduce an enum QCryptoCryptoDevBackendOptionsType in order to identify the cryptodev vhost backend is vhost-user or vhost-kernel-module (If exist). At this point, the cryptdoev-vhost-user works. Signed-off-by: G

[Qemu-devel] [PATCH 1/4] cryptodev: add vhost-user as a new cryptodev backend

2017-11-28 Thread Gonglei
Usage: -chardev socket,id=charcrypto0,path=/path/to/your/socket -object cryptodev-vhost-user,id=cryptodev0,chardev=charcrypto0 -device virtio-crypto-pci,id=crypto0,cryptodev=cryptodev0 Signed-off-by: Gonglei Signed-off-by: Longpeng(Mike) Signed-off-by: Zhoujian --- backends/Makefile.objs

Re: [Qemu-devel] [PATCH 11/25] spapr: describe the XIVE interrupt source flags

2017-11-28 Thread David Gibson
On Thu, Nov 23, 2017 at 02:29:41PM +0100, Cédric Le Goater wrote: > The XIVE interrupt sources can have different characteristics depending > on their nature and the HW level in use. The sPAPR specs provide a set of > flags to describe them : > > - XIVE_SRC_H_INT_ESB the Event State Buffers are

Re: [Qemu-devel] [PATCH 10/25] spapr: add MMIO handlers for the XIVE interrupt sources

2017-11-28 Thread David Gibson
On Thu, Nov 23, 2017 at 02:29:40PM +0100, Cédric Le Goater wrote: > Each interrupt source is associated with a two bit state machine > called an Event State Buffer (ESB). The bits are named "P" (pending) > and "Q" (queued) and can be controlled by MMIO. It is used to trigger > events. See code for

Re: [Qemu-devel] [PATCH 08/25] spapr: introduce a skeleton for the XIVE interrupt controller

2017-11-28 Thread David Gibson
On Thu, Nov 23, 2017 at 02:29:38PM +0100, Cédric Le Goater wrote: > The XIVE interrupt controller uses a set of tables to redirect exception > from event sources to CPU threads. The Interrupt Virtualization Entry (IVE) > table, also known as Event Assignment Structure (EAS), is one them. > > The X

Re: [Qemu-devel] [PATCH 09/25] spapr: introduce handlers for XIVE interrupt sources

2017-11-28 Thread David Gibson
On Thu, Nov 23, 2017 at 02:29:39PM +0100, Cédric Le Goater wrote: > These are very similar to the XICS handlers in a simpler form. They make > use of a status array for the LSI interrupts. The spapr_xive_irq() routine > in charge of triggering the CPU interrupt line will be filled later on. > > Si

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Paolo Bonzini
On 28/11/2017 10:03, Gonglei wrote: > Introduce two vhost-user meassges: VHOST_USER_CREATE_CRYPTO_SESSION > and VHOST_USER_CLOSE_CRYPTO_SESSION. At this point, the QEMU side > support crypto operation in cryptodev host-user backend. > > Signed-off-by: Gonglei > Signed-off-by: Longpeng(Mike) > Si

Re: [Qemu-devel] [PATCH v3] vhost: Cancel migration when vhost-user process restarted during migration

2017-11-28 Thread Dr. David Alan Gilbert
* fangying (fangyi...@huawei.com) wrote: > QEMU will abort when vhost-user process is restarted during migration > and vhost_log_global_start/stop is called. The reason is clear that > vhost_dev_set_log returns -1 because network connection is temporarily > lost. To handle this situation, let's can

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Cornelia Huck
On Tue, 28 Nov 2017 09:53:15 +0100 Boris Fiuczynski wrote: > On 11/27/2017 05:56 PM, Cornelia Huck wrote: > > Proposal 2: Export the default cssid as a machine property. If this > > property exists, it also implies that devices can be put into any css > > image (although it makes the most sense t

[Qemu-devel] [Bug 1672383] Re: Slow Windows XP load after commit a9353fe897ca2687e5b3385ed39e3db3927a90e0

2017-11-28 Thread Maskim Bakulin
Supposedly fixed by commit 406bc339b0505fcfc2ffcbca1f05a3756e338a65 ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1672383 Title: Slow Window

Re: [Qemu-devel] [PATCH v1 0/5] (FIXED) Interactive Boot Menu for DASD and SCSI Guests on s390x

2017-11-28 Thread Cornelia Huck
On Mon, 27 Nov 2017 15:55:31 -0500 "Collin L. Walling" wrote: > These patches implement a boot menu for ECKD DASD and SCSI guests on s390x. > The menu will only appear if the disk has been configured for IPL with the > zIPL tool and with the following QEMU command line options: > > -boot m

Re: [Qemu-devel] [PATCH v3 1/2] virtio: check VirtQueue Vring object is set

2017-11-28 Thread Stefan Hajnoczi
On Tue, Nov 28, 2017 at 10:11:54AM +0100, Cornelia Huck wrote: > On Mon, 27 Nov 2017 23:25:28 +0530 (IST) > P J P wrote: > > +-- On Mon, 27 Nov 2017, Stefan Hajnoczi wrote --+ > > | > +if (!vdev->vq[n].vring.num || !desc || !vdev->vq[n].vring.align) { > > | ... > > | vdev->vq[n].vring.desc =

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Gonglei (Arei)
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, November 28, 2017 6:02 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: m...@redhat.com; Huangweidong (C); stefa...@redhat.com; Zhoujian > (jay); pa...@linux.vnet.ibm.com; longpeng; xin.z...@intel.

Re: [Qemu-devel] [PATCH 08/25] spapr: introduce a skeleton for the XIVE interrupt controller

2017-11-28 Thread Cédric Le Goater
On 11/28/2017 05:40 AM, David Gibson wrote: > On Thu, Nov 23, 2017 at 02:29:38PM +0100, Cédric Le Goater wrote: >> The XIVE interrupt controller uses a set of tables to redirect exception >> from event sources to CPU threads. The Interrupt Virtualization Entry (IVE) >> table, also known as Event As

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Paolo Bonzini
On 28/11/2017 11:43, Gonglei (Arei) wrote: >> As far as I understand, VIRTIO_CRYPTO_CIPHER_CREATE_SESSION is called as >> a result of sending a message on the control virtqueue. > > VIRTIO_CRYPTO_CIPHER_CREATE_SESSION is a message type of control queue, > Means creating a session for next crypto re

Re: [Qemu-devel] [PATCH v1 1/5] s390-ccw: update libc.h

2017-11-28 Thread Cornelia Huck
On Mon, 27 Nov 2017 15:55:32 -0500 "Collin L. Walling" wrote: > Moved: > memcmp from bootmap.h to libc.h (renamed from _memcmp) > strlen from sclp.c to libc.h (renamed from _strlen) > > Added C standard functions: > isdigit > atoi > > Added non-C standard function: > itostr > > Signe

Re: [Qemu-devel] [PATCH v1 2/5] s390-ccw: ipl structs for eckd cdl/ldl

2017-11-28 Thread Cornelia Huck
On Mon, 27 Nov 2017 15:55:33 -0500 "Collin L. Walling" wrote: > ECKD DASDs have different IPL structures for CDL and LDL > formats. The current Ipl1 and Ipl2 structs follow the CDL > format, so we prepend "EckdCdl" to them. A new struct, > EckdLdlIpl1 is introduced and contains boot info for LDL.

Re: [Qemu-devel] [PATCH v5] nvme: Add tracing

2017-11-28 Thread Stefan Hajnoczi
On Mon, Nov 27, 2017 at 12:58:32PM +0100, Kevin Wolf wrote: > Am 25.11.2017 um 08:08 hat Doug Gale geschrieben: > > Ping > > Stefan, do you expect this to go through a different tree than the > tracing one? Yes, patches that just add/remove/modify trace events go through the affected component's

Re: [Qemu-devel] [Qemu-ppc] [PATCH 03/25] spapr: introduce a spapr_icp_create() helper

2017-11-28 Thread Greg Kurz
On Fri, 24 Nov 2017 12:26:21 + Cédric Le Goater wrote: > On 11/24/2017 10:09 AM, Greg Kurz wrote: > > On Thu, 23 Nov 2017 14:29:33 +0100 > > Cédric Le Goater wrote: > > > >> On sPAPR, the creation of the interrupt presenter depends on some of > >> the machine attributes. When the XIVE int

Re: [Qemu-devel] [Qemu-ppc] [PATCH 04/25] spapr: move the IRQ allocation routines under the machine

2017-11-28 Thread Greg Kurz
On Thu, 23 Nov 2017 14:29:34 +0100 Cédric Le Goater wrote: > Also change the prototype to use a sPAPRMachineState and prefix them > with spapr_irq_. It will let us synchronise the IRQ allocation with > the XIVE interrupt mode when available. > > Signed-off-by: Cédric Le Goater > --- Reviewed-b

Re: [Qemu-devel] [PULL] Net patches

2017-11-28 Thread Peter Maydell
On 28 November 2017 at 04:01, Jason Wang wrote: > The following changes since commit 5e19aed59ab48ca3c7f1e2da203eed27b91bef2d: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.11-20171127' > into staging (2017-11-27 11:16:20 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v1 3/5] s390-ccw: parse and set boot menu options

2017-11-28 Thread Cornelia Huck
On Mon, 27 Nov 2017 15:55:34 -0500 "Collin L. Walling" wrote: > Set boot menu options for an s390 guest and store them in > the iplb. These options are set via the QEMU command line > option: > > -boot menu=on|off[,splash-time=X] > > or via the libvirt domain xml: > > > >

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Gonglei (Arei)
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, November 28, 2017 6:46 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: m...@redhat.com; Huangweidong (C); stefa...@redhat.com; Zhoujian > (jay); pa...@linux.vnet.ibm.com; longpeng; xin.z...@intel.

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Paolo Bonzini
On 28/11/2017 12:06, Gonglei (Arei) wrote: >>> You mean we can share control virtqueue to DPDK as well? Like data queues? >> I don't know :) but why not? >> > Current there are two main reasons for this design: > > 1) we should use another cpu to polling the control virtqueue, which is > expensiv

[Qemu-devel] [PULL (for 2.11) v1 0/1] Merge io 2017/11/28

2017-11-28 Thread Daniel P. Berrange
The following changes since commit 5e19aed59ab48ca3c7f1e2da203eed27b91bef2d: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.11-20171127' into staging (2017-11-27 11:16:20 +) are available in the Git repository at: git://github.com/berrange/qemu tags/pull-qio-2017-11-28-1

[Qemu-devel] [PULL (for 2.11) v1 1/1] sockets: avoid crash when cleaning up sockets for an invalid FD

2017-11-28 Thread Daniel P. Berrange
If socket_listen_cleanup is passed an invalid FD, then querying the socket local address will fail. We must thus be prepared for the returned addr to be NULL Reported-by: Dr. David Alan Gilbert Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrange --- util/qemu-sockets.c | 3 ++

Re: [Qemu-devel] [PATCH] BCM2837 and machine raspi3

2017-11-28 Thread bzt bzt
Hi Andrew! [...] > > In that case, IIRC my high-level suggestion was to either parameterise > bcm2836 to take a CPU model string, or else move the CPU creation out of > bcm2836.c into the board file. From what I've understood thus far about > pi3, it does not seem necessary to have a separate bcm

Re: [Qemu-devel] [PATCH v3 1/2] virtio: check VirtQueue Vring object is set

2017-11-28 Thread P J P
+-- On Tue, 28 Nov 2017, Stefan Hajnoczi wrote --+ | > This is conflating different things: | > - vq does not exist (num == 0) | > - vq is not setup by the guest (desc == 0) | > - vq has no valid alignment (which is only relevant for legacy) | | I agree. Either case, vq would be unfit for use, no

Re: [Qemu-devel] [PATCH for-2.11] pc: fix crash on attempted cpu unplug

2017-11-28 Thread Paolo Bonzini
On 20/11/2017 18:05, Eduardo Habkost wrote: > On Mon, Nov 20, 2017 at 03:59:51PM +0100, Igor Mammedov wrote: >> On Mon, 20 Nov 2017 12:44:54 -0200 >> Eduardo Habkost wrote: >> >>> On Mon, Nov 20, 2017 at 03:34:13PM +0100, Igor Mammedov wrote: when qemu is started with '-no-acpi' CLI option, a

[Qemu-devel] [PATCH] memfd: fix configure test

2017-11-28 Thread Paolo Bonzini
Recent glibc added memfd_create in sys/mman.h. This conflicts with the definition in util/memfd.c: /builddir/build/BUILD/qemu-2.11.0-rc1/util/memfd.c:40:12: error: static declaration of memfd_create follows non-static declaration Fix the configure test, and remove the sys/memfd.h inclusion

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 1/5] s390-ccw: update libc.h

2017-11-28 Thread Thomas Huth
On 27.11.2017 21:55, Collin L. Walling wrote: > Moved: > memcmp from bootmap.h to libc.h (renamed from _memcmp) > strlen from sclp.c to libc.h (renamed from _strlen) > > Added C standard functions: > isdigit > atoi > > Added non-C standard function: > itostr > > Signed-off-by: Collin L

Re: [Qemu-devel] [PATCH 0/1] block: Workaround for the iotests errors

2017-11-28 Thread Kevin Wolf
Am 28.11.2017 um 06:43 hat Jeff Cody geschrieben: > On Tue, Nov 28, 2017 at 12:29:09AM +0100, Kevin Wolf wrote: > > Am 23.11.2017 um 18:57 hat Fam Zheng geschrieben: > > > Jeff's block job patch made the latent drain bug visible, and I find this > > > patch, which by itself also makes some sense, c

Re: [Qemu-devel] [PATCH] memfd: fix configure test

2017-11-28 Thread Marc-André Lureau
Hi On Tue, Nov 28, 2017 at 12:32 PM, Paolo Bonzini wrote: > Recent glibc added memfd_create in sys/mman.h. This conflicts with > the definition in util/memfd.c: > > /builddir/build/BUILD/qemu-2.11.0-rc1/util/memfd.c:40:12: error: static > declaration of memfd_create follows non-static decla

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 3/5] s390-ccw: parse and set boot menu options

2017-11-28 Thread Thomas Huth
On 27.11.2017 21:55, Collin L. Walling wrote: > Set boot menu options for an s390 guest and store them in > the iplb. These options are set via the QEMU command line > option: > > -boot menu=on|off[,splash-time=X] > > or via the libvirt domain xml: > > > > > > Where X repre

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Boris Fiuczynski
On 11/28/2017 11:22 AM, Cornelia Huck wrote: On Tue, 28 Nov 2017 09:53:15 +0100 Boris Fiuczynski wrote: On 11/27/2017 05:56 PM, Cornelia Huck wrote: Proposal 2: Export the default cssid as a machine property. If this property exists, it also implies that devices can be put into any css image

Re: [Qemu-devel] [PATCH] memfd: fix configure test

2017-11-28 Thread Paolo Bonzini
On 28/11/2017 12:42, Marc-André Lureau wrote: > Hi > > On Tue, Nov 28, 2017 at 12:32 PM, Paolo Bonzini wrote: >> Recent glibc added memfd_create in sys/mman.h. This conflicts with >> the definition in util/memfd.c: >> >> /builddir/build/BUILD/qemu-2.11.0-rc1/util/memfd.c:40:12: error: static

[Qemu-devel] [Bug 1734810] Re: Windows guest virtual PC running abnormally slow

2017-11-28 Thread Jeb E.
** Also affects: gnome-boxes Importance: Undecided Status: New ** Also affects: qemu Importance: Undecided Status: New ** Also affects: spice-packages Importance: Undecided Status: New ** Also affects: kvm Importance: Undecided Status: New ** Changed in:

Re: [Qemu-devel] [PATCH] BCM2837 and machine raspi3

2017-11-28 Thread Peter Maydell
On 28 November 2017 at 11:26, bzt bzt wrote: > (Although I have a question. I'm not sure what's the preferred > way to get MachineClass* object in bcm2836. Use a MachineState* cast on it's > Object* argument with MACHINE_GET_CLASS() or should I use the parameterless > qdev_get_machine() instead?)

Re: [Qemu-devel] [PATCH] memfd: fix configure test

2017-11-28 Thread Peter Maydell
On 28 November 2017 at 11:49, Paolo Bonzini wrote: > On 28/11/2017 12:42, Marc-André Lureau wrote: >> It is introduced by this commit, right? >> https://sourceware.org/git/?p=glibc.git;a=commit;h=59d2cbb1fe4b8601d5cbd359c3806973eab6c62d >> >> (I added Florian Weimer in cc) >> >> So it's not part o

Re: [Qemu-devel] [PATCH v3 1/2] virtio: check VirtQueue Vring object is set

2017-11-28 Thread Cornelia Huck
On Tue, 28 Nov 2017 16:57:34 +0530 (IST) P J P wrote: > +-- On Tue, 28 Nov 2017, Stefan Hajnoczi wrote --+ > | > This is conflating different things: > | > - vq does not exist (num == 0) > | > - vq is not setup by the guest (desc == 0) > | > - vq has no valid alignment (which is only relevant for

Re: [Qemu-devel] [PATCH] memfd: fix configure test

2017-11-28 Thread Florian Weimer
On 11/28/2017 12:42 PM, Marc-André Lureau wrote: Couldn't the declarations be put in sys/memfd.h like the man claimed it would be for > 1y? We discussed it. It was a typo in the manual page. There never was a header file: https://marc.info/?l=linux-man&m=150988359906012&w=2 The UAPI h

[Qemu-devel] [PATCH 2/2] colo: add trace for the tcp packet comparison

2017-11-28 Thread Mao Zhongyi
Cc: Zhang Chen Cc: Li Zhijian Cc: Jason Wang Signed-off-by: Mao Zhongyi --- net/colo-compare.c | 16 net/colo.c | 1 + net/colo.h | 1 + net/trace-events | 2 +- 4 files changed, 19 insertions(+), 1 deletion(-) diff --git a/net/colo-compare.c b/net/colo-

[Qemu-devel] [PATCH 1/2] colo: compare the packet based on the tcp sequence number

2017-11-28 Thread Mao Zhongyi
The primary and secondary guest has the same TCP stream, but the the packet sizes are different due to the different fragmentation. In the current impletation, compare the packet with the size of payload, but packets of the same size and payload are very few, so it triggers che

[Qemu-devel] [PATCH 0/2] Rewrite TCP packet comparison in colo

2017-11-28 Thread Mao Zhongyi
In this series, rewrite the tcp packet comparison based on the tcp sequence number instead of original method that compare the packet based on the payload size. Mao Zhongyi (2): colo: compare the packet based on the tcp sequence number colo: add trace for the tcp packet comparison net/colo-c

Re: [Qemu-devel] [PATCH v3 01/45] windbg: added empty windbgstub files

2017-11-28 Thread Ladi Prosek
On Tue, Nov 21, 2017 at 3:07 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > Makefile.target |7 +++ > include/exec/windbgstub-utils.h | 18 ++ > include/exec/windbg

[Qemu-devel] [PATCH 2/2] ide: fix crash in IDE cdrom read

2017-11-28 Thread Denis V. Lunev
There is the following crash reported from the field in QEMU 2.9: bdrv_inc_in_flight (bs=bs@entry=0x0) blk_aio_prwv blk_aio_preadv ide_buffered_readv cd_read_sector ide_data_readw portio_read memory_region_read_accessor access_with_adjusted_size memory_region

[Qemu-devel] [PATCH 1/2] hmp: block qemu-io command for device without media

2017-11-28 Thread Denis V. Lunev
In this case blk->bs == NULL and the code will just crash. Emulate error on that path. Signed-off-by: Denis V. Lunev CC: "Dr. David Alan Gilbert" CC: Kevin Wolf CC: Stefan Hajnoczi --- hmp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hmp.c b/hmp.c index 35a7041824..cfd1d9ab29 1006

[Qemu-devel] [PATCH for 2.11 0/2] QEMU crashes with CD device without media

2017-11-28 Thread Denis V. Lunev
There are 2 cases I have spotted so far: 1) IDE ATAPI read processing. Actually this was reported from field 2) QEMU IO hmp command (found during evaluation of (1)) SCSI code checks during access that blk_is_available(). These patches add same checks on different code paths. Pls decide whether th

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Cornelia Huck
On Tue, 28 Nov 2017 12:49:04 +0100 Boris Fiuczynski wrote: > On 11/28/2017 11:22 AM, Cornelia Huck wrote: > > On Tue, 28 Nov 2017 09:53:15 +0100 > > Boris Fiuczynski wrote: > > > >> On 11/27/2017 05:56 PM, Cornelia Huck wrote: > >>> Proposal 2: Export the default cssid as a machine property

Re: [Qemu-devel] [Qemu-block] [PATCH 0/1] block: Workaround for the iotests errors

2017-11-28 Thread Kevin Wolf
Am 28.11.2017 um 12:42 hat Kevin Wolf geschrieben: > Am 28.11.2017 um 06:43 hat Jeff Cody geschrieben: > > On Tue, Nov 28, 2017 at 12:29:09AM +0100, Kevin Wolf wrote: > > > Am 23.11.2017 um 18:57 hat Fam Zheng geschrieben: > > > > Jeff's block job patch made the latent drain bug visible, and I find

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Christian Borntraeger
On 11/28/2017 01:14 PM, Cornelia Huck wrote: > On Tue, 28 Nov 2017 12:49:04 +0100 > Boris Fiuczynski wrote: > >> On 11/28/2017 11:22 AM, Cornelia Huck wrote: >>> On Tue, 28 Nov 2017 09:53:15 +0100 >>> Boris Fiuczynski wrote: >>> On 11/27/2017 05:56 PM, Cornelia Huck wrote: > Prop

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 4/5] s390-ccw: interactive boot menu for eckd dasd

2017-11-28 Thread Thomas Huth
On 27.11.2017 21:55, Collin L. Walling wrote: > When the boot menu options are present and the guest's > disk has been configured by the zipl tool, then the user > will be presented with an interactive boot menu with > labeled entries. An example of what the menu might look > like: > > zIPL v1

Re: [Qemu-devel] [PATCH v3 45/45] windbg: implemented kd_api_get_context_ex and kd_api_set_context_ex

2017-11-28 Thread Ladi Prosek
On Tue, Nov 21, 2017 at 3:11 PM, Mihail Abakumov wrote: [...] > diff --git a/windbgstub.c b/windbgstub.c > index 36372c0ea5..3bcf6a8cbb 100755 > --- a/windbgstub.c > +++ b/windbgstub.c > @@ -224,6 +224,14 @@ static void > windbg_process_manipulate_packet(ParsingContext *ctx) > kd_api_que

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 4/5] s390-ccw: interactive boot menu for eckd dasd

2017-11-28 Thread Cornelia Huck
On Tue, 28 Nov 2017 13:36:38 +0100 Thomas Huth wrote: > On 27.11.2017 21:55, Collin L. Walling wrote: > > +static int zipl_boot_menu(block_number_t s1b_block_nr) > > +{ > > +void *stage2_data, *menu_offset; > > + > > +read_stage2(s1b_block_nr, &stage2_data); > > +menu_offset = stage2

Re: [Qemu-devel] [PATCH 1/2] pci: removed the is_express field since a uniform interface was inserted

2017-11-28 Thread Yoni Bettan
On 11/28/2017 07:51 AM, Yoni Bettan wrote: * according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we don't need this field anymore Hi, please discard this series, i will sen

Re: [Qemu-devel] [PATCH v3 03/45] windbg: modified windbgkd.h

2017-11-28 Thread Ladi Prosek
On Tue, Nov 21, 2017 at 3:07 PM, Mihail Abakumov wrote: > Added useful name arrays of some defines. Not used yet. Needs for the future. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > include/exec/windbgkd.h | 75 > ++

[Qemu-devel] [PULL 0/2] nbd patches for -rc3

2017-11-28 Thread Eric Blake
The following changes since commit c7e1f823aed63f49e559e7463da76d5b320be35b: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2017-11-28 10:03:26 +) are available in the Git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2017-11-28 for y

[Qemu-devel] [PULL 1/2] nbd/server: CVE-2017-15119 Reject options larger than 32M

2017-11-28 Thread Eric Blake
The NBD spec gives us permission to abruptly disconnect on clients that send outrageously large option requests, rather than having to spend the time reading to the end of the option. No real option request requires that much data anyways; and meanwhile, we already have the practice of abruptly dr

[Qemu-devel] [PULL 2/2] nbd/server: CVE-2017-15118 Stack smash on large export name

2017-11-28 Thread Eric Blake
Introduced in commit f37708f6b8 (2.10). The NBD spec says a client can request export names up to 4096 bytes in length, even though they should not expect success on names longer than 256. However, qemu hard-codes the limit of 256, and fails to filter out a client that probes for a longer name; t

[Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

2017-11-28 Thread Halil Pasic
The default css 0xfe is currently restricted to virtual subchannel devices. The hope when the decision was made was, that non-virtual subchannel devices will come around when guest can exploit multiple channel subsystems. Since the guests generally don't do, the pain of the partitioned (cssid) name

Re: [Qemu-devel] [PATCH] linux-user: Use *at functions instead of caching interp_prefix contents

2017-11-28 Thread Peter Maydell
On 12 January 2017 at 04:05, Richard Henderson wrote: > If the interp_prefix is a complete chroot, it may have a *lot* of files. > Setting up the cache for this is quite expensive. Instead, use the *at > versions of various syscalls to attempt the operation in the prefix. > > Signed-off-by: Richa

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Halil Pasic
On 11/28/2017 01:24 PM, Christian Borntraeger wrote: > > > On 11/28/2017 01:14 PM, Cornelia Huck wrote: >> On Tue, 28 Nov 2017 12:49:04 +0100 >> Boris Fiuczynski wrote: >> >>> On 11/28/2017 11:22 AM, Cornelia Huck wrote: On Tue, 28 Nov 2017 09:53:15 +0100 Boris Fiuczynski wrote: >>>

Re: [Qemu-devel] [PATCH for-2.11] pc: fix crash on attempted cpu unplug

2017-11-28 Thread Igor Mammedov
On Tue, 28 Nov 2017 12:28:43 +0100 Paolo Bonzini wrote: > On 20/11/2017 18:05, Eduardo Habkost wrote: > > On Mon, Nov 20, 2017 at 03:59:51PM +0100, Igor Mammedov wrote: > >> On Mon, 20 Nov 2017 12:44:54 -0200 > >> Eduardo Habkost wrote: > >> > >>> On Mon, Nov 20, 2017 at 03:34:13PM +0100, Ig

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Christian Borntraeger
On 11/28/2017 02:17 PM, Halil Pasic wrote: > > > On 11/28/2017 01:24 PM, Christian Borntraeger wrote: >> >> >> On 11/28/2017 01:14 PM, Cornelia Huck wrote: >>> On Tue, 28 Nov 2017 12:49:04 +0100 >>> Boris Fiuczynski wrote: >>> On 11/28/2017 11:22 AM, Cornelia Huck wrote: > On Tue, 28

[Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices

2017-11-28 Thread Cornelia Huck
info qom-tree shows several devices under unattached that probably should go somewhere. The css bridge should attach to the machine, as it has a similar purpose as e.g. a pci host bridge. The autogenerated network devices should be in the same bucket as any other device; I'm just not sure about t

Re: [Qemu-devel] [PATCH v3 10/45] windbg: structures for parsing data stream

2017-11-28 Thread Ladi Prosek
On Tue, Nov 21, 2017 at 3:08 PM, Mihail Abakumov wrote: > Added structures for parsing data stream from windbg to packet. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > include/exec/windbgstub-utils.h | 11 +++ > windbgst

[Qemu-devel] [PATCH RFC 2/2] s390x: attach autogenerated nics

2017-11-28 Thread Cornelia Huck
The autogenerated nics should be treated as any other device; use qdev_set_id() to have them show up under peripheral-anon. Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c in

[Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

2017-11-28 Thread Victor Kaplansky
From: Victor Kaplansky If we allow qemu to change logging area after it was already established, it may require from the backend to acquire a lock on each access to the log_base, which has a potential quite a big performance hit. Thus we would like to clarify in the spec, that qemu is not expect

[Qemu-devel] [PATCH RFC 1/2] s390x/css: attach css bridge

2017-11-28 Thread Cornelia Huck
Logically, the css bridge should be attached to the machine. Signed-off-by: Cornelia Huck --- hw/s390x/css-bridge.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/s390x/css-bridge.c b/hw/s390x/css-bridge.c index c4a9735d71..84d33eafc2 100644 --- a/hw/s390x/css-bridge.c +++ b/hw/s390x/c

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Cornelia Huck
On Tue, 28 Nov 2017 14:25:08 +0100 Christian Borntraeger wrote: > On 11/28/2017 02:17 PM, Halil Pasic wrote: > > In the meanwhile I strongly prefer option 1 (at the ccw devices). I've just > > sent a v2, and IMHO it shows the limitations of machine properties very > > well. > > option 1 is s

Re: [Qemu-devel] [PATCH RFC 1/2] s390x/css: attach css bridge

2017-11-28 Thread Christian Borntraeger
Looks good to me and is similar to the other devices (e.g. the IPL device) Reviewed-by: Christian Borntraeger On 11/28/2017 02:46 PM, Cornelia Huck wrote: > Logically, the css bridge should be attached to the machine. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/css-bridge.c | 2 ++ >

Re: [Qemu-devel] [PATCH v3 15/45] windbg: sized data buffer

2017-11-28 Thread Ladi Prosek
On Tue, Nov 21, 2017 at 3:08 PM, Mihail Abakumov wrote: > Defined useful sized data buffer. It contains pointer to data and size of > this data. Also, defined some macros for init and free. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov >

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Halil Pasic
On 11/24/2017 01:46 PM, Cornelia Huck wrote: > On Thu, 23 Nov 2017 14:33:56 +0100 > Halil Pasic wrote: > >> Having an adequate representation for the css in QOM would be certainly >> interesting, but at the same time (IMHO) is somewhat challenging. Let me >> make some observations, which should

Re: [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices

2017-11-28 Thread Halil Pasic
On 11/28/2017 02:46 PM, Cornelia Huck wrote: > info qom-tree shows several devices under unattached that probably > should go somewhere. I think this was reported by me. See MID: <76f95c6f-641e-2fe0-73b4-3ab24fc1a...@linux.vnet.ibm.com> I would not mind a Reported-by: Halil Pasic . Or do you s

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Christian Borntraeger
On 11/28/2017 03:01 PM, Cornelia Huck wrote: > On Tue, 28 Nov 2017 14:25:08 +0100 > Christian Borntraeger wrote: > >> On 11/28/2017 02:17 PM, Halil Pasic wrote: > >>> In the meanwhile I strongly prefer option 1 (at the ccw devices). I've just >>> sent a v2, and IMHO it shows the limitations of m

Re: [Qemu-devel] [PULL 0/2] nbd patches for -rc3

2017-11-28 Thread Peter Maydell
On 28 November 2017 at 13:02, Eric Blake wrote: > The following changes since commit c7e1f823aed63f49e559e7463da76d5b320be35b: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2017-11-28 10:03:26 +) > > are available in the Git repository at: > > g

Re: [Qemu-devel] [PULL (for 2.11) v1 0/1] Merge io 2017/11/28

2017-11-28 Thread Peter Maydell
On 28 November 2017 at 11:23, Daniel P. Berrange wrote: > The following changes since commit 5e19aed59ab48ca3c7f1e2da203eed27b91bef2d: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.11-20171127' > into staging (2017-11-27 11:16:20 +) > > are available in the Git repository

Re: [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices

2017-11-28 Thread Cornelia Huck
On Tue, 28 Nov 2017 15:17:38 +0100 Halil Pasic wrote: > On 11/28/2017 02:46 PM, Cornelia Huck wrote: > > info qom-tree shows several devices under unattached that probably > > should go somewhere. > > I think this was reported by me. See > MID: <76f95c6f-641e-2fe0-73b4-3ab24fc1a...@linux.vnet

[Qemu-devel] Help with Qemu/KVM performance counters

2017-11-28 Thread Abdullah Alhaddad
Hi all, I hope you're all doing well. As i was looking for a solution for a particular problem in Qemu/KVM virtulization. My issue is that I have a virtual machine that runs well in VMware and when I migrated that to Qemu/KVM-enabled environment, it didn't work! I figured out that under VMware h

[Qemu-devel] [PATCH 1/2] linux-user: Propagate siginfo_t through to handle_cpu_signal()

2017-11-28 Thread Peter Maydell
Currently all the architecture/OS specific cpu_signal_handler() functions call handle_cpu_signal() without passing it the siginfo_t. We're going to want that so we can look at the si_code to determine whether this is a SEGV_ACCERR access violation or some other kind of fault, so change the function

[Qemu-devel] [PATCH 0/2] linux-user: Fix race between threads in page_unprotect()

2017-11-28 Thread Peter Maydell
If multiple guest threads in user-mode emulation write to a page which QEMU has marked read-only because of cached TCG translations, the threads can race in page_unprotect: * threads A & B both try to do a write to a page with code in it at the same time (ie which we've made non-writeable, so

[Qemu-devel] [PATCH 2/2] page_unprotect(): handle calls to pages that are PAGE_WRITE

2017-11-28 Thread Peter Maydell
If multiple guest threads in user-mode emulation write to a page which QEMU has marked read-only because of cached TCG translations, the threads can race in page_unprotect: * threads A & B both try to do a write to a page with code in it at the same time (ie which we've made non-writeable, so

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Cornelia Huck
On Tue, 28 Nov 2017 15:17:49 +0100 Christian Borntraeger wrote: > On 11/28/2017 03:01 PM, Cornelia Huck wrote: > > On Tue, 28 Nov 2017 14:25:08 +0100 > > Christian Borntraeger wrote: > >> What I want now is to enable vfio-ccw for libvirt and Linux guests and for > >> that > >> we need to lift

Re: [Qemu-devel] [PATCH v2 2/2] vmgenid: use UUID property type

2017-11-28 Thread Michael S. Tsirkin
On Tue, Nov 28, 2017 at 11:02:13AM +0300, Roman Kagan wrote: > On Mon, Nov 27, 2017 at 08:38:41AM -0800, Ben Warren wrote: > > It looks like you dropped Marc-André and my Reviewed-by lines. Please put > > them back. > > Oops. I thought that the amount of changes in the first patch was too > big

[Qemu-devel] [PATCH for-2.11] blockjob: Remove the job from the list earlier in block_job_unref()

2017-11-28 Thread Alberto Garcia
When destroying a block job in block_job_unref() we should remove it from the job list before calling block_job_remove_all_bdrv(). This is because removing the BDSs can trigger an aio_poll() and wake up other jobs that might attempt to use the block job list. If that happens the job we're currentl

[Qemu-devel] [PATCH] numa: fix missing '-numa cpu' in '-help' output

2017-11-28 Thread Igor Mammedov
commit 419fcdec3c (numa: add '-numa cpu,...' option for property based node mapping) added '-numa cpu' option but forgot to update appropriate section for '--help'. Add '-numa cpu' description to '-help' output Reported-by: Markus Armbruster Signed-off-by: Igor Mammedov --- qemu-options.hx | 4

  1   2   3   >