On Tue, 28 Nov 2017 13:36:38 +0100
Thomas Huth <th...@redhat.com> wrote:
> On 27.11.2017 21:55, Collin L. Walling wrote:
> > +static int zipl_boot_menu(block_number_t s1b_block_nr)
> > +{
> > + void *stage2_data, *menu_offset;
> > +
> > + read_stage2(s1b_block_nr, &stage2_data);
> > + menu_offset = stage2_data;
> > +
> > + /* Menu banner starts with "zIPL" */
> > + while (menu_offset < stage2_data + STAGE2_MAX_SIZE - 4) {
> > + if (magic_match(menu_offset, ZIPL_MAGIC_EBCDIC)) {
> > + return menu_get_zipl_boot_index(menu_offset);
> > + }
> > + menu_offset++;
> > + }
> > +
> > + panic("\n! No menu data found !\n");
>
> Maybe remove the initial exclamation mark?
It does match the other panics in the code, though.
>
> > + /* should not reach here */
> > + return 0;
> > +}
