Re: [Qemu-devel] [PATCH v3 7/7] s390x/pci: search for subregion inside the BARs

2017-11-27 Thread Pierre Morel
On 23/11/2017 10:54, Thomas Huth wrote: On 22.11.2017 23:05, Pierre Morel wrote: When dispatching memory access to PCI BAR region, we must look for possible subregions, used by the PCI device to map different memory areas inside the same PCI BAR. Since the data offset we received is calculated

Re: [Qemu-devel] [PATCH v3 4/7] s390x/pci: rework PCI STORE BLOCK

2017-11-27 Thread Pierre Morel
On 23/11/2017 10:26, Thomas Huth wrote: On 22.11.2017 23:05, Pierre Morel wrote: Enhance the fault detection. Fixup the precedence to check the destination path existance before checking for the source accessibility. Add the maxstbl entry to both the Query PCI Function Group response and the P

[Qemu-devel] [PATCH v3] vhost: Cancel migration when vhost-user process restarted during migration

2017-11-27 Thread fangying
QEMU will abort when vhost-user process is restarted during migration and vhost_log_global_start/stop is called. The reason is clear that vhost_dev_set_log returns -1 because network connection is temporarily lost. To handle this situation, let's cancel migration here. Signed-off-by: Ying Fang --

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Pierre Morel
On 27/11/2017 07:59, Thomas Huth wrote: On 25.11.2017 14:49, Pierre Morel wrote: On 24/11/2017 07:19, Yi Min Zhao wrote: 在 2017/11/23 下午8:18, Thomas Huth 写道: On 23.11.2017 13:07, Yi Min Zhao wrote: 在 2017/11/23 下午6:33, Cornelia Huck 写道: On Thu, 23 Nov 2017 11:25:10 +0100 Thomas Huth wrot

Re: [Qemu-devel] [PATCH v2 1/6] machine: Replace has_dynamic_sysbus with list of allowed devices

2017-11-27 Thread Marcel Apfelbaum
On 25/11/2017 17:16, Eduardo Habkost wrote: The existing has_dynamic_sysbus flag makes the machine accept every user-creatable sysbus device type on the command-line. Replace it with a list of allowed device types, so machines can easily accept some sysbus devices while rejecting others. To keep

Re: [Qemu-devel] [PATCHv3] dma/i82374: avoid double creation of i82374 device

2017-11-27 Thread Eduardo Otubo
On Fri, Nov 24, 2017 at 06:44:59PM +0100, Thomas Huth wrote: > Hi Eduardo, > > On 24.11.2017 14:46, Eduardo Otubo wrote: > > v3: > > * Removed all unecessary local_err > > * Change return of isa_bus_dma() and DMA_init() from void to int8_t, > >returning -EBUSY on error and 0 on success > >

Re: [Qemu-devel] [PATCH v3] vhost: Cancel migration when vhost-user process restarted during migration

2017-11-27 Thread Marc-André Lureau
Hi On Mon, Nov 27, 2017 at 8:32 AM, fangying wrote: > QEMU will abort when vhost-user process is restarted during migration > and vhost_log_global_start/stop is called. The reason is clear that > vhost_dev_set_log returns -1 because network connection is temporarily > lost. To handle this situati

Re: [Qemu-devel] [PATCH v2 6/6] q35: Allow only supported dynamic sysbus devices

2017-11-27 Thread Marcel Apfelbaum
On 25/11/2017 17:16, Eduardo Habkost wrote: The only user-creatable sysbus devices in qemu-system-x86_64 are amd-iommu, intel-iommu, and xen-backend. xen-backend is handled by xen_set_dynamic_sysbus(), so we only need to add amd-iommu and intel-iommu. Cc: "Michael S. Tsirkin" Cc: Marcel Apfelb

Re: [Qemu-devel] [PATCH] gdbstub: add tracing

2017-11-27 Thread Markus Armbruster
Drive-by question... Doug Gale writes: > Signed-off-by: Doug Gale > --- > gdbstub.c| 100 > ++- > trace-events | 21 + > 2 files changed, 86 insertions(+), 35 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 2

Re: [Qemu-devel] [PATCH v3 1/2] virtio: check VirtQueue Vring object is set

2017-11-27 Thread Cornelia Huck
On Sat, 25 Nov 2017 00:04:45 +0530 P J P wrote: > From: Prasad J Pandit > > An user could attempt to use an uninitialised VirtQueue object s/An user/A guest/ ? > or unset Vring.align leading to a arithmetic exception. Add check > to avoid it. > > Reported-by: Zhangboxian > Signed-off-by: Pr

Re: [Qemu-devel] [PATCH 1/2] qdev-properties: add UUID property type

2017-11-27 Thread Roman Kagan
On Fri, Nov 24, 2017 at 08:36:53PM -0600, Corey Minyard wrote: > On 11/24/2017 09:36 AM, Roman Kagan wrote: > > UUIDs (GUIDs) are widely used in VMBus-related stuff, so a dedicated > > property type becomes helpful. > > > > Signed-off-by: Roman Kagan > > --- > > include/hw/qdev-properties.h |

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Yi Min Zhao
在 2017/11/27 下午2:59, Thomas Huth 写道: On 25.11.2017 14:49, Pierre Morel wrote: On 24/11/2017 07:19, Yi Min Zhao wrote: 在 2017/11/23 下午8:18, Thomas Huth 写道: On 23.11.2017 13:07, Yi Min Zhao wrote: 在 2017/11/23 下午6:33, Cornelia Huck 写道: On Thu, 23 Nov 2017 11:25:10 +0100 Thomas Huth wrote:

Re: [Qemu-devel] [PATCH for-2.12] s390x: introduce 2.12 compat machine

2017-11-27 Thread Cornelia Huck
On Fri, 24 Nov 2017 16:33:44 +0100 Cornelia Huck wrote: > Signed-off-by: Cornelia Huck > --- > hw/s390x/s390-virtio-ccw.c | 17 - > include/hw/compat.h| 3 +++ > 2 files changed, 19 insertions(+), 1 deletion(-) Queued to s390-next.

Re: [Qemu-devel] [PATCH 1/2] qdev-properties: add UUID property type

2017-11-27 Thread Daniel P. Berrange
On Fri, Nov 24, 2017 at 08:36:53PM -0600, Corey Minyard wrote: > On 11/24/2017 09:36 AM, Roman Kagan wrote: > > UUIDs (GUIDs) are widely used in VMBus-related stuff, so a dedicated > > property type becomes helpful. > > > > Signed-off-by: Roman Kagan > > --- > > include/hw/qdev-properties.h |

[Qemu-devel] [PATCH v13 06/12] target-arm: kvm64: detect whether can set vsesr_el2

2017-11-27 Thread Dongjiu Geng
Check if kvm can support to set vsesr_el2 value for vcpu. When guest takes a virtual SError interrupt exception, this value will provides syndrome value reported into ESR_EL1 ISS filed. Signed-off-by: Dongjiu Geng Signed-off-by: Quanming Wu --- Address James's(james.mo...@arm.com) comments to de

[Qemu-devel] [PATCH v13 02/12] ACPI: Add APEI GHES table generation and CPER record support

2017-11-27 Thread Dongjiu Geng
This implements APEI GHES Table generation when OS boot and record CPER in runtime via fw_cfg blobs. After a CPER info is recorded into guest memory, it need to inject whatever interrupt (or assert whatever GPIO line) to notify the guest. About the detailed design or implementation, please see the

[Qemu-devel] [PATCH v13 05/12] linux-headers: sync against Linux v4.14-rc8

2017-11-27 Thread Dongjiu Geng
Signed-off-by: Dongjiu Geng --- Address Peter's comments to sync mainline Linux header file in [1] Address Michael's comments to not sync SPDX from Linux kernel header file [1]: https://lkml.org/lkml/2017/9/5/575 --- linux-headers/linux/kvm.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Qemu-devel] [PATCH v13 04/12] ACPI: enable APEI GHES in the configure file and build it

2017-11-27 Thread Dongjiu Geng
Add CONFIG_ACPI_APEI configuration in the arm-softmmu.mak and add build choice in the Makefile.objs. Signed-off-by: Dongjiu Geng --- default-configs/arm-softmmu.mak | 1 + hw/acpi/Makefile.objs | 1 + 2 files changed, 2 insertions(+) diff --git a/default-configs/arm-softmmu.mak b/defa

[Qemu-devel] [PATCH v13 07/12] target-arm: handle SError interrupt exception from the guest OS

2017-11-27 Thread Dongjiu Geng
When guest OS happens SError interrupt(SEI), it will trap to host. Host check the Asynchronous Error Type(ESR_ELx.AET). If it the error has not been propagated and has not (yet) been architecturally consumed by the PE, it will return to use space with error code KVM_SEI_SEV_RECOVERABLE. Qemu recei

[Qemu-devel] [PATCH v13 03/12] docs: APEI GHES generation description

2017-11-27 Thread Dongjiu Geng
Add APEI/GHES description document Signed-off-by: Dongjiu Geng --- Address Igor's comments to add a doc --- docs/specs/acpi_hest_ghes.txt | 96 +++ 1 file changed, 96 insertions(+) create mode 100644 docs/specs/acpi_hest_ghes.txt diff --git a/docs/specs/

Re: [Qemu-devel] [PATCH] 9pfs: don't ignore O_DIRECT flag in the 9pfs server

2017-11-27 Thread Greg Kurz
On Tue, 21 Nov 2017 11:28:29 +0800 jiangyiwen wrote: > On 2017/11/20 18:13, Greg Kurz wrote: > > On Mon, 20 Nov 2017 13:48:59 +0800 > > jiangyiwen wrote: > > > >> Now v9fs in linux has already supported O_DIRECT(v9fs_direct_IO), > >> when guest user open file with O_DIRECT flag and return suc

[Qemu-devel] [PATCH v13 01/12] ACPI: add related GHES structures and macros definition

2017-11-27 Thread Dongjiu Geng
Add Generic Error Status Block structures and some macros definition, which refer to the ACPI 4.0 and ACPI 6.1. The HEST table generation and CPER record will use them. Signed-off-by: Dongjiu Geng --- Address Igor's comments to to get rid of most structures and use build_append_int_noprefix() API

Re: [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band

2017-11-27 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Nov 24, 2017 at 01:14:53PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > So it can get rid of being run on main thread. > > > > > > Signed-off-by: Peter Xu > > > > Last time I asked if you were sure that we di

[Qemu-devel] [PATCH v13 08/12] target-arm: kvm64: inject synchronous External Abort

2017-11-27 Thread Dongjiu Geng
Add synchronous external abort injection logic, setup spsr_elx, esr_elx, PSTATE, elr_elx etc, when switch to guest, guest will jump to the synchronous external abort vector table entry. The ESR_ELx.DFSC is set to Synchronous external abort(0x10), and ESR_ELx.FnV is set to not valid(0x1), which wil

[Qemu-devel] [PATCH v13 11/12] hw/arm/virt: Add RAS platform version for migration

2017-11-27 Thread Dongjiu Geng
Support this feature since version 2.10, disable it by default in the old version. Signed-off-by: Dongjiu Geng --- Address Shannon's comments to add platform version in [1]. [1]: https://lkml.org/lkml/2017/8/25/821 --- hw/arm/virt-acpi-build.c | 14 +- hw/arm/virt.c| 4

Re: [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band

2017-11-27 Thread Peter Xu
On Mon, Nov 27, 2017 at 10:44:26AM +, Dr. David Alan Gilbert wrote: [...] > > > > > > But then I added a break on pthread_mutex_lock, and I've got > > > this set caused by qemu_start_incoming_migration sending a > > > MIGRATION_STATUS_SETUP event: > > > > > > #1 0x55ba6eba in qemu_

[Qemu-devel] [PATCH v13 09/12] Move related hwpoison page function to accel/kvm/ folder

2017-11-27 Thread Dongjiu Geng
kvm_hwpoison_page_add() and kvm_unpoison_all() will be used by both X86 and ARM platforms, so move them to a common accel/kvm/ folder to avoid duplicate code. Signed-off-by: Dongjiu Geng --- Address Peter's comments to move related hwpoison page function to accel/kvm folder in [1] Address Paolo'

[Qemu-devel] [PATCH v13 12/12] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2017-11-27 Thread Dongjiu Geng
Add SIGBUS signal handler. In this handler, it checks the SIGBUS type, translate the host VA which is delivered by host to guest PA, then fill this PA to CPER and fill the CPER to guest APEI GHES memory, finally notify guest according the SIGBUS type. There are two kinds of SIGBUS that QEMU need to

[Qemu-devel] [PATCH v13 10/12] ARM: ACPI: Add _E04 for hardware error device

2017-11-27 Thread Dongjiu Geng
In ARM platform we implements a notification of error events via a GPIO pin. In this case of GPIO-signaled events, an _AEI object lists the appropriate GPIO pin. GPIO pin 4 is used for hardware error device (PNP0C33), so add _E04 in ACPI DSDT table. When GPIO-pin 4 signaled a events, the guest ACP

[Qemu-devel] [PATCH v13 00/12] Add ARMv8 RAS virtualization support in QEMU

2017-11-27 Thread Dongjiu Geng
From: gengdongjiu In the ARMv8 platform, the CPU error type are synchronous external abort(SEA) and SError Interrupt (SEI). If guest happen exception, sometimes guest itself do the recovery is better, because host does not know guest's detailed info. For example, if a guest user-space applicat

Re: [Qemu-devel] [PATCH] util: add is_equal to UUID API

2017-11-27 Thread Roman Kagan
On Fri, Nov 24, 2017 at 06:34:03PM +0100, Thomas Huth wrote: > On 24.11.2017 15:32, Roman Kagan wrote: > > +++ b/tests/test-uuid.c > > @@ -116,6 +116,29 @@ static void test_uuid_is_null(void) > > g_assert_false(qemu_uuid_is_null(&uuid_not_null_2)); > > } > > > > +static void test_uuid_is_eq

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Cornelia Huck
On Mon, 27 Nov 2017 07:59:36 +0100 Thomas Huth wrote: > On 25.11.2017 14:49, Pierre Morel wrote: > > On 24/11/2017 07:19, Yi Min Zhao wrote: > >> > >> > >> 在 2017/11/23 下午8:18, Thomas Huth 写道: > >>> On 23.11.2017 13:07, Yi Min Zhao wrote: > Another question, does 'cpu' in cpu_to_le**(

Re: [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band

2017-11-27 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Mon, Nov 27, 2017 at 10:44:26AM +, Dr. David Alan Gilbert wrote: > > [...] > > > > > > > > > But then I added a break on pthread_mutex_lock, and I've got > > > > this set caused by qemu_start_incoming_migration sending a > > > > MIGRATION_STATUS_SET

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Thomas Huth
On 27.11.2017 11:09, Yi Min Zhao wrote: > > > 在 2017/11/27 下午2:59, Thomas Huth 写道: >> On 25.11.2017 14:49, Pierre Morel wrote: >>> On 24/11/2017 07:19, Yi Min Zhao wrote: 在 2017/11/23 下午8:18, Thomas Huth 写道: > On 23.11.2017 13:07, Yi Min Zhao wrote: >> 在 2017/11/23 下午6:33, Corne

Re: [Qemu-devel] [PATCH v3 1/2] virtio: check VirtQueue Vring object is set

2017-11-27 Thread Stefan Hajnoczi
On Sat, Nov 25, 2017 at 12:04:45AM +0530, P J P wrote: > @@ -1426,6 +1429,9 @@ hwaddr virtio_queue_get_addr(VirtIODevice *vdev, int n) > void virtio_queue_set_rings(VirtIODevice *vdev, int n, hwaddr desc, > hwaddr avail, hwaddr used) > { > +if (!vdev->vq[n].vring.

Re: [Qemu-devel] [PATCH for 2.11] virtio-net: don't touch virtqueue if vm is stopped

2017-11-27 Thread Stefan Hajnoczi
On Mon, Nov 27, 2017 at 11:26:34AM +0800, Jason Wang wrote: > > > On 2017年11月24日 18:44, Stefan Hajnoczi wrote: > > On Fri, Nov 24, 2017 at 10:57:11AM +0800, Jason Wang wrote: > > > On 2017年11月23日 18:59, Stefan Hajnoczi wrote: > > > > On Thu, Nov 23, 2017 at 11:37:46AM +0800, Jason Wang wrote: > >

Re: [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band

2017-11-27 Thread Peter Xu
On Mon, Nov 27, 2017 at 11:04:00AM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Mon, Nov 27, 2017 at 10:44:26AM +, Dr. David Alan Gilbert wrote: > > > > [...] > > > > > > > > > > > > But then I added a break on pthread_mutex_lock, and I've got > > > > >

Re: [Qemu-devel] [PATCH] util: add is_equal to UUID API

2017-11-27 Thread Daniel P. Berrange
On Fri, Nov 24, 2017 at 06:34:03PM +0100, Thomas Huth wrote: > On 24.11.2017 15:32, Roman Kagan wrote: > > It's going to be useful, in particular, in VMBus code massively using > > uuids aka GUIDs. > > > > Signed-off-by: Roman Kagan > > --- > > include/qemu/uuid.h | 2 ++ > > tests/test-uuid.c

Re: [Qemu-devel] [Qemu-block] [PATCH v4 for-2.11] QAPI & interop: Clarify events emitted by 'block-job-cancel'

2017-11-27 Thread Kevin Wolf
Am 21.11.2017 um 10:58 hat Kashyap Chamarthy geschrieben: > On Fri, Nov 17, 2017 at 07:54:44PM +0100, Kashyap Chamarthy wrote: > > +So there are two possible actions to take, after a 'mirror' job has > > +emitted the event ``BLOCK_JOB_READY``, indicating that the source and > > +target have reached

Re: [Qemu-devel] [PATCH 1/2] ARM: BUG if jumping to usermode address in kernel mode

2017-11-27 Thread Peter Maydell
On 27 November 2017 at 11:47, Russell King - ARM Linux wrote: > On Mon, Nov 27, 2017 at 11:16:06AM +0100, Cédric Le Goater wrote: >> Additional QEMU logging gives us : >> >> Ignoring attempt to switch CPSR_A flag from non-secure world with SCR.AW >> bit clear >> Ignoring attempt to switch CPS

Re: [Qemu-devel] [Qemu-block] [PATCH v5 for-2.11] QAPI & interop: Clarify events emitted by 'block-job-cancel'

2017-11-27 Thread Kevin Wolf
Am 21.11.2017 um 12:52 hat Kashyap Chamarthy geschrieben: > When you cancel an in-progress 'mirror' job (or "active `block-commit`") > with QMP `block-job-cancel`, it emits the event: BLOCK_JOB_CANCELLED. > However, when `block-job-cancel` is issued *after* `drive-mirror` has > indicated (via the e

Re: [Qemu-devel] [PATCH v5] nvme: Add tracing

2017-11-27 Thread Kevin Wolf
Am 25.11.2017 um 08:08 hat Doug Gale geschrieben: > Ping Stefan, do you expect this to go through a different tree than the tracing one? Kevin > On Thu, Nov 16, 2017 at 6:16 AM, Doug Gale wrote: > > I submitted it with git Nov 3 - the long lines issue with git-am > > should be resolved. Please

Re: [Qemu-devel] [PATCH v3] rcu: reduce more than 7MB heap memory by malloc_trim()

2017-11-27 Thread Paolo Bonzini
On 27/11/2017 04:06, Zhong Yang wrote: > #test command > ./qemu-system-x86_64 -enable-kvm -cpu host -m 2G -smp cpus=4,cores=4,\ >threads=1,sockets=1 -drive format=raw,\ >file=test.img,index=0,media=disk -nographic > > #without patch > root@in

Re: [Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-11-27 Thread Peter Maydell
On 26 November 2017 at 22:13, Brad Smith wrote: > Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). > > ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* > constants. ncurses 5.7 was released in 2008 and is now 9 years old. Why is OpenBSD still using suc

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-27 Thread Kevin Wolf
Am 24.11.2017 um 16:01 hat Vladimir Sementsov-Ogievskiy geschrieben: > John, Kevin, do we reach a consensus? Can we go on with this? I don't know the details of this, so I can't really offer a strong opinion. I gave a high-level perspective of what we're doing in other places and that's all I was

Re: [Qemu-devel] [PATCH] util: add is_equal to UUID API

2017-11-27 Thread Roman Kagan
On Mon, Nov 27, 2017 at 11:45:52AM +, Daniel P. Berrange wrote: > On Fri, Nov 24, 2017 at 06:34:03PM +0100, Thomas Huth wrote: > > On 24.11.2017 15:32, Roman Kagan wrote: > > > It's going to be useful, in particular, in VMBus code massively using > > > uuids aka GUIDs. > > > > > > Signed-off-b

[Qemu-devel] [PATCH v2] util: add is_equal to UUID API

2017-11-27 Thread Roman Kagan
It's going to be useful, in particular, in VMBus code massively using uuids aka GUIDs. Signed-off-by: Roman Kagan --- v1 -> v2: - drop dedicated testcase (for it was of no value) and incorporate is_null and is_equal assertions into uuid_generate testcase include/qemu/uuid.h | 2 ++ tests/te

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-27 Thread Cornelia Huck
On Fri, 24 Nov 2017 17:39:04 +0100 Halil Pasic wrote: > On 11/24/2017 05:15 PM, Cornelia Huck wrote: > >>> In theory this should work. > >>> > >>> In reality it seems more complicated. A per-device property is easy and > >>> can be > >>> inspected on the command line (e.g. -device virtio-blk-cc

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-27 Thread Cornelia Huck
On Mon, 27 Nov 2017 10:20:56 +0800 Dong Jia Shi wrote: > * Halil Pasic [2017-11-24 17:39:04 +0100]: > > > > > > > On 11/24/2017 05:15 PM, Cornelia Huck wrote: > > >>> In theory this should work. > > >>> > > >>> In reality it seems more complicated. A per-device property is easy and > > >>

Re: [Qemu-devel] [Qemu-block] [PATCH v5 for-2.11] QAPI & interop: Clarify events emitted by 'block-job-cancel'

2017-11-27 Thread Kashyap Chamarthy
On Mon, Nov 27, 2017 at 12:53:07PM +0100, Kevin Wolf wrote: > Am 21.11.2017 um 12:52 hat Kashyap Chamarthy geschrieben: [...] > > Signed-off-by: Kashyap Chamarthy > > Reviewed-by: Eric Blake > > > +(1) Issuing the command ``block-job-cancel`` (after it emits the event > > +``BLOCK_JOB_COMP

[Qemu-devel] [PATCH v2 1/2] qdev-properties: add UUID property type

2017-11-27 Thread Roman Kagan
UUIDs (GUIDs) are widely used in VMBus-related stuff, so a dedicated property type becomes helpful. The property accepts a string-formatted UUID or a special keyword "auto" meaning a randomly generated UUID; the latter is also the default when the property is not given a value explicitly. Signed-

[Qemu-devel] [PATCH v2 2/2] vmgenid: use UUID property type

2017-11-27 Thread Roman Kagan
Switch vmgenid device to use the UUID property type introduced in the previous patch for its 'guid' property. One semantic change it introduces is that post-realize modification of 'guid' via HMP or QMP will now be rejected with an error; however, according to docs/specs/vmgenid.txt this is actual

[Qemu-devel] [PATCH v2 0/2] add UUID property type

2017-11-27 Thread Roman Kagan
UUIDs (GUIDs) are widely used in VMBus-related stuff, so a dedicated property type becomes helpful. In the existing code, vmgenid can immediately profit from it. Roman Kagan (2): qdev-properties: add UUID property type vmgenid: use UUID property type v1 -> v2: - make the property default to

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-27 Thread Halil Pasic
On 11/27/2017 01:56 PM, Cornelia Huck wrote: > On Fri, 24 Nov 2017 17:39:04 +0100 > Halil Pasic wrote: > >> On 11/24/2017 05:15 PM, Cornelia Huck wrote: > In theory this should work. > > In reality it seems more complicated. A per-device property is easy and > can be > ins

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-27 Thread Cornelia Huck
On Mon, 27 Nov 2017 14:11:57 +0100 Halil Pasic wrote: > On 11/27/2017 01:56 PM, Cornelia Huck wrote: > > On Fri, 24 Nov 2017 17:39:04 +0100 > > Halil Pasic wrote: > > > >> On 11/24/2017 05:15 PM, Cornelia Huck wrote: > >>> (Unless we simply make this a "default cssid" prop after all - then

Re: [Qemu-devel] [PULL 0/2] ppc-for-2.11 queue 20171127

2017-11-27 Thread Peter Maydell
git://github.com/dgibson/qemu.git tags/ppc-for-2.11-20171127 > > for you to fetch changes up to e07cc1929515cfb808b5c2fcc60c079e6be110cf: > > target/ppc: Fix setting of cpu->compat_pvr on incoming migration > (2017-11-27 12:20:11 +1100) > > --

[Qemu-devel] [Bug 1728615] Re: qemu-io crashes with SIGABRT and Assertion `c->entries[i].offset != 0' failed

2017-11-27 Thread Thomas Huth
Fix has been merged here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=6bf45d59f98c898b7d79 ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/17

Re: [Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-11-27 Thread Brad Smith
On 11/27/2017 7:02 AM, Peter Maydell wrote: On 26 November 2017 at 22:13, Brad Smith wrote: Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* constants. ncurses 5.7 was released in 2008 and is now 9 y

[Qemu-devel] [Bug 1401798] Re: Qemu 2.2.0 savevm crash.

2017-11-27 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

Re: [Qemu-devel] [Qemu-block] [PATCH v5 for-2.11] QAPI & interop: Clarify events emitted by 'block-job-cancel'

2017-11-27 Thread Kevin Wolf
Am 27.11.2017 um 14:00 hat Kashyap Chamarthy geschrieben: > On Mon, Nov 27, 2017 at 12:53:07PM +0100, Kevin Wolf wrote: > > Am 21.11.2017 um 12:52 hat Kashyap Chamarthy geschrieben: > > [...] > > > > Signed-off-by: Kashyap Chamarthy > > > Reviewed-by: Eric Blake > > > > > +(1) Issuing the comm

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-27 Thread Christian Borntraeger
On 11/27/2017 02:19 PM, Cornelia Huck wrote: > On Mon, 27 Nov 2017 14:11:57 +0100 > Halil Pasic wrote: > >> On 11/27/2017 01:56 PM, Cornelia Huck wrote: >>> On Fri, 24 Nov 2017 17:39:04 +0100 >>> Halil Pasic wrote: >>> On 11/24/2017 05:15 PM, Cornelia Huck wrote: > > (Unless we

[Qemu-devel] [Bug 1399191] Re: Large VHDX image size

2017-11-27 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-27 Thread Halil Pasic
On 11/27/2017 02:19 PM, Cornelia Huck wrote: > On Mon, 27 Nov 2017 14:11:57 +0100 > Halil Pasic wrote: > >> On 11/27/2017 01:56 PM, Cornelia Huck wrote: >>> On Fri, 24 Nov 2017 17:39:04 +0100 >>> Halil Pasic wrote: >>> On 11/24/2017 05:15 PM, Cornelia Huck wrote: > > (Unless we

Re: [Qemu-devel] [dpdk-dev] [ovs-dev] [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type

2017-11-27 Thread Yuanhan Liu
On Fri, Nov 24, 2017 at 05:59:09PM +0800, Chen Hailin wrote: > Hi Aaron Conole && Jianfeng, > > The stp could not work in ovs-dpdk vhostuser. > Because the attached vhost device doesn't have MAC address. > > Now we have two ways to solve this problem. > 1. The vhost learns MAC address from packet

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Cornelia Huck
On Mon, 27 Nov 2017 12:02:55 +0100 Cornelia Huck wrote: > On Mon, 27 Nov 2017 07:59:36 +0100 > Thomas Huth wrote: > > > On 25.11.2017 14:49, Pierre Morel wrote: > > > On 24/11/2017 07:19, Yi Min Zhao wrote: > > >> > > >> > > >> 在 2017/11/23 下午8:18, Thomas Huth 写道: > > >>> On 23.11.201

Re: [Qemu-devel] [PULL 2/2] target/ppc: Fix setting of cpu->compat_pvr on incoming migration

2017-11-27 Thread Greg Kurz
On Mon, 27 Nov 2017 15:30:03 +1100 David Gibson wrote: > From: Suraj Jitindar Singh > > cpu->compat_pvr is used to store the current compat mode of the cpu. > > On the receiving side during incoming migration we check compatibility > with the compat mode by calling ppc_set_compat(). However we

Re: [Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-11-27 Thread Peter Maydell
On 27 November 2017 at 14:52, Brad Smith wrote: > On 11/27/2017 7:02 AM, Peter Maydell wrote: > >> On 26 November 2017 at 22:13, Brad Smith wrote: >>> >>> Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). >>> >>> ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-27 Thread Halil Pasic
On 11/27/2017 03:03 PM, Christian Borntraeger wrote: > > > On 11/27/2017 02:19 PM, Cornelia Huck wrote: >> On Mon, 27 Nov 2017 14:11:57 +0100 >> Halil Pasic wrote: >> >>> On 11/27/2017 01:56 PM, Cornelia Huck wrote: On Fri, 24 Nov 2017 17:39:04 +0100 Halil Pasic wrote: >

Re: [Qemu-devel] javac crash in user-mode emulation: races on page_unprotect()

2017-11-27 Thread Paolo Bonzini
On 24/11/2017 18:18, Peter Maydell wrote: > * threads A & B both try to do a write to a page with code in it at >the same time (ie which we've made non-writeable, so SEGV) > * they race into the signal handler with this faulting address > * thread A happens to get to page_unprotect() first a

Re: [Qemu-devel] javac crash in user-mode emulation: races on page_unprotect()

2017-11-27 Thread Peter Maydell
On 27 November 2017 at 15:38, Paolo Bonzini wrote: > On 24/11/2017 18:18, Peter Maydell wrote: >> * threads A & B both try to do a write to a page with code in it at >>the same time (ie which we've made non-writeable, so SEGV) >> * they race into the signal handler with this faulting address

[Qemu-devel] Question about RNG virtio device

2017-11-27 Thread Dennis Chen
Hello QEMU developers, We all know that there is a virtio-rng device can be para-virtualised from the host to guest in case of a real RNG HW exists in the host, my question is: Can we get some performance gain to use the 'virtio-rng' device if there isn't a real RNG HW in host, in this case, what'

Re: [Qemu-devel] javac crash in user-mode emulation: races on page_unprotect()

2017-11-27 Thread Paolo Bonzini
On 27/11/2017 15:47, Peter Maydell wrote: > On 27 November 2017 at 15:38, Paolo Bonzini wrote: >> On 24/11/2017 18:18, Peter Maydell wrote: >>> * threads A & B both try to do a write to a page with code in it at >>>the same time (ie which we've made non-writeable, so SEGV) >>> * they race in

Re: [Qemu-devel] glibc "linux: spawni.c: simplify error reporting to parent" breaks qemu-user/Windows Service For Linux

2017-11-27 Thread Adhemerval Zanella
On 26/11/2017 18:35, John Paul Adrian Glaubitz wrote: > On 11/26/2017 09:28 PM, John Paul Adrian Glaubitz wrote: >> I'm not sure yet what the actual problem is but I thought it should be >> necessary >> to point you at the problem. > > Ok, there is already a QEMU bug report for this [1]. > > Adr

[Qemu-devel] [PATCH] thread: move detach_thread from creating thread to created thread

2017-11-27 Thread linzhecheng
If we create a thread with QEMU_THREAD_DETACHED mode, QEMU may get a segfault in a low probability. The backtrace is: #0 0x7f46c60291d7 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x7f46c602a8c8 in __GI_abort () at abort.c:90 #2 0x008543c9

[Qemu-devel] tpm: swtpm and libtpms projects tagged

2017-11-27 Thread Stefan Berger
Hello! I tagged libtpms with TPM 1.2 and TPM 2 support with tag/v0.6.0-dev1 and swtpm with TPM 1.2 and TPM 2 support with tag/v0.1.0-dev2. The git repos of the respective projects are here: libtpms: https://github.com/stefanberger/libtpms swtpm: https://github.com/stefanberger/swtpm Note:

Re: [Qemu-devel] [PATCH 00/17] iotests: Fix iotests for weird formats/options

2017-11-27 Thread Max Reitz
On 2017-11-23 08:24, Fam Zheng wrote: > On Thu, 11/23 03:08, Max Reitz wrote: >> (I hate to write Python tests because the boilerplate seems so large and >> the debugging is so hard. But there is test 194 which shows that it is >> possible to write simple bash-like tests as well--and that is how

Re: [Qemu-devel] [PATCH] thread: move detach_thread from creating thread to created thread

2017-11-27 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH] thread: move detach_thread from creating thread to created thread Message-id: 20171127145936.15676-1-linzhech...@huawei.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing

Re: [Qemu-devel] javac crash in user-mode emulation: races on page_unprotect()

2017-11-27 Thread Peter Maydell
On 27 November 2017 at 15:53, Paolo Bonzini wrote: > On 27/11/2017 15:47, Peter Maydell wrote: >> I have a patch from rth based on an idea he and I came up with: >> we add a field to the PageDesc struct to store the thread id of >> the thread that last touches the flags. If you come into the >> se

Re: [Qemu-devel] [PATCH] thread: move detach_thread from creating thread to created thread

2017-11-27 Thread Daniel P. Berrange
On Mon, Nov 27, 2017 at 10:59:36PM +0800, linzhecheng wrote: > If we create a thread with QEMU_THREAD_DETACHED mode, QEMU may get a segfault > in a low probability. > > The backtrace is: > #0 0x7f46c60291d7 in __GI_raise (sig=sig@entry=6) at > ../nptl/sysdeps/unix/sysv/linux/raise.c:56 > #1

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-27 Thread Boris Fiuczynski
On 11/27/2017 03:13 PM, Halil Pasic wrote: On 11/27/2017 02:19 PM, Cornelia Huck wrote: On Mon, 27 Nov 2017 14:11:57 +0100 Halil Pasic wrote: On 11/27/2017 01:56 PM, Cornelia Huck wrote: On Fri, 24 Nov 2017 17:39:04 +0100 Halil Pasic wrote: On 11/24/2017 05:15 PM, Cornelia Huck wrote

Re: [Qemu-devel] javac crash in user-mode emulation: races on page_unprotect()

2017-11-27 Thread Paolo Bonzini
On 27/11/2017 16:06, Peter Maydell wrote: > On 27 November 2017 at 15:53, Paolo Bonzini wrote: >> On 27/11/2017 15:47, Peter Maydell wrote: >>> I have a patch from rth based on an idea he and I came up with: >>> we add a field to the PageDesc struct to store the thread id of >>> the thread that la

Re: [Qemu-devel] [PATCH] thread: move detach_thread from creating thread to created thread

2017-11-27 Thread Paolo Bonzini
On 27/11/2017 16:08, Daniel P. Berrange wrote: > We should just do > > if (mode == QEMU_THREAD_DETACHED) { > pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED); > } > This is true, but Zhecheng's patch (when fixed---see patchew's report) would also fix a similar race on

Re: [Qemu-devel] [PATCH] thread: move detach_thread from creating thread to created thread

2017-11-27 Thread no-reply
Hi, This series failed build test on ppc host. Please find the details below. Subject: [Qemu-devel] [PATCH] thread: move detach_thread from creating thread to created thread Type: series Message-id: 20171127145936.15676-1-linzhech...@huawei.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing sc

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Pierre Morel
On 27/11/2017 15:34, Cornelia Huck wrote: On Mon, 27 Nov 2017 12:02:55 +0100 Cornelia Huck wrote: On Mon, 27 Nov 2017 07:59:36 +0100 Thomas Huth wrote: On 25.11.2017 14:49, Pierre Morel wrote: On 24/11/2017 07:19, Yi Min Zhao wrote: 在 2017/11/23 下午8:18, Thomas Huth 写道: On 23.11.2017 13

Re: [Qemu-devel] glibc "linux: spawni.c: simplify error reporting to parent" breaks qemu-user/Windows Service For Linux

2017-11-27 Thread Peter Maydell
On 27 November 2017 at 12:57, Adhemerval Zanella wrote: > We found out this potential bogus assert on 2.27 development [1] which > resulted in two fixes [2][3]. > > It should not be an issue for generic posix_spawn usage where there is > no expectation system/user/program kills random pids (since

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Cornelia Huck
On Mon, 27 Nov 2017 16:24:08 +0100 Pierre Morel wrote: > On 27/11/2017 15:34, Cornelia Huck wrote: > > On Mon, 27 Nov 2017 12:02:55 +0100 > > Cornelia Huck wrote: > > > >> On Mon, 27 Nov 2017 07:59:36 +0100 > >> Thomas Huth wrote: > >> > >>> On 25.11.2017 14:49, Pierre Morel wrote: > >>>

Re: [Qemu-devel] [dpdk-dev] [ovs-dev] [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type

2017-11-27 Thread Tan, Jianfeng
On 11/27/2017 10:27 PM, Yuanhan Liu wrote: On Fri, Nov 24, 2017 at 05:59:09PM +0800, Chen Hailin wrote: Hi Aaron Conole && Jianfeng, The stp could not work in ovs-dpdk vhostuser. Because the attached vhost device doesn't have MAC address. Now we have two ways to solve this problem. 1. The vh

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Pierre Morel
On 27/11/2017 16:30, Cornelia Huck wrote: On Mon, 27 Nov 2017 16:24:08 +0100 Pierre Morel wrote: On 27/11/2017 15:34, Cornelia Huck wrote: On Mon, 27 Nov 2017 12:02:55 +0100 Cornelia Huck wrote: On Mon, 27 Nov 2017 07:59:36 +0100 Thomas Huth wrote: On 25.11.2017 14:49, Pierre Morel

[Qemu-devel] [PATCH for-2.11] block/nfs: fix nfs_client_open for filesize greater than 1TB

2017-11-27 Thread Peter Lieven
DIV_ROUND_UP(st.st_size, BDRV_SECTOR_SIZE) was overflowing ret (int) if st.st_size is greater than 1TB. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven --- block/nfs.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index 337fcd9..effc8

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Cornelia Huck
On Mon, 27 Nov 2017 16:53:04 +0100 Pierre Morel wrote: > On 27/11/2017 16:30, Cornelia Huck wrote: > > On Mon, 27 Nov 2017 16:24:08 +0100 > > Pierre Morel wrote: > > > >> On 27/11/2017 15:34, Cornelia Huck wrote: > >>> On Mon, 27 Nov 2017 12:02:55 +0100 > >>> Cornelia Huck wrote: > >>>

Re: [Qemu-devel] glibc "linux: spawni.c: simplify error reporting to parent" breaks qemu-user/Windows Service For Linux

2017-11-27 Thread Adhemerval Zanella
On 27/11/2017 13:24, Peter Maydell wrote: > On 27 November 2017 at 12:57, Adhemerval Zanella > wrote: >> We found out this potential bogus assert on 2.27 development [1] which >> resulted in two fixes [2][3]. >> >> It should not be an issue for generic posix_spawn usage where there is >> no expe

Re: [Qemu-devel] [PATCH v6 00/26] tcg: generic vector operations

2017-11-27 Thread Timothy Pearson
Just as a note, I've been watching these series with great interest. Once the changes settle down / are mergeable we will be looking to implement vector <--> vector support between a couple of other architectures. Thanks for working on this! On 11/21/2017 03:25 PM, Richard Henderson wrote: > Quit

Re: [Qemu-devel] glibc "linux: spawni.c: simplify error reporting to parent" breaks qemu-user/Windows Service For Linux

2017-11-27 Thread John Paul Adrian Glaubitz
On 11/27/2017 05:07 PM, Adhemerval Zanella wrote:> However I am not very compelled to change internal posix_spawn on GLIBC on Linux mainly because it uses a slight less resources than the generic POSIX one (check e83be730910c) and it works on Linux kernel as expected. But it breaks QEMU and Mi

[Qemu-devel] [PATCH] pci: removed the is_express field since a uniform interface was inserted

2017-11-27 Thread Yoni Bettan
* according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we don't need this field anymore Signed-off-by: Yoni Bettan --- hw/block/nvme.c| 1 - hw/net/e1000e.c

Re: [Qemu-devel] [dpdk-dev] [ovs-dev] [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type

2017-11-27 Thread Aaron Conole
Yuanhan Liu writes: > On Fri, Nov 24, 2017 at 05:59:09PM +0800, Chen Hailin wrote: >> Hi Aaron Conole && Jianfeng, >> >> The stp could not work in ovs-dpdk vhostuser. >> Because the attached vhost device doesn't have MAC address. >> >> Now we have two ways to solve this problem. >> 1. The vhost

Re: [Qemu-devel] glibc "linux: spawni.c: simplify error reporting to parent" breaks qemu-user/Windows Service For Linux

2017-11-27 Thread Adhemerval Zanella
On 27/11/2017 14:10, John Paul Adrian Glaubitz wrote: > On 11/27/2017 05:07 PM, Adhemerval Zanella wrote:> However I am not very > compelled to change internal posix_spawn >> on GLIBC on Linux mainly because it uses a slight less resources >> than the generic POSIX one (check e83be730910c) and i

Re: [Qemu-devel] [dpdk-dev] [ovs-dev] [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type

2017-11-27 Thread Tan, Jianfeng
On 11/28/2017 12:14 AM, Aaron Conole wrote: Yuanhan Liu writes: On Fri, Nov 24, 2017 at 05:59:09PM +0800, Chen Hailin wrote: Hi Aaron Conole && Jianfeng, The stp could not work in ovs-dpdk vhostuser. Because the attached vhost device doesn't have MAC address. Now we have two ways to solve

Re: [Qemu-devel] [PATCH v2 2/2] vmgenid: use UUID property type

2017-11-27 Thread Ben Warren via Qemu-devel
It looks like you dropped Marc-André and my Reviewed-by lines. Please put them back. > On Nov 27, 2017, at 5:05 AM, Roman Kagan wrote: > > Switch vmgenid device to use the UUID property type introduced in the > previous patch for its 'guid' property. > > One semantic change it introduces is t

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Pierre Morel
On 27/11/2017 17:02, Cornelia Huck wrote: On Mon, 27 Nov 2017 16:53:04 +0100 Pierre Morel wrote: On 27/11/2017 16:30, Cornelia Huck wrote: On Mon, 27 Nov 2017 16:24:08 +0100 Pierre Morel wrote: On 27/11/2017 15:34, Cornelia Huck wrote: On Mon, 27 Nov 2017 12:02:55 +0100 Cornelia Huck

Re: [Qemu-devel] [PATCH v2 2/2] vmgenid: use UUID property type

2017-11-27 Thread Marc-André Lureau
On Mon, Nov 27, 2017 at 2:05 PM, Roman Kagan wrote: > Switch vmgenid device to use the UUID property type introduced in the > previous patch for its 'guid' property. > > One semantic change it introduces is that post-realize modification of > 'guid' via HMP or QMP will now be rejected with an erro

  1   2   >