[Qemu-devel] [RFC v4 24/27] qmp: add command "x-oob-test"

2017-11-16 Thread Peter Xu
This command is only used to test OOB functionality. It should not be used for any other purposes. Signed-off-by: Peter Xu --- qapi-schema.json | 18 ++ qmp.c| 16 2 files changed, 34 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json in

Re: [Qemu-devel] [Libguestfs] [qemu-img] support for XVA

2017-11-16 Thread Richard W.M. Jones
I think it's even possible to modify that shell script to pipe into nbdkit and from there to ‘qemu-img convert’. I'm too lazy to actually do that right now, but the basic idea is here: https://rwmj.wordpress.com/2014/10/14/streaming-nbd-server/ You'll probably have to add ‘-m 1’ to the qemu-im

[Qemu-devel] [RFC v4 27/27] tests: qmp-test: add oob test

2017-11-16 Thread Peter Xu
Test the new OOB capability. Here we used the new "x-oob-test" command. Firstly, we send a lock=true and oob=false command to hang the main thread. Then send another lock=false and oob=true command (which will be run inside parser this time) to free that hanged command. Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH v6 5/5] fw_cfg: write vmcoreinfo details

2017-11-16 Thread Marc-André Lureau
Hi - Original Message - > On Mon, Nov 13, 2017 at 08:29:58PM +0100, Marc-André Lureau wrote: > > If the "etc/vmcoreinfo" fw_cfg file is present and we are not running > > the kdump kernel, write the addr/size of the vmcoreinfo ELF note. > > > > Signed-off-by: Marc-André Lureau > > Review

Re: [Qemu-devel] [PULL for-2.11 0/3] tcg: user-mode memory helper fixes

2017-11-16 Thread Peter Maydell
On 15 November 2017 at 12:35, Richard Henderson wrote: > Fixes the issue that Peter found wrt javac on aarch64-linux-user. > > > r~ > > > The following changes since commit 1fa0f627d03cd0d0755924247cafeb42969016bf: > > Update version for v2.11.0-rc1 release (2017-11-14 18:37:49 +) > > are av

Re: [Qemu-devel] [virtio-dev] [PATCH 1/1] virtio-balloon: include buffers and chached memory statistics

2017-11-16 Thread Yan Vugenfirer
Hello All, Michael asked me to comment regarding the possibility to get this statistics on Windows. By using Win32_OperatingSystem WMI class we can calculate the amount of cached memory (https://msdn.microsoft.com/en-us/library/aa394239(v=vs.85).aspx

Re: [Qemu-devel] [PATCH v3] net: Transmit zero UDP checksum as 0xFFFF

2017-11-16 Thread Ed Swierk via Qemu-devel
On Wed, Nov 15, 2017 at 7:55 PM, Eric Blake wrote: > > On 11/15/2017 09:07 PM, Ed Swierk via Qemu-devel wrote: > > This part below... > > > > > v3: > > > > Leave net_tx_pkt_update_ip_checksums() alone since it's only computing > > a partial sum of the IP pseudo-header. > > > > Rename wrapper to ne

Re: [Qemu-devel] [Libguestfs] [qemu-img] support for XVA

2017-11-16 Thread Max Reitz
On 2017-11-16 11:08, Gandalf Corvotempesta wrote: > 2017-11-15 23:55 GMT+01:00 Max Reitz : >> https://xanclic.moe/convert-xva.rb -- does this work? >> (It seems to works on the two example images I found...) >> >> An example is in the code, you use it like this: >> >> $ ./convert-xva.rb ~/Downloads

[Qemu-devel] [PATCH v3 REPOST] net: Transmit zero UDP checksum as 0xFFFF

2017-11-16 Thread Ed Swierk via Qemu-devel
The checksum algorithm used by IPv4, TCP and UDP allows a zero value to be represented by either 0x and 0x. But per RFC 768, a zero UDP checksum must be transmitted as 0x because 0x is a special value meaning no checksum. Substitute 0x whenever a checksum is computed as zero wh

Re: [Qemu-devel] [virtio-dev] [PATCH 1/1] virtio-balloon: include buffers and chached memory statistics

2017-11-16 Thread Tomáš Golembiovský
On Thu, 16 Nov 2017 15:38:21 +0200 Yan Vugenfirer wrote: > Hello All, > > Michael asked me to comment regarding the possibility to get this statistics > on Windows. > By using Win32_OperatingSystem WMI class we can calculate the amount of > cached memory > (https://msdn.microsoft.com/en-us/li

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.11] throttle-groups: forget timer and schedule next TGM on detach

2017-11-16 Thread Stefan Hajnoczi
On Thu, Nov 16, 2017 at 11:21:50AM +, Stefan Hajnoczi wrote: > tg->any_timer_armed[] must be cleared when detaching pending timers from > the AioContext. Failure to do so leads to hung I/O because it looks > like there are still timers pending when in fact they have been removed. > > Other Th

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1

2017-11-16 Thread Peter Maydell
On 15 November 2017 at 18:17, Michael S. Tsirkin wrote: > The following changes since commit 1fa0f627d03cd0d0755924247cafeb42969016bf: > > Update version for v2.11.0-rc1 release (2017-11-14 18:37:49 +) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/ms

Re: [Qemu-devel] Effect of qemu-img convert -m and -W options

2017-11-16 Thread Stefan Hajnoczi
On Wed, Nov 15, 2017 at 11:52:46AM +, Richard W.M. Jones wrote: > [CC to qemu-devel since I'm obviously doing something wrong here, > I'm just not sure what.] > > I was getting ready to add multiple threads to ‘qemu-img convert’ (the > longest part of v2v conversions) when I noticed that it ha

[Qemu-devel] [Bug 1636217] Re: qemu-kvm 2.7 does not boot kvm VMs with virtio on top of VMware ESX

2017-11-16 Thread introom
This problem still exists as of now on Debian sid. Qemu version is "QEMU emulator version 2.10.1(Debian 1:2.10.0+dfsg-2)". for "-machine type=pc-i440fx-x" where x > 2.6, all stuck at boot if the interface is virtio. I use nested virtualization where the first level is VMWARE FUSION (might not b

Re: [Qemu-devel] Effect of qemu-img convert -m and -W options

2017-11-16 Thread Peter Lieven
Am 16.11.2017 um 15:47 schrieb Stefan Hajnoczi: On Wed, Nov 15, 2017 at 11:52:46AM +, Richard W.M. Jones wrote: [CC to qemu-devel since I'm obviously doing something wrong here, I'm just not sure what.] I was getting ready to add multiple threads to ‘qemu-img convert’ (the longest part of v

[Qemu-devel] [PATCH] ipmi: check ibe status before ibe outlen at ipmi_bmc_extern_handle_command

2017-11-16 Thread xinhua.Cao
When we always kill vm's ipmi_sim program. qemu will do handling chr_event to reconnect ipmi_sim. handling chain is chr_event -> continue_send -> qemu_chr_fe_write. if ipmi_sim program was killed again. then qemu_chr_fe_write will failed. then ibe's outlen and outbuf will not cleared. so if vcpu ha

Re: [Qemu-devel] Effect of qemu-img convert -m and -W options

2017-11-16 Thread Richard W.M. Jones
On Thu, Nov 16, 2017 at 02:47:46PM +, Stefan Hajnoczi wrote: > The threads you observed are the thread pool that performs > preadv(2)/pwritev(2) syscalls. The Linux AIO API could be used instead > and does not use threads for read and write operations. I guess if I used AIO then I wouldn't ge

Re: [Qemu-devel] Effect of qemu-img convert -m and -W options

2017-11-16 Thread Richard W.M. Jones
On Thu, Nov 16, 2017 at 03:51:29PM +0100, Peter Lieven wrote: > Afaik all writes to the same QCOW2 serialize because of the s->lock that > is held during the write. So its not suprising that there is no benefit from > mutliple threads as long as reading from the RAW file involves no delay. > Which

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1

2017-11-16 Thread Thomas Huth
On 16.11.2017 15:41, Peter Maydell wrote: > On 15 November 2017 at 18:17, Michael S. Tsirkin wrote: >> The following changes since commit 1fa0f627d03cd0d0755924247cafeb42969016bf: >> >> Update version for v2.11.0-rc1 release (2017-11-14 18:37:49 +) >> >> are available in the git repository a

[Qemu-devel] [PATCH v2 for-2.11] migration, xen: Fix block image lock issue on live migration

2017-11-16 Thread Anthony PERARD
When doing a live migration of a Xen guest with libxl, the images for block devices are locked by the original QEMU process, and this prevent the QEMU at the destination to take the lock and the migration fail. >From QEMU point of view, once the RAM of a domain is migrated, there is two QMP comman

Re: [Qemu-devel] QEMU terminates during reboot after memory unplug with vhost=on

2017-11-16 Thread Michael S. Tsirkin
On Thu, Nov 16, 2017 at 01:23:39PM +0100, Greg Kurz wrote: > Hi, > > I'm resurrecting a thread about a QEMU crash we're still hitting on ppc64. It > was reported to the list by Bharata 2 months ago: > > https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg03685.html > > "Hi, > > QEMU hits t

[Qemu-devel] [PATCH] hw/arm: Silence xlnx-ep108 deprecation warning during tests

2017-11-16 Thread Thomas Huth
The new deprecation warning for the xlnx-ep108 machine also pops up during "make check" which is kind of confusing. Silence it if testing mode is enabled. Signed-off-by: Thomas Huth --- Note: I slightly shortened the message so that the code still fits into the 80-columns limit. hw/arm/xlnx-z

Re: [Qemu-devel] [Nbd] [Qemu-block] How to online resize qemu disk with nbd protocol?

2017-11-16 Thread Eric Blake
On 11/16/2017 03:51 AM, Wouter Verhelst wrote: >> I also remember from talking with Vladimir during KVM Forum last month >> that one of the shortfalls of the NBD protocol is that you can only ever >> send a length of up to 32 bits on the command side (unless we introduce >> structured commands in

Re: [Qemu-devel] QEMU terminates during reboot after memory unplug with vhost=on

2017-11-16 Thread Greg Kurz
On Thu, 16 Nov 2017 17:28:44 +0200 "Michael S. Tsirkin" wrote: > On Thu, Nov 16, 2017 at 01:23:39PM +0100, Greg Kurz wrote: > > Hi, > > > > I'm resurrecting a thread about a QEMU crash we're still hitting on ppc64. > > It > > was reported to the list by Bharata 2 months ago: > > > > https://li

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1

2017-11-16 Thread Michael S. Tsirkin
On Thu, Nov 16, 2017 at 02:41:09PM +, Peter Maydell wrote: > On 15 November 2017 at 18:17, Michael S. Tsirkin wrote: > > The following changes since commit 1fa0f627d03cd0d0755924247cafeb42969016bf: > > > > Update version for v2.11.0-rc1 release (2017-11-14 18:37:49 +) > > > > are availab

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1

2017-11-16 Thread Daniel P. Berrange
On Thu, Nov 16, 2017 at 05:38:18PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 16, 2017 at 02:41:09PM +, Peter Maydell wrote: > > On 15 November 2017 at 18:17, Michael S. Tsirkin wrote: > > > The following changes since commit > > > 1fa0f627d03cd0d0755924247cafeb42969016bf: > > > > > > U

Re: [Qemu-devel] [PATCH] tests: report errors when iasl exits with non-zero status

2017-11-16 Thread Michael S. Tsirkin
On Wed, Oct 18, 2017 at 02:15:28PM +0100, Daniel P. Berrange wrote: > If iasl exits with non-zero status, the test unhelpfully just reports > that the AML did not match, because the data files it thought iasl > generated do not exist. This adds an explicit check for the exit status > of iasl and pr

Re: [Qemu-devel] [PATCH] test: fix detection of errors from iasl

2017-11-16 Thread Michael S. Tsirkin
On Wed, Oct 18, 2017 at 02:14:56PM +0100, Daniel P. Berrange wrote: > The conditional looking for errors while loading asl files would ignore > errors from loading the expected data, if the actual data succeeded. > > Signed-off-by: Daniel P. Berrange Problem is, some systems have a broken iasl.

Re: [Qemu-devel] QEMU terminates during reboot after memory unplug with vhost=on

2017-11-16 Thread Alex Williamson
On Thu, 16 Nov 2017 17:28:44 +0200 "Michael S. Tsirkin" wrote: > On Thu, Nov 16, 2017 at 01:23:39PM +0100, Greg Kurz wrote: > > Hi, > > > > I'm resurrecting a thread about a QEMU crash we're still hitting on ppc64. > > It > > was reported to the list by Bharata 2 months ago: > > > > https://li

Re: [Qemu-devel] [Qemu-block] segfault in parallel blockjobs (iotest 30)

2017-11-16 Thread Alberto Garcia
On Wed 15 Nov 2017 05:31:20 PM CET, Anton Nefedov wrote: >> I have the impression that one major source of headaches is the fact >> that the reopen queue contains nodes that don't need to be reopened at >> all. Ideally this should be detected early on in bdrv_reopen_queue(), so >> there's no chance

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1

2017-11-16 Thread Michael S. Tsirkin
On Thu, Nov 16, 2017 at 03:45:34PM +, Daniel P. Berrange wrote: > On Thu, Nov 16, 2017 at 05:38:18PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 16, 2017 at 02:41:09PM +, Peter Maydell wrote: > > > On 15 November 2017 at 18:17, Michael S. Tsirkin wrote: > > > > The following changes s

Re: [Qemu-devel] [RFC PATCH v2 01/21] ppc/xive: introduce a skeleton for the sPAPR XIVE interrupt controller

2017-11-16 Thread Cédric Le Goater
On 09/26/2017 05:54 AM, David Gibson wrote: > On Fri, Sep 22, 2017 at 02:42:07PM +0200, Cédric Le Goater wrote: >> On 09/22/2017 01:00 PM, David Gibson wrote: >>> On Tue, Sep 19, 2017 at 03:15:44PM +0200, Cédric Le Goater wrote: On 09/19/2017 04:27 AM, David Gibson wrote: > On Mon, Sep 11,

Re: [Qemu-devel] QEMU terminates during reboot after memory unplug with vhost=on

2017-11-16 Thread Michael S. Tsirkin
On Thu, Nov 16, 2017 at 08:53:45AM -0700, Alex Williamson wrote: > On Thu, 16 Nov 2017 17:28:44 +0200 > "Michael S. Tsirkin" wrote: > > > On Thu, Nov 16, 2017 at 01:23:39PM +0100, Greg Kurz wrote: > > > Hi, > > > > > > I'm resurrecting a thread about a QEMU crash we're still hitting on > > > pp

[Qemu-devel] 2 bytes of memory leaking due to MigrationParameters unshadowing

2017-11-16 Thread Christian Borntraeger
Markus, valgrind complains about the following two 1 byte memory leaks during migration: ==40773== 1 bytes in 1 blocks are definitely lost in loss record 3 of 2,127 ==40773==at 0x4834E60: malloc (vg_replace_malloc.c:299) ==40773==by 0x18B1A177: g_malloc (in /usr/lib64/libglib-2.0.so.0.50

Re: [Qemu-devel] QEMU terminates during reboot after memory unplug with vhost=on

2017-11-16 Thread Alex Williamson
On Thu, 16 Nov 2017 17:59:17 +0200 "Michael S. Tsirkin" wrote: > On Thu, Nov 16, 2017 at 08:53:45AM -0700, Alex Williamson wrote: > > On Thu, 16 Nov 2017 17:28:44 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Nov 16, 2017 at 01:23:39PM +0100, Greg Kurz wrote: > > > > Hi, > > > >

Re: [Qemu-devel] [PATCH v6 5/5] fw_cfg: write vmcoreinfo details

2017-11-16 Thread Michael S. Tsirkin
On Thu, Nov 16, 2017 at 08:34:23AM -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Mon, Nov 13, 2017 at 08:29:58PM +0100, Marc-André Lureau wrote: > > > If the "etc/vmcoreinfo" fw_cfg file is present and we are not running > > > the kdump kernel, write the addr/size of

Re: [Qemu-devel] [PATCH v6 3/5] fw_cfg: do DMA read operation

2017-11-16 Thread Michael S. Tsirkin
On Thu, Nov 16, 2017 at 08:17:12AM -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Mon, Nov 13, 2017 at 08:29:56PM +0100, Marc-André Lureau wrote: > > > Modify fw_cfg_read_blob() to use DMA if the device supports it. > > > Return errors, because the operation may fail.

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1

2017-11-16 Thread Peter Maydell
On 16 November 2017 at 15:56, Michael S. Tsirkin wrote: > On Thu, Nov 16, 2017 at 03:45:34PM +, Daniel P. Berrange wrote: >> On Thu, Nov 16, 2017 at 05:38:18PM +0200, Michael S. Tsirkin wrote: >> > I think it's test: fix detection of errors from iasl >> > I'll drop it for now. >> >> I thin

Re: [Qemu-devel] [PULL 00/11] Miscellaneous patches for QEMU 2.11-rc2

2017-11-16 Thread Peter Maydell
On 16 November 2017 at 11:59, Paolo Bonzini wrote: > The following changes since commit d24aaf2a2915424962fb101142f28fa4307f4740: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-11-06 11:24:14 +) > > are available in the Git repository at: >

Re: [Qemu-devel] [Qemu-block] segfault in parallel blockjobs (iotest 30)

2017-11-16 Thread Anton Nefedov
On 16/11/2017 6:54 PM, Alberto Garcia wrote: On Wed 15 Nov 2017 05:31:20 PM CET, Anton Nefedov wrote: I have the impression that one major source of headaches is the fact that the reopen queue contains nodes that don't need to be reopened at all. Ideally this should be detected early on in bdr

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1

2017-11-16 Thread Daniel P. Berrange
On Thu, Nov 16, 2017 at 04:10:22PM +, Peter Maydell wrote: > On 16 November 2017 at 15:56, Michael S. Tsirkin wrote: > > On Thu, Nov 16, 2017 at 03:45:34PM +, Daniel P. Berrange wrote: > >> On Thu, Nov 16, 2017 at 05:38:18PM +0200, Michael S. Tsirkin wrote: > >> > I think it's test: fi

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1

2017-11-16 Thread Michael S. Tsirkin
On Thu, Nov 16, 2017 at 04:10:22PM +, Peter Maydell wrote: > On 16 November 2017 at 15:56, Michael S. Tsirkin wrote: > > On Thu, Nov 16, 2017 at 03:45:34PM +, Daniel P. Berrange wrote: > >> On Thu, Nov 16, 2017 at 05:38:18PM +0200, Michael S. Tsirkin wrote: > >> > I think it's test: fi

Re: [Qemu-devel] QEMU terminates during reboot after memory unplug with vhost=on

2017-11-16 Thread Michael S. Tsirkin
On Thu, Nov 16, 2017 at 09:04:48AM -0700, Alex Williamson wrote: > > Range is unmapped by listener but device has not been reset yet, > > so it will get errors when attempting to access guest RAM. > > So IOMMU faults would occur if the device continues to try to DMA > into that range. Sloppy orde

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1

2017-11-16 Thread Peter Maydell
On 16 November 2017 at 16:13, Daniel P. Berrange wrote: > On Thu, Nov 16, 2017 at 04:10:22PM +, Peter Maydell wrote: >> If there are known-buggy iasl versions in the wild we could >> consider a configure test and treat buggy-iasl like no-iasl. > > iasl has long been broken on big-endian, but i

Re: [Qemu-devel] [Nbd] [Qemu-block] How to online resize qemu disk with nbd protocol?

2017-11-16 Thread Wouter Verhelst
On Thu, Nov 16, 2017 at 09:30:41AM -0600, Eric Blake wrote: > On 11/16/2017 03:51 AM, Wouter Verhelst wrote: > > >> I also remember from talking with Vladimir during KVM Forum last month > >> that one of the shortfalls of the NBD protocol is that you can only ever > >> send a length of up to 32 bi

[Qemu-devel] [PULL for-2.11 0/1] Block patches

2017-11-16 Thread Stefan Hajnoczi
The following changes since commit 8048082f7a11040a366942a2de8abb4c3d0020c9: Merge remote-tracking branch 'remotes/stefanberger/tags/pull-tpm-2017-11-15-1' into staging (2017-11-16 11:34:24 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-re

[Qemu-devel] [PULL for-2.11 1/1] throttle-groups: forget timer and schedule next TGM on detach

2017-11-16 Thread Stefan Hajnoczi
tg->any_timer_armed[] must be cleared when detaching pending timers from the AioContext. Failure to do so leads to hung I/O because it looks like there are still timers pending when in fact they have been removed. Other ThrottleGroupMembers might have requests pending too so it's necessary to sch

[Qemu-devel] [PATCH for-2.11] Fix build of console and GUI executables for Windows

2017-11-16 Thread Stefan Weil
It was broken by commit 8ecc89f6e792152496eccb684d6c8c48aba8027d which moved the SDL linker flags from macro libs_softmmu to macro SDL_LIBS. Signed-off-by: Stefan Weil --- Peter, can you apply this fix directly, or do you need a pull request? Regards Stefan Makefile.target | 2 +- 1 file chan

Re: [Qemu-devel] [Question] Qemu's Heap Becomes Very Large and Never Reduce Down

2017-11-16 Thread Zhong Yang
On Wed, Nov 15, 2017 at 02:18:55PM +0100, Paolo Bonzini wrote: > On 15/11/2017 04:14, Xulei (Stone) wrote: > > Hi, guys > > > > I met a strange problem, with qemu 2.8.1: > > qemu consumes too many heap memory after several operations and can not > > release them anymore:  > > hot pulg/unplug disk

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

2017-11-16 Thread Liu, Yi L
Hi David, On Tue, Nov 14, 2017 at 11:59:34AM +1100, David Gibson wrote: > On Mon, Nov 13, 2017 at 04:28:45PM +0800, Peter Xu wrote: > > On Mon, Nov 13, 2017 at 04:56:01PM +1100, David Gibson wrote: > > > On Fri, Nov 03, 2017 at 08:01:52PM +0800, Liu, Yi L wrote: > > > > From: Peter Xu > > > > >

[Qemu-devel] [PULL 0/9] pc, pci, virtio: fixes for rc1

2017-11-16 Thread Michael S. Tsirkin
The following changes since commit 6a7cb8c3d674815cab08d884740d203fded12249: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20171115' into staging (2017-11-16 12:45:14 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstrea

[Qemu-devel] [PULL 4/9] hw/pcie-pci-bridge: restrict to X86 and ARM

2017-11-16 Thread Michael S. Tsirkin
From: Marcel Apfelbaum The PCIE-PCI bridge is specific to "pure" PCIe systems (on QEMU we have X86 and ARM), it does not make sense to have it in other archs. Reported-by: Thomas Huth Signed-off-by: Marcel Apfelbaum Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Phil

[Qemu-devel] [PULL 5/9] tests/acpi-test-data: update _CRS in DSDT

2017-11-16 Thread Michael S. Tsirkin
commit dadf988e81b15065ac1d6dbaf4b87b5b80c7b670 hw/pci-host: Fix x86 Host Bridges 64bit PCI hole Added a 64 bit hole to _CRS of PCI0. Update the expected files accordingly. Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/DSDT | Bin 5098 -> 5144 bytes tests/acpi-test-d

Re: [Qemu-devel] [PATCH v17 6/6] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-11-16 Thread Wei Wang
On 11/15/2017 09:26 PM, Michael S. Tsirkin wrote: On Wed, Nov 15, 2017 at 11:47:58AM +0800, Wei Wang wrote: On 11/15/2017 05:21 AM, Michael S. Tsirkin wrote: On Tue, Nov 14, 2017 at 08:02:03PM +0800, Wei Wang wrote: On 11/14/2017 01:32 AM, Michael S. Tsirkin wrote: - guest2host_cmd: written b

[Qemu-devel] [PULL 2/9] pci: Initialize pci_dev->name before use

2017-11-16 Thread Michael S. Tsirkin
From: Alexey Kardashevskiy This moves pci_dev->name initialization earlier so pci_dev->bus_master_as could get a name instead of an empty string. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Xu Signed-off-by: Alexey Kardashevskiy Reviewed-by: Michael S. Tsirkin Signed-off-by: Micha

[Qemu-devel] [PULL 3/9] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

2017-11-16 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Currently there is no MMIO range over 4G reserved for PCI hotplug. Since the 32bit PCI hole depends on the number of cold-plugged PCI devices and other factors, it is very possible is too small to hotplug PCI devices with large BARs. Fix it by reserving 2G for I4400FX chip

[Qemu-devel] [PULL 1/9] fix: unrealize virtio device if we fail to hotplug it

2017-11-16 Thread Michael S. Tsirkin
From: linzhecheng If we fail to hotplug virtio-blk device and then suspend or shutdown VM, qemu is likely to crash. Re-production steps: 1. Run VM named vm001 2. Create a virtio-blk.xml which contains wrong configurations: 3. Run command : virsh attach-device vm001 virtio-blk.xml erro

[Qemu-devel] [PULL 6/9] NUMA: Enable adding NUMA node implicitly

2017-11-16 Thread Michael S. Tsirkin
From: Dou Liyang Linux and Windows need ACPI SRAT table to make memory hotplug work properly, however currently QEMU doesn't create SRAT table if numa options aren't present on CLI. Which breaks both linux and windows guests in certain conditions: * Windows: won't enable memory hotplug without

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1

2017-11-16 Thread Thomas Huth
On 16.11.2017 17:15, Peter Maydell wrote: > On 16 November 2017 at 16:13, Daniel P. Berrange wrote: >> On Thu, Nov 16, 2017 at 04:10:22PM +, Peter Maydell wrote: >>> If there are known-buggy iasl versions in the wild we could >>> consider a configure test and treat buggy-iasl like no-iasl. >>

[Qemu-devel] [PULL 7/9] vmcoreinfo: put it in the 'misc' device category

2017-11-16 Thread Michael S. Tsirkin
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/misc/vmcoreinfo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/vmcoreinfo.c b/hw/misc/vmcoreinfo.c index a618e12..31db57a 100644 --- a/hw/misc/vmcor

Re: [Qemu-devel] [RFC PATCH v2 01/21] ppc/xive: introduce a skeleton for the sPAPR XIVE interrupt controller

2017-11-16 Thread Cédric Le Goater
On 09/26/2017 11:45 AM, Benjamin Herrenschmidt wrote: > On Tue, 2017-09-26 at 13:54 +1000, David Gibson wrote: Which ones? My impression was that there needed to be at least #cpus * #priority-levels EQs, but there could be more than that, >>> >>> euh no, not in spapr mode at least.

[Qemu-devel] [PULL 8/9] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets

2017-11-16 Thread Michael S. Tsirkin
From: Marc-André Lureau vmcoreinfo is built for all targets. However, it requires fw_cfg with DMA operations support (write operation). Restrict vmcoreinfo exposure to architectures that are supporting FW_CFG_DMA, that is arm-virt and x86 only atm. Signed-off-by: Marc-André Lureau Reviewed-by:

Re: [Qemu-devel] [PATCH v8 10/14] migration: add postcopy migration of dirty bitmaps

2017-11-16 Thread Dr. David Alan Gilbert
* John Snow (js...@redhat.com) wrote: > > > On 10/30/2017 12:33 PM, Vladimir Sementsov-Ogievskiy wrote: > > Postcopy migration of dirty bitmaps. Only named dirty bitmaps, > > associated with root nodes and non-root named nodes are migrated. > > > > If destination qemu is already containing a dir

Re: [Qemu-devel] [PULL 6/9] NUMA: Enable adding NUMA node implicitly

2017-11-16 Thread Thadeu Lima de Souza Cascardo
Acked-by: Thadeu Lima de Souza Cascardo

[Qemu-devel] [PULL 9/9] tests/bios-tables-test: Fix endianess problems when passing data to iasl

2017-11-16 Thread Michael S. Tsirkin
From: Thomas Huth The bios-tables-test was writing out files that we pass to iasl in with the wrong endianness in the header when running on a big endian host. So instead of storing mixed endian information in our structures, let's keep everything in little endian and byte-swap it only when we ne

[Qemu-devel] [PATCH v2 4/4] iotests: 030: add compressed block-stream test

2017-11-16 Thread Anton Nefedov
Signed-off-by: Anton Nefedov --- tests/qemu-iotests/030 | 66 +- tests/qemu-iotests/030.out | 4 +-- 2 files changed, 67 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030 index 457984b..831d6f3 100755 --- a

[Qemu-devel] [PATCH v2 0/4] compressed block-stream

2017-11-16 Thread Anton Nefedov
v2: - 1st patch omitted (applied to 2.11) - remarks applied v1: http://lists.nongnu.org/archive/html/qemu-devel/2017-11/msg02515.html It might be useful to compress images during block-stream; this way the user can merge compressed images of a backing chain and the result will remain compress

[Qemu-devel] [PATCH v2 1/4] qcow2: multiple clusters write compressed

2017-11-16 Thread Anton Nefedov
From: Pavel Butsykin At the moment, qcow2_co_pwritev_compressed can process the requests size less than or equal to one cluster. This patch added possibility to write compressed data in the QCOW2 more than one cluster. The implementation is simple, we just split large requests into separate clust

[Qemu-devel] [PATCH v2 3/4] block-stream: add compress option

2017-11-16 Thread Anton Nefedov
It might be useful to compress images during block-stream; this way the user can merge compressed images of a backing chain and the result will remain compressed. Signed-off-by: Anton Nefedov --- qapi/block-core.json | 4 include/block/block_int.h | 4 +++- block/stream.c

[Qemu-devel] [PATCH v2 2/4] block: support compressed write for copy-on-read

2017-11-16 Thread Anton Nefedov
Signed-off-by: Anton Nefedov Reviewed-by: Max Reitz --- block/io.c | 23 +-- block/trace-events | 2 +- 2 files changed, 18 insertions(+), 7 deletions(-) diff --git a/block/io.c b/block/io.c index 3d5ef2c..2ba62a3 100644 --- a/block/io.c +++ b/block/io.c @@ -953,7 +

Re: [Qemu-devel] [PATCH] ipmi: check ibe status before ibe outlen at ipmi_bmc_extern_handle_command

2017-11-16 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] ipmi: check ibe status before ibe outlen at ipmi_bmc_extern_handle_command Type: series Message-id: 20171116052511.16236-1-caoxin...@huawei.com === TEST SCRIPT BEGIN ==

Re: [Qemu-devel] [PATCH] hw/arm: Silence xlnx-ep108 deprecation warning during tests

2017-11-16 Thread Wei Huang
On 11/16/2017 09:29 AM, Thomas Huth wrote: > The new deprecation warning for the xlnx-ep108 machine also pops up > during "make check" which is kind of confusing. Silence it if testing > mode is enabled. > > Signed-off-by: Thomas Huth > --- > Note: I slightly shortened the message so that the

Re: [Qemu-devel] [PATCH v2 1/2] Fix eepro100 simple transmission mode

2017-11-16 Thread Thomas Huth
On 06.11.2017 21:35, Mike Nawrocki wrote: > The simple transmission mode was treating the area immediately after the > transmit command block (TCB) as if it were a transmit buffer descriptor, > when in reality it is simply the packet data. This change simply copies > the data following the TCB into

Re: [Qemu-devel] [PATCH] ipmi: check ibe status before ibe outlen at ipmi_bmc_extern_handle_command

2017-11-16 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] ipmi: check ibe status before ibe outlen at ipmi_bmc_extern_handle_command Type: series Message

[Qemu-devel] [PATCH v1 for-2.11 2/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)

2017-11-16 Thread David Hildenbrand
Currently, single threaded TCG with > 1 VCPU gets stuck during IPL, when the bios tries to switch to the loaded kernel via DIAG 308. pause_all_vcpus()/resume_all_vcpus() should not be called from a VCPU. And there is also no need for it. run_on_cpu() will make sure that the CPUs exit KVM/TCG, whe

Re: [Qemu-devel] [PATCH for-2.11] target/arm: Report GICv3 sysregs present in ID registers if needed

2017-11-16 Thread Alistair Francis
On Wed, Nov 15, 2017 at 3:57 AM, Peter Maydell wrote: > On 15 November 2017 at 01:14, Alistair Francis wrote: >> On Tue, Nov 7, 2017 at 7:01 AM, Peter Maydell >> wrote: >>> The CPU ID registers ID_AA64PFR0_EL1, ID_PFR1_EL1 and ID_PFR1 >>> have a field for reporting presence of GICv3 system regi

[Qemu-devel] [PATCH v1 for-2.11 1/3] s390x: fix storing CPU status (again)

2017-11-16 Thread David Hildenbrand
Looks like the last fix + cleanup introduced another bug. (for now Linux guests don't seem to care) - we store the crs into ars. Fixes: 947a38bd6f13 ("s390x/kvm: fix and cleanup storing CPU status") Signed-off-by: David Hildenbrand --- target/s390x/helper.c | 2 +- 1 file changed, 1 insertion(+)

[Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308

2017-11-16 Thread David Hildenbrand
First one also applies to KVM SIGP handling. The other two only apply to TCG (allowing to IPL from disk with more than 1 VCPU- I never tested that before). David Hildenbrand (3): s390x: fix storing CPU status (again) s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG) s390x/tcg: fix

[Qemu-devel] [PATCH v1 for-2.11 3/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (MTTCG)

2017-11-16 Thread David Hildenbrand
Currently, multi threaded TCG with > 1 VCPU gets stuck during IPL, when the bios tries to switch to the loaded kernel via DIAG 308. As run_on_cpu() is used, we run into a deadlock after handling the reset. We need the iolock (just like KVM). Signed-off-by: David Hildenbrand --- target/s390x/mis

Re: [Qemu-devel] [PATCH] hw/arm: Silence xlnx-ep108 deprecation warning during tests

2017-11-16 Thread Alistair Francis
On Thu, Nov 16, 2017 at 7:29 AM, Thomas Huth wrote: > The new deprecation warning for the xlnx-ep108 machine also pops up > during "make check" which is kind of confusing. Silence it if testing > mode is enabled. > > Signed-off-by: Thomas Huth > --- > Note: I slightly shortened the message so th

Re: [Qemu-devel] Effect of qemu-img convert -m and -W options

2017-11-16 Thread Stefan Hajnoczi
On Thu, Nov 16, 2017 at 3:12 PM, Richard W.M. Jones wrote: > On Thu, Nov 16, 2017 at 03:51:29PM +0100, Peter Lieven wrote: >> Afaik all writes to the same QCOW2 serialize because of the s->lock that >> is held during the write. So its not suprising that there is no benefit from >> mutliple threads

Re: [Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308

2017-11-16 Thread Cornelia Huck
On Thu, 16 Nov 2017 18:05:23 +0100 David Hildenbrand wrote: > First one also applies to KVM SIGP handling. The other two only > apply to TCG (allowing to IPL from disk with more than 1 VCPU- I > never tested that before). > > David Hildenbrand (3): > s390x: fix storing CPU status (again) > s

Re: [Qemu-devel] Effect of qemu-img convert -m and -W options

2017-11-16 Thread Stefan Hajnoczi
On Thu, Nov 16, 2017 at 3:10 PM, Richard W.M. Jones wrote: > On Thu, Nov 16, 2017 at 02:47:46PM +, Stefan Hajnoczi wrote: >> The threads you observed are the thread pool that performs >> preadv(2)/pwritev(2) syscalls. The Linux AIO API could be used instead >> and does not use threads for rea

Re: [Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308

2017-11-16 Thread David Hildenbrand
On 16.11.2017 18:23, Cornelia Huck wrote: > On Thu, 16 Nov 2017 18:05:23 +0100 > David Hildenbrand wrote: > >> First one also applies to KVM SIGP handling. The other two only >> apply to TCG (allowing to IPL from disk with more than 1 VCPU- I >> never tested that before). >> >> David Hildenbrand

Re: [Qemu-devel] [PATCH v1 for-2.11 2/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)

2017-11-16 Thread Alex Bennée
David Hildenbrand writes: > Currently, single threaded TCG with > 1 VCPU gets stuck during IPL, when > the bios tries to switch to the loaded kernel via DIAG 308. > > pause_all_vcpus()/resume_all_vcpus() should not be called from a VCPU. > > And there is also no need for it. run_on_cpu() will ma

[Qemu-devel] [PATCH 00/10] I/O tests cleanups

2017-11-16 Thread Cleber Rosa
Hi all, This is a collection of cleanups, simplifications, and hopefully improvements to the I/O tests. Please don't mind the "change noise": this almost qualifies as a collection of trivial patches. It skips that category (of trivial patches) because it proposes a few conceptual changes to how

[Qemu-devel] [PATCH 02/10] qemu-iotests: fix filename containing checks

2017-11-16 Thread Cleber Rosa
Commit cce293a2945 moved some functions from common.config to common.rc, but the error messages still reference the old file location. Signed-off-by: Cleber Rosa --- tests/qemu-iotests/common.rc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/common.rc

[Qemu-devel] [PATCH 08/10] qemu-iotests: clean up double comment characters

2017-11-16 Thread Cleber Rosa
This is a syntactic only change, just to make it consistent with the style used on all other tests. Signed-off-by: Cleber Rosa --- tests/qemu-iotests/048 | 37 ++--- tests/qemu-iotests/074 | 40 2 files changed, 38 insertio

[Qemu-devel] [PATCH 01/10] qemu-iotests: make execution of tests agnostic to test type

2017-11-16 Thread Cleber Rosa
check makes a distinction on how it runs Python based tests. The current approach is inconsistent because: 1) a large number of Python tests are already set as executable files (eg: 030, 040, 041, 044, 045, 055, 056, 057, 065, 093, 118, 147, 149, 155, 165 and 194) 2) a smaller number of Python t

[Qemu-devel] [PATCH 03/10] qemu-iotests: be strict with expected output

2017-11-16 Thread Cleber Rosa
The contract between runner (check) and test is one that accepts some minor differences in the expcted output, as the comparison method employed is a "diff -w". This is an exception to a clearer and more straightforward rule of just requiring the generated output to be *equal* (and not similar) to

[Qemu-devel] [PATCH 07/10] qemu-iotests: remove the concept of $seq.full (and boiler plate code)

2017-11-16 Thread Cleber Rosa
The $seq.full file, in theory, should contain the full output of a test error. In practice, it's only used on a single test, and the boiler plate code to clean it up plagues all other tests. Let's remove the concept altogether, and record the failure in the output itself for the one test using th

[Qemu-devel] [PATCH 04/10] qemu-iotests: include (source) filters from common.rc

2017-11-16 Thread Cleber Rosa
There's an explicit dependency from common.rc on common.filters, that is, it consumes functions defined there. Just like common.config is included in common.rc, it makes sense to also sense common.filter. This drops the requirement on individual tests to include common.filter, reducing the amount

[Qemu-devel] [PATCH 10/10] qemu-iotests: add section on how to write a new I/O test

2017-11-16 Thread Cleber Rosa
This adds some basic information on how to write a new test. I'm aware that some of the information in the wiki (Testing/QemuIoTests) could also belong here. Since copying content over won't generate much interesting feedback, the goal here is to get feedback on the sample_test_templates, general

[Qemu-devel] [PATCH 09/10] qemu-iotests: remove unused "here" variable

2017-11-16 Thread Cleber Rosa
Another legacy variable that did not convince me it has any purpose whatsoever. Signed-off-by: Cleber Rosa --- tests/qemu-iotests/001 | 1 - tests/qemu-iotests/002 | 1 - tests/qemu-iotests/003 | 1 - tests/qemu-iotests/004 | 1 - tests/qemu-iotests/005 | 1 - tests/qemu-iotests/007 | 1 - tests

[Qemu-devel] [PATCH 05/10] qemu-iotests: define functions used in _cleanup() before its use

2017-11-16 Thread Cleber Rosa
The functions used in _cleanup() come from common.rc, which currently gets sourced after _cleanup() is defined and registered as a signal handler. When _cleanup() is executed, it has no valid references to those functions, as BASH won't resolve the reference at that time. While at it, also fix so

[Qemu-devel] [PATCH 06/10] qemu-iotests: turn owner variable into a comment

2017-11-16 Thread Cleber Rosa
This variables has no real use. To avoid pretending it does, while still keeping the information, let's turn it into a comment. The format chosen is the one already being used on tests 149 and 194. Signed-off-by: Cleber Rosa --- tests/qemu-iotests/001 | 5 ++--- tests/qemu-iotests/002 | 5 ++--

Re: [Qemu-devel] [PATCH v1 for-2.11 2/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)

2017-11-16 Thread David Hildenbrand
On 16.11.2017 18:05, David Hildenbrand wrote: > Currently, single threaded TCG with > 1 VCPU gets stuck during IPL, when > the bios tries to switch to the loaded kernel via DIAG 308. > > pause_all_vcpus()/resume_all_vcpus() should not be called from a VCPU. > > And there is also no need for it. r

Re: [Qemu-devel] [PATCH v2 1/2] Fix eepro100 simple transmission mode

2017-11-16 Thread Thomas Huth
On 16.11.2017 17:59, Thomas Huth wrote: > On 06.11.2017 21:35, Mike Nawrocki wrote: >> The simple transmission mode was treating the area immediately after the >> transmit command block (TCB) as if it were a transmit buffer descriptor, >> when in reality it is simply the packet data. This change si

[Qemu-devel] [PATCH v2 0/7] s390x/pci: Improve zPCI to cover more cases

2017-11-16 Thread Pierre Morel
This patch fixes the following BUG: Even a guest is able to detect virtio_pci device, the init function the Linux virtio_pci driver will hang because zPCI does not support the subregions used by virtio_pci. It follows that right now the PCI support is very limited (e.g. pass through of a host vfio

[Qemu-devel] [PATCH v2 2/7] s390x/pci: rework PCI STORE

2017-11-16 Thread Pierre Morel
Enhance the fault detection, correction of the fault reporting. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao Signed-off-by: Pierre Morel --- hw/s390x/s390-pci-inst.c | 39 ++- 1 file changed, 22 insertions(+), 17 deletions(-) diff --git a/hw/s390x/s

<    1   2   3   >