On 16 November 2017 at 15:56, Michael S. Tsirkin <m...@redhat.com> wrote: > On Thu, Nov 16, 2017 at 03:45:34PM +0000, Daniel P. Berrange wrote: >> On Thu, Nov 16, 2017 at 05:38:18PM +0200, Michael S. Tsirkin wrote: >> > I think it's test: fix detection of errors from iasl >> > I'll drop it for now. >> >> I think that patch is merely exposing a failure that has always >> happened, but which we've never noticed before. So dropping that >> patch just hides the error again, doesn't fix the error.
> We shouldn't fail test if system can't load expected files. > This just will trip up people trying to build qemu. If there are known-buggy iasl versions in the wild we could consider a configure test and treat buggy-iasl like no-iasl. thanks -- PMM
