Re: [Qemu-devel] [PATCH v17 1/6] lib/xbitmap: Introduce xbitmap

2017-11-06 Thread Wei Wang
On 11/03/2017 06:55 PM, Tetsuo Handa wrote: I'm commenting without understanding the logic. Wei Wang wrote: + +bool xb_preload(gfp_t gfp); + Want __must_check annotation, for __radix_tree_preload() is marked with __must_check annotation. By error failing to check result of xb_preload() will le

Re: [Qemu-devel] [PATCH v17 4/6] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-11-06 Thread Wei Wang
On 11/04/2017 07:28 PM, Tetsuo Handa wrote: Wei Wang wrote: On 11/03/2017 07:25 PM, Tetsuo Handa wrote: If this is inside vb->balloon_lock mutex (isn't this?), xb_set_page() must not use __GFP_DIRECT_RECLAIM allocation, for leak_balloon_sg_oom() will be blocked on vb->balloon_lock mutex. OK. Si

Re: [Qemu-devel] [PATCH v1 0/5][RFC] Refactoring of AIS support

2017-11-06 Thread Cornelia Huck
On Mon, 30 Oct 2017 19:58:15 +0100 Halil Pasic wrote: > On 10/30/2017 06:38 PM, Pierre Morel wrote: > > On 30/10/2017 18:08, Christian Borntraeger wrote: > >> > >> On 10/30/2017 05:59 PM, Cornelia Huck wrote: > >>> On Mon, 30 Oct 2017 14:48:23 +0100 > >>> Christian Borntraeger wrote: > >>> >

Re: [Qemu-devel] [PATCH v1 0/5][RFC] Refactoring of AIS support

2017-11-06 Thread Christian Borntraeger
On 11/06/2017 09:52 AM, Cornelia Huck wrote: > On Mon, 30 Oct 2017 19:58:15 +0100 > Halil Pasic wrote: > >> On 10/30/2017 06:38 PM, Pierre Morel wrote: >>> On 30/10/2017 18:08, Christian Borntraeger wrote: On 10/30/2017 05:59 PM, Cornelia Huck wrote: > On Mon, 30 Oct 2017 14:4

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-06 Thread Ladi Prosek
On Fri, Nov 3, 2017 at 4:11 PM, Michael S. Tsirkin wrote: > On Fri, Nov 03, 2017 at 09:23:07AM +0100, Ladi Prosek wrote: >> On Fri, Nov 3, 2017 at 8:20 AM, Gerd Hoffmann wrote: >> > >> >> > > Signed-off-by: Ladi Prosek >> >> > >> >> > I wonder whether it's a problem that legacy devices ignore >>

[Qemu-devel] unsubscribe

2017-11-06 Thread li.shanlue
unsubscribe qemu-devel

[Qemu-devel] qemu core file size

2017-11-06 Thread Wanpeng Li
Hi all, qemu core dump, max_core="unlimited", dump_guest_core=0, kill -11 pid to generate a qemu core file, the Rss of qemu itself is ~40MB, the core file is almost ~40MB in centos 6.x, but ~400MB in cents 7.x, any idea? Regards, Wanpeng Li

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-06 Thread Gerd Hoffmann
Hi, > > So in my humble opinion the right thing for people to do is simply > > to > > avoid legacy devices. Is something preventing that? > > The same reasons why the concept of transitional devices exists at > all? We discussing future driver versions running on future qemu versions, so we sh

[Qemu-devel] [Bug 1086782] Re: HPET time drift windows 7 64bits guest

2017-11-06 Thread Carlos-velasco
Testing now with qemu 2.10.1 Will need 1 day to see drift or not -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1086782 Title: HPET time drift windows 7 64bits guest Status in QEMU: Incomplete B

Re: [Qemu-devel] [PATCH v13 2/6] qmp: Use ThrottleLimits structure

2017-11-06 Thread Manos Pitsidianakis
On Fri, Oct 13, 2017 at 09:26:17AM -0500, Eric Blake wrote: [adding Markus, and block list] On 10/13/2017 09:16 AM, Alberto Garcia wrote: On Mon 02 Oct 2017 04:33:28 PM CEST, Pradeep Jagadeesh wrote: This patch factors out code to use the ThrottleLimits structure. { 'struct': 'BlockIOThrot

[Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

2017-11-06 Thread Stefan Priebe - Profihost AG
Hello, i've upgraded some servers from kernel 4.4 to 4.12 - both running Qemu 2.9.1. If i migrate a VM from a host running kernel 4.4 to a host running 4.12 i get: kvm: virtio-net: saved image requires TUN_F_UFO support kvm: Failed to load virtio-net-device:tmp kvm: Failed to load virtio-net:vir

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

2017-11-06 Thread Paolo Bonzini
On 06/11/2017 10:38, Stefan Priebe - Profihost AG wrote: > Hello, > > i've upgraded some servers from kernel 4.4 to 4.12 - both running Qemu > 2.9.1. > > If i migrate a VM from a host running kernel 4.4 to a host running 4.12 > i get: > > kvm: virtio-net: saved image requires TUN_F_UFO support >

Re: [Qemu-devel] qemu core file size

2017-11-06 Thread Paolo Bonzini
On 06/11/2017 10:11, Wanpeng Li wrote: > Hi all, > > qemu core dump, max_core="unlimited", dump_guest_core=0, kill -11 pid > to generate a qemu core file, the Rss of qemu itself is ~40MB, the > core file is almost ~40MB in centos 6.x, but ~400MB in cents 7.x, any > idea? My suspicion is the memor

[Qemu-devel] [RFC v3 00/27] QMP: out-of-band (OOB) execution support

2017-11-06 Thread Peter Xu
This is RFC v3 of Monitor Out-Of-Band series. It's getting longer and changes happens between versions, so I decided to re-write the cover letter. This series was born from this one: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg04310.html The idea comes from Markus Armbruster and

[Qemu-devel] [RFC v3 01/27] char-io: fix possible race on IOWatchPoll

2017-11-06 Thread Peter Xu
This is not a problem if we are only having one single loop thread like before. However, after per-monitor thread is introduced, this is not true any more, and the race can happen. The race can be triggered with "make check -j8" sometimes: qemu-system-x86_64: /root/git/qemu/chardev/char-io.c:9

[Qemu-devel] [RFC v3 04/27] qobject: let object_property_get_str() use new API

2017-11-06 Thread Peter Xu
We can simplify object_property_get_str() using the new qobject_get_try_str(). Signed-off-by: Peter Xu --- qom/object.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/qom/object.c b/qom/object.c index c58c52d518..9cbeb51f0b 100644 --- a/qom/object.c +++ b/qom/object

[Qemu-devel] [RFC v3 02/27] qobject: introduce qstring_get_try_str()

2017-11-06 Thread Peter Xu
The only difference from qstring_get_str() is that it allows the qstring to be NULL. If so, NULL is returned. CC: Eric Blake CC: Markus Armbruster Signed-off-by: Peter Xu --- include/qapi/qmp/qstring.h | 1 + qobject/qstring.c | 10 ++ 2 files changed, 11 insertions(+) diff

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

2017-11-06 Thread Paolo Bonzini
On 06/11/2017 10:48, Stefan Priebe - Profihost AG wrote: > Hi Paolo, > > Am 06.11.2017 um 10:40 schrieb Paolo Bonzini: >> On 06/11/2017 10:38, Stefan Priebe - Profihost AG wrote: >>> Hello, >>> >>> i've upgraded some servers from kernel 4.4 to 4.12 - both running Qemu >>> 2.9.1. >>> >>> If i migra

[Qemu-devel] [RFC v3 08/27] monitor: unify global init

2017-11-06 Thread Peter Xu
There are many places for monitor init its globals, at least: - monitor_init_qmp_commands() at the very beginning - single function to init monitor_lock - in the first entry of monitor_init() using "is_first_init" Unify them a bit. Signed-off-by: Peter Xu --- include/monitor/monitor.h | 2 +-

[Qemu-devel] [RFC v3 06/27] qjson: add "opaque" field to JSONMessageParser

2017-11-06 Thread Peter Xu
It'll be passed to emit() as well when it happens. Since at it, add a typedef for the emitter function. Signed-off-by: Peter Xu --- include/qapi/qmp/json-streamer.h | 10 -- monitor.c| 7 --- qga/main.c | 5 +++-- qobject/json-streamer

[Qemu-devel] [RFC v3 03/27] qobject: introduce qobject_get_try_str()

2017-11-06 Thread Peter Xu
A quick way to fetch string from qobject when it's a QString. Signed-off-by: Peter Xu --- include/qapi/qmp/qstring.h | 1 + qobject/qstring.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/include/qapi/qmp/qstring.h b/include/qapi/qmp/qstring.h index 34278bd639..12ae

[Qemu-devel] [RFC v3 16/27] monitor: let monitor_{suspend|resume} thread safe

2017-11-06 Thread Peter Xu
Monitor code now can be run in more than one thread. Let the suspend and resume code for thread safety. --- monitor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 1e87de87f8..47e969244d 100644 --- a/monitor.c +++ b/monitor.c @@ -4003,7 +4003,

[Qemu-devel] [RFC v3 12/27] qmp: introduce QMPCapability

2017-11-06 Thread Peter Xu
There was no QMP capabilities defined. Define the first "oob" as capability to allow out-of-band messages. Also, touch up qmp-test.c to test the new bits. Signed-off-by: Peter Xu --- monitor.c| 15 +-- qapi-schema.json | 13 + tests/qmp-test.c | 10 +- 3

[Qemu-devel] [RFC v3 07/27] monitor: move the cur_mon hack deeper for QMP

2017-11-06 Thread Peter Xu
In monitor_qmp_read(), we have the hack to temporarily replace the cur_mon pointer. Now we move this hack deeper inside the QMP dispatcher routine since the Monitor pointer can be passed in to that using the new JSON Parser opaque field now. This does not make much sense as a single patch. Howev

[Qemu-devel] [RFC v3 17/27] monitor: separate QMP parser and dispatcher

2017-11-06 Thread Peter Xu
Originally QMP goes throw these steps: JSON Parser --> QMP Dispatcher --> Respond /|\(2)(3) | (1) | \|/ (4) +- main thread + This patch does this: JSON Parser QMP Dispatcher --> Respond /|\ |

[Qemu-devel] [RFC v3 05/27] monitor: move skip_flush into monitor_data_init

2017-11-06 Thread Peter Xu
It's part of the data init. Collect it. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- monitor.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index e36fb5308d..3940737c1c 100644 --- a/monitor.c +++ b/monitor.c @@ -568,13 +56

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

2017-11-06 Thread Stefan Priebe - Profihost AG
Hi Paolo, Am 06.11.2017 um 10:40 schrieb Paolo Bonzini: > On 06/11/2017 10:38, Stefan Priebe - Profihost AG wrote: >> Hello, >> >> i've upgraded some servers from kernel 4.4 to 4.12 - both running Qemu >> 2.9.1. >> >> If i migrate a VM from a host running kernel 4.4 to a host running 4.12 >> i get

[Qemu-devel] [RFC v3 14/27] qmp: introduce some capability helpers

2017-11-06 Thread Peter Xu
Introduce qmp_cap_enabled() and qmp_oob_enabled() helpers. --- monitor.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/monitor.c b/monitor.c index dba56fbcdf..442d711d5d 100644 --- a/monitor.c +++ b/monitor.c @@ -1038,6 +1038,16 @@ static void monitor_init_qmp_commands(void)

[Qemu-devel] [RFC v3 09/27] monitor: let mon_list be tail queue

2017-11-06 Thread Peter Xu
It was QLIST. I want to use this list to do monitor priority job later, which need tail insertion ability. So switching to a tail queue. Signed-off-by: Peter Xu --- monitor.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c index ac5313023b..

[Qemu-devel] [RFC v3 18/27] qmp: add new event "request-dropped"

2017-11-06 Thread Peter Xu
This event will be emitted if one QMP request is dropped. Along, declare an enum for the reasons. Signed-off-by: Peter Xu --- qapi-schema.json | 35 +++ 1 file changed, 35 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index 531fd4c0db..650714da0

[Qemu-devel] [RFC v3 15/27] monitor: introduce monitor_qmp_respond()

2017-11-06 Thread Peter Xu
A tiny refactoring, preparing to split the QMP dispatcher away. Signed-off-by: Peter Xu --- monitor.c | 48 +++- 1 file changed, 31 insertions(+), 17 deletions(-) diff --git a/monitor.c b/monitor.c index 442d711d5d..1e87de87f8 100644 --- a/monitor.c +

[Qemu-devel] [RFC v3 11/27] monitor: allow to use IO thread for parsing

2017-11-06 Thread Peter Xu
For each Monitor, add one field "use_io_thr" to show whether it will be using the dedicated monitor IO thread to handle input/output. When set, monitor IO parsing work will be offloaded to dedicated monitor IO thread, rather than the original main loop thread. This only works for QMP. HMP will a

[Qemu-devel] [RFC v3 19/27] monitor: send event when request queue full

2017-11-06 Thread Peter Xu
Set maximum QMP request queue length to 8. If queue full, instead of queue the command, we directly return a "request-dropped" event, telling client that specific command is dropped. Note that this flow control mechanism is only valid if OOB is enabled. If it's not, the effective queue length wil

[Qemu-devel] [RFC v3 13/27] qmp: negociate QMP capabilities

2017-11-06 Thread Peter Xu
After this patch, we will allow QMP clients to enable QMP capabilities when sending the first "qmp_capabilities" command. Originally we are starting QMP session with no arguments like: { "execute": "qmp_capabilities" } Now we can enable some QMP capabilities using (take OOB as example, which i

[Qemu-devel] [RFC v3 20/27] qapi: introduce new cmd option "allow-oob"

2017-11-06 Thread Peter Xu
Here "oob" stands for "Out-Of-Band". When "allow-oob" is set, it means the command allows out-of-band execution. The "oob" idea is proposed by Markus Armbruster in following thread: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02057.html This new "allow-oob" boolean will be expose

[Qemu-devel] [RFC v3 10/27] monitor: create monitor dedicate iothread

2017-11-06 Thread Peter Xu
Create one IOThread for the monitors, prepared to handle all the input/output IOs using existing iothread framework. Signed-off-by: Peter Xu --- monitor.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/monitor.c b/monitor.c index a70ab5606b..df1ec8d037 10

[Qemu-devel] [RFC v3 22/27] qmp: let migrate-incoming allow out-of-band

2017-11-06 Thread Peter Xu
So it can get rid of being run on main thread. Signed-off-by: Peter Xu --- qapi/migration.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/migration.json b/qapi/migration.json index bbc4671ded..95098072dd 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @

[Qemu-devel] [RFC v3 25/27] docs: update QMP documents for OOB commands

2017-11-06 Thread Peter Xu
Update both the developer and spec for the new QMP OOB (Out-Of-Band) command. Signed-off-by: Peter Xu --- docs/devel/qapi-code-gen.txt | 51 +++- docs/interop/qmp-spec.txt| 32 +++ 2 files changed, 74 insertions(+), 9 deletions(

Re: [Qemu-devel] qemu core file size

2017-11-06 Thread Wanpeng Li
2017-11-06 17:41 GMT+08:00 Paolo Bonzini : > On 06/11/2017 10:11, Wanpeng Li wrote: >> Hi all, >> >> qemu core dump, max_core="unlimited", dump_guest_core=0, kill -11 pid >> to generate a qemu core file, the Rss of qemu itself is ~40MB, the >> core file is almost ~40MB in centos 6.x, but ~400MB in

[Qemu-devel] [RFC v3 21/27] qmp: support out-of-band (oob) execution

2017-11-06 Thread Peter Xu
Having "allow-oob" to true for a command does not mean that this command will always be run in out-of-band mode. The out-of-band quick path will only be executed if we specify the extra "run-oob" flag when sending the QMP request: { "execute": "command-that-allows-oob", "arguments": {

[Qemu-devel] [RFC v3 24/27] monitor: enable IO thread for (qmp & !mux) typed

2017-11-06 Thread Peter Xu
Start to use dedicate IO thread for QMP monitors that are not using MUXed chardev. Signed-off-by: Peter Xu --- monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index a2550d79a8..be6b3a914f 100644 --- a/monitor.c +++ b/monitor.c @@ -36,6 +36,7

[Qemu-devel] [RFC v3 27/27] tests: qmp-test: add oob test

2017-11-06 Thread Peter Xu
Test the new OOB capability. Here we used the "dump-guest-memory" command to hang the thread a bit to test working of OOB preemption. Note that currently it is only running for x86/arm/ppc/s390x. Note that for some platforms we may need to specify "-cpu" to make sure the dump-guest-memory command

[Qemu-devel] [RFC v3 23/27] qmp: isolate responses into io thread

2017-11-06 Thread Peter Xu
For those monitors who has enabled IO thread, we'll offload the responding procedure into IO thread. The main reason is that chardev is not thread safe, and we need to do all the read/write IOs in the same thread. For use_io_thr=true monitors, that thread is the IO thread. We do this isolation i

[Qemu-devel] [RFC v3 26/27] tests: qmp-test: verify command batching

2017-11-06 Thread Peter Xu
OOB introduced DROP event for flow control. This should not affect old QMP clients. Add a command batching check to make sure of it. --- tests/qmp-test.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/qmp-test.c b/tests/qmp-test.c index 292c5f135a..729ec59b0a 1006

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

2017-11-06 Thread Stefan Priebe - Profihost AG
Hi Paolo, Am 06.11.2017 um 10:49 schrieb Paolo Bonzini: > On 06/11/2017 10:48, Stefan Priebe - Profihost AG wrote: >> Hi Paolo, >> >> Am 06.11.2017 um 10:40 schrieb Paolo Bonzini: >>> On 06/11/2017 10:38, Stefan Priebe - Profihost AG wrote: Hello, i've upgraded some servers from ker

Re: [Qemu-devel] [PATCH v1 0/5][RFC] Refactoring of AIS support

2017-11-06 Thread Pierre Morel
On 06/11/2017 09:54, Christian Borntraeger wrote: On 11/06/2017 09:52 AM, Cornelia Huck wrote: On Mon, 30 Oct 2017 19:58:15 +0100 Halil Pasic wrote: On 10/30/2017 06:38 PM, Pierre Morel wrote: On 30/10/2017 18:08, Christian Borntraeger wrote: On 10/30/2017 05:59 PM, Cornelia Huck wrote:

Re: [Qemu-devel] [RFC v2 1/4] hw/intc/arm_gicv3_its: Don't abort on table save failure

2017-11-06 Thread Auger Eric
Hi Peter, On 02/11/2017 13:53, Peter Maydell wrote: > On 23 October 2017 at 16:35, Eric Auger wrote: >> The ITS is not fully properly reset at the moment. Caches are >> not emptied. >> >> After a reset, in case we attempt to save the state before >> the bound devices have registered their MSIs an

Re: [Qemu-devel] [PATCH] linux-user: remove nmi.c and fw-path-provider.c

2017-11-06 Thread Laurent Vivier
Le 06/11/2017 à 01:44, Alexey Kardashevskiy a écrit : > On 04/11/17 06:38, Laurent Vivier wrote: >> linux-user binaries don't need firmware and NMI, >> so don't add them in this case, move QDEV >> firmware functions to qdev-fw.c > > > When configured with --target-list=ppc64-linux-user , config-h

Re: [Qemu-devel] [PATCH] crypto: afalg: fix a NULL pointer dereference

2017-11-06 Thread Gonglei (Arei)
> -Original Message- > From: longpeng > Sent: Monday, November 06, 2017 2:21 PM > To: berra...@redhat.com; pbonz...@redhat.com; Gonglei (Arei) > Cc: longpeng; qemu-devel@nongnu.org > Subject: [PATCH] crypto: afalg: fix a NULL pointer dereference > > Test-crypto-hash calls qcrypto_hash_byt

Re: [Qemu-devel] qemu core file size

2017-11-06 Thread Paolo Bonzini
On 06/11/2017 11:01, Wanpeng Li wrote: > 2017-11-06 17:41 GMT+08:00 Paolo Bonzini : >> On 06/11/2017 10:11, Wanpeng Li wrote: >>> Hi all, >>> >>> qemu core dump, max_core="unlimited", dump_guest_core=0, kill -11 pid >>> to generate a qemu core file, the Rss of qemu itself is ~40MB, the >>> core fil

Re: [Qemu-devel] [PATCH] hw/intc/arm_gicv3_its: Fix the VM termination in vm_change_state_handler()

2017-11-06 Thread Peter Maydell
On 6 November 2017 at 07:30, Auger Eric wrote: > Hi Shanker, > > On 03/11/2017 13:37, Shanker Donthineni wrote: >> The commit cddafd8f353d ("hw/intc/arm_gicv3_its: Implement state save >> /restore") breaks the backward compatibility with the older kernels >> where vITS save/restore support is not

Re: [Qemu-devel] [v21 RESEND 0/2] virtio-crypto: virtio crypto device specification

2017-11-06 Thread Gonglei (Arei)
Hi guys, What a long time iteration it is. Hoping this is the final version if no big arguments exist as discussed with Stefan at KVM Forum 2017 this October. People can submit patches to fix some grammar issues or little problems, and then Xin' can submit the asymmetric crypto services spec bas

Re: [Qemu-devel] [PULL v1 03/11] sockets: Handle race condition between binds to the same port

2017-11-06 Thread Daniel P. Berrange
On Fri, Nov 03, 2017 at 06:54:44PM +, Peter Maydell wrote: > On 16 October 2017 at 21:16, Daniel P. Berrange wrote: > > From: Knut Omang > > > > If an offset of ports is specified to the inet_listen_saddr function(), > > and two or more processes tries to bind from these ports at the same tim

Re: [Qemu-devel] [PATCH v3 0/5] Various improvements/bugfixes to submodule handling

2017-11-06 Thread Daniel P. Berrange
On Fri, Nov 03, 2017 at 06:03:55PM +, Peter Maydell wrote: > On 3 November 2017 at 15:33, Daniel P. Berrange wrote: > > This short series of patches improves the reliability of the submodule > > handling to cope with various dev env scenarios that have since emerged > > Can I ask you to write

Re: [Qemu-devel] [PATCH v2 2/5] net: fix -netdev socket, fd= for UDP sockets

2017-11-06 Thread Jens Freimann
On Fri, Nov 03, 2017 at 06:46:57PM +, Peter Maydell wrote: On 8 August 2017 at 21:38, Jens Freimann wrote: @@ -333,8 +333,13 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer, * by ONLY ONE process: we must "clone" this dgram socket --jjo */ -if (is_c

Re: [Qemu-devel] [PATCH] osdep: Deal with TIME_MAX and OpenBSD 64-bit time_t

2017-11-06 Thread Peter Maydell
On 6 November 2017 at 00:56, Brad Smith wrote: > Define TIME_MAX to LLONG_MAX for OpenBSD since OpenBSD uses 64-bit time_t. > > Signed-off-by: Brad Smith > > > diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h > index 6855b94bbf..824714049b 100644 > --- a/include/qemu/osdep.h > +++ b/inclu

Re: [Qemu-devel] [PATCH qemu] isa-bus: Replace assert() about DMA with error report

2017-11-06 Thread Markus Armbruster
Alexey Kardashevskiy writes: > Running "qemu-system-ppc64 -machine prep -device i82374" creates an ISA > bus with two i82374 DMA controllers - one is implicit from ppc_prep_init(), > the other one is from "-device i82374". QEMU asserts but it is not > immediately clear why. > > This adds an error

Re: [Qemu-devel] [PATCH qemu] isa-bus: Replace assert() about DMA with error report

2017-11-06 Thread Peter Maydell
On 26 October 2017 at 09:00, Alexey Kardashevskiy wrote: > Running "qemu-system-ppc64 -machine prep -device i82374" creates an ISA > bus with two i82374 DMA controllers - one is implicit from ppc_prep_init(), > the other one is from "-device i82374". QEMU asserts but it is not > immediately clear

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

2017-11-06 Thread Stefan Priebe - Profihost AG
HI Paolo, could this patchset be related? Greets, Stefan Am 06.11.2017 um 10:52 schrieb Stefan Priebe - Profihost AG: > Hi Paolo, > > Am 06.11.2017 um 10:49 schrieb Paolo Bonzini: >> On 06/11/2017 10:48, Stefan Priebe - Profihost AG wrote: >>> Hi Paolo, >>> >>> Am 06.11.2017 um 10:40 schrieb Pa

Re: [Qemu-devel] [RFC v2 1/4] hw/intc/arm_gicv3_its: Don't abort on table save failure

2017-11-06 Thread Peter Maydell
On 6 November 2017 at 10:09, Auger Eric wrote: > Hi Peter, > > On 02/11/2017 13:53, Peter Maydell wrote: >> On 23 October 2017 at 16:35, Eric Auger wrote: >>> The ITS is not fully properly reset at the moment. Caches are >>> not emptied. >>> >>> After a reset, in case we attempt to save the state

[Qemu-devel] [PULL 0/1] Block patches

2017-11-06 Thread Stefan Hajnoczi
The following changes since commit b33afc415622e5eb26e0f14fd27eb86e32a5472e: Merge remote-tracking branch 'remotes/stsquad/tags/pull-ci-updates-for-softfreeze-021117-2' into staging (2017-11-03 10:08:34 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/

[Qemu-devel] [PULL 1/1] aio-posix: drop QEMU_AIO_POLL_MAX_NS env var

2017-11-06 Thread Stefan Hajnoczi
This hunk should not have been merged but I forgot to remove it. Let's remove it before it slips into a QEMU release. ¯\_(ツ)_/¯ Reviewed-by: Thomas Huth Signed-off-by: Stefan Hajnoczi Message-id: 20171103154041.12617-1-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi --- util/aio-posix.c |

Re: [Qemu-devel] [PATCH] osdep: Deal with TIME_MAX and OpenBSD 64-bit time_t

2017-11-06 Thread Daniel P. Berrange
On Mon, Nov 06, 2017 at 10:51:16AM +, Peter Maydell wrote: > On 6 November 2017 at 00:56, Brad Smith wrote: > > Define TIME_MAX to LLONG_MAX for OpenBSD since OpenBSD uses 64-bit time_t. > > > > Signed-off-by: Brad Smith > > > > > > diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h > >

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

2017-11-06 Thread Paolo Bonzini
On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote: > HI Paolo, > > could this patchset be related? Uh oh, yes it should. Jason, any ways to fix it? I suppose we need to disable UFO in the newest machine types, but do we also have to do (software) UFO in vhost-net and QEMU for migration co

Re: [Qemu-devel] [PATCH] configure: Deal with OpenBSD/i386 emulation linker

2017-11-06 Thread Peter Maydell
On 6 November 2017 at 00:53, Brad Smith wrote: > OpenBSD/i386 uses elf_i386_obsd for the emulation linker. > > Signed-off-by: Brad Smith > > > diff --git a/configure b/configure > index dd73cce62f..02799d38ac 100755 > --- a/configure > +++ b/configure > @@ -5159,9 +5159,9 @@ if test \( "$cpu" = "

[Qemu-devel] [PATCH] build: remove use of MAKELEVEL optimization in submodule handling

2017-11-06 Thread Daniel P. Berrange
The Makefile attempts to optimize the handling of submodules by using MAKELEVEL to only check the submodule status when running from the top level make invokation. This causes problems for people who are using a makefile of their own to in turn invoke QEMU's makefile, as MAKELEVEL is already set to

[Qemu-devel] [PATCH] vmcoreinfo: put it in the 'misc' device category

2017-11-06 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- hw/misc/vmcoreinfo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/vmcoreinfo.c b/hw/misc/vmcoreinfo.c index a618e12677..31db57ab44 100644 --- a/hw/misc/vmcoreinfo.c +++ b/hw/misc/vmcoreinfo.c @@ -79,6 +79,7 @@ static void vmcoreinfo_device_class

[Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets

2017-11-06 Thread Marc-André Lureau
vmcoreinfo is built for all targets. However, it requires fw_cfg with DMA operations support (write operation). Restrict vmcoreinfo exposure to architectures that are supporting FW_CFG_DMA, that is arm-virt and x86 only atm. Signed-off-by: Marc-André Lureau --- default-configs/arm-softmmu.mak

[Qemu-devel] [Bug 696094] Re: TI Stellaris lm3s811evb (ARM Cortex-M3) : Systick interrupt not working

2017-11-06 Thread Peter Maydell
** Tags added: arm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/696094 Title: TI Stellaris lm3s811evb (ARM Cortex-M3) : Systick interrupt not working Status in QEMU: New Bug description: I

[Qemu-devel] [Bug 657006] Re: arm v7M - svc insn doesn't trigger PendSV handler

2017-11-06 Thread Peter Maydell
** Tags added: arm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/657006 Title: arm v7M - svc insn doesn't trigger PendSV handler Status in QEMU: Incomplete Bug description: The svc instructio

Re: [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets

2017-11-06 Thread Thomas Huth
On 06.11.2017 12:53, Marc-André Lureau wrote: > vmcoreinfo is built for all targets. However, it requires fw_cfg with > DMA operations support (write operation). Restrict vmcoreinfo exposure > to architectures that are supporting FW_CFG_DMA, that is arm-virt and > x86 only atm. > > Signed-off-by:

Re: [Qemu-devel] qemu core file size

2017-11-06 Thread Fam Zheng
On Mon, 11/06 11:26, Paolo Bonzini wrote: > On 06/11/2017 11:01, Wanpeng Li wrote: > > 2017-11-06 17:41 GMT+08:00 Paolo Bonzini : > >> On 06/11/2017 10:11, Wanpeng Li wrote: > >>> Hi all, > >>> > >>> qemu core dump, max_core="unlimited", dump_guest_core=0, kill -11 pid > >>> to generate a qemu core

Re: [Qemu-devel] qemu core file size

2017-11-06 Thread Paolo Bonzini
On 06/11/2017 12:59, Fam Zheng wrote: >>> Could you point out the patchset for the fix? >> Between 447b0d0b9ee8a0ac216c3186e0f3c427a1001f0c and >> 092aa2fc65b7a35121616aad8f39d47b8f921618. > Not sure how these relate to the core size, but I've tested upstream > (ec7a8bf0b8f7dc7288fe8745464ee8217528

Re: [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets

2017-11-06 Thread Marc-André Lureau
Hi On Mon, Nov 6, 2017 at 12:58 PM, Thomas Huth wrote: > On 06.11.2017 12:53, Marc-André Lureau wrote: >> vmcoreinfo is built for all targets. However, it requires fw_cfg with >> DMA operations support (write operation). Restrict vmcoreinfo exposure >> to architectures that are supporting FW_CFG_

Re: [Qemu-devel] [PULL 0/2] Changes for 2017-11-05

2017-11-06 Thread Peter Maydell
On 5 November 2017 at 14:56, Paolo Bonzini wrote: > The following changes since commit b33afc415622e5eb26e0f14fd27eb86e32a5472e: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-ci-updates-for-softfreeze-021117-2' into staging > (2017-11-03 10:08:34 +) > > are available in the

Re: [Qemu-devel] [PULL 0/1] Block patches

2017-11-06 Thread Peter Maydell
On 6 November 2017 at 11:20, Stefan Hajnoczi wrote: > The following changes since commit b33afc415622e5eb26e0f14fd27eb86e32a5472e: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-ci-updates-for-softfreeze-021117-2' into staging > (2017-11-03 10:08:34 +) > > are available in t

[Qemu-devel] [Bug 1188991] Re: Unable to do serial communication using -chardev tty

2017-11-06 Thread Peter Maydell
Hi. The beaglexm model isn't part of upstream QEMU (it was in a set of downstream patches for OMAP3 which were never merged upstream and which are now essentially abandoned.) The root cause of this bug is that support for pass-through of a host serial port requires specific support in the device mo

[Qemu-devel] [Bug 1098729] Re: qemu-user-static for armhf: segfault in threaded code

2017-11-06 Thread Peter Maydell
We think we've fixed the multithreading issues in QEMU linux-user (in particular the test case that started this bug report works). If there are still problems with a QEMU version later than 2.10, please open fresh bug reports for specific guest programs that fail, giving detailed how-to-reproduce

Re: [Qemu-devel] qemu core file size

2017-11-06 Thread Wanpeng Li
2017-11-06 20:02 GMT+08:00 Paolo Bonzini : > On 06/11/2017 12:59, Fam Zheng wrote: Could you point out the patchset for the fix? >>> Between 447b0d0b9ee8a0ac216c3186e0f3c427a1001f0c and >>> 092aa2fc65b7a35121616aad8f39d47b8f921618. >> Not sure how these relate to the core size, but I've tested

Re: [Qemu-devel] [PATCH] build: remove use of MAKELEVEL optimization in submodule handling

2017-11-06 Thread Greg Kurz
On Mon, 6 Nov 2017 11:41:34 + "Daniel P. Berrange" wrote: > The Makefile attempts to optimize the handling of submodules by using > MAKELEVEL > to only check the submodule status when running from the top level make > invokation. This causes problems for people who are using a makefile of t

Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option

2017-11-06 Thread Markus Armbruster
Sorry for the slow response. Ian Jackson writes: > This allows the caller to specify a uid and gid to use, even if there > is no corresponding password entry. This will be useful in certain > Xen configurations. > > Signed-off-by: Ian Jackson > --- > v3: Error messages fixed. Thanks to Pe

Re: [Qemu-devel] [Qemu-block] [PATCH v2 3/7] qcow2: Prevent allocating compressed clusters at offset 0

2017-11-06 Thread Max Reitz
On 2017-11-03 21:32, Alberto Garcia wrote: > On Fri 03 Nov 2017 09:22:39 PM CET, Alberto Garcia wrote: -assert(offset); >>> >>> I don't think this assert() was meant as a protection against offset >>> being 0. :-) >> >> After the new check offset is now guaranteed to be 0, so what's th

Re: [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets

2017-11-06 Thread Daniel Henrique Barboza
On 11/06/2017 09:53 AM, Marc-André Lureau wrote: vmcoreinfo is built for all targets. However, it requires fw_cfg with DMA operations support (write operation). Restrict vmcoreinfo exposure to architectures that are supporting FW_CFG_DMA, that is arm-virt and x86 only atm. Signed-off-by: Marc-

Re: [Qemu-devel] [PATCH v13 2/6] qmp: Use ThrottleLimits structure

2017-11-06 Thread Pradeep Jagadeesh
On 11/6/2017 10:35 AM, Manos Pitsidianakis wrote: On Fri, Oct 13, 2017 at 09:26:17AM -0500, Eric Blake wrote: [adding Markus, and block list] On 10/13/2017 09:16 AM, Alberto Garcia wrote: On Mon 02 Oct 2017 04:33:28 PM CEST, Pradeep Jagadeesh wrote: This patch factors out code to use the Thro

Re: [Qemu-devel] [Qemu-block] [PATCH v2 3/7] qcow2: Prevent allocating compressed clusters at offset 0

2017-11-06 Thread Alberto Garcia
On Mon 06 Nov 2017 01:36:01 PM CET, Max Reitz wrote: > -assert(offset); I don't think this assert() was meant as a protection against offset being 0. :-) >>> >>> After the new check offset is now guaranteed to be 0, so what's the >>> point of keeping the assert() ? >> >>

Re: [Qemu-devel] [PATCH] aio-posix: drop QEMU_AIO_POLL_MAX_NS env var

2017-11-06 Thread Stefan Hajnoczi
On Fri, Nov 03, 2017 at 03:40:41PM +, Stefan Hajnoczi wrote: > This hunk should not have been merged but I forgot to remove it. Let's > remove it before it slips into a QEMU release. > > ¯\_(ツ)_/¯ > > Reviewed-by: Thomas Huth > Signed-off-by: Stefan Hajnoczi > --- > util/aio-posix.c | 7 -

Re: [Qemu-devel] [RFC PATCH 17/26] replay: push replay_mutex_lock up the call tree

2017-11-06 Thread Alex Bennée
Paolo Bonzini writes: > On 03/11/2017 10:47, Alex Bennée wrote: >> As deadlocks are easy to introduce a new rule is introduced that the >> replay_mutex_lock is taken before any BQL locks. Conversely you cannot >> release the replay_lock while the BQL is still held. > > I agree with the for

Re: [Qemu-devel] [RFC v3 00/27] QMP: out-of-band (OOB) execution support

2017-11-06 Thread Peter Xu
On Mon, Nov 06, 2017 at 02:12:17AM -0800, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [RFC v3 00/27] QMP: out-of-band (OOB) execution support > Type: series > Message-id: 20171106094

Re: [Qemu-devel] [RFC PATCH 17/26] replay: push replay_mutex_lock up the call tree

2017-11-06 Thread Paolo Bonzini
On 06/11/2017 14:05, Alex Bennée wrote: > > Paolo Bonzini writes: > >> On 03/11/2017 10:47, Alex Bennée wrote: >>> As deadlocks are easy to introduce a new rule is introduced that the >>> replay_mutex_lock is taken before any BQL locks. Conversely you cannot >>> release the replay_lock whi

[Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-06 Thread Jens Freimann
This fixes coverity issue CID1005339. Make sure that saddr is not used uninitialized if the mcast parameter is NULL. Cc: qemu-sta...@nongnu.org Reported-by: Peter Maydell Signed-off-by: Jens Freimann --- net/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/s

Re: [Qemu-devel] Make 9pfs buildable for Windows

2017-11-06 Thread Greg Kurz
On Fri, 29 Sep 2017 13:13:05 +0200 Michael Fritscher wrote: > Good day, > Hi, Sorry for the late reply... Since I have only limited bandwidth, I'll only be able to provide some limited feedback. A global remark to start with: it is a usual practice to prefix each patch title with the componen

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-06 Thread Peter Maydell
On 6 November 2017 at 13:28, Jens Freimann wrote: > This fixes coverity issue CID1005339. > > Make sure that saddr is not used uninitialized if the > mcast parameter is NULL. > > Cc: qemu-sta...@nongnu.org > Reported-by: Peter Maydell > Signed-off-by: Jens Freimann > --- > net/socket.c | 4 ++--

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-06 Thread Darren Kenny
Hi Jan, On Mon, Nov 06, 2017 at 02:28:05PM +0100, Jens Freimann wrote: This fixes coverity issue CID1005339. Make sure that saddr is not used uninitialized if the mcast parameter is NULL. Cc: qemu-sta...@nongnu.org Reported-by: Peter Maydell Signed-off-by: Jens Freimann --- net/socket.c | 4

Re: [Qemu-devel] [PATCH 01/18] Add definitions needed by file-op-9p.h for Windows

2017-11-06 Thread Greg Kurz
On Fri, 29 Sep 2017 13:13:06 +0200 Michael Fritscher wrote: > Signed-off-by: Michael Fritscher > --- > include/sysemu/os-win32.h | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/include/sysemu/os-win32.h b/include/sysemu/os-win32.h > index ff18b23db1..15cc94

Re: [Qemu-devel] [PATCH 03/18] Disable the proxy fsdev under Windows.

2017-11-06 Thread Greg Kurz
On Fri, 29 Sep 2017 13:13:08 +0200 Michael Fritscher wrote: > Signed-off-by: Michael Fritscher What's the justification for this patch ? > --- > fsdev/qemu-fsdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c > index 266e442b87..9f6d33365d

Re: [Qemu-devel] [RFC PATCH 19/26] cpu-exec: reset exit flag before calling cpu_exec_nocache

2017-11-06 Thread Paolo Bonzini
On 03/11/2017 09:27, Pavel Dovgalyuk wrote: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> On 02/11/2017 12:33, Paolo Bonzini wrote: >>> On 02/11/2017 12:24, Pavel Dovgalyuk wrote: > I am not sure about this. I think if instead you should return false > from here and EXCP_INTERRUPT

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-06 Thread Jens Freimann
On Mon, Nov 06, 2017 at 01:29:42PM +, Peter Maydell wrote: On 6 November 2017 at 13:28, Jens Freimann wrote: This fixes coverity issue CID1005339. Make sure that saddr is not used uninitialized if the mcast parameter is NULL. Cc: qemu-sta...@nongnu.org Reported-by: Peter Maydell Signed-o

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-06 Thread Jens Freimann
On Mon, Nov 06, 2017 at 01:33:49PM +, Darren Kenny wrote: Hi Jan, On Mon, Nov 06, 2017 at 02:28:05PM +0100, Jens Freimann wrote: This fixes coverity issue CID1005339. Make sure that saddr is not used uninitialized if the mcast parameter is NULL. Cc: qemu-sta...@nongnu.org Reported-by: Pet

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-06 Thread Peter Maydell
On 6 November 2017 at 13:48, Jens Freimann wrote: > On Mon, Nov 06, 2017 at 01:29:42PM +, Peter Maydell wrote: >> Do we really need the initialization here? With the two if() >> conditions aligned we should be properly initializing it >> in all the cases we use it, or have I missed one? > > >

Re: [Qemu-devel] [RFC PATCH 19/26] cpu-exec: reset exit flag before calling cpu_exec_nocache

2017-11-06 Thread Alex Bennée
Pavel Dovgalyuk writes: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> On 02/11/2017 12:33, Paolo Bonzini wrote: >> > On 02/11/2017 12:24, Pavel Dovgalyuk wrote: >> >>> I am not sure about this. I think if instead you should return false >> >>> from here and EXCP_INTERRUPT from cpu_exec

  1   2   3   4   >