On 6 November 2017 at 10:09, Auger Eric <eric.au...@redhat.com> wrote: > Hi Peter, > > On 02/11/2017 13:53, Peter Maydell wrote: >> On 23 October 2017 at 16:35, Eric Auger <eric.au...@redhat.com> wrote: >>> The ITS is not fully properly reset at the moment. Caches are >>> not emptied. >>> >>> After a reset, in case we attempt to save the state before >>> the bound devices have registered their MSIs and after the >>> 1st level table has been allocated by the ITS driver >>> (device BASER is valid), the first level entries are still >>> invalid. If the device cache is not empty (devices registered >>> before the reset), vgic_its_save_device_tables fails with -EINVAL. >>> This causes a QEMU abort(). >>> >>> Signed-off-by: Eric Auger <eric.au...@redhat.com> >>> Reported-by: wanghaibin <wanghaibin.w...@huawei.com> >>> >>> --- >>> >>> this patch would deserve being cc'ed stable (2.10) >>> This goes along with patches 1-5 of >>> [PATCH v5 00/10] vITS Migration fixes and reset, candidate >>> for being cc'ed stable >>> --- >> >> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> >> >> We could/should put this patch into qemu now, right (it's >> the rest of the series that's RFC) ? > > Yes that's correct.
OK. I have applied 1/4 (and none of the rest) to target-arm.next, with a cc-stable annotation. thanks -- PMM
