Re: [Qemu-devel] [libfdt][PATCH v2] implement strnlen for systems that need it

2017-10-22 Thread David Gibson
On Fri, Oct 20, 2017 at 04:44:58PM -0700, Richard Henderson wrote: > On 10/20/2017 10:55 AM, John Arbuckle wrote: > > +static inline size_t strnlen(const char *string, size_t max_count) > > +{ > > +size_t count; > > +for (count = 0; count < max_count; count++) { > > +if (string[coun

[Qemu-devel] [Qemu devel v3 PATCH] msf2: Remove dead code reported by Coverity

2017-10-22 Thread Subbaraya Sundeep
Fixed incorrect frame size mask, validated maximum frame size in spi_write and removed dead code. Signed-off-by: Subbaraya Sundeep --- v3: Added comment that [31:6] bits are reserved in R_SPI_DFSIZE register and logged incorrect value too in guest error(suggested by Darren).

Re: [Qemu-devel] [RFC] RISC-V Decoder generator

2017-10-22 Thread Bastian Koppelmann
On 10/20/2017 06:57 PM, Richard Henderson wrote: > All that said, this looks very readable. Thank you. > Thanks for your great feedback. I think most of them are not hard to implement. However I might need some time for that :) Cheers, Bastian

Re: [Qemu-devel] [libfdt][PATCH v2] implement strnlen for systems that need it

2017-10-22 Thread Peter Maydell
On 21 October 2017 at 00:44, Richard Henderson wrote: > On 10/20/2017 10:55 AM, John Arbuckle wrote: >> +static inline size_t strnlen(const char *string, size_t max_count) >> +{ >> +size_t count; >> +for (count = 0; count < max_count; count++) { >> +if (string[count] == '\0') { >>

Re: [Qemu-devel] [sw-dev] [RFC] RISC-V Decoder generator

2017-10-22 Thread Bastian Koppelmann
Hi Richard, On 10/21/2017 08:44 AM, Richard W.M. Jones wrote: > On Fri, Oct 20, 2017 at 03:46:54PM +0200, Bastian Koppelmann wrote: >> I asked you for feedback some while ago regarding a modular RISC-V QEMU >> target (see discussion [1]). I tried getting it to work with the good >> old C preproces

[Qemu-devel] PCI Passthrough + AMD + NPT

2017-10-22 Thread geoff--- via Qemu-devel
Hi All, I have started to dig into why ntp seems to slow down graphics performance on AMD systems using PCI passthrough and figured I would report what I have so far discovered. I have noted the primary point of failure seems to be specifically with PhysX. This is why people only see a slow do

Re: [Qemu-devel] [libfdt][PATCH v2] implement strnlen for systems that need it

2017-10-22 Thread Programmingkid
> On Oct 22, 2017, at 9:37 AM, Peter Maydell wrote: > > On 21 October 2017 at 00:44, Richard Henderson > wrote: >> On 10/20/2017 10:55 AM, John Arbuckle wrote: >>> +static inline size_t strnlen(const char *string, size_t max_count) >>> +{ >>> +size_t count; >>> +for (count = 0; count <

Re: [Qemu-devel] [Qemu devel v2 PATCH] msf2: Remove dead code reported by Coverity

2017-10-22 Thread sundeep subbaraya
Hi Darren, On Wed, Oct 18, 2017 at 4:04 PM, Darren Kenny wrote: > Hi Sundeep, > > > On Wed, Oct 18, 2017 at 10:10:07AM +, sundeep subbaraya wrote: > >> Hi Darren, >> >> On Wed, Oct 18, 2017 at 2:24 PM, Darren Kenny >> wrote: >> >> On Wed, Oct 18, 2017 at 03:40:38AM +, Subbaraya Sundeep

Re: [Qemu-devel] [libfdt][PATCH v2] implement strnlen for systems that need it

2017-10-22 Thread Programmingkid
> On Oct 22, 2017, at 1:33 AM, David Gibson wrote: > > On Fri, Oct 20, 2017 at 04:44:58PM -0700, Richard Henderson wrote: >> On 10/20/2017 10:55 AM, John Arbuckle wrote: >>> +static inline size_t strnlen(const char *string, size_t max_count) >>> +{ >>> +size_t count; >>> +for (count = 0;

Re: [Qemu-devel] [libfdt][PATCH v2] implement strnlen for systems that need it

2017-10-22 Thread John Reiser
... this one is even smaller. Plus it uses the familiar strlen() function: size_t strnlen(const char *string, size_t max_count) { return strlen(string) < max_count ? strlen(string) : max_count; } Please do not use that implementation. The major goal of strnlen is to avoid looking beyond

Re: [Qemu-devel] [Qemu devel v3 PATCH] msf2: Remove dead code reported by Coverity

2017-10-22 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1508678882-4327-1-git-send-email-sundeep.l...@gmail.com Subject: [Qemu-devel] [Qemu devel v3 PATCH] m

Re: [Qemu-devel] [PULL 00/10] linux-user update for 2.11

2017-10-22 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1508329282.git.riku.voi...@linaro.org Subject: [Qemu-devel] [PULL 00/10] linux-user update for 2.11 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

[Qemu-devel] Unable to clone git repository from git.qemu.org

2017-10-22 Thread Eduardo A . Bustamante López
(please keep me CC'ed, I'm not subscribed) Hi, I apologize if this is not the right mailing list for this report. I'm unable to clone the git repository from git://git.qemu.org/qemu.git (which is listed on https://www.qemu.org/contribute/). I'm getting TCP RST's when I try to clone it, as indi

[Qemu-devel] [PATCH] BCM2837 and machine raspi3

2017-10-22 Thread bzt bzt
Dear All, I've added support for "-M raspi3" to qemu. This is my first patch, I hope it's okay. The github repo is here: https://github.com/bztsrc/qemu-raspi3 in case my patch does not work for some reason. >From 1f10f957b57f336728097803bf8339a5577dd3c2 Mon Sep 17 00:00:00 2001 From: bzt Date: S

Re: [Qemu-devel] [PATCH v2 1/1] virtio_balloon: include buffers and cached memory statistics

2017-10-22 Thread Tomáš Golembiovský
On Thu, 19 Oct 2017 16:12:20 +0300 "Michael S. Tsirkin" wrote: > On Thu, Sep 21, 2017 at 02:55:41PM +0200, Tomáš Golembiovský wrote: > > Add a new fields, VIRTIO_BALLOON_S_BUFFERS and VIRTIO_BALLOON_S_CACHED, > > to virtio_balloon memory statistics protocol. The values correspond to > > 'Buffers'

Re: [Qemu-devel] [Qemu devel v3 PATCH] msf2: Remove dead code reported by Coverity

2017-10-22 Thread Darren Kenny
On Sun, Oct 22, 2017 at 06:58:02PM +0530, Subbaraya Sundeep wrote: Fixed incorrect frame size mask, validated maximum frame size in spi_write and removed dead code. Signed-off-by: Subbaraya Sundeep --- v3: Added comment that [31:6] bits are reserved in R_SPI_DFSIZE register and

Re: [Qemu-devel] [libfdt][PATCH v2] implement strnlen for systems that need it

2017-10-22 Thread Ian Lepore
On Sun, 2017-10-22 at 10:41 -0400, Programmingkid wrote: > > > > On Oct 22, 2017, at 1:33 AM, David Gibson wrote: > > > > On Fri, Oct 20, 2017 at 04:44:58PM -0700, Richard Henderson wrote: > > > > > > On 10/20/2017 10:55 AM, John Arbuckle wrote: > > > > > > > > +static inline size_t strnlen(co

Re: [Qemu-devel] [libfdt][PATCH v2] implement strnlen for systems that need it

2017-10-22 Thread Programmingkid
> On Oct 22, 2017, at 3:06 PM, Ian Lepore wrote: > > On Sun, 2017-10-22 at 10:41 -0400, Programmingkid wrote: >>> >>> On Oct 22, 2017, at 1:33 AM, David Gibson wrote: >>> >>> On Fri, Oct 20, 2017 at 04:44:58PM -0700, Richard Henderson wrote: On 10/20/2017 10:55 AM, John Arbuckle wr

Re: [Qemu-devel] [PATCH] ACPI/unit-test: Add a testcase for RAM allocation in numa node

2017-10-22 Thread Dou Liyang
Hi Eduardo, Thanks for your reply. At 10/21/2017 03:15 AM, Eduardo Habkost wrote: On Wed, Oct 18, 2017 at 11:50:32AM +0800, Dou Liyang wrote: At 10/18/2017 11:48 AM, Dou Liyang wrote: As QEMU supports the memory-less node, it is possible that there is no RAM in the first numa node(also be ca

Re: [Qemu-devel] Unable to clone git repository from git.qemu.org

2017-10-22 Thread Paolo Bonzini
On 22/10/2017 18:13, Eduardo A. Bustamante López wrote: > (please keep me CC'ed, I'm not subscribed) > > Hi, > > I apologize if this is not the right mailing list for this report. I'm unable > to clone the git repository from > git://git.qemu.org/qemu.git (which is listed on > https://www.qemu.

[Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

2017-10-22 Thread Dou Liyang
Linux and Windows need ACPI SRAT table to make memory hotplug work properly, however currently QEMU doesn't create SRAT table if numa options aren't present on CLI. Which breaks both linux and windows guests in certain conditions: * Windows: won't enable memory hotplug without SRAT table at all

Re: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

2017-10-22 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1508722422-3861-1-git-send-email-douly.f...@cn.fujitsu.com Subject: [Qemu-devel] [PATCH v4] NUMA: Ena

Re: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

2017-10-22 Thread Dou Liyang
Hi Fam, At 10/23/2017 09:37 AM, no-re...@patchew.org wrote: Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1508722422-3861-1-git-send-email-douly

Re: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

2017-10-22 Thread Dou Liyang
Hi, Fam At 10/23/2017 09:37 AM, no-re...@patchew.org wrote: Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 1508722422-3861-1-git-send-email-douly.f...@cn.fujitsu.com Subject: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implici

[Qemu-devel] [libfdt][PATCH v3] implement strnlen for systems that need it

2017-10-22 Thread John Arbuckle
Prior the Mac OS 10.7, the function strnlen() was not available. This patch implements strnlen() on Mac OS X versions that are below 10.7. Signed-off-by: John Arbuckle --- v3 changes: - Replaced loop with memchr() v2 changes: - Simplified the code to make it static inline'ed - Changed the type o

Re: [Qemu-devel] [Qemu devel v3 PATCH] msf2: Remove dead code reported by Coverity

2017-10-22 Thread sundeep subbaraya
Hi Darren, On Mon, Oct 23, 2017 at 12:18 AM, Darren Kenny wrote: > On Sun, Oct 22, 2017 at 06:58:02PM +0530, Subbaraya Sundeep wrote: > >> Fixed incorrect frame size mask, validated maximum frame >> size in spi_write and removed dead code. >> >> Signed-off-by: Subbaraya Sundeep >> --- >> v3: >>

Re: [Qemu-devel] [Qemu devel v3 PATCH] msf2: Remove dead code reported by Coverity

2017-10-22 Thread sundeep subbaraya
Hi Peter, On Sun, Oct 22, 2017 at 7:35 PM, wrote: > Hi, > > This series failed automatic build test. Please find the testing commands > and > their output below. If you have docker installed, you can probably > reproduce it > locally. > > Type: series > Message-id: 1508678882-4327-1-git-send-ema

Re: [Qemu-devel] [PATCH v4 2/4] vhost-user-blk: introduce a new vhost-user-blk host device

2017-10-22 Thread Liu, Changpeng
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Friday, October 20, 2017 5:55 PM > To: Liu, Changpeng > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; m...@redhat.com; > marcandre.lur...@redhat.com; fel...@nutanix.com; Harris, James R > > Subject: Re: [

[Qemu-devel] [Bug 1711828] Re: lock mov non generated #UD

2017-10-22 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1711828 Title: lock mov no

Re: [Qemu-devel] [PATCH v2 18/24] fixup! ppc: spapr: use generic cpu_model parsing

2017-10-22 Thread Alexey Kardashevskiy
On 13/10/17 09:24, David Gibson wrote: > On Thu, Oct 12, 2017 at 05:50:08PM +0200, Igor Mammedov wrote: >> inot sure how it managed to compile locally and on travis > > Because target/ppc/kvm.c is only compiled on a ppc _host_. that or in cross environment, to be precise. > >> but build fails

Re: [Qemu-devel] [PATCH v4 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-10-22 Thread Liu, Changpeng
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Friday, October 20, 2017 6:01 PM > To: Michael S. Tsirkin > Cc: Liu, Changpeng ; qemu-devel@nongnu.org; > pbonz...@redhat.com; marcandre.lur...@redhat.com; fel...@nutanix.com; > Harris, James R > Subject: R

Re: [Qemu-devel] [Qemu devel v3 PATCH] msf2: Remove dead code reported by Coverity

2017-10-22 Thread Fam Zheng
On Mon, 10/23 08:59, sundeep subbaraya wrote: > > Cloning into '/var/tmp/patchew-tester-tmp-egubaaoc/src/dtc'... > > fatal: Could not read from remote repository. > > > > Please make sure you have the correct access rights > > and the repository exists. > > fatal: clone of 'git://git.qemu-project.o

Re: [Qemu-devel] [PATCH] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

2017-10-22 Thread Gerd Hoffmann
Hi, > The guest will still run with 40 bits physical! > (judging the code anyway, I hope I am wrong) > > Then, the stakes are not so big, the Guest kernel will disregard > the 64bit hole since is not CPU addressable and go on. But then there is no working 64bit hole for hotplug ... cheers,

Re: [Qemu-devel] [RFC v2 13/22] monitor: separate QMP parser and dispatcher

2017-10-22 Thread Peter Xu
On Fri, Oct 20, 2017 at 11:19:44AM +0200, Paolo Bonzini wrote: > On 19/10/2017 15:13, Stefan Hajnoczi wrote: > > Up to you. I don't remember the details of out_lock usage well enough > > to know whether using the lock for the queues is good or bad. > > out_lock is called like that because it's on

Re: [Qemu-devel] [PATCH] docker: Fix PATH for ccache

2017-10-22 Thread Fam Zheng
On Fri, 10/20 13:51, Daniel P. Berrange wrote: > On Wed, Oct 18, 2017 at 09:35:49AM +0100, Daniel P. Berrange wrote: > > On Wed, Oct 18, 2017 at 04:28:36PM +0800, Fam Zheng wrote: > > > On Wed, 10/18 01:08, no-re...@patchew.org wrote: > > > > Your branch is up-to-date with 'origin/test'. > > > > Su

Re: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

2017-10-22 Thread Fam Zheng
On Mon, 10/23 09:54, Dou Liyang wrote: > Hi Fam, > > At 10/23/2017 09:37 AM, no-re...@patchew.org wrote: > > Hi, > > > > This series failed automatic build test. Please find the testing commands > > and > > their output below. If you have docker installed, you can probably > > reproduce it > >

Re: [Qemu-devel] host physical address width issues/questions for x86_64

2017-10-22 Thread Peter Xu
On Fri, Oct 20, 2017 at 03:54:21PM -0700, Prasad Singamsetty wrote: > > > On 10/18/2017 8:33 PM, Peter Xu wrote: > >On Wed, Oct 18, 2017 at 10:19:31AM -0700, Prasad Singamsetty wrote: > >> > >> > >>On 10/16/2017 8:56 PM, Peter Xu wrote: > >>>On Mon, Oct 16, 2017 at 10:02:25AM -0700, Prasad Singam