[Qemu-devel] [PATCH v3 41/46] hw/xen*: Replace fprintf(stderr, "*\n" with error_report()

2017-10-19 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v3 39/46] hw/usb: Replace fprintf(stderr, "*\n" with error_report()

2017-10-19 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v3 46/46] target: Replace fprintf(stderr, "*\n" with error_report()

2017-10-19 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v3 42/46] util: Replace fprintf(stderr, "*\n" with error_report()

2017-10-19 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

Re: [Qemu-devel] [PATCH v1] os-posix: Add -unshare option

2017-10-19 Thread Daniel P. Berrange
On Thu, Oct 19, 2017 at 05:04:19PM +0100, Ross Lagerwall wrote: > Add an option to allow calling unshare() just before starting guest > execution. The option allows unsharing one or more of the mount > namespace, the network namespace, and the IPC namespace. This is useful > to restrict the ability

[Qemu-devel] [PATCH v6 1/8] aspeed: use a ROM memory region to catch invalid writes

2017-10-19 Thread Cédric Le Goater
Some legacy firmwares access unimplemented addresses on the Aspeed SoC (old U-Boot code using variables in the bss when it shouldn't do). Let's use a ROM memory region to catch the invalid writes and support new boards without using the 'ignore_memory_transaction_failures' flag. This change is bre

[Qemu-devel] [PATCH v6 2/8] aspeed: remove ignore_memory_transaction_failures on all boards

2017-10-19 Thread Cédric Le Goater
Now that we have a ROM memory region catching the invalid writes, we can remove this flag and work on fixing the current firwmares still accessing unimplemented addresses. Signed-off-by: Cédric Le Goater Reviewed-by: Peter Maydell --- hw/arm/aspeed.c | 3 --- 1 file changed, 3 deletions(-) dif

[Qemu-devel] [PATCH v6 3/8] aspeed: add support for the witherspoon-bmc board

2017-10-19 Thread Cédric Le Goater
The Witherspoon boards are OpenPOWER system hosting POWER9 Processors. Let's add support for their BMC including a couple of I2C devices as found on real HW. Signed-off-by: Cédric Le Goater Reviewed-by: Andrew Jeffery --- Changes since v2: - removed 'ignore_memory_transaction_failures' flag

[Qemu-devel] [PATCH v6 5/8] smbus: add a smbus_eeprom_init_one() routine

2017-10-19 Thread Cédric Le Goater
This is an helper routine to add a single EEPROM on an I2C bus. It can be directly used by smbus_eeprom_init() which adds a certain number of EEPROMs on mips and x86 machines. Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé --- hw/i2c/smbus_eeprom.c | 16 +++- i

Re: [Qemu-devel] [RFC PATCH] arm: implement cache/shareability attribute bits for PAR registers

2017-10-19 Thread Andrew Baumann via Qemu-devel
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Thursday, 19 October 2017 09:51 > > On 18 October 2017 at 01:16, Andrew Baumann > wrote: > Hi; thanks for this patch. Looks like you forgot to add your > signed-off-by line. Thanks for the review! I didn’t sign the patch, because

[Qemu-devel] [PATCH v6 6/8] aspeed: Add EEPROM I2C devices

2017-10-19 Thread Cédric Le Goater
The Aspeed boards have at least one EEPROM to hold the Vital Product Data (VPD). Signed-off-by: Cédric Le Goater Reviewed-by: Andrew Jeffery --- hw/arm/aspeed.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 124a0e5240b5..df7f266800ba

[Qemu-devel] [PATCH v6 4/8] aspeed: add an I2C RTC device to all machines

2017-10-19 Thread Cédric Le Goater
The AST2500 EVB does not have an RTC but we can pretend that one is plugged on the I2C bus header. The romulus and witherspoon boards expects an Epson RX8900 I2C RTC but a ds1338 is good enough for the basic features we need. Signed-off-by: Cédric Le Goater Reviewed-by: Andrew Jeffery --- hw/a

Re: [Qemu-devel] [PATCH 00/42] TPM: code cleanup & CRB device

2017-10-19 Thread Stefan Berger
On 10/19/2017 10:44 AM, Stefan Berger wrote: On 10/19/2017 10:33 AM, Marc-André Lureau wrote: Hi Stefan - Original Message - On 10/09/2017 06:55 PM, Marc-André Lureau wrote: Hi, I accumulated a series of patch doing some TPM code cleanup while doing review. I removed some dead code,

[Qemu-devel] [PATCH 8/8] configure: do_compiler: Dump some extra info under bash

2017-10-19 Thread Ian Jackson
This makes it much easier to find a particular thing in config.log. The information may be lacking in other shells, resulting in harmless empty output. (This is why we don't use the proper ${FUNCNAME[*]} array syntax - other shells will choke on that.) The extra output is only printed if configu

[Qemu-devel] [PATCH v6 8/8] aspeed: add the pc9552 chips to the witherspoon machine

2017-10-19 Thread Cédric Le Goater
The pca9552 LED blinkers on the Witherspoon machine are used for leds but also as GPIOs to control fans and GPUs. Signed-off-by: Cédric Le Goater Reviewed-by: Andrew Jeffery --- hw/arm/aspeed.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index df7f2

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-10-19 Thread Halil Pasic
On 09/15/2017 09:27 AM, Cornelia Huck wrote: >>> +DEFINE_PROP_UINT8("chpid_type", CcwTesterDevice, chpid_type, + 0x98), > This might also need re-evaluation - we should not really need a new > chpid type. > I'm back at ccw-tester again (for v2). I've reali

[Qemu-devel] [PATCH v5 0/8] xen: xen-domid-restrict improvements

2017-10-19 Thread Ian Jackson
I have been working on trying to get qemu, when running as a Xen device model, to _actually_ not have power equivalent to root. I think I have achieved this, with some limitations (which are discussed in my series against xen.git. However, there are changes to qemu needed. In particular * The

Re: [Qemu-devel] [PATCH 1/8] xen: link against xentoolcore

2017-10-19 Thread Anthony PERARD
On Thu, Oct 19, 2017 at 05:38:10PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("Re: [PATCH 1/8] xen: link against xentoolcore"): > > I don't think it is necessary to do anything in qemu. The linker should > > find on its own the new libxentoolcore as long as an option > > -Wl,-rpath-link= pr

Re: [Qemu-devel] [PATCH v1] arm: Adding new arm machine, Kinetis K64 MK64FN1M0

2017-10-19 Thread Peter Maydell
On 19 October 2017 at 13:50, wrote: > From: Gabriel Augusto Costa > > I add a new arm machine with some peripherals. The machine is mk64fn1m0, a > cortex-m4 microcontroller from NXP Kinetis family. The machine can run a > simple arm binary file using UART0 in polling mode. > I prepared two patch

Re: [Qemu-devel] [RFC PATCH] arm: implement cache/shareability attribute bits for PAR registers

2017-10-19 Thread Peter Maydell
On 18 October 2017 at 01:16, Andrew Baumann wrote: > On a successful address translation instruction, PAR is supposed to > contain cacheability and shareability attributes determined by the > translation. Previous versions of QEMU returned 0 for these bits (in > line with the general strategy of i

[Qemu-devel] [PATCH 4/8] xen: destroy_hvm_domain: Move reason into a variable

2017-10-19 Thread Ian Jackson
We are going to want to reuse this. No functional change. Signed-off-by: Ian Jackson Reviewed-by: Anthony PERARD --- hw/i386/xen/xen-hvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 7b60ec6..83420cd 100644 --- a/

[Qemu-devel] [PATCH 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown

2017-10-19 Thread Ian Jackson
xc_interface_open etc. is not going to work if we have dropped privilege, but xendevicemodel_shutdown will if everything is new enough. xendevicemodel_shutdown is only availabe in Xen 4.10 and later, so provide a stub for earlier versions. Signed-off-by: Ian Jackson --- v2: Add compatibility stu

[Qemu-devel] [PATCH 3/8] xen: defer call to xen_restrict until just before os_setup_post

2017-10-19 Thread Ian Jackson
We need to restrict *all* the control fds that qemu opens. Looking in /proc/PID/fd shows there are many; their allocation seems scattered throughout Xen support code in qemu. We must postpone the restrict call until roughly the same time as qemu changes its uid, chroots (if applicable), and so on

Re: [Qemu-devel] [RFC PATCH] arm: implement cache/shareability attribute bits for PAR registers

2017-10-19 Thread Peter Maydell
On 19 October 2017 at 18:04, Andrew Baumann wrote: >> From: Peter Maydell [mailto:peter.mayd...@linaro.org] >> Sent: Thursday, 19 October 2017 09:51 >> >> On 18 October 2017 at 01:16, Andrew Baumann >> wrote: >> Hi; thanks for this patch. Looks like you forgot to add your >> signed-off-by line. >

[Qemu-devel] [PATCH 1/8] xen: link against xentoolcore

2017-10-19 Thread Ian Jackson
From: Anthony PERARD Xen libraries 4.10 will include a new xentoolcore library, without which xendevicemodel et al will not work. Signed-off-by: Ian Jackson --- configure | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/configure b/configure index fd7e3a5..6f691df 10

[Qemu-devel] [PATCH v1] arm: Adding new arm machine, Kinetis K64 MK64FN1M0

2017-10-19 Thread gabriel291075
From: Gabriel Augusto Costa I add a new arm machine with some peripherals. The machine is mk64fn1m0, a cortex-m4 microcontroller from NXP Kinetis family. The machine can run a simple arm binary file using UART0 in polling mode. I prepared two patchs to include this machine: PATCH v1: Include th

[Qemu-devel] [PATCH 7/8] os-posix: Provide new -runas . facility

2017-10-19 Thread Ian Jackson
This allows the caller to specify a uid and gid to use, even if there is no corresponding password entry. This will be useful in certain Xen configurations. We don't support just -runas because: (i) deprivileging without calling setgroups would be ineffective (ii) given only a uid we don't know

[Qemu-devel] [PATCH v2] arm: Adding makefile for Kinetis K64 MK64FN1M0

2017-10-19 Thread gabriel291075
From: Gabriel Augusto Costa I add a new arm machine with some peripherals. The machine is mk64fn1m0, a cortex-m4 microcontroller from NXP Kinetis family. The machine can run a simple arm binary file using UART0 in polling mode. I prepared two patchs to include this machine: PATCH v1: Include th

Re: [Qemu-devel] [PATCH v3 32/46] hw/s390x: Replace fprintf(stderr, "*\n" with error_report()

2017-10-19 Thread Thomas Huth
On 19.10.2017 18:17, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. [...] > Some lines where then manually tweaked to pass checkpatch. > > One

Re: [Qemu-devel] [PATCH 00/42] TPM: code cleanup & CRB device

2017-10-19 Thread Marc-André Lureau
Hi - Original Message - > On 10/19/2017 10:44 AM, Stefan Berger wrote: > > On 10/19/2017 10:33 AM, Marc-André Lureau wrote: > >> Hi Stefan > >> > >> - Original Message - > >>> On 10/09/2017 06:55 PM, Marc-André Lureau wrote: > Hi, > > I accumulated a series of patch

Re: [Qemu-devel] [PATCH] build: Fix dtc-checkout race condition in Makefile

2017-10-19 Thread Peter Maydell
On 19 October 2017 at 10:15, Daniel P. Berrange wrote: > On Wed, Oct 18, 2017 at 02:40:23PM -0400, Aaron Lindsay wrote: >> This was introduced by: >> commit aef45d51d1204f3335fb99de6658e0c5612c2b67 >> Author: Daniel P. Berrange >> Date: Fri Sep 29 11:11:56 2017 +0100 >> >> bui

Re: [Qemu-devel] [PULL 0/1] Seabios 1.11 prerelease 20171019 patches

2017-10-19 Thread Peter Maydell
ble in the git repository at: > > git://git.kraxel.org/qemu tags/seabios-1.11-prerelease-20171019-pull-request > > for you to fetch changes up to 083fab0290f2c40d3d04f7f22eed9c8f2d5b6787: > > seabios: update

Re: [Qemu-devel] [PATCH v4 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-10-19 Thread Michael S. Tsirkin
On Thu, Oct 19, 2017 at 05:43:18PM +0200, Paolo Bonzini wrote: > On 19/10/2017 17:39, Michael S. Tsirkin wrote: > >> Add VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG messages which can be > >> used for live migration of vhost user devices, also vhost user devices > >> can benefit from the messages t

Re: [Qemu-devel] [PATCH v3 42/46] util: Replace fprintf(stderr, "*\n" with error_report()

2017-10-19 Thread Thomas Huth
On 19.10.2017 18:18, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. [...] > diff --git a/util/aio-posix.c b/util/aio-posix.c > index 5946ac09f0

[Qemu-devel] [PULL v1 01/21] tpm-tis: remove unused hw_access argument

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau This argument is always false, simplify the code. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm

[Qemu-devel] [PULL v1 09/21] tpm: remove init() class method

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau No backend use it. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- backends/tpm.c | 4 +--- include/sysemu/tpm_backend.h | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/backends/tpm.c b/b

[Qemu-devel] [PULL v1 16/21] tpm: remove locty_data from TPMState

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau Keep it internal to tpm-tis instead. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- hw/tpm/tpm_emulator.c | 3 +-- hw/tpm/tpm_int.h | 2 -- hw/tpm/tpm_tis.c | 12 +--- 3 files changed, 6 insertions(+),

[Qemu-devel] [PULL v1 00/21] Merge tpm 2017/10/19

2017-10-19 Thread Stefan Berger
The following changes since commit f2a48d696c12aaac12993364371daae9f6233c37: Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20171018' into staging (2017-10-19 14:39:30 +0100) are available in the git repository at: git://github.com/stefanberger/qemu-tpm.git tags/pull-tpm-20

[Qemu-devel] [PULL v1 04/21] tpm: lookup tpm backend class in tpm_driver_find_by_type()

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau One step towards removing TPMDriverOps and driver registration. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- tpm.c | 29 + 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/tpm.c

[Qemu-devel] [PULL v1 21/21] tpm: move recv_data_callback to TPM interface

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau Simplify the TPM backend setup, move callback to TPM interface. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- backends/tpm.c | 4 +--- hw/tpm/tpm_emulator.c| 3 ++- hw/tpm/tpm_int.h |

[Qemu-devel] [PULL v1 17/21] tpm-tis: move TPMState to TIS header

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- hw/tpm/tpm_int.h | 23 ++- hw/tpm/tpm_tis.h | 19 +++ hw/tpm/tpm_util.c | 1 + 3 files changed, 22 insertions(+), 21 deletions(-) diff -

[Qemu-devel] [PULL v1 20/21] tpm: add a QOM TPM interface

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau This will simplify backend / interface objects relationship, so the frontend interface will simply have to implement the TPM QOM interface. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- backends/tpm.c | 8 hw/

[Qemu-devel] [PULL v1 07/21] tpm: move TPMSizedBuffer to tpm_tis.h

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau Close to where it's being used. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.h | 5 + include/sysemu/tpm_backend.h | 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/

[Qemu-devel] [PULL v1 11/21] tpm: remove unused TPMBackendCmd

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau There is only handling of request so far in both backends. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- backends/tpm.c | 7 ++- hw/tpm/tpm_emulator.c| 42 ---

[Qemu-devel] [PULL v1 13/21] tpm: remove locty argument from receive_cb

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau The tpm_state is passed as argument, the assert() is pointless since we give it the value of tpm_state->locty_number already. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- hw/tpm/tpm_emulator.c| 3 +-- hw/tpm/tpm_

[Qemu-devel] [PULL v1 03/21] tpm: make tpm_get_backend_driver() static

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau No need to export the function. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- include/sysemu/tpm_backend.h | 1 - tpm.c| 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/

[Qemu-devel] [PULL v1 10/21] tpm: remove configure_tpm() hop

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- tpm.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tpm.c b/tpm.c index 4882501..45520f5 100644 --- a/tpm.c +++ b/tpm.c @@ -86,7 +86,7 @@ TPMBackend

[Qemu-devel] [PULL v1 05/21] tpm: replace tpm_get_backend_driver() to drop be_drivers

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau Use tpm_driver_find_by_type() instead. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- tpm.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/tpm.c b/tpm.c index 04de8da..ad2ed6a 100644 --- a/

[Qemu-devel] [PULL v1 15/21] tpm-emulator: fix error handling

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau The previous patch cleaned up a bit error handling, and exposed an existing bug: error_report_err() could be called with a NULL error. Instead, make tpm_emulator_set_locality() set the error. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Ste

[Qemu-devel] [PULL v1 18/21] tpm-tis: remove tpm_tis.h header

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau The definitions are now private to TIS implementation. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- hw/tpm/tpm_passthrough.c | 1 - hw/tpm/tpm_tis.c | 72 - hw/tpm/tpm_tis.h

[Qemu-devel] [PULL v1 06/21] tpm: remove tpm_register_driver()

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau No more users of be_drivers[], drop that too. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- hw/tpm/tpm_emulator.c| 1 - hw/tpm/tpm_passthrough.c | 1 - include/sysemu/tpm_backend.h | 1 - tpm.c

[Qemu-devel] [PULL v1 08/21] tpm: remove TPMDriverOps

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau Use TPMBackendClass to hold class methods/fields. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- backends/tpm.c | 31 --- hw/tpm/tpm_emulator.c| 29

[Qemu-devel] [PULL v1 12/21] tpm: remove needless cast

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- hw/tpm/tpm_passthrough.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/tpm/tpm_passthrough.c b/hw/tpm/tpm_passthrough.c index 5cd988e..fed3d69 100644 -

[Qemu-devel] [PULL v1 19/21] tpm-tis: fold TPMTISEmuState in TPMState

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.c | 336 ++- 1 file changed, 157 insertions(+), 179 deletions(-) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_

[Qemu-devel] [PULL v1 14/21] tpm: add TPMBackendCmd to hold the request state

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau This simplifies a bit locality handling, and argument passing, and could pave the way to queuing requests (if that makes sense). Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- backends/tpm.c | 6 +++--- hw/t

[Qemu-devel] [PULL v1 02/21] tpm-tis: remove RAISE_STS_IRQ

2017-10-19 Thread Stefan Berger
From: Marc-André Lureau This look like temporary hacking code. It shouldn't be necessary in release code, or there should be a runtime option for it. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.c | 24 +--- 1

Re: [Qemu-devel] [PULL] qemu-sparc updates

2017-10-19 Thread Peter Maydell
On 19 October 2017 at 07:58, Mark Cave-Ayland wrote: > Hi Peter, > > Here are my sun4u patches for 2.11. Note that because of the machine changes > there is an openbios-sparc64 binary update included in the first patch to > maintain bisectability. There will be a follow-up patch for OpenBIOS which

Re: [Qemu-devel] [PULL] Update OpenBIOS images

2017-10-19 Thread Peter Maydell
On 19 October 2017 at 08:10, Mark Cave-Ayland wrote: > Hi Peter, > > Here are the latest set of updates for OpenBIOS which should be pulled after > the sun4u > patches have been applied due to breaking changes in the sun4u machine. > > > ATB, > > Mark. > > > The following changes since commit 861

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-19 Thread Dan Williams
On Thu, Oct 19, 2017 at 1:01 AM, Christoph Hellwig wrote: > On Wed, Oct 18, 2017 at 08:51:37AM -0700, Dan Williams wrote: >> This use case is not "Persistent Memory". Persistent Memory is >> something you can map and make persistent with CPU instructions. >> Anything that requires a driver call is

Re: [Qemu-devel] [PATCH v4 RFC 9/8] nbd: Minimal structured read for client

2017-10-19 Thread Eric Blake
On 10/17/2017 07:57 AM, Vladimir Sementsov-Ogievskiy wrote: > Minimal implementation: for structured error only error_report error > message. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- and I replied: > > But in the client, I then perform 'w 0 0' (a zero-byte write, which > should fai

Re: [Qemu-devel] [PATCH v3 0/7] migration: pause-before-switchover

2017-10-19 Thread Dr. David Alan Gilbert
* Jiri Denemark (jdene...@redhat.com) wrote: > The libvirt changes which will make use of this new migration capability > can be found in migration-pause branch of my gitlab repository: > > git fetch https://gitlab.com/jirkade/libvirt.git migration-pause > > It's not properly split into patch

Re: [Qemu-devel] [PULL] Update OpenBIOS images

2017-10-19 Thread Mark Cave-Ayland
On 19/10/17 19:18, Peter Maydell wrote: > On 19 October 2017 at 08:10, Mark Cave-Ayland > wrote: >> Hi Peter, >> >> Here are the latest set of updates for OpenBIOS which should be pulled after >> the sun4u >> patches have been applied due to breaking changes in the sun4u machine. >> >> >> ATB, >

Re: [Qemu-devel] [PATCH v3 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-10-19 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 20171016222315.407-1-mdr...@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH v3 0/3] qdev/vfio: defer

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-19 Thread Sean Feole
will test these and report back shortly. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1719196 Title: [arm64 ocata] newly created instances are unable to raise network interfaces Status in Ubunt

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-19 Thread Andrew McLeod
I've tested with the packages from the ppa: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/2995 qemu: Installed: 1:2.8+dfsg-3ubuntu2.7~ppa5cloud qemu-system-arm: Installed: 1:2.8+dfsg-3ubuntu2.7~ppa5cloud qemu-system-aarch64: Installed: 1:2.8+dfsg-3ubuntu2.7~ppa5cloud Reboot

[Qemu-devel] [PATCH] configure: disable qemu-keymap for linux-user qemu

2017-10-19 Thread Laurent Vivier
We don't need qemu-keymap when we build only linux-user qemu. When we compile in static mode, the libxkbcommon is detected by configure if the shared one is available, but cannot be linked if the static version is not available. As we don't need it for qemu-linux-user, and we generally need a sta

Re: [Qemu-devel] [PATCH v1] arm: Adding new arm machine, Kinetis K64 MK64FN1M0

2017-10-19 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1508417443-31849-1-git-send-email-gabriel291...@gmail.com Subject: [Qemu-devel] [PATCH v1] arm: Adding new arm machine, Kinetis K64 MK64FN1M0 === TEST SCRIPT BEGIN === #!/bi

Re: [Qemu-devel] [PATCH v2] arm: Adding makefile for Kinetis K64 MK64FN1M0

2017-10-19 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1508417485-31911-1-git-send-email-gabriel291...@gmail.com Subject: [Qemu-devel] [PATCH v2] arm: Adding makefile for Kinetis K64 MK64FN1M0 === TEST SCRIPT BEGIN === #!/bin/bas

Re: [Qemu-devel] [PATCH v4 6/8] nbd/client: refactor nbd_receive_starttls

2017-10-19 Thread Eric Blake
On 10/14/2017 08:01 PM, Eric Blake wrote: > From: Vladimir Sementsov-Ogievskiy > > Split out nbd_request_simple_option to be reused for structured reply > option. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Eric Blake > > +static int nbd_request_simple_option(QIOChannel

Re: [Qemu-devel] [PATCH v2] arm: Adding makefile for Kinetis K64 MK64FN1M0

2017-10-19 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1508417485-31911-1-git-send-email-gabriel291...@gmail.com Subject: [Qemu-devel] [PATCH v2] arm: Addin

Re: [Qemu-devel] [PATCH v3 42/46] util: Replace fprintf(stderr, "*\n" with error_report()

2017-10-19 Thread Stefan Weil
Am 19.10.2017 um 19:53 schrieb Thomas Huth: > On 19.10.2017 18:18, Alistair Francis wrote: >> Replace a large number of the fprintf(stderr, "*\n" calls with >> error_report(). The functions were renamed with these commands and then >> compiler issues where manually fixed. > [...] >> diff --git a/ut

Re: [Qemu-devel] [PATCH v4 RFC 9/8] nbd: Minimal structured read for client

2017-10-19 Thread Eric Blake
On 10/17/2017 07:57 AM, Vladimir Sementsov-Ogievskiy wrote: > Minimal implementation: for structured error only error_report error > message. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > +static int nbd_co_request(BlockDriverState *bs, NBDRequest *request, > +

Re: [Qemu-devel] [RFC 0/6] enable numa configuration before machine_init() from HMP/QMP

2017-10-19 Thread Eduardo Habkost
On Thu, Oct 19, 2017 at 04:28:59PM +0100, Daniel P. Berrange wrote: > On Thu, Oct 19, 2017 at 11:21:22AM -0400, Igor Mammedov wrote: > > - Original Message - > > > From: "Daniel P. Berrange" > > > To: "Igor Mammedov" > > > Cc: "peter maydell" , pkre...@redhat.com, > > > ehabk...@redhat.c

[Qemu-devel] [PATCH] build: Don't force preserving permissions on config-devices.mak.old

2017-10-19 Thread Aaron Lindsay
I get the following error when building on an NFSv3 filesystem: % make -j8 GEN aarch64-softmmu/config-devices.mak.tmp GEN config-host.h [snip] GEN qmp-marshal.c GEN aarch64-softmmu/config-devices.mak cp: preserving permissions for ‘aarch64-softmmu/config-devices.mak.old’:

Re: [Qemu-devel] [PATCH v6 00/50] tcg tb_lock removal

2017-10-19 Thread Emilio G. Cota
On Thu, Oct 19, 2017 at 15:05:17 +0200, Paolo Bonzini wrote: > On 19/10/2017 00:45, Emilio G. Cota wrote: > > I have just pushed a branch on top of this series that includes > > 10 patches that further pave the way for the removal of tb_lock: > > > > https://github.com/cota/qemu/tree/multi-tcg-v

[Qemu-devel] [PATCH] translate-all: exit from tb_phys_invalidate if qht_remove fails

2017-10-19 Thread Emilio G. Cota
Two or more threads might race while invalidating the same TB. We currently do not check for this at all despite taking tb_lock, which means we would wrongly invalidate the same TB more than once. This bug has actually been hit by users: I recently saw a report on IRC, although I have yet to see th

Re: [Qemu-devel] [PATCH v6 0/9] Support the Capstone disassembler

2017-10-19 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 20171019155146.30434-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v6 0/9] Support the

Re: [Qemu-devel] [PATCH v4 RFC 9/8] nbd: Minimal structured read for client

2017-10-19 Thread Eric Blake
On 10/17/2017 04:17 PM, Eric Blake wrote: > On 10/17/2017 07:57 AM, Vladimir Sementsov-Ogievskiy wrote: >> Minimal implementation: for structured error only error_report error >> message. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- > But in the client, I then perform 'w 0 0' (a zero-

Re: [Qemu-devel] Running Qemu in discrete time/step by step

2017-10-19 Thread Emilio G. Cota
On Thu, Oct 19, 2017 at 14:14:12 +0900, Matt wrote: (snip) > - VMSimint does nearly that, it runs Qemu in discrete time but > interface it with a JAVA simulator > http://www.ikr.uni-stuttgart.de/Content/Publications/Archive/We_SIMUTools_2014_40209.pdf > (with the code http://www.ikr.uni-stuttgart.d

Re: [Qemu-devel] [PATCH] fix WFI/WFE length in syndrome register

2017-10-19 Thread Stefano Stabellini
On Thu, 19 Oct 2017, Peter Maydell wrote: > On 18 October 2017 at 23:03, Stefano Stabellini > wrote: > > WFI/E are 4 bytes long: set ARM_EL_IL_SHIFT in the syndrome. > > > > Signed-off-by: Stefano Stabellini > > > > diff --git a/target/arm/internals.h b/target/arm/internals.h > > index 1f6efef..

[Qemu-devel] unknown keycodes `(unnamed)'

2017-10-19 Thread Spaceboy Ross
unknown keycodes `(unnamed)', please report to qemu-devel@nongnu.org uname -a returns: Linux spaceboyross-Latitude-D630 4.13.0-16-generic #19-Ubuntu SMP Wed Oct 11 18:35:14 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

Re: [Qemu-devel] [PATCH v5 03/10] qemu-iotests: automatically clean up bash protocol servers

2017-10-19 Thread Paolo Bonzini
On 19/10/2017 16:52, Jeff Cody wrote: > On Thu, Oct 19, 2017 at 12:23:39PM +0200, Paolo Bonzini wrote: >> On 18/10/2017 19:27, Jeff Cody wrote: >>> On final exit, yes, a test needs not remember to remove all of its mouse >>> droppings. But as far as not needing to remove images in intermediate >>>

Re: [Qemu-devel] [PATCH v4 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-10-19 Thread Paolo Bonzini
On 19/10/2017 19:43, Michael S. Tsirkin wrote: > On Thu, Oct 19, 2017 at 05:43:18PM +0200, Paolo Bonzini wrote: >> On 19/10/2017 17:39, Michael S. Tsirkin wrote: Add VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG messages which can be used for live migration of vhost user devices, also vhost

Re: [Qemu-devel] [PATCH] don't hardcode EL1 in extended_addresses_enabled

2017-10-19 Thread Stefano Stabellini
On Thu, 19 Oct 2017, Peter Maydell wrote: > On 18 October 2017 at 23:41, Stefano Stabellini > wrote: > > extended_addresses_enabled calls arm_el_is_aa64, hardcoding exception > > level 1. Instead, retrieve the current el calling arm_current_el. > > > > Signed-off-by: Stefano Stabellini > > > > d

[Qemu-devel] [PATCH 2/2] target/arm: Don't set INSN_ARM_BE32 for CONFIG_USER_ONLY

2017-10-19 Thread Richard Henderson
This matches translator behaviour in arm_lduw_code. Fixes: https://bugs.launchpad.net/qemu/+bug/1724485 Signed-off-by: Richard Henderson --- target/arm/cpu.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index bc9d70df04..a0ed11c

[Qemu-devel] [PATCH 0/2] Fix armeb-linux-user disassembly

2017-10-19 Thread Richard Henderson
Reported in https://bugs.launchpad.net/qemu/+bug/1724485 There's one existing bug here, wrt setting INSN_ARM_BE32, and another when it comes to the capstone disassembler patch set. r~ Richard Henderson (2): target/arm: Move BE32 disassembler fixup target/arm: Don't set INSN_ARM_BE32 for

[Qemu-devel] [PATCH 1/2] target/arm: Move BE32 disassembler fixup

2017-10-19 Thread Richard Henderson
The Capstone disassembler has its own big-endian fixup. Doing this twice does not work, of course. Move our current fixup from target/arm/cpu.c to disas/arm.c. This makes read_memory_inner_func unused and can be removed. Signed-off-by: Richard Henderson --- include/disas/bfd.h | 7 --- di

Re: [Qemu-devel] [PATCH v4 5/8] nbd/server: Include human-readable message in structured errors

2017-10-19 Thread Eric Blake
On 10/14/2017 08:01 PM, Eric Blake wrote: > The NBD spec permits including a human-readable error string if > structured replies are in force, so we might as well send the > client the message that we logged on any error. > > Signed-off-by: Eric Blake > --- > nbd/server.c | 22 ++

Re: [Qemu-devel] [PATCH 24/42] tpm-be: call request_completed() out of thread

2017-10-19 Thread Stefan Berger
On 10/09/2017 06:56 PM, Marc-André Lureau wrote: Lift from the backend implementation the responsability to call the request_completed() callback outside of thread context. This also I don't think this is what you are doing here. It's still in thread context. Something is breaking the TIS inte

Re: [Qemu-devel] [PULL 07/11] tools: add qemu-keymap

2017-10-19 Thread Eric Blake
On 10/16/2017 08:16 AM, Gerd Hoffmann wrote: > qemu-keymap generates qemu reverse keymaps from xkb keymaps, > which can be used with the qemu "-k" command line switch. > > Signed-off-by: Gerd Hoffmann > Message-id: 20171005153330.19210-2-kra...@redhat.com > --- > configure | 23 ++ > Ma

Re: [Qemu-devel] [PULL 07/11] tools: add qemu-keymap

2017-10-19 Thread Eric Blake
On 10/19/2017 05:09 PM, Eric Blake wrote: > On 10/16/2017 08:16 AM, Gerd Hoffmann wrote: >> qemu-keymap generates qemu reverse keymaps from xkb keymaps, >> which can be used with the qemu "-k" command line switch. >> >> Signed-off-by: Gerd Hoffmann >> Message-id: 20171005153330.19210-2-kra...@redh

[Qemu-devel] [PATCH v5 02/11] nbd: Move nbd_errno_to_system_errno() to public header

2017-10-19 Thread Eric Blake
This is needed in preparation for structured reply handling, as we will be performing the translation from NBD error to system errno value higher in the stack at block/nbd-client.c. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 13 + n

[Qemu-devel] [PATCH v5 00/11] nbd minimal structured read

2017-10-19 Thread Eric Blake
I've incorporated a few more tweaks since v4: https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg03305.html I tried to call out the biggest changes in the various commits, but it includes bug fixes from my testing, and fixing places spotted by Vladimir. I still haven't validated the behavio

[Qemu-devel] [PATCH v5 04/11] nbd/server: Report error for write to read-only export

2017-10-19 Thread Eric Blake
When the server is read-only, we were already reporting an error message for NBD_CMD_WRITE_ZEROES, but failed to set errp for a similar NBD_CMD_WRITE. This will matter more once structured replies allow the server to propagate the errp information back to the client. While at it, use an error mes

[Qemu-devel] [PATCH v5 03/11] nbd: Expose constants and structs for structured read

2017-10-19 Thread Eric Blake
Upcoming patches will implement the NBD structured reply extension [1] for both client and server roles. Declare the constants, structs, and lookup routines that will be valuable whether the server or client code is backported in isolation. This includes moving one constant from an internal heade

[Qemu-devel] [PATCH v5 07/11] nbd/server: Include human-readable message in structured errors

2017-10-19 Thread Eric Blake
The NBD spec permits including a human-readable error string if structured replies are in force, so we might as well send the client the message that we logged on any error. Signed-off-by: Eric Blake --- v5: allow NULL msg, cast away const for ease of use [Vladimir]; send correct length over the

[Qemu-devel] [PATCH v5 10/11] nbd: Move nbd_read() to common header

2017-10-19 Thread Eric Blake
An upcoming change to block/nbd-client.c will want to read the tail of a structured reply chunk directly from the wire. Move this function to make it easier. Based on a patch from Vladimir Sementsov-Ogievskiy. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- include/blo

[Qemu-devel] [PATCH v5 01/11] nbd: Include error names in trace messages

2017-10-19 Thread Eric Blake
NBD errors were originally sent over the wire based on Linux errno values; but not all the world is Linux, and not all platforms share the same values. Since a number isn't very easy to decipher on all platforms, update the trace messages to include the name of NBD errors being sent/received over

[Qemu-devel] [PATCH v5 05/11] nbd/server: Refactor zero-length option check

2017-10-19 Thread Eric Blake
Consolidate the check for a zero-length payload to an option into a new function, nbd_check_zero_length(); this check will also be used when introducing support for structured replies. By sticking a catch-all check at the end of the loop for processing options, we can simplify several of the inter

[Qemu-devel] [PATCH v5 08/11] nbd/client: refactor nbd_receive_starttls

2017-10-19 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Split out nbd_request_simple_option to be reused for structured reply option. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Eric Blake --- v5: only check length for ACK responses v4: reduce redundant traces, typo fix in commit message --- nbd/c

<    1   2   3   4   >