[Qemu-devel] [Bug 1723984] Re: ID_MMFR0 has an invalid value on aarch64 cpu (A57, A53)

2017-10-18 Thread Bug
I see your point. Thank you for the advice. I'm doing some low-level check to be sure to be on a known platform, so this midr based code is very localized. For the "core" of the kernel, I'm mostly using (1) as access to MMU registers are localized in armv7/armv8 specialized sub- directories. -- Y

Re: [Qemu-devel] [PATCH] docker: cleanup temp directory after test

2017-10-18 Thread Fam Zheng
On Tue, 10/17 15:12, Peter Xu wrote: > There are temp directories named "docker-src.*" after doing docker > tests. I don't see much point in keeping that (it only contains the > qemu.tar which is exactly current tree, and the copied "run" file). > Let's remove it after test finished. > > CC: "Ale

Re: [Qemu-devel] [PATCH v3 0/7] improve error handling for IO instr

2017-10-18 Thread Cornelia Huck
On Tue, 17 Oct 2017 18:19:20 +0200 Halil Pasic wrote: > On 10/17/2017 05:13 PM, Cornelia Huck wrote: > > On Tue, 17 Oct 2017 16:04:46 +0200 > > Halil Pasic wrote: > > > >> Abstract > >> === > >> > >> The basic idea is: tell how to handle an unusual condition where it's > >> identified, in

[Qemu-devel] [PATCH] docker: Fix PATH for ccache

2017-10-18 Thread Fam Zheng
Before bcd7f06f57fb6f780a3e2f7a46c22b6f6c8238aa we source /etc/profile so the PATH included the right paths to ccache binaries. Now we need to update $PATH explicitly from run script. Keep the old /usr/lib around just so that in the future, ccache from 32 bit images will just work. Signed-off-by:

Re: [Qemu-devel] [PATCH v6 38/50] translate-all: use a binary search tree to track TBs in TBContext

2017-10-18 Thread Paolo Bonzini
On 16/10/2017 19:25, Richard Henderson wrote: > * Translation Cache-related fields of a TB. > + * This struct exists just for convenience; we keep track of TB's in a binary > + * search tree, and the only fields needed to compare TB's in the tree are > + * @ptr and @size. @search is brought here

Re: [Qemu-devel] [PATCH v3 33/42] hw/acpi: ACPI_PM_* defines are not restricted to i386 arch

2017-10-18 Thread Igor Mammedov
On Tue, 17 Oct 2017 13:44:17 -0300 Philippe Mathieu-Daudé wrote: > this allows to remove the old i386/pc dependency on acpi/core. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > include/hw/acpi/acpi.h | 11 +++ > include/hw/i386/pc.h | 11 --- >

Re: [Qemu-devel] [PATCH v3 34/42] hw/acpi/ich9: extract ACPI_PM_PROP_TCO_ENABLED from i386/pc

2017-10-18 Thread Igor Mammedov
On Tue, 17 Oct 2017 13:44:18 -0300 Philippe Mathieu-Daudé wrote: > enable_tco is specific to i386/pc. > > Suggested-by: Paolo Bonzini > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > include/hw/acpi/ich9.h | 2 ++ > include/hw/i386/pc.h | 2 -- > 2 files changed,

Re: [Qemu-devel] [PATCH v3 2/5] bcm2836: Use the Cortex-A7 instead of Cortex-A15

2017-10-18 Thread Igor Mammedov
On Tue, 17 Oct 2017 15:31:14 -0700 Alistair Francis wrote: > The BCM2836 uses a Cortex-A7 not a Cortex-A15. Update the device to use > the correct CPU. > https://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2836/QA7_rev3.4.pdf > > Signed-off-by: Alistair Francis Reviewed-by: Igor M

Re: [Qemu-devel] [PATCH RFC] file-posix: make lock_fd read-only

2017-10-18 Thread Fam Zheng
On Wed, 10/11 11:48, Kevin Wolf wrote: > Am 11.10.2017 um 11:38 hat Vladimir Sementsov-Ogievskiy geschrieben: > > 11.10.2017 12:22, Kevin Wolf wrote: > > > [ Cc: Fam ] Sorry for being slow, now finally getting my hands on email backlog after holiday and preparing for KVM Forum presentation. > > >

[Qemu-devel] [Bug 1724477] [NEW] Build-in websocket broken since v2.9.0-rc0

2017-10-18 Thread Raghav Sinha
Public bug reported: Since upgrading to 2.9.0, the qemu's build-in websocket was no longer available. Host: Ubuntu 16.04 LTS Command-line: /bin/qemu-system-x86_64 -enable-kvm -vnc 0.0.0.0:8,websocket I have tested the following qemu versions: master Fail 2.10.1 Fail 2.9.1 Fail 2

Re: [Qemu-devel] [PULL 06/36] docker: Enable features explicitly in test-full

2017-10-18 Thread Fam Zheng
On Mon, 10/02 16:21, Paolo Bonzini wrote: > On 22/09/2017 09:46, Fam Zheng wrote: > > Also avoid "set -e". > > > > Signed-off-by: Fam Zheng > > Message-Id: <20170907141245.31946-3-f...@redhat.com> > > Reviewed-by: Eric Blake Sorry for late reply, I've had a backlog due to holiday and KVM Forum.

[Qemu-devel] [Bug 1724477] Re: Build-in websocket broken since v2.9.0-rc0

2017-10-18 Thread Raghav Sinha
** Attachment added: "PrintScreen2.png" https://bugs.launchpad.net/qemu/+bug/1724477/+attachment/4974571/+files/PrintScreen2.png -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1724477 Title: Bui

Re: [Qemu-devel] [PATCH v3 1/7] s390x/css: be more consistent if broken beyond repair

2017-10-18 Thread Thomas Huth
On 17.10.2017 16:04, Halil Pasic wrote: > Calling do_subchannel_work with no function control flags set in SCSW is > a programming error. Currently the handle this differently in > do_subchannel_work_virtual and do_subchannel_work_passthrough. Let's be > consistent and guard with a common assert ag

[Qemu-devel] [PATCH] Revert "docker: Enable features explicitly in test-full"

2017-10-18 Thread Fam Zheng
This reverts commit 5e8a7fe673ca5949bd51939ee36faaf3b1320de8. It's hard to get all images to have all these packages, the usual "FEATURES" and "require" mechanism doesn't scale with so many features. With that change, the test basically only works in ubuntu. Until a better way comes up, leave the

Re: [Qemu-devel] [PATCH v3 0/7] improve error handling for IO instr

2017-10-18 Thread Dong Jia Shi
* Halil Pasic [2017-10-17 18:19:20 +0200]: [...] > >> Testing > >> === > >> > >> Nothing happened since v2 except for a quick smoke test. Dong Jia gave v2 > >> a spin with a focus on vfio-ccw. @Dong Jia I would appreciate some proper > >> testing, especially regarding the changes in vfio-ccw

Re: [Qemu-devel] [PATCH] docker: Fix PATH for ccache

2017-10-18 Thread Fam Zheng
On Wed, 10/18 01:08, no-re...@patchew.org wrote: > Your branch is up-to-date with 'origin/test'. > Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' > Cloning into > '/var/tmp/patchew-tester-tmp-jhpnlaz0/src/docker-src.2017-10-18-04.03.32.32287/qemu.tar.vroot/dtc'... >

[Qemu-devel] [PATCH 22/40] fixup: sh4: simplify superh_cpu_class_by_name()

2017-10-18 Thread Igor Mammedov
with "sh4: simplify superh_cpu_class_by_name()" no longer accepts type names as cpu_model but linux-useri/main.c still uses type name as default, fix it up and use cpu_model instead Signed-off-by: Igor Mammedov --- CC: Philippe Mathieu-Daudé CC: Eduardo Habkost CC: aurel...@aurel32.net --- lin

[Qemu-devel] [Bug 1724485] [NEW] Invalid assertion in arm_read_memory_func

2017-10-18 Thread Christophe Lyon
Public bug reported: Hi, I think there is an invalid assertion in arm_read_memory_func: assert(info->endian == BFD_ENDIAN_LITTLE) I face it in the following use case: target armeb-linux (I use qemu user mode), -d in_asm -cpu any. At some point during program startup, glibc's _dl_new_object call

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-18 Thread ChristianEhrhardt
So, libvirt knew about some change and picks the right default if you do not specify it. But if you (Openstack in this case) specify virtio-mmio as type, then it fails - is that correct? The patch in the referred RH-BZ is already in the qemu we have in Artful (and thereby Ocata). So if that is

Re: [Qemu-devel] [Xen-devel] [RFC QEMU PATCH v3 00/10] Implement vNVDIMM for Xen HVM guest

2017-10-18 Thread Roger Pau Monné
On Tue, Oct 17, 2017 at 08:16:47PM +0800, Haozhong Zhang wrote: > On 10/17/17 13:45 +0200, Paolo Bonzini wrote: > > On 14/10/2017 00:46, Stefano Stabellini wrote: > > > On Fri, 13 Oct 2017, Jan Beulich wrote: > > > On 13.10.17 at 13:13, wrote: > > >>> To Jan, Andrew, Stefano and Anthony, > > >

[Qemu-devel] [PATCH] tpm: Fix compilation with --disable-tpm

2017-10-18 Thread Juan Quintela
Commit c37cacabf2285b0731b44c1f667781fdd4f2b658 broke compilation without tpm. Just add an empty tpm_cleanup() stub. CC: Amarnath Valluri Signed-off-by: Juan Quintela --- tpm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tpm.c b/tpm.c index 317156..9396bb669c 100644 --- a

Re: [Qemu-devel] [PATCH] docker: Fix PATH for ccache

2017-10-18 Thread Daniel P. Berrange
On Wed, Oct 18, 2017 at 04:28:36PM +0800, Fam Zheng wrote: > On Wed, 10/18 01:08, no-re...@patchew.org wrote: > > Your branch is up-to-date with 'origin/test'. > > Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path > > 'dtc' > > Cloning into > > '/var/tmp/patchew-tester-tmp-

Re: [Qemu-devel] [PATCH v3 1/3] qdev: store DeviceState's canonical path to use when unparenting

2017-10-18 Thread Paolo Bonzini
On 17/10/2017 07:45, David Gibson wrote: >> >> post_realize_fail: >> +g_free(dev->canonical_path); > Should dev->canonical_path be set to NULL on this failure path? > It should be fine because dev->pending_deleted_event can only become true if dev->realized has ever been set to true. But

Re: [Qemu-devel] [PATCH 01/10] migration: Fix migrate_test_apply for multifd parameters

2017-10-18 Thread Juan Quintela
Peter Xu wrote: > On Tue, Oct 10, 2017 at 08:15:33PM +0200, Juan Quintela wrote: >> They were missing when introduced on the tree >> >> Signed-off-by: Juan Quintela >> --- >> migration/migration.c | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/migration/migration.c b/migrati

[Qemu-devel] [Bug 1724477] Re: Build-in websocket broken since v2.9.0-rc0

2017-10-18 Thread Daniel Berrange
Note that we tightened up the websocket server impl to validate HTTP requests more strictly. One key change is that the websockets path is required to be empty, while noVNC will default to appending a path - so make sure you change noVNC to have an empty path. Also until GIT master yesterday, there

Re: [Qemu-devel] [PATCH 06/10] migration: Make sure that we pass the right cache size

2017-10-18 Thread Juan Quintela
Peter Xu wrote: > On Tue, Oct 10, 2017 at 08:15:38PM +0200, Juan Quintela wrote: >> Instead of passing silently round down the number of pages, make it an >> error that the cache size is not a multiple of 2. > > s/multiple/power/? Thanks. > Would this patch break existing users? I have a proble

Re: [Qemu-devel] [PATCH v3 2/7] s390x/css: IO instr handler ending control

2017-10-18 Thread Thomas Huth
On 17.10.2017 16:04, Halil Pasic wrote: > CSS code needs to tell the IO instruction handlers located in how should locate in? ... sorry, I've got trouble to parse this sentence ... > the emulated instruction be ended. Currently this is done by returning > generic (POSIX) error codes, and mapping

Re: [Qemu-devel] [PATCH 1/4] tests: Rename pc-cpu-test.c to cpu-plug-test.c

2017-10-18 Thread David Hildenbrand
On 17.10.2017 15:32, Thomas Huth wrote: > The test will be extended to work on other architectures, too, so let's > use a more generic name for the file and the functions in here first. > > Signed-off-by: Thomas Huth > --- > tests/Makefile.include | 4 ++-- > tests/{pc-cpu-tes

Re: [Qemu-devel] [Xen-devel] [RFC QEMU PATCH v3 00/10] Implement vNVDIMM for Xen HVM guest

2017-10-18 Thread Paolo Bonzini
On 18/10/2017 10:32, Roger Pau Monné wrote: >> I'll have a try to check how much the differences would affect. If it >> would not take too much work, I'd like to adapt Xen NVDIMM enabling >> patches to the all QEMU built ACPI. Otherwise, I'll fall back to Paolo >> and MST's suggestions. > I don't a

Re: [Qemu-devel] [PATCH 09/10] migration: Make xbzrle_cache_size a migration parameter

2017-10-18 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Right now it is a variable in MigrationState instead of a >> MigrationParameter. The change allows to set it as the rest of the >> Migration parameters, from the command line, with >> query_migration_paramters, set_

Re: [Qemu-devel] [Qemu devel v2 PATCH] msf2: Remove dead code reported by Coverity

2017-10-18 Thread Darren Kenny
On Wed, Oct 18, 2017 at 03:40:38AM +, Subbaraya Sundeep wrote: Fixed incorrect frame size mask, validated maximum frame size in spi_write and removed dead code. Signed-off-by: Subbaraya Sundeep --- v2: else if -> else in set_fifodepth log guest error when frame size is more

Re: [Qemu-devel] [Xen-devel] [RFC QEMU PATCH v3 00/10] Implement vNVDIMM for Xen HVM guest

2017-10-18 Thread Roger Pau Monné
On Wed, Oct 18, 2017 at 10:46:57AM +0200, Paolo Bonzini wrote: > On 18/10/2017 10:32, Roger Pau Monné wrote: > >> I'll have a try to check how much the differences would affect. If it > >> would not take too much work, I'd like to adapt Xen NVDIMM enabling > >> patches to the all QEMU built ACPI. O

Re: [Qemu-devel] [PATCH 2/4] tests/cpu-plug-test: Check the CPU hot-plugging with device_add, too

2017-10-18 Thread David Hildenbrand
On 17.10.2017 15:32, Thomas Huth wrote: > Using 'device_add' instead of 'cpu-add' is the new way for > hot-plugging CPUs, so we should test this regularly, too. > > Signed-off-by: Thomas Huth > --- > tests/cpu-plug-test.c | 42 -- > 1 file changed, 40 inse

Re: [Qemu-devel] [PATCH 4/4] tests/cpu-plug-test: Test CPU hot-plugging on s390x

2017-10-18 Thread David Hildenbrand
On 17.10.2017 15:32, Thomas Huth wrote: > CPU hot-plugging on s390x is possible with both, "cpu-add" > and "device_add", so test both. > > Signed-off-by: Thomas Huth > --- > tests/Makefile.include | 1 + > tests/cpu-plug-test.c | 38 ++ > 2 files changed, 39

Re: [Qemu-devel] [PATCH 3/7] migration: Wait for semaphore before completing migration

2017-10-18 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Oct 11, 2017 at 08:13:13PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Wait for a semaphore before completing the migration, > > if the previously added capability was enabled. > > > > Signed-off-by: Dr. Da

[Qemu-devel] [Bug 1724485] Re: Invalid assertion in arm_read_memory_func

2017-10-18 Thread Christophe Lyon
The tarball contains: scoped1.exe etc/ld.so.cache lib/libm.so.6 lib/libstdc++.so.6 lib/lib.c.so.6 lib/ld-linux-armhf.so.3 lib/libgcc_s.so.1 I can reproduce the problem with qemu-2.10.1: qemu-armeb -E LD_LIBRARY_PATH=$PWD/lib -cpu any -R 0 -d in_asm -L $PWD $PWD/scoped1.exe Removing '-d in_asm' w

Re: [Qemu-devel] [PATCH] tpm: Fix compilation with --disable-tpm

2017-10-18 Thread Laurent Vivier
On 18/10/2017 10:33, Juan Quintela wrote: > Commit >c37cacabf2285b0731b44c1f667781fdd4f2b658 > > broke compilation without tpm. Just add an empty tpm_cleanup() stub. tpm_init() and tpm_config_parse() are managed in a different way: they are included in a "#ifdef CONFIG_TPM .. #endif" in vl.c

Re: [Qemu-devel] [PATCH] sun4u: fix assert when adding NICs which aren't the in-built model

2017-10-18 Thread Artyom Tarasenko
On Sun, Oct 15, 2017 at 11:21 AM, Mark Cave-Ayland wrote: > Commit 8d93297 introduced a bug whereby non-inbuilt NICs are realized before > setting the default MAC address causing an assert. Switch NIC creation > over from pci_create_simple() to pci_create() which works exactly the > same except om

Re: [Qemu-devel] [PATCHv3 00/13] sun4m: sparc32_dma tidy-ups

2017-10-18 Thread Artyom Tarasenko
On Sat, Oct 14, 2017 at 8:38 PM, Mark Cave-Ayland wrote: > This patchset aims to tidy-up the sparc32_dma code by improving the > modelling of the espdma/ledma devices using both QOM and the memory > API which didn't exist when the code was first written. > > The result is that it is now possible t

Re: [Qemu-devel] [PATCH v3 2/7] s390x/css: IO instr handler ending control

2017-10-18 Thread Dong Jia Shi
* Halil Pasic [2017-10-17 16:04:48 +0200]: [...] > diff --git a/include/hw/s390x/css.h b/include/hw/s390x/css.h > index 69b374730e..7e0dbd162f 100644 > --- a/include/hw/s390x/css.h > +++ b/include/hw/s390x/css.h > @@ -99,6 +99,22 @@ typedef struct CcwDataStream { > hwaddr cda; > } CcwDataS

Re: [Qemu-devel] [PATCH v4 06/20] iscsi: Switch iscsi_allocmap_update() to byte-based

2017-10-18 Thread Paolo Bonzini
On 12/10/2017 20:59, Eric Blake wrote: > We are gradually converting to byte-based interfaces, as they are > easier to reason about than sector-based. Convert all uses of > the allocmap (no semantic change). Callers that already had bytes > available are simpler, and callers that now scale to byt

Re: [Qemu-devel] [PATCH v4 07/20] iscsi: Switch to .bdrv_co_block_status()

2017-10-18 Thread Paolo Bonzini
On 12/10/2017 20:59, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. Update the iscsi driver accordingly. In this case, > it is handy to teach iscsi_co_block_status() to handle a NULL map > and file parameter, even though the block layer passes

Re: [Qemu-devel] [PATCH v4 05/20] iscsi: Switch cluster_sectors to byte-based

2017-10-18 Thread Paolo Bonzini
On 12/10/2017 20:59, Eric Blake wrote: > We are gradually converting to byte-based interfaces, as they are > easier to reason about than sector-based. Convert all uses of > the cluster size in sectors, along with adding assertions that we > are not dividing by zero. > > Signed-off-by: Eric Blake

Re: [Qemu-devel] [PATCH] tpm: Fix compilation with --disable-tpm

2017-10-18 Thread Juan Quintela
Laurent Vivier wrote: > On 18/10/2017 10:33, Juan Quintela wrote: >> Commit >>c37cacabf2285b0731b44c1f667781fdd4f2b658 >> >> broke compilation without tpm. Just add an empty tpm_cleanup() stub. > > tpm_init() and tpm_config_parse() are managed in a different way: they > are included in a "#i

Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH

2017-10-18 Thread Thomas Huth
On 17.10.2017 16:04, Halil Pasic wrote: > Simplify the error handling of the SSCH and RSCH handler avoiding > arbitrary and cryptic error codes being used to tell how the instruction > is supposed to end. Let the code detecting the condition tell how it's > to be handled in a less ambiguous way.

Re: [Qemu-devel] [PATCH v3 4/7] s390x: refactor error handling for XSCH handler

2017-10-18 Thread Thomas Huth
On 17.10.2017 16:04, Halil Pasic wrote: > Simplify the error handling of the XSCH. Let the code detecting the > condition tell (in a less ambiguous way) how it's to be handled. No > changes in behavior. > > Signed-off-by: Halil Pasic > --- > hw/s390x/css.c | 17 + > incl

Re: [Qemu-devel] [PATCH v3 2/7] s390x/css: IO instr handler ending control

2017-10-18 Thread Cornelia Huck
On Wed, 18 Oct 2017 10:45:28 +0200 Thomas Huth wrote: > On 17.10.2017 16:04, Halil Pasic wrote: > > CSS code needs to tell the IO instruction handlers located in how should > > locate in? ... sorry, I've got trouble to parse this sentence ... "located in ioinst.c", I guess. And maybe also mo

Re: [Qemu-devel] [PATCH v3 5/7] s390x: refactor error handling for CSCH handler

2017-10-18 Thread Thomas Huth
On 17.10.2017 16:04, Halil Pasic wrote: > Simplify the error handling of the cSCH. Let the code detecting the > condition tell (in a less ambiguous way) how it's to be handled. No > changes in behavior. > > Signed-off-by: Halil Pasic > --- > hw/s390x/css.c | 12 +++- > include/h

Re: [Qemu-devel] [PATCH 0/2] add "nopin" option in the memory-backend-file

2017-10-18 Thread Paolo Bonzini
On 18/10/2017 07:57, Zhong Yang wrote: > Your suggestion can avoid DMA target to nvdimm if the nvdimm memory region > was skipped during VFIO hotplug. It is valuable to try this solution. by the > way, please share me some clue for PCI address space related with memory > region, > below ad

Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH

2017-10-18 Thread Cornelia Huck
On Wed, 18 Oct 2017 11:30:47 +0200 Thomas Huth wrote: > On 17.10.2017 16:04, Halil Pasic wrote: > > Simplify the error handling of the SSCH and RSCH handler avoiding > > arbitrary and cryptic error codes being used to tell how the instruction > > is supposed to end. Let the code detecting the co

Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH

2017-10-18 Thread Thomas Huth
On 18.10.2017 11:30, Thomas Huth wrote: > On 17.10.2017 16:04, Halil Pasic wrote: >> Simplify the error handling of the SSCH and RSCH handler avoiding >> arbitrary and cryptic error codes being used to tell how the instruction >> is supposed to end. Let the code detecting the condition tell how it

Re: [Qemu-devel] [PATCH v3 0/7] improve error handling for IO instr

2017-10-18 Thread Cornelia Huck
On Wed, 18 Oct 2017 16:23:47 +0800 Dong Jia Shi wrote: > * Halil Pasic [2017-10-17 18:19:20 +0200]: > > [...] > > > >> Testing > > >> === > > >> > > >> Nothing happened since v2 except for a quick smoke test. Dong Jia gave v2 > > >> a spin with a focus on vfio-ccw. @Dong Jia I would apprec

Re: [Qemu-devel] [PATCH] Reject virtio-scsi configurations with logical block size > physical block size

2017-10-18 Thread Paolo Bonzini
On 16/10/2017 22:17, Mark Kanda wrote: > With virtio-scsi, logical block size should never be larger than > physical block size. From an ATA/SCSI perspective, it makes no sense > to have the logical block size greater than the physical block size, > and it cannot even be effectively expressed in th

Re: [Qemu-devel] [PATCH v3 6/7] s390x: refactor error handling for HSCH handler

2017-10-18 Thread Thomas Huth
On 17.10.2017 16:04, Halil Pasic wrote: > Simplify the error handling of the HSCH. Let the code detecting the > condition tell (in a less ambiguous way) how it's to be handled. No > changes in behavior. > > Signed-off-by: Halil Pasic > --- > hw/s390x/css.c | 18 +- > inc

Re: [Qemu-devel] [PATCH 0/2] add "nopin" option in the memory-backend-file

2017-10-18 Thread Zhong Yang
On Wed, Oct 18, 2017 at 11:48:11AM +0200, Paolo Bonzini wrote: > On 18/10/2017 07:57, Zhong Yang wrote: > > Your suggestion can avoid DMA target to nvdimm if the nvdimm memory region > > was skipped during VFIO hotplug. It is valuable to try this solution. by > > the > > way, please share me

Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH

2017-10-18 Thread Cornelia Huck
On Wed, 18 Oct 2017 11:52:03 +0200 Thomas Huth wrote: > On 18.10.2017 11:30, Thomas Huth wrote: > > On 17.10.2017 16:04, Halil Pasic wrote: > >> Simplify the error handling of the SSCH and RSCH handler avoiding > >> arbitrary and cryptic error codes being used to tell how the instruction > >> i

[Qemu-devel] [PATCH] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

2017-10-18 Thread Marcel Apfelbaum
Currently there is no MMIO range over 4G reserved for PCI hotplug. Since the 32bit PCI hole depends on the number of cold-plugged PCI devices and other factors, it is very possible is too small to hotplug PCI devices with large BARs. Fix it by reserving all the address space after RAM (and the res

Re: [Qemu-devel] [PATCH v3 7/7] s390x: refactor error handling for MSCH handler

2017-10-18 Thread Thomas Huth
On 17.10.2017 16:04, Halil Pasic wrote: > Simplify the error handling of the MSCH. Let the code detecting the > condition tell (in a less ambiguous way) how it's to be handled. No > changes in behavior. ok, so you claim no changes in behavior ... > Signed-off-by: Halil Pasic > --- > hw/s390x/c

Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH

2017-10-18 Thread Thomas Huth
On 18.10.2017 11:58, Cornelia Huck wrote: > On Wed, 18 Oct 2017 11:52:03 +0200 > Thomas Huth wrote: > >> On 18.10.2017 11:30, Thomas Huth wrote: >>> On 17.10.2017 16:04, Halil Pasic wrote: Simplify the error handling of the SSCH and RSCH handler avoiding arbitrary and cryptic error co

Re: [Qemu-devel] [PATCH v3 7/7] s390x: refactor error handling for MSCH handler

2017-10-18 Thread Cornelia Huck
On Wed, 18 Oct 2017 12:00:05 +0200 Thomas Huth wrote: > On 17.10.2017 16:04, Halil Pasic wrote: > > Simplify the error handling of the MSCH. Let the code detecting the > > condition tell (in a less ambiguous way) how it's to be handled. No > > changes in behavior. > > ok, so you claim no chan

Re: [Qemu-devel] [PATCH] tpm: Fix compilation with --disable-tpm

2017-10-18 Thread Valluri, Amarnath
Sorry for causing build break :( I would prefer the way tpm_init() was handled in vl.c, even tpm_cleanup() shuould be guarded behind #ifdef CONFIG_TPM. - Amarnath On Wed, 2017-10-18 at 11:27 +0200, Juan Quintela wrote: > Laurent Vivier wrote: > > > > On 18/10/2017 10:33, Juan Quintela wrote: >

Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH

2017-10-18 Thread Thomas Huth
On 18.10.2017 11:52, Cornelia Huck wrote: > On Wed, 18 Oct 2017 11:30:47 +0200 > Thomas Huth wrote: > >> On 17.10.2017 16:04, Halil Pasic wrote: >>> Simplify the error handling of the SSCH and RSCH handler avoiding >>> arbitrary and cryptic error codes being used to tell how the instruction >>> i

Re: [Qemu-devel] [Qemu devel v2 PATCH] msf2: Remove dead code reported by Coverity

2017-10-18 Thread sundeep subbaraya
Hi Darren, On Wed, Oct 18, 2017 at 2:24 PM, Darren Kenny wrote: > On Wed, Oct 18, 2017 at 03:40:38AM +, Subbaraya Sundeep wrote: > >> Fixed incorrect frame size mask, validated maximum frame >> size in spi_write and removed dead code. >> >> Signed-off-by: Subbaraya Sundeep >> --- >> v2: >>

Re: [Qemu-devel] [PATCH v3] NUMA: Enable adding NUMA node implicitly

2017-10-18 Thread Igor Mammedov
On Thu, 21 Sep 2017 17:23:08 +0800 Dou Liyang wrote: > Linux and Windows need ACPI SRAT table to make memory hotplug work properly, > however currently QEMU doesn't create SRAT table if numa options aren't > present > on CLI. > > Which breaks both linux and windows guests in certain conditions:

Re: [Qemu-devel] [PATCH] x86/cpufeatures: Enable new AVX512 cpu features

2017-10-18 Thread Paolo Bonzini
On 17/10/2017 11:34, Yang Zhong wrote: > Intel IceLake cpu has added new cpu features,AVX512VBMI2/GFNI/ > VAES/AVX512VNNI/AVX512BITALG/VPCLMULQDQ. Those new cpu features > need expose to guest VM. > > The bit definition: > CPUID.(EAX=7,ECX=0):ECX[bit 06] AVX512VBMI2 > CPUID.(EAX=7,ECX=0):ECX[bit 0

Re: [Qemu-devel] [Qemu devel v2 PATCH] msf2: Remove dead code reported by Coverity

2017-10-18 Thread Darren Kenny
Hi Sundeep, On Wed, Oct 18, 2017 at 10:10:07AM +, sundeep subbaraya wrote: Hi Darren, On Wed, Oct 18, 2017 at 2:24 PM, Darren Kenny wrote: On Wed, Oct 18, 2017 at 03:40:38AM +, Subbaraya Sundeep wrote: Fixed incorrect frame size mask, validated maximum frame size in spi_write and r

[Qemu-devel] [PATCH v2 03/10] migration: Make cache size elements use the right types

2017-10-18 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/page_cache.c | 8 migration/page_cache.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/migration/page_cache.c b/migration/page_cache.c index 381e555ddb..6b2dd77cf0 100644 --- a/migrat

[Qemu-devel] [PATCH v2 08/10] migration: No need to return the size of the cache

2017-10-18 Thread Juan Quintela
After the previous commits, we make sure that the value passed is right, or we just drop an error. So now we return if there is one error or we have setup correctly the value passed. Signed-off-by: Juan Quintela --- migration/migration.c | 6 ++ migration/ram.c | 8 +++- migration

[Qemu-devel] [PATCH v2 00/10] Make xbzrle_cache_size a migration parameter

2017-10-18 Thread Juan Quintela
In v2 - rebase - fix comments about power of 2 instead of multiple of two - minor typo on error message - use Error * when setting values After asking people of libvirt/ovirt/openstack, it appears that there is no problem about restricting cache_size to real values. We give back one error and t

[Qemu-devel] [PATCH v2 01/10] migration: Fix migrate_test_apply for multifd parameters

2017-10-18 Thread Juan Quintela
They were missing when introduced on the tree Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- migration/migration.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index 98429dc843..fb62a639d8 100644 --- a/migration/migration.c +++

[Qemu-devel] [PATCH v2 07/10] migration: Don't play games with the requested cache size

2017-10-18 Thread Juan Quintela
Now that we check that the value passed is a power of 2, we don't need to play games when comparing what is the size that is going to take the cache. Signed-off-by: Juan Quintela --- migration/ram.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b

[Qemu-devel] [PATCH v2 02/10] migratiom: Remove max_item_age parameter

2017-10-18 Thread Juan Quintela
It was not used at all since commit: 27af7d6ea5015e5ef1f7985eab94a8a218267a2b which replaced its use by the dirty sync count. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- migration/page_cache.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/migration/page_cache.c b/migration/p

[Qemu-devel] [PATCH v2 04/10] migration: Move xbzrle cache resize error handling to xbzrle_cache_resize

2017-10-18 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- migration/migration.c | 18 +- migration/ram.c | 22 -- migration/ram.h | 2 +- 3 files changed, 22 insertions(+), 20 deletions(-) diff --git a/migration/migration.c b/migration/migration.c i

[Qemu-devel] [PATCH v2 10/10] migration: [RFC] Use proper types in json

2017-10-18 Thread Juan Quintela
We use int for everything (int64_t), and then we check that value is between 0 and 255. Change it to the valid types. For qmp, the only real change is that now max_bandwidth allows to use the k/M/G suffixes. Signed-off-by: Juan Quintela --- hmp.c | 22 +++--- mi

[Qemu-devel] [PATCH v2 05/10] migration: Make cache_init() take an error parameter

2017-10-18 Thread Juan Quintela
Once there, take a total size instead of the size of the pages. We move the check that the new_size is bigger than one page from xbzrle_cache_resize(). Signed-off-by: Juan Quintela Reviewed-by: Peter Xu -- Fix typo spotted by Peter Xu --- migration/page_cache.c | 17 +++-- migrat

[Qemu-devel] [PATCH v2 06/10] migration: Make sure that we pass the right cache size

2017-10-18 Thread Juan Quintela
Instead of passing silently round down the number of pages, make it an error that the cache size is not a power of 2. Signed-off-by: Juan Quintela --- migration/page_cache.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/migration/page_cache.c b/migration/page_c

[Qemu-devel] [PATCH v2 09/10] migration: Make xbzrle_cache_size a migration parameter

2017-10-18 Thread Juan Quintela
Right now it is a variable in MigrationState instead of a MigrationParameter. The change allows to set it as the rest of the Migration parameters, from the command line, with query_migration_paramters, set_migrate_parameters, etc. Signed-off-by: Juan Quintela -- - Improve help message (dave) -

Re: [Qemu-devel] [PATCH] x86/cpufeatures: Enable new AVX512 cpu features

2017-10-18 Thread Paolo Bonzini
On 18/10/2017 12:39, Zhong Yang wrote: > Paolo, Thanks for review my patch! > > KVM patch is waiting for our kernel colleague to send kernel side patch, > My KVM patch has some header definition depency with kernel side. > > This Qemu patch has been verified on kernel and KVM's patch in n

Re: [Qemu-devel] [PATCH] x86/cpufeatures: Enable new AVX512 cpu features

2017-10-18 Thread Zhong Yang
On Wed, Oct 18, 2017 at 12:32:42PM +0200, Paolo Bonzini wrote: > On 17/10/2017 11:34, Yang Zhong wrote: > > Intel IceLake cpu has added new cpu features,AVX512VBMI2/GFNI/ > > VAES/AVX512VNNI/AVX512BITALG/VPCLMULQDQ. Those new cpu features > > need expose to guest VM. > > > > The bit definition: >

Re: [Qemu-devel] [PATCH] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

2017-10-18 Thread Igor Mammedov
On Wed, 18 Oct 2017 12:58:07 +0300 Marcel Apfelbaum wrote: > Currently there is no MMIO range over 4G > reserved for PCI hotplug. Since the 32bit PCI hole > depends on the number of cold-plugged PCI devices > and other factors, it is very possible is too small > to hotplug PCI devices with large

[Qemu-devel] [Bug 1724477] Re: Build-in websocket broken since v2.9.0-rc0

2017-10-18 Thread Raghav Sinha
Awesome! I cleared the path and tried the latest version, now it works! BTW, is there any other VNC Web Client that I can choose? or noVNC is the one and only? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.ne

Re: [Qemu-devel] [PATCH v4 0/2] Improve audio output quality

2017-10-18 Thread Gerd Hoffmann
Hi, > Which guests did you test with? > > I did a brief test with Windows 7 and still have sound dropouts, even > though it seems to not be as bad as before.  Didn't investigate yet > why. Played around a bit more. Windows 10 seems to work a bit better. Pushed some incremental patches. http

Re: [Qemu-devel] [PATCH] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

2017-10-18 Thread Marcel Apfelbaum
Hi Igor, On 18/10/2017 13:45, Igor Mammedov wrote: On Wed, 18 Oct 2017 12:58:07 +0300 Marcel Apfelbaum wrote: Currently there is no MMIO range over 4G reserved for PCI hotplug. Since the 32bit PCI hole depends on the number of cold-plugged PCI devices and other factors, it is very possible is

Re: [Qemu-devel] [PATCH v3 7/7] s390x: refactor error handling for MSCH handler

2017-10-18 Thread Halil Pasic
On 10/18/2017 12:02 PM, Cornelia Huck wrote: > On Wed, 18 Oct 2017 12:00:05 +0200 > Thomas Huth wrote: > >> On 17.10.2017 16:04, Halil Pasic wrote: >>> Simplify the error handling of the MSCH. Let the code detecting the >>> condition tell (in a less ambiguous way) how it's to be handled. No >>

Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH

2017-10-18 Thread Halil Pasic
On 10/18/2017 12:07 PM, Thomas Huth wrote: > On 18.10.2017 11:52, Cornelia Huck wrote: >> On Wed, 18 Oct 2017 11:30:47 +0200 >> Thomas Huth wrote: >> >>> On 17.10.2017 16:04, Halil Pasic wrote: Simplify the error handling of the SSCH and RSCH handler avoiding arbitrary and cryptic erro

[Qemu-devel] [RFC v2 3/6] possible_cpus: add CPUArchId::type field

2017-10-18 Thread Igor Mammedov
For enabling early cpu to numa node configuration at runtime qmp_query_hotpluggable_cpus() should provide a list of available cpu slots at early stage, before machine_init() is called and the 1st cpu is created, so that mgmt might be able to call it and use output to set numa mapping. Use MachineCl

Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH

2017-10-18 Thread Thomas Huth
On 18.10.2017 13:07, Halil Pasic wrote: > > > On 10/18/2017 12:07 PM, Thomas Huth wrote: >> On 18.10.2017 11:52, Cornelia Huck wrote: >>> On Wed, 18 Oct 2017 11:30:47 +0200 >>> Thomas Huth wrote: >>> On 17.10.2017 16:04, Halil Pasic wrote: > Simplify the error handling of the SSCH and R

[Qemu-devel] [PATCH V2] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

2017-10-18 Thread Marcel Apfelbaum
Currently there is no MMIO range over 4G reserved for PCI hotplug. Since the 32bit PCI hole depends on the number of cold-plugged PCI devices and other factors, it is very possible is too small to hotplug PCI devices with large BARs. Fix it by reserving all the address space after RAM (and the res

Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH

2017-10-18 Thread Halil Pasic
On 10/18/2017 01:12 PM, Thomas Huth wrote: > On 18.10.2017 13:07, Halil Pasic wrote: >> >> >> On 10/18/2017 12:07 PM, Thomas Huth wrote: >>> On 18.10.2017 11:52, Cornelia Huck wrote: On Wed, 18 Oct 2017 11:30:47 +0200 Thomas Huth wrote: > On 17.10.2017 16:04, Halil Pasic wrote

Re: [Qemu-devel] [PATCH v11 2/6] migration: add postcopy blocktime ctx into MigrationIncomingState

2017-10-18 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > This patch adds request to kernel space for UFFD_FEATURE_THREAD_ID, > in case when this feature is provided by kernel. > > PostcopyBlocktimeContext is incapsulated inside postcopy-ram.c, > due to it's postcopy only feature. > Also it defines Po

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-18 Thread Juan Quintela
Peter Xu wrote: > On Wed, Oct 04, 2017 at 12:39:28PM +0200, Juan Quintela wrote: > > [...] > >> +/* A simple PC boot sector that modifies memory (1-100MB) quickly >> + * outputing a 'B' every so often if it's still running. >> + */ >> +unsigned char bootsect[] = { >> + 0xfa, 0x0f, 0x01, 0x16, 0x7

Re: [Qemu-devel] [PATCH V2] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

2017-10-18 Thread Igor Mammedov
On Wed, 18 Oct 2017 14:16:12 +0300 Marcel Apfelbaum wrote: > Currently there is no MMIO range over 4G > reserved for PCI hotplug. Since the 32bit PCI hole > depends on the number of cold-plugged PCI devices > and other factors, it is very possible is too small > to hotplug PCI devices with large

Re: [Qemu-devel] [PATCH] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

2017-10-18 Thread Laszlo Ersek
Hi Marcel, On 10/18/17 11:58, Marcel Apfelbaum wrote: > Currently there is no MMIO range over 4G > reserved for PCI hotplug. Since the 32bit PCI hole > depends on the number of cold-plugged PCI devices > and other factors, it is very possible is too small > to hotplug PCI devices with large BARs.

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-18 Thread Juan Quintela
Peter Xu wrote: > On Wed, Oct 04, 2017 at 12:39:28PM +0200, Juan Quintela wrote: > > [...] > > (having some unit tests for migration is really good...) > >> +static void test_precopy(const char *uri) >> +{ >> +QTestState *from, *to; >> + >> +test_migrate_start(&from, &to, uri); >> + >> +

Re: [Qemu-devel] [PATCH 2/6] tests: Add basic migration precopy tcp test

2017-10-18 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela >> --- >> tests/migration-test.c | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/tests/migration-test.c b/tests/migration-test.c >> index cd954caee4..8ef2b72459 100

Re: [Qemu-devel] [PATCH 3/6] tests: Add precopy test using deprecated commands

2017-10-18 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela >> --- >> tests/migration-test.c | 71 >> ++ >> 1 file changed, 71 insertions(+) >> >> diff --git a/tests/migration-test.c b/tests/migr

Re: [Qemu-devel] [PATCH 4/6] tests: Add migration xbzrle test

2017-10-18 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela > +static void test_xbzrle(const char *uri) >> +{ >> +QTestState *from, *to; >> + >> +test_migrate_start(&from, &to, uri); >> + >> +/* We want to pick a speed slow enough th

Re: [Qemu-devel] [PATCH 5/6] tests: Add migration compress threads tests

2017-10-18 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> For some reason, compression is not working at the moment, test is >> disabled until I found why. >> >> Signed-off-by: Juan Quintela >> --- >> tests/migration-test.c | 51 >> ++

Re: [Qemu-devel] [PATCH 5/6] tests: Add migration compress threads tests

2017-10-18 Thread Juan Quintela
Peter Xu wrote: > On Wed, Oct 04, 2017 at 12:39:32PM +0200, Juan Quintela wrote: > > [...] > >> int main(int argc, char **argv) >> { >> @@ -641,6 +689,9 @@ int main(int argc, char **argv) >> qtest_add_func("/migration/precopy/tcp", test_precopy_tcp); >> qtest_add_func("/migration/depre

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-18 Thread Daniel P. Berrange
On Wed, Oct 04, 2017 at 12:39:28PM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 3 + > tests/migration-test.c | 497 > + > 2 files changed, 500 insertions(+) > create mode 100644 tests/migration-tes

  1   2   3   4   >