Re: [Qemu-devel] [RfC PATCH 6/6] vfio/display: add dmabuf support (v15)

2017-10-11 Thread Gerd Hoffmann
Hi, > Looks pretty straight forward otherwise.  I like the LRU dmabuf > freeing, but is it mostly for validating the interface?  My > impression > is that we'd reach a steady state with a single plane and single > cursor so I wonder if keeping that cache really provides a noticeable > benefit.

Re: [Qemu-devel] linux-user: refactor socket.h into architecture specific sockbits

2017-10-11 Thread Carlo Arenas
ping some of the patches already have a Reviewed-by as shown by : http://patchwork.ozlabs.org/patch/818378/ On Mon, Sep 25, 2017 at 4:19 PM, Carlo Marcelo Arenas Belón wrote: > the definitions in socket.h are meant to reflect the ones in linux for each > respective target, but are sometimes d

[Qemu-devel] [PATCH] cirrus: fix oob access in mode4and5 write functions

2017-10-11 Thread Gerd Hoffmann
Move dst calculation into the loop, so we apply the mask on each interation and will not overflow vga memory. Cc: Prasad J Pandit Reported-by: Niu Guoxiang Signed-off-by: Gerd Hoffmann --- hw/display/cirrus_vga.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/disp

Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-11 Thread Cédric Le Goater
On 10/11/2017 05:49 AM, Andrew Jeffery wrote: > On Tue, 2017-10-10 at 15:30 +0200, Cédric Le Goater wrote: >> On 10/09/2017 02:04 AM, Andrew Jeffery wrote: >>> On Wed, 2017-09-20 at 09:01 +0200, Cédric Le Goater wrote: The Witherspoon boards are OpenPOWER system hosting POWER9 Processors.

Re: [Qemu-devel] [PATCH] spapr_pci: fail gracefully with non-pseries machine types

2017-10-11 Thread Greg Kurz
On Sat, 7 Oct 2017 16:19:25 +1100 David Gibson wrote: > On Fri, Oct 06, 2017 at 05:09:04PM +0200, Greg Kurz wrote: > > QEMU currently crashes when the user tries to add a spapr-pci-host-bridge > > on a non-pseries machine: > > > > $ qemu-system-ppc64 -M ppce500 -device spapr-pci-host-bridge,inde

Re: [Qemu-devel] [PATCHv2] spapr: Correct RAM size calculation for HPT resizing

2017-10-11 Thread Laurent Vivier
On 11/10/2017 02:06, David Gibson wrote: > In order to prevent the guest from forcing the allocation of large amounts > of qemu memory (or host kernel memory, in the case of KVM HV), we limit > the size of Hashed Page Table (HPT) it is allowed to allocated, based on > its RAM size. > > However, th

Re: [Qemu-devel] [PATCH] cirrus: fix oob access in mode4and5 write functions

2017-10-11 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20171011071423.20179-1-kra...@redhat.com Subject: [Qemu-devel] [PATCH] cirrus: fix oob access in mode4and5 write functions === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n

Re: [Qemu-devel] [PATCH v2 1/6] linux-user: update hppa sockbits

2017-10-11 Thread Laurent Vivier
Le 26/09/2017 à 01:19, Carlo Marcelo Arenas Belón a écrit : > updated to match arch/parisc/include/uapi/asm/socket.h from linux 4.14 > include in socket.h changed to prefer a local path like all other qemu > headers and for consistency and clarity when adding all other arch > > Signed-off-by: Carl

Re: [Qemu-devel] [PATCH v2 10/30] target/s390x: interpret PSW_MASK_WAIT only for TCG

2017-10-11 Thread Cornelia Huck
On Thu, 28 Sep 2017 22:36:48 +0200 David Hildenbrand wrote: > KVM handles the wait PSW itself and triggers a WAIT ICPT in case it > really want to sleep (disabled wait). s/want/wants/ (fixing up while applying) > > This will later allow us to change the order of loading a restart > interrupt

Re: [Qemu-devel] [PATCH] oslib-posix: Fix compiler warning

2017-10-11 Thread Stefan Weil
Am 10.10.2017 um 16:43 schrieb Richard Henderson: > On 10/09/2017 10:39 PM, Stefan Weil wrote: >> Am 09.10.2017 um 23:58 schrieb Richard Henderson: >>> On 10/07/2017 08:55 AM, Stefan Weil wrote: +char *addr = memset_args->addr; +uint64_t numpages = memset_args->numpages; >

[Qemu-devel] ping RE: ping RE: question: I found a qemu crash about migration

2017-10-11 Thread wangjie (P)
I found the real culprit, the bug begin to occur since the committed as following: https://github.com/qemu/qemu/commit/e253f4b89796967d03a455d1df2ae6bda8cc7d01 since the patch committed, the mirror target bs begin to use BlockBackend, So the mirror target bs will be inactived in bdrv_inactivate_

Re: [Qemu-devel] [PATCH v2 16/30] s390x/kvm: factor out SIGP code into sigp.c

2017-10-11 Thread Cornelia Huck
On Thu, 28 Sep 2017 22:36:54 +0200 David Hildenbrand wrote: > We want to use the same code base for TCG, so let's cleanly factor it > out. > > The sigp mutex is currently not really needed, as everything is > protected by the iothread mutex. But this could change later, so leave > it in place an

[Qemu-devel] [PATCH] checkpatch: ignore perl files.

2017-10-11 Thread Jiang Biao
Most coding styles are not suit for perl files. If we check scripts/checkpatch.pl with itself, there would be tons of complaints. And if we make patches for checkpatch.pl, patchew.org and checkpatch.pl would complain errors for the patches. Ignore perl files taking Linux kernel version as referenc

Re: [Qemu-devel] ping RE: question: I found a qemu crash about migration

2017-10-11 Thread Kevin Wolf
Am 11.10.2017 um 03:34 hat wangjie (P) geschrieben: > I found the real culprit, the bug begin to occur since the committed as > following: > https://github.com/qemu/qemu/commit/e253f4b89796967d03a455d1df2ae6bda8cc7d01 > > since the patch committed, the mirror target bs begin to use BlockBackend,

[Qemu-devel] [PATCH] arm: fix armv7m_init() declaration to match definition

2017-10-11 Thread Igor Mammedov
s/cpu_model/cpu_type/ that has been forgotten during conversion (ba1ba5cc), while touching the line also fixup alignment. Signed-off-by: Igor Mammedov --- include/hw/arm/arm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/arm/arm.h b/include/hw/arm/arm.h index a3

Re: [Qemu-devel] [PATCH v2 20/30] s390x/tcg: implement SIGP SENSE

2017-10-11 Thread Cornelia Huck
On Thu, 28 Sep 2017 22:36:58 +0200 David Hildenbrand wrote: > Add it as preparation for TCG. Sensing coul later be done completely s/coul/could/ > lockless. > > Signed-off-by: David Hildenbrand > --- > target/s390x/sigp.c | 29 + > 1 file changed, 29 insertions(+)

[Qemu-devel] [PULL 03/10] ui: add keycodemapdb repository as a GIT submodule

2017-10-11 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a data file mapping between all the different scancode/keycode/keysym sets that are known, and a tool to auto-generate lookup tables for different combinations. It is used by GTK-VNC, SPICE-GTK and libvirt f

[Qemu-devel] [PULL 08/10] Add pc-bios/keymaps/Makefile

2017-10-11 Thread Gerd Hoffmann
Update files where I think I've figured the correct xkb maps. TODO: nl-be sl sv Signed-off-by: Gerd Hoffmann Message-id: 20171005153330.19210-3-kra...@redhat.com --- pc-bios/keymaps/Makefile | 56 1 file changed, 56 insertions(+) create mode 1006

[Qemu-devel] [PULL 10/10] ui/gtk: Fix deprecation of vte_terminal_copy_clipboard

2017-10-11 Thread Gerd Hoffmann
From: Anthony PERARD vte_terminal_copy_clipboard() is deprecated in VTE 0.50. Signed-off-by: Anthony PERARD Reviewed-by: Daniel P. Berrange Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 5 + 1 file changed, 5 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index 5bd87c265a..342e96fbe9 1006

[Qemu-devel] [PULL 05/10] ui: convert key events to QKeyCodes immediately

2017-10-11 Thread Gerd Hoffmann
From: "Daniel P. Berrange" Always use QKeyCode in the InputKeyEvent struct, by converting key numbers to QKeyCode at the time the event is created. This allows the code processing / consuming key events to assume QKeyCode is used. The only place we accept a key number in the InputKeyEvent struct

[Qemu-devel] [PULL 01/10] build: automatically handle GIT submodule checkout for dtc

2017-10-11 Thread Gerd Hoffmann
From: "Daniel P. Berrange" Currently if DTC is required by configure and not available in the host OS install, we exit with an error message telling the user to checkout a git submodule or install the library. This introduces automatic handling of the git submodule checkout process and enables i

[Qemu-devel] [PULL 00/10] Ui 20171011 patches

2017-10-11 Thread Gerd Hoffmann
The following changes since commit 567d0a19c7998fa366598b83d5a6e5f0759d3ea9: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-and-machine-pull-request' into staging (2017-10-10 13:25:46 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-201

[Qemu-devel] [PULL 06/10] ui: don't export qemu_input_event_new_key

2017-10-11 Thread Gerd Hoffmann
From: "Daniel P. Berrange" All public code should use qemu_input_event_send_key* functions instead of creating an event directly. Signed-off-by: Daniel P. Berrange Message-id: 20170929101201.21039-7-berra...@redhat.com Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 1 - ui/input.c

[Qemu-devel] [PULL 07/10] tools: add qemu-keymap

2017-10-11 Thread Gerd Hoffmann
qemu-keymap generates qemu reverse keymaps from xkb keymaps, which can be used with the qemu "-k" command line switch. Signed-off-by: Gerd Hoffmann Message-id: 20171005153330.19210-2-kra...@redhat.com --- configure | 23 ++ Makefile | 5 ++ qemu-keymap.c | 258 +++

[Qemu-devel] [PULL 02/10] docker: don't rely on submodules existing in the main checkout

2017-10-11 Thread Gerd Hoffmann
From: "Daniel P. Berrange" When building the tarball to pass into the docker/vm test image, the code relies on the git submodules being checked out in the main checkout. ie if the developer has not run 'git submodule update --init dtc' many of the docker tests will fail due to the libfdt package

[Qemu-devel] [PULL 04/10] ui: convert common input code to keycodemapdb

2017-10-11 Thread Gerd Hoffmann
From: "Daniel P. Berrange" Replace the number_to_qcode, qcode_to_number and linux_to_qcode tables with automatically generated tables. Missing entries in linux_to_qcode now fixed: KEY_LINEFEED -> Q_KEY_CODE_LF KEY_KPEQUAL -> Q_KEY_CODE_KP_EQUALS KEY_COMPOSE -> Q_KEY_CODE_COMPOSE KEY_AGA

Re: [Qemu-devel] [PATCH v5 01/23] block: Allow NULL file for bdrv_get_block_status()

2017-10-11 Thread Kevin Wolf
Am 10.10.2017 um 21:24 hat John Snow geschrieben: > > > On 10/10/2017 03:00 PM, Eric Blake wrote: > > On 10/10/2017 09:43 AM, Eric Blake wrote: > > > --- > v5: use second label for cleaner exit logic [John], use local_pnum > >> > @@ -1811,16 +1811,19 @@ static int64_t coroutine_fn

[Qemu-devel] [PATCH v2] cirrus: fix oob access in mode4and5 write functions

2017-10-11 Thread Gerd Hoffmann
Move dst calculation into the loop, so we apply the mask on each interation and will not overflow vga memory. Cc: Prasad J Pandit Reported-by: Niu Guoxiang Signed-off-by: Gerd Hoffmann --- hw/display/cirrus_vga.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/disp

Re: [Qemu-devel] [PATCH v2 24/30] s390x/tcg: implement STOP and RESET interrupts for TCG

2017-10-11 Thread Cornelia Huck
On Thu, 28 Sep 2017 22:37:02 +0200 David Hildenbrand wrote: > Implement them like KVM implements/handles them. Both can only be > triggered via SIGP instructions. RESET has (almos)the lowest priority if s/(almos)/(almost) / > the CPU is running, and the highest if the CPU is STOPPED. This is ha

Re: [Qemu-devel] [PATCH v2 26/30] s390x/tcg: switch to new SIGP handling code

2017-10-11 Thread Cornelia Huck
On Fri, 6 Oct 2017 10:02:43 -0400 Richard Henderson wrote: > On 09/28/2017 04:37 PM, David Hildenbrand wrote: > > static ExitStatus op_sigp(DisasContext *s, DisasOps *o) > > { > > TCGv_i32 r1 = tcg_const_i32(get_field(s->fields, r1)); > > +TCGv_i32 r3 = tcg_const_i32(get_field(s->field

Re: [Qemu-devel] [PATCH v2 28/30] s390x/tcg: unlock NMI

2017-10-11 Thread Cornelia Huck
On Thu, 28 Sep 2017 22:37:06 +0200 David Hildenbrand wrote: > Nothing hindering us anymore from unlocking the restart code (used for > NMI). > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 4 +--- > target/s390x/sigp.c| 5 - > 2 files changed, 1 insertion(

[Qemu-devel] [PATCH] bcm2835_armtimer: add bcm2835 ARM timer

2017-10-11 Thread Thomas Venriès
The ARM Timer is based on a ARM AP804, but it has a number of differences with the standard SP804. There is only one timer which runs in continuous mode with an extra clock pre-divider register and a 32-bit free running counter. The extra stop-in-debug-mode control bit is not implemented. Signed-

Re: [Qemu-devel] [PATCH v1 6/7] io: cope with websock 'Connection' header having multiple values

2017-10-11 Thread Daniel P. Berrange
On Tue, Oct 10, 2017 at 12:42:55PM -0500, Eric Blake wrote: > On 10/10/2017 10:43 AM, Daniel P. Berrange wrote: > > The noVNC server sends a header "Connection: keep-alive, Upgrade" which > > fails our simple equality test. Split the header on ',', trim whitespace > > and then check for 'upgrade' t

Re: [Qemu-devel] [PATCH v2 10/10] nbd: Minimal structured read for client

2017-10-11 Thread Vladimir Sementsov-Ogievskiy
10.10.2017 18:00, Paolo Bonzini wrote: On 10/10/2017 16:55, Vladimir Sementsov-Ogievskiy wrote: Hmm, would it be simpler just pass a function pointer, which should be called on each loop iteration? So, we will return to one common func nbd_co_receive_reply, but with two additional parameters: fu

Re: [Qemu-devel] [PATCH RFC] file-posix: make lock_fd read-only

2017-10-11 Thread Kevin Wolf
[ Cc: Fam ] Am 10.10.2017 um 15:42 hat Vladimir Sementsov-Ogievskiy geschrieben: > We do not reopen lock_fd on bdrv_reopen which leads to problems on > reopen image RO. So, lets make lock_fd be always RO. > This is correct, because qemu_lock_fd always called with exclusive=false > on lock_fd. > >

Re: [Qemu-devel] [PATCH 10/10] migration: [RFC] Use proper types in json

2017-10-11 Thread Daniel P. Berrange
On Tue, Oct 10, 2017 at 08:15:42PM +0200, Juan Quintela wrote: > We use int for everything (int64_t), and then we check that value is > between 0 and 255. Change it to the valid types. > > For qmp, the only real change is that now max_bandwidth allows to use > the k/M/G suffixes. So on input app

Re: [Qemu-devel] [PATCH RFC] file-posix: make lock_fd read-only

2017-10-11 Thread Vladimir Sementsov-Ogievskiy
11.10.2017 12:22, Kevin Wolf wrote: [ Cc: Fam ] Am 10.10.2017 um 15:42 hat Vladimir Sementsov-Ogievskiy geschrieben: We do not reopen lock_fd on bdrv_reopen which leads to problems on reopen image RO. So, lets make lock_fd be always RO. This is correct, because qemu_lock_fd always called with e

Re: [Qemu-devel] [PATCH 10/10] migration: [RFC] Use proper types in json

2017-10-11 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Tue, Oct 10, 2017 at 08:15:42PM +0200, Juan Quintela wrote: >> We use int for everything (int64_t), and then we check that value is >> between 0 and 255. Change it to the valid types. >> >> For qmp, the only real change is that now max_bandwidth allows to use >>

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 0/5] virtio-iommu: VFIO integration

2017-10-11 Thread Auger Eric
Hi Bharat, On 10/10/2017 08:42, Bharat Bhushan wrote: > Hi Alex, Eric, > >> -Original Message- >> From: Qemu-devel [mailto:qemu-devel- >> bounces+bharat.bhushan=nxp@nongnu.org] On Behalf Of Bharat >> Bhushan >> Sent: Friday, October 06, 2017 9:16 AM >> To: Auger Eric ; Linu Cherian >>

Re: [Qemu-devel] [PATCH RFC] file-posix: make lock_fd read-only

2017-10-11 Thread Kevin Wolf
Am 11.10.2017 um 11:38 hat Vladimir Sementsov-Ogievskiy geschrieben: > 11.10.2017 12:22, Kevin Wolf wrote: > > [ Cc: Fam ] > > > > Am 10.10.2017 um 15:42 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > We do not reopen lock_fd on bdrv_reopen which leads to problems on > > > reopen image RO. So

Re: [Qemu-devel] [PATCH 6/9] target/arm: Pull Thumb insn word loads up to top level

2017-10-11 Thread Peter Maydell
On 11 October 2017 at 03:18, Richard Henderson wrote: > On 10/09/2017 06:48 AM, Peter Maydell wrote: >> +if ((insn >> 11) == 0x1e && (s->pc < s->next_page_start - 3)) { >> +/* 0b_0xxx__ : BL/BLX prefix, and the suffix >> + * is not on the next page; we merge this in

Re: [Qemu-devel] [PATCH 8/9] target/arm: Support some Thumb insns being always unconditional

2017-10-11 Thread Peter Maydell
On 11 October 2017 at 03:52, Richard Henderson wrote: > On 10/09/2017 06:48 AM, Peter Maydell wrote: >> -if (dc->condexec_mask) { >> +if (dc->condexec_mask && !thumb_insn_is_unconditional(dc, insn)) { >> uint32_t cond = dc->condexec_cond; >> >> if (cond != 0x0e) { /*

[Qemu-devel] [PATCH v2 2/7] io: simplify websocket ping reply handling

2017-10-11 Thread Daniel P. Berrange
We must ensure we don't get flooded with ping replies if the outbound channel is slow. Currently we do this by keeping the ping reply in a separate temporary buffer and only writing it if the encoutput buffer is completely empty. This is overly pessimistic, as it is reasonable to add a ping reply t

[Qemu-devel] [PATCH v2 1/7] io: monitor encoutput buffer size from websocket GSource

2017-10-11 Thread Daniel P. Berrange
The websocket GSource is monitoring the size of the rawoutput buffer to determine if the channel can accepts more writes. The rawoutput buffer, however, is merely a temporary staging buffer before data is copied into the encoutput buffer. Thus its size will always be zero when the GSource runs. Th

[Qemu-devel] [PATCH v2 0/7] Limit websockets memory usage & other bug fixes

2017-10-11 Thread Daniel P. Berrange
The core motivation for this patch series is to fix a security issue publically reported, where websockets code can consume arbitrary amounts of RAM with slow clients: https://bugs.launchpad.net/qemu/+bug/1718964 I've asked for a CVE but its not assigned yet. Since the bug is public we might a

[Qemu-devel] [PATCH v2 5/7] io: get rid of bounce buffering in websock write path

2017-10-11 Thread Daniel P. Berrange
Currently most outbound I/O on the websock channel gets copied into the rawoutput buffer, and then immediately copied again into the encoutput buffer, with a header prepended. Now that qio_channel_websock_encode accepts a struct iovec, we can trivially remove this bounce buffering and write directl

[Qemu-devel] [PATCH v2 7/7] io: add trace points for websocket HTTP protocol headers

2017-10-11 Thread Daniel P. Berrange
Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- io/channel-websock.c | 4 io/trace-events | 2 ++ 2 files changed, 6 insertions(+) diff --git a/io/channel-websock.c b/io/channel-websock.c index 3e3d0953c4..afe9db4c28 100644 --- a/io/channel-websock.c +++ b/io/channel-web

[Qemu-devel] [PATCH v2 6/7] io: cope with websock 'Connection' header having multiple values

2017-10-11 Thread Daniel P. Berrange
The noVNC server sends a header "Connection: keep-alive, Upgrade" which fails our simple equality test. Split the header on ',', trim whitespace and then check for 'upgrade' token. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- io/channel-websock.c | 14 +- 1 file cha

[Qemu-devel] [PATCH v2 3/7] io: get rid of qio_channel_websock_encode helper method

2017-10-11 Thread Daniel P. Berrange
The qio_channel_websock_encode method is only used in one place, everything else calls qio_channel_websock_encode_buffer directly. It can also be pushed up a level into the qio_channel_websock_writev method, since every other caller of qio_channel_websock_write_wire has already filled encoutput. R

[Qemu-devel] [PATCH v2 4/7] io: pass a struct iovec into qio_channel_websock_encode

2017-10-11 Thread Daniel P. Berrange
Instead of requiring use of another Buffer, pass a struct iovec into qio_channel_websock_encode, which gives callers more flexibility in how they process data. Signed-off-by: Daniel P. Berrange --- io/channel-websock.c | 69 1 file changed, 42

Re: [Qemu-devel] [PATCH] spapr_pci: fail gracefully with non-pseries machine types

2017-10-11 Thread David Gibson
On Wed, Oct 11, 2017 at 09:29:08AM +0200, Greg Kurz wrote: > On Sat, 7 Oct 2017 16:19:25 +1100 > David Gibson wrote: > > > On Fri, Oct 06, 2017 at 05:09:04PM +0200, Greg Kurz wrote: > > > QEMU currently crashes when the user tries to add a spapr-pci-host-bridge > > > on a non-pseries machine: > >

Re: [Qemu-devel] [PATCH] bcm2835_armtimer: add bcm2835 ARM timer

2017-10-11 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1507712980-12135-1-git-send-email-thomas.venr...@gmail.com Subject: [Qemu-devel] [PATCH] bcm2835_armtimer: add bcm2835 ARM timer === TEST SCRIPT BEGIN === #!/bin/bash BASE=b

[Qemu-devel] [Bug 1719870] Re: Converting 100G VHDX fixed image to QCOW2 fails

2017-10-11 Thread R Naveen Kumar
Bug is reproducible with setting VHDX Fixed Logicalsectorsize to 4096bytes >10G image created reflects as 1.2G virtual size in Qemu-img PS F:\> new-vhd -path test.vhdx -BlockSizeBytes 134217728 -SizeBytes 10737418240 -Fixed -LogicalSectorSizeBytes 4096 ComputerName: Path

Re: [Qemu-devel] [RfC PATCH 5/6] vfio/display: adding region support

2017-10-11 Thread Gerd Hoffmann
Hi, > > +ret = ioctl(vdev->vbasedev.fd, VFIO_DEVICE_QUERY_GFX_PLANE, > > &plane); > > +if (ret < 0) { > > +fprintf(stderr, "ioctl VFIO_DEVICE_QUERY_GFX_PLANE: %s\n", > > +strerror(errno)); > > %m? Oh, neat, didn't know this even exists. man page says it is a gl

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

2017-10-11 Thread Halil Pasic
On 10/11/2017 05:47 AM, Dong Jia Shi wrote: > * Halil Pasic [2017-10-04 17:41:39 +0200]: > >> Simplify the error handling of the SSCH and RSCH handler avoiding >> arbitrary and cryptic error codes being used to tell how the instruction >> is supposed to end. Let the code detecting the conditio

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-11 Thread ChristianEhrhardt
Hi, I was reading into this after being back from PTO (actually back next monday). I was wondering as I tested (without openstack) just that last week with Dannf on the Rally). And indeed it seems to work for me on Artful (which as we all know is =Ocata in terms of SW stack). $ cat arm-template.

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-11 Thread ChristianEhrhardt
Note - be careful if you mean upstream qemu/libvirt (as the bug was filed) or the packages in Ubuntu (I added tasks for these). I try to spot both, but will be more on-track for the latter. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to Q

Re: [Qemu-devel] [PATCH 1/3] qcow2: Fix unaligned preallocated truncation

2017-10-11 Thread Max Reitz
On 2017-10-10 00:25, Eric Blake wrote: > On 10/09/2017 04:55 PM, Max Reitz wrote: >> A qcow2 image file's length is not required to have a length that is a >> multiple of the cluster size. However, qcow2_refcount_area() expects an >> aligned value for its @start_offset parameter, so we need to rou

Re: [Qemu-devel] [PATCH 2/3] qcow2: Always execute preallocate() in a coroutine

2017-10-11 Thread Max Reitz
On 2017-10-10 00:28, Eric Blake wrote: > On 10/09/2017 04:55 PM, Max Reitz wrote: >> Some qcow2 functions (at least perform_cow()) expect s->lock to be >> taken. Therefore, if we want to make use of them, we should execute >> preallocate() (as "preallocate_co") in a coroutine so that we can use >>

Re: [Qemu-devel] [PATCH 02/18] block: BDS deletion during bdrv_drain_recurse

2017-10-11 Thread Max Reitz
On 2017-10-10 10:36, Kevin Wolf wrote: > Am 13.09.2017 um 20:18 hat Max Reitz geschrieben: >> Drainined a BDS child may lead to both the original BDS and/or its other >> children being deleted (e.g. if the original BDS represents a block >> job). We should prepare for this in both bdrv_drain_recur

Re: [Qemu-devel] [PATCH 05/18] block/mirror: Convert to coroutines

2017-10-11 Thread Max Reitz
On 2017-10-10 11:14, Kevin Wolf wrote: > Am 13.09.2017 um 20:18 hat Max Reitz geschrieben: >> In order to talk to the source BDS (and maybe in the future to the >> target BDS as well) directly, we need to convert our existing AIO >> requests into coroutine I/O requests. >> >> Signed-off-by: Max Rei

Re: [Qemu-devel] [PATCH 08/18] block/mirror: Use source as a BdrvChild

2017-10-11 Thread Max Reitz
On 2017-10-10 11:27, Kevin Wolf wrote: > Am 13.09.2017 um 20:19 hat Max Reitz geschrieben: >> With this, the mirror_top_bs is no longer just a technically required >> node in the BDS graph but actually represents the block job operation. >> >> Signed-off-by: Max Reitz >> --- >> block/mirror.c | 1

Re: [Qemu-devel] [PATCH v2 2/4] spapr/rtas: disable the decrementer interrupt when a CPU is unplugged

2017-10-11 Thread Cédric Le Goater
On 10/11/2017 08:45 AM, David Gibson wrote: > On Mon, Oct 09, 2017 at 05:49:28PM +0200, Cédric Le Goater wrote: >> When a CPU is stopped with the 'stop-self' RTAS call, its state >> 'halted' is switched to 1 and, in this case, the MSR is not taken into >> account anymore in the cpu_has_work() routi

Re: [Qemu-devel] [PATCH 10/18] block/mirror: Make source the file child

2017-10-11 Thread Max Reitz
On 2017-10-10 11:47, Kevin Wolf wrote: > Am 13.09.2017 um 20:19 hat Max Reitz geschrieben: >> Regarding the source BDS, the mirror BDS is arguably a filter node. >> Therefore, the source BDS should be its "file" child. >> >> Signed-off-by: Max Reitz > > TODO: Justification why this doesn't break

Re: [Qemu-devel] [PATCH] checkpatch: replace ERROR with WARN for extern checking.

2017-10-11 Thread Peter Maydell
On 11 October 2017 at 05:33, Jiang Biao wrote: > There are some rare cases which need external declarations in .c > files. patchew.org and checkpatch.pl will complain errors on > patches for these declarations. > > Degrade ERROR to WARN to erase the error complaints taking > checkpatch.pl in kerne

Re: [Qemu-devel] [PULL v2 00/20] Queued TCG patches

2017-10-11 Thread Peter Maydell
On 10 October 2017 at 20:29, Richard Henderson wrote: > One trivial cleanup from Jiang. Cherry-picking half of Emilio's > patch set that has been reviewed. > > Changes since v1: > * Dropped 2 mprotect changes that Werrored on w32. > * Dropped tcg optimize patch that broke arm32 host. > > > r~

Re: [Qemu-devel] Co-routine re-entered recursively

2017-10-11 Thread Kevin Wolf
[ Cc: qemu-block ] Am 09.10.2017 um 21:11 hat Gugnani, Shashank geschrieben: > Hi, > > I'm trying to modify the NVMe emulator in QEMU to use multiple threads. > > After making necessary changes, I see this error: 'Co-routine re-entered > recursively' > > Can anybody tell me the reason for this

Re: [Qemu-devel] [PATCH v2 00/30] s390x: SMP for TCG

2017-10-11 Thread Cornelia Huck
On Thu, 28 Sep 2017 22:36:38 +0200 David Hildenbrand wrote: > This series is based on a couple of other patches floating around on > the mailing list (e.g. cleanups and LAP). The fist patches of v1 have > been sent as a separate series. > > As I am working on kvm-unit-tests for SIGP, I discovere

Re: [Qemu-devel] [PULL v2 00/10] Merge tpm 2017/10/04

2017-10-11 Thread Peter Maydell
On 11 October 2017 at 02:36, Stefan Berger wrote: > I installed OpenBSD 6.2 for i386 . I could recreate this one. PRIx64 solves > it. I don't see the EBADMSG. We include qemu/osdep.h in this file, so this > is odd. OpenBSD only added EBADMSG to its headers very recently: https://github.com/openb

Re: [Qemu-devel] [PATCH v1 4/5] s390x/pci: Refuse to realize VFIO-PCI if AIS needed but supported

2017-10-11 Thread Cornelia Huck
On Tue, 10 Oct 2017 18:01:53 +0200 Pierre Morel wrote: > Since in the case we have no AIS in KVM only PCI is impacted, do you > think we can fence IRQFD for MSI with > > kvm_msi_via_irqfd_allowed = false; > > in kvm_arch_init_irq_routing() ? Hm, it seems we never set that for s390x... does th

Re: [Qemu-devel] [PATCH 13/18] block/mirror: Keep write perm for pending writes

2017-10-11 Thread Max Reitz
On 2017-10-10 11:58, Kevin Wolf wrote: > Am 13.09.2017 um 20:19 hat Max Reitz geschrieben: >> The owner of the mirror BDS might retire its write permission; but there >> may still be pending mirror operations so the mirror BDS cannot >> necessarily retire its write permission for its child then. >>

Re: [Qemu-devel] [PATCH v2 4/7] io: pass a struct iovec into qio_channel_websock_encode

2017-10-11 Thread Eric Blake
On 10/11/2017 05:09 AM, Daniel P. Berrange wrote: > Instead of requiring use of another Buffer, pass a struct iovec > into qio_channel_websock_encode, which gives callers more > flexibility in how they process data. > > Signed-off-by: Daniel P. Berrange > --- > io/channel-websock.c | 69 > +

Re: [Qemu-devel] [PATCH v2 4/7] io: pass a struct iovec into qio_channel_websock_encode

2017-10-11 Thread Eric Blake
On 10/11/2017 05:09 AM, Daniel P. Berrange wrote: > Instead of requiring use of another Buffer, pass a struct iovec > into qio_channel_websock_encode, which gives callers more > flexibility in how they process data. > > Signed-off-by: Daniel P. Berrange > +static void qio_channel_websock_encode(

Re: [Qemu-devel] [PATCH v2 4/7] io: pass a struct iovec into qio_channel_websock_encode

2017-10-11 Thread Daniel P. Berrange
On Wed, Oct 11, 2017 at 07:30:45AM -0500, Eric Blake wrote: > On 10/11/2017 05:09 AM, Daniel P. Berrange wrote: > > Instead of requiring use of another Buffer, pass a struct iovec > > into qio_channel_websock_encode, which gives callers more > > flexibility in how they process data. > > > > Signed

Re: [Qemu-devel] [Qemu-block] [PATCH 15/18] block/mirror: Add active mirroring

2017-10-11 Thread Max Reitz
On 2017-10-10 12:16, Kevin Wolf wrote: > Am 18.09.2017 um 18:26 hat Max Reitz geschrieben: >> On 2017-09-18 12:06, Stefan Hajnoczi wrote: >>> On Sat, Sep 16, 2017 at 03:58:01PM +0200, Max Reitz wrote: On 2017-09-14 17:57, Stefan Hajnoczi wrote: > On Wed, Sep 13, 2017 at 08:19:07PM +0200, M

Re: [Qemu-devel] [PATCH v2 5/7] io: get rid of bounce buffering in websock write path

2017-10-11 Thread Eric Blake
On 10/11/2017 05:09 AM, Daniel P. Berrange wrote: > Currently most outbound I/O on the websock channel gets copied into the > rawoutput buffer, and then immediately copied again into the encoutput > buffer, with a header prepended. Now that qio_channel_websock_encode > accepts a struct iovec, we ca

Re: [Qemu-devel] [PATCH v2 5/6] linux-user: update default socket.h

2017-10-11 Thread Laurent Vivier
Le 26/09/2017 à 01:19, Carlo Marcelo Arenas Belón a écrit : > enable SO_REUSEPORT as a sideeffect and add SO_GET_FILTER alias > > Signed-off-by: Carlo Marcelo Arenas Belón > --- > linux-user/socket.h | 59 > +++-- > 1 file changed, 48 insertions(+

[Qemu-devel] [PATCH] tpm: Use EMSGSIZE instead of EBADMSG to compile on OpenBSD

2017-10-11 Thread Stefan Berger
EMSGSIZE was only added to OpenBSD very recently. To make QEMU compileable on older OpenBSD versions use EMSGSIZE instead when a mismatch between number of received bytes and message size in- dicated in the header was found. Signed-off-by: Stefan Berger --- hw/tpm/tpm_util.c | 2 +- 1 file chang

Re: [Qemu-devel] [PATCH] tpm: Use EMSGSIZE instead of EBADMSG to compile on OpenBSD

2017-10-11 Thread Peter Maydell
On 11 October 2017 at 13:59, Stefan Berger wrote: > EMSGSIZE was only added to OpenBSD very recently. To make QEMU Do you mean "EBADMSG" in this line? > compileable on older OpenBSD versions use EMSGSIZE instead when > a mismatch between number of received bytes and message size in- > dicated in

Re: [Qemu-devel] Patch to add helpful tracing output for driver authors in NVMe emulation

2017-10-11 Thread Doug Gale
On Tue, Oct 10, 2017 at 4:02 AM, Kevin Wolf wrote: > Am 10.10.2017 um 08:58 hat Markus Armbruster geschrieben: >> Doug Gale writes: >> >> > I used exclamations as a concise way of indicating that the driver did >> > something nonsensical, or horribly invalid, like something likely to >> > cause a

Re: [Qemu-devel] Patch to add helpful tracing output for driver authors in NVMe emulation

2017-10-11 Thread Peter Maydell
On 10 October 2017 at 09:02, Kevin Wolf wrote: > Assertions are for checking that assumptions in qemu code hold true. > Here it's about bad guest code, and you can't let qemu abort for that. > > Tracing is the right tool to detect bad guest code, and I think it makes > sense to mark conditions tha

Re: [Qemu-devel] updating to a u-boot without the case-sensitive filename clash

2017-10-11 Thread Thomas Huth
On 10.10.2017 19:43, Michael Roth wrote: > Quoting Richard Henderson (2017-10-10 11:32:22) >> On 10/10/2017 07:22 AM, Peter Maydell wrote: >>> I can see a couple of options: >>> (1) wait for next u-boot release (scheduled for Nov 13, 2017), >>> and move to that >>> [downsides: would be i

Re: [Qemu-devel] [PATCH 0/3] qcow2: Fix preallocated truncation

2017-10-11 Thread Max Reitz
On 2017-10-09 23:55, Max Reitz wrote: > There are (at least...) two bugs in preallocated truncation, which this > series fixes. > > Both would have been apparent if the the related iotest had used the > default cluster size in addition to 512 byte clusters, but alas, it did > not. This is remedie

Re: [Qemu-devel] [PATCH v1 1/1] virtio-ccw: Add the virtio-input devices for CCW bus

2017-10-11 Thread Thomas Huth
On 09.10.2017 16:01, Farhan Ali wrote: > Wire up the virtio-input HID devices (keyboard, mouse, tablet) > for the CCW bus. The virtio-input is a virtio-1 device, > so disable legacy revision 0. > > Signed-off-by: Farhan Ali > Reviewed-by: Halil Pasic > Reviewed-by: Christian Borntraeger > --- >

[Qemu-devel] [PATCH v2] bcm2835_armtimer: add bcm2835 ARM timer

2017-10-11 Thread Thomas Venriès
The ARM Timer is based on a ARM AP804, but it has a number of differences with the standard SP804. There is only one timer which runs in continuous mode with an extra clock pre-divider register and a 32-bit free running counter. The extra stop-in-debug-mode control bit is not implemented. Signed-

Re: [Qemu-devel] [PATCH v2 6/6] linux_user: consolidate sock_type

2017-10-11 Thread Laurent Vivier
Le 26/09/2017 à 01:19, Carlo Marcelo Arenas Belón a écrit : > remove unnecessary sock_type enum and other unused surrounding code to > allow for per arch sockbits to mirror better linux headers for maintenance > > Signed-off-by: Carlo Marcelo Arenas Belón > --- > linux-user/alpha/sockbits.h | 36

Re: [Qemu-devel] [PULL v2 00/27] vhost-user patches

2017-10-11 Thread Peter Maydell
On 10 October 2017 at 22:34, Marc-André Lureau wrote: > The following changes since commit 567d0a19c7998fa366598b83d5a6e5f0759d3ea9: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/x86-and-machine-pull-request' into staging (2017-10-10 > 13:25:46 +0100) > > are available in the Git r

Re: [Qemu-devel] updating to a u-boot without the case-sensitive filename clash

2017-10-11 Thread Alexander Graf
On 11.10.17 15:11, Thomas Huth wrote: > On 10.10.2017 19:43, Michael Roth wrote: >> Quoting Richard Henderson (2017-10-10 11:32:22) >>> On 10/10/2017 07:22 AM, Peter Maydell wrote: I can see a couple of options: (1) wait for next u-boot release (scheduled for Nov 13, 2017), a

Re: [Qemu-devel] [PATCH] tpm: Use EMSGSIZE instead of EBADMSG to compile on OpenBSD

2017-10-11 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1507726772-16661-1-git-send-email-stef...@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH] tpm: Use EMSGSIZE instead of EBADMSG to compile on OpenBSD === TEST SCRIPT BEGIN =

[Qemu-devel] [PATCH] s390x/event-facility: variable-length event masks

2017-10-11 Thread Jason J. Herne
From: Cornelia Huck The architecture supports masks of variable length for sclp write event mask. We currently only support 4 byte event masks, as that is what Linux uses. Let's extend this to the maximum mask length supported by the architecture and return 0 to the guest for the mask bits we do

Re: [Qemu-devel] [PATCH v16 5/5] virtio-balloon: VIRTIO_BALLOON_F_CTRL_VQ

2017-10-11 Thread Michael S. Tsirkin
On Wed, Oct 11, 2017 at 02:03:20PM +0800, Wei Wang wrote: > On 10/10/2017 11:15 PM, Michael S. Tsirkin wrote: > > On Mon, Oct 02, 2017 at 04:38:01PM +, Wang, Wei W wrote: > > > On Sunday, October 1, 2017 11:19 AM, Michael S. Tsirkin wrote: > > > > On Sat, Sep 30, 2017 at 12:05:54PM +0800, Wei W

Re: [Qemu-devel] [PATCH 8/9] target/arm: Support some Thumb insns being always unconditional

2017-10-11 Thread Richard Henderson
On 10/11/2017 02:57 AM, Peter Maydell wrote: > On 11 October 2017 at 03:52, Richard Henderson > wrote: >> On 10/09/2017 06:48 AM, Peter Maydell wrote: >>> -if (dc->condexec_mask) { >>> +if (dc->condexec_mask && !thumb_insn_is_unconditional(dc, insn)) { >>> uint32_t cond = dc->cond

Re: [Qemu-devel] [PULL 00/10] Ui 20171011 patches

2017-10-11 Thread Peter Maydell
; > are available in the git repository at: > > git://git.kraxel.org/qemu tags/ui-20171011-pull-request > > for you to fetch changes up to 92328b7104ffc825f10c33f3fd1866e940a523f7: > > ui/gtk: Fix deprecation of vte_term

[Qemu-devel] [PATCH v2] tpm: Use EMSGSIZE instead of EBADMSG to compile on OpenBSD

2017-10-11 Thread Stefan Berger
EBADMSG was only added to OpenBSD very recently. To make QEMU compilable on older OpenBSD versions use EMSGSIZE instead when a mismatch between number of received bytes and message size indicated in the header was found. Return -EMSGSIZE and convert all other errnos in the same functions to return

Re: [Qemu-devel] [PULL 00/10] Ui 20171011 patches

2017-10-11 Thread Kamil Rytarowski
On 11.10.2017 16:37, Peter Maydell wrote: > The OpenBSD failure is because make now tries to run a > script that uses #!/bin/bash, and this machine doesn't > have bash installed. Do we really need to add bash to > our build-dependencies? The script doesn't seem like it's > doing anything that criti

Re: [Qemu-devel] [PATCH v2] bcm2835_armtimer: add bcm2835 ARM timer

2017-10-11 Thread Peter Maydell
On 11 October 2017 at 14:24, Thomas Venriès wrote: > The ARM Timer is based on a ARM AP804, but it has > a number of differences with the standard SP804. > There is only one timer which runs in continuous > mode with an extra clock pre-divider register > and a 32-bit free running counter. > > The

Re: [Qemu-devel] [PATCH] arm: fix armv7m_init() declaration to match definition

2017-10-11 Thread Peter Maydell
On 11 October 2017 at 09:33, Igor Mammedov wrote: > s/cpu_model/cpu_type/ that has been forgotten during > conversion (ba1ba5cc), while touching the line also > fixup alignment. > > Signed-off-by: Igor Mammedov > --- > include/hw/arm/arm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [RFC v4 00/16] VIRTIO-IOMMU device

2017-10-11 Thread Peter Maydell
On 19 September 2017 at 08:46, Eric Auger wrote: > This series implements the virtio-iommu device. > > This v4 is an upgrade to v0.4 spec [1] and applies on QEMU v2.10.0. > - probe request support although no reserved region is returned at > the moment > - unmap semantics less strict, as specifi

Re: [Qemu-devel] [PATCH v2] tpm: Use EMSGSIZE instead of EBADMSG to compile on OpenBSD

2017-10-11 Thread Peter Maydell
On 11 October 2017 at 15:42, Stefan Berger wrote: > EBADMSG was only added to OpenBSD very recently. To make QEMU compilable > on older OpenBSD versions use EMSGSIZE instead when a mismatch between > number of received bytes and message size indicated in the header was > found. > > Return -EMSGSIZ

Re: [Qemu-devel] [PATCH 0/3] qcow2: Fix preallocated truncation

2017-10-11 Thread Stefan Hajnoczi
On Mon, Oct 09, 2017 at 11:55:30PM +0200, Max Reitz wrote: > There are (at least...) two bugs in preallocated truncation, which this > series fixes. > > Both would have been apparent if the the related iotest had used the > default cluster size in addition to 512 byte clusters, but alas, it did >

  1   2   3   >