Re: [Qemu-devel] [PATCH v1 3/5] xlnx-zcu102: Specify the valid CPUs

2017-10-09 Thread Igor Mammedov
On Fri, 6 Oct 2017 15:06:57 -0700 Alistair Francis wrote: > On Fri, Oct 6, 2017 at 4:45 AM, Eduardo Habkost wrote: > > On Fri, Oct 06, 2017 at 10:23:12AM +0200, Igor Mammedov wrote: > >> On Thu, 5 Oct 2017 14:09:06 -0300 > >> Eduardo Habkost wrote: > >> > >> > On Thu, Oct 05, 2017 at 11:04:

Re: [Qemu-devel] [PATCH 01/88] cocci: script to use g_new() & friends

2017-10-09 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Imported from Markus Armbruster commit b45c03f > > Signed-off-by: Philippe Mathieu-Daudé > --- > Signed-off-by: Markus Armbruster ? > > scripts/coccinelle/g_new.cocci | 101 > + > 1 file changed, 101 insertions(+) > crea

Re: [Qemu-devel] [PATCH 02/88] cocci: add more g_new() transformations

2017-10-09 Thread Markus Armbruster
The commit message should explain the additional transformations briefly and informally. In particular, why they're a good idea. Same for PATCH 3-5. Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé > --- > scripts/coccinelle/g_new.cocci | 73 > +

Re: [Qemu-devel] What is the status of the QEMU sound rework?

2017-10-09 Thread Gerd Hoffmann
Hi, > > GSoC 2015 QEMU rework of the sound environmental variables > > https://wiki.qemu.org/Google_Summer_of_Code_2015#QEMU_audio_backend Code is here: https://www.kraxel.org/cgit/qemu/log/?h=testing/audio.gsoc Merge was blocked back then due to depending on a QAPI updates. Those QAPI update

Re: [Qemu-devel] [PATCH 31/88] QMP: use g_new() family of functions

2017-10-09 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Philippe Mathieu-Daudé > [PMD: more changes] > --- > monitor.c | 14 +++--- > qmp.c | 14 +++--- > tests/test-qmp-commands.c | 14

[Qemu-devel] Need help to launch VM using QEMU command

2017-10-09 Thread Koushik Dutta
Hi ALL QEMU members, I installed qemu utility in my host machine. I want to start Virtual machine using qemu command. But i facing problem like "object_new_with_type". Below i past my VM launch script as well as error. My host machine: Intel-X86 Script for launching VM : T=/home/koushik/vpp/clou

Re: [Qemu-devel] [PATCH v2 1/8] s390x/css: be more consistent if broken beyond repair

2017-10-09 Thread Dong Jia Shi
* Halil Pasic [2017-10-04 17:41:37 +0200]: > Calling do_subchannel_work with no function control flags set in SCSW is > a programming error. Currently the handle this differently in ?: s/the/we/ > do_subchannel_work_virtual and do_subchannel_work_passthrough. Let's be > consistent and guard with

Re: [Qemu-devel] [PATCH 18/23] ppc: pnv: use generic cpu_model parsing

2017-10-09 Thread David Gibson
On Mon, Oct 09, 2017 at 07:44:15AM +0200, Igor Mammedov wrote: > On Fri, 6 Oct 2017 22:25:03 +1100 > David Gibson wrote: > > > On Fri, Oct 06, 2017 at 11:30:54AM +0200, Igor Mammedov wrote: > > > On Fri, 6 Oct 2017 19:34:19 +1100 > > > David Gibson wrote: > > > > > > > On Thu, Oct 05, 2017 at

Re: [Qemu-devel] [PATCH 31/88] QMP: use g_new() family of functions

2017-10-09 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Philippe Mathieu-Daudé writes: > > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > Signed-off-by: Philippe Mathieu-Daudé > > [PMD: more changes] > > --- > > monitor.c | 14 +++--- > > qmp.c

Re: [Qemu-devel] [PATCH v1 2/5] s390x/css: Use AIS AIRQ injection only if adapter support AIS

2017-10-09 Thread Cornelia Huck
On Wed, 4 Oct 2017 15:49:36 +0200 Pierre Morel wrote: > Testing to use Adapter Interrupt suppression or not depend on AIS > being enabled in the kernel. > To implement AIS emulation we must move this test inside the FLIC > dedicated irq_inject function. > > Furthermore, a test to verify that th

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-09 Thread Peter Xu
On Wed, Oct 04, 2017 at 12:39:28PM +0200, Juan Quintela wrote: [...] (having some unit tests for migration is really good...) > +static void test_precopy(const char *uri) > +{ > +QTestState *from, *to; > + > +test_migrate_start(&from, &to, uri); > + > +/* We want to pick a speed slow

Re: [Qemu-devel] Qemu Documentation

2017-10-09 Thread Kevin Wolf
Am 06.10.2017 um 19:39 hat Swetheendra Tallamraju geschrieben: > Infact emulation of virtual USB already exists. I want to add functionality > of booting from USB. Can you refer which source files to llok on and > modify. Booting is the job of the BIOS that is running inside the guest, so you won'

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-09 Thread Thomas Huth
On 04.10.2017 17:41, Halil Pasic wrote: > CSS code needs to tell the IO instruction handlers located in how should located in how? > the emulated instruction be ended. Currently this is done by returning > generic (POSIX) error codes, and mapping them to outcomes like condition > codes. This make

Re: [Qemu-devel] What is the status of the QEMU sound rework?

2017-10-09 Thread Zir Blazer
> > Fundamental issue is that right now there is not really someone paying > > attention to audio in qemu. > > > > I'm currently the maintainer, but due to also being busy with other > > stuff I hardly find time to do anything beyond picking up fixes from > > the mailing list, maybe do some basic

Re: [Qemu-devel] [PATCH 5/6] tests: Add migration compress threads tests

2017-10-09 Thread Peter Xu
On Wed, Oct 04, 2017 at 12:39:32PM +0200, Juan Quintela wrote: [...] > int main(int argc, char **argv) > { > @@ -641,6 +689,9 @@ int main(int argc, char **argv) > qtest_add_func("/migration/precopy/tcp", test_precopy_tcp); > qtest_add_func("/migration/deprecated/unix", test_deprecated

Re: [Qemu-devel] [PATCH v2 1/2] exec: add page_mask for flatview_do_translate

2017-10-09 Thread Maxime Coquelin
Hi Peter, On 10/09/2017 07:17 AM, Peter Xu wrote: On Fri, Oct 06, 2017 at 03:03:50PM +0200, Maxime Coquelin wrote: On 10/06/2017 02:48 PM, Paolo Bonzini wrote: On 06/10/2017 14:46, Maxime Coquelin wrote:   addr = ((iotlb.translated_addr & ~iotlb.addr_mask)   | (add

Re: [Qemu-devel] [PATCH v1] pci: Set PCI-bus device entry before initializing bus master

2017-10-09 Thread Yi Min Zhao
I strongly agree. This will make IOMMU assignment easier. 在 2017/10/5 下午8:36, Pierre Morel 写道: When initializing the PCI-bus master pci_init_bus_master(PCIDevice *) calls pci_device_iommu_address_space(PCIDevice *) which in turn calls iommu_bus->iommu_fn(bus, opaque,devfn) If the device entry

Re: [Qemu-devel] [PATCH v1 3/5] s390x/intc: Emulate Adapter Interrupt Suppression

2017-10-09 Thread Cornelia Huck
On Wed, 4 Oct 2017 15:49:37 +0200 Pierre Morel wrote: > Emulate the Adapter Interrupt Suppression in the KVM FLIC interface when > the kernel does not support AIS. > > When the kernel KVM does not support AIS, we can not support VFIO PCI > devices but we still can support emulated devices if we

Re: [Qemu-devel] [PATCH v2 1/2] exec: add page_mask for flatview_do_translate

2017-10-09 Thread Peter Xu
On Mon, Oct 09, 2017 at 10:30:07AM +0200, Maxime Coquelin wrote: > Hi Peter, > > On 10/09/2017 07:17 AM, Peter Xu wrote: > >On Fri, Oct 06, 2017 at 03:03:50PM +0200, Maxime Coquelin wrote: > >> > >> > >>On 10/06/2017 02:48 PM, Paolo Bonzini wrote: > >>>On 06/10/2017 14:46, Maxime Coquelin wrote: >

Re: [Qemu-devel] [PATCH v1 4/5] s390x/pci: Refuse to realize VFIO-PCI if AIS needed but supported

2017-10-09 Thread Cornelia Huck
On Wed, 4 Oct 2017 15:49:38 +0200 Pierre Morel wrote: "not supported", surely? > In S390x the Adapter Interrupt Suppression facility is used to mask > interrupts of other PCI devices during interruption handling. > > VFIO PCI allows the interrupts to be delivered rapidely through KVM via > IRQ

Re: [Qemu-devel] [PATCH v1 3/5] s390x/intc: Emulate Adapter Interrupt Suppression

2017-10-09 Thread Cornelia Huck
On Mon, 9 Oct 2017 10:42:44 +0200 Cornelia Huck wrote: > On Wed, 4 Oct 2017 15:49:37 +0200 > Pierre Morel wrote: > > > Emulate the Adapter Interrupt Suppression in the KVM FLIC interface when > > the kernel does not support AIS. > > > > When the kernel KVM does not support AIS, we can not sup

Re: [Qemu-devel] [PATCH v1 1/5] s390x/kvm: Enable AIS from CPU model always

2017-10-09 Thread Cornelia Huck
On Wed, 4 Oct 2017 15:49:35 +0200 Pierre Morel wrote: > As this patchset will introduce AIS emulation, we always enable > Adapter Interrupt Suppression, depending only from the CPU model. > > Signed-off-by: Pierre Morel > --- > target/s390x/kvm.c | 1 + > 1 file changed, 1 insertion(+) > > d

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5] vl: exit if maxcpus is negative

2017-10-09 Thread seeteena
Thanks. Eduardo Habkost On 10/06/2017 05:22 PM, Eduardo Habkost wrote: On Fri, Oct 06, 2017 at 03:15:44PM +1100, David Gibson wrote: On Thu, Sep 28, 2017 at 06:38:55PM +0530, seeteena wrote: Thanks Thomas. Since you already put them on cc. I will wait for the response. At this point, I think

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [RFC 0/8] virtio-crypto: add multiplexing mode support

2017-10-09 Thread Gonglei (Arei)
> -Original Message- > From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > Sent: Friday, October 06, 2017 10:25 PM > On 09/18/2017 03:17 AM, Longpeng (Mike) wrote: > > > > > > On 2017/9/16 1:33, Halil Pasic wrote: > > > >> > >> > >> On 09/14/2017 02:58 AM, Longpeng (Mike) wrote: > >>> >

Re: [Qemu-devel] [PATCH] io: Add missing GCC_FMT_ATTR (fix -Werror=suggest-attribute=format)

2017-10-09 Thread Daniel P. Berrange
On Sat, Oct 07, 2017 at 04:56:09PM +0200, Stefan Weil wrote: > This fixes a compiler warning: > > /qemu/io/channel-websock.c:163:5: error: > function might be possible candidate for ‘gnu_printf’ format attribute > [-Werror=suggest-attribute=format] > > Signed-off-by: Stefan Weil > --- > io/ch

Re: [Qemu-devel] [PATCH v9 02/12] migration: Improve migration thread error handling

2017-10-09 Thread Peter Xu
On Wed, Oct 04, 2017 at 12:46:26PM +0200, Juan Quintela wrote: [...] > diff --git a/migration/tls.c b/migration/tls.c > index 596e8790bd..026a008667 100644 > --- a/migration/tls.c > +++ b/migration/tls.c > @@ -119,7 +119,6 @@ static void migration_tls_outgoing_handshake(QIOTask > *task, > i

Re: [Qemu-devel] [PATCH v9 03/12] migration: Make migrate_fd_error() the owner of the Error

2017-10-09 Thread Peter Xu
On Wed, Oct 04, 2017 at 12:46:27PM +0200, Juan Quintela wrote: > So far, we had to free the error after each caller, so just do it > here. Once there, tls.c was leaking the error. Ah I see the point of my previous question... I think the tls.c leak was introduced by previous patch? Shall we squa

Re: [Qemu-devel] [PATCH 26/88] S390: use g_new() family of functions

2017-10-09 Thread Cornelia Huck
On Fri, 6 Oct 2017 20:49:21 -0300 Philippe Mathieu-Daudé wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Philippe Mathieu-Daudé > [PMD: more changes in hw/s390x/css.c, added target/s390x/cpu_models.c] > --- > hw/s390x/css.c| 10 +- >

Re: [Qemu-devel] [PATCH v16 0/5] Virtio-balloon Enhancement

2017-10-09 Thread Wei Wang
On 10/01/2017 09:25 PM, Damian Tometzki wrote: Hello, where i can found the patch in git.kernel.org ? We don't have patches there. If you want to try this feature, you can get the qemu side draft code here: https://github.com/wei-w-wang/qemu-lm Best, Wei

Re: [Qemu-devel] What is the status of the QEMU sound rework?

2017-10-09 Thread Gerd Hoffmann
Hi, > The guy from reddit whose Thread I linked in the previous mail has > done a bit more work, and his current status is this: > https://www.reddit.com/r/VFIO/comments/74vokw/improved_pulse_audio_dr > iver_for_qemu/ > > He identified some issues with the QEMU audio backend, and according > to

Re: [Qemu-devel] [PATCH 78/88] gdb: use g_new() family of functions

2017-10-09 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau Reviewed-by: Alex Bennée > --- > gdbstub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 2a94030d3b..5f0d8af1c0 100644 > --- a/gdbstub.

Re: [Qemu-devel] [PATCH 77/88] dump: use g_new() family of functions

2017-10-09 Thread Cornelia Huck
On Fri, 6 Oct 2017 20:50:12 -0300 Philippe Mathieu-Daudé wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > dump.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) Acked-by: Cornelia Huck

Re: [Qemu-devel] [PATCH v9 04/12] migration: Start of multiple fd work

2017-10-09 Thread Peter Xu
On Wed, Oct 04, 2017 at 12:46:28PM +0200, Juan Quintela wrote: > We create new channels for each new thread created. We send through > them a string containing multifd so we are Need to touch-up the commit message to reflect the new protocol? > sure that we connect the right channels in both si

Re: [Qemu-devel] [PATCH v9 04/12] migration: Start of multiple fd work

2017-10-09 Thread Daniel P. Berrange
On Wed, Oct 04, 2017 at 12:46:28PM +0200, Juan Quintela wrote: > We create new channels for each new thread created. We send through > them a string containing multifd so we are > sure that we connect the right channels in both sides. This message needs updating now that we send a struct. > di

Re: [Qemu-devel] [PATCH v5 18/22] s390x: implement query-hotpluggable-cpus

2017-10-09 Thread Marc-André Lureau
Hi - Original Message - > Cornelia Huck writes: > > > On Wed, 04 Oct 2017 14:42:55 +0200 > > Markus Armbruster wrote: > > > >> Cornelia Huck writes: > >> > >> > On Mon, 02 Oct 2017 09:46:41 +0200 > >> > Markus Armbruster wrote: > >> > > >> >> David Hildenbrand writes: > >> >> >

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-09 Thread Halil Pasic
On 10/09/2017 10:20 AM, Thomas Huth wrote: > On 04.10.2017 17:41, Halil Pasic wrote: >> CSS code needs to tell the IO instruction handlers located in how should > > located in how? > First, thanks for your review! Wanted to say: in target/s390x/ioinst.c just forgot to copy paste. >> the emul

Re: [Qemu-devel] [PATCH v6 0/7] KASLR kernel dump support

2017-10-09 Thread Marc-André Lureau
ping On Mon, Sep 25, 2017 at 12:52 PM, Marc-André Lureau wrote: > ping > > On Mon, Sep 11, 2017 at 6:59 PM, Marc-André Lureau > wrote: >> Recent linux kernels enable KASLR to randomize phys/virt memory >> addresses. This series aims to provide enough information in qemu >> dumps so that crash ut

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-09 Thread Daniel P. Berrange
On Mon, Sep 11, 2017 at 06:59:24PM +0200, Marc-André Lureau wrote: > See docs/specs/vmcoreinfo.txt for details. > > "etc/vmcoreinfo" fw_cfg entry is added when using "-device vmcoreinfo". I'm wondering if you considered just adding the entry to fw_cfg by default, without requiring any -device arg

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [RFC 0/8] virtio-crypto: add multiplexing mode support

2017-10-09 Thread Halil Pasic
On 10/09/2017 11:22 AM, Gonglei (Arei) wrote: > The next patch refactors make sense to me, > but why do we need to decouple the virtio-crypto.h? > > I wanted to be able to freely change the host side and test with an unchanged guest side, that's why I've done that. It's just for testing. I ha

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-09 Thread Thomas Huth
On 09.10.2017 12:54, Halil Pasic wrote: > > > On 10/09/2017 10:20 AM, Thomas Huth wrote: >> On 04.10.2017 17:41, Halil Pasic wrote: >>> CSS code needs to tell the IO instruction handlers located in how should >> >> located in how? >> > > First, thanks for your review! > > Wanted to say: in targ

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-09 Thread Cornelia Huck
On Mon, 9 Oct 2017 12:54:03 +0200 Halil Pasic wrote: > On 10/09/2017 10:20 AM, Thomas Huth wrote: > > On 04.10.2017 17:41, Halil Pasic wrote: > >> +/* IO instructions conclude according this */ > >> +typedef struct IOInstEnding { > >> +/* > >> + * General semantic of cc codes o

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [RFC 0/8] virtio-crypto: add multiplexing mode support

2017-10-09 Thread Gonglei (Arei)
> -Original Message- > From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > Sent: Monday, October 09, 2017 7:05 PM > > On 10/09/2017 11:22 AM, Gonglei (Arei) wrote: > > The next patch refactors make sense to me, > > but why do we need to decouple the virtio-crypto.h? > > > > > > I wante

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-09 Thread Marc-André Lureau
Hi - Original Message - > On Mon, Sep 11, 2017 at 06:59:24PM +0200, Marc-André Lureau wrote: > > See docs/specs/vmcoreinfo.txt for details. > > > > "etc/vmcoreinfo" fw_cfg entry is added when using "-device vmcoreinfo". > > I'm wondering if you considered just adding the entry to fw_cfg

Re: [Qemu-devel] ping RE: question: I found a qemu crash about migration

2017-10-09 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 29.09.2017 um 21:06 hat Dr. David Alan Gilbert geschrieben: > > * Kevin Wolf (kw...@redhat.com) wrote: > > > Am 28.09.2017 um 19:01 hat Dr. David Alan Gilbert geschrieben: > > > > Hi, > > > > This is a 'fun' bug; I had a good chat to kwolf about it ear

Re: [Qemu-devel] [RFC 24/29] vhost+postcopy: Lock around set_mem_table

2017-10-09 Thread Dr. David Alan Gilbert
* Maxime Coquelin (maxime.coque...@redhat.com) wrote: > > > On 10/03/2017 03:23 PM, Dr. David Alan Gilbert wrote: > > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > > * Maxime Coquelin (maxime.coque...@redhat.com) wrote: > > > > > > > > > > > > On 06/28/2017 09:00 PM, Dr. David Alan

[Qemu-devel] hot plug cpu report error

2017-10-09 Thread Paul Schlacter
report error: intel_rapl: no valid rapl domains found in package 0 intel_rapl: no valid rapl domains found in package 0 and then will shutdown after in a moment of time qemu log : qemu: qemu_mutex_lock: Invalid argument 2017-10-09 09:27:34.781+: shutting down, reason=crashed Find a sol

Re: [Qemu-devel] [PATCH v9 04/12] migration: Start of multiple fd work

2017-10-09 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Wed, Oct 04, 2017 at 12:46:28PM +0200, Juan Quintela wrote: >> We create new channels for each new thread created. We send through >> them a string containing multifd so we are >> sure that we connect the right channels in both sides. > > This message needs updat

Re: [Qemu-devel] [PATCH v9 04/12] migration: Start of multiple fd work

2017-10-09 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Wed, Oct 04, 2017 at 12:46:28PM +0200, Juan Quintela wrote: >> We create new channels for each new thread created. We send through >> them a string containing multifd so we are >> sure that we connect the right channels in both sides. > > This message needs updat

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-09 Thread Igor Mammedov
On Mon, 9 Oct 2017 12:03:36 +0100 "Daniel P. Berrange" wrote: > On Mon, Sep 11, 2017 at 06:59:24PM +0200, Marc-André Lureau wrote: > > See docs/specs/vmcoreinfo.txt for details. > > > > "etc/vmcoreinfo" fw_cfg entry is added when using "-device vmcoreinfo". > > I'm wondering if you considered

Re: [Qemu-devel] [PATCH v2] vga: stop passing pointers to vga_draw_line* functions

2017-10-09 Thread Gerd Hoffmann
On Mon, 2017-10-09 at 12:55 +0100, David Buchanan wrote: > I might be mistaken, but I don't think this patch actually fixes > CVE-2017-13672. I tested the latest git repo (last commit 530049bc1d) > against my initial reproducer, and QEMU still segfaults. Hmm, no segfault here. Tried gtk, sdl, vnc

[Qemu-devel] [PATCH v9 1/8] vmdk: Move vmdk_find_offset_in_cluster() to the top

2017-10-09 Thread Ashijeet Acharya
Move the existing vmdk_find_offset_in_cluster() function to the top of the driver. Signed-off-by: Ashijeet Acharya Reviewed-by: Fam Zheng --- block/vmdk.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index c665bcc977.

[Qemu-devel] [PATCH v9 0/8] Optimize VMDK I/O by allocating multiple clusters

2017-10-09 Thread Ashijeet Acharya
Previously posted series patches: v1 - http://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg02044.html v2 - http://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg05080.html v3 - http://lists.nongnu.org/archive/html/qemu-devel/2017-04/msg00074.html v4 - http://lists.nongnu.org/archive/htm

[Qemu-devel] [PATCH v9 2/8] vmdk: Rename get_whole_cluster() to vmdk_perform_cow()

2017-10-09 Thread Ashijeet Acharya
Rename the existing function get_whole_cluster() to vmdk_perform_cow() as its sole purpose is to perform COW for the first and the last allocated clusters if needed. Signed-off-by: Ashijeet Acharya Reviewed-by: Fam Zheng --- block/vmdk.c | 23 ++- 1 file changed, 14 insertio

[Qemu-devel] [PATCH v9 3/8] vmdk: Rename get_cluster_offset() to vmdk_get_cluster_offset()

2017-10-09 Thread Ashijeet Acharya
Rename the existing get_cluster_offset() to vmdk_get_cluster_offset() and update name in all the callers accordingly. Signed-off-by: Ashijeet Acharya Reviewed-by: Fam Zheng --- block/vmdk.c | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) d

[Qemu-devel] [PATCH v9 5/8] vmdk: Set maximum bytes allocated in one cycle

2017-10-09 Thread Ashijeet Acharya
Set the maximum bytes allowed to get allocated at once to be not more than the extent size boundary to handle writes at two separate extents appropriately. Signed-off-by: Ashijeet Acharya Reviewed-by: Fam Zheng --- block/vmdk.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-

[Qemu-devel] [PATCH v9 4/8] vmdk: Factor out metadata loading code out of vmdk_get_cluster_offset()

2017-10-09 Thread Ashijeet Acharya
Move the cluster tables loading code out of the existing vmdk_get_cluster_offset() function and implement it in separate get_cluster_table() and vmdk_l2load() functions. Signed-off-by: Ashijeet Acharya Reviewed-by: Fam Zheng --- block/vmdk.c | 153 ---

[Qemu-devel] [PATCH v9 7/8] vmdk: Update metadata for multiple clusters

2017-10-09 Thread Ashijeet Acharya
Include a next pointer in VmdkMetaData struct to point to the previous allocated L2 table. Modify vmdk_L2update to start updating metadata for allocation of multiple clusters at once. Signed-off-by: Ashijeet Acharya Reviewed-by: Fam Zheng --- block/vmdk.c | 128 +

[Qemu-devel] [PATCH v9 6/8] vmdk: New functions to assist allocating multiple clusters

2017-10-09 Thread Ashijeet Acharya
Introduce two new helper functions handle_alloc() and vmdk_alloc_cluster_offset(). handle_alloc() helps to allocate multiple clusters at once starting from a given offset on disk and performs COW if necessary for first and last allocated clusters. vmdk_alloc_cluster_offset() helps to return the off

[Qemu-devel] [PATCH v9 8/8] vmdk: Make vmdk_get_cluster_offset() return cluster offset only

2017-10-09 Thread Ashijeet Acharya
vmdk_alloc_clusters() introduced earlier now handles the task of allocating clusters and performing COW when needed. Thus we can change vmdk_get_cluster_offset() to stick to the sole purpose of returning cluster offset using sector number. Update the changes at all call sites. Signed-off-by: Ashij

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-09 Thread Daniel P. Berrange
On Mon, Oct 09, 2017 at 02:43:44PM +0200, Igor Mammedov wrote: > On Mon, 9 Oct 2017 12:03:36 +0100 > "Daniel P. Berrange" wrote: > > > On Mon, Sep 11, 2017 at 06:59:24PM +0200, Marc-André Lureau wrote: > > > See docs/specs/vmcoreinfo.txt for details. > > > > > > "etc/vmcoreinfo" fw_cfg entry is

Re: [Qemu-devel] [PATCH v9 05/12] migration: Create ram_multifd_page

2017-10-09 Thread Paolo Bonzini
On 04/10/2017 12:46, Juan Quintela wrote: > The function still don't use multifd, but we have simplified > ram_save_page, xbzrle and RDMA stuff is gone. We have added a new > counter and a new flag for this type of pages. > > Signed-off-by: Juan Quintela I still disagree with the approach, and

Re: [Qemu-devel] [PATCH v2] vga: stop passing pointers to vga_draw_line* functions

2017-10-09 Thread David Buchanan
I might be mistaken, but I don't think this patch actually fixes CVE-2017-13672. I tested the latest git repo (last commit 530049bc1d) against my initial reproducer, and QEMU still segfaults. I think this is because the actual OOB read occurs inside pixman, which of course is not affected by this

Re: [Qemu-devel] [PATCH v16 1/5] lib/xbitmap: Introduce xbitmap

2017-10-09 Thread Tetsuo Handa
On 2017/09/30 13:05, Wei Wang wrote: > /** > + * xb_preload - preload for xb_set_bit() > + * @gfp_mask: allocation mask to use for preloading > + * > + * Preallocate memory to use for the next call to xb_set_bit(). This function > + * returns with preemption disabled. It will be enabled by xb_pr

Re: [Qemu-devel] [PATCH v5 0/7] Generalize MDIO framework

2017-10-09 Thread Edgar E. Iglesias
On Fri, Sep 22, 2017 at 02:13:16PM -0300, Philippe Mathieu-Daudé wrote: > Hi, > > I have a follow up series using multiples PHY on the MDIO bus based on this > series. Hi Philippe! I think this is a good improvement compared to todays state. It may make sense to have the generic mdio bus functio

Re: [Qemu-devel] [PATCH v2] vga: stop passing pointers to vga_draw_line* functions

2017-10-09 Thread David Buchanan
On 09/10/17 13:56, Gerd Hoffmann wrote: > How do you start > qemu? Which user interface? Like this: qemu-system-x86_64 -vga cirrus [disk image] (which I assume is using the GTK interface) I have attached the reproducer NASM source and disk image. Note that the reproducer is using VBE. > Have y

Re: [Qemu-devel] [PATCH 0/7] x86: Rework KVM-defaults compat code, enable kvm_pv_unhalt by default

2017-10-09 Thread Paolo Bonzini
On 06/10/2017 23:52, Eduardo Habkost wrote: > This series enables kvm_pv_unhalt by default on pc-*-2.11 and > newer. > > To do that, I first reworked the existing > x86_cpu_change_kvm_default() logic to use compat_props instead, > so we don't need to make the chain of pc_compat_*() functions > gro

Re: [Qemu-devel] [PATCH 1/7] qemu-doc: Document minimum kernel version for KVM in x86_64

2017-10-09 Thread Paolo Bonzini
On 06/10/2017 23:52, Eduardo Habkost wrote: > The default set of KVM CPU features require the host kernel to > support them. KVM_PV_EOI is the newest one, and was included on > Linux v3.6 (Linux commit ae7a2a3f). > > Running on an old host might break management software > expectations because th

[Qemu-devel] [PATCH 0/9] v8M: BLXNS, SG, secure function return

2017-10-09 Thread Peter Maydell
This patchset is mostly implementation of SG, BLXNS and secure function return. Parts of it were in the previous patchset, but had a bug which I've fixed in the SG implementation where we read the first half of the insn twice by mistake. Patch 1 is a new trivial bugfix. Patches 2-4 were in the pre

[Qemu-devel] [PATCH 2/9] target/arm: Implement SG instruction

2017-10-09 Thread Peter Maydell
Implement the SG instruction, which we emulate 'by hand' in the exception handling code path. Signed-off-by: Peter Maydell --- target/arm/helper.c | 132 ++-- 1 file changed, 127 insertions(+), 5 deletions(-) diff --git a/target/arm/helper.c b/tar

[Qemu-devel] [PATCH 8/9] target/arm: Support some Thumb insns being always unconditional

2017-10-09 Thread Peter Maydell
A few Thumb instructions are always unconditional even inside an IT block (as opposed to being UNPREDICTABLE if used inside an IT block): BKPT, the v8M SG instruction, and the A profile HLT (debug halt) instruction. This means we need to suppress the jump-over-instruction-on-condfail code generati

[Qemu-devel] [PATCH 6/9] target/arm: Pull Thumb insn word loads up to top level

2017-10-09 Thread Peter Maydell
Refactor the Thumb decode to do the loads of the instruction words at the top level rather than only loading the second half of a 32-bit Thumb insn in the middle of the decode. This is simple apart from the awkward case of Thumb1, where the BL/BLX prefix and suffix instructions live in what in Thu

[Qemu-devel] [PATCH 7/9] target-arm: Simplify insn_crosses_page()

2017-10-09 Thread Peter Maydell
Recent changes have left insn_crosses_page() more complicated than it needed to be: * it's only called from thumb_tr_translate_insn() so we know for certain that we're looking at a Thumb insn * the caller's check for dc->pc >= dc->next_page_start - 3 means that dc->pc can't possibly be 4 al

[Qemu-devel] [PATCH 5/9] target-arm: Don't check for "Thumb2 or M profile" for not-Thumb1

2017-10-09 Thread Peter Maydell
The code which implements the Thumb1 split BL/BLX instructions is guarded by a check on "not M or THUMB2". All we really need to check here is "not THUMB2" (and we assume that elsewhere too, eg in the ARCH(6T2) test that UNDEFs the Thumb2 insns). This doesn't change behaviour because all M profile

[Qemu-devel] [PATCH 3/9] target/arm: Implement BLXNS

2017-10-09 Thread Peter Maydell
Implement the BLXNS instruction, which allows secure code to call non-secure code. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/helper.h| 1 + target/arm/internals.h | 1 + target/arm/helper.c| 59 ++ target

[Qemu-devel] [PATCH 9/9] target/arm: Implement SG instruction corner cases

2017-10-09 Thread Peter Maydell
The common situation of the SG instruction is that it is executed from S&NSC memory by a CPU in NS state. That case is handled by v7m_handle_execute_nsc(). However the instruction also has defined behaviour in a couple of other cases: * SG instruction in NS memory (behaves as a NOP) * SG in S mem

[Qemu-devel] [PATCH 1/9] target/arm: Add M profile secure MMU index values to get_a32_user_mem_index()

2017-10-09 Thread Peter Maydell
Add the M profile secure MMU index values to the switch in get_a32_user_mem_index() so that LDRT/STRT work correctly rather than asserting at translate time. Signed-off-by: Peter Maydell --- target/arm/translate.c | 4 1 file changed, 4 insertions(+) diff --git a/target/arm/translate.c b/t

[Qemu-devel] [PATCH 4/9] target/arm: Implement secure function return

2017-10-09 Thread Peter Maydell
Secure function return happens when a non-secure function has been called using BLXNS and so has a particular magic LR value (either 0xfefe or 0xfeff). The function return via BX behaves specially when the new PC value is this magic value, in the same way that exception returns are handled.

Re: [Qemu-devel] [PATCH v1 1/5] s390x/kvm: Enable AIS from CPU model always

2017-10-09 Thread Pierre Morel
On 09/10/2017 11:09, Cornelia Huck wrote: On Wed, 4 Oct 2017 15:49:35 +0200 Pierre Morel wrote: As this patchset will introduce AIS emulation, we always enable Adapter Interrupt Suppression, depending only from the CPU model. Signed-off-by: Pierre Morel --- target/s390x/kvm.c | 1 + 1 fi

Re: [Qemu-devel] [PATCH v1 2/5] s390x/css: Use AIS AIRQ injection only if adapter support AIS

2017-10-09 Thread Pierre Morel
On 09/10/2017 10:17, Cornelia Huck wrote: On Wed, 4 Oct 2017 15:49:36 +0200 Pierre Morel wrote: Testing to use Adapter Interrupt suppression or not depend on AIS being enabled in the kernel. To implement AIS emulation we must move this test inside the FLIC dedicated irq_inject function. Furt

[Qemu-devel] [PATCH v1 1/1] virtio-ccw: Add the virtio-input devices for CCW bus

2017-10-09 Thread Farhan Ali
Wire up the virtio-input HID devices (keyboard, mouse, tablet) for the CCW bus. The virtio-input is a virtio-1 device, so disable legacy revision 0. Signed-off-by: Farhan Ali Reviewed-by: Halil Pasic Reviewed-by: Christian Borntraeger --- hw/s390x/virtio-ccw.c | 100 +++

Re: [Qemu-devel] [PATCH v1 3/5] s390x/intc: Emulate Adapter Interrupt Suppression

2017-10-09 Thread Pierre Morel
On 09/10/2017 10:42, Cornelia Huck wrote: On Wed, 4 Oct 2017 15:49:37 +0200 Pierre Morel wrote: Emulate the Adapter Interrupt Suppression in the KVM FLIC interface when the kernel does not support AIS. When the kernel KVM does not support AIS, we can not support VFIO PCI devices but we still

Re: [Qemu-devel] [PATCH v1 3/5] s390x/intc: Emulate Adapter Interrupt Suppression

2017-10-09 Thread Pierre Morel
On 09/10/2017 11:08, Cornelia Huck wrote: On Mon, 9 Oct 2017 10:42:44 +0200 Cornelia Huck wrote: On Wed, 4 Oct 2017 15:49:37 +0200 Pierre Morel wrote: Emulate the Adapter Interrupt Suppression in the KVM FLIC interface when the kernel does not support AIS. When the kernel KVM does not sup

Re: [Qemu-devel] [PATCH v9 0/8] Optimize VMDK I/O by allocating multiple clusters

2017-10-09 Thread Fam Zheng
On Mon, 10/09 18:29, Ashijeet Acharya wrote: > Optimization test results: > > This patch series improves 128 KB sequential write performance to an > empty VMDK file by 54% > > Benchmark command: ./qemu-img bench -w -c 1024 -s 128K -d 1 -t none -f > vmdk test.vmdk > > Changes in v9: > - rebase th

Re: [Qemu-devel] [PATCH 49/88] hw/misc: use g_new() family of functions

2017-10-09 Thread Gabriel L. Somlo
Reviewed-by: Gabriel Somlo On Fri, Oct 06, 2017 at 08:49:44PM -0300, Philippe Mathieu-Daudé wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Philippe Mathieu-Daudé > [PMD: added hw/misc/pvpanic.c] > --- > hw/misc/applesmc.c | 2 +- > hw/misc/pvpanic.c |

Re: [Qemu-devel] [PATCH 54/88] KVM: use g_new() family of functions

2017-10-09 Thread Gabriel L. Somlo
Reviewed-by: Gabriel Somlo On Fri, Oct 06, 2017 at 08:49:49PM -0300, Philippe Mathieu-Daudé wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Philippe Mathieu-Daudé > [PMD: more changes] > --- > accel/kvm/kvm-all.c | 8 > 1 file changed, 4 insert

Re: [Qemu-devel] [PATCH v1 4/5] s390x/pci: Refuse to realize VFIO-PCI if AIS needed but supported

2017-10-09 Thread Pierre Morel
On 09/10/2017 11:06, Cornelia Huck wrote: On Wed, 4 Oct 2017 15:49:38 +0200 Pierre Morel wrote: "not supported", surely? :) yes, "not supported" In S390x the Adapter Interrupt Suppression facility is used to mask interrupts of other PCI devices during interruption handling. VFIO PCI allo

Re: [Qemu-devel] [PATCH 1/2] spapr/rtas: disable the decrementer interrupt when a CPU is unplugged

2017-10-09 Thread Cédric Le Goater
On 10/06/2017 12:10 PM, David Gibson wrote: > On Fri, Oct 06, 2017 at 11:53:30AM +0200, Benjamin Herrenschmidt wrote: >> On Fri, 2017-10-06 at 20:07 +1100, David Gibson wrote: >>> Hm. Checking mmu_model doesn't seem right to me. I mean, it'll get >>> the right answer in practice, but the LPCR pro

Re: [Qemu-devel] [PATCH v7 02/20] hw/arm/smmu-common: IOMMU memory region and address space setup

2017-10-09 Thread Peter Maydell
On 1 September 2017 at 18:21, Eric Auger wrote: > We enumerate all the PCI devices attached to the SMMU and > initialize an associated IOMMU memory region and address space. > This happens on SMMU base instance init. > > Those info are stored in SMMUDevice objects. The devices are > grouped accord

Re: [Qemu-devel] [PATCH 7/7] target/i386: Enable kvm_pv_unhalt by default

2017-10-09 Thread Paolo Bonzini
On 06/10/2017 23:52, Eduardo Habkost wrote: > Commit f010bc643a (target-i386: add feature kvm_pv_unhalt) introduced the > kvm_pv_unhalt feature but didn't enable it by default. > > Without kvm_pv_unhalt we see a measurable degradation in scheduling > performance, so enabling it by default

Re: [Qemu-devel] [PATCH 7/7] target/i386: Enable kvm_pv_unhalt by default

2017-10-09 Thread Alexander Graf
On 09.10.17 16:40, Paolo Bonzini wrote: > On 06/10/2017 23:52, Eduardo Habkost wrote: >> Commit f010bc643a (target-i386: add feature kvm_pv_unhalt) introduced the >> kvm_pv_unhalt feature but didn't enable it by default. >> >> Without kvm_pv_unhalt we see a measurable degradation in schedul

Re: [Qemu-devel] [PATCH v1 4/5] s390x/pci: Refuse to realize VFIO-PCI if AIS needed but supported

2017-10-09 Thread Alex Williamson
On Wed, 4 Oct 2017 15:49:38 +0200 Pierre Morel wrote: > In S390x the Adapter Interrupt Suppression facility is used to mask > interrupts of other PCI devices during interruption handling. > > VFIO PCI allows the interrupts to be delivered rapidely through KVM via > IRQfd or to be delivered thro

Re: [Qemu-devel] [PATCH v7 03/20] hw/arm/smmu-common: smmu_read/write_sysmem

2017-10-09 Thread Peter Maydell
On 1 September 2017 at 18:21, Eric Auger wrote: > Those two functions will be used to access configuration > data (STE, CD) and page table entries in guest RAM. > > Signed-off-by: Eric Auger > --- > hw/arm/smmu-common.c | 37 + > include/hw/arm/smmu-co

Re: [Qemu-devel] [PATCH v2 0/4] blockjobs: add explicit job reaping

2017-10-09 Thread Nikolay Shirokovskiy
Hi, John. This is the original letter https://lists.nongnu.org/archive/html/qemu-devel/2016-11/msg04091.html. In short problem is next. If during full backup I miss the completion event I don't know whether backup file is correct or not. If I miss the event during incremental backup additionally

Re: [Qemu-devel] [PATCH 02/17] imx_fec: Do not calculate FEC

2017-10-09 Thread Andrey Smirnov
On Fri, Oct 6, 2017 at 6:48 AM, Peter Maydell wrote: > On 18 September 2017 at 20:50, Andrey Smirnov > wrote: >> Save some computation time and avoid calculating CRC's frame >> >> Cc: Peter Maydell >> Cc: Jason Wang >> Cc: qemu-devel@nongnu.org >> Cc: qemu-...@nongnu.org >> Cc: yurov...@gmail.

[Qemu-devel] [PATCH] qcow2: Use BDRV_SECTOR_BITS instead of its literal value

2017-10-09 Thread Alberto Garcia
BDRV_SECTOR_BITS is defined to be 9 in block.h (and BDRV_SECTOR_SIZE is calculated from that), but there are still a few placed where we are using the literal value instead of the macro. Signed-off-by: Alberto Garcia --- block/qcow2-cluster.c | 6 +++--- block/qcow2.c | 4 ++-- 2 files c

Re: [Qemu-devel] [PATCH v2 00/13] More fully implement ARM PMUv3

2017-10-09 Thread Aaron Lindsay
Ping! Unfortunately I'm not sure who to add other than the current recipients, but I'm eager for feedback and would love to work this into something that will allow for using the full ARM PMU. I've also updated Peter Crosthwaite's email since the xilinx one appears to be stale. -Aaron On Sep 2

[Qemu-devel] ‘vte_terminal_copy_clipboard’ is deprecated

2017-10-09 Thread Anthony PERARD
Hi, Looks like vte_terminal_copy_clipboard() is been deprecated: CC ui/gtk.o ui/gtk.c: In function ‘gd_menu_copy’ ui/gtk.c:1705:5: error: ‘vte_terminal_copy_clipboard’ is deprecated [-Werror=deprecated-declarations] vte_terminal_copy_clipboard(VTE_TERMINAL(vc->vte.terminal)); ^~

Re: [Qemu-devel] [PATCH 04/17] imx_fec: Change queue flushing heuristics

2017-10-09 Thread Andrey Smirnov
On Fri, Oct 6, 2017 at 6:56 AM, Peter Maydell wrote: > On 18 September 2017 at 20:50, Andrey Smirnov > wrote: >> In current implementation, packet queue flushing logic seem to suffer >> from a deadlock like scenario if a packet is received by the interface >> before before Rx ring is initialized

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-09 Thread Halil Pasic
On 10/09/2017 01:07 PM, Thomas Huth wrote: > On 09.10.2017 12:54, Halil Pasic wrote: >> >> >> On 10/09/2017 10:20 AM, Thomas Huth wrote: >>> On 04.10.2017 17:41, Halil Pasic wrote: CSS code needs to tell the IO instruction handlers located in how should >>> >>> located in how? >>> >> >> Firs

Re: [Qemu-devel] ‘vte_terminal_copy_clipboard’ is deprecated

2017-10-09 Thread Daniel P. Berrange
On Mon, Oct 09, 2017 at 03:55:42PM +0100, Anthony PERARD wrote: > Hi, > > Looks like vte_terminal_copy_clipboard() is been deprecated: > > CC ui/gtk.o > ui/gtk.c: In function ‘gd_menu_copy’ > ui/gtk.c:1705:5: error: ‘vte_terminal_copy_clipboard’ is deprecated > [-Werror=deprecated-declara

  1   2   3   4   >