On Mon, Oct 09, 2017 at 03:55:42PM +0100, Anthony PERARD wrote: > Hi, > > Looks like vte_terminal_copy_clipboard() is been deprecated: > > CC ui/gtk.o > ui/gtk.c: In function ‘gd_menu_copy’ > ui/gtk.c:1705:5: error: ‘vte_terminal_copy_clipboard’ is deprecated > [-Werror=deprecated-declarations] > vte_terminal_copy_clipboard(VTE_TERMINAL(vc->vte.terminal)); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from /usr/include/vte-2.91/vte/vte.h:35:0, > from ui/gtk.c:47: > /usr/include/vte-2.91/vte/vtedeprecated.h:94:6: note: declared here > void vte_terminal_copy_clipboard(VteTerminal *terminal) _VTE_GNUC_NONNULL(1); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > make: *** [/local/home/sheep/work/qemu/rules.mak:66: ui/gtk.o] Error 1
The docs say it should be simply replaced with a call to vte_terminal_copy_clipboard_format, using VTE_FORMAT_TEXT as the format. So we just need to make either the old or new method call conditional on VTE version >= 0.50.0 Since you've got the new vte installed to test with, do you want to write a patch for that :-) Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
