Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: Add random ioctls

2017-10-05 Thread Laurent Vivier
On 05/10/2017 00:06, Marco A L Barbosa wrote: > I don't know how (and if it is necessary) to add buf field to > rand_pool_info struct. See > https://github.com/torvalds/linux/blob/5924bbecd0267d87c24110cbe2041b5075173a25/include/uapi/linux/random.h#L17 I doesn't look really trivial... To manage t

Re: [Qemu-devel] [PATCH] hw/s390x/sclp: Mark the sclp device with user_creatable = false

2017-10-05 Thread Cornelia Huck
On Wed, 4 Oct 2017 15:53:19 +0200 Thomas Huth wrote: > The "sclp" device is just an internal device that can not be instantiated > by the users. If they try to use it, they only get a simple error message: > > $ qemu-system-s390x -nographic -device sclp > qemu-system-s390x: Option '-device s390

Re: [Qemu-devel] [PATCH] s390x/sclp: mark sclp-cpu-hotplug as non-usercreatable

2017-10-05 Thread Cornelia Huck
On Wed, 4 Oct 2017 17:46:47 +0200 Cornelia Huck wrote: > A TYPE_SCLP_CPU_HOTPLUG device for handling cpu hotplug events > is already created by the sclp event facility. Adding a second > TYPE_SCLP_CPU_HOTPLUG device via -device sclp-cpu-hotplug creates > an ambiguity in raise_irq_cpu_hotplug(),

Re: [Qemu-devel] [PATCH v2 3/3] qom: add helper macro DEFINE_TYPES()

2017-10-05 Thread Igor Mammedov
On Wed, 4 Oct 2017 18:04:59 -0300 Eduardo Habkost wrote: > On Wed, Oct 04, 2017 at 12:08:02PM +0200, Igor Mammedov wrote: > > DEFINE_TYPES() will help to simplify following routine patterns: > > > > static void foo_register_types(void) > > { > > type_register_static(&foo1_type_info); > >

Re: [Qemu-devel] [PATCH] hw/s390x/sclp: Mark the sclp device with user_creatable = false

2017-10-05 Thread Cornelia Huck
On Wed, 4 Oct 2017 19:06:57 +0200 Thomas Huth wrote: > On 04.10.2017 17:18, Pierre Morel wrote: > > On 04/10/2017 15:53, Thomas Huth wrote: > >> The "sclp" device is just an internal device that can not be instantiated > >> by the users. If they try to use it, they only get a simple error > >>

Re: [Qemu-devel] [PATCH] qdev: Check for the availability of a hotplug controller before adding a device

2017-10-05 Thread Igor Mammedov
On Tue, 3 Oct 2017 15:49:46 -0300 Eduardo Habkost wrote: > On Tue, Oct 03, 2017 at 06:46:02PM +0200, Thomas Huth wrote: > > The qdev_unplug() function contains a g_assert(hotplug_ctrl) statement, > > so QEMU crashes when the user tries to device_add + device_del a device > > that does not have a

[Qemu-devel] Qemu Documentation

2017-10-05 Thread Swetheendra Tallamraju
I am working on qemu source code to provide extra functionality of emulating virtual usb. Can I get any documentation for the qemu source code that helps me in implementing this?

Re: [Qemu-devel] [PATCH v1 2/5] netduino2: Specify the valid CPUs

2017-10-05 Thread Igor Mammedov
On Wed, 4 Oct 2017 19:21:09 -0300 Philippe Mathieu-Daudé wrote: > >>> +const char *netduino_valid_cpus[] = { ARM_CPU_TYPE_NAME("cortex-m3"), > >> style nit, ^^^ put entries on new line with > >> typical 4 space alignment > > > > Do you mean like this? > > > >

[Qemu-devel] [Bug 1721468] [NEW] Free invalid pointer crash in vnc

2017-10-05 Thread Peter Sabaini
Public bug reported: Attempt to send qemu monitor command crashed the VM. I have sent the following qemu monitor command to a running instance: virsh qemu-monitor-command --hmp instance-xxx 'change vnc none' At the time I was connected via VNC. Closing my xvncviewer resulted in a crash of th

[Qemu-devel] [PATCH] hw/s390x: Mark the "sclpquiesce" device with user_creatable = false

2017-10-05 Thread Thomas Huth
The "sclpquiesce" device is just an internal device that should not be created by the user directly. Though it currently does not seem to cause any obvious trouble when the user instantiates an additional device, let's better mark it with user_creatable = false to avoid unexpected behavior, e.g. be

Re: [Qemu-devel] [PATCH] hw/s390x: Mark the "sclpquiesce" device with user_creatable = false

2017-10-05 Thread Halil Pasic
On 10/05/2017 10:45 AM, Thomas Huth wrote: > The "sclpquiesce" device is just an internal device that should not be > created by the user directly. Though it currently does not seem to cause > any obvious trouble when the user instantiates an additional device, let's > better mark it with user_cr

Re: [Qemu-devel] [PATCH] qdev: Check for the availability of a hotplug controller before adding a device

2017-10-05 Thread Thomas Huth
On 05.10.2017 10:36, Igor Mammedov wrote: > On Tue, 3 Oct 2017 15:49:46 -0300 > Eduardo Habkost wrote: > >> On Tue, Oct 03, 2017 at 06:46:02PM +0200, Thomas Huth wrote: >>> The qdev_unplug() function contains a g_assert(hotplug_ctrl) statement, >>> so QEMU crashes when the user tries to device_ad

Re: [Qemu-devel] [PATCH v1 3/5] xlnx-zcu102: Specify the valid CPUs

2017-10-05 Thread Igor Mammedov
On Wed, 4 Oct 2017 14:39:20 -0700 Alistair Francis wrote: > On Wed, Oct 4, 2017 at 9:34 AM, Eduardo Habkost wrote: > > On Wed, Oct 04, 2017 at 03:08:16PM +0200, Igor Mammedov wrote: > >> On Wed, 4 Oct 2017 09:28:51 -0300 > >> Eduardo Habkost wrote: > >> > >> > On Wed, Oct 04, 2017 at 01:12:

[Qemu-devel] [PULL 0/4] Usb 20171005 patches

2017-10-05 Thread Gerd Hoffmann
The following changes since commit ab161529261928ae7f3556e3220829c34b2686ec: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20170927a' into staging (2017-09-27 22:44:51 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/usb-201

[Qemu-devel] [PULL 3/4] usb: Use angle brackets for cacard include directive

2017-10-05 Thread Gerd Hoffmann
From: Fam Zheng This is a library header, so angle brackets are more appropriate; also move the line to before QEMU headers, as is recommended in HACKING. Signed-off-by: Fam Zheng Message-id: 20170920085952.3872-1-f...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/usb/ccid-card-passthru.c |

[Qemu-devel] [PULL 4/4] usb: fix host-stub.c build race

2017-10-05 Thread Gerd Hoffmann
Suggested-by: Thomas Huth Signed-off-by: Gerd Hoffmann Reviewed-by: Thomas Huth Message-id: 20171004125210.7817-1-kra...@redhat.com --- hw/usb/Makefile.objs | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs index 0e6d54b21f..bdfead6701 100644 --- a/

[Qemu-devel] [PULL 1/4] hw/usb/bus: Remove bad object_unparent() from usb_try_create_simple()

2017-10-05 Thread Gerd Hoffmann
From: Thomas Huth Valgrind detects an invalid read operation when hot-plugging of an USB device fails: $ valgrind x86_64-softmmu/qemu-system-x86_64 -device usb-ehci -nographic -S ==30598== Memcheck, a memory error detector ==30598== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al.

[Qemu-devel] [PULL 2/4] usb: fix libusb config variable name.

2017-10-05 Thread Gerd Hoffmann
Cc: Jan Kiszka Fixes: 4e5ee5b21c84fe3023a64b5cc2e12a52ab0597c1 Signed-off-by: Gerd Hoffmann Tested-by: Jan Kiszka Message-id: 20170926063820.30773-1-kra...@redhat.com --- hw/usb/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/Makefile.objs b/hw/usb/Makef

Re: [Qemu-devel] [PATCH 0/3] hmp-commands-info: Texinfo fixes

2017-10-05 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Markus Armbruster (3): > hmp-commands-info: Fix "info rocker-FOO" misspellings > hmp-commands-info: Move Texinfo stanzas to conventional place > hmp-commands-info: Change "@findex FOO" to "@findex info FOO" Queued for HMP > hmp-commands-info

Re: [Qemu-devel] [PATCH] qdev: Check for the availability of a hotplug controller before adding a device

2017-10-05 Thread Igor Mammedov
On Thu, 5 Oct 2017 11:00:29 +0200 Thomas Huth wrote: > On 05.10.2017 10:36, Igor Mammedov wrote: > > On Tue, 3 Oct 2017 15:49:46 -0300 > > Eduardo Habkost wrote: > > > >> On Tue, Oct 03, 2017 at 06:46:02PM +0200, Thomas Huth wrote: > >>> The qdev_unplug() function contains a g_assert(hotplu

Re: [Qemu-devel] [PATCH] qdev: Check for the availability of a hotplug controller before adding a device

2017-10-05 Thread Igor Mammedov
On Thu, 5 Oct 2017 11:12:41 +0200 Igor Mammedov wrote: > On Thu, 5 Oct 2017 11:00:29 +0200 > Thomas Huth wrote: [...] > > Yes, currently we might be able to do it with the typename only ... but > > that seems to be a rather big rework right now, and we might indeed need > > a real device instan

[Qemu-devel] [Bug 1721468] Re: Free invalid pointer crash in vnc

2017-10-05 Thread Thomas Huth
** Project changed: qemu => qemu (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1721468 Title: Free invalid pointer crash in vnc Status in qemu package in Ubuntu: New Bug description:

Re: [Qemu-devel] loading bitmaps in invalidate_cache fails

2017-10-05 Thread Vladimir Sementsov-Ogievskiy
12.09.2017 12:46, Kevin Wolf wrote: Am 11.09.2017 um 18:51 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi Kevin! I'm confused with relations of permissions and invalidation, can you please help? Now dirty bitmaps are loaded in invalidate_cache. Here is a problem with migration: 1. destinati

Re: [Qemu-devel] [Qemu-block] [PATCH 8/8] nbd: Minimal structured read for client

2017-10-05 Thread Vladimir Sementsov-Ogievskiy
03.10.2017 17:06, Paolo Bonzini wrote: On 03/10/2017 15:35, Vladimir Sementsov-Ogievskiy wrote: In the end this probably means that you have a read_chunk_header function and a read_chunk function.  READ has a loop that calls read_chunk_header followed by direct reading into the QEMUIOVector, whi

[Qemu-devel] [PULL 0/6] Ui 20171005 patches

2017-10-05 Thread Gerd Hoffmann
The following changes since commit d147f7e815f97cb477e223586bcb80c316ae10ea: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-10-03 16:27:24 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20171005-pull-request

[Qemu-devel] [PULL 3/6] ui: add keycodemapdb repository as a GIT submodule

2017-10-05 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a data file mapping between all the different scancode/keycode/keysym sets that are known, and a tool to auto-generate lookup tables for different combinations. It is used by GTK-VNC, SPICE-GTK and libvirt f

[Qemu-devel] [PULL 5/6] ui: convert key events to QKeyCodes immediately

2017-10-05 Thread Gerd Hoffmann
From: "Daniel P. Berrange" Always use QKeyCode in the InputKeyEvent struct, by converting key numbers to QKeyCode at the time the event is created. This allows the code processing / consuming key events to assume QKeyCode is used. The only place we accept a key number in the InputKeyEvent struct

[Qemu-devel] [PULL 6/6] ui: don't export qemu_input_event_new_key

2017-10-05 Thread Gerd Hoffmann
From: "Daniel P. Berrange" All public code should use qemu_input_event_send_key* functions instead of creating an event directly. Signed-off-by: Daniel P. Berrange Message-id: 20170929101201.21039-7-berra...@redhat.com Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 1 - ui/input.c

Re: [Qemu-devel] [Qemu-block] [PATCH 8/8] nbd: Minimal structured read for client

2017-10-05 Thread Vladimir Sementsov-Ogievskiy
03.10.2017 17:06, Paolo Bonzini wrote: On 03/10/2017 15:35, Vladimir Sementsov-Ogievskiy wrote: In the end this probably means that you have a read_chunk_header function and a read_chunk function.  READ has a loop that calls read_chunk_header followed by direct reading into the QEMUIOVector, whi

[Qemu-devel] [PULL 4/6] ui: convert common input code to keycodemapdb

2017-10-05 Thread Gerd Hoffmann
From: "Daniel P. Berrange" Replace the number_to_qcode, qcode_to_number and linux_to_qcode tables with automatically generated tables. Missing entries in linux_to_qcode now fixed: KEY_LINEFEED -> Q_KEY_CODE_LF KEY_KPEQUAL -> Q_KEY_CODE_KP_EQUALS KEY_COMPOSE -> Q_KEY_CODE_COMPOSE KEY_AGA

[Qemu-devel] [PULL 2/6] docker: don't rely on submodules existing in the main checkout

2017-10-05 Thread Gerd Hoffmann
From: "Daniel P. Berrange" When building the tarball to pass into the docker/vm test image, the code relies on the git submodules being checked out in the main checkout. ie if the developer has not run 'git submodule update --init dtc' many of the docker tests will fail due to the libfdt package

[Qemu-devel] [PULL 1/6] build: automatically handle GIT submodule checkout for dtc

2017-10-05 Thread Gerd Hoffmann
From: "Daniel P. Berrange" Currently if DTC is required by configure and not available in the host OS install, we exit with an error message telling the user to checkout a git submodule or install the library. This introduces automatic handling of the git submodule checkout process and enables i

Re: [Qemu-devel] [Qemu-block] [PATCH v6 2/6] qapi/qlist: Add qlist_append_null() macro

2017-10-05 Thread Alberto Garcia
On Wed 04 Oct 2017 05:25:49 PM CEST, Max Reitz wrote: > Besides the macro itself, this patch also adds a corresponding > Coccinelle rule. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: Add random ioctls

2017-10-05 Thread Marco A L Barbosa
> > I doesn't look really trivial... > > To manage the buf field you must read buf_size and it cannot be done in > a generic way: you must define a function to translate the buffer, use > IOCTL_SPECIAL() with RNDADDENTROPY and RNDGETPOOL. > > You should send your patch using "git send-email" or "gi

Re: [Qemu-devel] [PATCH] hw/s390x: Mark the "sclpquiesce" device with user_creatable = false

2017-10-05 Thread Claudio Imbrenda
On Thu, 5 Oct 2017 10:45:05 +0200 Thomas Huth wrote: > The "sclpquiesce" device is just an internal device that should not be > created by the user directly. Though it currently does not seem to > cause any obvious trouble when the user instantiates an additional > device, let's better mark it w

Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: Add random ioctls

2017-10-05 Thread Laurent Vivier
On 05/10/2017 12:24, Marco A L Barbosa wrote: > I doesn't look really trivial... > > To manage the buf field you must read buf_size and it cannot be done in > a generic way: you must define a function to translate the buffer, use > IOCTL_SPECIAL() with RNDADDENTROPY and RNDGETPOOL.

Re: [Qemu-devel] [Qemu-block] [PATCH 8/8] nbd: Minimal structured read for client

2017-10-05 Thread Paolo Bonzini
On 05/10/2017 12:02, Vladimir Sementsov-Ogievskiy wrote: > 03.10.2017 17:06, Paolo Bonzini wrote: >> On 03/10/2017 15:35, Vladimir Sementsov-Ogievskiy wrote: > In the end this probably means that you have a read_chunk_header > function and a read_chunk function.  READ has a loop that calls

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 0/5] virtio-iommu: VFIO integration

2017-10-05 Thread Auger Eric
Hi Linu, On 04/10/2017 13:49, Linu Cherian wrote: > Hi Eric, > > > On Wed Sep 27, 2017 at 11:24:01AM +0200, Auger Eric wrote: >> Hi Linu, >> >> On 27/09/2017 11:21, Linu Cherian wrote: >>> On Wed Sep 27, 2017 at 10:55:07AM +0200, Auger Eric wrote: Hi Linu, On 27/09/2017 10:30, Bhar

[Qemu-devel] [PULL 0/5] hmp queue

2017-10-05 Thread Dr. David Alan Gilbert (git)
b.com/dagrh/qemu.git tags/pull-hmp-20171005 for you to fetch changes up to 1b591700e6410d1a8f7700a13686a16759977204: hmp-commands-info: Change "@findex FOO" to "@findex info FOO" (2017-10-05 10:08:39 +0100)

[Qemu-devel] [PULL 5/5] hmp-commands-info: Change "@findex FOO" to "@findex info FOO"

2017-10-05 Thread Dr. David Alan Gilbert (git)
From: Markus Armbruster qemu-doc has the monitor commands in the "Function Index". The "info FOO" are listed as "FOO" there. List them as "info FOO" instead. Signed-off-by: Markus Armbruster Message-Id: <20171002134538.23332-4-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Marc-Andr

[Qemu-devel] [PULL 1/5] hmp: Missing handle_errors

2017-10-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" hmp_info_memdev && hmp_info_memory_devices were missing hmp_handle_error calls. Add them. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20170817104216.29150-2-dgilb...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Dr. David Alan Gilbert --- hmp.c | 2

[Qemu-devel] [PULL 2/5] hmp: Fix unknown command for subtable

2017-10-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" (qemu) info foo unknown command: 'foo' fix this to: (qemu) info foo unknown command: 'info foo' Reported-by: Markus Armbruster Signed-off-by: Dr. David Alan Gilbert Message-Id: <20170817104216.29150-3-dgilb...@redhat.com> Reviewed-by: Eric Blake Signed-off-by:

[Qemu-devel] [PULL 3/5] hmp-commands-info: Fix "info rocker-FOO" misspellings

2017-10-05 Thread Dr. David Alan Gilbert (git)
From: Markus Armbruster Screwed up in commit da76ee7. Signed-off-by: Markus Armbruster Message-Id: <20171002134538.23332-2-arm...@redhat.com> Reviewed-by: Marc-André Lureau Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- hmp-commands-info.hx | 6 +++--- 1 file

[Qemu-devel] [PULL 4/5] hmp-commands-info: Move Texinfo stanzas to conventional place

2017-10-05 Thread Dr. David Alan Gilbert (git)
From: Markus Armbruster A command's STEXI..ETEXI stanza follows the command's initializer. Two commands got them backwards. Correct that. Signed-off-by: Markus Armbruster Message-Id: <20171002134538.23332-3-arm...@redhat.com> Reviewed-by: Marc-André Lureau Reviewed-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH v2 0/7] xen: xen-domid-restrict improvements

2017-10-05 Thread Ian Jackson
no-re...@patchew.org writes ("Re: [Qemu-devel] [PATCH v2 0/7] xen: xen-domid-restrict improvements"): > ERROR: consider using qemu_strtoul in preference to strtoul > #42: FILE: os-posix.c:160: > +lv = strtoul(optarg, &ep, 0); /* can't qemu_strtoul, want *ep=='.' */ > > total: 1 errors, 0

[Qemu-devel] [PATCH v10 1/3] migration: postcopy_place_page factoring out

2017-10-05 Thread Alexey Perevalov
Need to mark copied pages as closer as possible to the place where it tracks down. That will be necessary in futher patch. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Alexey Perevalov --- migration/postcopy-ram.c | 13 +++-- migr

[Qemu-devel] [PATCH v10 2/3] migration: introduce qemu_ufd_copy_ioctl helper

2017-10-05 Thread Alexey Perevalov
Just for placing auxilary operations inside helper, auxilary operations like: track received pages, notify about copying operation in futher patches. Reviewed-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Signed-off-by: Alexey Perevalov --- migration/postcopy-ram

[Qemu-devel] [PATCH v10 0/3] Add bitmap for received pages in postcopy migration

2017-10-05 Thread Alexey Perevalov
This is 10th version of [PATCH v1 0/2] Add bitmap for copied pages in postcopy migration cover message from there This is a separate patch set, it derived from https://www.mail-archive.com/qemu-devel@nongnu.org/msg456004.html There are several possible use cases: 1. solve issue with postcopy live

[Qemu-devel] [PATCH v10 3/3] migration: add bitmap for received page

2017-10-05 Thread Alexey Perevalov
This patch adds ability to track down already received pages, it's necessary for calculation vCPU block time in postcopy migration feature, and for recovery after postcopy migration failure. Also it's necessary to solve shared memory issue in postcopy livemigration. Information about received page

[Qemu-devel] [PATCH v11 1/6] migration: introduce postcopy-blocktime capability

2017-10-05 Thread Alexey Perevalov
Right now it could be used on destination side to enable vCPU blocktime calculation for postcopy live migration. vCPU blocktime - it's time since vCPU thread was put into interruptible sleep, till memory page was copied and thread awake. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alexey P

[Qemu-devel] [PATCH v11 0/6] calculate blocktime for postcopy live migration

2017-10-05 Thread Alexey Perevalov
This is 11th version. The rationale for that idea is following: vCPU could suspend during postcopy live migration until faulted page is not copied into kernel. Downtime on source side it's a value - time interval since source turn vCPU off, till destination start runnig vCPU. But that value was pr

[Qemu-devel] [PATCH v11 4/6] migration: postcopy_blocktime documentation

2017-10-05 Thread Alexey Perevalov
Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alexey Perevalov --- docs/devel/migration.txt | 13 + 1 file changed, 13 insertions(+) diff --git a/docs/devel/migration.txt b/docs/devel/migration.txt index 4030703..cebfe7a 100644 --- a/docs/devel/migration.txt +++ b/docs/devel/mi

[Qemu-devel] [PATCH v11 2/6] migration: add postcopy blocktime ctx into MigrationIncomingState

2017-10-05 Thread Alexey Perevalov
This patch adds request to kernel space for UFFD_FEATURE_THREAD_ID, in case when this feature is provided by kernel. PostcopyBlocktimeContext is incapsulated inside postcopy-ram.c, due to it's postcopy only feature. Also it defines PostcopyBlocktimeContext's instance live time. Information from Po

[Qemu-devel] [PATCH v11 3/6] migration: calculate vCPU blocktime on dst side

2017-10-05 Thread Alexey Perevalov
This patch provides blocktime calculation per vCPU, as a summary and as a overlapped value for all vCPUs. This approach was suggested by Peter Xu, as an improvements of previous approch where QEMU kept tree with faulted page address and cpus bitmask in it. Now QEMU is keeping array with faulted pa

[Qemu-devel] [PATCH v11 5/6] migration: add blocktime calculation into postcopy-test

2017-10-05 Thread Alexey Perevalov
This patch just requests blocktime calculation, and check it in case when UFFD_FEATURE_THREAD_ID feature is set on the host. Signed-off-by: Alexey Perevalov --- tests/postcopy-test.c | 63 +++ 1 file changed, 48 insertions(+), 15 deletions(-) diff

[Qemu-devel] [Bug 1721275] Re: Support more ARM CPUs

2017-10-05 Thread Peter Maydell
M0 is hard, because it's v6M which we don't support. M4 we already have (but only the no-fpu variant). M7 we don't currently have -- what would be the differences from M4? M33 is in the works (it's v8M). M23 is harder, because it's v8M-baseline which is the v8M equivalent to v6M. A53 and A57 we alr

[Qemu-devel] [PATCH v11 6/6] migration: add postcopy total blocktime into query-migrate

2017-10-05 Thread Alexey Perevalov
Postcopy total blocktime is available on destination side only. But query-migrate was possible only for source. This patch adds ability to call query-migrate on destination. To be able to see postcopy blocktime, need to request postcopy-blocktime capability. The query-migrate command will show fol

[Qemu-devel] [Bug 1721275] Re: Support more ARM CPUs

2017-10-05 Thread Peter Maydell
PS: in general I wouldn't unconditionally trust that QEMU emulating CPU X definitely does not implement any instructions that CPU X doesn't have -- no real world code will notice, and we don't have any mechanism to automatically verify that we didn't accidentally forget to conditionalize an instruc

Re: [Qemu-devel] nbd structured reply

2017-10-05 Thread Vladimir Sementsov-Ogievskiy
21.09.2017 15:18, Vladimir Sementsov-Ogievskiy wrote: Hi all! I'm about this: "A server SHOULD try to minimize the number of chunks sent in a reply, but MUST NOT mark a chunk as final if there is still a possibility of detecting an error before transmission of that chunk completes" What do

Re: [Qemu-devel] [PATCH v2 0/4] blockjobs: add explicit job reaping

2017-10-05 Thread Kevin Wolf
Am 05.10.2017 um 03:46 hat John Snow geschrieben: > On 10/04/2017 02:27 PM, Kevin Wolf wrote: > > Am 04.10.2017 um 03:52 hat John Snow geschrieben: > >> For jobs that complete when a monitor isn't looking, there's no way to > >> tell what the job's final return code was. We need to allow jobs to >

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 0/5] virtio-iommu: VFIO integration

2017-10-05 Thread Auger Eric
Hi Linu, On 05/10/2017 12:46, Auger Eric wrote: > Hi Linu, > On 04/10/2017 13:49, Linu Cherian wrote: >> Hi Eric, >> >> >> On Wed Sep 27, 2017 at 11:24:01AM +0200, Auger Eric wrote: >>> Hi Linu, >>> >>> On 27/09/2017 11:21, Linu Cherian wrote: On Wed Sep 27, 2017 at 10:55:07AM +0200, Auger Eri

Re: [Qemu-devel] [PULL 0/6] Ui 20171005 patches

2017-10-05 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20171005100106.30118-1-kra...@redhat.com Subject: [Qemu-devel] [PULL 0/6] Ui 20171005 patches === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 0/5] virtio-iommu: VFIO integration

2017-10-05 Thread Auger Eric
Hi Linu, On 05/10/2017 13:54, Auger Eric wrote: > Hi Linu, > On 05/10/2017 12:46, Auger Eric wrote: >> Hi Linu, >> On 04/10/2017 13:49, Linu Cherian wrote: >>> Hi Eric, >>> >>> >>> On Wed Sep 27, 2017 at 11:24:01AM +0200, Auger Eric wrote: Hi Linu, On 27/09/2017 11:21, Linu Cherian

Re: [Qemu-devel] [PULL 0/5] Block patches

2017-10-05 Thread Peter Maydell
On 3 October 2017 at 20:12, Stefan Hajnoczi wrote: > The following changes since commit d147f7e815f97cb477e223586bcb80c316ae10ea: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2017-10-03 16:27:24 +0100) > > are available in the git repository at: > > git

Re: [Qemu-devel] nbd structured reply

2017-10-05 Thread Vladimir Sementsov-Ogievskiy
fix cc to n...@other.debian.org 05.10.2017 14:30, Vladimir Sementsov-Ogievskiy wrote: 21.09.2017 15:18, Vladimir Sementsov-Ogievskiy wrote: Hi all! I'm about this: "A server SHOULD try to minimize the number of chunks sent in a reply, but MUST NOT mark a chunk as final if there is still a p

[Qemu-devel] [PATCH v2 0/2] Check for the availability of a hotplug controller before adding a device

2017-10-05 Thread Thomas Huth
First patch is a small clean up to the error handling code in qdev_device_add(), and the second patch adds a proper check for the availability of a hotplug controller to prevent the possibility of a crash with device_del. Thomas Huth (2): qdev_monitor: Simplify error handling in qdev_device_add(

[Qemu-devel] [PATCH v2 2/2] qdev: Check for the availability of a hotplug controller before adding a device

2017-10-05 Thread Thomas Huth
The qdev_unplug() function contains a g_assert(hotplug_ctrl) statement, so QEMU crashes when the user tries to device_add + device_del a device that does not have a corresponding hotplug controller. This could be provoked for a couple of devices in the past (see commit 4c93950659487c7ad or 84ebd3e8

[Qemu-devel] [PATCH 1/2] qdev_monitor: Simplify error handling in qdev_device_add()

2017-10-05 Thread Thomas Huth
Instead of doing the clean-ups on errors multiple times, introduce a jump label at the end of the function that can be used by all error paths that need this cleanup. Suggested-by: Igor Mammedov Signed-off-by: Thomas Huth --- qdev-monitor.c | 21 ++--- 1 file changed, 10 inserti

Re: [Qemu-devel] [PATCH v4 2/2] vl: Deprecate auto-loading of qemu.conf

2017-10-05 Thread Eduardo Habkost
On Thu, Oct 05, 2017 at 07:00:33AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Wed, Oct 04, 2017 at 09:23:08AM -0300, Eduardo Habkost wrote: > >> On Wed, Oct 04, 2017 at 07:42:17AM +0200, Markus Armbruster wrote: > >> > Eduardo Habkost writes: > >> > > >> > > In case ther

[Qemu-devel] [PATCH v1][RFC] pci: Set PCI-bus device entry before initializing bus master

2017-10-05 Thread Pierre Morel
When initializing the PCI-bus master pci_init_bus_master(PCIDevice *) calls pci_device_iommu_address_space(PCIDevice *) which in turn calls iommu_bus->iommu_fn(bus, opaque,devfn) If the device entry of the PCI-bus is not initialized to point to the PCIDevice structure, the iommu_fn() function, get

[Qemu-devel] [PATCH v1] pci: Set PCI-bus device entry before initializing bus master

2017-10-05 Thread Pierre Morel
When initializing the PCI-bus master pci_init_bus_master(PCIDevice *) calls pci_device_iommu_address_space(PCIDevice *) which in turn calls iommu_bus->iommu_fn(bus, opaque,devfn) If the device entry of the PCI-bus is not initialized to point to the PCIDevice structure, the iommu_fn() function, get

Re: [Qemu-devel] [PATCH 17/38] sh4: r2d: use generic cpu_model parsing

2017-10-05 Thread Philippe Mathieu-Daudé
On 10/02/2017 06:07 AM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé > --- > CC: Magnus Damm > CC: Aurelien Jarno > --- > hw/sh4/r2d.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c > in

Re: [Qemu-devel] [PATCH v2 2/3] qom: introduce type_register_static_array()

2017-10-05 Thread Philippe Mathieu-Daudé
On 10/04/2017 07:08 AM, Igor Mammedov wrote: > it will help to remove code duplication of registration > static types in places that have open coded loop to > perform batch type registering. > > Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé > --- > include/qom/object.h | 10

Re: [Qemu-devel] [PATCH 19/38] sh4: cleanup cpu type name composition

2017-10-05 Thread Philippe Mathieu-Daudé
On 10/02/2017 06:08 AM, Igor Mammedov wrote: > introduce SUPERH_CPU_TYPE_NAME macro and use it to construct > cpu type names. While at it move cpu type_infos into one > array and register it directly with type_init_from_array() > instead of custom superh_cpu_register_types() > > Signed-off-by: Igo

Re: [Qemu-devel] [PATCH v2 3/3] qom: add helper macro DEFINE_TYPES()

2017-10-05 Thread Philippe Mathieu-Daudé
On 10/04/2017 07:08 AM, Igor Mammedov wrote: > DEFINE_TYPES() will help to simplify following routine patterns: > > static void foo_register_types(void) > { > type_register_static(&foo1_type_info); > type_register_static(&foo2_type_info); > ... > } > > type_init(foo_register_types

Re: [Qemu-devel] [PATCH 21/38] sh4: remove SuperHCPUClass::name field

2017-10-05 Thread Philippe Mathieu-Daudé
On 10/02/2017 06:08 AM, Igor Mammedov wrote: > the field contains upper-cased cpu model name and is used > for printing supported cpu model names for '-cpu help'. > > Considering that cpu model lookup in superh_cpu_class_by_name() > is case-insensitive, we can drop upper-casing when > printing sup

Re: [Qemu-devel] [PATCH v3] target/ppc: Fix carry flag setting for shift algebraic instructions

2017-10-05 Thread Richard Henderson
On 10/03/2017 02:23 AM, Sandipan Das wrote: > @@ -231,6 +231,10 @@ target_ulong helper_sraw(CPUPPCState *env, target_ulong > value, > ret = (int32_t)value >> 31; > env->ca = (ret != 0); > } > + > +/* update CA32 for ISA v3.0 */ > +env->ca32 = env->ca; As I said befo

[Qemu-devel] [PATCH] xen/pt: Mark TYPE_XEN_PT_DEVICE as hybrid

2017-10-05 Thread Eduardo Habkost
xen-pt doesn't set the is_express field, but is supposed to be able to handle PCI Express devices too. Mark it as hybrid. Suggested-by: Jan Beulich Signed-off-by: Eduardo Habkost --- hw/xen/xen_pt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index 01d

Re: [Qemu-devel] [PULL 3/5] hmp-commands-info: Fix "info rocker-FOO" misspellings

2017-10-05 Thread Paolo Bonzini
On 05/10/2017 12:51, Dr. David Alan Gilbert (git) wrote: > From: Markus Armbruster > > Screwed up in commit da76ee7. Let me introduce you to these two aliases: whatis = "show -s --pretty='tformat:%h (\"%s\", %cd)' --date=short" pwhatis = "show -s --pretty='tformat:%h, \"%s\", %c

Re: [Qemu-devel] [PATCH 18/38] sh4: shix: use generic cpu_model parsing

2017-10-05 Thread Philippe Mathieu-Daudé
Hi Igor, On 10/02/2017 06:08 AM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > CC: Magnus Damm > CC: Aurelien Jarno > --- > hw/sh4/shix.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/hw/sh4/shix.c b/hw/sh4/shix.c > index 50ee36a..4add230 100644

Re: [Qemu-devel] [PATCH] s390x/tcg: initialize machine check queue

2017-10-05 Thread Thomas Huth
On 04.10.2017 18:25, Cornelia Huck wrote: > Just as for external interrupts and I/O interrupts, we need to > initialize mchk_index during cpu reset. > > Signed-off-by: Cornelia Huck > --- > > Trying a device_add with a ccw device under tcg currently insta-crashes > qemu. Probably nobody ever tri

Re: [Qemu-devel] [PATCH] s390x/tcg: initialize machine check queue

2017-10-05 Thread Cornelia Huck
On Wed, 4 Oct 2017 18:25:43 +0200 Cornelia Huck wrote: > Just as for external interrupts and I/O interrupts, we need to > initialize mchk_index during cpu reset. > > Signed-off-by: Cornelia Huck > --- > > Trying a device_add with a ccw device under tcg currently insta-crashes > qemu. Probably

Re: [Qemu-devel] [PATCH] hw/s390x: Mark the "sclpquiesce" device with user_creatable = false

2017-10-05 Thread Cornelia Huck
On Thu, 5 Oct 2017 10:45:05 +0200 Thomas Huth wrote: > The "sclpquiesce" device is just an internal device that should not be > created by the user directly. Though it currently does not seem to cause > any obvious trouble when the user instantiates an additional device, let's > better mark it w

Re: [Qemu-devel] [PATCH 20/38] sh4: simplify superh_cpu_class_by_name()

2017-10-05 Thread Philippe Mathieu-Daudé
Hi Igor, On 10/02/2017 06:08 AM, Igor Mammedov wrote: > currently for sh4 cpu_model argument for '-cpu' option > could be either 'cpu model' name or cpu_typename. > > however typically '-cpu' takes 'cpu model' name and > cpu type for sh4 target isn't advertised publicly > ('-cpu help' prints only

Re: [Qemu-devel] [Qemu-arm] [PATCH 18/20] target/arm: Implement BLXNS

2017-10-05 Thread Philippe Mathieu-Daudé
On 09/22/2017 12:00 PM, Peter Maydell wrote: > Implement the BLXNS instruction, which allows secure code to > call non-secure code. > > Signed-off-by: Peter Maydell Acked-by: Philippe Mathieu-Daudé > --- > target/arm/helper.h| 1 + > target/arm/internals.h | 1 + > target/arm/helper.c

Re: [Qemu-devel] [Qemu-arm] [PATCH 19/20] target/arm: Implement secure function return

2017-10-05 Thread Philippe Mathieu-Daudé
On 09/22/2017 12:00 PM, Peter Maydell wrote: > Secure function return happens when a non-secure function has been > called using BLXNS and so has a particular magic LR value (either > 0xfefe or 0xfeff). The function return via BX behaves > specially when the new PC value is this magic value

Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: Add random ioctls

2017-10-05 Thread Marco A L Barbosa
I submitted a new patch. Thanks. On Thu, Oct 5, 2017 at 7:35 AM, Laurent Vivier wrote: > On 05/10/2017 12:24, Marco A L Barbosa wrote: > > I doesn't look really trivial... > > > > To manage the buf field you must read buf_size and it cannot be done > in > > a generic way: you must de

Re: [Qemu-devel] nbd structured reply

2017-10-05 Thread Eric Blake
On 10/05/2017 06:30 AM, Vladimir Sementsov-Ogievskiy wrote: > 21.09.2017 15:18, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> I'm about this: >> >> "A server SHOULD try to minimize the number of chunks sent in a reply, >> but MUST NOT mark a chunk as final if there is still a possibility of

Re: [Qemu-devel] [PULL 0/3] VFIO updates 2017-10-03

2017-10-05 Thread Peter Maydell
On 3 October 2017 at 23:12, Alex Williamson wrote: > The following changes since commit d147f7e815f97cb477e223586bcb80c316ae10ea: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2017-10-03 16:27:24 +0100) > > are available in the git repository at: > > > g

Re: [Qemu-devel] [PATCH 2/3] linux-user: Tidy and enforce reserved_va initialization

2017-10-05 Thread Richard Henderson
On 10/03/2017 12:24 PM, Peter Maydell wrote: > On 8 July 2017 at 03:50, Richard Henderson wrote: >> We had a check using TARGET_VIRT_ADDR_SPACE_BITS to make sure >> that the allocation coming in from the command-line option was >> not too large, but that didn't include target-specific knowledge >>

[Qemu-devel] [PATCH v2 02/40] qom: introduce type_register_static_array()

2017-10-05 Thread Igor Mammedov
it will help to remove code duplication of registration static types in places that have open coded loop to perform batch type registering. Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé --- include/qom/object.h | 10 ++ qom/object.c

[Qemu-devel] [PATCH v2 04/40] alpha: cleanup cpu type name composition

2017-10-05 Thread Igor Mammedov
Introduce ALPHA_CPU_TYPE_NAME macro to replace rather ununique TYPE macro that alpha uses. With new macro it will follow the same naming convention as other targets. While at it put scattered TypeInfo into one array which places type desriptions at one place and reduces code a bit. Signed-off-by:

[Qemu-devel] [PATCH v2 05/40] alpha: use generic cpu_model parsing

2017-10-05 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Acked-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- CC: r...@twiddle.net --- hw/alpha/dp264.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c index 1b12130..babd6ea 100644 --- a/hw/alpha/dp2

[Qemu-devel] [PATCH v2 03/40] qom: add helper macro DEFINE_TYPES()

2017-10-05 Thread Igor Mammedov
DEFINE_TYPES() will help to simplify following routine patterns: static void foo_register_types(void) { type_register_static(&foo1_type_info); type_register_static(&foo2_type_info); ... } type_init(foo_register_types) or static void foo_register_types(void) { int i; f

[Qemu-devel] [PATCH v2 08/40] lm32: cleanup cpu type name composition

2017-10-05 Thread Igor Mammedov
introduce LM32_CPU_TYPE_NAME macro and consistently use it to construct cpu type names. While at it replace dynamic cpu type name composition with static data. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael Walle --- v2: rename type_init_from_array into DEFI

[Qemu-devel] [PATCH v2 01/40] qom: update doc comment for type_register[_static]()

2017-10-05 Thread Igor Mammedov
type_register()/type_register_static() functions in current impl. can't fail returning 0, also none of the users check for error so update doc comment to reflect current behaviour. Suggested-by: Eduardo Habkost Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- include/qom/object.h

Re: [Qemu-devel] [PATCH v2 0/1] linux: Buffers/caches in VirtIO Balloon driver stats

2017-10-05 Thread Tomáš Golembiovský
On Thu, 21 Sep 2017 14:55:40 +0200 Tomáš Golembiovský wrote: > Linux driver part > > v2: > - fixed typos > > Tomáš Golembiovský (1): > virtio_balloon: include buffers and cached memory statistics > > drivers/virtio/virtio_balloon.c | 11 +++ > include/uapi/linux/virtio_balloon.h

[Qemu-devel] [PATCH v2 06/40] cris: cleanup cpu type name composition

2017-10-05 Thread Igor Mammedov
replace ambiguous TYPE macro with a new CRIS_CPU_TYPE_NAME and use it consistently in the code. Signed-off-by: Igor Mammedov --- v2: - rename type_init_from_array into DEFINE_TYPES - add & use DEFINE_CRIS_CPU_TYPE (Philippe Mathieu-Daudé ) CC: edgar.igles...@gmail.com --- target/cris/cpu.h

[Qemu-devel] [PATCH v2 07/40] cris: use generic cpu_model parsing

2017-10-05 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- CC: edgar.igles...@gmail.com --- hw/cris/axis_dev88.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/cris/axis_dev88.c b/hw/cris/axis_dev88.c index 5eb552b..9ccc435 100644 --- a/hw/cris/axis_dev88

[Qemu-devel] [PATCH v2 09/40] lm32: milkymist: use generic cpu_model parsing

2017-10-05 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael Walle --- CC: mich...@walle.cc --- hw/lm32/milkymist.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c index 4db4d2d..d4e765f 100644 --- a/hw/l

  1   2   3   4   >