Re: [Qemu-devel] [PATCHv2] macio: convert pmac_ide_ops from old_mmio

2017-09-20 Thread David Gibson
On Wed, Sep 20, 2017 at 07:28:27AM +0100, Mark Cave-Ayland wrote: > On 20/09/17 07:00, David Gibson wrote: > > > On Wed, Sep 20, 2017 at 06:56:37AM +0100, Mark Cave-Ayland wrote: > >> On 20/09/17 05:29, David Gibson wrote: > >> > >>> On Tue, Sep 19, 2017 at 09:02:54PM +0100, Mark Cave-Ayland wrote

[Qemu-devel] [PATCH v2 3/6] smbus: add a smbus_eeprom_init_one() routine

2017-09-20 Thread Cédric Le Goater
This is an helper routine to add a single EEPROM on an I2C bus. It can be directly used by smbus_eeprom_init() which adds a certain number of EEPROMs on mips and x86 machines. Signed-off-by: Cédric Le Goater --- hw/i2c/smbus_eeprom.c | 16 +++- include/hw/i2c/smbus.h | 1 + 2 files

[Qemu-devel] [PATCH v2 2/6] aspeed: add an I2C RTC device to all machines

2017-09-20 Thread Cédric Le Goater
The AST2500 EVB does not have an RTC but we can pretend that one is plugged on the I2C bus header. The romulus and witherspoon boards expects an Epson RX8900 I2C RTC but a ds1338 is good enough for the basic features we need. Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 19

[Qemu-devel] [PATCH v2 5/6] misc: add pca9552 LED blinker model

2017-09-20 Thread Cédric Le Goater
Specs are available here : https://www.nxp.com/docs/en/data-sheet/PCA9552.pdf This is a simple model supporting the basic registers for led and GPIO mode. The device also supports two blinking rates but not the model yet. Signed-off-by: Cédric Le Goater --- default-configs/arm-softmmu.mak |

[Qemu-devel] [PATCH v2 0/6] aspeed: add a witherspoon-bmc machine

2017-09-20 Thread Cédric Le Goater
Hello, This series adds a new Aspeed machine to emulate the BMC of a Witherspoon system. It also extends the other Aspeed machines with I2C devices and adds a simple model for the pca9552 LED blinker present on the witherspoon board. Thanks, C. Changes since v1: - introduced smbus_eeprom_init

[Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-09-20 Thread Cédric Le Goater
The Witherspoon boards are OpenPOWER system hosting POWER9 Processors. Let's add support for their BMC including a couple of I2C devices as found on real HW. Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 49 + 1 file changed, 49 insertions(

[Qemu-devel] [PATCH v2 4/6] aspeed: Add EEPROM I2C devices

2017-09-20 Thread Cédric Le Goater
The Aspeed boards have at least one EEPROM to hold the Vital Product Data (VPD). Signed-off-by: Cédric Le Goater --- Changes since v1: - fixed palmetto EEPROM size - used smbus_eeprom_init_one() hw/arm/aspeed.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/arm/aspeed.

[Qemu-devel] [PATCH v2 6/6] aspeed: add the pc9552 chips to the witherspoon machine

2017-09-20 Thread Cédric Le Goater
The pca9552 LED blinkers on the Witherspoon machine are used for leds but also as GPIOs to control fans and GPUs. Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 462f8008cff5..2ae46d71bff7 100644

Re: [Qemu-devel] RFC: Reducing the size of entries in the qcow2 L2 cache

2017-09-20 Thread Kevin Wolf
Am 19.09.2017 um 17:07 hat Alberto Garcia geschrieben: > Hi everyone, > > over the past few weeks I have been testing the effects of reducing > the size of the entries in the qcow2 L2 cache. This was briefly > mentioned by Denis in the same thread where we discussed subcluster > allocation back in

Re: [Qemu-devel] [PATCH v7 1/4] hw/pci: introduce pcie-pci-bridge device

2017-09-20 Thread Marcel Apfelbaum
On 19/09/2017 23:34, Eduardo Habkost wrote: On Fri, Aug 18, 2017 at 02:36:47AM +0300, Aleksandr Bezzubikov wrote: Introduce a new PCIExpress-to-PCI Bridge device, which is a hot-pluggable PCI Express device and supports devices hot-plug with SHPC. This device is intended to replace the DMI-to-P

Re: [Qemu-devel] [PATCH 00/12] Patch Round-up for stable 2.10.1, freeze on 2017-09-27

2017-09-20 Thread Thomas Huth
On 20.09.2017 02:45, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v2.10.1: > > https://github.com/mdroth/qemu/commits/stable-2.10-staging > > The release is planned for 2017-10-02: > > https://wiki.qemu.org/Planning/2.10 > > Please respond her

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

2017-09-20 Thread Nikunj A Dadhania
David Gibson writes: > On Wed, Sep 20, 2017 at 12:10:48PM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Wed, Sep 20, 2017 at 10:43:19AM +0530, Nikunj A Dadhania wrote: >> >> David Gibson writes: >> >> >> >> > On Wed, Sep 20, 2017 at 09:50:24AM +0530, Nikunj A Dadhania wro

Re: [Qemu-devel] [PULL v2 00/38] various s390x patches (+some fixes)

2017-09-20 Thread Cornelia Huck
On Tue, 19 Sep 2017 19:03:13 +0200 Christian Borntraeger wrote: > On 09/19/2017 06:42 PM, Cornelia Huck wrote: > > The following changes since commit 7ec6a364916c0d1eba01128481e503a550a2b466: > > > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > > staging (2017-09-19

Re: [Qemu-devel] [PATCH v3 5/5] s390x/css: support ccw IDA

2017-09-20 Thread Dong Jia Shi
* Halil Pasic [2017-09-19 20:27:45 +0200]: > Let's add indirect data addressing support for our virtual channel > subsystem. This implementation does not bother with any kind of > prefetching. We simply step through the IDAL on demand. > > Signed-off-by: Halil Pasic > Signed-off-by: Cornelia Hu

Re: [Qemu-devel] [PATCH 2/2] hw/pcie: disable IO port fwd by default for pcie-root-port

2017-09-20 Thread Marcel Apfelbaum
Hi Laszlo, On 20/09/2017 1:15, Laszlo Ersek wrote: Hi Marcel, On 09/06/17 16:26, Marcel Apfelbaum wrote: For most cases the devices attached to PCIe Root Ports do not need IO ports range, add an 'enable-io-fwd' property making it false by default, but keeping it true for older machines. Signe

Re: [Qemu-devel] [PATCH] net: Mark the 'hubport' netdev as deprecated

2017-09-20 Thread Thomas Huth
On 24.05.2017 10:04, Thomas Huth wrote: > The 'hubport' netdev is closely tied to the 'vlan' concept which > has been marked as deprecated in commit a2dbe1356faff3cb6 already. > Thus we should also mark the hubport netdevs as deprecated to make > the remaining users aware that they should not use t

Re: [Qemu-devel] [PATCH v3 4/5] 390x/css: introduce maximum data address checking

2017-09-20 Thread Dong Jia Shi
* Halil Pasic [2017-09-19 20:27:44 +0200]: > The architecture mandates the addresses to be accessed on the first > indirection level (that is, the data addresses without IDA, and the > (M)IDAW addresses with (M)IDA) to be checked against an CCW format > dependent limit maximum address. If a vio

Re: [Qemu-devel] [RFC PATCH] qdev: Mark devices as non-hotpluggable by default

2017-09-20 Thread Marcel Apfelbaum
Hi Thomas, On 19/09/2017 11:55, Thomas Huth wrote: Historically we've marked all devices as hotpluggable by default. However, most devices are not hotpluggable, and you also need a HotplugHandler to support these devices. So if the user tries to "device_add" or "device_del" such a non-hotpluggab

Re: [Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

2017-09-20 Thread Daniel P. Berrange
On Thu, Sep 14, 2017 at 03:50:22PM +0800, Peter Xu wrote: > This is not a problem if we are only having one single loop thread like > before. However, after per-monitor thread is introduced, this is not > true any more, and the race can happen. > > The race can be triggered with "make check -j8"

Re: [Qemu-devel] [PATCH v3 3/5] virtio-ccw: use ccw data stream

2017-09-20 Thread Cornelia Huck
On Tue, 19 Sep 2017 20:27:43 +0200 Halil Pasic wrote: > Replace direct access which implicitly assumes no IDA > or MIDA with the new ccw data stream interface which should > cope with these transparently in the future. > > Signed-off-by: Halil Pasic > Reviewed-by: Pierre Morel > --- > hw/s390x

Re: [Qemu-devel] [PATCH] throttle-groups: update tg->any_timer_armed[] on detach

2017-09-20 Thread Alberto Garcia
On Tue 19 Sep 2017 05:50:25 PM CEST, Stefan Hajnoczi wrote: > Clear tg->any_timer_armed[] when throttling timers are destroy during > AioContext attach/detach. Failure to do so causes throttling to hang > because we believe the timer is already scheduled! > > The following was broken at least sinc

Re: [Qemu-devel] [PATCH v3 4/5] 390x/css: introduce maximum data address checking

2017-09-20 Thread Cornelia Huck
On Tue, 19 Sep 2017 20:27:44 +0200 Halil Pasic wrote: > The architecture mandates the addresses to be accessed on the first > indirection level (that is, the data addresses without IDA, and the > (M)IDAW addresses with (M)IDA) to be checked against an CCW format > dependent limit maximum address

Re: [Qemu-devel] [PATCH v3 5/5] s390x/css: support ccw IDA

2017-09-20 Thread Cornelia Huck
On Tue, 19 Sep 2017 20:27:45 +0200 Halil Pasic wrote: > Let's add indirect data addressing support for our virtual channel > subsystem. This implementation does not bother with any kind of > prefetching. We simply step through the IDAL on demand. > > Signed-off-by: Halil Pasic > Signed-off-by:

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

2017-09-20 Thread Cédric Le Goater
On 09/20/2017 09:18 AM, Nikunj A Dadhania wrote: > David Gibson writes: > >> On Wed, Sep 20, 2017 at 12:10:48PM +0530, Nikunj A Dadhania wrote: >>> David Gibson writes: >>> On Wed, Sep 20, 2017 at 10:43:19AM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > >> On Wed, Se

Re: [Qemu-devel] qmeu-arm SIGSEGV for self-modifying code

2017-09-20 Thread Peter Maydell
On 20 September 2017 at 11:21, Peter Maydell wrote: > On 20 September 2017 at 00:13, John Reiser wrote: >> [Moving here from https://bugzilla.redhat.com/show_bug.cgi?id=1493304 ] >> >> qemu-arm from qemu-user-2.10.0-1.fc27.x86_64 (thus emulating 32-bit ARM on >> x86_64) >> generates SIGSEGV when

Re: [Qemu-devel] [RFC PATCH v2 07/21] ppc/xive: add MMIO handlers for the XIVE interrupt sources

2017-09-20 Thread Cédric Le Goater
On 09/19/2017 04:57 AM, David Gibson wrote: > On Mon, Sep 11, 2017 at 07:12:21PM +0200, Cédric Le Goater wrote: >> Each interrupt source is associated with a two bit state machine >> called an Event State Buffer (ESB) which is controlled by MMIO to >> trigger events. See code for more details on th

Re: [Qemu-devel] [RFC PATCH v2 07/21] ppc/xive: add MMIO handlers for the XIVE interrupt sources

2017-09-20 Thread Cédric Le Goater
>> +/* >> + * XIVE Interrupt Source MMIOs >> + */ >> +static uint64_t spapr_xive_esb_read(void *opaque, hwaddr addr, unsigned >> size) >> +{ >> +sPAPRXive *xive = SPAPR_XIVE(opaque); >> +uint32_t offset = addr & 0xF00; >> +uint32_t srcno = addr >> xive->esb_shift; >> +XiveIVE *ive

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

2017-09-20 Thread David Gibson
On Wed, Sep 20, 2017 at 12:48:55PM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > On Wed, Sep 20, 2017 at 12:10:48PM +0530, Nikunj A Dadhania wrote: > >> David Gibson writes: > >> > >> > On Wed, Sep 20, 2017 at 10:43:19AM +0530, Nikunj A Dadhania wrote: > >> >> David Gibson write

Re: [Qemu-devel] [RFC PATCH v2 00/21] Guest exploitation of the XIVE interrupt controller (POWER9)

2017-09-20 Thread Cédric Le Goater
On 09/19/2017 10:46 AM, David Gibson wrote: > On Tue, Sep 19, 2017 at 06:20:20PM +1000, David Gibson wrote: >> On Mon, Sep 11, 2017 at 07:12:14PM +0200, Cédric Le Goater wrote: >>> On a POWER9 sPAPR machine, the Client Architecture Support (CAS) >>> negotiation process determines whether the guest

Re: [Qemu-devel] [PATCH v3 4/5] 390x/css: introduce maximum data address checking

2017-09-20 Thread Cornelia Huck
On Wed, 20 Sep 2017 15:47:51 +0800 Dong Jia Shi wrote: > * Halil Pasic [2017-09-19 20:27:44 +0200]: > > @@ -828,7 +836,9 @@ void ccw_dstream_init(CcwDataStream *cds, CCW1 const > > *ccw, ORB const *orb) > > g_assert(!(orb->ctrl1 & ORB_CTRL1_MASK_MIDAW)); > > cds->flags = (orb->ctrl0

[Qemu-devel] [PULL 02/16] migration: Teach it about G_SOURCE_REMOVE

2017-09-20 Thread Juan Quintela
As this is defined on glib 2.32, add compatibility macros for older glibs. Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrange Reviewed-by: Peter Xu --- include/glib-compat.h | 2 ++ migration/exec.c | 2 +- migration/fd.c| 2 +- migration/socket.c| 2 +- 4 files chan

Re: [Qemu-devel] [RFC v2 02/33] bitmap: introduce bitmap_count_one()

2017-09-20 Thread Juan Quintela
Peter Xu wrote: > Count how many bits set in the bitmap. > > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v2] softfloat: rename make_float[x80|128]_init to const_float[x80|128]

2017-09-20 Thread Richard Henderson
On 09/19/2017 04:18 PM, Eric Blake wrote: > On 09/19/2017 04:10 PM, Laurent Vivier wrote: >> We already have const_float16(), const_float32() and const_float64(), >> so rename make_floatx80_init() and make_float128_init() as > > s/as/to now be/ > >> const_floatx80() and const_float128(). > > s/\

[Qemu-devel] [PULL 04/16] migration: Create migration_has_all_channels

2017-09-20 Thread Juan Quintela
This function allows us to decide when to close the listener socket. For now, we only need one connection. Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrange --- migration/migration.c | 11 +++ migration/migration.h | 2 ++ migration/socket.c| 10 +++--- 3 files chang

Re: [Qemu-devel] [PATCH v2 4/8] disas: Support the Capstone disassembler library

2017-09-20 Thread Richard Henderson
On 09/20/2017 06:17 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> If configured, prefer this over our rather dated copy of the >> GPLv2-only binutils. This will be especially apparent with >> the proposed vector extensions to TCG, as disas/i386.c does >> not handle AVX. >> >> Signed

Re: [Qemu-devel] [PATCH v2 4/8] disas: Support the Capstone disassembler library

2017-09-20 Thread Alex Bennée
Richard Henderson writes: > If configured, prefer this over our rather dated copy of the > GPLv2-only binutils. This will be especially apparent with > the proposed vector extensions to TCG, as disas/i386.c does > not handle AVX. > > Signed-off-by: Richard Henderson Hmm I get a link failure:

Re: [Qemu-devel] [PATCH v10 01/13] gitignore: Ignore vm test images

2017-09-20 Thread Eric Blake
On 09/19/2017 10:25 PM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > .gitignore | 1 + > tests/.gitignore | 1 + > 2 files changed, 2 insertions(+) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.

[Qemu-devel] [PULL 12/16] bitmap: provide to_le/from_le helpers

2017-09-20 Thread Juan Quintela
From: Peter Xu Provide helpers to convert bitmaps to little endian format. It can be used when we want to send one bitmap via network to some other hosts. One thing to mention is that, these helpers only solve the problem of endianess, but it does not solve the problem of different word size on

Re: [Qemu-devel] [PATCH v9 05/20] dirty-bitmap: Avoid size query failure during truncate

2017-09-20 Thread Eric Blake
On 09/19/2017 09:10 PM, Fam Zheng wrote: >> >> Do you suspect that almost certainly if bdrv_truncate() fails overall >> that the image format driver will either unmount the image or become >> read-only? Uggh - it feels like I've bitten off more than I can chew with this patch - I'm getting bogged

[Qemu-devel] [PULL 09/16] migration: Split migration_fd_process_incoming

2017-09-20 Thread Juan Quintela
We need that on later patches. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Reviewed-by: Daniel P. Berrange --- migration/migration.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/migration/migration.c b/migration

[Qemu-devel] [PULL 13/16] migration: pass MigrationIncomingState* into migration check functions

2017-09-20 Thread Juan Quintela
From: Alexey Perevalov That tiny refactoring is necessary to be able to set UFFD_FEATURE_THREAD_ID while requesting features, and then to create downtime context in case when kernel supports it. Signed-off-by: Alexey Perevalov Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migra

Re: [Qemu-devel] [PATCH] net: Mark the 'hubport' netdev as deprecated

2017-09-20 Thread Thomas Huth
On 20.09.2017 13:07, Paolo Bonzini wrote: > On 20/09/2017 09:45, Thomas Huth wrote: >> On 24.05.2017 10:04, Thomas Huth wrote: >>> The 'hubport' netdev is closely tied to the 'vlan' concept which >>> has been marked as deprecated in commit a2dbe1356faff3cb6 already. >>> Thus we should also mark the

[Qemu-devel] [PULL 00/16] Migration PULL request

2017-09-20 Thread Juan Quintela
-tracking branch 'remotes/cohuck/tags/s390x-20170919-v2' into staging (2017-09-19 18:08:48 +0100) are available in the git repository at: git://github.com/juanquintela/qemu.git tags/migration/20170920 for you to fetch changes up to bfaf91242bd9dc168ccd8e7919c604757b410d3d:

[Qemu-devel] [PULL 10/16] bitmap: remove BITOP_WORD()

2017-09-20 Thread Juan Quintela
From: Peter Xu We have BIT_WORD(). It's the same. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- util/bitops.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/util/bitops.c b/util/bitops.c index b0c35dd5f1..f2364015c4 100644 ---

[Qemu-devel] [PULL 06/16] migration: Create x-multifd-channels parameter

2017-09-20 Thread Juan Quintela
Indicates the number of channels that we will create. By default we create 2 channels. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Catch inconsistent defaults (eric). Improve comment stating that number of threads is the same than number of socke

[Qemu-devel] [PULL 08/16] migration: Create multifd migration threads

2017-09-20 Thread Juan Quintela
Creation of the threads, nothing inside yet. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert -- Use pointers instead of long array names Move to use semaphores instead of conditions as paolo suggestion Put all the state inside one struct. Use a counter for the number of threa

Re: [Qemu-devel] [RFC PATCH v2 13/21] ppc/xive: handle interrupt acknowledgment by the O/S

2017-09-20 Thread Cédric Le Goater
On 09/19/2017 09:53 AM, David Gibson wrote: > On Mon, Sep 11, 2017 at 07:12:27PM +0200, Cédric Le Goater wrote: >> When an O/S Exception is raised, the O/S acknowledges the interrupt >> with a special read in the TIMA. If the EO bit of the Notification >> Source Register (NSR) is set (and it should

[Qemu-devel] kvm_set_phys_mem: assertion failed

2017-09-20 Thread Gerd Hoffmann
Hi, git master crashes: ERROR:/home/kraxel/projects/qemu/accel/kvm/kvm- all.c:756:kvm_set_phys_mem: assertion failed: (!memory_region_is_ram(mr) && !writeable && !mr->romd_mode) bisect blames: commit f357f564be0bd45245b3ccfbbe20ace08fe83ca8 Author: David Hildenbrand Date:   Mon Sep 11 19:49:

[Qemu-devel] [PULL 01/16] migration: Create migration_ioc_process_incoming()

2017-09-20 Thread Juan Quintela
We pass the ioc instead of the fd. This will allow us to have more than one channel open. We also make sure that we set the from_src_file sooner, so we don't need to pass it as a parameter. Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrange -- Do not assing mis->from_src_file (pete

Re: [Qemu-devel] [PATCH 2/2] block/block-backend.c: remove blk_pread_unthrottled()

2017-09-20 Thread Kevin Wolf
Am 20.09.2017 um 13:43 hat Manos Pitsidianakis geschrieben: > blk_pread_unthrottled was used to bypass I/O throttling on the BlockBackend in > the case of async I/O. This is not needed anymore and we can just call > blk_pread() directly. > > Signed-off-by: Manos Pitsidianakis We already did a re

[Qemu-devel] [PULL 03/16] migration: Add comments to channel functions

2017-09-20 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrange --- migration/channel.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/migration/channel.c b/migration/channel.c index edceebdb7b..70ec7ea3b7 100644 --- a/migration/channel.c +++ b/migration/channel.c @@ -19,6 +19

[Qemu-devel] [PATCH] seccomp: Don't include libseccomp from QEMU header

2017-09-20 Thread Fam Zheng
The only prototype doesn't need anything from the lib header, and not including it here allows files that include this header, for example vl.c, to compile without the libseccomp cflags. The breakage is since c3883e1f93 for environments where `pkg-config --cflags libseccomp" is non-empty. Reporte

[Qemu-devel] [PULL 14/16] migration: fix hardcoded function name in error report

2017-09-20 Thread Juan Quintela
From: Alexey Perevalov Reviewed-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alexey Perevalov Signed-off-by: Juan Quintela --- migration/postcopy-ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/postcopy-ram.c b/migration/postcopy-ra

[Qemu-devel] [PATCH] tests: Move postcopy migration test to migrate-set-parameters

2017-09-20 Thread Juan Quintela
migrate_set_speed and migrate_set_dowtime are deprecated since long ago. Signed-off-by: Juan Quintela --- tests/postcopy-test.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c index 8142f2ab90..991b954a83 100644 --- a/test

[Qemu-devel] [PULL 05/16] migration: Add multifd capability

2017-09-20 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Reviewed-by: Daniel P. Berrange -- Use new DEFINE_PROP --- migration/migration.c | 10 ++ migration/migration.h | 1 + qapi/migration.json | 4 +++- 3 files changed, 14 insertions(+), 1 deletio

Re: [Qemu-devel] [PATCH 5/5] migration: Route more error paths

2017-09-20 Thread Eric Blake
On 09/19/2017 10:55 PM, Fam Zheng wrote: > On Tue, 09/19 19:00, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" >> >> vmstate_save is called in a few places, and vmstate_save_state is >> called in lots of places. >> >> Route error returns from the easier cases back up; there

Re: [Qemu-devel] block ais migration for machines <= 2.9

2017-09-20 Thread Cornelia Huck
On Wed, 20 Sep 2017 14:53:07 +0200 Christian Borntraeger wrote: > Something like the following seems to do the tricks. > Needs proper patch description, review, full test with different kernel > versions. Looks sane. Will you handle it? > > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s3

[Qemu-devel] [PULL 07/16] migration: Create x-multifd-page-count parameter

2017-09-20 Thread Juan Quintela
Indicates how many pages we are going to send in each batch to a multifd thread. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Be consistent with defaults and documentation Use new DEFINE_PROP_* Rename x-multifd-group to x-multifd-page-count --- hm

[Qemu-devel] [PATCH v3 2/3] block/nbd-client: simplify check in nbd_co_receive_reply

2017-09-20 Thread Vladimir Sementsov-Ogievskiy
If we are woken up from while() loop in nbd_read_reply_entry handles must be equal. If we are woken up from nbd_recv_coroutines_wake_all s->quit must be true, so we do not need checking handles equality. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd-client.c | 3 ++- 1 file changed,

Re: [Qemu-devel] qmeu-arm SIGSEGV for self-modifying code

2017-09-20 Thread Peter Maydell
On 20 September 2017 at 00:13, John Reiser wrote: > [Moving here from https://bugzilla.redhat.com/show_bug.cgi?id=1493304 ] > > qemu-arm from qemu-user-2.10.0-1.fc27.x86_64 (thus emulating 32-bit ARM on > x86_64) > generates SIGSEGV when code modifies a never-previously executed instruction > tha

[Qemu-devel] [PULL 16/16] migration: introduce postcopy-blocktime capability

2017-09-20 Thread Juan Quintela
From: Alexey Perevalov Right now it could be used on destination side to enable vCPU blocktime calculation for postcopy live migration. vCPU blocktime - it's time since vCPU thread was put into interruptible sleep, till memory page was copied and thread awake. Reviewed-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

2017-09-20 Thread Peter Xu
On Wed, Sep 20, 2017 at 10:14:38AM +0100, Daniel P. Berrange wrote: > On Wed, Sep 20, 2017 at 05:09:26PM +0800, Peter Xu wrote: > > On Wed, Sep 20, 2017 at 08:57:03AM +0100, Daniel P. Berrange wrote: > > > On Thu, Sep 14, 2017 at 03:50:22PM +0800, Peter Xu wrote: > > > > This is not a problem if we

[Qemu-devel] need to resurrect no-lock option?

2017-09-20 Thread Christian Ehrhardt
Hi, this might have been discussed in the wake of the lock changes that took place in 2.10 but I can't find anything clear enough to follow in the current case. There was an old submission [1] by Fam to make it possible to no-lock qemu-img and others if needed. But it seems nothing like it made it

[Qemu-devel] [PULL 11/16] bitmap: introduce bitmap_count_one()

2017-09-20 Thread Juan Quintela
From: Peter Xu Count how many bits set in the bitmap. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- include/qemu/bitmap.h | 10 ++ util/bitmap.c | 15 +++ 2 files changed, 25 insertions(+)

[Qemu-devel] [PULL 15/16] migration: split ufd_version_check onto receive/request features part

2017-09-20 Thread Juan Quintela
From: Alexey Perevalov This modification is necessary for userfault fd features which are required to be requested from userspace. UFFD_FEATURE_THREAD_ID is a one of such "on demand" feature, which will be introduced in the next patch. QEMU have to use separate userfault file descriptor, due to

Re: [Qemu-devel] [RFC PATCH v2 16/21] spapr: add a XIVE object to the sPAPR machine

2017-09-20 Thread Cédric Le Goater
On 09/19/2017 10:38 AM, David Gibson wrote: > On Mon, Sep 11, 2017 at 07:12:30PM +0200, Cédric Le Goater wrote: >> If the machine supports XIVE (POWER9 CPU), create a XIVE object. The >> CAS negotiation process will decide which model (legacy or XIVE) will >> be used for the interrupt controller de

[Qemu-devel] [PATCH v3] softfloat: rename make_float[x80|128]_init to const_float[x80|128]

2017-09-20 Thread Laurent Vivier
We already have const_float16(), const_float32() and const_float64(), so rename make_floatx80_init() and make_float128_init() to now be const_floatx80() and const_float128(), for consistency. Redefine make_float16(), make_float32() and make_float64() to be like make_floatx80() and make_float128(),

Re: [Qemu-devel] [PATCH v3 4/5] 390x/css: introduce maximum data address checking

2017-09-20 Thread Halil Pasic
On 09/20/2017 10:06 AM, Cornelia Huck wrote: > On Tue, 19 Sep 2017 20:27:44 +0200 > Halil Pasic wrote: > >> The architecture mandates the addresses to be accessed on the first >> indirection level (that is, the data addresses without IDA, and the >> (M)IDAW addresses with (M)IDA) to be checked

Re: [Qemu-devel] [PATCH v3 03/20] file-posix: Switch to .bdrv_co_block_status()

2017-09-20 Thread Fam Zheng
On Thu, 09/14 09:40, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. Update the file protocol driver accordingly. In mapping > mode, note that the entire file is reported as allocated, so we can > take a shortcut and skip lseek(). > > Signed-o

Re: [Qemu-devel] [PATCH] arm: Fix SMC reporting to EL2 when QEMU provides PSCI

2017-09-20 Thread Jan Kiszka
On 2017-09-18 09:51, Jan Kiszka wrote: > From: Jan Kiszka > > This properly forwards SMC events to EL2 when PSCI is provided by QEMU > itself and, thus, ARM_FEATURE_EL3 is off. > > Found and tested with the Jailhouse hypervisor. > > Signed-off-by: Jan Kiszka > --- > target/arm/helper.c| 2

Re: [Qemu-devel] [PATCH 3/3] linux-user: add SO_LINGER to getsockopt

2017-09-20 Thread Laurent Vivier
Le 20/09/2017 à 01:06, Carlo Marcelo Arenas Belón a écrit : > Signed-off-by: Carlo Marcelo Arenas Belón > --- > linux-user/syscall.c | 34 +- > 1 file changed, 33 insertions(+), 1 deletion(-) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index ad6

Re: [Qemu-devel] [RFC v2 06/33] migration: reuse mis->userfault_quit_fd

2017-09-20 Thread Juan Quintela
Peter Xu wrote: > It was only used for quitting the page fault thread before. Let it be > something more useful - now we can use it to notify a "wake" for the > page fault thread (for any reason), and it only means "quit" if the > fault_thread_quit is set. > > Since we changed what it does, renami

Re: [Qemu-devel] [PATCH v3 5/5] s390x/css: support ccw IDA

2017-09-20 Thread Cornelia Huck
On Wed, 20 Sep 2017 15:42:38 +0800 Dong Jia Shi wrote: > * Halil Pasic [2017-09-19 20:27:45 +0200]: > > > Let's add indirect data addressing support for our virtual channel > > subsystem. This implementation does not bother with any kind of > > prefetching. We simply step through the IDAL on de

[Qemu-devel] [PATCH 1/3] block: add bdrv_co_drain_end callback

2017-09-20 Thread Manos Pitsidianakis
BlockDriverState has a bdrv_do_drain() callback but no equivalent for the end of the drain. The throttle driver (block/throttle.c) needs a way to mark the end of the drain in order to toggle io_limits_disabled correctly, thus bdrv_co_drain_end is needed. Signed-off-by: Manos Pitsidianakis --- in

Re: [Qemu-devel] [PATCH v3 3/5] virtio-ccw: use ccw data stream

2017-09-20 Thread Cornelia Huck
On Wed, 20 Sep 2017 12:56:16 +0200 Halil Pasic wrote: > On 09/20/2017 09:58 AM, Cornelia Huck wrote: > > On Tue, 19 Sep 2017 20:27:43 +0200 > > Halil Pasic wrote: > > > >> Replace direct access which implicitly assumes no IDA > >> or MIDA with the new ccw data stream interface which should >

Re: [Qemu-devel] [PATCH v2 3/3] s390x/tcg: add basic MSA features

2017-09-20 Thread Richard Henderson
On 09/19/2017 02:36 PM, David Hildenbrand wrote: > On 19.09.2017 19:47, Richard Henderson wrote: >> On 09/19/2017 09:26 AM, David Hildenbrand wrote: >>> +const uint8_t fc = env->regs[0] & 0x7fULL; >> >> Don't mask here... > > Bit 56 is the mod bit (see variable "mod") and is checked inside the

[Qemu-devel] [PATCH 1/2] block/block-backend.c: add blk_check_byte_request call to blk_pread/blk_pwrite

2017-09-20 Thread Manos Pitsidianakis
blk_check_byte_request() is called from the blk_co_pwritev/blk_co_preadv to check if the request offset and request bytes parameters are valid for the given Blockbackend. Let's do that in blk_pread/blk_pwrite too. Signed-off-by: Manos Pitsidianakis --- block/block-backend.c | 11 ++- 1 f

Re: [Qemu-devel] need to resurrect no-lock option?

2017-09-20 Thread Fam Zheng
On Wed, 09/20 11:26, Christian Ehrhardt wrote: > Hi, > this might have been discussed in the wake of the lock changes that took > place in 2.10 but I can't find anything clear enough to follow in the > current case. > There was an old submission [1] by Fam to make it possible to no-lock > qemu-img

Re: [Qemu-devel] [Qemu-arm] [PATCH] target/arm: Remove out of date ARM ARM section references in A64 decoder

2017-09-20 Thread Alex Bennée
Alistair Francis writes: > On Fri, Sep 15, 2017 at 8:08 AM, Peter Maydell > wrote: >> In the A64 decoder, we have a lot of references to section numbers >> from version A.a of the v8A ARM ARM (DDI0487). This version of the >> document is now long obsolete (we are currently on revision B.a), >>

Re: [Qemu-devel] [RFC PATCH] qdev: Mark devices as non-hotpluggable by default

2017-09-20 Thread Marcel Apfelbaum
On 20/09/2017 13:07, Peter Maydell wrote: On 20 September 2017 at 08:50, Marcel Apfelbaum wrote: Hi Thomas, On 19/09/2017 11:55, Thomas Huth wrote: Historically we've marked all devices as hotpluggable by default. However, most devices are not hotpluggable, and you also need a HotplugHandle

[Qemu-devel] [PATCH 2/3] block: rename bdrv_co_drain to bdrv_co_drain_begin

2017-09-20 Thread Manos Pitsidianakis
Signed-off-by: Manos Pitsidianakis --- include/block/block_int.h | 2 +- block/io.c| 4 ++-- block/qed.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/block/block_int.h b/include/block/block_int.h index ea1326e3c7..fd10f53b43 1006

[Qemu-devel] [PATCH v3 0/3] nbd client refactoring and fixing

2017-09-20 Thread Vladimir Sementsov-Ogievskiy
v3: dropped all controversial things. I'll try to implement minimal structured reply and block status over this small residue. Vladimir Sementsov-Ogievskiy (3): block/nbd-client: refactor nbd_co_receive_reply block/nbd-client: simplify check in nbd_co_receive_reply block/nbd-client: nbd_co_s

Re: [Qemu-devel] [RFC PATCH v2 14/21] ppc/xive: add support for the SET_OS_PENDING command

2017-09-20 Thread Cédric Le Goater
On 09/19/2017 09:55 AM, David Gibson wrote: > On Mon, Sep 11, 2017 at 07:12:28PM +0200, Cédric Le Goater wrote: >> Adjusting the Interrupt Pending Buffer for the O/S would allow a CPU >> to process event queues of other priorities during one physical >> interrupt cycle. This is not currently used b

Re: [Qemu-devel] [RFC PATCH v2 15/21] spapr: modify spapr_populate_pci_dt() to use a 'nr_irqs' argument

2017-09-20 Thread Cédric Le Goater
On 09/19/2017 09:56 AM, David Gibson wrote: > On Mon, Sep 11, 2017 at 07:12:29PM +0200, Cédric Le Goater wrote: >> This adds some flexibility in the definition of the number of >> available IRQS used in a sPAPR machine. >> >> Signed-off-by: Cédric Le Goater > > This doesn't seem sensible. You've

Re: [Qemu-devel] [PATCH 7/8] openpic: add missing timer fields to vmstate_openpic_timer

2017-09-20 Thread David Gibson
On Tue, Sep 19, 2017 at 08:50:49PM +0100, Mark Cave-Ayland wrote: > On 18/09/17 23:44, David Gibson wrote: > > > So, adding new things to the migration stream always requires some > > thought. The commit message should contain a rationale for why the > > proposed representation is a good one. In

Re: [Qemu-devel] [PATCH 2/2] hw/pcie: disable IO port fwd by default for pcie-root-port

2017-09-20 Thread Laszlo Ersek
On 09/20/17 09:42, Marcel Apfelbaum wrote: > On 20/09/2017 1:15, Laszlo Ersek wrote: >> It seems that we now have "grp->io_reserve" (a numeric quantity, not a >> boolean), from property "io-reserve". The default value is -1. >> >> According to the documentation added in c1800a162765 ("docs: update

Re: [Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

2017-09-20 Thread Daniel P. Berrange
On Wed, Sep 20, 2017 at 06:49:58PM +0800, Peter Xu wrote: > On Wed, Sep 20, 2017 at 10:14:38AM +0100, Daniel P. Berrange wrote: > > On Wed, Sep 20, 2017 at 05:09:26PM +0800, Peter Xu wrote: > > > On Wed, Sep 20, 2017 at 08:57:03AM +0100, Daniel P. Berrange wrote: > > > > On Thu, Sep 14, 2017 at 03:

[Qemu-devel] [PATCH v3 1/3] block/nbd-client: refactor nbd_co_receive_reply

2017-09-20 Thread Vladimir Sementsov-Ogievskiy
"NBDReply *reply" parameter of nbd_co_receive_reply is used only to pass return value for nbd_co_request (reply.error). Remove it and use function return value instead. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/nbd-client.c | 30 +++---

[Qemu-devel] [PATCH v3 3/3] block/nbd-client: nbd_co_send_request: fix return code

2017-09-20 Thread Vladimir Sementsov-Ogievskiy
It's incorrect to return success rc >= 0 if we skip qio_channel_writev_all() call due to s->quit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd-client.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/nbd-client.c b/block/nbd-client.c index 486bfff9f7..9d1e154feb 100644 -

Re: [Qemu-devel] [PATCH v9 06/13] tests: Add ubuntu.i386 image

2017-09-20 Thread Alex Bennée
Fam Zheng writes: > On Tue, 09/19 16:12, Alex Bennée wrote: >> Could we also do something about locales in this setup. The build gives >> a lot of noise like: >> >> perl: warning: Falling back to a fallback locale ("en_US.UTF-8"). >> perl: warning: Setting locale failed. >> perl: war

Re: [Qemu-devel] [PATCH v7 1/4] hw/pci: introduce pcie-pci-bridge device

2017-09-20 Thread Aleksandr Bezzubikov
ср, 20 сент. 2017 г. в 10:13, Marcel Apfelbaum : > On 19/09/2017 23:34, Eduardo Habkost wrote: > > On Fri, Aug 18, 2017 at 02:36:47AM +0300, Aleksandr Bezzubikov wrote: > >> Introduce a new PCIExpress-to-PCI Bridge device, > >> which is a hot-pluggable PCI Express device and > >> supports devices

Re: [Qemu-devel] [PATCH v2 5/7] block/nbd-client: nbd_co_send_request: return -EIO if s->quit was set in parallel

2017-09-20 Thread Vladimir Sementsov-Ogievskiy
18.09.2017 19:01, Eric Blake wrote: On 09/18/2017 08:59 AM, Vladimir Sementsov-Ogievskiy wrote: It's incorrect to return success rc >= 0 if we skip qio_channel_writev_all() call due to s->quit. Does this need to cc: qemu-stable for 2.10.1 (or put another way, can we come up with some scenario o

Re: [Qemu-devel] need to resurrect no-lock option?

2017-09-20 Thread Christian Ehrhardt
On Wed, Sep 20, 2017 at 11:51 AM, Fam Zheng wrote: > On Wed, 09/20 11:26, Christian Ehrhardt wrote: > > Hi, > > this might have been discussed in the wake of the lock changes that took > > place in 2.10 but I can't find anything clear enough to follow in the > > current case. > > There was an old

Re: [Qemu-devel] [PATCH v10 02/10] migration: pass MigrationIncomingState* into migration check functions

2017-09-20 Thread Juan Quintela
Alexey Perevalov wrote: > That tiny refactoring is necessary to be able to set > UFFD_FEATURE_THREAD_ID while requesting features, and then > to create downtime context in case when kernel supports it. > > Signed-off-by: Alexey Perevalov Reviewed-by: Juan Quintela

Re: [Qemu-devel] [RFC v2 01/33] bitmap: remove BITOP_WORD()

2017-09-20 Thread Juan Quintela
Peter Xu wrote: > We have BIT_WORD(). It's the same. > > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela It is the same, and it don't ever exist on linux code.

Re: [Qemu-devel] [PATCH v2] s390x/cpu: expose the guest crash information

2017-09-20 Thread Cornelia Huck
On Tue, 19 Sep 2017 09:43:14 +0200 Christian Borntraeger wrote: > From: Jing Liu > > This patch is the s390 implementation of guest crash information, similar > to commit d187e08dc4 ("i386/cpu: add crash-information QOM property") and > the related commits. We will detect several crash reasons,

[Qemu-devel] [PATCH 0/3] add bdrv_co_drain_begin/end BlockDriver callbacks

2017-09-20 Thread Manos Pitsidianakis
This patch series renames bdrv_co_drain to bdrv_co_drain_begin and adds a new bdrv_co_drain_end callback to match bdrv_drained_begin/end and drained_begin/end of BdrvChild. This is needed because the throttle driver (block/throttle.c) needs a way to mark the end of the drain in order to toggle

Re: [Qemu-devel] [PATCH v3 5/5] s390x/css: support ccw IDA

2017-09-20 Thread Cornelia Huck
On Wed, 20 Sep 2017 13:13:01 +0200 Halil Pasic wrote: > On 09/20/2017 10:33 AM, Cornelia Huck wrote: > > On Wed, 20 Sep 2017 15:42:38 +0800 > > Dong Jia Shi wrote: > > > >> * Halil Pasic [2017-09-19 20:27:45 +0200]: > >>> + MEMTXATTRS_UNSPECIFIED, (void *) > >

[Qemu-devel] [PATCH 3/3] block/throttle.c: add bdrv_co_drain_begin/end callbacks

2017-09-20 Thread Manos Pitsidianakis
Signed-off-by: Manos Pitsidianakis --- block/throttle.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block/throttle.c b/block/throttle.c index 5bca76300f..833175ac77 100644 --- a/block/throttle.c +++ b/block/throttle.c @@ -197,6 +197,21 @@ static bool throttle_recurse_

[Qemu-devel] [PATCH 2/2] block/block-backend.c: remove blk_pread_unthrottled()

2017-09-20 Thread Manos Pitsidianakis
blk_pread_unthrottled was used to bypass I/O throttling on the BlockBackend in the case of async I/O. This is not needed anymore and we can just call blk_pread() directly. Signed-off-by: Manos Pitsidianakis --- include/sysemu/block-backend.h | 2 -- block/block-backend.c | 16 -

  1   2   3   4   >