On Tue, 19 Sep 2017 20:27:43 +0200 Halil Pasic <pa...@linux.vnet.ibm.com> wrote:
> Replace direct access which implicitly assumes no IDA > or MIDA with the new ccw data stream interface which should > cope with these transparently in the future. > > Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> > Reviewed-by: Pierre Morel<pmo...@linux.vnet.ibm.com> > --- > hw/s390x/virtio-ccw.c | 157 > +++++++++++++++----------------------------------- > 1 file changed, 46 insertions(+), 111 deletions(-) > > @@ -417,9 +382,9 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw) > /* Return zeroes if the guest supports more feature bits. */ > features.features = 0; > } > - address_space_stl_le(&address_space_memory, ccw.cda, > - features.features, MEMTXATTRS_UNSPECIFIED, > - NULL); > + ccw_dstream_rewind(&sch->cds); > + cpu_to_le32s(&features.features); > + ccw_dstream_write(&sch->cds, features.features); > sch->curr_status.scsw.count = ccw.count - sizeof(features); Hm, didn't you want to convert these as well? Or do you plan to do it as an add-on patch? > ret = 0; > }
