Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block

On Thu, 08/31 13:36, Philippe Mathieu-Daudé wrote: > On 08/31/2017 01:21 PM, Eric Blake wrote: > > On 08/31/2017 11:18 AM, Daniel P. Berrange wrote: > > > > > > 'qcow' (v1) was also passing last time I checked, though it is > > > waay slow to run compared to qcow2, so I'd understand if you > >

Re: [Qemu-devel] S390 bios breaks in qemu 2.10.rc3

On Thu, Aug 31, 2017 at 7:44 PM, Michael Roth wrote: > Quoting Thomas Huth (2017-08-29 04:35:22) > > On 28.08.2017 09:18, Christian Borntraeger wrote: > > > > > > > > > On 08/25/2017 10:29 AM, Cornelia Huck wrote: > > >> On Fri, 25 Aug 2017 10:21:58 +0200 > > >> Christian Borntraeger wrote: > >

Re: [Qemu-devel] [PATCH 06/15] input: convert virtio-input-hid device to keycodemapdb

On Wed, 2017-08-30 at 17:01 +0100, Daniel P. Berrange wrote: > On Mon, Aug 21, 2017 at 03:49:05PM +0200, Gerd Hoffmann wrote: > > On Thu, 2017-08-10 at 16:55 +0100, Daniel P. Berrange wrote: > > > -    virtio_input_key_config(vinput, keymap_qcode, > > > -    ARRAY_SIZE(keyma

[Qemu-devel] [qemu-web PATCH] Add a blog post about the release of version 2.10.0

Using the contents of Micheal Roth's announce e-mail for this blog post. Signed-off-by: Thomas Huth --- _posts/2017-09-01-qemu-2-10-0.md | 56 1 file changed, 56 insertions(+) create mode 100644 _posts/2017-09-01-qemu-2-10-0.md diff --git a/_posts/2017-

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post about the release of version 2.10.0

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1504250391-6353-1-git-send-email-th...@redhat.com Subject: [Qemu-devel] [qemu-web PATCH] Add a blog post about the release of version 2.10.0 Type: series === TEST SCRIPT BEGIN === #!/bin

Re: [Qemu-devel] [PATCH RESEND v3 0/3] Generic PCIe host bridge INTx determination for INTx routing

Hi, On 09/07/2017 23:02, Eric Auger wrote: > This series implements INTx to gsi routing for ARM VIRT/Gpex. This is > a respin of [1] which was lost in limbo. > > ARM virt uses GPEX PCIe bridge. This latter does not implement INTx > to GSI routing. PCIe/INTx assignment works but the consequence is

[Qemu-devel] [PATCH] target/ppc: Remove old STATUS file

The target/ppc/STATUS file has seen its last real update 10 years ago - so the information in there is not up to date anymore. Since nobody seems to care about this file, let's simply remove it. Signed-off-by: Thomas Huth --- target/ppc/STATUS | 550 --

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

+ our product manager If I understand correctly, we will need to reconsider things if I included any additional technology in my port. However, I didn't include any additional references/source in my port compared to Veertu, that was not in the qemu code already (e.g., hax-all/kvm-all) so I think

[Qemu-devel] QEMU is looping when I load a VM snapshot

Hello, I am repeatedly facing an issue while loading a saved snapshot into QEMU. I will detail the steps which I follow when I take a snapshot: 1. I start QEMU with *-enable-kvm* option. I then run a workload(a program from Spec2006) on QEMU. 2. Immediately after I start running the workload, I

Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block

On Thu, 08/31 17:18, Daniel P. Berrange wrote: > Could you add 'check -luks' - it should be passing already with git > master. Ideally it wants password-less sudo enabled, but will skip > the appropriate test if that's not there. I have this failure: 192 - output mismatch (see 192.out.b

Re: [Qemu-devel] RFC: changing ROM bundling in tar dists for releases

Hi, > > - The qemu release dists get ever larger as we add more ROMS. > > Adding > >    EFI ROM builds for i386, x86_64, and aarch64 will make the dists > >    larger still. > > I think these make sense. Should we tie this into the > recent suggestion (by Gerd?) that we should put all the > rom

Re: [Qemu-devel] [PATCH v5 04/12] tests: Add vm test lib

On Thu, 08/31 12:59, Philippe Mathieu-Daudé wrote: > Hi Fam, > > On 08/31/2017 03:42 AM, Fam Zheng wrote: > > This is the common code to implement a "VM test" to > > > >1) Download and initialize a pre-defined VM that has necessary > >dependencies to build QEMU and SSH access. > > Lookin

Re: [Qemu-devel] [PATCH v7 00/11] scripts/qemu.py fixes and cleanups

On Fri, Sep 1, 2017 at 1:36 AM, Eduardo Habkost wrote: > I was going to queue most of this series except patch 02/11 due > the "qemu received signal" message log level, but a few conflicts > prevent the rest of the series from applying cleanly. Are you > planning to send v8? Now I am. Sending as

Re: [Qemu-devel] [PATCH 02/14] qlit: move qlit from check-qjson to qobject/

Eduardo Habkost writes: > On Thu, Aug 24, 2017 at 12:33:38PM +0200, Marc-André Lureau wrote: >> Fix code style issues while at it, to please check-patch. >> >> Signed-off-by: Marc-André Lureau >> --- >> include/qapi/qmp/qlit.h | 49 + >> qobject/qlit.c | 89 +++

Re: [Qemu-devel] [PATCH v2] tests: Enable the drive_del test also on s390x

David Hildenbrand writes: >> static void test_drive_del_device_del(void) >> { >> +char *args; >> + >> /* Start with a drive used by a device that unplugs instantaneously */ >> -qtest_start("-drive if=none,id=drive0,file=null-co://,format=raw" >> -" -device virtio-sc

Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to use the null backend when none provided

Philippe Mathieu-Daudé writes: > On 08/31/2017 06:43 AM, Thomas Huth wrote: >> On 31.08.2017 11:36, Marc-André Lureau wrote: >>> Hi >>> >>> On Thu, Aug 31, 2017 at 7:20 AM Thomas Huth >> > wrote: >>> >>> On 31.08.2017 05:53, Philippe Mathieu-Daudé wrote: >>> > S

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

On Fri, Sep 01, 2017 at 01:10:54AM +0300, Izik Eidus wrote: > (BTW, I am pretty sure the copyright message that include GPLv2/GPLv3 and > created all this mess was taken from QEMU itself ... :)) Sigh, you are right there. I've just checked and found a random splattering of files with "GPL-v2-or-v3

Re: [Qemu-devel] [PATCH v5 04/12] tests: Add vm test lib

On Fri, Sep 01, 2017 at 04:39:38PM +0800, Fam Zheng wrote: > On Thu, 08/31 12:59, Philippe Mathieu-Daudé wrote: > > Hi Fam, > > > > On 08/31/2017 03:42 AM, Fam Zheng wrote: > > > This is the common code to implement a "VM test" to > > > > > >1) Download and initialize a pre-defined VM that ha

Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block

On Fri, Sep 01, 2017 at 04:22:13PM +0800, Fam Zheng wrote: > On Thu, 08/31 17:18, Daniel P. Berrange wrote: > > Could you add 'check -luks' - it should be passing already with git > > master. Ideally it wants password-less sudo enabled, but will skip > > the appropriate test if that's not there.

Re: [Qemu-devel] RFC: changing ROM bundling in tar dists for releases

On Fri, Sep 01, 2017 at 10:31:17AM +0200, Gerd Hoffmann wrote: > Hi, > > > > - The qemu release dists get ever larger as we add more ROMS. > > > Adding > > >    EFI ROM builds for i386, x86_64, and aarch64 will make the dists > > >    larger still. > > > > I think these make sense. Should we ti

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post about the release of version 2.10.0

On Fri, Sep 01, 2017 at 12:22:41AM -0700, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Message-id: 1504250391-6353-1-git-send-email-th...@redhat.com > Subject: [Qemu-devel] [qemu-web PATCH] Add a blog post

Re: [Qemu-devel] [PATCH 1/2] .dir-locals.el: add makefiles to auto-mode

Marc-André Lureau writes: > QEMU uses non-conventional makefile filenames. Ease the life of emacs > developpers a bit by appending to the auto-mode-alist. > > Signed-off-by: Marc-André Lureau > --- > .dir-locals.el | 7 ++- > Makefile.target | 2 -- > trace/Makefile.objs | 2 -- >

Re: [Qemu-devel] [PATCH V4 1/3] net/colo-compare.c: Optimize unpredictable tcp options comparison

Hi chen, At 08/21/2017 04:55 PM, Zhang Chen wrote: When network is busy, some tcp options(like sack) will unpredictable occur in primary side or secondary side. it will make packet size not same, but the two packet's payload is identical. colo just care about packet payload, so we skip the optio

Re: [Qemu-devel] [PATCH v5 04/12] tests: Add vm test lib

On 01.09.2017 11:21, Daniel P. Berrange wrote: > On Fri, Sep 01, 2017 at 04:39:38PM +0800, Fam Zheng wrote: >> On Thu, 08/31 12:59, Philippe Mathieu-Daudé wrote: >>> Hi Fam, >>> >>> On 08/31/2017 03:42 AM, Fam Zheng wrote: This is the common code to implement a "VM test" to 1) Dow

Re: [Qemu-devel] RFC: changing ROM bundling in tar dists for releases

Hi, > > Question is what to do with the non-firmware submodules (pixman, > > dtc, > > more?) then.  I think they are not that big, so I doubt it is worth > > the > > hassle to create two tarball versions.  And license-wise it isn't a > > issue too. > > I've always wondered why we need to specia

Re: [Qemu-devel] [PATCH v2 04/14] qlit: remove compound literals

Laszlo Ersek writes: > On 08/31/17 10:42, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> Hi >>> >>> - Original Message - Marc-André Lureau writes: > Hi > > - Original Message - >> Marc-André Lureau writes: >> >>> They are not con

Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block

On Thu, 08/31 11:06, Eric Blake wrote: > On 08/31/2017 06:22 AM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > tests/docker/test-block | 21 + > > 1 file changed, 21 insertions(+) > > create mode 100755 tests/docker/test-block > > > > +cd "$BUILD_DIR" > > + > >

Re: [Qemu-devel] About virtio device hotplug in Q35! 【外域邮件.谨慎查阅】

More updates: 1. This behavior was found not only on M60, but also on TITAN 1080Ti or Xp. 2. When not setting up the p2p compatibility, i.e. run the original qemu with GPUs attached to the root pcie bus, the LnkSta on host always remains at 8 GT/s. Don't know why the new p2p change would cause th

Re: [Qemu-devel] [PATCH v11 2/6] ACPI: Add APEI GHES Table Generation support

Hi Igor, On 2017/8/29 18:20, Igor Mammedov wrote: > On Fri, 18 Aug 2017 22:23:43 +0800 > Dongjiu Geng wrote: > >> This implements APEI GHES Table by passing the error CPER info >> to the guest via a fw_cfg_blob. After a CPER info is recorded, an >> SEA(Synchronous External Abort)/SEI(SError Inte

Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block

On Fri, Sep 01, 2017 at 05:55:52PM +0800, Fam Zheng wrote: > On Thu, 08/31 11:06, Eric Blake wrote: > > On 08/31/2017 06:22 AM, Fam Zheng wrote: > > > Signed-off-by: Fam Zheng > > > --- > > > tests/docker/test-block | 21 + > > > 1 file changed, 21 insertions(+) > > > create

Re: [Qemu-devel] [PATCH v4] vl: exit if maxcpus is negative

On 08/30/2017 10:40 PM, Philippe Mathieu-Daudé wrote: Hi Seeteena, On 08/29/2017 02:45 AM, Seeteena Thoufeek wrote: ---Steps to Reproduce--- When passed a negative number to 'maxcpus' parameter, Qemu aborts with a core dump. Run the following command with maxcpus argument as negative numbe

Re: [Qemu-devel] [PATCH v2] tests: Enable the drive_del test also on s390x

On 01.09.2017 11:10, Markus Armbruster wrote: > David Hildenbrand writes: > >>> static void test_drive_del_device_del(void) >>> { >>> +char *args; >>> + >>> /* Start with a drive used by a device that unplugs instantaneously */ >>> -qtest_start("-drive if=none,id=drive0,file=null-c

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post about the release of version 2.10.0

On 01.09.2017 11:28, Daniel P. Berrange wrote: > On Fri, Sep 01, 2017 at 12:22:41AM -0700, no-re...@patchew.org wrote: >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: >> >> Message-id: 1504250391-6353-1-git-send-email-th...@redhat.com >>

Re: [Qemu-devel] [PATCH v2] tests: Enable the drive_del test also on s390x

On Fri, 1 Sep 2017 12:39:49 +0200 Thomas Huth wrote: > On 01.09.2017 11:10, Markus Armbruster wrote: > > David Hildenbrand writes: > > > >>> static void test_drive_del_device_del(void) > >>> { > >>> +char *args; > >>> + > >>> /* Start with a drive used by a device that unplugs inst

[Qemu-devel] [PATCH] pixman: drop submodule

Drop pixman submodule and support for the "internal" pixman build. pixman should be reasonable well established meanwhile that we don't need the fallback submodule any more. While being at it also drop some #ifdefs for pixman versions olter than what we require in configure anyway. Signed-off-by:

[Qemu-devel] [PATCH] docs: add firmware.txt

Document how guest firmware is handled in qemu today. Reviewed-by: Laszlo Ersek Signed-off-by: Gerd Hoffmann --- docs/firmware.txt | 49 + 1 file changed, 49 insertions(+) create mode 100644 docs/firmware.txt diff --git a/docs/firmware.txt b/doc

[Qemu-devel] [PATCH 0/2] Fix / skip recent iotests with LUKS driver

Two recently added iotests are currently breaking 'check -luks', fix the easy one and disable the hard one. Daniel P. Berrange (2): iotests: rewrite 192 to use _launch_qemu to fix LUKS support iotests: blacklist 194 with the luks driver tests/qemu-iotests/192| 23

[Qemu-devel] [PATCH 1/2] iotests: rewrite 192 to use _launch_qemu to fix LUKS support

The LUKS driver requires extra args to QEMU to setup passwords. The _launch_qemu function takes care of this, so convert the test to use this function and use correct -drive syntax Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/192 | 23 --- 1 file changed, 16 inser

[Qemu-devel] [PATCH 2/2] iotests: blacklist 194 with the luks driver

The 194 test has alot of code that assumes a simple image file. Rewriting this to work with luks is possible, but non-trivial, so blacklist the luks format for now. Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/194| 1 + tests/qemu-iotests/iotests.py | 4 +++- 2 files changed,

Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/9] IDE: replace printfs with tracing

On Thu, Aug 31, 2017 at 08:14:53PM -0400, John Snow wrote: > Wherever possible, replace all printfs with proper tracing. > In most places I've tried to do a straight replacement, but > forthcoming patches may calibrate the tracing to be a little nicer. > > For now, it's nice to just remove the all

[Qemu-devel] [PATCHv4 0/6] seccomp: feature refactoring

v4: * include another field on the struct for the modes * remove priority * fixed typos * error handling for prctl * add allow|deny values for all options * error hanlding for wrong values for all options * change how binary values are treated * reformat help text v

[Qemu-devel] [PATCHv4 3/6] seccomp: add elevateprivileges argument to command line

This patch introduces the new argument [,elevateprivileges=allow|deny|children] to the `-sandbox on'. It allows or denies Qemu process to elevate its privileges by blacklisting all set*uid|gid system calls. The 'children' option will let forks and execves run unprivileged. Signed-off-by: Eduardo O

[Qemu-devel] [PATCHv4 1/6] seccomp: changing from whitelist to blacklist

This patch changes the default behavior of the seccomp filter from whitelist to blacklist. By default now all system calls are allowed and a small black list of definitely forbidden ones was created. Signed-off-by: Eduardo Otubo --- include/sysemu/seccomp.h | 2 + qemu-seccomp.c | 26

Re: [Qemu-devel] RFC: changing ROM bundling in tar dists for releases

On 1 September 2017 at 10:24, Daniel P. Berrange wrote: > I've always wondered why we need to specialcase those modules at all. > Personally I'd just remove them entirely and let people install the > -dev packages on their distro just like they do for any other build > prerequisite of QEMU. Two u

[Qemu-devel] [PATCHv4 4/6] seccomp: add spawn argument to command line

This patch adds [,spawn=deny] argument to `-sandbox on' option. It blacklists fork and execve system calls, avoiding Qemu to spawn new threads or processes. Signed-off-by: Eduardo Otubo --- include/sysemu/seccomp.h | 1 + qemu-options.hx | 9 +++-- qemu-seccomp.c | 12 ++

[Qemu-devel] [PATCHv4 2/6] seccomp: add obsolete argument to command line

This patch introduces the argument [,obsolete=allow] to the `-sandbox on' option. It allows Qemu to run safely on old system that still relies on old system calls. Signed-off-by: Eduardo Otubo --- include/sysemu/seccomp.h | 3 ++- qemu-options.hx | 12 ++-- qemu-seccomp.c

[Qemu-devel] [PATCHv4 5/6] seccomp: add resourcecontrol argument to command line

This patch adds [,resourcecontrol=deny] to `-sandbox on' option. It blacklists all process affinity and scheduler priority system calls to avoid any bigger of the process. Signed-off-by: Eduardo Otubo --- include/sysemu/seccomp.h | 1 + qemu-options.hx | 9 ++--- qemu-seccomp.c

[Qemu-devel] [PATCHv4 6/6] seccomp: adding documentation to new seccomp model

Adding new documentation under docs/ to describe every one and each new option added by the refactoring patchset. Signed-off-by: Eduardo Otubo --- docs/seccomp.txt | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 docs/seccomp.txt diff --git a/docs/secco

Re: [Qemu-devel] [PATCHv4 6/6] seccomp: adding documentation to new seccomp model

On Fri, Sep 01, 2017 at 12:58:18PM +0200, Eduardo Otubo wrote: > Adding new documentation under docs/ to describe every one and each new > option added by the refactoring patchset. > > Signed-off-by: Eduardo Otubo > --- > docs/seccomp.txt | 31 +++ > 1 file changed, 3

[Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

When used with the following command line: ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 QEMU with machine type 40p already creates the device i82374. If specified in the command line, it will try to create it again, hence generating the error. One way to avoid this

Re: [Qemu-devel] [PATCHv4 1/6] seccomp: changing from whitelist to blacklist

On Fri, Sep 01, 2017 at 12:58:13PM +0200, Eduardo Otubo wrote: > This patch changes the default behavior of the seccomp filter from > whitelist to blacklist. By default now all system calls are allowed and > a small black list of definitely forbidden ones was created. > > Signed-off-by: Eduardo Ot

[Qemu-devel] [PATCH] isa-fdc: assert replaced by proper error exit

When not available, isa-fdc falls into assert instead of proper error exit. This patch fixes this behavior. Signed-off-by: Eduardo Otubo --- hw/block/fdc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index 401129073b..0b6def4e1d 100644

Re: [Qemu-devel] [PATCHv4 2/6] seccomp: add obsolete argument to command line

On Fri, Sep 01, 2017 at 12:58:14PM +0200, Eduardo Otubo wrote: > This patch introduces the argument [,obsolete=allow] to the `-sandbox on' > option. It allows Qemu to run safely on old system that still relies on > old system calls. > > Signed-off-by: Eduardo Otubo > --- > include/sysemu/seccomp

[Qemu-devel] [Bug 1714331] Re: Virtual machines not working anymore on 2.10

Please try: -machine pc-q35-2.9,accel=kvm,mem-merge=off I'm not sure if it will make a difference in this case but it presents exactly the same onboard hardware as QEMU 2.9. The onboard hardware configuration may change unless you specify a precise version in the machine type, so I suggest using

[Qemu-devel] [PATCH v8 03/13] qemu.py: use os.path.null instead of /dev/null

For increased portability, let's use os.path.devnull. Signed-off-by: Amador Pahim --- scripts/qemu.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/qemu.py b/scripts/qemu.py index aca6fa4d82..a6e06291ea 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -79,7

[Qemu-devel] [PATCH v8 00/13] scripts/qemu.py fixes and cleanups

Changes v1->v2: - Style fixes to make checkpatch.pl happy. - Rebased. Changes v2->v3: - Fix typo in patch 3 ("qemu.py: make 'args' public") commit message. Changes v3->v4: - Squash the 2 first commits since they are co-dependant. - Cleanup launch() and shutdown(). - Reorder the commits, putti

[Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create

To launch a VM, we need to create basically two files: the monitor socket (if it's a UNIX socket) and the qemu log file. For the qemu log file, we currently just open the path, which will create the file if it does not exist or overwrite the file if it does exist. For the monitor socket, if it al

[Qemu-devel] [PATCH v8 02/13] qemu.py: avoid writing to stdout/stderr

This module should not write directly to stdout/stderr. Instead, it should either raise exceptions or just log the messages and let the callers handle them and decide what to do. For example, scripts could choose to send the log messages stderr or/and write them to a file if verbose or debugging mo

[Qemu-devel] [PATCH v8 01/13] qemu.py: fix is_running() return before first launch()

is_running() returns None when called before the first time we call launch(): >>> import qemu >>> vm = qemu.QEMUMachine('qemu-system-x86_64') >>> vm.is_running() >>> It should return False instead. This patch fixes that. For consistence, this patch removes the parenthesis from th

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post about the release of version 2.10.0

On Fri, 09/01 12:41, Thomas Huth wrote: > On 01.09.2017 11:28, Daniel P. Berrange wrote: > > On Fri, Sep 01, 2017 at 12:22:41AM -0700, no-re...@patchew.org wrote: > >> Hi, > >> > >> This series seems to have some coding style problems. See output below for > >> more information: > >> > >> Message-i

[Qemu-devel] [PATCH v8 07/13] qemu.py: close _qemu_log_path on cleanup

We are opening the _qemu_log_path during the launch() but we are forgetting to close it. This patch makes sure we will close the self._qemu_log_path during the cleanup (post_shutdown()). Signed-off-by: Amador Pahim --- scripts/qemu.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scrip

[Qemu-devel] [PATCH v8 05/13] qemu.py: include debug information on launch error

When launching a VM, if an exception happens and the VM is not initiated, it might be useful to see the qemu command line and the qemu command output. This patch creates that message. Notice that self._iolog needs to be cleaned up in the beginning of the launch() to make sure we will not expose th

[Qemu-devel] [PATCH v8 04/13] qemu.py: improve message on negative exit code

The current message shows 'self._args', which contains only part of the options used in the Qemu command line. This patch makes the qemu full args list an instance variable and then uses it in the negative exit code message. Message was moved outside the 'if is_running' block to make sure it will

[Qemu-devel] [PATCH v8 08/13] qemu.py: refactor launch()

This is just an refactor to separate the exception handler from the actual launch procedure, improving the readability and making future maintenances in this piece of code easier. Signed-off-by: Amador Pahim --- scripts/qemu.py | 29 ++--- 1 file changed, 18 insertions(+)

[Qemu-devel] [PATCH v8 11/13] qemu.py: cleanup redundant calls in launch()

Now that shutdown() is guaranteed to always execute self._load_io_log() and self._post_shutdown(), their calls in 'except' became redundant and we can safely replace it by a call to shutdown(). Due to this change, shutdown() can be now called even before the creation of the _qemu_log_path. So, to

[Qemu-devel] [PATCH v8 09/13] qemu.py: always cleanup on shutdown()

Currently we only cleanup on shutdown() if the VM is running. To make sure we will always cleanup, this patch makes the cleanup to always happen in shutdown, regardless the VM running state. Signed-off-by: Amador Pahim --- scripts/qemu.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-

[Qemu-devel] [PATCH v8 10/13] qemu.py: use poll() instead of 'returncode'

The 'returncode' Popen attribute is not guaranteed to be updated. It actually depends on a call to either poll(), wait() or communicate(). On the other hand, poll() will: "Check if child process has terminated. Set and return returncode attribute." Let's use the poll() to check whether the proces

[Qemu-devel] [PATCH v3 1/2] tests: Use real size for iov tests

We were using -1 instead of the real size because the functions check what is bigger, size in bytes or the size of the iov. Recent gcc's barf at this. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu Tested-by: Cleber Rosa -- Remove comments about this feature. Fix missing -1. --- include/

[Qemu-devel] [PATCH v8 12/13] qemu.py: launch vm only if it's not running

A new call to launch() with a running VM will fall in exception and consequently call shutdown(). This patch makes launch() to raise an exception when it's called with VM already running. Signed-off-by: Amador Pahim --- scripts/qemu.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scri

[Qemu-devel] [PATCH v3 0/2] Fix tests on recent gcc

Hi changes from v2: - change assert from position Please review. [v2] - move all uses of -1 for memtest. - remove docs about the feature. - use size_t for the second patch (cedric) Please, review. [v1] On Fedora 26 (gcc-7.1.1 and glib2 2.52.3) tests don't compile. In file included from /u

[Qemu-devel] [PATCH v8 13/13] qemu.py: don't launch again before shutdown()

If a VM is launched, files are created and a cleanup is required before a new launch. This cleanup is executed by shutdown(), so shutdown() must be called even if the VM is manually terminated (i.e. using kill). This patch creates a control to make sure launch() will not be executed again if shutd

Re: [Qemu-devel] [PATCHv4 0/6] seccomp: feature refactoring

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170901105818.31956-1-ot...@redhat.com Subject: [Qemu-devel] [PATCHv4 0/6] seccomp: feature refactoring Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] [PATCH v8 03/13] qemu.py: use os.path.null instead of /dev/null

On 09/01/2017 08:28 AM, Amador Pahim wrote: For increased portability, let's use os.path.devnull. Signed-off-by: Amador Pahim Reviewed-by: Philippe Mathieu-Daudé --- scripts/qemu.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/qemu.py b/scripts/qemu.py

[Qemu-devel] [Bug 1714331] Re: Virtual machines not working anymore on 2.10

> Please try: -machine pc-q35-2.9,accel=kvm,mem-merge=off I've tried the first configuration (windowed) with the change you proposed, and I get the same behavior (windows recovery); I didnt' try the second configuration (VFIO). > Did you build QEMU 2.9 from source with the same ./configure option

Re: [Qemu-devel] [PATCH] isa-fdc: assert replaced by proper error exit

On 01.09.2017 13:07, Eduardo Otubo wrote: > When not available, isa-fdc falls into assert instead of proper error > exit. This patch fixes this behavior. > > Signed-off-by: Eduardo Otubo > --- > hw/block/fdc.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/hw/bloc

[Qemu-devel] [PATCH v3 2/2] tests: Make vmgenid test compile

Just make sure that nr_tables is size_t not int. Suggested-by: Cédric Le Goater Signed-off-by: Juan Quintela Tested-by: Cleber Rosa -- Drop the s/g_new0/g_malloc0/ change. --- tests/vmgenid-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vmgenid-test.c b/test

Re: [Qemu-devel] [PATCH] block: Cleanup BMDS in bdrv_close_all

Fam Zheng wrote: > This fixes the assertion due to op blockers added by BMDS: > > block.c:3248: bdrv_delete: Assertion `bdrv_op_blocker_is_empty(bs)' failed. > > Reproducer: simply start block migration and quit QEMU before it ends. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Fam Zheng Revie

Re: [Qemu-devel] [PATCH v19 0/2] virtio-crypto: virtio crypto device specification

On 09/01/2017 02:47 AM, Longpeng (Mike) wrote: > Ping... > > Stefan, Halil, do you have any suggestion ? > Hi Longpeng, I've ran trough your patch, and it reads much better that what I recall v18 used to read like. Because it's been a while since v18 doing a conscious review on this will take

Re: [Qemu-devel] [PATCH v11 2/6] ACPI: Add APEI GHES Table Generation support

On Fri, 1 Sep 2017 17:58:55 +0800 gengdongjiu wrote: > Hi Igor, > > On 2017/8/29 18:20, Igor Mammedov wrote: > > On Fri, 18 Aug 2017 22:23:43 +0800 > > Dongjiu Geng wrote: [...] > > > >> +void ghes_build_acpi(GArray *table_data, GArray *hardware_error, > >> +

[Qemu-devel] [PATCH v4 2/2] tests: Make vmgenid test compile

Just make sure that nr_tables is size_t not int. Once there, do the assert in the right place and be sure that we don't have a division by zero. Suggested-by: Cédric Le Goater Signed-off-by: Juan Quintela Tested-by: Cleber Rosa -- Drop the s/g_new0/g_malloc0/ change. Avoid division by zero wi

[Qemu-devel] [PATCH v4 0/2] Fix tests on recent gcc

Hi v4: really sent the patches for v3, not for v2. Sorry folks [v3] - change assert from position Please review. [v2] - move all uses of -1 for memtest. - remove docs about the feature. - use size_t for the second patch (cedric) Please, review. [v1] On Fedora 26 (gcc-7.1.1 and glib2 2.52.

[Qemu-devel] [PATCH v4 1/2] tests: Use real size for iov tests

We were using -1 instead of the real size because the functions check what is bigger, size in bytes or the size of the iov. Recent gcc's barf at this. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu Tested-by: Cleber Rosa -- Remove comments about this feature. Fix missing -1. --- include/

Re: [Qemu-devel] [PATCH v3 0/2] Fix tests on recent gcc

Juan Quintela wrote: > Hi > > changes from v2: > - change assert from position SelfNAK Just sent the v2 patches instead of v3. A v4 is already on list with the right patches. Sorry, Juan.

Re: [Qemu-devel] [PATCH v2 00/14] Generate a literal qobject for introspection

Marc-André Lureau writes: > Hi, > > This series is based on patches 2-5 from "[PATCH v2 00/54] qapi: add #if > pre-processor conditions to generated code". Generating a literal qobject > will allow to easily introduce #if conditionals from the original series. > > v2: > - use QLIST_FOREACH_ENTRY

Re: [Qemu-devel] [PATCH v2 09/16] qapi-schema: Collect migration stuff in qapi/migration.json

Markus Armbruster writes: > "Dr. David Alan Gilbert" writes: > >> * Markus Armbruster (arm...@redhat.com) wrote: >>> Cc: Juan Quintela >>> Cc: Dr. David Alan Gilbert >>> Signed-off-by: Markus Armbruster >> >> >> Two thoughts: >> a) Do you actually want that as migration/migration.json? > >

Re: [Qemu-devel] [PATCH v4 2/2] tests: Make vmgenid test compile

On Fri, Sep 01, 2017 at 01:55:00PM +0200, Juan Quintela wrote: > Just make sure that nr_tables is size_t not int. > Once there, do the assert in the right place and be sure that we don't > have a division by zero. > > Suggested-by: Cédric Le Goater > Signed-off-by: Juan Quintela > Tested-by: Cle

Re: [Qemu-devel] [PATCH v4 1/2] tests: Use real size for iov tests

On Fri, Sep 01, 2017 at 01:54:59PM +0200, Juan Quintela wrote: > We were using -1 instead of the real size because the functions check > what is bigger, size in bytes or the size of the iov. Recent gcc's > barf at this. > > Signed-off-by: Juan Quintela > Reviewed-by: Peter Xu > Tested-by: Clebe

Re: [Qemu-devel] [PATCH v2 00/16] qapi-schema: Reorganize along maintenance boundaries

Markus Armbruster writes: > Cc: "Daniel P. Berrange" > Cc: Alberto Garcia > Cc: Dr. David Alan Gilbert > Cc: Gerd Hoffmann > Cc: Jason Wang > Cc: Juan Quintela > Cc: Marc-André Lureau > Cc: Paolo Bonzini > > Much of the QAPI schema really belongs to a subsystem, but MAINTAINERS > can't te

Re: [Qemu-devel] [PATCH 00/16] qapi: Rework mapping of enum value to string

Markus Armbruster writes: > The purpose of this work is to make holes in QAPI enumerations > possible. > > Why holes? Because we want to be able to suppress enumeration > constants with #if. Holes could be avoided, e.g. by letting the > compiler assign the values. Falls apart when the conditio

Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling

On 8/31/2017 3:34 PM, Alberto Garcia wrote: On Wed 30 Aug 2017 05:12:22 PM CEST, Pradeep Jagadeesh wrote: On 8/30/2017 5:10 PM, Alberto Garcia wrote: On Wed 30 Aug 2017 05:07:29 PM CEST, Pradeep Jagadeesh wrote: Thanks for the steps, I did reproduce the issue easily. Looking into the code, ma

[Qemu-devel] [PULL 01/47] qapi: Fix error handling code on alternate conflict

From: Eduardo Habkost The conflict check added by commit c0644771 ("qapi: Reject alternates that can't work with keyval_parse()") doesn't work with the following declaration: { 'alternate': 'Alt', 'data': { 'one': 'bool', 'two': 'str' } } It crashes with: Traceback (most

[Qemu-devel] [PULL 04/47] qdict: Add qdict_put_null() helper, and put it to use

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Message-Id: <20170825105913.4060-2-marcandre.lur...@redhat.com> [Update to qobject.cocci squashed in, commit message tweaked] Signed-off-by: Markus Armbruster --- include/qapi/qmp/qdict.h | 4 +++-

[Qemu-devel] [PULL 16/47] qapi-schema: Document how generated documentation is ordered

Documentation generated with qapi2texi.py is in source order, with included sub-schemas inserted at the first include directive (subsequent include directives have no effect). To get a sane and stable order, it's best to include each sub-schema just once, or include it first in qapi-schema.json.

[Qemu-devel] [PULL 14/47] qlit: Tighten QLit dict vs QDict comparison

From: Marc-André Lureau We check that all members of the QLit dictionary are also in the QDict. We neglect to check the other direction. Comparing the number of members suffices, because QDict can't contain duplicate members, and putting duplicates in a QLit is a programming error. Signed-off-

[Qemu-devel] [PULL 13/47] tests/check-qlit: New, covering qobject/qlit.c

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20170825105913.4060-11-marcandre.lur...@redhat.com> [Copyright notice correction squashed in, commit message tweaked] Signed-off-by: Markus Armbruster --- tests/Makefile.include | 5 +++- tests/check-qlit.c | 64 +++

[Qemu-devel] [PULL 03/47] qobject: Explain how QNum works, and why

Suggested-by: Max Reitz Signed-off-by: Markus Armbruster Message-Id: <1503384739-17207-1-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau [Comment typos fixed] --- include/qapi/qmp/qnum.h | 21 + 1 file changed, 21 insertions(+) diff --git a/include/qapi/qmp

[Qemu-devel] [PULL 07/47] qlit: Change compound literals to initializers

From: Marc-André Lureau The QLIT_QFOO() macros expand into compound literals. Sadly, gcc doesn't recognizes these as constant expressions (clang does), which makes the macros useless for initializing objects with static storage duration. There is a gcc bug about it: https://gcc.gnu.org/bugzilla

[Qemu-devel] [PULL 33/47] qapi: Drop superfluous qapi_enum_parse() parameter max

The lookup tables have a sentinel, no need to make callers pass their size. Signed-off-by: Markus Armbruster Message-Id: <1503564371-26090-3-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau Reviewed-by: Eric Blake [Commit message corrected] --- block.c | 1 -

[Qemu-devel] [PULL 29/47] qapi-schema: Make block-core.json self-contained

Except for block-core.json, the sub-schemas are self-contained: if they use a symbol defined in another sub-schema, they include that sub-schema. To check, feed the sub-schema to qapi2texi (or any other QAPI generator) along with the pragma from qapi-schema.json. Fix up things to make block-core.

[Qemu-devel] [PULL 31/47] qapi-schema: Improve section headings

The generated QEMU QMP reference is now structured as follows: 1.1 Introduction 1.2 Stability Considerations 1.3 Common data types 1.4 Socket data types 1.5 VM run state 1.6 Cryptography 1.7 Block devices 1.7.1 Block core (VM unrelated) 1.7.2 QAPI block definiti

  1   2   3   4   >