[Qemu-devel] [PATCHv5 00/03] Replace the COLO comparing thread with IOThread

2017-08-29 Thread Wang yong
From: Wang Yong It's a good idea to use IOThread instead of COLO comparing thread. comparing thread can be completely replaced by IOThread, so this idea came. This series of updates mainly include IOThread supports the GMainContext event loop, then the old packet regularly check and primary/seco

[Qemu-devel] [PATCHv5 03/03] colo-compare: Update the COLO document to add the IOThread configuration

2017-08-29 Thread Wang yong
From: Wang Yong Update colo-proxy.txt,add IOThread configuration. Later we have to configure IOThread,if not COLO can not work. Signed-off-by: Wang Yong Signed-off-by: Wang Guang --- docs/colo-proxy.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/colo-proxy.txt

[Qemu-devel] [PATCHv5 01/03] qemu-iothread: IOThread supports the GMainContext event loop

2017-08-29 Thread Wang yong
From: Wang Yong IOThread uses AioContext event loop and does not run a GMainContext. Therefore,chardev cannot work in IOThread,such as the chardev is used for colo-compare packets reception. This patch makes the IOThread run the GMainContext event loop, chardev and IOThread can work together. S

[Qemu-devel] [PATCHv5 02/03] colo-compare: Use IOThread to Check old packet regularly and Process pactkets of the primary

2017-08-29 Thread Wang yong
From: Wang Yong Remove the task which check old packet in the comparing thread, then use IOthread context timer to handle it. Process pactkets in the IOThread which arrived over the socket. we use iothread_get_g_main_context to create a new g_main_loop in the IOThread.then the packets from the p

Re: [Qemu-devel] [PATCH 00/79] Patch Round-up for stable 2.9.1, freeze on 2017-09-04

2017-08-29 Thread Cornelia Huck
On Tue, 29 Aug 2017 04:18:20 +0200 Thomas Huth wrote: > On 29.08.2017 02:13, Michael Roth wrote: > > Hi everyone, > > > > The following new patches are queued for QEMU stable v2.9.1: > > > > https://github.com/mdroth/qemu/commits/stable-2.9-staging > > > > The release is planned for 2017-09-

Re: [Qemu-devel] [PATCH] virtio-input: send rel-wheel events for wheel buttons

2017-08-29 Thread Ladi Prosek
On Wed, Aug 23, 2017 at 3:51 PM, Gerd Hoffmann wrote: > qemu uses wheel-up/down button events for mouse wheel input, however > linux applications typically want REL_WHEEL events. > > This fixes wheel with linux guests. Tested with X11/wayland, and > windows virtio-input driver. > > Based on a patc

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-29 Thread Cornelia Huck
On Tue, 29 Aug 2017 12:32:17 +0800 Yi Min Zhao wrote: > 在 2017/8/28 下午10:51, Cornelia Huck 写道: > > On Mon, 28 Aug 2017 10:04:44 +0200 > > Yi Min Zhao wrote: > > > >> The function trap_msix() is to check if pcistg instruction would access > >> msix table entries. The correct boundary condition

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午4:00, Cornelia Huck 写道: On Tue, 29 Aug 2017 12:32:17 +0800 Yi Min Zhao wrote: 在 2017/8/28 下午10:51, Cornelia Huck 写道: On Mon, 28 Aug 2017 10:04:44 +0200 Yi Min Zhao wrote: The function trap_msix() is to check if pcistg instruction would access msix table entries. The corre

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-29 Thread Cornelia Huck
[Restored cc:s. Please remember to do reply-all.] On Tue, 29 Aug 2017 12:46:51 +0800 Yi Min Zhao wrote: > 在 2017/8/28 下午11:57, Cornelia Huck 写道: > > On Mon, 28 Aug 2017 10:04:47 +0200 > > Yi Min Zhao wrote: > > > >> Let's introduce iommu replay callback for s390 pci iommu memory region. > >> Cu

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午4:00, Cornelia Huck 写道: On Tue, 29 Aug 2017 12:32:17 +0800 Yi Min Zhao wrote: 在 2017/8/28 下午10:51, Cornelia Huck 写道: On Mon, 28 Aug 2017 10:04:44 +0200 Yi Min Zhao wrote: The function trap_msix() is to check if pcistg instruction would access msix table entries. The corre

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-29 Thread Cornelia Huck
On Tue, 29 Aug 2017 16:12:26 +0800 Yi Min Zhao wrote: > 在 2017/8/29 下午4:00, Cornelia Huck 写道: > > On Tue, 29 Aug 2017 12:32:17 +0800 > > Yi Min Zhao wrote: > > > >> 在 2017/8/28 下午10:51, Cornelia Huck 写道: > >>> On Mon, 28 Aug 2017 10:04:44 +0200 > >>> Yi Min Zhao wrote: > >>> > The

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午4:07, Cornelia Huck 写道: [Restored cc:s. Please remember to do reply-all.] On Tue, 29 Aug 2017 12:46:51 +0800 Yi Min Zhao wrote: 在 2017/8/28 下午11:57, Cornelia Huck 写道: On Mon, 28 Aug 2017 10:04:47 +0200 Yi Min Zhao wrote: Let's introduce iommu replay callback for s390 pci i

Re: [Qemu-devel] understanding qemu devices

2017-08-29 Thread Thomas Huth
On 18.07.2017 23:44, Eric Blake wrote: > Based on an IRC conversation today, here's some notes that may help > newcomers understand what is actually happening with qemu devices. The > initial question was how does a guest mount a qcow2 file (the poster was > wondering if it was a loop or FUSE file

Re: [Qemu-devel] [RFC v2 16/32] vhost+postcopy: Send address back to qemu

2017-08-29 Thread Peter Xu
On Thu, Aug 24, 2017 at 08:27:14PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > We need a better way, but at the moment we need the address of the > mappings sent back to qemu so it can interpret the messages on the > userfaultfd it reads. > > Note: We don't as

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午4:22, Cornelia Huck 写道: On Tue, 29 Aug 2017 16:12:26 +0800 Yi Min Zhao wrote: 在 2017/8/29 下午4:00, Cornelia Huck 写道: On Tue, 29 Aug 2017 12:32:17 +0800 Yi Min Zhao wrote: 在 2017/8/28 下午10:51, Cornelia Huck 写道: On Mon, 28 Aug 2017 10:04:44 +0200 Yi Min Zhao wrote:

Re: [Qemu-devel] GSOC Report: Moving I/O throttling and write notifiers into block filter drivers

2017-08-29 Thread Stefan Hajnoczi
On Mon, Aug 28, 2017 at 05:57:28PM +0300, Manos Pitsidianakis wrote: > Branches / Patches > == > > The 'throttle' and 'throttle-remove-legacy' patches should be merged soon > after master unfreezes from the 2.10 release. The rest of the patch series > are in final stages of review

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

2017-08-29 Thread Alexey Kardashevskiy
On 25/08/17 18:53, Paolo Bonzini wrote: > On 25/08/2017 10:31, Alexey Kardashevskiy wrote: >> Otherwise old dispatch holds way too much memory before RCU gets >> a chance to free old dispatches. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> >> This is a follow-up to the "Memory use with >100

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-29 Thread Cornelia Huck
On Tue, 29 Aug 2017 16:33:52 +0800 Yi Min Zhao wrote: > 在 2017/8/29 下午4:22, Cornelia Huck 写道: > > On Tue, 29 Aug 2017 16:12:26 +0800 > > Yi Min Zhao wrote: > > > >> 在 2017/8/29 下午4:00, Cornelia Huck 写道: > >>> On Tue, 29 Aug 2017 12:32:17 +0800 > >>> Yi Min Zhao wrote: > >>> > 在 20

Re: [Qemu-devel] [PATCH 01/14] hvf: add support for Hypervisor.framework in the configure script

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 08:56:41PM -0500, Sergio Andres Gomez Del Real wrote: > @@ -3619,6 +3619,16 @@ applicable to MAC and Windows platform, and thus does > not conflict with > KVM. > ETEXI > > +DEF("enable-hvf", 0, QEMU_OPTION_enable_hvf, \ > +"-enable-hvf enable Hypervisor.framewor

Re: [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance

2017-08-29 Thread Jason Wang
On 2017年08月22日 15:16, no-re...@patchew.org wrote: Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1503305719-2512-1-git-send-email-zhangchen.f...@cn.fujitsu.com Subject: [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare

Re: [Qemu-devel] [PATCH] MAINTAINERS: Update mail address for COLO Proxy

2017-08-29 Thread Jason Wang
On 2017年08月29日 13:31, Zhang Chen wrote: Hi~ No news for long time. Ping... Thanks Zhang Chen On 08/23/2017 04:51 PM, Zhang Chen wrote: My Fujitsu mail account will be disabled soon, update the mail info to my private mail. Signed-off-by: Zhang Chen --- MAINTAINERS | 2 +- 1 file ch

Re: [Qemu-devel] [QGA] Bug of qga?

2017-08-29 Thread Sameeh Jubran
Hi Sam, Thanks for reporting this, in order to debug this efficiently I need you to provide me with more info, if you can provide it that would be great. Can you reproduce the issue with ncat? You can use ncat to connect to the socket by running the following command: nc -U /tmp/qga.sock Which O

[Qemu-devel] [PATCH v2] qemu-iotests: Extend non-shared storage migration test (194)

2017-08-29 Thread Kashyap Chamarthy
This is the follow-up patch that was discussed[*] as part of feedback to qemu-iotest 194. Changes in this patch: - Supply 'job-id' parameter to `drive-mirror` invocation. - Issue QMP `block-job-cancel` command on the source QEMU to gracefully complete `drive-mirror` operation. - Stop

Re: [Qemu-devel] GSOC Report: Moving I/O throttling and write notifiers into block filter drivers

2017-08-29 Thread Alberto Garcia
On Tue 29 Aug 2017 10:51:28 AM CEST, Stefan Hajnoczi wrote: >> Already merged patches in 2.10 >> https://github.com/qemu/qemu/commits/v2.10.0-rc4?author=epilys >> Already merged patches for 2.11 >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg470461.html >> >> [0] [insert-node] block-i

Re: [Qemu-devel] [PATCH 03/14] hvf: add conditional macros around hvf code in cpus.c

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 08:56:43PM -0500, Sergio Andres Gomez Del Real wrote: > @@ -900,6 +904,11 @@ void cpu_synchronize_all_states(void) > > CPU_FOREACH(cpu) { > cpu_synchronize_state(cpu); > +#ifdef CONFIG_HVF > +if (hvf_enabled()) { > +hvf_cpu_synchronize_sta

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

2017-08-29 Thread Peter Maydell
On 26 August 2017 at 01:02, Emilio G. Cota wrote: > An additional "nice to have" would be: > > * Allow inlining of TCG code by the instrumenter. Example use case: > the instrumenter wants to increment a counter every time a > basic block is executed. Instead of calling a callback function on e

Re: [Qemu-devel] [PULL 0/1] slirp updates

2017-08-29 Thread Peter Maydell
On 28 August 2017 at 00:05, Samuel Thibault wrote: > warning: redirection vers https://people.debian.org/~sthibault/qemu.git/ > The following changes since commit 04d74e07b4542aad5aa4ad03951b38b767f5314a: > > slirp: fix clearing ifq_so from pending packets (2017-08-26 01:04:12 +0200) > > are ava

Re: [Qemu-devel] [PULL 0/1] slirp updates

2017-08-29 Thread Samuel Thibault
Peter Maydell, on mar. 29 août 2017 10:20:31 +0100, wrote: > On 28 August 2017 at 00:05, Samuel Thibault > wrote: > > warning: redirection vers https://people.debian.org/~sthibault/qemu.git/ > > The following changes since commit 04d74e07b4542aad5aa4ad03951b38b767f5314a: > > > > slirp: fix clear

Re: [Qemu-devel] [PATCH 04/14] hvf: add fields to CPUState and CPUX86State; add definitions

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 08:56:44PM -0500, Sergio Andres Gomez Del Real wrote: > This commit adds some fields specific to hvf in CPUState and > CPUX86State. It also adds some handy #defines. > > Signed-off-by: Sergio Andres Gomez Del Real > --- > include/qom/cpu.h | 8 > target/i386/cpu

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-29 Thread Cornelia Huck
On Tue, 29 Aug 2017 16:26:10 +0800 Yi Min Zhao wrote: > 在 2017/8/29 下午4:07, Cornelia Huck 写道: > > [Restored cc:s. Please remember to do reply-all.] > > > > On Tue, 29 Aug 2017 12:46:51 +0800 > > Yi Min Zhao wrote: > > > >> 在 2017/8/28 下午11:57, Cornelia Huck 写道: > >>> On Mon, 28 Aug 2017 10:0

Re: [Qemu-devel] [PATCH 06/14] hvf: add compilation rules to Makefile.objs

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 08:56:46PM -0500, Sergio Andres Gomez Del Real wrote: > This commit adds to target/i386/Makefile.objs the necessary rules so > that the new files for hvf are compiled by the build system. > It also adds handling of the -enable-hvf argument in the main function > in vl.c. >

Re: [Qemu-devel] [PATCH 07/14] hvf: run hvf code through checkpatch.pl and fix style issues

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 08:56:47PM -0500, Sergio Andres Gomez Del Real wrote: > Signed-off-by: Sergio Andres Gomez Del Real Please make this the 2nd patch so there are no other patches in between that modify code that violates coding style.

Re: [Qemu-devel] S390 bios breaks in qemu 2.10.rc3

2017-08-29 Thread Thomas Huth
On 28.08.2017 09:18, Christian Borntraeger wrote: > > > On 08/25/2017 10:29 AM, Cornelia Huck wrote: >> On Fri, 25 Aug 2017 10:21:58 +0200 >> Christian Borntraeger wrote: >> >>> On 08/25/2017 09:20 AM, Cornelia Huck wrote: >> OK, to recap: - the current pre-built bios seems fine >

Re: [Qemu-devel] [PATCH 08/14] apic: add function to apic that will be used by hvf

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 08:56:48PM -0500, Sergio Andres Gomez Del Real wrote: > This commit moves (hides) the function apic_get_highest_priority_irr to > apic.c and exports it through the interface in apic.h for use by hvf. I don't see a move. This patch only adds a new function. Did you forget

Re: [Qemu-devel] [PATCH 10/14] hvf: refactor cpuid code

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 08:56:50PM -0500, Sergio Andres Gomez Del Real wrote: > This commit adds code to request the cpuid features supported by the > host and hvf; it calls hvf_get_supported_cpuid if hvf is compiled with > QEMU and enabled. > > Signed-off-by: Sergio Andres Gomez Del Real > --- >

Re: [Qemu-devel] [Qemu-discuss] changing from net to netdev with vde switches and double nics

2017-08-29 Thread Thomas Huth
Hi, On 28.08.2017 15:58, Paolo wrote: > Hello everyone, > > I'm at loss as to how to translate from net to netdev syntax the following > lines: > > NET0="-net vde,vlan=0,sock=/var/run/vde.ctl00 -net > nic,vlan=0,model=rtl8139,macaddr=$NIC0MAC -net > tap,vlan=0,ifname=pub2,script=no,downscrip

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-29 Thread Cornelia Huck
On Tue, 29 Aug 2017 11:33:53 +0200 Cornelia Huck wrote: > My question was whether virtio-pci works with your patches on top at > all - last time I checked on master, virtio-pci devices failed to > realize with a "msi-x is mandatory" message. Just checked again, I still get qemu-system-s390x: -d

Re: [Qemu-devel] [PATCH 00/14] add support for Hypervisor.framework in QEMU

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 08:56:40PM -0500, Sergio Andres Gomez Del Real wrote: > The following patchset adds to QEMU the supporting for macOS's native > hypervisor, Hypervisor.framework (hvf). The code base is taken from > Google's Android emulator at > https://android.googlesource.com/platform/exte

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午5:33, Cornelia Huck 写道: On Tue, 29 Aug 2017 16:26:10 +0800 Yi Min Zhao wrote: 在 2017/8/29 下午4:07, Cornelia Huck 写道: [Restored cc:s. Please remember to do reply-all.] On Tue, 29 Aug 2017 12:46:51 +0800 Yi Min Zhao wrote: 在 2017/8/28 下午11:57, Cornelia Huck 写道: On Mon, 28

Re: [Qemu-devel] [PATCH 00/14] add support for Hypervisor.framework in QEMU

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 08:56:40PM -0500, Sergio Andres Gomez Del Real wrote: > The following patchset adds to QEMU the supporting for macOS's native > hypervisor, Hypervisor.framework (hvf). The code base is taken from > Google's Android emulator at > https://android.googlesource.com/platform/exte

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午5:49, Cornelia Huck 写道: On Tue, 29 Aug 2017 11:33:53 +0200 Cornelia Huck wrote: My question was whether virtio-pci works with your patches on top at all - last time I checked on master, virtio-pci devices failed to realize with a "msi-x is mandatory" message. Just checked agai

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-29 Thread Cornelia Huck
On Tue, 29 Aug 2017 17:51:43 +0800 Yi Min Zhao wrote: > 在 2017/8/29 下午5:33, Cornelia Huck 写道: > > My question was whether virtio-pci works with your patches on top at > > all - last time I checked on master, virtio-pci devices failed to > > realize with a "msi-x is mandatory" message. > > > >

Re: [Qemu-devel] [RFC] Buffers/caches in VirtIO Balloon driver stats

2017-08-29 Thread Stefan Hajnoczi
On Sun, Aug 27, 2017 at 11:30:33PM +0200, Tomáš Golembiovský wrote: > Hi, I have CCed the relevant mailing lists and people most recently involved in virtio-balloon discussions. Hopefully this will help get the right people to see your questions. > We'd like to include information about reclaima

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

2017-08-29 Thread Stefan Hajnoczi
On Fri, Aug 25, 2017 at 09:24:36AM -0700, no-re...@patchew.org wrote: > === OUTPUT BEGIN === > Checking PATCH 1/3: scripts: add argparse module for Python 2.6 > compatibility... > ERROR: trailing whitespace > #115: FILE: COPYING.PYTHON:93: > +Reserved" are retained in Python alone or in any deriva

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午5:57, Cornelia Huck 写道: On Tue, 29 Aug 2017 17:51:43 +0800 Yi Min Zhao wrote: 在 2017/8/29 下午5:33, Cornelia Huck 写道: My question was whether virtio-pci works with your patches on top at all - last time I checked on master, virtio-pci devices failed to realize with a "msi-x is m

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

2017-08-29 Thread Stefan Hajnoczi
On Fri, Aug 25, 2017 at 12:42:44PM -0500, Eric Blake wrote: > On 08/25/2017 11:40 AM, Peter Maydell wrote: > > Our choices about our dependencies are generally driven by "what > > are the versions available on the oldest distros which we wish > > to support building QEMU on", which typically is wha

Re: [Qemu-devel] wrong ioctl error handling on dirty pages sync?

2017-08-29 Thread Stefan Hajnoczi
On Fri, Aug 25, 2017 at 01:42:55PM +0200, Ján Poctavek wrote: > Hi guys, > > Maybe it is just my lack of understanding, this seems like a bug to me: > > To get list of dirty pages, qemu calls kvm_vm_ioctl() with > KVM_GET_DIRTY_LOG: > https://github.com/qemu/qemu/blob/v2.10.0-rc4/accel/kvm/kvm-al

Re: [Qemu-devel] Make NVME device "migratable" (savevm)

2017-08-29 Thread Stefan Hajnoczi
On Fri, Aug 25, 2017 at 11:39:30AM +0300, Sergei Dyshel wrote: > Hi all, > From what I understand, I can't "savevm" a VM that uses NVME device because > it has ".unmigratable = 1" in the code. What support must be implemented in > order to make it "migratable"? CCing Keith Busch, the NVMe maintain

Re: [Qemu-devel] [PATCH v11 2/6] ACPI: Add APEI GHES Table Generation support

2017-08-29 Thread Igor Mammedov
On Fri, 18 Aug 2017 22:23:43 +0800 Dongjiu Geng wrote: > This implements APEI GHES Table by passing the error CPER info > to the guest via a fw_cfg_blob. After a CPER info is recorded, an > SEA(Synchronous External Abort)/SEI(SError Interrupt) exception > will be injected into the guest OS. it's

Re: [Qemu-devel] S390 bios breaks in qemu 2.10.rc3

2017-08-29 Thread Christian Borntraeger
On 08/29/2017 11:35 AM, Thomas Huth wrote: > On 28.08.2017 09:18, Christian Borntraeger wrote: >> >> >> On 08/25/2017 10:29 AM, Cornelia Huck wrote: >>> On Fri, 25 Aug 2017 10:21:58 +0200 >>> Christian Borntraeger wrote: >>> On 08/25/2017 09:20 AM, Cornelia Huck wrote: >>> > OK, to reca

Re: [Qemu-devel] [RFC 5/6] migration: store listen task tag

2017-08-29 Thread Daniel P. Berrange
On Wed, Aug 16, 2017 at 05:47:13PM +0800, Peter Xu wrote: > On Tue, Aug 15, 2017 at 05:47:08PM +0800, Peter Xu wrote: > > On Tue, Aug 15, 2017 at 10:27:07AM +0100, Daniel P. Berrange wrote: > > > On Tue, Aug 15, 2017 at 04:50:06PM +0800, Peter Xu wrote: > > > > On Tue, Aug 15, 2017 at 09:37:14AM +0

Re: [Qemu-devel] About virtio device hotplug in Q35! 【外域邮件.谨慎查阅】

2017-08-29 Thread Bob Chen
The topology is already having all GPUs directly attached to root bus 0. In this situation you can't see the LnkSta attribute in any capabilities. The other way of using emulated switch would somehow show this attribute, at 8 GT/s, although the real bandwidth is low as usual. 2017-08-23 2:06 GMT+

Re: [Qemu-devel] [PATCH 16/26] qapi: add conditions to VNC type/commands/events on the schema

2017-08-29 Thread Daniel P. Berrange
On Thu, Aug 17, 2017 at 09:04:38AM +0200, Markus Armbruster wrote: > Copying our resident VNC maintainer^Wodd fixer Gerd. > > Also copying Dan for QCryptoCipherAlgorithm. > > Gerd, Dan, this patch is about making VNC support visible in > query-qmp-schema, by having the QAPI generators generate su

Re: [Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance

2017-08-29 Thread Fam Zheng
On Tue, 08/29 17:01, Jason Wang wrote: > > > On 2017年08月22日 15:16, no-re...@patchew.org wrote: > > Hi, > > > > This series seems to have some coding style problems. See output below for > > more information: > > > > Type: series > > Message-id: 1503305719-2512-1-git-send-email-zhangchen.f...@cn

Re: [Qemu-devel] [PATCH 16/26] qapi: add conditions to VNC type/commands/events on the schema

2017-08-29 Thread Marc-André Lureau
Hi - Original Message - > On Thu, Aug 17, 2017 at 09:04:38AM +0200, Markus Armbruster wrote: > > Copying our resident VNC maintainer^Wodd fixer Gerd. > > > > Also copying Dan for QCryptoCipherAlgorithm. > > > > Gerd, Dan, this patch is about making VNC support visible in > > query-qmp-sc

Re: [Qemu-devel] [PATCH v4] vl: exit if maxcpus is negative

2017-08-29 Thread Fam Zheng
On Tue, 08/29 11:15, Seeteena Thoufeek wrote: > ---Steps to Reproduce--- > > When passed a negative number to 'maxcpus' parameter, Qemu aborts > with a core dump. > > Run the following command with maxcpus argument as negative number > > ppc64-softmmu/qemu-system-ppc64 --nographic -vga none -mac

Re: [Qemu-devel] [PATCH v4 08/10] Makefile: Add rules to run vm tests

2017-08-29 Thread Fam Zheng
On Mon, 08/28 17:18, Philippe Mathieu-Daudé wrote: > On 08/28/2017 02:47 PM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > Reviewed-by: Stefan Hajnoczi > > --- > > Makefile | 2 ++ > > configure | 2 +- > > tests/vm/Makefile.include | 40

Re: [Qemu-devel] [PATCH for-2.11 6/6] ppc: drop caching ObjectClass from PowerPCCPUAlias

2017-08-29 Thread David Gibson
On Fri, Aug 25, 2017 at 09:49:48AM +0200, Igor Mammedov wrote: > On Fri, 25 Aug 2017 14:22:03 +1000 > David Gibson wrote: > > > On Thu, Aug 24, 2017 at 10:21:51AM +0200, Igor Mammedov wrote: > > > Caching there practically doesn't give any benefits > > > and that at slow path druring querying sup

Re: [Qemu-devel] [PATCH for-2.11 v2] hw/ppc: CAS reset on early device hotplug

2017-08-29 Thread David Gibson
On Fri, Aug 25, 2017 at 06:11:19PM -0300, Daniel Henrique Barboza wrote: > This patch is a follow up on the discussions made in patch > "hw/ppc: disable hotplug before CAS is completed" that can be > found at [1]. > > At this moment, we do not support CPU/memory hotplug in early > boot stages, bef

Re: [Qemu-devel] [Qemu-ppc] [PATCH 00/15] Sam460ex emulation

2017-08-29 Thread David Gibson
On Sun, Aug 27, 2017 at 02:34:14PM +0200, BALATON Zoltan wrote: > Hello, > > Just to confirm where we are with this series, let me summarise what I got > from the replies and what's my plan for this based on that. Here's the list > of patches for reference: > > [PATCH 01/15] ppc4xx: Move MAL from

Re: [Qemu-devel] [RFC v2 0/8] monitor: allow per-monitor thread

2017-08-29 Thread Daniel P. Berrange
On Wed, Aug 23, 2017 at 02:51:03PM +0800, Peter Xu wrote: > v2: > - fixed "make check" error that patchew reported > - moved the thread_join upper in monitor_data_destroy(), before > resources are released > - added one new patch (current patch 3) that fixes a nasty risk > condition with IOWatc

Re: [Qemu-devel] [PATCH for-2.11 v2] hw/ppc: CAS reset on early device hotplug

2017-08-29 Thread David Gibson
On Fri, Aug 25, 2017 at 06:11:18PM -0300, Daniel Henrique Barboza wrote: > v2: > - rebased with ppc-for-2.11 > - function 'spapr_cas_completed' dropped > - function 'spapr_drc_needed' made public and it's now used inside > 'spapr_hotplugged_dev_before_cas' > - 'spapr_drc_needed' was changed to su

Re: [Qemu-devel] [PATCH v2] spapr: fallback to raw mode if best compat mode cannot be set during CAS

2017-08-29 Thread David Gibson
On Thu, Aug 17, 2017 at 01:23:50PM +0200, Greg Kurz wrote: > KVM PR doesn't allow to set a compat mode. This causes ppc_set_compat_all() > to fail and we return H_HARDWARE to the guest right away. > > This is excessive: even if we favor compat mode since commit 152ef803ceb19, > we should at least

Re: [Qemu-devel] [PATCH for-2.11 2/6] ppc: make cpu_model translation to type consistent

2017-08-29 Thread David Gibson
On Fri, Aug 25, 2017 at 04:34:26PM +0200, Igor Mammedov wrote: > On Fri, 25 Aug 2017 23:28:00 +1000 > David Gibson wrote: > > > On Fri, Aug 25, 2017 at 01:40:07PM +0200, Igor Mammedov wrote: > > > On Fri, 25 Aug 2017 19:45:38 +1000 > > > David Gibson wrote: > > > > > > > On Fri, Aug 25, 2017

Re: [Qemu-devel] [PATCH 09/16] crypto: Use qapi_enum_parse() in qcrypto_block_luks_name_lookup()

2017-08-29 Thread Daniel P. Berrange
On Thu, Aug 24, 2017 at 10:46:04AM +0200, Markus Armbruster wrote: > Cc: "Daniel P. Berrange" > Signed-off-by: Markus Armbruster > --- > crypto/block-luks.c | 19 +++ > 1 file changed, 7 insertions(+), 12 deletions(-) Acked-by: Daniel P. Berrange > > diff --git a/crypto/block

Re: [Qemu-devel] [PATCH v2 3/3] hostmem-file: Add "discard-data" option

2017-08-29 Thread Daniel P. Berrange
On Thu, Aug 24, 2017 at 04:23:15PM -0300, Eduardo Habkost wrote: > The new option can be used to indicate that the file contents can > be destroyed and don't need to be flushed to disk when QEMU exits > or when the memory backend object is removed. > > Internally, it will trigger a madvise(MADV_RE

Re: [Qemu-devel] [PATCH v11 2/6] ACPI: Add APEI GHES Table Generation support

2017-08-29 Thread gengdongjiu
Igor, Thank you very much for your review and comments, I will check your comments in detail and reply to you. On 2017/8/29 18:20, Igor Mammedov wrote: > On Fri, 18 Aug 2017 22:23:43 +0800 > Dongjiu Geng wrote: > >> This implements APEI GHES Table by passing the error CPER info >> to the gue

[Qemu-devel] [Bug 1713066] Re: Incorrect handling of aarch64 ldp in some cases

2017-08-29 Thread Andrew
Yes, D1.13.4 is what I want, I'm not completely familiar with this part of the document. Based on my reading of gen_load_exclusive I agree that it looks correct, and loading to a float/vector won't affect the address generation. I have worked around this in FreeBSD my switching the order of the r

Re: [Qemu-devel] [PATCH 02/14] hvf: add code base from Google's QEMU repository

2017-08-29 Thread Daniel P. Berrange
On Sun, Aug 27, 2017 at 08:56:42PM -0500, Sergio Andres Gomez Del Real wrote: > This file begins tracking the files that will be the code base for HVF > support in QEMU. > > Signed-off-by: Sergio Andres Gomez Del Real > --- > diff --git a/target/i386/hvf-all.c b/target/i386/hvf-all.c > new file

[Qemu-devel] [PATCH v3] console: add question-mark escape operator

2017-08-29 Thread Alexander Graf
Some termcaps (found using SLES11SP1) use [? sequences. According to man console_codes (http://linux.die.net/man/4/console_codes) the question mark is a nop and should simply be ignored. This patch does exactly that, rendering screen output readable when outputting guest serial consoles to the gra

Re: [Qemu-devel] [RFC] Buffers/caches in VirtIO Balloon driver stats

2017-08-29 Thread Wei Wang
On 08/29/2017 05:57 PM, Stefan Hajnoczi wrote: On Sun, Aug 27, 2017 at 11:30:33PM +0200, Tomáš Golembiovský wrote: Hi, I have CCed the relevant mailing lists and people most recently involved in virtio-balloon discussions. Hopefully this will help get the right people to see your questions.

[Qemu-devel] [Bug 1713066] Re: Incorrect handling of aarch64 ldp in some cases

2017-08-29 Thread Peter Maydell
Richard Henderson has posted a patch which should fix this: http://patchwork.ozlabs.org/patch/806051/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1713066 Title: Incorrect handling of aarch64 ldp

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-08-29 Thread R.Nageswara Sastry
Strange, # gcc --version gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16) Copyright (C) 2015 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. OS is RHEL based. # uname -

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-29 Thread Cornelia Huck
On Mon, 28 Aug 2017 10:28:53 -0400 Farhan Ali wrote: > On 08/28/2017 10:19 AM, Halil Pasic wrote: > > > > > > On 08/28/2017 04:15 PM, Farhan Ali wrote: > >> > >> > >> On 08/28/2017 10:05 AM, Cornelia Huck wrote: > >> It's the alignment of the CCW which causes the problem. > >> > >

Re: [Qemu-devel] [PATCH v4 03/10] tests: Add vm test lib

2017-08-29 Thread Philippe Mathieu-Daudé
Hi Fam, On 08/28/2017 02:47 PM, Fam Zheng wrote: This is the common code to implement a "VM test" to 1) Download and initialize a pre-defined VM that has necessary dependencies to build QEMU and SSH access. 2) Archive $SRC_PATH to a .tar file. 3) Boot the VM, and pass the source t

[Qemu-devel] [PATCH] misc: Remove unused Error variables

2017-08-29 Thread Alberto Garcia
There's a few cases which we're passing an Error pointer to a function only to discard it immediately afterwards without checking it. In these cases we can simply remove the variable and pass NULL instead. Signed-off-by: Alberto Garcia --- block/qcow.c | 12 +++- block/qcow2.c | 8 ++--

Re: [Qemu-devel] [PATCH v4 06/10] tests: Add NetBSD image

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/28/2017 02:47 PM, Fam Zheng wrote: The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng Reviewed-by: Kamil Rytarowski --- tests/vm/netbsd | 42 ++ 1 file changed, 42 insertions(+) create

Re: [Qemu-devel] [PATCH v4 03/10] tests: Add vm test lib

2017-08-29 Thread Daniel P. Berrange
On Tue, Aug 29, 2017 at 09:06:48AM -0300, Philippe Mathieu-Daudé wrote: > Hi Fam, > > On 08/28/2017 02:47 PM, Fam Zheng wrote: > > This is the common code to implement a "VM test" to > > > >1) Download and initialize a pre-defined VM that has necessary > >dependencies to build QEMU and SS

Re: [Qemu-devel] [PATCH v4 03/10] tests: Add vm test lib

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/28/2017 02:47 PM, Fam Zheng wrote: This is the common code to implement a "VM test" to 1) Download and initialize a pre-defined VM that has necessary dependencies to build QEMU and SSH access. 2) Archive $SRC_PATH to a .tar file. 3) Boot the VM, and pass the source tar file t

Re: [Qemu-devel] [RFC for-2.10 1/3] pci/pcie: Make a consistent helper for switching PCI/PCIe "hybrid" devices

2017-08-29 Thread David Gibson
On Wed, Apr 26, 2017 at 06:23:58PM +0300, Michael S. Tsirkin wrote: > On Tue, Mar 28, 2017 at 01:16:49PM +1100, David Gibson wrote: > > virtio-pci and XHCI are "hybrid" devices in the sense that they can present > > themselves as either PCIe or plain PCI devices depending on the machine > > and bus

[Qemu-devel] [PATCH v2 0/3] nbd-client: enter read_reply_co during init to avoid crash

2017-08-29 Thread Stefan Hajnoczi
v2: * Rewrote Patch 1 following Paolo's suggestion [Paolo] See Patch 1 for the segfault fix. Patches 2 & 3 add qemu-iotests coverage. This is a rare crash that we'll probably only see in testing. It only seems to happen with UNIX domain sockets. Stefan Hajnoczi (3): nbd-client: avoid read_r

[Qemu-devel] [PATCH v2 2/3] qemu-iotests: improve nbd-fault-injector.py startup protocol

2017-08-29 Thread Stefan Hajnoczi
Currently 083 waits for the nbd-fault-injector.py server to start up by looping until netstat shows the TCP listen socket. The startup protocol can be simplified by passing a 0 port number to nbd-fault-injector.py. The kernel will allocate a port in bind(2) and the final port number can be printe

[Qemu-devel] [PATCH v2 3/3] qemu-iotests: test NBD over UNIX domain sockets in 083

2017-08-29 Thread Stefan Hajnoczi
083 only tests TCP. Some failures might be specific to UNIX domain sockets. A few adjustments are necessary: 1. Generating a port number and waiting for server startup is TCP-specific. Use the new nbd-fault-injector.py startup protocol to fetch the address. This is a little more elegant

[Qemu-devel] [PATCH v2 1/3] nbd-client: avoid read_reply_co entry if send failed

2017-08-29 Thread Stefan Hajnoczi
The following segfault is encountered if the NBD server closes the UNIX domain socket immediately after negotiation: Program terminated with signal SIGSEGV, Segmentation fault. #0 aio_co_schedule (ctx=0x0, co=0xd3c0ff2ef0) at util/async.c:441 441 QSLIST_INSERT_HEAD_ATOMIC(&ctx->schedu

Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables

2017-08-29 Thread Philippe Mathieu-Daudé
Hi Alberto, On 08/29/2017 09:08 AM, Alberto Garcia wrote: There's a few cases which we're passing an Error pointer to a function only to discard it immediately afterwards without checking it. In these cases we can simply remove the variable and pass NULL instead. How did you notice? Signed-

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-08-29 Thread Thomas Huth
Very weird, looks like SLOF crashed at a very early stage here. I've got no further clue how to debug this ... could you maybe try it on another POWER9 host if possible? Or check whether slof.bin accidentially got corrupted (md5sum pc-bios/slof.bin should give you db83598b28052e9c12972d86c37b0c69)?

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-29 Thread Farhan Ali
On 08/29/2017 08:04 AM, Cornelia Huck wrote: On Mon, 28 Aug 2017 10:28:53 -0400 Farhan Ali wrote: On 08/28/2017 10:19 AM, Halil Pasic wrote: On 08/28/2017 04:15 PM, Farhan Ali wrote: On 08/28/2017 10:05 AM, Cornelia Huck wrote: It's the alignment of the CCW which causes the problem.

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-29 Thread Cornelia Huck
On Tue, 29 Aug 2017 08:39:27 -0400 Farhan Ali wrote: > On 08/29/2017 08:04 AM, Cornelia Huck wrote: > > On Mon, 28 Aug 2017 10:28:53 -0400 > > Farhan Ali wrote: > > > >> On 08/28/2017 10:19 AM, Halil Pasic wrote: > >>> > >>> > >>> On 08/28/2017 04:15 PM, Farhan Ali wrote: > > > >

Re: [Qemu-devel] [Qemu-block] [PATCH v4 03/15] block: introduce BDRV_REQ_ALLOCATE flag

2017-08-29 Thread Alberto Garcia
On Tue 01 Aug 2017 04:19:00 PM CEST, Anton Nefedov wrote: > The flag is supposed to indicate that the region of the disk image has > to be sufficiently allocated so it reads as zeroes. The call with the flag > set has to return -ENOTSUP if allocation cannot be done efficiently > (i.e. without falli

Re: [Qemu-devel] [Qemu-block] [PATCH v4 05/15] file-posix: support BDRV_REQ_ALLOCATE

2017-08-29 Thread Alberto Garcia
On Tue 01 Aug 2017 04:19:02 PM CEST, Anton Nefedov wrote: > Current write_zeroes implementation is good enough to satisfy this flag too > > Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [RFC for-2.10 0/3] Rework handling of PCI/PCIe "hybrid" devices

2017-08-29 Thread Eduardo Habkost
On Tue, Mar 28, 2017 at 01:16:48PM +1100, David Gibson wrote: > A couple of devices - virtio-pci and XHCI - can present themselves to > the guest as either PCI or PCIe devices depending on how they're > attached. However, the logic is a little different between the two > devices. In addition the

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-08-29 Thread R.Nageswara Sastry
# md5sum ./pc-bios/slof.bin db83598b28052e9c12972d86c37b0c69 ./pc-bios/slof.bin Same as what you mentioned. Will try to get a different machine and try. If the problem still persists, I will check with Nikunj. Thanks a lot for your time. I have learned many things while interacting with you.

Re: [Qemu-devel] [Qemu-block] [PATCH v4 06/15] block: support BDRV_REQ_ALLOCATE in passthrough drivers

2017-08-29 Thread Alberto Garcia
On Tue 01 Aug 2017 04:19:03 PM CEST, Anton Nefedov wrote: > Support the flag if the underlying BDS supports it > > Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v4 03/10] tests: Add vm test lib

2017-08-29 Thread Philippe Mathieu-Daudé
Hi Fam, Kamil, On 08/28/2017 02:47 PM, Fam Zheng wrote: [...] +    subprocess.check_call([tar_cmd, +   "--exclude-vcs", +   "--exclude=tests/vm/*.img", +   "--exclude=tests/vm/*.img.*", +   

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

2017-08-29 Thread Yaniv Lavi (Dary)
YANIV LAVI (YANIV DARY) SENIOR TECHNICAL PRODUCT MANAGER Red Hat Israel Ltd. 34 Jerusalem Road, Building A, 1st floor Ra'anana, Israel 4350109 yl...@redhat.comT: +972-9-7692306/8272306 F: +972-9-7692223IM: ylavi TRIED. TESTED. TRUSTED

Re: [Qemu-devel] [PATCH v2 3/3] hostmem-file: Add "discard-data" option

2017-08-29 Thread Eduardo Habkost
On Tue, Aug 29, 2017 at 12:13:45PM +0100, Daniel P. Berrange wrote: > On Thu, Aug 24, 2017 at 04:23:15PM -0300, Eduardo Habkost wrote: > > The new option can be used to indicate that the file contents can > > be destroyed and don't need to be flushed to disk when QEMU exits > > or when the memory b

Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables

2017-08-29 Thread Alberto Garcia
On Tue 29 Aug 2017 02:31:35 PM CEST, Philippe Mathieu-Daudé wrote: >> There's a few cases which we're passing an Error pointer to a function >> only to discard it immediately afterwards without checking it. In >> these cases we can simply remove the variable and pass NULL instead. > > How did you

Re: [Qemu-devel] [PATCH v4 03/10] tests: Add vm test lib

2017-08-29 Thread Kamil Rytarowski
On 29.08.2017 15:10, Philippe Mathieu-Daudé wrote: > Hi Fam, Kamil, > >> On 08/28/2017 02:47 PM, Fam Zheng wrote: > [...] >>> +subprocess.check_call([tar_cmd, >>> + "--exclude-vcs", >>> + "--exclude=tests/vm/*.img", >>> +

Re: [Qemu-devel] [PATCH v4 03/10] tests: Add vm test lib

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/29/2017 10:22 AM, Kamil Rytarowski wrote: On 29.08.2017 15:10, Philippe Mathieu-Daudé wrote: Hi Fam, Kamil, On 08/28/2017 02:47 PM, Fam Zheng wrote: [...] +subprocess.check_call([tar_cmd, + "--exclude-vcs", + "--exclud

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-08-29 Thread R.Nageswara Sastry
On other machine with same OS and gcc level, it's working fine. Not getting what went wrong in the machine where I can re-produce this issue. I guess this bug can be closed. Thank you. /ppc64/prom-env/pseries: SLOF ** QEMU Sta

  1   2   3   >