Re: [Qemu-devel] [PATCH v2 00/16] qapi-schema: Reorganize along maintenance boundaries

2017-08-24 Thread Eric Blake
On 08/24/2017 02:13 PM, Markus Armbruster wrote: > Cc: "Daniel P. Berrange" > Cc: Alberto Garcia > Cc: Dr. David Alan Gilbert > Cc: Gerd Hoffmann > Cc: Jason Wang > Cc: Juan Quintela > Cc: Marc-André Lureau > Cc: Paolo Bonzini > > Much of the QAPI schema really belongs to a subsystem, but

[Qemu-devel] [RFC v2 21/32] postcopy: postcopy_notify_shared_wake

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add a hook to allow a client userfaultfd to be 'woken' when a page arrives, and a walker that calls that hook for relevant clients given a RAMBlock and offset. Signed-off-by: Dr. David Alan Gilbert --- migration/postcopy-ram.c | 16 migration/pos

Re: [Qemu-devel] S390 bios breaks in qemu 2.10.rc3

2017-08-24 Thread Farhan Ali
On 08/24/2017 02:33 PM, Christian Borntraeger wrote: Just to understand the urgency. Is the problem happening with the BIOS that is shipped in the upstream git tree, or a self-built one? The bios image upstream works fine, but if someone tries to recompile the bios and use that, it breaks.

Re: [Qemu-devel] [PATCH 13/15] ppc4xx: Add more PLB registers

2017-08-24 Thread BALATON Zoltan
On Thu, 24 Aug 2017, David Gibson wrote: On Wed, Aug 23, 2017 at 12:16:24PM +0200, BALATON Zoltan wrote: On Wed, 23 Aug 2017, David Gibson wrote: On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: These registers are present in 440 SoCs (and maybe in others too) and U-Boot accesse

Re: [Qemu-devel] [Qemu-arm] [PATCH 4/8] boards.h: Define new flag ignore_memory_transaction_failures

2017-08-24 Thread Richard Henderson
On 22 August 2017 at 09:36, Peter Maydell wrote: > On 22 August 2017 at 04:45, Philippe Mathieu-Daudé wrote: >> If we are worried about being backward compatible, defaulting background >> region to unimp() won't throw any transaction error. > > As I said, it will, for the cases of device model di

Re: [Qemu-devel] Make test

2017-08-24 Thread Cleber Rosa
On 08/24/2017 03:10 PM, Programmingkid wrote: > I think 'make test' is an abandoned testing option for QEMU so this report > might be unimportant. Here is my results for running 'make test': > > $ make test > make -C tests/tcg test > LINKtest_path > Undefined symbols for architecture x86_

Re: [Qemu-devel] [PATCH v7 6/6] qemu-iotests: add 184 for throttle filter driver

2017-08-24 Thread Manos Pitsidianakis
On Thu, Aug 24, 2017 at 07:43:08PM +0100, Stefan Hajnoczi wrote: On Tue, Aug 22, 2017 at 01:15:35PM +0300, Manos Pitsidianakis wrote: +_supported_fmt qcow2 What makes this test qcow2-specific? With additional filtering for IMGFMT it should be possible to run this on any image format. I thin

Re: [Qemu-devel] [PATCH 15/15] ppc: Add aCube Sam460ex board

2017-08-24 Thread BALATON Zoltan
On Thu, 24 Aug 2017, David Gibson wrote: On Wed, Aug 23, 2017 at 01:12:06PM +0200, BALATON Zoltan wrote: On Wed, 23 Aug 2017, David Gibson wrote: On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: Add emulation of aCube Sam460ex board based on AMCC 460EX embedded SoC. This is not

Re: [Qemu-devel] [PATCH 15/15] ppc: Add aCube Sam460ex board

2017-08-24 Thread BALATON Zoltan
On Thu, 24 Aug 2017, David Gibson wrote: On Wed, Aug 23, 2017 at 01:43:56PM +0200, François Revol wrote: Le 23/08/2017 à 13:12, BALATON Zoltan a écrit : What's the connection with mips_malta? The board's firmware wants to see SPD EEPROMs of the connected memory while initialising the memory c

Re: [Qemu-devel] Make test

2017-08-24 Thread Programmingkid
> On Aug 24, 2017, at 4:41 PM, Cleber Rosa wrote: > > > > On 08/24/2017 03:10 PM, Programmingkid wrote: >> I think 'make test' is an abandoned testing option for QEMU so this report >> might be unimportant. Here is my results for running 'make test': >> >> $ make test >> make -C tests/tcg te

Re: [Qemu-devel] [PATCH 10/15] ppc440: Add emulation of plb-pcix controller found in some 440 SoCs

2017-08-24 Thread BALATON Zoltan
On Sun, 20 Aug 2017, Philippe Mathieu-Daudé wrote: Hi Zoltan, Hello, Thanks for the review and comments. On 08/20/2017 02:23 PM, BALATON Zoltan wrote: This is the PCIX controller found in newer 440 core SoCs e.g. the AMMC 460EX. The device tree refers to this as plb-pcix compared to the plb

Re: [Qemu-devel] Make test

2017-08-24 Thread Cleber Rosa
On 08/24/2017 05:50 PM, Programmingkid wrote: > > Thank you for the patches. I will test them. I was wondering what is the > point to having both 'make check' and 'make test'. It looks like everyone is > using 'make check'. Maybe we are better off removing the 'make test' target. > I think t

Re: [Qemu-devel] Make test

2017-08-24 Thread Programmingkid
> On Aug 24, 2017, at 4:41 PM, Cleber Rosa wrote: > > > > On 08/24/2017 03:10 PM, Programmingkid wrote: >> I think 'make test' is an abandoned testing option for QEMU so this report >> might be unimportant. Here is my results for running 'make test': >> >> $ make test >> make -C tests/tcg te

Re: [Qemu-devel] Make test

2017-08-24 Thread Cleber Rosa
On 08/24/2017 06:18 PM, Programmingkid wrote: > After applying the patches I saw this error: > > $ make test > make -C tests/tcg test > CC test_path.o > LINKtest_path > ./test_path > cc -m32 -nostdlib -Wall -O2 -g -fno-strict-aliasing -static -o hello-i386 > hello-i386.c > hello-i

Re: [Qemu-devel] Make test

2017-08-24 Thread Programmingkid
> On Aug 24, 2017, at 6:21 PM, Cleber Rosa wrote: > > > > On 08/24/2017 06:18 PM, Programmingkid wrote: >> After applying the patches I saw this error: >> >> $ make test >> make -C tests/tcg test >> CC test_path.o >> LINKtest_path >> ./test_path >> cc -m32 -nostdlib -Wall -O2 -g -f

Re: [Qemu-devel] [PATCH v6 01/10] qemu.py: Pylint/style fixes

2017-08-24 Thread Cleber Rosa
On 08/18/2017 10:26 AM, Lukáš Doktor wrote: > No actual code changes, just several pylint/style fixes and docstring > clarifications. > > Signed-off-by: Lukáš Doktor > Reviewed-by: Stefan Hajnoczi > --- > scripts/qemu.py | 73 > +++-- > 1 f

Re: [Qemu-devel] [PATCH v6 02/10] qemu|qtest: Avoid dangerous arguments

2017-08-24 Thread Cleber Rosa
On 08/18/2017 10:26 AM, Lukáš Doktor wrote: > The list object is mutable in python and potentially might modify other > object's arguments when used as default argument. Reproducer: > > >>> vm1 = QEMUMachine("qemu") > >>> vm2 = QEMUMachine("qemu") > >>> vm1._wrapper.append("foo") >

Re: [Qemu-devel] [PATCH v6 03/10] qemu.py: Use iteritems rather than keys()

2017-08-24 Thread Cleber Rosa
On 08/18/2017 10:26 AM, Lukáš Doktor wrote: > Let's avoid creating an in-memory list of keys and query for each value > and use `iteritems` which is an iterator of key-value pairs. > > Signed-off-by: Lukáš Doktor > Reviewed-by: Eduardo Habkost > Reviewed-by: Philippe Mathieu-Daudé > --- > sc

Re: [Qemu-devel] [PATCH v6 04/10] qemu.py: Simplify QMP key-conversion

2017-08-24 Thread Cleber Rosa
On 08/18/2017 10:26 AM, Lukáš Doktor wrote: > The QMP key conversion consist of '_'s to be replaced with '-'s, which > can easily be done by a single `str.replace` method which is faster and > does not require `string` module import. > > Signed-off-by: Lukáš Doktor > Reviewed-by: Eduardo Habkos

Re: [Qemu-devel] [RFC v2 01/32] vhu: vu_queue_started

2017-08-24 Thread Marc-André Lureau
Hi On Thu, Aug 24, 2017 at 9:39 PM Dr. David Alan Gilbert (git) < dgilb...@redhat.com> wrote: > From: "Dr. David Alan Gilbert" > > Add a vu_queue_started method to complement vu_queue_enabled. > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Marc-André Lureau > --- > contrib/libvh

Re: [Qemu-devel] A use-after-free in slirp

2017-08-24 Thread Samuel Thibault
Hello, Thanks for the reproducer you sent me offline. Here is a fix which makes a lot of sense and fixes the reproducer. Could you try it with your whole testcase? Could somebody also review the patch? Samuel commit 1a3a763509fad895c907e6978ea034a5c19ee370 Author: Samuel Thibault Date: Fri

Re: [Qemu-devel] [PATCH 15/15] ppc: Add aCube Sam460ex board

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 11:43:18PM +0200, BALATON Zoltan wrote: > On Thu, 24 Aug 2017, David Gibson wrote: > > On Wed, Aug 23, 2017 at 01:43:56PM +0200, François Revol wrote: > > > Le 23/08/2017 à 13:12, BALATON Zoltan a écrit : > > > > > What's the connection with mips_malta? > > > > > > > > The

Re: [Qemu-devel] [PATCH 15/15] ppc: Add aCube Sam460ex board

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 11:37:09PM +0200, BALATON Zoltan wrote: > On Thu, 24 Aug 2017, David Gibson wrote: > > On Wed, Aug 23, 2017 at 01:12:06PM +0200, BALATON Zoltan wrote: > > > On Wed, 23 Aug 2017, David Gibson wrote: > > > > On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: > > >

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

2017-08-24 Thread John Snow
Sorry in advance for :words: ... On 08/23/2017 02:04 PM, Vladimir Sementsov-Ogievskiy wrote: > 23.08.2017 11:59, Vladimir Sementsov-Ogievskiy wrote: >> 22.08.2017 22:07, John Snow wrote: >>> Well, we knew we'd want this sooner or later. I've got some pings >>> downstream over whether or not we sup

[Qemu-devel] [Bug 1712818] Re: live migration with storage encounter assert(!(bs->open_flags & BDRV_O_INACTIVE)) crashes

2017-08-24 Thread meeho yuen
Thank you,I will try it. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1712818 Title: live migration with storage encounter assert(!(bs->open_flags & BDRV_O_INACTIVE)) crashes Status in QEMU:

Re: [Qemu-devel] [PATCH QEMU v4] xen/pt: allow QEMU to request MSI unmasking at bind time

2017-08-24 Thread Stefano Stabellini
On Thu, 24 Aug 2017, Roger Pau Monne wrote: > When a MSI interrupt is bound to a guest using > xc_domain_update_msi_irq (XEN_DOMCTL_bind_pt_irq) the interrupt is > left masked by default. > > This causes problems with guests that first configure interrupts and > clean the per-entry MSIX table mask

[Qemu-devel] [QGA] Bug of qga?

2017-08-24 Thread Sam
Hi all, I'm using qga to send `route -n` and `ping` command to guest. But I found SOMETIMES, the second `ping` command's result is the same as `route -n` command. So I guess is there some cache mechanism of qga command result? So when I send the second command, and receive from qga socket, I rece

Re: [Qemu-devel] [PATCH for-2.11 1/6] ppc: use macros to make cpu type name from string literal

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 10:21:46AM +0200, Igor Mammedov wrote: > Replace > "-" TYPE_POWERPC_CPU > when composing cpu type name from cpu model string literal > and the same pattern in format strings with > POWERPC_CPU_TYPE_SUFFIX and POWERPC_CPU_TYPE_NAME(model) > macroses like we do in x86. > >

Re: [Qemu-devel] [PATCH for-2.11 3/6] ppc: make cpu alias point only to real cpu models

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 10:21:48AM +0200, Igor Mammedov wrote: > alias pointing to another alias forces lookup code to > do recurrsive translation till real cpu model is reached. > > Drop this nonsence and make each alias point to cpu model > that has corresponding CPU type. It will allow to drop

Re: [Qemu-devel] [PATCH for-2.11 2/6] ppc: make cpu_model translation to type consistent

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 10:21:47AM +0200, Igor Mammedov wrote: > PPC handles -cpu FOO rather incosistently, > i.e. it does case-insensitive matching of FOO to > a CPU type (see: ppc_cpu_compare_class_name) but > handles alias names as case-sensitive, as result: > > # qemu-system-ppc64 -M mac99 -c

Re: [Qemu-devel] A use-after-free in slirp

2017-08-24 Thread Philippe Mathieu-Daudé
Hi Samuel, On 08/24/2017 08:42 PM, Samuel Thibault wrote: Hello, Thanks for the reproducer you sent me offline. Here is a fix which makes a lot of sense and fixes the reproducer. Could you try it with your whole testcase? Could somebody also review the patch? Your patch looks correct. It

Re: [Qemu-devel] [QGA] Bug of qga?

2017-08-24 Thread Sam
Also I found: when I use `socat` to take a qga socket, then I use `socat` to communicate it will got error. But also SOMETIMES, I will not got error and will communicate OK. If one user take qga socket, another user should got error, is it? But why sometimes, the communicate is OK? 2017-08-25 10

[Qemu-devel] [PATCH qemu] pci: Initialize pci_dev->name before use

2017-08-24 Thread Alexey Kardashevskiy
This moves pci_dev->name initialization earlier so pci_dev->bus_master_as could get a name instead of empry string. Signed-off-by: Alexey Kardashevskiy --- hw/pci/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 258fbe51e2..852babe812 10

[Qemu-devel] [Bug 1712818] Re: live migration with storage encounter assert(!(bs->open_flags & BDRV_O_INACTIVE)) crashes

2017-08-24 Thread meeho yuen
hi,eblake,the problem still exists on qemu 2.10_rc4,although the possibility is less than before. kvm: block/io.c:1543: bdrv_co_pwritev: Assertion `!(bs->open_flags & 0x0800)' failed. 2017-08-25 11:08:18.963+: shutting down, reason=crashed -- You received this bug notification because you

Re: [Qemu-devel] [PATCH for-2.11 6/6] ppc: drop caching ObjectClass from PowerPCCPUAlias

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 10:21:51AM +0200, Igor Mammedov wrote: > Caching there practically doesn't give any benefits > and that at slow path druring querying supported CPU list. > But it introduces non conventional path of where from > comes used CPU type name (kvm_ppc_register_host_cpu_type). > >

Re: [Qemu-devel] [PATCH for-2.11 5/6] ppc: simplify cpu model lookup by PVR

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 10:21:50AM +0200, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > target/ppc/translate_init.c | 27 +++ > 1 file changed, 11 insertions(+), 16 deletions(-) > > diff --git a/target/ppc/translate_init.c b/target/ppc/translate_init.c > ind

Re: [Qemu-devel] [PATCH for-2.11 4/6] ppc: replace inter-function cyclic dependency/recurssion with 2 simple lookups

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 10:21:49AM +0200, Igor Mammedov wrote: > previous patches cleaned up cpu model/alias naming which > allows to simplify cpu model/alias to cpu type lookup a bit > byt removing recurssion and dependency of ppc_cpu_class_by_name() / > ppc_cpu_class_by_alias() on each other. > B

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

2017-08-24 Thread Peter Xu
On Wed, Aug 23, 2017 at 06:35:35PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Firstly, introduce Monitor.use_thread, and set it for monitors that are > > using non-mux typed backend chardev. We only do this for monitors, so > > mux-typed chardevs are not suita

Re: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 11:11:22AM -0700, Ram Pai wrote: > On Thu, Aug 24, 2017 at 12:54:48PM +1000, Paul Mackerras wrote: > > On Mon, Aug 21, 2017 at 05:00:36PM -0300, Thiago Jung Bauermann wrote: > > > LoPAPR says: > > > > > > “ibm,processor-storage-keys” > > > > > > property name indic

Re: [Qemu-devel] [PATCH v2 00/16] qapi-schema: Reorganize along maintenance boundaries

2017-08-24 Thread Markus Armbruster
Eric Blake writes: > On 08/24/2017 02:13 PM, Markus Armbruster wrote: >> Cc: "Daniel P. Berrange" >> Cc: Alberto Garcia >> Cc: Dr. David Alan Gilbert >> Cc: Gerd Hoffmann >> Cc: Jason Wang >> Cc: Juan Quintela >> Cc: Marc-André Lureau >> Cc: Paolo Bonzini >> >> Much of the QAPI schema re

Re: [Qemu-devel] [PATCH 13/15] ppc4xx: Add more PLB registers

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 10:28:15PM +0200, BALATON Zoltan wrote: > On Thu, 24 Aug 2017, David Gibson wrote: > > On Wed, Aug 23, 2017 at 12:16:24PM +0200, BALATON Zoltan wrote: > > > On Wed, 23 Aug 2017, David Gibson wrote: > > > > On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: > > >

Re: [Qemu-devel] Structure / order of generated QAPI/QMP docs

2017-08-24 Thread Markus Armbruster
Markus Armbruster writes: > We've split sub-schemas off qapi-schema.json to enable proper > MAINTAINERS coverage, and also because the complete schema has become > rather large. > > The reference documentation generated with qapi2texi.py is in textual > schema order, with included sub-schemas ins

Re: [Qemu-devel] [RFC v2 4/8] QAPI: new QMP command option "without-bql"

2017-08-24 Thread Peter Xu
On Wed, Aug 23, 2017 at 06:44:12PM +0100, Dr. David Alan Gilbert wrote: [...] > > +Most of the commands require the Big QEMU Lock (BQL) be held during > > +execution. However, there is a small subset of the commands that may > > +not really need BQL at all. To mark out this kind of commands, we

Re: [Qemu-devel] [RFC v2 4/8] QAPI: new QMP command option "without-bql"

2017-08-24 Thread Peter Xu
On Thu, Aug 24, 2017 at 07:37:32AM +0800, Fam Zheng wrote: > On Wed, 08/23 18:44, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > Introducing this new parameter for QMP commands in general to mark out > > > when the command does not need BQL. Normally QMP command exec

Re: [Qemu-devel] [RFC v2 5/8] hmp: support "without_bql"

2017-08-24 Thread Peter Xu
On Wed, Aug 23, 2017 at 06:46:29PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Introducing new option "without_bql" for HMP commands. It works just > > like QMP "without-bql", but for HMP commands. > > > > Signed-off-by: Peter Xu > > It's going to be interes

Re: [Qemu-devel] Make test

2017-08-24 Thread Thomas Huth
On 25.08.2017 00:16, Cleber Rosa wrote: > > On 08/24/2017 05:50 PM, Programmingkid wrote: >> >> Thank you for the patches. I will test them. I was wondering what is the >> point to having both 'make check' and 'make test'. It looks like everyone is >> using 'make check'. Maybe we are better off

Re: [Qemu-devel] [RFC v2 8/8] migration: add incoming mgmt lock

2017-08-24 Thread Peter Xu
On Wed, Aug 23, 2017 at 07:01:35PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Now at least migrate_incoming can be run in parallel. Let's provide a > > migration lock to protect it. > > > > Signed-off-by: Peter Xu > > --- > > migration/migration.c | 6 +

Re: [Qemu-devel] [PATCH 01/14] qdict: add qdict_put_null() helper

2017-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > A step towards completeness. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 02/14] qlit: move qlit from check-qjson to qobject/

2017-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > Fix code style issues while at it, to please check-patch. It's spelled checkpatch. Can touch up on commit. > Signed-off-by: Marc-André Lureau > --- > include/qapi/qmp/qlit.h | 49 + > qobject/qlit.c | 89 +++

Re: [Qemu-devel] [PATCH v2 01/54] qapi: fix type_seen key error

2017-08-24 Thread Markus Armbruster
Conflicts with Eduardo's "[PATCH v2] qapi: Fix error handling code on alternate conflict". Message-Id: <20170717180926.14924-1-ehabk...@redhat.com> Marc-André, could you have a look? You can rebase your fix on top of Eduardo's, or merge the two into one commit. Marc-André Lureau writes: > The

Re: [Qemu-devel] [PATCH 03/14] qlit: use QLit prefix consistently

2017-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > Rename from LiteralQ to QLit. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 04/14] qlit: remove needless type cast

2017-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > And misc code style fix. > > Signed-off-by: Marc-André Lureau > --- > include/qapi/qmp/qlit.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h > index f36bca4554..1e9696988a 100644 > --

Re: [Qemu-devel] [PATCH qemu v4 2/3] vfio/spapr: Add a notifier for PPC64 HV/PR KVM about new group attached to LIOBN

2017-08-24 Thread David Gibson
On Thu, Jul 20, 2017 at 05:22:30PM +1000, Alexey Kardashevskiy wrote: > This implements a notification for a new IOMMU group attached to > sPAPR's logical IO bus (LIOBN) to enable in-kernel TCE acceleration. > > This extends the TYPE_SPAPR_IOMMU_MEMORY_REGION class with a get_fd() > callback which

[Qemu-devel] Why got no response of vnc?

2017-08-24 Thread Sam
Hi all, I'm starting vm using: kvm]$ sudo /usr/local/bin/qemu-system-x86_64 -m 256 -hda test.qcow2 -cdrom > CentOS-7-x86_64-DVD-1503-01.iso -boot d > VNC server running on '127.0.0.1:5900' then I start vnc client in another PC to connect 10.253.23.24:11800 and 10.253.23.24:5900, I got time out,

Re: [Qemu-devel] [PATCH 05/14] qlit: rename compare_litqobj_to_qobj

2017-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > Use qlit_ prefix. Let's spell it out: qlit: rename compare_litqobj_to_qobj() to qlit_equal_qobject() By the way, not only is your name shorter, it's also more precise: "compare" suggests -1, 0, +1 for less than, equal and greater than, equal suggests non-zero f

Re: [Qemu-devel] [PATCH 05/14] qlit: rename compare_litqobj_to_qobj

2017-08-24 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Use qlit_ prefix. > > Let's spell it out: > > qlit: rename compare_litqobj_to_qobj() to qlit_equal_qobject() > > By the way, not only is your name shorter, it's also more precise: > "compare" suggests -1, 0, +1 for less than, equal

Re: [Qemu-devel] Why got no response of vnc?

2017-08-24 Thread Sam
I follow this: https://en.wikibooks.org/wiki/QEMU/QEMU_Hello_World:_Installing_QEMU_and_getting_it_up_and_running 2017-08-25 14:31 GMT+08:00 Sam : > Hi all, > > I'm starting vm using: > > kvm]$ sudo /usr/local/bin/qemu-system-x86_64 -m 256 -hda test.qcow2 >> -cdrom CentOS-7-x86_64-DVD-1503-01.iso

Re: [Qemu-devel] [PATCH 06/14] qlit: make qlit_equal_qobject return a bool

2017-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > Make it more obvious about the expected return values. > > Signed-off-by: Marc-André Lureau > --- > include/qapi/qmp/qlit.h | 2 +- > qobject/qlit.c | 18 +- > tests/check-qjson.c | 14 +++--- > 3 files changed, 17 insertions(+),

Re: [Qemu-devel] [PATCH 07/14] qlit: make qlit_equal_qobject() take const arguments

2017-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > Signed-off-by: Marc-André Lureau > --- > include/qapi/qmp/qlit.h | 2 +- > qobject/qlit.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h > index 2e22d0f73c..8882016199 100644 > --

Re: [Qemu-devel] [PATCH 08/14] qlit: add QLIT_QNULL and QLIT_BOOL

2017-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > As they are going to be used in the following patches. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

<    1   2   3   4