On Thu, 24 Aug 2017 13:20:12 +0800
Yi Min Zhao wrote:
> Why can't I receive [Qemu-devel] prefixed patches?
>
>
> 在 2017/8/23 下午3:26, Yi Min Zhao 写道:
> > This patch set contains four small zpci patches to fixup different issues.
> > 1) fixup calculation of msix boundary
> > 2) remove zpci idx fr
Alberto Garcia writes:
> On Mon 07 Aug 2017 04:45:35 PM CEST, Markus Armbruster wrote:
>> Sizes and byte rates should use QAPI type 'size' (uint64_t).
>> BlockIOThrottle and BlockDeviceInfo members @bps, @bps_rd, @bps_wr,
>> @bps_max, @bps_rd_max, @bps_wr_max, @iops_size are 'int' (int64_t).
>> q
On 08/23/2017 05:54 PM, Cornelia Huck wrote:
> Some non-pci code calls into zpci code. Provide some stubs for builds
> without pci.
>
> Reviewed-by: Thomas Huth
> Signed-off-by: Cornelia Huck
> ---
> hw/s390x/Makefile.objs | 3 +-
> hw/s390x/s390-pci-stub.c | 74
>
Trying to add a spapr-nvram device currently aborts QEMU like this:
$ ppc64-softmmu/qemu-system-ppc64 -device spapr-nvram
qemu-system-ppc64: hw/ppc/spapr_rtas.c:407: spapr_rtas_register:
Assertion `!rtas_table[token].name' failed.
Aborted (core dumped)
This NVRAM device registers RTAS calls dur
Trying to add a spapr-nvram device currently aborts QEMU like this:
$ ppc64-softmmu/qemu-system-ppc64 -device spapr-nvram
qemu-system-ppc64: hw/ppc/spapr_rtas.c:407: spapr_rtas_register:
Assertion `!rtas_table[token].name' failed.
Aborted (core dumped)
This NVRAM device registers RTAS calls dur
Paolo Bonzini writes:
> On 23/08/2017 23:30, Eric Blake wrote:
>>> Well, whatever is assigning to global_qtest should be using the long form.
>> Question - what about going the other way, and switching ALL callers to
>> always use the explicit form? I'd really like to maintain only one
>> form,
On 08/24/2017 09:38 AM, Christian Borntraeger wrote:
>
>
> On 08/23/2017 05:54 PM, Cornelia Huck wrote:
>> Some non-pci code calls into zpci code. Provide some stubs for builds
>> without pci.
>>
>> Reviewed-by: Thomas Huth
>> Signed-off-by: Cornelia Huck
>> ---
>> hw/s390x/Makefile.objs |
The scratch/ (TEST_DIR) directory is not automatically cleaned up after
test execution. It is the responsibility of tests to remove any files
they create.
A nice way of doing this is to declare files at the beginning of the
test and automatically remove them with a context manager:
with iotest
There are a number of ways to ensure that the QEMU process is shut down
when the test ends, including atexit.register(), try: finally:, or
unittest.teardown() methods. All of these require extra code and the
programmer must remember to add vm.shutdown().
A nice solution is context managers:
wi
Switch from atexit.register() to a more elegant idiom of declaring
resources in a with statement:
with FilePath('monitor.sock') as monitor_path,
VM() as vm:
...
The files and VMs will be automatically cleaned up whether the test
passes or fails.
Signed-off-by: Stefan Hajnoczi
---
This series introduces context managers for the two most commonly used
resources: files and VMs. Context managers eliminate the need to call a
cleanup function explicitly.
Tests should declare resources upfront in a with statement. Resources are
automatically cleaned up whether the test passes o
As there are only minor things left,
whole series
Acked-by: Christian Borntraeger
On 08/23/2017 05:54 PM, Cornelia Huck wrote:
> Hopefully should be close now...
>
> v4->v5:
> - dropped "s390x/kvm: msi route fixup for non-pci"
> - reworked "s390x/sclp: properly guard pci-specific functions":
Eric Blake writes:
> On 08/22/2017 06:19 AM, Halil Pasic wrote:
>
>> OTOH I do think this is to some degree institutionalizing a bad practice
>> (you say we do not want to do that, but IMHO refusing to build with
>> NDEBUG makes only sense if we want to alter the semantic of assert so
>> that onc
On 08/22/2017 04:46 PM, Wang yong wrote:
From: Wang Yong
Remove the task which check old packet in the comparing thread,
then use IOthread context timer to handle it.
Process pactkets in the IOThread which arrived over the socket.
we use iothread_get_g_main_context to create a new g_main_loo
Signed-off-by: Gerd Hoffmann
---
hw/display/qxl-render.c | 33 ++---
1 file changed, 26 insertions(+), 7 deletions(-)
diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c
index e1b3f05ecb..b2c98f90c0 100644
--- a/hw/display/qxl-render.c
+++ b/hw/display/qxl-
This series adds support for unpacking qxl chunks, and uses it to
support chunked cursor images. Windows guest drivers seem to use
that when in HiDPI mode.
Also drop (broken) support for mono cursors.
Gerd Hoffmann (2):
qxl: drop mono cursor support
qxl: add support for chunked cursors.
hw
The chunk size sanity check in qxl_render_cursor works for
SPICE_CURSOR_TYPE_ALPHA cursors only. So support for
SPICE_CURSOR_TYPE_MONO cursors must be broken for ages without anyone
noticing. Most likely it simply isn't used any more by guest drivers.
Drop the dead code.
Signed-off-by: Gerd Hoff
On Wed, 2017-08-23 at 20:37 +0100, Matt Parker wrote:
> + intel_hda_reg_write(d, reg, val, (1UL << (size * 8)) - 1);
Hmm? Same as v1, forgot to commit the changes?
cheers,
Gerd
Replace
"-" TYPE_POWERPC_CPU
when composing cpu type name from cpu model string literal
and the same pattern in format strings with
POWERPC_CPU_TYPE_SUFFIX and POWERPC_CPU_TYPE_NAME(model)
macroses like we do in x86.
Later POWERPC_CPU_TYPE_NAME() will be used to define default
cpu type per mach
While removing cpu_init() tree-wide, I've stumbled uppon
PPC way of parsing cpu_model which looked way too complex
compared to other targets.
So here goes cleanups that instead of current inconsistent
way of dealing with cpu models
- mix of case-(in)sensetive lookups and cpu model names
- aliase
Caching there practically doesn't give any benefits
and that at slow path druring querying supported CPU list.
But it introduces non conventional path of where from
comes used CPU type name (kvm_ppc_register_host_cpu_type).
Taking in account that kvm_ppc_register_host_cpu_type()
fixes up models th
alias pointing to another alias forces lookup code to
do recurrsive translation till real cpu model is reached.
Drop this nonsence and make each alias point to cpu model
that has corresponding CPU type. It will allow to drop
recurrsion in cpu model translation code and actually
make ppc_cpu_aliase
previous patches cleaned up cpu model/alias naming which
allows to simplify cpu model/alias to cpu type lookup a bit
byt removing recurssion and dependency of ppc_cpu_class_by_name() /
ppc_cpu_class_by_alias() on each other.
Besides of simplifying code it reduces it by ~15LOC.
Signed-off-by: Igor
PPC handles -cpu FOO rather incosistently,
i.e. it does case-insensitive matching of FOO to
a CPU type (see: ppc_cpu_compare_class_name) but
handles alias names as case-sensitive, as result:
# qemu-system-ppc64 -M mac99 -cpu g3
qemu-system-ppc64: unable to find CPU model ' kN�U'
# qemu-system-
Signed-off-by: Igor Mammedov
---
target/ppc/translate_init.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/target/ppc/translate_init.c b/target/ppc/translate_init.c
index f1a559d..ca9f1e3 100644
--- a/target/ppc/translate_init.c
+++ b/target/ppc
On Wed, 23 Aug 2017 18:25:05 +0200
Pierre Morel wrote:
> On 23/08/2017 17:54, Cornelia Huck wrote:
> > If we do not provide zpci, pci reconfiguration via sclp is not available
> > either. I/O adapter configuration, however, should always be present.
> >
> > Rename the values that refer to I/O ad
On Thu, 24 Aug 2017 03:13:46 +0200
Thomas Huth wrote:
> On 23.08.2017 17:54, Cornelia Huck wrote:
> > The msi routing code in kvm calls some pci functions: provide
> > some stubs to enable builds without pci.
> >
> > Also, to make this more obvious, guard them via a pci_available boolean
> > (wh
On Thu, 08/24 08:21, Stefan Hajnoczi wrote:
> Tests should declare resources upfront in a with statement. Resources are
> automatically cleaned up whether the test passes or fails:
>
> with FilePath('test.img') as img_path,
>VM() as vm:
> ...test...
> # img_path is deleted and v
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20170824081305.8445-1-kra...@redhat.com
Subject: [Qemu-devel] [PATCH 0/2] qxl: add support for chunked cursors.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(g
Signed-off-by: Markus Armbruster
---
qapi/qapi-visit-core.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c
index ed6d2af..ec83ff6 100644
--- a/qapi/qapi-visit-core.c
+++ b/qapi/qapi-visit-core.c
@@ -14,6 +14,7 @@
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Message-Id: <20170822132255.23945-12-marcandre.lur...@redhat.com>
Reviewed-by: Markus Armbruster
[Rebased, qemu_opt_get() factored out, commit message tweaked]
Cc: Alberto Garcia
Reviewed-by: Alberto Garcia
Signed-off-by: Markus Armbrus
The next commit will put it to use. May look pointless now, but we're
going to change the FOO_lookup's type, and then it'll help.
Signed-off-by: Markus Armbruster
---
block.c | 1 -
block/blkdebug.c | 1 -
block/file-posix.c | 1 -
block/file-win32.c
The purpose of this work is to make holes in QAPI enumerations
possible.
Why holes? Because we want to be able to suppress enumeration
constants with #if. Holes could be avoided, e.g. by letting the
compiler assign the values. Falls apart when the conditions are
target-specific, because then ta
We have a strict separation between enum TpmModel and tpm_models[]:
* TpmModel may have any number of members. It just happens to have one.
* tpm_register_model() uses the first empty slot in tmp_models[].
If you register more than tpm_models[] has space,
tpn_register_model() fails. Its ca
Currently, the FOO_lookup[] generated for QAPI enum types are
terminated by a NULL sentinel.
A future patch will generate enums with "holes". NULL-termination
will cease to work then.
To prepare for that, replace "have we reached the sentinel?"
predicates by "have we reached the FOO__MAX value?"
From: Marc-André Lureau
We have a strict separation between enum TpmType and be_drivers[]:
* TpmType may have any number of members. It just happens to have one.
* tpm_register_driver() uses the first empty slot in be_drivers[].
If you register more than tpm_models[] has space,
tpm_regist
From: Marc-André Lureau
The error message on invalid blkdebug events changes from
qemu-system-x86_64: LOCATION: Invalid event name "VALUE"
to
qemu-system-x86_64: LOCATION: invalid parameter value: VALUE
Slight degradation, but the message is sub-par even before the patch.
When complai
From: Marc-André Lureau
Now that all usages have been converted to user lookup helpers.
Signed-off-by: Marc-André Lureau
Message-Id: <20170822132255.23945-14-marcandre.lur...@redhat.com>
[Rebased, superfluous local variable dropped, missing
check-qom-proplist.c update added]
Signed-off-by: Mark
Cc: "Daniel P. Berrange"
Signed-off-by: Markus Armbruster
---
crypto/block-luks.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/crypto/block-luks.c b/crypto/block-luks.c
index afb8543..c3cacdb 100644
--- a/crypto/block-luks.c
+++ b/crypto/block-luks.c
@
Signed-off-by: Markus Armbruster
---
hw/core/qdev-properties.c | 7 +--
qapi/qapi-visit-core.c| 2 +-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 078fc5d..7512bd4 100644
--- a/hw/core/qdev-properties.c
+++ b/hw
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.txt | 47 +++-
1 file changed, 38 insertions(+), 9 deletions(-)
diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt
index 9903ac4..ae05327 100644
--- a/docs/devel/qapi-code-
The lookup tables have a sentinel, no need to make callers pass their
size.
Fun: the header has it in the wrong position. Good riddance.
Signed-off-by: Markus Armbruster
---
block.c | 1 -
block/file-posix.c | 7 +++
block/file-win32.c | 2 +-
block/gluster.
On 24/08/2017 09:42, Markus Armbruster wrote:
>
> In a language less primitive than C, I'd write it exactly that way, and
> nobody would complain. In old, primitive C, I have to write
>
> global_qtest = A;
> do this
> do that
>
> global_qtest = B;
> do something
>
> glo
From: Marc-André Lureau
The error message on invalid capability name changes from
Invalid parameter "NAME"
to
invalid parameter value: NAME
No worse than before.
Signed-off-by: Marc-André Lureau
Message-Id: <20170822132255.23945-9-marcandre.lur...@redhat.com>
Reviewed-by: Markus Arm
在 2017/8/24 下午3:13, Cornelia Huck 写道:
On Thu, 24 Aug 2017 13:20:12 +0800
Yi Min Zhao wrote:
Why can't I receive [Qemu-devel] prefixed patches?
在 2017/8/23 下午3:26, Yi Min Zhao 写道:
This patch set contains four small zpci patches to fixup different issues.
1) fixup calculation of msix bounda
On Wed, 2017-08-23 at 23:16 +0300, Marcel Apfelbaum wrote:
> > Is such a configuration considered valid?
>
> Definitely no.
>
> > Or should
> > libvirt and the guest OS / firmware start allowing it?
>
> I thought libvirt does not allow it anyway and yes, is a bug,
> but considered low priority.
From: Marc-André Lureau
The error message on invalid parameter name changes from
Invalid parameter "NAME"
to
invalid parameter value: NAME
Slight degratation, perhaps.
Signed-off-by: Marc-André Lureau
Message-Id: <20170822132255.23945-10-marcandre.lur...@redhat.com>
Reviewed-by: Mar
From: Marc-André Lureau
Currently, a FOO_lookup is an array of strings terminated by a NULL
sentinel.
A future patch will generate enums with "holes". NULL-termination
will cease to work then.
To prepare for that, store the length in the FOO_lookup by wrapping it
in a struct and adding a membe
Signed-off-by: Markus Armbruster
---
backends/hostmem.c | 2 +-
block/backup.c | 2 +-
block/file-posix.c | 4 +--
block/file-win32.c | 2 +-
block/gluster.c | 4 +--
block/iscsi.c
On Thu, 24 Aug 2017 09:43:48 +0200
Christian Borntraeger wrote:
> On 08/24/2017 09:38 AM, Christian Borntraeger wrote:
> >
> >
> > On 08/23/2017 05:54 PM, Cornelia Huck wrote:
> >> Some non-pci code calls into zpci code. Provide some stubs for builds
> >> without pci.
> >>
> >> Reviewed-by: T
* Chris Friesen (chris.frie...@windriver.com) wrote:
>
> Hi all,
>
> I need to apologize up front, this is going to be a long email. Basically
> the executive summary is that we're seeing issues where a VM is apparently
> not making forward progress in the guest, while at the same time spinning
Instead pass around the address (aka offset into vga memory).
Add vga_read_* helper functions which apply vbe_size_mask to
the address, to make sure the address stays within the valid
range, simliar to the cirrus blitter fixes (commits ffaf857778
and 026aeffcb4).
Impact: DoS for priviledged guest
On Wed, 23 Aug 2017 14:58:39 -0300
Eduardo Habkost wrote:
> On Wed, Aug 23, 2017 at 07:37:39PM +0200, Igor Mammedov wrote:
> > On Wed, 23 Aug 2017 13:46:38 -0300
> > Eduardo Habkost wrote:
> >
> > > On Wed, Aug 23, 2017 at 06:29:02PM +0200, Igor Mammedov wrote:
> > > > On Wed, 23 Aug 2017 1
vga display update mis-calculated the region for the dirty bitmap
snapshot in case split screen mode is used. This can trigger an
assert in cpu_physical_memory_snapshot_get_dirty().
Impact: DoS for priviledged guest users.
Fixes: CVE-2017-
Fixes: fec5e8c92becad223df9d972770522f64aafdb72
Cc:
On Wed, 08/23 17:15, Kamil Rytarowski wrote:
> On 22.08.2017 06:41, Fam Zheng wrote:
> > The image is prepared following instructions as in:
> >
> > https://wiki.qemu.org/Hosts/BSD
> >
> > Signed-off-by: Fam Zheng
> > Reviewed-by: Kamil Rytarowski
> > ---
> > tests/vm/netbsd | 45 +
On Tue, 08/22 16:33, Kamil Rytarowski wrote:
> I propose to rename *bsd.img.xz (like netbsd.img.xz) to
> *bsd-version-arch.img.xz, like netbsd-7.1-amd64.img.xz. This will be
> more verbose about the version and leave room for image upgrades in future.
Good idea, will update.
Fam
On 08/23/2017 05:54 PM, Cornelia Huck wrote:
> If we do not provide zpci, pci reconfiguration via sclp is not available
> either. I/O adapter configuration, however, should always be present.
>
> Rename the values that refer to I/O adapter configuration (instead of only
> pci) to make things cle
On Thu, 24 Aug 2017 11:29:47 +0200
Halil Pasic wrote:
> On 08/23/2017 05:54 PM, Cornelia Huck wrote:
> > If we do not provide zpci, pci reconfiguration via sclp is not available
> > either. I/O adapter configuration, however, should always be present.
> >
> > Rename the values that refer to I/O
On 21/08/17 15:50, Alexey Kardashevskiy wrote:
> On 21/08/17 14:31, David Gibson wrote:
>> On Fri, Aug 18, 2017 at 02:18:53PM +0100, Stefan Hajnoczi wrote:
>>> On Fri, Aug 18, 2017 at 03:39:20PM +1000, Alexey Kardashevskiy wrote:
==94451== 4 of 10
On 08/24/2017 11:09 AM, Cornelia Huck wrote:
> On Thu, 24 Aug 2017 09:43:48 +0200
> Christian Borntraeger wrote:
>
>> On 08/24/2017 09:38 AM, Christian Borntraeger wrote:
>>>
>>>
>>> On 08/23/2017 05:54 PM, Cornelia Huck wrote:
Some non-pci code calls into zpci code. Provide some stubs f
>>> On 24.08.17 at 11:47, wrote:
> @@ -274,7 +278,7 @@ int xen_pt_msi_update(XenPCIPassthroughState *s)
> {
> XenPTMSI *msi = s->msi;
> return msi_msix_update(s, msi_addr64(msi), msi->data, msi->pirq,
> - false, 0, &msi->pirq);
> + fal
Markus Armbruster writes:
> From: Marc-André Lureau
>
> Currently, a FOO_lookup is an array of strings terminated by a NULL
> sentinel.
>
> A future patch will generate enums with "holes". NULL-termination
> will cease to work then.
>
> To prepare for that, store the length in the FOO_lookup by
On Thu, 24 Aug 2017 11:50:54 +0200
Halil Pasic wrote:
> On 08/24/2017 11:09 AM, Cornelia Huck wrote:
> > On Thu, 24 Aug 2017 09:43:48 +0200
> > Christian Borntraeger wrote:
> >
> >> On 08/24/2017 09:38 AM, Christian Borntraeger wrote:
> >>>
> >>>
> >>> On 08/23/2017 05:54 PM, Cornelia Huck
QEMU currently aborts if the user tries to create a skey device:
$ s390x-softmmu/qemu-system-s390x -nographic -device s390-skeys-qemu
qemu-system-s390x: hw/s390x/s390-skeys.c:30: s390_get_skeys_device:
Assertion `ss' failed.
Aborted (core dumped)
The storage key devices are only meant to be inst
Paolo Bonzini writes:
> On 24/08/2017 09:42, Markus Armbruster wrote:
>>
>> In a language less primitive than C, I'd write it exactly that way, and
>> nobody would complain. In old, primitive C, I have to write
>>
>> global_qtest = A;
>> do this
>> do that
>>
>> global_qtest =
>>> On 24.08.17 at 12:06, wrote:
> On Thu, Aug 24, 2017 at 03:54:21AM -0600, Jan Beulich wrote:
>> >>> On 24.08.17 at 11:47, wrote:
>> > @@ -274,7 +278,7 @@ int xen_pt_msi_update(XenPCIPassthroughState *s)
>> > {
>> > XenPTMSI *msi = s->msi;
>> > return msi_msix_update(s, msi_addr64(ms
If the alg is GCRY_CIPHER_AES256 and length of data to be encrypted is
multiple of 16 (16/32/48...),the length of encryted data is equal to the
raw data. There is no padding and the bug is triggerd.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscri
When a MSIX interrupt is bound to a guest using
xc_domain_update_msi_irq (XEN_DOMCTL_bind_pt_irq) the interrupt is
left masked by default.
This causes problems with guests that first configure interrupts and
clean the per-entry MSIX table mask bit and afterwards enable MSIX
globally. In such scena
On 24/08/2017 12:09, Markus Armbruster wrote:
> Cut-and-paste cuts both ways (pardon the pun):
>
> initialize with QTestState A
> frobnicate with QTestState A
> glomnify with QTestState A
> frobnicate with QTestState A
> initialize with QTestState B
> boingboing with QTestS
Hi,
> > How big?
>
> The ArmVirtQemu firmware binary, and its matching varstore template,
> need to be padded to 64MB each, after the edk2 build process
> completes,
> before the fw binary, and a variable store created from the varstore
> template, can be passed to QEMU.
>
> So, "pretty big".
On Thu, 24 Aug 2017 12:08:48 +0200
Thomas Huth wrote:
> QEMU currently aborts if the user tries to create a skey device:
>
> $ s390x-softmmu/qemu-system-s390x -nographic -device s390-skeys-qemu
> qemu-system-s390x: hw/s390x/s390-skeys.c:30: s390_get_skeys_device:
> Assertion `ss' failed.
> Abor
A step towards completeness.
Signed-off-by: Marc-André Lureau
---
include/qapi/qmp/qdict.h | 4 +++-
target/i386/cpu.c| 4 ++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/qapi/qmp/qdict.h b/include/qapi/qmp/qdict.h
index 363e431106..6588c7f0c8 100644
--- a/inc
Hi,
This series is based on patches 2-5 from "[PATCH v2 00/54] qapi: add #if
pre-processor conditions to generated code". Generating a literal qobject
will allow to easily introduce #if conditionals from the original series.
Marc-André Lureau (14):
qdict: add qdict_put_null() helper
qlit: mov
Use qlit_ prefix.
Signed-off-by: Marc-André Lureau
---
include/qapi/qmp/qlit.h | 2 +-
qobject/qlit.c | 6 +++---
tests/check-qjson.c | 14 +++---
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h
index 1e969
Fix code style issues while at it, to please check-patch.
Signed-off-by: Marc-André Lureau
---
include/qapi/qmp/qlit.h | 49 +
qobject/qlit.c | 89 +
tests/check-qjson.c | 96 +---
Signed-off-by: Marc-André Lureau
---
include/qapi/qmp/qlit.h | 2 +-
qobject/qlit.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h
index 2e22d0f73c..8882016199 100644
--- a/include/qapi/qmp/qlit.h
+++ b/include/qap
Rename from LiteralQ to QLit.
Signed-off-by: Marc-André Lureau
---
include/qapi/qmp/qlit.h | 24
qobject/qlit.c | 4 ++--
tests/check-qjson.c | 40
3 files changed, 34 insertions(+), 34 deletions(-)
diff --git a/inc
And misc code style fix.
Signed-off-by: Marc-André Lureau
---
include/qapi/qmp/qlit.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h
index f36bca4554..1e9696988a 100644
--- a/include/qapi/qmp/qlit.h
+++ b/include/qapi
As they are going to be used in the following patches.
Signed-off-by: Marc-André Lureau
---
include/qapi/qmp/qlit.h | 5 +
qobject/qlit.c | 4
2 files changed, 9 insertions(+)
diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h
index 8882016199..7118fc9e32 100644
--
Make it more obvious about the expected return values.
Signed-off-by: Marc-André Lureau
---
include/qapi/qmp/qlit.h | 2 +-
qobject/qlit.c | 18 +-
tests/check-qjson.c | 14 +++---
3 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/include/qapi
Fail if the QLit dict doesn't match exactly the object dict.
To do so, create a copy of the original qdict, and remove the checked
elements. Verify that the dict is empty by the end of the comparison.
Signed-off-by: Marc-André Lureau
---
qobject/qlit.c | 42 -
On 08/24/2017 12:08 PM, Thomas Huth wrote:
> QEMU currently aborts if the user tries to create a skey device:
>
> $ s390x-softmmu/qemu-system-s390x -nographic -device s390-skeys-qemu
> qemu-system-s390x: hw/s390x/s390-skeys.c:30: s390_get_skeys_device:
> Assertion `ss' failed.
> Aborted (core d
qnum_get_int() will assert if underlying type isn't compatible.
Signed-off-by: Marc-André Lureau
---
qobject/qlit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qobject/qlit.c b/qobject/qlit.c
index 07ad6b05e8..7e4bf92862 100644
--- a/qobject/qlit.c
+++ b/qobject/qlit.c
@@
Signed-off-by: Marc-André Lureau
---
tests/check-qlit.c | 64 ++
tests/Makefile.include | 5 +++-
2 files changed, 68 insertions(+), 1 deletion(-)
create mode 100644 tests/check-qlit.c
diff --git a/tests/check-qlit.c b/tests/check-qlit.c
new
On Thu, Aug 24, 2017 at 10:55 AM Markus Armbruster
wrote:
> Signed-off-by: Markus Armbruster
>
Reviewed-by: Marc-André Lureau
(tbh, I find it tedious and not really useful to have generated code in the
doc though)
---
> docs/devel/qapi-code-gen.txt | 47
> ++
On Thu, Aug 24, 2017 at 03:54:21AM -0600, Jan Beulich wrote:
> >>> On 24.08.17 at 11:47, wrote:
> > @@ -274,7 +278,7 @@ int xen_pt_msi_update(XenPCIPassthroughState *s)
> > {
> > XenPTMSI *msi = s->msi;
> > return msi_msix_update(s, msi_addr64(msi), msi->data, msi->pirq,
> > -
Check that the QLit list has the same size as the qlist, this should
ensure that we have an exact match when iterating over qlist for
comparing the elements.
Signed-off-by: Marc-André Lureau
---
qobject/qlit.c | 39 ++-
tests/check-qlit.c | 3 +++
2 files
Signed-off-by: Marc-André Lureau
---
include/qapi/qmp/qlit.h | 2 ++
qobject/qlit.c | 37 +
tests/check-qlit.c | 26 ++
3 files changed, 65 insertions(+)
diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h
inde
Replace the generated json string with a literal qobject. The later is
easier to deal with, at run time as well as compile time: adding #if
conditionals will be easier than in a json string.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
---
scripts/qapi-introspect.py |
- Original Message -
> Check that the QLit list has the same size as the qlist, this should
> ensure that we have an exact match when iterating over qlist for
> comparing the elements.
>
> Signed-off-by: Marc-André Lureau
> ---
> qobject/qlit.c | 39 ++--
Hi
On Thu, Aug 24, 2017 at 10:45 AM, Markus Armbruster wrote:
> We have a strict separation between enum TpmModel and tpm_models[]:
>
> * TpmModel may have any number of members. It just happens to have one.
>
> * tpm_register_model() uses the first empty slot in tmp_models[].
>
> If you regis
On Thu, Aug 24, 2017 at 04:13:58AM -0600, Jan Beulich wrote:
> >>> On 24.08.17 at 12:06, wrote:
> > On Thu, Aug 24, 2017 at 03:54:21AM -0600, Jan Beulich wrote:
> >> >>> On 24.08.17 at 11:47, wrote:
> >> > @@ -274,7 +278,7 @@ int xen_pt_msi_update(XenPCIPassthroughState *s)
> >> > {
> >> >
On Thu, Aug 24, 2017 at 10:45 AM, Markus Armbruster wrote:
> The lookup tables have a sentinel, no need to make callers pass their
> size.
>
> Fun: the header has it in the wrong position. Good riddance.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> block.c
On Thu, Aug 24, 2017 at 10:46 AM, Markus Armbruster wrote:
> Cc: "Daniel P. Berrange"
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> crypto/block-luks.c | 19 +++
> 1 file changed, 7 insertions(+), 12 deletions(-)
>
> diff --git a/crypto/block-luks
Hi,
> Having all our precompiled blobs be in a submodule would
> maybe be handy for properly keeping them separate from the
> QEMU code -- would that be useful for downstream distro
> packagers?
I like the clear separation.
Also you don't have to fetch the firmware submodule if you don't need
On Thu, 24 Aug 2017 09:49:18 +0200
Christian Borntraeger wrote:
> As there are only minor things left,
> whole series
>
> Acked-by: Christian Borntraeger
Thanks.
I've applied this to s390-next.
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote:
> Hi
>
> - Original Message -
> > Marc-André Lureau writes:
> >
> > > This will help with the introduction of a new structure to handle
> > > enum lookup.
It would be good to make that comment explain why it's necessary.
> > > Si
Hello Samuel,
+-- On Wed, 23 Aug 2017, Samuel Thibault wrote --+
| The paste is not available any more. Is it really very large? It's usually
| really better to just send it by mail, so it's archived in the mailing list
| etc.
Yes, stack-trace was quite long.
===
==2704==ERROR: AddressSaniti
On Thu, 24 Aug 2017 12:08:48 +0200
Thomas Huth wrote:
> QEMU currently aborts if the user tries to create a skey device:
>
> $ s390x-softmmu/qemu-system-s390x -nographic -device s390-skeys-qemu
> qemu-system-s390x: hw/s390x/s390-skeys.c:30: s390_get_skeys_device:
> Assertion `ss' failed.
> Abor
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote:
> Signed-off-by: Marc-André Lureau
> ---
> hmp.c | 24 +++-
> 1 file changed, 11 insertions(+), 13 deletions(-)
>
> diff --git a/hmp.c b/hmp.c
> index 29e42ab661..4ba50e8e26 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1544
1 - 100 of 360 matches
Mail list logo
